[Tomcat Wiki] Update of LocalBadContent by KonstantinKolinko

2011-11-22 Thread Apache Wiki
Dear Wiki user,

You have subscribed to a wiki page or wiki category on Tomcat Wiki for change 
notification.

The LocalBadContent page has been changed by KonstantinKolinko:
http://wiki.apache.org/tomcat/LocalBadContent?action=diffrev1=37rev2=38

Comment:
Add spam URL from walterjames page

  j\-cellular
  kogaryu\.com
  konferenzdolmetscher\.over-blog\.de
+ kreditkarte\.com
  levidus\.com
  lo\.lee\.tv
  mailin\.fr

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



buildbot failure in ASF Buildbot on tomcat-trunk

2011-11-22 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building 
ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/tomcat-trunk/builds/2542

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: bb-vm_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch tomcat/trunk] 1205033
Blamelist: kkolinko

BUILD FAILED: failed compile_1

sincerely,
 -The Buildbot





[GUMP@vmgump]: Project tomcat-tc7.0.x-test (in module tomcat-7.0.x) failed

2011-11-22 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-tc7.0.x-test has an issue affecting its community integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-tc7.0.x-test :  Tomcat 7.x, a web server implementing Java Servlet 
3.0,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-test/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on tomcat-tc7.0.x-dbcp exists, no need to add for property 
tomcat-dbcp-src.jar.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -DEBUG- Dependency on tomcat-tc7.0.x-dbcp exists, no need to add for property 
tomcat-dbcp.home.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-7.0.x/output/build/logs



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-test/gump_work/build_tomcat-7.0.x_tomcat-tc7.0.x-test.html
Work Name: build_tomcat-7.0.x_tomcat-tc7.0.x-test (Type: Build)
Work ended in a state of : Failed
Elapsed: 17 mins 55 secs
Command Line: /usr/lib/jvm/java-6-openjdk/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/dist/junit-22112011.jar 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-22112011-native-src.tar.gz
 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-22112011-native-src.tar.gz
 -Dexamples.sources.skip=true 
-Dtomcat-dbcp.home=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/org.eclipse.jdt.core_3.4.2/jdtcore.jar
 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-22112011.jar
 
-Dtomcat-dbcp-src.jar=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps/tomcat-dbcp-src.jar
 -Dcommons-pool.home=/srv/gump/public/workspace/commons-pool-1.x 
-Dcommons-dbcp.home=/srv/gump/public/worksp
 ace/commons-dbcp-1.x 
-Dtomcat-dbcp.jar=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps/tomcat-dbcp-22112011.jar
 test 
[Working Directory: /srv/gump/public/workspace/tomcat-7.0.x]
CLASSPATH: 
/usr/lib/jvm/java-6-openjdk/lib/tools.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-7.0.x/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/servlet-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/outp
 
ut/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-util.jar:/srv/gump/packages/javamail-1.4/mail.jar:/srv/gump/packages/javamail-1.4/lib/mailapi.jar:/srv/gump/packages/jaf-1.1ea/activation.jar:/srv/gump/packages/eclipse/plugins/org.eclipse.jdt.core_3.4.2/jdtcore.jar:/srv/gump/public/workspace/tomcat-7.
 
0.x/tomcat-deps/tomcat-dbcp-22112011.jar:/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-22112011.jar:/srv/gump/public/workspace/junit/dist/junit-22112011.jar

Re: tagging 6.0.34 tomorrow?

2011-11-22 Thread Forrest Xia
On Tue, Nov 22, 2011 at 4:39 PM, Konstantin Kolinko
knst.koli...@gmail.comwrote:

 2011/11/22 Forrest Xia forres...@gmail.com:
  Any update on 6.0.34 vote? Geronimo would like to have it in the coming
  2.1.8 release.

 6.0.34 is broken.

Thank you for update, so broken for what reason? Can you share here?

 Timing for 6.0.35 is yet to be decided. There is 7.0.23 vote right now.

I noticed 7.0.23 is voting, then, when 6.0.35 could be out? one week or two
weeks?

Thanks for your patience :)


 Best regards,
 Konstantin Kolinko

 -
 To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
 For additional commands, e-mail: dev-h...@tomcat.apache.org




-- 
Thanks!

Regards, Forrest


svn commit: r1205065 - in /tomcat/trunk: java/org/apache/catalina/filters/RemoteIpFilter.java java/org/apache/catalina/valves/RemoteIpValve.java webapps/docs/config/filter.xml webapps/docs/config/valv

2011-11-22 Thread kkolinko
Author: kkolinko
Date: Tue Nov 22 16:28:38 2011
New Revision: 1205065

URL: http://svn.apache.org/viewvc?rev=1205065view=rev
Log:
Correct request attribute names mentioned in RemoteIpFilter/RemoteIpValve 
javadoc
and mention them in documentation.

Modified:
tomcat/trunk/java/org/apache/catalina/filters/RemoteIpFilter.java
tomcat/trunk/java/org/apache/catalina/valves/RemoteIpValve.java
tomcat/trunk/webapps/docs/config/filter.xml
tomcat/trunk/webapps/docs/config/valve.xml

Modified: tomcat/trunk/java/org/apache/catalina/filters/RemoteIpFilter.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/filters/RemoteIpFilter.java?rev=1205065r1=1205064r2=1205065view=diff
==
--- tomcat/trunk/java/org/apache/catalina/filters/RemoteIpFilter.java (original)
+++ tomcat/trunk/java/org/apache/catalina/filters/RemoteIpFilter.java Tue Nov 
22 16:28:38 2011
@@ -1104,10 +1104,10 @@ public class RemoteIpFilter implements F
  *
  * The attributes set are:
  * ul
- * liorg.apache.catalina.RemoteAddr/li
- * liorg.apache.catalina.RemoteHost/li
- * liorg.apache.catalina.Protocol/li
- * liorg.apache.catalina.ServerPost/li
+ * liorg.apache.catalina.AccessLog.RemoteAddr/li
+ * liorg.apache.catalina.AccessLog.RemoteHost/li
+ * liorg.apache.catalina.AccessLog.Protocol/li
+ * liorg.apache.catalina.AccessLog.ServerPort/li
  * /ul
  *
  * @param requestAttributesEnabled  codetrue/code causes the attributes

Modified: tomcat/trunk/java/org/apache/catalina/valves/RemoteIpValve.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/RemoteIpValve.java?rev=1205065r1=1205064r2=1205065view=diff
==
--- tomcat/trunk/java/org/apache/catalina/valves/RemoteIpValve.java (original)
+++ tomcat/trunk/java/org/apache/catalina/valves/RemoteIpValve.java Tue Nov 22 
16:28:38 2011
@@ -810,10 +810,10 @@ public class RemoteIpValve extends Valve
  *
  * The attributes set are:
  * ul
- * liorg.apache.catalina.RemoteAddr/li
- * liorg.apache.catalina.RemoteHost/li
- * liorg.apache.catalina.Protocol/li
- * liorg.apache.catalina.ServerPost/li
+ * liorg.apache.catalina.AccessLog.RemoteAddr/li
+ * liorg.apache.catalina.AccessLog.RemoteHost/li
+ * liorg.apache.catalina.AccessLog.Protocol/li
+ * liorg.apache.catalina.AccessLog.ServerPort/li
  * /ul
  *
  * @param requestAttributesEnabled  codetrue/code causes the attributes

Modified: tomcat/trunk/webapps/docs/config/filter.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/filter.xml?rev=1205065r1=1205064r2=1205065view=diff
==
--- tomcat/trunk/webapps/docs/config/filter.xml (original)
+++ tomcat/trunk/webapps/docs/config/filter.xml Tue Nov 22 16:28:38 2011
@@ -700,6 +700,16 @@ FINE: Request /docs/config/manager.html
 coderequestAttributesEnabled/code attribute of
 codeAccessLogValve/code./p
 
+pThe names of request attributes that are set by this filter
+and can be used by access logging are the following:/p
+
+ul
+  licodeorg.apache.catalina.AccessLog.RemoteAddr/code/li
+  licodeorg.apache.catalina.AccessLog.RemoteHost/code/li
+  licodeorg.apache.catalina.AccessLog.Protocol/code/li
+  licodeorg.apache.catalina.AccessLog.ServerPort/code/li
+/ul
+
   /subsection
 
   subsection name=Filter Class Name

Modified: tomcat/trunk/webapps/docs/config/valve.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/valve.xml?rev=1205065r1=1205064r2=1205065view=diff
==
--- tomcat/trunk/webapps/docs/config/valve.xml (original)
+++ tomcat/trunk/webapps/docs/config/valve.xml Tue Nov 22 16:28:38 2011
@@ -1262,6 +1262,16 @@
 coderequestAttributesEnabled/code attribute of
 codeAccessLogValve/code./p
 
+pThe names of request attributes that are set by this valve
+and can be used by access logging are the following:/p
+
+ul
+  licodeorg.apache.catalina.AccessLog.RemoteAddr/code/li
+  licodeorg.apache.catalina.AccessLog.RemoteHost/code/li
+  licodeorg.apache.catalina.AccessLog.Protocol/code/li
+  licodeorg.apache.catalina.AccessLog.ServerPort/code/li
+/ul
+
   /subsection
 
   subsection name=Attributes



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: tagging 6.0.34 tomorrow?

2011-11-22 Thread jean-frederic clere

On 11/22/2011 05:08 PM, Forrest Xia wrote:

On Tue, Nov 22, 2011 at 4:39 PM, Konstantin Kolinko
knst.koli...@gmail.comwrote:


2011/11/22 Forrest Xiaforres...@gmail.com:

Any update on 6.0.34 vote? Geronimo would like to have it in the coming
2.1.8 release.


6.0.34 is broken.


Thank you for update, so broken for what reason? Can you share here?


Timing for 6.0.35 is yet to be decided. There is 7.0.23 vote right now.


I noticed 7.0.23 is voting, then, when 6.0.35 could be out? one week or two
weeks?


I will tag after 7.0.23 is announced so except a release next week.

Cheers

Jean-Frederic

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1205067 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/filters/RemoteIpFilter.java java/org/apache/catalina/valves/RemoteIpValve.java webapps/docs/changelog.xml webapps/docs/conf

2011-11-22 Thread kkolinko
Author: kkolinko
Date: Tue Nov 22 16:31:46 2011
New Revision: 1205067

URL: http://svn.apache.org/viewvc?rev=1205067view=rev
Log:
Merged revisions r1205033 r1205065 from tomcat/trunk:
Add clarification to RemoteIpValve and RemoteIpValve that to use their 
IP/hostname/port/protocol values in access log you should properly configure 
your AccessLogValve.
Correct request attribute names mentioned in RemoteIpFilter/RemoteIpValve 
javadoc and mention them in documentation.

Modified:
tomcat/tc7.0.x/trunk/   (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/catalina/filters/RemoteIpFilter.java
tomcat/tc7.0.x/trunk/java/org/apache/catalina/valves/RemoteIpValve.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
tomcat/tc7.0.x/trunk/webapps/docs/config/filter.xml
tomcat/tc7.0.x/trunk/webapps/docs/config/valve.xml

Propchange: tomcat/tc7.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Tue Nov 22 16:31:46 2011
@@ -1 +1 @@
-/tomcat/trunk:1156115,1156171,1156276,1156304,1156519,1156530,1156602,1157015,1157018,1157151,1157198,1157204,1157810,1157832,1157834,1157847,1157908,1157939,1158155,1158160,1158176,1158195,1158198-1158199,1158227,1158331,1158334-1158335,1158426,1160347,1160592,1160611,1160619,1160626,1160639,1160652,1160720-1160721,1160772,1160774,1160776,1161303,1161310,1161322,1161339,1161486,1161540,1161549,1161584,1162082,1162149,1162169,1162721,1162769,1162836,1162932,1163630,1164419,1164438,1164469,1164480,1164567,1165234,1165247-1165248,1165253,1165273,1165282,1165309,1165331,1165338,1165347,1165360-1165361,1165367-1165368,1165602,1165608,1165677,1165693,1165721,1165723,1165728,1165730,1165738,1165746,1165765,1165777,1165918,1165921,1166077,1166150-1166151,1166290,1166366,1166620,1166686,1166693,1166752,1166757,1167368,1167394,1169447,1170647,1171692,1172233-1172234,1172236,1172269,1172278,1172282,1172556,1172610,1172664,1172689,1172711,1173020-1173021,1173082,1173088,1173090,1173096
 
,1173241,1173256,1173288,117,1173342,1173461,1173614,1173630,1173659,1173722,1174061,1174239,1174322,1174325,1174329-1174330,1174337-1174339,1174343,1174353,1174799,1174882,1174884,1174983,1175155,1175158,1175167,1175182,1175190,1175201,1175272,1175275,1175283,1175582,1175589-1175590,1175594,1175602,1175613,1175633,1175690,1175713,1175798,1175889,1175896,1175907,1176584,1176590,1176799,1177050,1177060,1177125,1177152,1177160,1177245,1177850,1177862,1177978,1178209,1178228,1178233,1178449,1178542,1178681,1178684,1178721,1179268,1179274,1180261,1180865,1180891,1180894,1180907,1181028,1181123,1181125,1181136,1181291,1181743,1182796,1183078,1183105,1183142,1183328,1183339-1183340,1183492-1183494,1183605,1184917,1184919,1185018,1185020,1185200,1185588,1185626,1185756,1185758,1186011,1186042-1186045,1186104,1186123,1186137,1186153,1186254,1186257,1186377-1186379,1186479-1186480,1186712,1186743,1186750,1186763,1186890-1186892,1186894,1186949,1187018,1187027-1187028,1187381,1187
 
753,1187755,1187775,1187801,1187806,1187809,1187827,1188301,1188303-1188305,1188399,1188822,1188930-1188931,1189116,1189129,1189183,1189240,1189256,1189386,1189413-1189414,1189477,1189685,1189805,1189857,1189864,1189882,1190034,1190185,1190279,1190339,1190371,1190388-1190389,1190474,1190481,1194915,1195222-1195223,1195531,1195899,1195905,1195943,1195949,1195953,1195955,1195965,1195968,1196175,1196212,1196223,1196304-1196305,1196735,1196825,1196827,1197158,1197261,1197263,1197299-1197300,1197305,1197339-1197340,1197343,1197382,1197386-1197387,1197480,1197578,1198497,1198528,1198552,1198602,1198604,1198607,1198622,1198640,1198696,1198707,1199418,1199432,1199436,1199513,1199529,1199980,116,1200056,1200089,1200106-1200107,1200263,1200316,1200320,1200398-1200399,1200445-1200446,1200555,1200627,1200696,1200725,1200937,1200941,1201069,1201087,1201180,1201235-1201237,1201508,1201521,1201542,1201545-1201546,1201548,1201555-1201556,1201568,1201576,1201608,1201921-1201922,1201931,1
 
202035,1202039,1202271,1202565,1202578,1202705,1202828,1202860,1203047-1203052,1203078,1203091,1203253,1203278,1204182,1204856,1204867,1204936,1204938,1204982

DO NOT REPLY [Bug 45931] trimSpaces incorrectly modifies output

2011-11-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45931

Sylvain Laurent slaur...@apache.org changed:

   What|Removed |Added

 CC||slaur...@apache.org

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



buildbot success in ASF Buildbot on tomcat-trunk

2011-11-22 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while 
building ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/tomcat-trunk/builds/2543

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: bb-vm_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch tomcat/trunk] 1205065
Blamelist: kkolinko

Build succeeded!

sincerely,
 -The Buildbot





svn commit: r1205082 - /tomcat/trunk/test/org/apache/catalina/connector/TestMaxConnections.java

2011-11-22 Thread kkolinko
Author: kkolinko
Date: Tue Nov 22 17:05:58 2011
New Revision: 1205082

URL: http://svn.apache.org/viewvc?rev=1205082view=rev
Log:
TestMaxConnections: improve log messages printed by this test.
Do not use SEVERE level. Print introductory message about what logging output 
is expected.
Use port number as configured by TomcatBaseTest (8001) instead of hardcoded 
8080.

Modified:
tomcat/trunk/test/org/apache/catalina/connector/TestMaxConnections.java

Modified: 
tomcat/trunk/test/org/apache/catalina/connector/TestMaxConnections.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/connector/TestMaxConnections.java?rev=1205082r1=1205081r2=1205082view=diff
==
--- tomcat/trunk/test/org/apache/catalina/connector/TestMaxConnections.java 
(original)
+++ tomcat/trunk/test/org/apache/catalina/connector/TestMaxConnections.java Tue 
Nov 22 17:05:58 2011
@@ -31,16 +31,15 @@ import org.apache.catalina.Context;
 import org.apache.catalina.startup.SimpleHttpClient;
 import org.apache.catalina.startup.Tomcat;
 import org.apache.catalina.startup.TomcatBaseTest;
-import org.apache.juli.logging.Log;
-import org.apache.juli.logging.LogFactory;
 
 public class TestMaxConnections extends TomcatBaseTest {
-private static Log log = LogFactory.getLog(TestMaxConnections.class);
-static int soTimeout = 3000;
-static int connectTimeout = 1000;
+public static final int soTimeout = 3000;
+public static final int connectTimeout = 1000;
 
 @Test
 public void testConnector() throws Exception {
+log.info(This test tries to create 10 connections to connector 
++ that has maxConnections='4'. Expect half of them to fail.);
 init();
 ConnectThread[] t = new ConnectThread[10];
 int passcount = 0;
@@ -60,10 +59,11 @@ public class TestMaxConnections extends 
 }
 
 assertTrue(The number of successful requests should have been 4-5, 
actual +passcount,4==passcount || 5==passcount);
-System.out.println(There were [ + connectfail + ] connection 
failures);
+log.info(There were [ + passcount + ] passed requests and [
++ connectfail + ] connection failures);
 }
 
-private static class ConnectThread extends Thread {
+private class ConnectThread extends Thread {
 public boolean passed = true;
 public boolean connectfailed = false;
 @Override
@@ -73,7 +73,7 @@ public class TestMaxConnections extends 
 client.doHttp10Request();
 }catch (Exception x) {
 passed = false;
-log.error(Thread.currentThread().getName()+ 
Error:+x.getMessage());
+log.info(Thread.currentThread().getName()+ 
Error:+x.getMessage());
 connectfailed = connect timed out.equals(x.getMessage()) || 
Connection refused: connect.equals(x.getMessage());
 }
 }
@@ -89,15 +89,15 @@ public class TestMaxConnections extends 
 tomcat.getConnector().setProperty(maxThreads, 10);
 tomcat.getConnector().setProperty(soTimeout, 2);
 tomcat.getConnector().setProperty(keepAliveTimeout, 5);
-tomcat.getConnector().setProperty(port, 8080);
 tomcat.getConnector().setProperty(maxConnections, 4);
 tomcat.getConnector().setProperty(acceptCount, 1);
 tomcat.start();
 }
 
-private static class TestClient extends SimpleHttpClient {
+private class TestClient extends SimpleHttpClient {
 
 private void doHttp10Request() throws Exception {
+setPort(getPort());
 
 long start = System.currentTimeMillis();
 // Open connection



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1205086 - in /tomcat/tc7.0.x/trunk: ./ test/org/apache/catalina/connector/TestMaxConnections.java

2011-11-22 Thread kkolinko
Author: kkolinko
Date: Tue Nov 22 17:12:00 2011
New Revision: 1205086

URL: http://svn.apache.org/viewvc?rev=1205086view=rev
Log:
Merged revision 1205082 from tomcat/trunk:
TestMaxConnections: improve log messages printed by this test.
Do not use SEVERE level. Print introductory message about what logging output 
is expected.
Use port number as configured by TomcatBaseTest (8001) instead of hardcoded 
8080.

Modified:
tomcat/tc7.0.x/trunk/   (props changed)

tomcat/tc7.0.x/trunk/test/org/apache/catalina/connector/TestMaxConnections.java

Propchange: tomcat/tc7.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Tue Nov 22 17:12:00 2011
@@ -1 +1 @@
-/tomcat/trunk:1156115,1156171,1156276,1156304,1156519,1156530,1156602,1157015,1157018,1157151,1157198,1157204,1157810,1157832,1157834,1157847,1157908,1157939,1158155,1158160,1158176,1158195,1158198-1158199,1158227,1158331,1158334-1158335,1158426,1160347,1160592,1160611,1160619,1160626,1160639,1160652,1160720-1160721,1160772,1160774,1160776,1161303,1161310,1161322,1161339,1161486,1161540,1161549,1161584,1162082,1162149,1162169,1162721,1162769,1162836,1162932,1163630,1164419,1164438,1164469,1164480,1164567,1165234,1165247-1165248,1165253,1165273,1165282,1165309,1165331,1165338,1165347,1165360-1165361,1165367-1165368,1165602,1165608,1165677,1165693,1165721,1165723,1165728,1165730,1165738,1165746,1165765,1165777,1165918,1165921,1166077,1166150-1166151,1166290,1166366,1166620,1166686,1166693,1166752,1166757,1167368,1167394,1169447,1170647,1171692,1172233-1172234,1172236,1172269,1172278,1172282,1172556,1172610,1172664,1172689,1172711,1173020-1173021,1173082,1173088,1173090,1173096
 
,1173241,1173256,1173288,117,1173342,1173461,1173614,1173630,1173659,1173722,1174061,1174239,1174322,1174325,1174329-1174330,1174337-1174339,1174343,1174353,1174799,1174882,1174884,1174983,1175155,1175158,1175167,1175182,1175190,1175201,1175272,1175275,1175283,1175582,1175589-1175590,1175594,1175602,1175613,1175633,1175690,1175713,1175798,1175889,1175896,1175907,1176584,1176590,1176799,1177050,1177060,1177125,1177152,1177160,1177245,1177850,1177862,1177978,1178209,1178228,1178233,1178449,1178542,1178681,1178684,1178721,1179268,1179274,1180261,1180865,1180891,1180894,1180907,1181028,1181123,1181125,1181136,1181291,1181743,1182796,1183078,1183105,1183142,1183328,1183339-1183340,1183492-1183494,1183605,1184917,1184919,1185018,1185020,1185200,1185588,1185626,1185756,1185758,1186011,1186042-1186045,1186104,1186123,1186137,1186153,1186254,1186257,1186377-1186379,1186479-1186480,1186712,1186743,1186750,1186763,1186890-1186892,1186894,1186949,1187018,1187027-1187028,1187381,1187
 
753,1187755,1187775,1187801,1187806,1187809,1187827,1188301,1188303-1188305,1188399,1188822,1188930-1188931,1189116,1189129,1189183,1189240,1189256,1189386,1189413-1189414,1189477,1189685,1189805,1189857,1189864,1189882,1190034,1190185,1190279,1190339,1190371,1190388-1190389,1190474,1190481,1194915,1195222-1195223,1195531,1195899,1195905,1195943,1195949,1195953,1195955,1195965,1195968,1196175,1196212,1196223,1196304-1196305,1196735,1196825,1196827,1197158,1197261,1197263,1197299-1197300,1197305,1197339-1197340,1197343,1197382,1197386-1197387,1197480,1197578,1198497,1198528,1198552,1198602,1198604,1198607,1198622,1198640,1198696,1198707,1199418,1199432,1199436,1199513,1199529,1199980,116,1200056,1200089,1200106-1200107,1200263,1200316,1200320,1200398-1200399,1200445-1200446,1200555,1200627,1200696,1200725,1200937,1200941,1201069,1201087,1201180,1201235-1201237,1201508,1201521,1201542,1201545-1201546,1201548,1201555-1201556,1201568,1201576,1201608,1201921-1201922,1201931,1
 
202035,1202039,1202271,1202565,1202578,1202705,1202828,1202860,1203047-1203052,1203078,1203091,1203253,1203278,1204182,1204856,1204867,1204936,1204938,1204982,1205033,1205065
+/tomcat/trunk:1156115,1156171,1156276,1156304,1156519,1156530,1156602,1157015,1157018,1157151,1157198,1157204,1157810,1157832,1157834,1157847,1157908,1157939,1158155,1158160,1158176,1158195,1158198-1158199,1158227,1158331,1158334-1158335,1158426,1160347,1160592,1160611,1160619,1160626,1160639,1160652,1160720-1160721,1160772,1160774,1160776,1161303,1161310,1161322,1161339,1161486,1161540,1161549,1161584,1162082,1162149,1162169,1162721,1162769,1162836,1162932,1163630,1164419,1164438,1164469,1164480,1164567,1165234,1165247-1165248,1165253,1165273,1165282,1165309,1165331,1165338,1165347,1165360-1165361,1165367-1165368,1165602,1165608,1165677,1165693,1165721,1165723,1165728,1165730,1165738,1165746,1165765,1165777,1165918,1165921,1166077,1166150-1166151,1166290,1166366,1166620,1166686,1166693,1166752,1166757,1167368,1167394,1169447,1170647,1171692,1172233-1172234,1172236,1172269,1172278,1172282,1172556,1172610,1172664,1172689,1172711,1173020-1173021,1173082,1173088,1173090,1173096
 

svn commit: r1205097 - in /tomcat/trunk/java/org/apache/catalina/valves: AccessLogValve.java ExtendedAccessLogValve.java

2011-11-22 Thread kkolinko
Author: kkolinko
Date: Tue Nov 22 17:36:36 2011
New Revision: 1205097

URL: http://svn.apache.org/viewvc?rev=1205097view=rev
Log:
Correct typo in javadoc

Modified:
tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java
tomcat/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java

Modified: tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java?rev=1205097r1=1205096r2=1205097view=diff
==
--- tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java (original)
+++ tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java Tue Nov 22 
17:36:36 2011
@@ -122,7 +122,7 @@ import org.apache.tomcat.util.buf.B2CCon
  * For UNIX users, another field called codecheckExists/code is also
  * available. If set to true, the log file's existence will be checked before
  * each logging. This way an external log rotator can move the file
- * somewhere and tomcat will start with a new file.
+ * somewhere and Tomcat will start with a new file.
  * /p
  *
  * p

Modified: 
tomcat/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java?rev=1205097r1=1205096r2=1205097view=diff
==
--- tomcat/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java 
Tue Nov 22 17:36:36 2011
@@ -98,10 +98,10 @@ import org.apache.tomcat.util.ExceptionU
  * /p
  *
  * p
- * For UvNIX users, another field called codecheckExists/code is also
+ * For UNIX users, another field called codecheckExists/code is also
  * available. If set to true, the log file's existence will be checked before
  * each logging. This way an external log rotator can move the file
- * somewhere and tomcat will start with a new file.
+ * somewhere and Tomcat will start with a new file.
  * /p
  *
  * p



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1205100 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/valves/AccessLogValve.java java/org/apache/catalina/valves/ExtendedAccessLogValve.java

2011-11-22 Thread kkolinko
Author: kkolinko
Date: Tue Nov 22 17:41:18 2011
New Revision: 1205100

URL: http://svn.apache.org/viewvc?rev=1205100view=rev
Log:
Merged revision 1205097 from tomcat/trunk:
Correct typo in javadoc

Modified:
tomcat/tc7.0.x/trunk/   (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/catalina/valves/AccessLogValve.java

tomcat/tc7.0.x/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java

Propchange: tomcat/tc7.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Tue Nov 22 17:41:18 2011
@@ -1 +1 @@
-/tomcat/trunk:1156115,1156171,1156276,1156304,1156519,1156530,1156602,1157015,1157018,1157151,1157198,1157204,1157810,1157832,1157834,1157847,1157908,1157939,1158155,1158160,1158176,1158195,1158198-1158199,1158227,1158331,1158334-1158335,1158426,1160347,1160592,1160611,1160619,1160626,1160639,1160652,1160720-1160721,1160772,1160774,1160776,1161303,1161310,1161322,1161339,1161486,1161540,1161549,1161584,1162082,1162149,1162169,1162721,1162769,1162836,1162932,1163630,1164419,1164438,1164469,1164480,1164567,1165234,1165247-1165248,1165253,1165273,1165282,1165309,1165331,1165338,1165347,1165360-1165361,1165367-1165368,1165602,1165608,1165677,1165693,1165721,1165723,1165728,1165730,1165738,1165746,1165765,1165777,1165918,1165921,1166077,1166150-1166151,1166290,1166366,1166620,1166686,1166693,1166752,1166757,1167368,1167394,1169447,1170647,1171692,1172233-1172234,1172236,1172269,1172278,1172282,1172556,1172610,1172664,1172689,1172711,1173020-1173021,1173082,1173088,1173090,1173096
 
,1173241,1173256,1173288,117,1173342,1173461,1173614,1173630,1173659,1173722,1174061,1174239,1174322,1174325,1174329-1174330,1174337-1174339,1174343,1174353,1174799,1174882,1174884,1174983,1175155,1175158,1175167,1175182,1175190,1175201,1175272,1175275,1175283,1175582,1175589-1175590,1175594,1175602,1175613,1175633,1175690,1175713,1175798,1175889,1175896,1175907,1176584,1176590,1176799,1177050,1177060,1177125,1177152,1177160,1177245,1177850,1177862,1177978,1178209,1178228,1178233,1178449,1178542,1178681,1178684,1178721,1179268,1179274,1180261,1180865,1180891,1180894,1180907,1181028,1181123,1181125,1181136,1181291,1181743,1182796,1183078,1183105,1183142,1183328,1183339-1183340,1183492-1183494,1183605,1184917,1184919,1185018,1185020,1185200,1185588,1185626,1185756,1185758,1186011,1186042-1186045,1186104,1186123,1186137,1186153,1186254,1186257,1186377-1186379,1186479-1186480,1186712,1186743,1186750,1186763,1186890-1186892,1186894,1186949,1187018,1187027-1187028,1187381,1187
 
753,1187755,1187775,1187801,1187806,1187809,1187827,1188301,1188303-1188305,1188399,1188822,1188930-1188931,1189116,1189129,1189183,1189240,1189256,1189386,1189413-1189414,1189477,1189685,1189805,1189857,1189864,1189882,1190034,1190185,1190279,1190339,1190371,1190388-1190389,1190474,1190481,1194915,1195222-1195223,1195531,1195899,1195905,1195943,1195949,1195953,1195955,1195965,1195968,1196175,1196212,1196223,1196304-1196305,1196735,1196825,1196827,1197158,1197261,1197263,1197299-1197300,1197305,1197339-1197340,1197343,1197382,1197386-1197387,1197480,1197578,1198497,1198528,1198552,1198602,1198604,1198607,1198622,1198640,1198696,1198707,1199418,1199432,1199436,1199513,1199529,1199980,116,1200056,1200089,1200106-1200107,1200263,1200316,1200320,1200398-1200399,1200445-1200446,1200555,1200627,1200696,1200725,1200937,1200941,1201069,1201087,1201180,1201235-1201237,1201508,1201521,1201542,1201545-1201546,1201548,1201555-1201556,1201568,1201576,1201608,1201921-1201922,1201931,1
 
202035,1202039,1202271,1202565,1202578,1202705,1202828,1202860,1203047-1203052,1203078,1203091,1203253,1203278,1204182,1204856,1204867,1204936,1204938,1204982,1205033,1205065,1205082
+/tomcat/trunk:1156115,1156171,1156276,1156304,1156519,1156530,1156602,1157015,1157018,1157151,1157198,1157204,1157810,1157832,1157834,1157847,1157908,1157939,1158155,1158160,1158176,1158195,1158198-1158199,1158227,1158331,1158334-1158335,1158426,1160347,1160592,1160611,1160619,1160626,1160639,1160652,1160720-1160721,1160772,1160774,1160776,1161303,1161310,1161322,1161339,1161486,1161540,1161549,1161584,1162082,1162149,1162169,1162721,1162769,1162836,1162932,1163630,1164419,1164438,1164469,1164480,1164567,1165234,1165247-1165248,1165253,1165273,1165282,1165309,1165331,1165338,1165347,1165360-1165361,1165367-1165368,1165602,1165608,1165677,1165693,1165721,1165723,1165728,1165730,1165738,1165746,1165765,1165777,1165918,1165921,1166077,1166150-1166151,1166290,1166366,1166620,1166686,1166693,1166752,1166757,1167368,1167394,1169447,1170647,1171692,1172233-1172234,1172236,1172269,1172278,1172282,1172556,1172610,1172664,1172689,1172711,1173020-1173021,1173082,1173088,1173090,1173096
 

svn commit: r1205111 - in /tomcat/tc6.0.x/trunk/java/org/apache/catalina/valves: AccessLogValve.java ExtendedAccessLogValve.java

2011-11-22 Thread kkolinko
Author: kkolinko
Date: Tue Nov 22 17:54:15 2011
New Revision: 1205111

URL: http://svn.apache.org/viewvc?rev=1205111view=rev
Log:
CTR: javadoc
Correct typo and amend AccessLogValve javadoc

Modified:
tomcat/tc6.0.x/trunk/java/org/apache/catalina/valves/AccessLogValve.java

tomcat/tc6.0.x/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/valves/AccessLogValve.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/valves/AccessLogValve.java?rev=1205111r1=1205110r2=1205111view=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/catalina/valves/AccessLogValve.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/valves/AccessLogValve.java 
Tue Nov 22 17:54:15 2011
@@ -98,7 +98,9 @@ import org.apache.tomcat.util.buf.B2CCon
  * p
  * There is also support to write information from the cookie, incoming
  * header, the Session or something else in the ServletRequest.br
- * It is modeled after the apache syntax:
+ * It is modeled after the
+ * a href=http://httpd.apache.org/;Apache HTTP Server/a log configuration
+ * syntax:/p
  * ul
  * licode%{xxx}i/code for incoming headers
  * licode%{xxx}o/code for outgoing response headers
@@ -106,6 +108,23 @@ import org.apache.tomcat.util.buf.B2CCon
  * licode%{xxx}r/code xxx is an attribute in the ServletRequest
  * licode%{xxx}s/code xxx is an attribute in the HttpSession
  * /ul
+ *
+ * p
+ * Log rotation can be on or off. This is dictated by the
+ * coderotatable/code property.
+ * /p
+ *
+ * p
+ * For UNIX users, another field called codecheckExists/code is also
+ * available. If set to true, the log file's existence will be checked before
+ * each logging. This way an external log rotator can move the file
+ * somewhere and Tomcat will start with a new file.
+ * /p
+ *
+ * p
+ * For JMX junkies, a public method called coderotate/code has
+ * been made available to allow you to tell this instance to move
+ * the existing log file to somewhere else and start writing a new log file.
  * /p
  *
  * p

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java?rev=1205111r1=1205110r2=1205111view=diff
==
--- 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java
 (original)
+++ 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java
 Tue Nov 22 17:54:15 2011
@@ -91,19 +91,19 @@ import org.apache.juli.logging.LogFactor
  *
  *
  * p
- * Log rotation can be on or off. This is dictated by the rotatable
- * property.
+ * Log rotation can be on or off. This is dictated by the
+ * coderotatable/code property.
  * /p
  *
  * p
- * For UvNIX users, another field called codecheckExists/codeis also
+ * For UNIX users, another field called codecheckExists/codeis also
  * available. If set to true, the log file's existence will be checked before
  * each logging. This way an external log rotator can move the file
- * somewhere and tomcat will start with a new file.
+ * somewhere and Tomcat will start with a new file.
  * /p
  *
  * p
- * For JMX junkies, a public method called /coderotate/code has
+ * For JMX junkies, a public method called coderotate/code has
  * been made available to allow you to tell this instance to move
  * the existing log file to somewhere else start writing a new log file.
  * /p



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1205112 - in /tomcat/trunk/java/org/apache/catalina/valves: AccessLogValve.java ExtendedAccessLogValve.java

2011-11-22 Thread kkolinko
Author: kkolinko
Date: Tue Nov 22 17:59:49 2011
New Revision: 1205112

URL: http://svn.apache.org/viewvc?rev=1205112view=rev
Log:
Correct javadoc markup

Modified:
tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java
tomcat/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java

Modified: tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java?rev=1205112r1=1205111r2=1205112view=diff
==
--- tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java (original)
+++ tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java Tue Nov 22 
17:59:49 2011
@@ -103,7 +103,7 @@ import org.apache.tomcat.util.buf.B2CCon
  * header, the Session or something else in the ServletRequest.br
  * It is modeled after the
  * a href=http://httpd.apache.org/;Apache HTTP Server/a log configuration
- * syntax:
+ * syntax:/p
  * ul
  * licode%{xxx}i/code for incoming headers
  * licode%{xxx}o/code for outgoing response headers
@@ -111,11 +111,10 @@ import org.apache.tomcat.util.buf.B2CCon
  * licode%{xxx}r/code xxx is an attribute in the ServletRequest
  * licode%{xxx}s/code xxx is an attribute in the HttpSession
  * /ul
- * /p
  *
  * p
- * Log rotation can be on or off. This is dictated by the rotatable
- * property.
+ * Log rotation can be on or off. This is dictated by the
+ * coderotatable/code property.
  * /p
  *
  * p
@@ -126,7 +125,7 @@ import org.apache.tomcat.util.buf.B2CCon
  * /p
  *
  * p
- * For JMX junkies, a public method called /coderotate/code has
+ * For JMX junkies, a public method called coderotate/code has
  * been made available to allow you to tell this instance to move
  * the existing log file to somewhere else and start writing a new log file.
  * /p

Modified: 
tomcat/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java?rev=1205112r1=1205111r2=1205112view=diff
==
--- tomcat/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java 
Tue Nov 22 17:59:49 2011
@@ -93,8 +93,8 @@ import org.apache.tomcat.util.ExceptionU
  *
  *
  * p
- * Log rotation can be on or off. This is dictated by the rotatable
- * property.
+ * Log rotation can be on or off. This is dictated by the
+ * coderotatable/code property.
  * /p
  *
  * p
@@ -105,7 +105,7 @@ import org.apache.tomcat.util.ExceptionU
  * /p
  *
  * p
- * For JMX junkies, a public method called /coderotate/code has
+ * For JMX junkies, a public method called coderotate/code has
  * been made available to allow you to tell this instance to move
  * the existing log file to somewhere else and start writing a new log file.
  * /p



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1205115 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/valves/AccessLogValve.java java/org/apache/catalina/valves/ExtendedAccessLogValve.java

2011-11-22 Thread kkolinko
Author: kkolinko
Date: Tue Nov 22 18:02:35 2011
New Revision: 1205115

URL: http://svn.apache.org/viewvc?rev=1205115view=rev
Log:
Merged revision 1205112 from tomcat/trunk:
Correct javadoc markup

Modified:
tomcat/tc7.0.x/trunk/   (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/catalina/valves/AccessLogValve.java

tomcat/tc7.0.x/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java

Propchange: tomcat/tc7.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Tue Nov 22 18:02:35 2011
@@ -1 +1 @@
-/tomcat/trunk:1156115,1156171,1156276,1156304,1156519,1156530,1156602,1157015,1157018,1157151,1157198,1157204,1157810,1157832,1157834,1157847,1157908,1157939,1158155,1158160,1158176,1158195,1158198-1158199,1158227,1158331,1158334-1158335,1158426,1160347,1160592,1160611,1160619,1160626,1160639,1160652,1160720-1160721,1160772,1160774,1160776,1161303,1161310,1161322,1161339,1161486,1161540,1161549,1161584,1162082,1162149,1162169,1162721,1162769,1162836,1162932,1163630,1164419,1164438,1164469,1164480,1164567,1165234,1165247-1165248,1165253,1165273,1165282,1165309,1165331,1165338,1165347,1165360-1165361,1165367-1165368,1165602,1165608,1165677,1165693,1165721,1165723,1165728,1165730,1165738,1165746,1165765,1165777,1165918,1165921,1166077,1166150-1166151,1166290,1166366,1166620,1166686,1166693,1166752,1166757,1167368,1167394,1169447,1170647,1171692,1172233-1172234,1172236,1172269,1172278,1172282,1172556,1172610,1172664,1172689,1172711,1173020-1173021,1173082,1173088,1173090,1173096
 
,1173241,1173256,1173288,117,1173342,1173461,1173614,1173630,1173659,1173722,1174061,1174239,1174322,1174325,1174329-1174330,1174337-1174339,1174343,1174353,1174799,1174882,1174884,1174983,1175155,1175158,1175167,1175182,1175190,1175201,1175272,1175275,1175283,1175582,1175589-1175590,1175594,1175602,1175613,1175633,1175690,1175713,1175798,1175889,1175896,1175907,1176584,1176590,1176799,1177050,1177060,1177125,1177152,1177160,1177245,1177850,1177862,1177978,1178209,1178228,1178233,1178449,1178542,1178681,1178684,1178721,1179268,1179274,1180261,1180865,1180891,1180894,1180907,1181028,1181123,1181125,1181136,1181291,1181743,1182796,1183078,1183105,1183142,1183328,1183339-1183340,1183492-1183494,1183605,1184917,1184919,1185018,1185020,1185200,1185588,1185626,1185756,1185758,1186011,1186042-1186045,1186104,1186123,1186137,1186153,1186254,1186257,1186377-1186379,1186479-1186480,1186712,1186743,1186750,1186763,1186890-1186892,1186894,1186949,1187018,1187027-1187028,1187381,1187
 
753,1187755,1187775,1187801,1187806,1187809,1187827,1188301,1188303-1188305,1188399,1188822,1188930-1188931,1189116,1189129,1189183,1189240,1189256,1189386,1189413-1189414,1189477,1189685,1189805,1189857,1189864,1189882,1190034,1190185,1190279,1190339,1190371,1190388-1190389,1190474,1190481,1194915,1195222-1195223,1195531,1195899,1195905,1195943,1195949,1195953,1195955,1195965,1195968,1196175,1196212,1196223,1196304-1196305,1196735,1196825,1196827,1197158,1197261,1197263,1197299-1197300,1197305,1197339-1197340,1197343,1197382,1197386-1197387,1197480,1197578,1198497,1198528,1198552,1198602,1198604,1198607,1198622,1198640,1198696,1198707,1199418,1199432,1199436,1199513,1199529,1199980,116,1200056,1200089,1200106-1200107,1200263,1200316,1200320,1200398-1200399,1200445-1200446,1200555,1200627,1200696,1200725,1200937,1200941,1201069,1201087,1201180,1201235-1201237,1201508,1201521,1201542,1201545-1201546,1201548,1201555-1201556,1201568,1201576,1201608,1201921-1201922,1201931,1
 
202035,1202039,1202271,1202565,1202578,1202705,1202828,1202860,1203047-1203052,1203078,1203091,1203253,1203278,1204182,1204856,1204867,1204936,1204938,1204982,1205033,1205065,1205082,1205097
+/tomcat/trunk:1156115,1156171,1156276,1156304,1156519,1156530,1156602,1157015,1157018,1157151,1157198,1157204,1157810,1157832,1157834,1157847,1157908,1157939,1158155,1158160,1158176,1158195,1158198-1158199,1158227,1158331,1158334-1158335,1158426,1160347,1160592,1160611,1160619,1160626,1160639,1160652,1160720-1160721,1160772,1160774,1160776,1161303,1161310,1161322,1161339,1161486,1161540,1161549,1161584,1162082,1162149,1162169,1162721,1162769,1162836,1162932,1163630,1164419,1164438,1164469,1164480,1164567,1165234,1165247-1165248,1165253,1165273,1165282,1165309,1165331,1165338,1165347,1165360-1165361,1165367-1165368,1165602,1165608,1165677,1165693,1165721,1165723,1165728,1165730,1165738,1165746,1165765,1165777,1165918,1165921,1166077,1166150-1166151,1166290,1166366,1166620,1166686,1166693,1166752,1166757,1167368,1167394,1169447,1170647,1171692,1172233-1172234,1172236,1172269,1172278,1172282,1172556,1172610,1172664,1172689,1172711,1173020-1173021,1173082,1173088,1173090,1173096
 

svn commit: r1205119 - in /tomcat/tc6.0.x/trunk: java/org/apache/catalina/valves/AccessLogValve.java java/org/apache/catalina/valves/ExtendedAccessLogValve.java webapps/docs/config/valve.xml

2011-11-22 Thread kkolinko
Author: kkolinko
Date: Tue Nov 22 18:17:22 2011
New Revision: 1205119

URL: http://svn.apache.org/viewvc?rev=1205119view=rev
Log:
CTR: docs
Further minor corrections for access log valve docs

Modified:
tomcat/tc6.0.x/trunk/java/org/apache/catalina/valves/AccessLogValve.java

tomcat/tc6.0.x/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java
tomcat/tc6.0.x/trunk/webapps/docs/config/valve.xml

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/valves/AccessLogValve.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/valves/AccessLogValve.java?rev=1205119r1=1205118r2=1205119view=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/catalina/valves/AccessLogValve.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/valves/AccessLogValve.java 
Tue Nov 22 18:17:22 2011
@@ -57,7 +57,8 @@ import org.apache.tomcat.util.buf.B2CCon
  * pImplementation of the bValve/b interface that generates a web server
  * access log with the detailed line contents matching a configurable pattern.
  * The syntax of the available patterns is similar to that supported by the
- * Apache codemod_log_config/code module.  As an additional feature,
+ * a href=http://httpd.apache.org/;Apache HTTP Server/a
+ * codemod_log_config/code module.  As an additional feature,
  * automatic rollover of log files when the date changes is also supported./p
  *
  * pPatterns for the logged message may include constant text or any of the
@@ -131,7 +132,13 @@ import org.apache.tomcat.util.buf.B2CCon
  * Conditional logging is also supported. This can be done with the
  * codecondition/code property.
  * If the value returned from ServletRequest.getAttribute(condition)
- * yields a non-null value. The logging will be skipped.
+ * yields a non-null value, the logging will be skipped.
+ * /p
+ *
+ * p
+ * For extended attributes coming from a getAttribute() call,
+ * it is you responsibility to ensure there are no newline or
+ * control characters.
  * /p
  *
  * @author Craig R. McClanahan

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java?rev=1205119r1=1205118r2=1205119view=diff
==
--- 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java
 (original)
+++ 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/valves/ExtendedAccessLogValve.java
 Tue Nov 22 18:17:22 2011
@@ -72,14 +72,14 @@ import org.apache.juli.logging.LogFactor
  * certain POST parameters.
  * /li
  * liFor any of the x-H(...) the following method will be called from the
- *HttpServletRequestObject /li
+ *HttpServletRequest object /li
  * licodex-H(authType)/code: getAuthType /li
  * licodex-H(characterEncoding)/code: getCharacterEncoding /li
  * licodex-H(contentLength)/code: getContentLength /li
  * licodex-H(locale)/code:  getLocale/li
  * licodex-H(protocol)/code: getProtocol /li
  * licodex-H(remoteUser)/code:  getRemoteUser/li
- * licodex-H(requestedSessionId)/code: getGequestedSessionId/li
+ * licodex-H(requestedSessionId)/code: getRequestedSessionId/li
  * licodex-H(requestedSessionIdFromCookie)/code:
  *  isRequestedSessionIdFromCookie /li
  * licodex-H(requestedSessionIdValid)/code:
@@ -96,7 +96,7 @@ import org.apache.juli.logging.LogFactor
  * /p
  *
  * p
- * For UNIX users, another field called codecheckExists/codeis also
+ * For UNIX users, another field called codecheckExists/code is also
  * available. If set to true, the log file's existence will be checked before
  * each logging. This way an external log rotator can move the file
  * somewhere and Tomcat will start with a new file.
@@ -105,14 +105,14 @@ import org.apache.juli.logging.LogFactor
  * p
  * For JMX junkies, a public method called coderotate/code has
  * been made available to allow you to tell this instance to move
- * the existing log file to somewhere else start writing a new log file.
+ * the existing log file to somewhere else and start writing a new log file.
  * /p
  *
  * p
  * Conditional logging is also supported. This can be done with the
  * codecondition/code property.
  * If the value returned from ServletRequest.getAttribute(condition)
- * yields a non-null value. The logging will be skipped.
+ * yields a non-null value, the logging will be skipped.
  * /p
  *
  * p

Modified: tomcat/tc6.0.x/trunk/webapps/docs/config/valve.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/config/valve.xml?rev=1205119r1=1205118r2=1205119view=diff
==
--- tomcat/tc6.0.x/trunk/webapps/docs/config/valve.xml (original)
+++ 

svn commit: r1205131 - in /tomcat/tc7.0.x/trunk/java/org/apache: catalina/util/Enumerator.java jasper/util/Enumerator.java

2011-11-22 Thread kkolinko
Author: kkolinko
Date: Tue Nov 22 19:12:46 2011
New Revision: 1205131

URL: http://svn.apache.org/viewvc?rev=1205131view=rev
Log:
Followup to r1195962
Document recommended alternative for the deprecated class

Modified:
tomcat/tc7.0.x/trunk/java/org/apache/catalina/util/Enumerator.java
tomcat/tc7.0.x/trunk/java/org/apache/jasper/util/Enumerator.java

Modified: tomcat/tc7.0.x/trunk/java/org/apache/catalina/util/Enumerator.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/util/Enumerator.java?rev=1205131r1=1205130r2=1205131view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/catalina/util/Enumerator.java 
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/catalina/util/Enumerator.java Tue Nov 
22 19:12:46 2011
@@ -36,6 +36,7 @@ import java.util.NoSuchElementException;
  *
  * @author Craig R. McClanahan
  * @version $Id$
+ * @deprecated Replaced by java.util.Collections#enumeration(..)
  */
 @Deprecated
 public final class EnumeratorT implements EnumerationT {

Modified: tomcat/tc7.0.x/trunk/java/org/apache/jasper/util/Enumerator.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/jasper/util/Enumerator.java?rev=1205131r1=1205130r2=1205131view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/jasper/util/Enumerator.java (original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/jasper/util/Enumerator.java Tue Nov 22 
19:12:46 2011
@@ -34,6 +34,7 @@ import java.util.NoSuchElementException;
  *
  * @author Craig R. McClanahan
  * @version $Id$
+ * @deprecated Replaced by java.util.Collections#enumeration(..)
  */
 @Deprecated
 public final class EnumeratorT implements EnumerationT {



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 7.0.23 - Take 2

2011-11-22 Thread Mark Thomas
On 20/11/2011 22:17, Mark Thomas wrote:
 On 20/11/2011 22:16, Mark Thomas wrote:
 The 7.0.23 tag was fine. The problem was local. I have re-rolled the
 7.0.23 release from a clean export of the 7.0.23 tag.

 The proposed Apache Tomcat 7.0.23 release is now available for voting.

 It can be obtained from:
 http://people.apache.org/~markt/dev/tomcat-7/v7.0.23/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_23/

 The proposed 7.0.23 release is:

 [ ] Broken - do not release
 [ ] Beta   - go ahead and release as 7.0.23 Beta
 [X] Stable - go ahead and release as 7.0.23 Stable

FYI The ASF Jira instance has been running on 7.0.23 for ~24 hours now
without any problems.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 52225] Adding Alias for existing host on running Tomcat causes ClassCastException

2011-11-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52225

Mark Thomas ma...@apache.org changed:

   What|Removed |Added

  Component|Catalina|Catalina
Version|7.0.23  |6.0.33
Product|Tomcat 7|Tomcat 6
   Target Milestone|--- |default

--- Comment #2 from Mark Thomas ma...@apache.org 2011-11-22 19:25:49 UTC ---
Moving to 6.0.x

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Tomcat Wiki] Update of FrontPage by KonstantinKolinko

2011-11-22 Thread Apache Wiki
Dear Wiki user,

You have subscribed to a wiki page or wiki category on Tomcat Wiki for change 
notification.

The FrontPage page has been changed by KonstantinKolinko:
http://wiki.apache.org/tomcat/FrontPage?action=diffrev1=26rev2=27

Comment:
Remove link to DocumentInOtherLanguages page. That page has been removed a 
while ago and I do not see perspectives for it.

   * '''[[Tomcat/Books|Books]]''' - Books about Tomcat.
   * '''[[UsingPhp|Using PHP]]''' - Using PHP with Tomcat 4 or later.
   * '''[[WhatIsComet|What is Comet]]''' - What is the Tomcat Comet API.
-  * '''[[DocumentInOtherLanguages|Translations]]''' - List of Tomcat documents 
in other languages.
   * '''[[GSOC]]''' - Google Summer of Code
   * '''[[AddOns]]''' - Third party tools and add-ons not included in the 
official distribution
  

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Random Comet unit test failures

2011-11-22 Thread Mark Thomas
I have done a little bit of digging on this as the current 7.0.x trunk
fails frequently enough on my windows box that I can repeat the failure
often enough.

I have got as far as discovering that the request.getAvailable() test on
line 308 of the CoyoteAdapter returns zero whenever the test fails.

While, I haven't figured out how this leads to the failure yet, I
thought the info may help others make some progress on this.

There is clearly a timing / threading issue here but I haven't found it yet.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GUMP@vmgump]: Project tomcat-tc7.0.x-test (in module tomcat-7.0.x) failed

2011-11-22 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-tc7.0.x-test has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 2 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-tc7.0.x-test :  Tomcat 7.x, a web server implementing Java Servlet 
3.0,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-test/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on tomcat-tc7.0.x-dbcp exists, no need to add for property 
tomcat-dbcp-src.jar.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -DEBUG- Dependency on tomcat-tc7.0.x-dbcp exists, no need to add for property 
tomcat-dbcp.home.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-7.0.x/output/build/logs



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-test/gump_work/build_tomcat-7.0.x_tomcat-tc7.0.x-test.html
Work Name: build_tomcat-7.0.x_tomcat-tc7.0.x-test (Type: Build)
Work ended in a state of : Failed
Elapsed: 17 mins 58 secs
Command Line: /usr/lib/jvm/java-6-openjdk/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/dist/junit-23112011.jar 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-23112011-native-src.tar.gz
 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-23112011-native-src.tar.gz
 -Dexamples.sources.skip=true 
-Dtomcat-dbcp.home=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/org.eclipse.jdt.core_3.4.2/jdtcore.jar
 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-23112011.jar
 
-Dtomcat-dbcp-src.jar=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps/tomcat-dbcp-src.jar
 -Dcommons-pool.home=/srv/gump/public/workspace/commons-pool-1.x 
-Dcommons-dbcp.home=/srv/gump/public/worksp
 ace/commons-dbcp-1.x 
-Dtomcat-dbcp.jar=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps/tomcat-dbcp-23112011.jar
 test 
[Working Directory: /srv/gump/public/workspace/tomcat-7.0.x]
CLASSPATH: 
/usr/lib/jvm/java-6-openjdk/lib/tools.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-7.0.x/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/servlet-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/outp
 
ut/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-util.jar:/srv/gump/packages/javamail-1.4/mail.jar:/srv/gump/packages/javamail-1.4/lib/mailapi.jar:/srv/gump/packages/jaf-1.1ea/activation.jar:/srv/gump/packages/eclipse/plugins/org.eclipse.jdt.core_3.4.2/jdtcore.jar:/srv/gump/public/workspace/tomcat-7.
 

[GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2011-11-22 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-test has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 2 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-test :  Tomcat 8.x, a web server implementing Java Servlet 
3.1,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on tomcat-trunk-dbcp exists, no need to add for property 
tomcat-dbcp-src.jar.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -DEBUG- Dependency on tomcat-trunk-dbcp exists, no need to add for property 
tomcat-dbcp.home.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/build/logs



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/gump_work/build_tomcat-trunk_tomcat-trunk-test.html
Work Name: build_tomcat-trunk_tomcat-trunk-test (Type: Build)
Work ended in a state of : Failed
Elapsed: 17 mins 59 secs
Command Line: /usr/lib/jvm/java-6-openjdk/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/dist/junit-23112011.jar 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-23112011-native-src.tar.gz
 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-23112011-native-src.tar.gz
 -Dexamples.sources.skip=true 
-Dtomcat-dbcp.home=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/org.eclipse.jdt.core_3.4.2/jdtcore.jar
 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-23112011.jar
 
-Dtomcat-dbcp-src.jar=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps/tomcat-dbcp-src.jar
 -Dcommons-pool.home=/srv/gump/public/workspace/commons-pool-1.x 
-Dcommons-dbcp.home=/srv/gump/public/worksp
 ace/commons-dbcp-1.x 
-Dtomcat-dbcp.jar=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps/tomcat-dbcp-23112011.jar
 test 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-6-openjdk/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.jar:/srv/gump/public/workspace/tomcat-trunk/outp
 
ut/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-util.jar:/srv/gump/packages/javamail-1.4/mail.jar:/srv/gump/packages/javamail-1.4/lib/mailapi.jar:/srv/gump/packages/jaf-1.1ea/activation.jar:/srv/gump/packages/eclipse/plugins/org.eclipse.jdt.core_3.4.2/jdtcore.jar:/srv/gump/public/workspace/tomcat-tr
 

DO NOT REPLY [Bug 52231] New: Ant Tasks need to reflect changes in manager commands

2011-11-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52231

 Bug #: 52231
   Summary: Ant Tasks need to reflect changes in manager commands
   Product: Tomcat Native
   Version: unspecified
  Platform: PC
Status: NEW
  Severity: normal
  Priority: P2
 Component: Library
AssignedTo: dev@tomcat.apache.org
ReportedBy: logic@gmail.com
Classification: Unclassified


I was performing a catalina ant ReloadTask, getting the error
C:\springsource\workspace\Test1\build.xml:121: java.io.FileNotFoundException:
http://localhost:8080/manager/reload?path=%2FTest1

I tried browsing to this URL manually and the following line from the Manager
404 page caught my eye:
Note that the URL for the text interface has changed from /manager to
/manager/text.

Turns out the source code in src/java/org/apache/catalina/ant/ReloadTask.java
may have it wrong:

execute(createQueryString(/reload).toString());
Should be
execute(createQueryString(/text/reload).toString());

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



can only see ROOT webapp

2011-11-22 Thread shadowdancer351

I am using Tomcat 4 on Linux.

I can see any html page i put in the ROOT directory, but I can't see any of
the built-in webapps by typing in the URL
http://myhost:8080/manager/index.html (yes that index.html file exists in
that directory). It won't work for tomcat-docs or examples either. I
tried putting in my own webapp and I couldn't see that either. I've added
the context definition to the server.xml file and restarted tomcat. Is there
anything else I should do?
-- 
View this message in context: 
http://old.nabble.com/can-only-see-ROOT-webapp-tp32873594p32873594.html
Sent from the Tomcat - Dev mailing list archive at Nabble.com.


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



can only see ROOT webapp

2011-11-22 Thread shadowdancer351

I am using Tomcat 4 on Linux.

I can see any html page i put in the ROOT directory, but I can't see any of
the built-in webapps by typing in the URL
http://myhost:8080/manager/index.html (yes that index.html file exists in
that directory). It won't work for tomcat-docs or examples either. I
tried putting in my own webapp and I couldn't see that either. I've added
the context definition to the server.xml file and restarted tomcat. Is there
anything else I should do?
-- 
View this message in context: 
http://old.nabble.com/can-only-see-ROOT-webapp-tp32873595p32873595.html
Sent from the Tomcat - Dev mailing list archive at Nabble.com.


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Random Comet unit test failures

2011-11-22 Thread Konstantin Kolinko
2011/11/23 Mark Thomas ma...@apache.org:
 I have done a little bit of digging on this as the current 7.0.x trunk
 fails frequently enough on my windows box that I can repeat the failure
 often enough.

 I have got as far as discovering that the request.getAvailable() test on
 line 308 of the CoyoteAdapter returns zero whenever the test fails.

 While, I haven't figured out how this leads to the failure yet, I
 thought the info may help others make some progress on this.

 There is clearly a timing / threading issue here but I haven't found it yet.


What failure are you pursuing?

The following one occurs frequently on Gump/buildbot:
[[[
Testcase: testCometConnectorStop took 4.078 sec
FAILED
Comet END event not received
junit.framework.AssertionFailedError: Comet END event not received
at 
org.apache.catalina.comet.TestCometProcessor.testCometConnectorStop(TestCometProcessor.java:293)
]]]


In the main stdout file there occasionally are also a lot of NPE like
[[[
[junit] Nov 23, 2011 3:37:25 AM
org.apache.coyote.http11.AbstractHttp11Processor process
[junit] SEVERE: Error processing request
[junit] java.lang.NullPointerException
[junit] at
org.apache.tomcat.util.net.NioBlockingSelector.write(NioBlockingSelector.java:126)
[junit] at
org.apache.tomcat.util.net.NioSelectorPool.write(NioSelectorPool.java:175)
[junit] at
org.apache.coyote.http11.InternalNioOutputBuffer.writeToSocket(InternalNioOutputBuffer.java:170)
[junit] at
org.apache.coyote.http11.InternalNioOutputBuffer.flushBuffer(InternalNioOutputBuffer.java:249)
[junit] at
org.apache.coyote.http11.InternalNioOutputBuffer.endRequest(InternalNioOutputBuffer.java:128)
[junit] at
org.apache.coyote.http11.AbstractHttp11Processor.action(AbstractHttp11Processor.java:741)
[junit] at org.apache.coyote.Response.action(Response.java:170)
[junit] at org.apache.coyote.Response.finish(Response.java:276)
[junit] at
org.apache.catalina.connector.OutputBuffer.close(OutputBuffer.java:288)
[junit] at
org.apache.catalina.connector.Response.finishResponse(Response.java:507)
[junit] at
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:434)
[junit] at
org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:987)
[junit] at
org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:539)
[junit] at
org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1571)
[junit] at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
[junit] at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
[junit] at java.lang.Thread.run(Thread.java:636)


[junit] Nov 23, 2011 3:37:25 AM
org.apache.catalina.connector.CoyoteAdapter log
[junit] WARNING: Exception while attempting to add an entry to the
access log
[junit] java.lang.NullPointerException
[junit] at
org.apache.catalina.connector.CoyoteAdapter.log(CoyoteAdapter.java:511)
[junit] at
org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1007)
[junit] at
org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:539)
[junit] at
org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1571)
[junit] at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
[junit] at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
[junit] at java.lang.Thread.run(Thread.java:636)
]]]

The above one is from
http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-test/gump_work/build_tomcat-7.0.x_tomcat-tc7.0.x-test.txt


Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org