date:20111202

https://issues.apache.org/bugzilla/show_bug.cgi?id=52261

hemant jaiswal hema...@gmail.com changed:

   What|Removed |Added

Summary|due to  |test
   |org.apache.jasper.compiler. |
   |TldLocationsCache.tldScanJa |
   |r server throws |
   |java.lang.OutOfMemoryError: |
   |requested 33554440 bytes|
   |for Chunk::new. Out of swap |

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 52259] synchonization issues and dead lock if no realm is presented in configuration

https://issues.apache.org/bugzilla/show_bug.cgi?id=52259

Rainer Jung rainer.j...@kippdata.de changed:

   What|Removed |Added

 CC||zhouyanm...@gmail.com

--- Comment #9 from Rainer Jung rainer.j...@kippdata.de 2011-12-02 08:58:03 
UTC ---
*** Bug 52276 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 52276] tomcat deploy will be blocked without LockOutRealm

https://issues.apache.org/bugzilla/show_bug.cgi?id=52276

Rainer Jung rainer.j...@kippdata.de changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE
 OS/Version||All

--- Comment #1 from Rainer Jung rainer.j...@kippdata.de 2011-12-02 08:58:02 
UTC ---
Most likely a duplicate of 52259. As a workaround onfiguring any Realm should
prevent the deadlock.

This is already fixed and will be released with 7.0.24.

*** This bug has been marked as a duplicate of bug 52259 ***

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 52261] due to org.apache.jasper.compiler.TldLocationsCache.tldScanJar server throws java.lang.OutOfMemoryError: requested 33554440 bytes for Chunk::new. Out of swap

https://issues.apache.org/bugzilla/show_bug.cgi?id=52261

Mark Thomas ma...@apache.org changed:

   What|Removed |Added

Summary|test|due to
   ||org.apache.jasper.compiler.
   ||TldLocationsCache.tldScanJa
   ||r server throws
   ||java.lang.OutOfMemoryError:
   ||requested 33554440 bytes
   ||for Chunk::new. Out of swap

--- Comment #5 from Mark Thomas ma...@apache.org 2011-12-02 09:12:53 UTC ---
Restoring correct title after idiot used BZ as a sandbox

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: DO NOT REPLY [Bug 52276] New: tomcat deploy will be blocked without LockOutRealm

2011-12-02 Thread jaiswal

Hi,

Sorry ..i dont know whether this mail group is valid for this discussion or
not but i am facing one issue:

after looking into hs_err_pid log file

th emain issue is in

*org.apache.jasper.compiler.TldLocationsCache.tldScanJar*

method

Can you tell me what should i do ?

regards
kailash

# java.lang.OutOfMemoryError: requested 134217736 bytes for Chunk::new. Out
of swap space?)




On Fri, Dec 2, 2011 at 10:50 AM, bugzi...@apache.org wrote:

 https://issues.apache.org/bugzilla/show_bug.cgi?id=52276

 Bug #: 52276
   Summary: tomcat deploy will be blocked without LockOutRealm
   Product: Tomcat 7
   Version: 7.0.23
  Platform: PC
Status: NEW
  Severity: blocker
  Priority: P2
 Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: zhouyanm...@gmail.com
Classification: Unclassified


 If I comment Realm
 className=org.apache.catalina.realm.LockOutRealm../Realm under Engine
 name=Catalina defaultHost=localhost ,tomcat deploy will be blocked
 when
 start,7.0.22 works fine without LockOutRealm


 2011-12-2 13:11:20 org.apache.coyote.AbstractProtocol init
 INFO: Initializing ProtocolHandler [http-bio-8080]
 2011-12-2 13:11:20 org.apache.coyote.AbstractProtocol init
 INFO: Initializing ProtocolHandler [ajp-bio-8009]
 2011-12-2 13:11:20 org.apache.catalina.startup.Catalina load
 INFO: Initialization processed in 866 ms
 2011-12-2 13:11:20 org.apache.catalina.core.StandardService startInternal
 INFO: Starting service Catalina
 2011-12-2 13:11:20 org.apache.catalina.core.StandardEngine startInternal
 INFO: Starting Servlet Engine: Apache Tomcat/7.0.23
 2011-12-2 13:11:20 org.apache.catalina.startup.HostConfig deployDescriptor
 INFO: Deploying configuration descriptor
 D:\apache-tomcat-7.0.23\conf\Catalina\localhost\ROOT.xml

 blocking ...

 --
 Configure bugmail:
 https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
 --- You are receiving this mail because: ---
 You are the assignee for the bug.

 -
 To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
 For additional commands, e-mail: dev-h...@tomcat.apache.org




-- 
-Hemant

Proposal: use tomcat-version-number in server.xml Server element?

All,

This may be a waste of time, but it's worth suggesting IMO.

We have lots of users who try to upgrade between major versions of
Tomcat by simply installing the new Tomcat somewhere, copying their
configuration over (primarily server.xml), dumping their webapps into
webapps/, starting the server, and then running to the users' list when
it doesn't work.

I was thinking that we could add a version attribute to server.xml's
Server element that could allow Tomcat to bomb on startup if the
version wasn't correct/compatible.

Such a version string could be as simple as 5.5 or 6.0 or whatever.
It could also track the actual release version 6.0.32, or even be
something more opaque like Java's class file version numbering.

A server reading an incompatible configuration file (almost always a
newer version of Tomcat reading an ancient version of the file) could
complain with an error message a reference to the documentation about
how to properly upgrade Tomcat.

Does anything think:

1) This would actually help people? You get a nice error message instead
   of ClassNotFoundExceptions and warnings about unrecognized property
   names and stuff.

2) This would be a total PITA because you have to go find the magic
   version string for your new Tomcat version? The intent would be
   to have the version string /already/ in the server.xml that ships
   with Tomcat.

3) This could help us when we have to introduce some semi-breaking
   change to server.xml without a major release bump. In these cases,
   the warning could be something like There are incompatibilities
   between your version of server.xml and this version of Tomcat: please
   see [url-to-incompatible-property-docs] for more info instead of
   go see the upgrade documentation.

This kind of thing is probably too late for TC 7, but TC 8 could
implement it pretty trivially.

-chris



signature.asc
Description: OpenPGP digital signature

Re: DO NOT REPLY [Bug 52259] synchonization issues and dead lock if no realm is presented in configuration

Mark,

On 12/1/11 2:02 PM, Mark Thomas wrote:
 On 01/12/2011 17:54, Zampani, Michael wrote:
 Should this mentioned somewhere on the changelog as a known bug with a 
 workaround?
 
 It already is.

Yes and no: it's in the changelog, but the changelog currently published
on the website doesn't cover anything past 7.0.23.

-chris



signature.asc
Description: OpenPGP digital signature

[GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2011-12-02 Thread Bill Barker

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-test has an issue affecting its community integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-test :  Tomcat 8.x, a web server implementing Java Servlet 
3.1,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on tomcat-trunk-dbcp exists, no need to add for property 
tomcat-dbcp-src.jar.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -DEBUG- Dependency on tomcat-trunk-dbcp exists, no need to add for property 
tomcat-dbcp.home.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/build/logs



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/gump_work/build_tomcat-trunk_tomcat-trunk-test.html
Work Name: build_tomcat-trunk_tomcat-trunk-test (Type: Build)
Work ended in a state of : Failed
Elapsed: 17 mins 45 secs
Command Line: /usr/lib/jvm/java-6-openjdk/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/dist/junit-02122011.jar 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-02122011-native-src.tar.gz
 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-02122011-native-src.tar.gz
 -Dexamples.sources.skip=true 
-Dtomcat-dbcp.home=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/org.eclipse.jdt.core_3.4.2/jdtcore.jar
 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-02122011.jar
 
-Dtomcat-dbcp-src.jar=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps/tomcat-dbcp-src.jar
 -Dcommons-pool.home=/srv/gump/public/workspace/commons-pool-1.x 
-Dcommons-dbcp.home=/srv/gump/public/worksp
 ace/commons-dbcp-1.x 
-Dtomcat-dbcp.jar=/srv/gump/public/workspace/tomcat-trunk/tomcat-deps/tomcat-dbcp-02122011.jar
 test 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-6-openjdk/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.jar:/srv/gump/public/workspace/tomcat-trunk/outp
 
ut/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-util.jar:/srv/gump/packages/javamail-1.4/mail.jar:/srv/gump/packages/javamail-1.4/lib/mailapi.jar:/srv/gump/packages/jaf-1.1ea/activation.jar:/srv/gump/packages/eclipse/plugins/org.eclipse.jdt.core_3.4.2/jdtcore.jar:/srv/gump/public/workspace/tomcat-tr
 
unk/tomcat-deps/tomcat-dbcp-02122011.jar:/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-02122011.jar:/srv/gump/public/workspace/junit/dist/junit-02122011.jar

Re: Proposal: use tomcat-version-number in server.xml Server element?

2011-12-02 Thread Tim Funk

Sounds like a job for a LifeCycleListener. (and therefore easy to backport)

-Tim

Re: Proposal: use tomcat-version-number in server.xml Server element?

Tim,

On 12/2/11 11:19 AM, Tim Funk wrote:
 Sounds like a job for a LifeCycleListener. (and therefore easy to backport)

I'm concerned about back-porting because anyone starting with Tomcat
7.0.x will not likely have such a version number, and we don't want to
complain that the version number is missing if those users have been
doing what they are supposed to be doing. That is, I won't want a 7.0.23
- 7.0.24 upgrade to suddenly complain that the server.xml is incompatible.

I'm not sure there's a good way to detect 6.0 - (say) 7.0.24 as being
distinct from 7.0.23 - 7.0.24.

The only way I can see to avoid that would be to scan the entire
server.xml looking for suspicious things from previous versions and
complain about those... which seems like it would be a) a waste of (our)
time b) fraught will difficulty and c) couldn't catch many cases anyway.

I'm definitely open to suggestions, though.

-chris



signature.asc
Description: OpenPGP digital signature

Re: Proposal: use tomcat-version-number in server.xml Server element?

2011-12-02 Thread Konstantin Kolinko

2011/12/2 Christopher Schultz ch...@christopherschultz.net:
 All,

 This may be a waste of time, but it's worth suggesting IMO.

 We have lots of users who try to upgrade between major versions of
 Tomcat by simply installing the new Tomcat somewhere, copying their
 configuration over (primarily server.xml), dumping their webapps into
 webapps/, starting the server, and then running to the users' list when
 it doesn't work.

 I was thinking that we could add a version attribute to server.xml's
 Server element that could allow Tomcat to bomb on startup if the
 version wasn't correct/compatible.


-1

1. I strongly dislike relying on any numbers in such a feature. As
people say, you should not rely on numbers, but on the features that
are available.

2. It is social problem. You cannot teach people with this feature.
People will always be smarter than your tool.

I'd suspect that the first thing that most people faced with such
problem will do is to edit the number. They wouldn't read the docs.

3. It does not prevent someone from Googling ancient articles and
copying parts of config from there.

(Someone cited an article from year 2001 just recently. Surprisingly
it was still relevant - that part of Servet spec did not change much).

4. Version number can be changed by vendor or by site Admin.

Speaking of relying on features:
-  Tomcat 6 server.xml should not start with Tomcat 7, because some
LifeCycle listener implementations were removed.
- Tomcat 5.5 and 6.0 differ in loader configuration in catalina.properties


How about mentioning your issue somewhere in the FAQ? Though I think
it is already mentioned on
http://apache.org/migration.html

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: DO NOT REPLY [Bug 52259] synchonization issues and dead lock if no realm is presented in configuration

2011-12-02 Thread Konstantin Kolinko

2011/12/2 Christopher Schultz ch...@christopherschultz.net:
 Mark,

 On 12/1/11 2:02 PM, Mark Thomas wrote:
 On 01/12/2011 17:54, Zampani, Michael wrote:
 Should this mentioned somewhere on the changelog as a known bug with a 
 workaround?

 It already is.

 Yes and no: it's in the changelog, but the changelog currently published
 on the website doesn't cover anything past 7.0.23.


There is link here:
http://tomcat.apache.org/bugreport.html#Recently_fixed_issues

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Proposal: use tomcat-version-number in server.xml Server element?

2011-12-02 Thread Filip Hanik - Dev Lists

On 12/2/2011 10:11 AM, Konstantin Kolinko wrote:

2011/12/2 Christopher Schultzch...@christopherschultz.net:

All,

This may be a waste of time, but it's worth suggesting IMO.

We have lots of users who try to upgrade between major versions of
Tomcat by simply installing the new Tomcat somewhere, copying their
configuration over (primarily server.xml), dumping their webapps into
webapps/, starting the server, and then running to the users' list when
it doesn't work.

I was thinking that we could add a version attribute to server.xml's
Server element that could allow Tomcat to bomb on startup if the
version wasn't correct/compatible.

-1

1. I strongly dislike relying on any numbers in such a feature. As
people say, you should not rely on numbers, but on the features that
are available.
I have the exact opposite reaction. It seems like a strong -1 here is an engineering preference, specifically from one that already knows
the product inside and out.
However, I run into this very often, with Apache Tomcat and other products. Where ease of use is hindered by the product having almost zero
validation of it's own configuration.

It's very different making a -1 statement from behind a developer IDE, but try to sit next to a customer with 3000 tomcat instances running
and tell that administrator why Tomcat is not telling him his config is wrong, cause the config changed between 5.0 and 5.5

2. It is social problem. You cannot teach people with this feature.
People will always be smarter than your tool.

Opposite again, ease of use comes from the tool. advanced usage comes from the
people.

I'd suspect that the first thing that most people faced with such
problem will do is to edit the number. They wouldn't read the docs.

so then there is room for a different solution, but yet attacking the same
problem.

3. It does not prevent someone from Googling ancient articles and
copying parts of config from there.

It does not solve it, but it refers to the very problem to address, and
actuates that it is a problem.
So it seems like, the problem is obvious, the solution may not be enough.

Chris, this would be your queue to rethink the solution one step further down
the line.
Not too long ago, I add in a property validator. Tomcat used to silently
ignored invalid attributes, so misspellings such as

Server sport=-1 shutdowns=SHUTDOWN

This used to run with default values, with zero logging. This has been
addressed for the most part.
but there are still loop wholes, particularly with values and elements

Filip

(Someone cited an article from year 2001 just recently. Surprisingly
it was still relevant - that part of Servet spec did not change much).

4. Version number can be changed by vendor or by site Admin.

Speaking of relying on features:
- Tomcat 6 server.xml should not start with Tomcat 7, because some
LifeCycle listener implementations were removed.
- Tomcat 5.5 and 6.0 differ in loader configuration in catalina.properties

How about mentioning your issue somewhere in the FAQ? Though I think
it is already mentioned on
http://apache.org/migration.html

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Proposal: use tomcat-version-number in server.xml Server element?

Konstantin,

On 12/2/11 12:11 PM, Konstantin Kolinko wrote:
 2011/12/2 Christopher Schultz ch...@christopherschultz.net:

 I was thinking that we could add a version attribute to server.xml's
 Server element that could allow Tomcat to bomb on startup if the
 version wasn't correct/compatible.

 
 -1
 
 1. I strongly dislike relying on any numbers in such a feature. As
 people say, you should not rely on numbers, but on the features that
 are available.

While I agree in theory, it's almost a guarantee that using a server.xml
from some other major-version of Tomcat will result in a broken Tomcat
or at least one that won't start properly.

 2. It is social problem. You cannot teach people with this feature.
 People will always be smarter than your tool.

Or dumber :)

 I'd suspect that the first thing that most people faced with such
 problem will do is to edit the number. They wouldn't read the docs.

That's one reason I suggested using a somewhat opaque version number
rather than just saying 7.0 or whatever. It might force them to read
the docs.

 3. It does not prevent someone from Googling ancient articles and
 copying parts of config from there.

Agreed.

 4. Version number can be changed by vendor or by site Admin.
 
 Speaking of relying on features:
 -  Tomcat 6 server.xml should not start with Tomcat 7, because some
 LifeCycle listener implementations were removed.

That's precisely the case I'm trying to cover, here.

 - Tomcat 5.5 and 6.0 differ in loader configuration in catalina.properties

Same here.

 How about mentioning your issue somewhere in the FAQ? Though I think
 it is already mentioned on
 http://apache.org/migration.html

http://tomcat.apache.org/migration.html does not contain the string
server.xml, though I haven't through the actual text -- just searched
for server.xml. I'd be happy to take a look at the guide and make some
additions.

-chris



signature.asc
Description: OpenPGP digital signature

Re: Proposal: use tomcat-version-number in server.xml Server element?

Filip,

On 12/2/11 12:26 PM, Filip Hanik - Dev Lists wrote:
 Chris, this would be your [cue] to rethink the solution one step further
 down the line.
 Not too long ago, I add in a property validator. Tomcat used to silently
 ignored invalid attributes, so misspellings such as
 
 Server sport=-1 shutdowns=SHUTDOWN
 
 This used to run with default values, with zero logging. This has been
 addressed for the most part.
 but there are still [loopholes], particularly with values and elements

Definitely. I'll see if I can take a look at the validator to see how it
might be extended to look for certain things.

I just cringe whenever I see someone who has a Logger element in their
server.xml or debug attributes all over their elements. The former may
require a different strategy, but the latter should already be handled
by your validator (which really sounds like a complainer :)

Tomcat already uses commons-digester to read its configuration files, so
it should be trivial to add some rules to look for specific, definitely
BAD things (like Logger anywhere, for instance).

IIRC, Tomcat has hard-coded digester rules for just about everything.
Does anyone know if that was an intentional design decision or just what
happened at the time? Digester may have more elegant ways of doing the
same things these days (like XML configuration)... and that would make
it easier for me to add something like this: just a one-liner in the
configuration for each known-bad element/property instead of modifying
the code.

-chris



signature.asc
Description: OpenPGP digital signature

Re: Proposal: use tomcat-version-number in server.xml Server element?

2011-12-02 Thread sebb

On 2 December 2011 17:35, Christopher Schultz
ch...@christopherschultz.net wrote:
 Filip,

 On 12/2/11 12:26 PM, Filip Hanik - Dev Lists wrote:
 Chris, this would be your [cue] to rethink the solution one step further
 down the line.
 Not too long ago, I add in a property validator. Tomcat used to silently
 ignored invalid attributes, so misspellings such as

 Server sport=-1 shutdowns=SHUTDOWN

 This used to run with default values, with zero logging. This has been
 addressed for the most part.
 but there are still [loopholes], particularly with values and elements

 Definitely. I'll see if I can take a look at the validator to see how it
 might be extended to look for certain things.

 I just cringe whenever I see someone who has a Logger element in their
 server.xml or debug attributes all over their elements. The former may
 require a different strategy, but the latter should already be handled
 by your validator (which really sounds like a complainer :)

 Tomcat already uses commons-digester to read its configuration files, so
 it should be trivial to add some rules to look for specific, definitely
 BAD things (like Logger anywhere, for instance).

 IIRC, Tomcat has hard-coded digester rules for just about everything.
 Does anyone know if that was an intentional design decision or just what
 happened at the time? Digester may have more elegant ways of doing the
 same things these days (like XML configuration)... and that would make
 it easier for me to add something like this: just a one-liner in the
 configuration for each known-bad element/property instead of modifying
 the code.

What about implementing something like Java does for deprecated code?

That is, if the checking algorithm notices anything odd in the
configuration, log a _single_ message to say the config looks wrong.
The message should say how to generate more verbose logging (and
possibly stricter checking), e.g. via a System property or marker
file, or even via a command-line option. [Asking them to edit the xml
file would likely be counter-productive...!]

If it was found that even basic checking caused a slowdown in startup,
then just log a message saying how to run the checks.

==

May I suggest that any warning messages generated by the checking
algorithm have a unique code for each error type; if it is reasonably
short (cf. Http's 404 etc. or VMS's RMS-FNF) it might make debugging
on the user list easier.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: DO NOT REPLY [Bug 52259] synchonization issues and dead lock if no realm is presented in configuration

On 02/12/2011 15:59, Christopher Schultz wrote:
 Mark,
 
 On 12/1/11 2:02 PM, Mark Thomas wrote:
 On 01/12/2011 17:54, Zampani, Michael wrote:
 Should this mentioned somewhere on the changelog as a known bug
 with a workaround?
 
 It already is.
 
 Yes and no: it's in the changelog, but the changelog currently
 published on the website doesn't cover anything past 7.0.23.

The latest changelog is always available from svn and is formatted so
it prints nicely:

http://svn.apache.org/repos/asf/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml


There are also multiple bug reports in BZ that includes the work-around.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 52278] New: An invalid Lifecycle transition was attempted ([before_start]) for component [StandardServer[18005]]

https://issues.apache.org/bugzilla/show_bug.cgi?id=52278

 Bug #: 52278
   Summary: An invalid Lifecycle transition was attempted
([before_start]) for component [StandardServer[18005]]
   Product: Tomcat 7
   Version: 7.0.23
  Platform: Other
OS/Version: other
Status: NEW
  Severity: major
  Priority: P2
 Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: bim...@us.ibm.com
Classification: Unclassified


Environment:
Using CATALINA_BASE:   /apacheTomcat7/apache-tomcat-7.0.23 
Using CATALINA_HOME:   /apacheTomcat7/apache-tomcat-7.0.23   
Using CATALINA_TMPDIR: /apacheTomcat7/apache-tomcat-7.0.23/temp  
Using JRE_HOME:/QOpenSys/QIBM/ProdData/JavaVM/jdk60/32bit/jre
Using CLASSPATH:   /apacheTomcat7/apache-tomcat-7.0.23/bin/bootstrap.jar:
/apacheTomcat7/apache-tomcat-7.0.23/bin/tomcat-juli.jar  
Server version: Apache Tomcat/7.0.23 
Server built:   Nov 20 2011 07:36:25 
Server number:  7.0.23.0 
OS Name:OS/400   
OS Version: V7R1M0   
Architecture:   PowerPC  
JVM Version:jvmap3260sr9-20101130
JVM Vendor: IBM Corporation  

Out of the box start failed with :-
Throwable occurred: org.apache.catalina.LifecycleException: An invalid
Lifecycle transition was attempted ([before_start]) for component
[StandardServer[18005]] in state [INITIALIZING]

I then updated server.xml to prepend a 1 before the port numbers:-
Server port=18005 shutdown=SHUTDOWN
Connector port=18080 protocol=HTTP/1.1
   connectionTimeout=2
   redirectPort=18443 /
Connector port=18009 protocol=AJP/1.3 redirectPort=18443 /
Start is failing with:-
Dec 2, 2011 1:07:01 PM org.apache.catalina.core.AprLifecycleListener init
INFO: The APR based Apache Tomcat Native library which allows optimal
performance in production environments was not found on the java.library.path:
/QSYS.LIB/SST.LIB:/QSYS.LIB:/QSYS.LIB/QSYS2.LIB:/QSYS.LIB/QUSRSYS.LIB:/QSYS.LIB/QHLPSYS.LIB:/QSYS.LIB/QSHELL.LIB:/QSYS.LIB/BIMBRA.LIB:/QSYS.LIB/QGPL.LIB:/QSYS.LIB/QTEMP.LIB:/QSYS.LIB/VLOGTOOL3.LIB:/QOpenSys/QIBM/ProdData/JavaVM/jdk60/32bit/jre/lib/ppc:/QOpenSys/QIBM/ProdData/JavaVM/jdk60/32bit/jre/lib/ppc/classic:/QOpenSys/QIBM/ProdData/JavaVM/jdk60/32bit/jre/lib/ppc/default
Dec 2, 2011 1:07:01 PM org.apache.catalina.startup.Catalina start
SEVERE: Catalina.start: 
Throwable occurred: org.apache.catalina.LifecycleException: An invalid
Lifecycle transition was attempted ([before_start]) for component
[StandardServer[18005]] in state [INITIALIZING]
at
org.apache.catalina.util.LifecycleBase.invalidTransition(LifecycleBase.java:408)
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:144)
at org.apache.catalina.startup.Catalina.start(Catalina.java:624)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:60)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:37)
at java.lang.reflect.Method.invoke(Method.java:611)
at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:322)
at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:450)
Dec 2, 2011 1:07:01 PM org.apache.catalina.startup.Catalina start
INFO: Server startup in 2 ms

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 52278] An invalid Lifecycle transition was attempted ([before_start]) for component [StandardServer[18005]]

https://issues.apache.org/bugzilla/show_bug.cgi?id=52278

--- Comment #1 from Tosh bim...@us.ibm.com 2011-12-02 20:07:35 UTC ---
A slight update to the details I posted earlier.
The default port number is 8005.
The 'out of the box' failure to start the server is:-
Out of the box start failed with :-
Throwable occurred: org.apache.catalina.LifecycleException: An invalid
Lifecycle transition was attempted ([before_start]) for component
[StandardServer[8005]] in state [INITIALIZING]

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1209683 - /tomcat/trunk/.gitignore

2011-12-02 Thread slaurent

Author: slaurent
Date: Fri Dec  2 20:34:29 2011
New Revision: 1209683

URL: http://svn.apache.org/viewvc?rev=1209683view=rev
Log:
synced svn ignores to git ignores

Modified:
tomcat/trunk/.gitignore

Modified: tomcat/trunk/.gitignore
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/.gitignore?rev=1209683r1=1209682r2=1209683view=diff
==
--- tomcat/trunk/.gitignore (original)
+++ tomcat/trunk/.gitignore Fri Dec  2 20:34:29 2011
@@ -30,5 +30,7 @@ maven-ant-tasks-*.jar
 thumbs.db
 Thumbs.db
 bin/setenv.*
+java/org/apache/catalina/startup/catalina.properties
 modules/jdbc-pool/bin
 modules/jdbc-pool/includes
+webapps/docs/jdbc-pool.xml
\ No newline at end of file



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1209686 [2/2] - in /tomcat/trunk: java/org/apache/catalina/core/ java/org/apache/catalina/loader/ java/org/apache/catalina/startup/ java/org/apache/naming/resources/ test/org/apache/catal

2011-12-02 Thread slaurent

Propchange: 
tomcat/trunk/test/webapp-3.0-virtual-webapp/src/main/webapp2/rsrc/resourceH.properties
--
svn:eol-style = native

Added: 
tomcat/trunk/test/webapp-3.0-virtual-webapp/src/main/webapp2/rsrc2/resourceJ.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/webapp-3.0-virtual-webapp/src/main/webapp2/rsrc2/resourceJ.properties?rev=1209686view=auto
==
--- 
tomcat/trunk/test/webapp-3.0-virtual-webapp/src/main/webapp2/rsrc2/resourceJ.properties
 (added)
+++ 
tomcat/trunk/test/webapp-3.0-virtual-webapp/src/main/webapp2/rsrc2/resourceJ.properties
 Fri Dec  2 20:49:50 2011
@@ -0,0 +1,16 @@
+#  Licensed to the Apache Software Foundation (ASF) under one or more
+#  contributor license agreements.  See the NOTICE file distributed with
+#  this work for additional information regarding copyright ownership.
+#  The ASF licenses this file to You under the Apache License, Version 2.0
+#  (the License); you may not use this file except in compliance with
+#  the License.  You may obtain a copy of the License at
+#
+#  http://www.apache.org/licenses/LICENSE-2.0
+#
+#  Unless required by applicable law or agreed to in writing, software
+#  distributed under the License is distributed on an AS IS BASIS,
+#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#  See the License for the specific language governing permissions and
+#  limitations under the License.
+
+resourceJInWebapp=true

Propchange: 
tomcat/trunk/test/webapp-3.0-virtual-webapp/src/main/webapp2/rsrc2/resourceJ.properties
--
svn:eol-style = native

Modified: tomcat/trunk/webapps/docs/config/context.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/context.xml?rev=1209686r1=1209685r2=1209686view=diff
==
--- tomcat/trunk/webapps/docs/config/context.xml (original)
+++ tomcat/trunk/webapps/docs/config/context.xml Fri Dec  2 20:49:50 2011
@@ -539,6 +539,8 @@
 codedocBase/code instead./p
 pThese external locations will not be emptied if the context
 is un-deployed./p
+pA more powerful feature (for development only) is 
+a href=#Virtual_webappVirtual webapp/a./p
   /attribute
 
   attribute name=allowLinking required=false
@@ -1251,6 +1253,82 @@
 
   /subsection
 
+  subsection name=Virtual webapp
+pDuring development it may be more productive to avoid copying files 
(static 
+resources, JSPs, classes, jars...) and configure tomcat to use files from 
their
+source locations. To do that, several customisations of the context 
configuration are 
+required:/p
+ul
+  liThe codeVirtualDirContext/code implementation of 
+  a href=resources.htmlResources/a/li
+  liThe codeVirtualWebappLoader/code implementation of 
+  a href=loader.htmlLoader/a/li
+  licodescanAllDirectories=true/code on the a 
href=jar-scanner.htmlJarScanner/a/li
+/ul
+pTo illustrate this feature, here is an example of a standard maven 
webapp source tree:/p
+source
+mywebapp/
+ src/
+ main/
+  java/
+  resources/
+  webapp/
+ WEB-INF/
+ classes/
+ target/
+classes/
+/source
+pTo deploy such an application (assuming it also uses the log4j maven 
artefact), 
+the context configuration looks like:/p
+source
+lt;Context path=/mywebapp docBase=/Users/theuser/mywebapp/src/main/webapp 

+  lt;Resources className=org.apache.naming.resources.VirtualDirContext 
+
extraResourcePaths=/WEB-INF/classes=/Users/theuser/mywebapp/target/classes /
+  lt;Loader className=org.apache.catalina.loader.VirtualWebappLoader
+ 
virtualClasspath=/Users/theuser/mywebapp/target/classes;/Users/theuser/.m2/repository/log4j/log4j/1.2.15/log4j-1.2.15.jar
 /
+  lt;JarScanner scanAllDirectories=true /
+lt;/Context
+/source
+
+pHere is another example where the webapp serves pictures under 
/pictures and movies
+under /movies and also depends on another maven project mylib that would 
normally 
+produce a jar to be packaged in WEB-INF/lib:/p
+source
+mylib/
+  src/
+  main/
+   java/
+   resources/
+ META-INF/
+  resources/
+  target/
+ classes/
+mymovies/
+mypictures/
+mywebapp/
+ src/
+ main/
+  java/
+  resources/
+  webapp/
+ WEB-INF/
+ classes/
+ target/
+classes/
+/source
+pThe configuration is:/p
+source
+lt;Context

Re: svn commit: r1209686 [1/2] - in /tomcat/trunk: java/org/apache/catalina/core/ java/org/apache/catalina/loader/ java/org/apache/catalina/startup/ java/org/apache/naming/resources/ test/org/apache/c

On 02/12/2011 20:49, slaur...@apache.org wrote:
 Author: slaurent
 Date: Fri Dec  2 20:49:50 2011
 New Revision: 1209686
 
 URL: http://svn.apache.org/viewvc?rev=1209686view=rev
 Log:
 bug 51741: Eclipse WTP Serve modules without publishing broken with
 tc7, needs patch in tomcat 
 https://issues.apache.org/bugzilla/show_bug.cgi?id=51741

You need to run checkstyle on this. There are a number of issues including:
- files without license headers
- files with license headers that do not use the expected layout
- an import from o.a.catlina used within o.a.naming wich is not permitted

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

buildbot failure in ASF Buildbot on tomcat-trunk

2011-12-02 Thread buildbot

The Buildbot has detected a new failure on builder tomcat-trunk while building 
ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/tomcat-trunk/builds/2564

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: bb-vm_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch tomcat/trunk] 1209686
Blamelist: slaurent

BUILD FAILED: failed compile_1

sincerely,
 -The Buildbot

Re: svn commit: r1209686 [1/2] - in /tomcat/trunk: java/org/apache/catalina/core/ java/org/apache/catalina/loader/ java/org/apache/catalina/startup/ java/org/apache/naming/resources/ test/org/apache/c

On 02/12/2011 21:08, Mark Thomas wrote:
 On 02/12/2011 20:49, slaur...@apache.org wrote:
 Author: slaurent
 Date: Fri Dec  2 20:49:50 2011
 New Revision: 1209686

 URL: http://svn.apache.org/viewvc?rev=1209686view=rev
 Log:
 bug 51741: Eclipse WTP Serve modules without publishing broken with
 tc7, needs patch in tomcat 
 https://issues.apache.org/bugzilla/show_bug.cgi?id=51741
 
 You need to run checkstyle on this. There are a number of issues including:
 - files without license headers
 - files with license headers that do not use the expected layout
 - an import from o.a.catlina used within o.a.naming wich is not permitted

Just seen that this is unused which makes this an easy fix.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1209686 [1/2] - in /tomcat/trunk: java/org/apache/catalina/core/ java/org/apache/catalina/loader/ java/org/apache/catalina/startup/ java/org/apache/naming/resources/ test/org/apache/c

2011-12-02 Thread Sylvain Laurent

good catch. Actually I did perform a ant test to check that all tests pass, but 
the validate target is not run by default. Why isn't it enabled by default ?

Sylvain

On 2 déc. 2011, at 22:08, Mark Thomas wrote:

 On 02/12/2011 20:49, slaur...@apache.org wrote:
 Author: slaurent
 Date: Fri Dec  2 20:49:50 2011
 New Revision: 1209686
 
 URL: http://svn.apache.org/viewvc?rev=1209686view=rev
 Log:
 bug 51741: Eclipse WTP Serve modules without publishing broken with
 tc7, needs patch in tomcat 
 https://issues.apache.org/bugzilla/show_bug.cgi?id=51741
 
 You need to run checkstyle on this. There are a number of issues including:
 - files without license headers
 - files with license headers that do not use the expected layout
 - an import from o.a.catlina used within o.a.naming wich is not permitted
 
 Mark
 
 -
 To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
 For additional commands, e-mail: dev-h...@tomcat.apache.org
 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1209686 [1/2] - in /tomcat/trunk: java/org/apache/catalina/core/ java/org/apache/catalina/loader/ java/org/apache/catalina/startup/ java/org/apache/naming/resources/ test/org/apache/c

On 02/12/2011 21:20, Mark Thomas wrote:
 On 02/12/2011 21:08, Mark Thomas wrote:
 On 02/12/2011 20:49, slaur...@apache.org wrote:
 Author: slaurent
 Date: Fri Dec  2 20:49:50 2011
 New Revision: 1209686

 URL: http://svn.apache.org/viewvc?rev=1209686view=rev
 Log:
 bug 51741: Eclipse WTP Serve modules without publishing broken with
 tc7, needs patch in tomcat 
 https://issues.apache.org/bugzilla/show_bug.cgi?id=51741

 You need to run checkstyle on this. There are a number of issues including:
 - files without license headers
 - files with license headers that do not use the expected layout
 - an import from o.a.catlina used within o.a.naming wich is not permitted
 
 Just seen that this is unused which makes this an easy fix.

They were all easy and fixing the failures was just as easy as skipping
the checks. Patch applied to trunk.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1209694 - in /tomcat/trunk: java/org/apache/catalina/loader/ java/org/apache/naming/resources/ test/org/apache/catalina/loader/ test/webapp-3.0-virtual-webapp/src/main/webapp2/rsrc/

2011-12-02 Thread markt

Author: markt
Date: Fri Dec  2 21:25:49 2011
New Revision: 1209694

URL: http://svn.apache.org/viewvc?rev=1209694view=rev
Log:
Fix checkstyle errors

Modified:
tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java
tomcat/trunk/java/org/apache/naming/resources/VirtualDirContext.java
tomcat/trunk/test/org/apache/catalina/loader/EchoTag.java
tomcat/trunk/test/org/apache/catalina/loader/MyAnnotatedServlet.java
tomcat/trunk/test/org/apache/catalina/loader/TestVirtualContext.java

tomcat/trunk/test/webapp-3.0-virtual-webapp/src/main/webapp2/rsrc/resourceF.properties

Modified: tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java?rev=1209694r1=1209693r2=1209694view=diff
==
--- tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/loader/WebappClassLoader.java Fri Dec 
 2 21:25:49 2011
@@ -1341,7 +1341,7 @@ public class WebappClassLoader
 }
 
 }
-
+
 final IteratorURL iterator = result.iterator();
 
 return new EnumerationURL() {

Modified: tomcat/trunk/java/org/apache/naming/resources/VirtualDirContext.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/naming/resources/VirtualDirContext.java?rev=1209694r1=1209693r2=1209694view=diff
==
--- tomcat/trunk/java/org/apache/naming/resources/VirtualDirContext.java 
(original)
+++ tomcat/trunk/java/org/apache/naming/resources/VirtualDirContext.java Fri 
Dec  2 21:25:49 2011
@@ -28,7 +28,6 @@ import java.util.StringTokenizer;
 import javax.naming.NamingException;
 import javax.naming.directory.Attributes;
 
-import org.apache.catalina.loader.VirtualWebappLoader;
 import org.apache.naming.NamingEntry;
 
 /**
@@ -36,9 +35,9 @@ import org.apache.naming.NamingEntry;
  * directories of the filesystem under a single webapp, a feature mainly used
  * for development with IDEs.
  * This should be used in conjunction with {@link VirtualWebappLoader}.
- * 
+ *
  * Sample context xml configuration:
- * 
+ *
  * code
  * lt;Context path=/mywebapp 
docBase=/Users/theuser/mywebapp/src/main/webapp 
  *   lt;Resources className=org.apache.naming.resources.VirtualDirContext
@@ -48,13 +47,13 @@ import org.apache.naming.NamingEntry;
  *   lt;JarScanner scanAllDirectories=true /
  * lt;/Context
  * /code
- * 
- * 
+ *
+ *
  * strongThis is not meant to be used for production.
  * Its meant to ease development with IDE's without the
  * need for fully republishing jars in WEB-INF/lib/strong
- * 
- * 
+ *
+ *
  * @author Fabrizio Giustina
  * @version $Id$
  */
@@ -76,7 +75,7 @@ public class VirtualDirContext extends F
  * The path to the docBase must not be added here, otherwise resources 
would
  * be listed twice.
  * /p
- * 
+ *
  * @param path
  */
 public void setExtraResourcePaths(String path) {

Modified: tomcat/trunk/test/org/apache/catalina/loader/EchoTag.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/loader/EchoTag.java?rev=1209694r1=1209693r2=1209694view=diff
==
--- tomcat/trunk/test/org/apache/catalina/loader/EchoTag.java (original)
+++ tomcat/trunk/test/org/apache/catalina/loader/EchoTag.java Fri Dec  2 
21:25:49 2011
@@ -1,3 +1,19 @@
+/*
+ *  Licensed to the Apache Software Foundation (ASF) under one or more
+ *  contributor license agreements.  See the NOTICE file distributed with
+ *  this work for additional information regarding copyright ownership.
+ *  The ASF licenses this file to You under the Apache License, Version 2.0
+ *  (the License); you may not use this file except in compliance with
+ *  the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing, software
+ *  distributed under the License is distributed on an AS IS BASIS,
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  See the License for the specific language governing permissions and
+ *  limitations under the License.
+ */
 package org.apache.catalina.loader;
 
 import java.io.IOException;

Modified: tomcat/trunk/test/org/apache/catalina/loader/MyAnnotatedServlet.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/loader/MyAnnotatedServlet.java?rev=1209694r1=1209693r2=1209694view=diff
==
--- tomcat/trunk/test/org/apache/catalina/loader/MyAnnotatedServlet.java 
(original)
+++ tomcat/trunk/test/org/apache/catalina/loader/MyAnnotatedServlet.java Fri 
Dec  2 21:25:49 2011
@@ -1,3 +1,19 @@
+/*
+ *

Re: svn commit: r1209686 [1/2] - in /tomcat/trunk: java/org/apache/catalina/core/ java/org/apache/catalina/loader/ java/org/apache/catalina/startup/ java/org/apache/naming/resources/ test/org/apache/c

On 02/12/2011 21:25, Sylvain Laurent wrote:
 good catch. Actually I did perform a ant test to check that all tests
 pass, but the validate target is not run by default. Why isn't it
 enabled by default ?

Because Checkstyle uses a license (LGPL?) that is not AL2 compatible so
we require explicit enabling of those checks in build.properties. There
should be a comment to that effect in build.properties.default.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1209731 - in /tomcat/trunk: ./ test/org/apache/catalina/loader/ test/webapp-3.0-virtual-library/ test/webapp-3.0-virtual-library/target/ test/webapp-3.0-virtual-library/target/classes/ te

2011-12-02 Thread slaurent

Author: slaurent
Date: Fri Dec  2 22:16:33 2011
New Revision: 1209731

URL: http://svn.apache.org/viewvc?rev=1209731view=rev
Log:
bug 51741: Eclipse WTP Serve modules without publishing broken with
tc7, needs patch in tomcat 
https://issues.apache.org/bugzilla/show_bug.cgi?id=51741

fixed checkstyle problems + missing files in target directories
because it was in gitignore

Added:
tomcat/trunk/test/webapp-3.0-virtual-library/
tomcat/trunk/test/webapp-3.0-virtual-library/target/
tomcat/trunk/test/webapp-3.0-virtual-library/target/classes/
tomcat/trunk/test/webapp-3.0-virtual-library/target/classes/META-INF/
tomcat/trunk/test/webapp-3.0-virtual-library/target/classes/META-INF/C.tld
  - copied, changed from r1209694, 
tomcat/trunk/test/webapp-3.0-virtual-webapp/src/main/webapp/WEB-INF/web.xml

tomcat/trunk/test/webapp-3.0-virtual-library/target/classes/META-INF/resources/

tomcat/trunk/test/webapp-3.0-virtual-library/target/classes/META-INF/resources/rsrc/

tomcat/trunk/test/webapp-3.0-virtual-library/target/classes/META-INF/resources/rsrc/resourceE.properties
  - copied, changed from r1209694, 
tomcat/trunk/test/webapp-3.0-virtual-webapp/src/main/webapp2/rsrc/resourceF.properties
tomcat/trunk/test/webapp-3.0-virtual-library/target/classes/rsrc/

tomcat/trunk/test/webapp-3.0-virtual-library/target/classes/rsrc/resourceC.properties
  - copied, changed from r1209694, 
tomcat/trunk/test/webapp-3.0-virtual-webapp/src/main/webapp2/rsrc/resourceF.properties
tomcat/trunk/test/webapp-3.0-virtual-webapp/target/
tomcat/trunk/test/webapp-3.0-virtual-webapp/target/classes/
tomcat/trunk/test/webapp-3.0-virtual-webapp/target/classes/rsrc/

tomcat/trunk/test/webapp-3.0-virtual-webapp/target/classes/rsrc/resourceB.properties
  - copied, changed from r1209694, 
tomcat/trunk/test/webapp-3.0-virtual-webapp/src/main/webapp2/rsrc/resourceF.properties
Removed:

tomcat/trunk/test/webapp-3.0-virtual-webapp/src/main/webapp/META-INF/context.xml
Modified:
tomcat/trunk/.gitignore
tomcat/trunk/test/org/apache/catalina/loader/TestVirtualContext.java
tomcat/trunk/test/webapp-3.0-virtual-webapp/src/main/webapp/WEB-INF/web.xml

tomcat/trunk/test/webapp-3.0-virtual-webapp/src/main/webapp/contextGetResource.jsp

tomcat/trunk/test/webapp-3.0-virtual-webapp/src/main/webapp/contextGetResourcePaths.jsp

tomcat/trunk/test/webapp-3.0-virtual-webapp/src/main/webapp2/rsrc/resourceF.properties
tomcat/trunk/webapps/docs/config/context.xml
tomcat/trunk/webapps/docs/config/resources.xml

Modified: tomcat/trunk/.gitignore
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/.gitignore?rev=1209731r1=1209730r2=1209731view=diff
==
--- tomcat/trunk/.gitignore (original)
+++ tomcat/trunk/.gitignore Fri Dec  2 22:16:33 2011
@@ -14,7 +14,6 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 # -
-target
 output
 logs
 work

Modified: tomcat/trunk/test/org/apache/catalina/loader/TestVirtualContext.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/loader/TestVirtualContext.java?rev=1209731r1=1209730r2=1209731view=diff
==
--- tomcat/trunk/test/org/apache/catalina/loader/TestVirtualContext.java 
(original)
+++ tomcat/trunk/test/org/apache/catalina/loader/TestVirtualContext.java Fri 
Dec  2 22:16:33 2011
@@ -25,10 +25,10 @@ import java.io.InputStream;
 import java.util.Arrays;
 import java.util.HashSet;
 
-import junit.framework.Assert;
-
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertTrue;
+
+import org.junit.Assert;
 import org.junit.Test;
 
 import org.apache.catalina.core.JreMemoryLeakPreventionListener;

Copied: 
tomcat/trunk/test/webapp-3.0-virtual-library/target/classes/META-INF/C.tld 
(from r1209694, 
tomcat/trunk/test/webapp-3.0-virtual-webapp/src/main/webapp/WEB-INF/web.xml)
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/webapp-3.0-virtual-library/target/classes/META-INF/C.tld?p2=tomcat/trunk/test/webapp-3.0-virtual-library/target/classes/META-INF/C.tldp1=tomcat/trunk/test/webapp-3.0-virtual-webapp/src/main/webapp/WEB-INF/web.xmlr1=1209694r2=1209731rev=1209731view=diff
==
--- tomcat/trunk/test/webapp-3.0-virtual-webapp/src/main/webapp/WEB-INF/web.xml 
(original)
+++ tomcat/trunk/test/webapp-3.0-virtual-library/target/classes/META-INF/C.tld 
Fri Dec  2 22:16:33 2011
@@ -1,4 +1,4 @@
-?xml version=1.0 encoding=ISO-8859-1?
+?xml version=1.0 encoding=ISO-8859-1 ?
 !--
   Licensed to the Apache Software Foundation (ASF) under one or more
   contributor license agreements.  See the NOTICE file distributed with
@@ -14,11 +14,24 @@
   WITHOUT

Re: buildbot failure in ASF Buildbot on tomcat-trunk

2011-12-02 Thread Sylvain Laurent

should be fixed with r1209731

On 2 déc. 2011, at 22:19, build...@apache.org wrote:

 The Buildbot has detected a new failure on builder tomcat-trunk while 
 building ASF Buildbot.
 Full details are available at:
 http://ci.apache.org/builders/tomcat-trunk/builds/2564
 
 Buildbot URL: http://ci.apache.org/
 
 Buildslave for this Build: bb-vm_ubuntu
 
 Build Reason: scheduler
 Build Source Stamp: [branch tomcat/trunk] 1209686
 Blamelist: slaurent
 
 BUILD FAILED: failed compile_1
 
 sincerely,
 -The Buildbot
 
 
 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

DO NOT REPLY [Bug 51741] Eclipse WTP Serve modules without publishing broken with tc7, needs patch in tomcat