Re: [Vote] Add comments.apache.org to Tomcat docs

2012-11-26 Thread Konstantin Kolinko
2012/11/21 Rainer Jung rainer.j...@kippdata.de:

 Integrate comments.apache.org with TC 7 docs on tomcat.apache.org:

 [x] +1, go ahead
 [  ]  0, I don't care
 [  ] -1, Don't integrate, because ...


Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 54208] New: ant extras build task fails

2012-11-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54208

Bug ID: 54208
   Summary: ant extras build task fails
   Product: Tomcat 7
   Version: 7.0.33
  Hardware: Other
OS: other
Status: NEW
  Severity: normal
  Priority: P2
 Component: Packaging
  Assignee: dev@tomcat.apache.org
  Reporter: e...@iki.fi
Classification: Unclassified

Trying to compile the 'extras' target for Tomcat 7.0.33 source distribution.
Compiling on OS X 10.8, java 1.6, ant 1.8.4, using command:
ant deploy extras

Build fails in the target extras - extras-commons-logging - ... -
compile-non-log4j, with the error package javax.servlet does not exist and
related further errors due to incomplete class path.

The fix is to edit the top level build.xml, under target
'extras-commons-logging', specifically the ant task on line 1287, by adding
parameter
inheritAll=false

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1413550 - in /tomcat/trunk: ./ java/javax/websocket/ java/org/apache/tomcat/websocket/ java/org/apache/websocket/ res/META-INF/tomcat-websocket.jar/ res/META-INF/tomcat-websocket.jar/serv

2012-11-26 Thread markt
Author: markt
Date: Mon Nov 26 10:54:46 2012
New Revision: 1413550

URL: http://svn.apache.org/viewvc?rev=1413550view=rev
Log:
Re-package as per kkolinko's review

Added:
tomcat/trunk/java/org/apache/tomcat/websocket/
  - copied from r1413281, tomcat/trunk/java/org/apache/websocket/
tomcat/trunk/res/META-INF/tomcat-websocket.jar/
  - copied from r1413281, tomcat/trunk/res/META-INF/websocket-impl.jar/
tomcat/trunk/test/org/apache/tomcat/websocket/
  - copied from r1413281, tomcat/trunk/test/org/apache/websocket/
Removed:
tomcat/trunk/java/org/apache/websocket/
tomcat/trunk/res/META-INF/websocket-impl.jar/
tomcat/trunk/test/org/apache/websocket/
Modified:
tomcat/trunk/build.xml
tomcat/trunk/java/javax/websocket/ContainerProvider.java
tomcat/trunk/java/org/apache/tomcat/websocket/ClientContainerImpl.java
tomcat/trunk/java/org/apache/tomcat/websocket/ServerContainerImpl.java
tomcat/trunk/java/org/apache/tomcat/websocket/Util.java
tomcat/trunk/java/org/apache/tomcat/websocket/WsSci.java
tomcat/trunk/java/org/apache/tomcat/websocket/WsServlet.java

tomcat/trunk/res/META-INF/tomcat-websocket.jar/services/javax.servlet.ServletContainerInitializer
tomcat/trunk/res/checkstyle/org-import-control.xml
tomcat/trunk/test/org/apache/tomcat/websocket/TestUtil.java

Modified: tomcat/trunk/build.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=1413550r1=1413549r2=1413550view=diff
==
--- tomcat/trunk/build.xml (original)
+++ tomcat/trunk/build.xml Mon Nov 26 10:54:46 2012
@@ -89,7 +89,7 @@
   property name=jsp-api.jar value=${tomcat.build}/lib/jsp-api.jar/
   property name=el-api.jar value=${tomcat.build}/lib/el-api.jar/
   property name=websocket-api.jar 
value=${tomcat.build}/lib/websocket-api.jar/
-  property name=websocket-impl.jar 
value=${tomcat.build}/lib/websocket-impl.jar/
+  property name=tomcat-websocket.jar 
value=${tomcat.build}/lib/tomcat-websocket.jar/
   property name=catalina.jar value=${tomcat.build}/lib/catalina.jar/
   property name=catalina-tribes.jar 
value=${tomcat.build}/lib/catalina-tribes.jar/
   property name=catalina-ha.jar 
value=${tomcat.build}/lib/catalina-ha.jar/
@@ -115,7 +115,7 @@
   property name=jsp-api-src.jar value=${tomcat.src.jars}/jsp-api-src.jar/
   property name=el-api-src.jar value=${tomcat.src.jars}/el-api-src.jar/
   property name=websocket-api-src.jar 
value=${tomcat.src.jars}/websocket-api-src.jar/
-  property name=websocket-impl-src.jar 
value=${tomcat.src.jars}/websocket-impl-src.jar/
+  property name=tomcat-websocket-src.jar 
value=${tomcat.src.jars}/tomcat-websocket-src.jar/
   property name=catalina-src.jar 
value=${tomcat.src.jars}/catalina-src.jar/
   property name=catalina-tribes-src.jar 
value=${tomcat.src.jars}/catalina-tribes-src.jar/
   property name=catalina-ha-src.jar 
value=${tomcat.src.jars}/catalina-ha-src.jar/
@@ -287,8 +287,8 @@
 include name=javax/websocket/** /
   /patternset
 
-  patternset id=files.websocket-impl
-include name=org/apache/websocket/** /
+  patternset id=files.tomcat-websocket
+include name=org/apache/tomcat/websocket/** /
   /patternset
 
   patternset id=files.bootstrap
@@ -382,7 +382,7 @@
 patternset refid=files.el-api /
 patternset refid=files.servlet-api /
 patternset refid=files.websocket-api /
-patternset refid=files.websocket-impl /
+patternset refid=files.tomcat-websocket /
 patternset refid=files.tomcat-api /
 !-- These pattern sets conflict so include files directly
   patternset refid=files.tomcat-coyote /
@@ -670,10 +670,10 @@
   manifest=${tomcat.manifests}/websocket-api.jar.manifest /
 
 !-- WebSocket 1.0 implementation JAR File --
-jarIt jarfile=${websocket-impl.jar}
+jarIt jarfile=${tomcat-websocket.jar}
   filesDir=${tomcat.classes}
-  filesId=files.websocket-impl
-  meta-inf=${tomcat.manifests}/websocket-impl.jar/
+  filesId=files.tomcat-websocket
+  meta-inf=${tomcat.manifests}/tomcat-websocket.jar/
 
 !-- Bootstrap JAR File --
 jarIt jarfile=${bootstrap.jar}
@@ -1723,7 +1723,7 @@ Apache Tomcat ${version} native binaries
 include name=jasper-el.jar/
 include name=servlet-api.jar/
 include name=websocket-api.jar/
-include name=websocket-impl.jar/
+include name=tomcat-websocket.jar/
 include name=tomcat-coyote.jar/
 include name=tomcat-util.jar/
   /fileset
@@ -2260,9 +2260,9 @@ Apache Tomcat ${version} native binaries
   manifest=${tomcat.manifests}/websocket-api.jar.manifest /
 
 !-- WebSocket 1.0 implementation JAR File --
-jarIt jarfile=${websocket-impl-src.jar}
+jarIt jarfile=${tomcat-websocket-src.jar}
   filesDir=java
-  filesId=files.websocket-impl /
+  filesId=files.tomcat-websocket /
 
 !-- Bootstrap JAR File --
 jarIt jarfile=${bootstrap-src.jar}

Modified: 

svn commit: r1413552 - /tomcat/trunk/java/javax/servlet/http/HttpServletResponse.java

2012-11-26 Thread markt
Author: markt
Date: Mon Nov 26 11:08:02 2012
New Revision: 1413552

URL: http://svn.apache.org/viewvc?rev=1413552view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54198
Clarify that sendError(int) results in an HTML response.

Modified:
tomcat/trunk/java/javax/servlet/http/HttpServletResponse.java

Modified: tomcat/trunk/java/javax/servlet/http/HttpServletResponse.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/javax/servlet/http/HttpServletResponse.java?rev=1413552r1=1413551r2=1413552view=diff
==
--- tomcat/trunk/java/javax/servlet/http/HttpServletResponse.java (original)
+++ tomcat/trunk/java/javax/servlet/http/HttpServletResponse.java Mon Nov 26 
11:08:02 2012
@@ -116,13 +116,13 @@ public interface HttpServletResponse ext
 public String encodeRedirectUrl(String url);
 
 /**
- * Sends an error response to the client using the specified status. The
- * server defaults to creating the response to look like an HTML-formatted
- * server error page containing the specified message, setting the content
- * type to text/html, leaving cookies and other headers unmodified. If an
- * error-page declaration has been made for the web application
- * corresponding to the status code passed in, it will be served back in
- * preference to the suggested msg parameter.
+ * Sends an error response to the client using the specified status code 
and
+ * clears the output buffer. The server defaults to creating the response 
to
+ * look like an HTML-formatted server error page containing the specified
+ * message, setting the content type to text/html, leaving cookies and
+ * other headers unmodified. If an error-page declaration has been made for
+ * the web application corresponding to the status code passed in, it will
+ * be served back in preference to the suggested msg parameter.
  * p
  * If the response has already been committed, this method throws an
  * IllegalStateException. After using this method, the response should be
@@ -141,11 +141,8 @@ public interface HttpServletResponse ext
 
 /**
  * Sends an error response to the client using the specified status code 
and
- * clearing the buffer.
- * p
- * If the response has already been committed, this method throws an
- * IllegalStateException. After using this method, the response should be
- * considered to be committed and should not be written to.
+ * clears the buffer. This is equivalent to calling {@link #sendError(int,
+ * String)} with the same status code and codenull/code for the 
message.
  *
  * @param sc
  *the error status code



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1413553 - in /tomcat/tc7.0.x/trunk: ./ java/javax/servlet/http/HttpServletResponse.java webapps/docs/changelog.xml

2012-11-26 Thread markt
Author: markt
Date: Mon Nov 26 11:12:12 2012
New Revision: 1413553

URL: http://svn.apache.org/viewvc?rev=1413553view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54198
Clarify that sendError(int) results in an HTML response.

Modified:
tomcat/tc7.0.x/trunk/   (props changed)
tomcat/tc7.0.x/trunk/java/javax/servlet/http/HttpServletResponse.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc7.0.x/trunk/
--
  Merged /tomcat/trunk:r1413552

Modified: tomcat/tc7.0.x/trunk/java/javax/servlet/http/HttpServletResponse.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/javax/servlet/http/HttpServletResponse.java?rev=1413553r1=1413552r2=1413553view=diff
==
--- tomcat/tc7.0.x/trunk/java/javax/servlet/http/HttpServletResponse.java 
(original)
+++ tomcat/tc7.0.x/trunk/java/javax/servlet/http/HttpServletResponse.java Mon 
Nov 26 11:12:12 2012
@@ -116,13 +116,13 @@ public interface HttpServletResponse ext
 public String encodeRedirectUrl(String url);
 
 /**
- * Sends an error response to the client using the specified status. The
- * server defaults to creating the response to look like an HTML-formatted
- * server error page containing the specified message, setting the content
- * type to text/html, leaving cookies and other headers unmodified. If an
- * error-page declaration has been made for the web application
- * corresponding to the status code passed in, it will be served back in
- * preference to the suggested msg parameter.
+ * Sends an error response to the client using the specified status code 
and
+ * clears the output buffer. The server defaults to creating the response 
to
+ * look like an HTML-formatted server error page containing the specified
+ * message, setting the content type to text/html, leaving cookies and
+ * other headers unmodified. If an error-page declaration has been made for
+ * the web application corresponding to the status code passed in, it will
+ * be served back in preference to the suggested msg parameter.
  * p
  * If the response has already been committed, this method throws an
  * IllegalStateException. After using this method, the response should be
@@ -141,11 +141,8 @@ public interface HttpServletResponse ext
 
 /**
  * Sends an error response to the client using the specified status code 
and
- * clearing the buffer.
- * p
- * If the response has already been committed, this method throws an
- * IllegalStateException. After using this method, the response should be
- * considered to be committed and should not be written to.
+ * clears the buffer. This is equivalent to calling {@link #sendError(int,
+ * String)} with the same status code and codenull/code for the 
message.
  * 
  * @param sc
  *the error status code

Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1413553r1=1413552r2=1413553view=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Mon Nov 26 11:12:12 2012
@@ -66,6 +66,15 @@
   /fix
 /changelog
   /subsection
+  subsection name=Web applications
+changelog
+  fix
+bug54198/bug: Clarify that
+codeHttpServletResponse.sendError(int)/code results in an HTML
+response by default. (markt)
+  /fix
+/changelog
+  /subsection
   subsection name=Other
 changelog
   update



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 54194] NPE in DataSource.registerJmx() although DataSource is created with setJmxEnabled(false)

2012-11-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54194

tobias.gie...@voipfuture.com changed:

   What|Removed |Added

 CC||tobias.gie...@voipfuture.co
   ||m
   Severity|normal  |minor

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1413554 - in /tomcat/tc6.0.x/trunk: ./ java/javax/servlet/http/HttpServletResponse.java webapps/docs/changelog.xml

2012-11-26 Thread markt
Author: markt
Date: Mon Nov 26 11:19:56 2012
New Revision: 1413554

URL: http://svn.apache.org/viewvc?rev=1413554view=rev
Log:
CTR - Docs
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54198
Clarify that sendError(int) results in an HTML response.

Modified:
tomcat/tc6.0.x/trunk/   (props changed)
tomcat/tc6.0.x/trunk/java/javax/servlet/http/HttpServletResponse.java
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc6.0.x/trunk/
--
  Merged /tomcat/trunk:r1413552
  Merged /tomcat/tc7.0.x/trunk:r1413553

Modified: tomcat/tc6.0.x/trunk/java/javax/servlet/http/HttpServletResponse.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/javax/servlet/http/HttpServletResponse.java?rev=1413554r1=1413553r2=1413554view=diff
==
--- tomcat/tc6.0.x/trunk/java/javax/servlet/http/HttpServletResponse.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/javax/servlet/http/HttpServletResponse.java Mon 
Nov 26 11:19:56 2012
@@ -131,41 +131,41 @@ public interface HttpServletResponse ext
 public String encodeRedirectUrl(String url);
 
 /**
- * Sends an error response to the client using the specified
- * status.  The server defaults to creating the
- * response to look like an HTML-formatted server error page
- * containing the specified message, setting the content type
- * to text/html, leaving cookies and other headers unmodified.
- *
- * If an error-page declaration has been made for the web application
- * corresponding to the status code passed in, it will be served back in 
- * preference to the suggested msg parameter. 
- *
- * pIf the response has already been committed, this method throws 
- * an IllegalStateException.
- * After using this method, the response should be considered
- * to be committed and should not be written to.
- *
- * @param  sc  the error status code
- * @param  msg the descriptive message
- * @exception  IOException If an input or output exception occurs
- * @exception  IllegalStateException   If the response was committed
+ * Sends an error response to the client using the specified status code 
and
+ * clears the output buffer. The server defaults to creating the response 
to
+ * look like an HTML-formatted server error page containing the specified
+ * message, setting the content type to text/html, leaving cookies and
+ * other headers unmodified. If an error-page declaration has been made for
+ * the web application corresponding to the status code passed in, it will
+ * be served back in preference to the suggested msg parameter.
+ * p
+ * If the response has already been committed, this method throws an
+ * IllegalStateException. After using this method, the response should be
+ * considered to be committed and should not be written to.
+ * 
+ * @param sc
+ *the error status code
+ * @param msg
+ *the descriptive message
+ * @exception IOException
+ *If an input or output exception occurs
+ * @exception IllegalStateException
+ *If the response was committed
  */

 public void sendError(int sc, String msg) throws IOException;
 
 /**
- * Sends an error response to the client using the specified status
- * code and clearing the buffer. 
- * pIf the response has already been committed, this method throws 
- * an IllegalStateException.
- * After using this method, the response should be considered
- * to be committed and should not be written to.
- *
- * @param  sc  the error status code
- * @exception  IOException If an input or output exception occurs
- * @exception  IllegalStateException   If the response was committed
- * before this method call
+ * Sends an error response to the client using the specified status code 
and
+ * clears the buffer. This is equivalent to calling {@link #sendError(int,
+ * String)} with the same status code and codenull/code for the 
message.
+ * 
+ * @param sc
+ *the error status code
+ * @exception IOException
+ *If an input or output exception occurs
+ * @exception IllegalStateException
+ *If the response was committed before this method call
  */
 
 public void sendError(int sc) throws IOException;

Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=1413554r1=1413553r2=1413554view=diff
==
--- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original)
+++ 

[Bug 54198] Improve HttpServletResponse#sendError(int) JavaDoc description

2012-11-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54198

Mark Thomas ma...@apache.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #3 from Mark Thomas ma...@apache.org ---
Fixed in trunk, 7.0.x and 6.0.x. Will be included in 7.0.34 and 6.0.37.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1413556 - /tomcat/trunk/java/org/apache/naming/java/javaURLContextFactory.java

2012-11-26 Thread markt
Author: markt
Date: Mon Nov 26 11:29:15 2012
New Revision: 1413556

URL: http://svn.apache.org/viewvc?rev=1413556view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54207
Correct package name in Javadoc

Modified:
tomcat/trunk/java/org/apache/naming/java/javaURLContextFactory.java

Modified: tomcat/trunk/java/org/apache/naming/java/javaURLContextFactory.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/naming/java/javaURLContextFactory.java?rev=1413556r1=1413555r2=1413556view=diff
==
--- tomcat/trunk/java/org/apache/naming/java/javaURLContextFactory.java 
(original)
+++ tomcat/trunk/java/org/apache/naming/java/javaURLContextFactory.java Mon Nov 
26 11:29:15 2012
@@ -37,7 +37,7 @@ import org.apache.naming.SelectorContext
  * prefix, which can be done by either :
  * ul
  * liAdding a
- * java.naming.factory.url.pkgs=org.apache.catalina.util.naming property
+ * java.naming.factory.url.pkgs=org.apache.naming property
  * to the JNDI properties file/li
  * liSetting an environment variable named Context.URL_PKG_PREFIXES with
  * its value including the org.apache.catalina.util.naming package name.



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1413557 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/naming/java/javaURLContextFactory.java webapps/docs/changelog.xml

2012-11-26 Thread markt
Author: markt
Date: Mon Nov 26 11:31:50 2012
New Revision: 1413557

URL: http://svn.apache.org/viewvc?rev=1413557view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54207
Correct package name in Javadoc

Modified:
tomcat/tc7.0.x/trunk/   (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/naming/java/javaURLContextFactory.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc7.0.x/trunk/
--
  Merged /tomcat/trunk:r1413556

Modified: 
tomcat/tc7.0.x/trunk/java/org/apache/naming/java/javaURLContextFactory.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/naming/java/javaURLContextFactory.java?rev=1413557r1=1413556r2=1413557view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/naming/java/javaURLContextFactory.java 
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/naming/java/javaURLContextFactory.java 
Mon Nov 26 11:31:50 2012
@@ -37,7 +37,7 @@ import org.apache.naming.SelectorContext
  * prefix, which can be done by either :
  * ul
  * liAdding a 
- * java.naming.factory.url.pkgs=org.apache.catalina.util.naming property
+ * java.naming.factory.url.pkgs=org.apache.naming property
  * to the JNDI properties file/li
  * liSetting an environment variable named Context.URL_PKG_PREFIXES with 
  * its value including the org.apache.catalina.util.naming package name. 

Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1413557r1=1413556r2=1413557view=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Mon Nov 26 11:31:50 2012
@@ -73,6 +73,10 @@
 codeHttpServletResponse.sendError(int)/code results in an HTML
 response by default. (markt)
   /fix
+  fix
+bug54207/bug: Correct JNDI factory package name in Javadoc for
+codeorg.apache.naming.java.javaURLContextFactory/code. (markt)
+  /fix
 /changelog
   /subsection
   subsection name=Other



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1413559 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/naming/java/javaURLContextFactory.java webapps/docs/changelog.xml

2012-11-26 Thread markt
Author: markt
Date: Mon Nov 26 11:34:24 2012
New Revision: 1413559

URL: http://svn.apache.org/viewvc?rev=1413559view=rev
Log:
CTR - Docs
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54207
Correct package name in Javadoc

Modified:
tomcat/tc6.0.x/trunk/   (props changed)
tomcat/tc6.0.x/trunk/java/org/apache/naming/java/javaURLContextFactory.java
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc6.0.x/trunk/
--
  Merged /tomcat/trunk:r1413556
  Merged /tomcat/tc7.0.x/trunk:r1413557

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/naming/java/javaURLContextFactory.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/naming/java/javaURLContextFactory.java?rev=1413559r1=1413558r2=1413559view=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/naming/java/javaURLContextFactory.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/naming/java/javaURLContextFactory.java 
Mon Nov 26 11:34:24 2012
@@ -35,7 +35,7 @@ import org.apache.naming.ContextBindings
  * prefix, which can be done by either :
  * ul
  * liAdding a 
- * java.naming.factory.url.pkgs=org.apache.catalina.util.naming property
+ * java.naming.factory.url.pkgs=org.apache.naming property
  * to the JNDI properties file/li
  * liSetting an environment variable named Context.URL_PKG_PREFIXES with 
  * its value including the org.apache.catalina.util.naming package name. 

Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=1413559r1=1413558r2=1413559view=diff
==
--- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Mon Nov 26 11:34:24 2012
@@ -51,6 +51,10 @@
 codeHttpServletResponse.sendError(int)/code results in an HTML
 response by default. (markt)
   /fix
+  fix
+bug54207/bug: Correct JNDI factory package name in Javadoc for
+codeorg.apache.naming.java.javaURLContextFactory/code. (markt)
+  /fix
 /changelog
   /subsection
 /section



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 54207] javaURLContextFactory javadoc refers to defunct package names in initial context properties

2012-11-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54207

Mark Thomas ma...@apache.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED
 OS||All

--- Comment #1 from Mark Thomas ma...@apache.org ---
Fixed in trunk, 7.0.x and 6.0.x. Will be included in 7.0.34 and 6.0.37.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1413562 - /tomcat/trunk/java/org/apache/naming/java/javaURLContextFactory.java

2012-11-26 Thread markt
Author: markt
Date: Mon Nov 26 11:44:20 2012
New Revision: 1413562

URL: http://svn.apache.org/viewvc?rev=1413562view=rev
Log:
Follow up to r1413556

Modified:
tomcat/trunk/java/org/apache/naming/java/javaURLContextFactory.java

Modified: tomcat/trunk/java/org/apache/naming/java/javaURLContextFactory.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/naming/java/javaURLContextFactory.java?rev=1413562r1=1413561r2=1413562view=diff
==
--- tomcat/trunk/java/org/apache/naming/java/javaURLContextFactory.java 
(original)
+++ tomcat/trunk/java/org/apache/naming/java/javaURLContextFactory.java Mon Nov 
26 11:44:20 2012
@@ -40,7 +40,7 @@ import org.apache.naming.SelectorContext
  * java.naming.factory.url.pkgs=org.apache.naming property
  * to the JNDI properties file/li
  * liSetting an environment variable named Context.URL_PKG_PREFIXES with
- * its value including the org.apache.catalina.util.naming package name.
+ * its value including the org.apache.naming package name.
  * More detail about this can be found in the JNDI documentation :
  * {@link javax.naming.spi.NamingManager#getURLContext(java.lang.String, 
java.util.Hashtable)}./li
  * /ul



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1413563 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/naming/java/javaURLContextFactory.java

2012-11-26 Thread markt
Author: markt
Date: Mon Nov 26 11:45:43 2012
New Revision: 1413563

URL: http://svn.apache.org/viewvc?rev=1413563view=rev
Log:
Follow up to r1413557

Modified:
tomcat/tc7.0.x/trunk/   (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/naming/java/javaURLContextFactory.java

Propchange: tomcat/tc7.0.x/trunk/
--
  Merged /tomcat/trunk:r1413562

Modified: 
tomcat/tc7.0.x/trunk/java/org/apache/naming/java/javaURLContextFactory.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/naming/java/javaURLContextFactory.java?rev=1413563r1=1413562r2=1413563view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/naming/java/javaURLContextFactory.java 
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/naming/java/javaURLContextFactory.java 
Mon Nov 26 11:45:43 2012
@@ -39,9 +39,9 @@ import org.apache.naming.SelectorContext
  * liAdding a 
  * java.naming.factory.url.pkgs=org.apache.naming property
  * to the JNDI properties file/li
- * liSetting an environment variable named Context.URL_PKG_PREFIXES with 
- * its value including the org.apache.catalina.util.naming package name. 
- * More detail about this can be found in the JNDI documentation : 
+ * liSetting an environment variable named Context.URL_PKG_PREFIXES with
+ * its value including the org.apache.naming package name.
+ * More detail about this can be found in the JNDI documentation :
  * {@link javax.naming.spi.NamingManager#getURLContext(java.lang.String, 
java.util.Hashtable)}./li
  * /ul
  * 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1413564 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/naming/java/javaURLContextFactory.java

2012-11-26 Thread markt
Author: markt
Date: Mon Nov 26 11:47:08 2012
New Revision: 1413564

URL: http://svn.apache.org/viewvc?rev=1413564view=rev
Log:
Follow up to r1413559

Modified:
tomcat/tc6.0.x/trunk/   (props changed)
tomcat/tc6.0.x/trunk/java/org/apache/naming/java/javaURLContextFactory.java

Propchange: tomcat/tc6.0.x/trunk/
--
  Merged /tomcat/trunk:r1413562
  Merged /tomcat/tc7.0.x/trunk:r1413563

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/naming/java/javaURLContextFactory.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/naming/java/javaURLContextFactory.java?rev=1413564r1=1413563r2=1413564view=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/naming/java/javaURLContextFactory.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/naming/java/javaURLContextFactory.java 
Mon Nov 26 11:47:08 2012
@@ -37,9 +37,9 @@ import org.apache.naming.ContextBindings
  * liAdding a 
  * java.naming.factory.url.pkgs=org.apache.naming property
  * to the JNDI properties file/li
- * liSetting an environment variable named Context.URL_PKG_PREFIXES with 
- * its value including the org.apache.catalina.util.naming package name. 
- * More detail about this can be found in the JNDI documentation : 
+ * liSetting an environment variable named Context.URL_PKG_PREFIXES with
+ * its value including the org.apache.naming package name.
+ * More detail about this can be found in the JNDI documentation :
  * {@link javax.naming.spi.NamingManager#getURLContext(java.lang.String, 
java.util.Hashtable)}./li
  * /ul
  * 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



buildbot failure in ASF Buildbot on tomcat-7-trunk

2012-11-26 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-7-trunk while 
building ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/tomcat-7-trunk/builds/937

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: bb-vm_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch tomcat/tc7.0.x/trunk] 1413553
Blamelist: markt

BUILD FAILED: failed compile_1

sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [Vote] Add comments.apache.org to Tomcat docs

2012-11-26 Thread Olivier Lamy
+1

--
Olivier
Le 21 nov. 2012 16:11, Rainer Jung rainer.j...@kippdata.de a écrit :

 The ASF has a Apache Comments System. It was started by a committer of
 the web server project in order to allow users to add comments to live
 docs web pages. It is currently by the web server and the trafficserver
 projects. The experience at the web server project is very positive.
 Most comments do make sense, there is only very little SPAM or other
 misuse and the typical volume is about 1-2 comments per day. The Tomcat
 community might be more active though.

 Two weeks ago I started a discussion about including it into our public
 Tomcat docs as well. Some have expressed interest in the idea and there
 was some valuable feedback about improvements.

 Although docs are CTR the proposed change is not only about docs
 contents, but also about a new service offering to users. As such it
 will in the end put some more pressure on our precious time resources.
 This is why I start a formal vote thread.

 I propose to add the commenting feature to our live docs at
 tomcat.apache.org for version 7. Especially this means, that any user
 will be able to post any comment without moderation, except when
 including links. Any moderator can subscribe to all comments, mark
 comments or delete them or - if they contain links - release them. Any
 ASF committer is automatically a moderator for any site using comments.a.o.

 The implementation will be based on

 http://people.apache.org/~rjung/patches/tc-trunk-comments-v2.patch

 (some adjustments are obvious because it will be applied to TC 7 docs on
 tomcat.apache.org).

 A visual prototype is available at

 http://people.apache.org/~rjung/tomcat-docs-comments/tomcat-8.0-docs/

 An explanation page that is linked from the comments system was drafted
 here:


 http://people.apache.org/~rjung/tomcat-docs-comments/tomcat-8.0-docs/comments.html

 Possible future enhancements:

 - Discuss whether we want new comments to be copied to the dev list

 - Discuss whether we want to invite some non-committers as moderators

 - Add to docs for version 6 and 5.5 with comments plugin informing users
 about comments existing on the same page in another version (relatively
 easy, soon)

 - Add to connectors and native docs (needs investigation)

 - Add to other site pages and migration guide (not sure)

 - Improve styles, probably making the comments threads more consistent
 with the docs

 There is currently no good way to share comments between different sites
 that serve the same docs, like our CI system and the main tomcat site.
 IMHO it is already valuable to allow comments on the main site.

 Integrate comments.apache.org with TC 7 docs on tomcat.apache.org:

 [  ] +1, go ahead
 [  ]  0, I don't care
 [  ] -1, Don't integrate, because ...

 Regards,

 Rainer

 -
 To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
 For additional commands, e-mail: dev-h...@tomcat.apache.org




Re: buildbot failure in ASF Buildbot on tomcat-7-trunk

2012-11-26 Thread Konstantin Kolinko
2012/11/26  build...@apache.org:
 The Buildbot has detected a new failure on builder tomcat-7-trunk while 
 building ASF Buildbot.
 Full details are available at:
  http://ci.apache.org/builders/tomcat-7-trunk/builds/937

 Buildbot URL: http://ci.apache.org/

 Buildslave for this Build: bb-vm_ubuntu

 Build Reason: scheduler
 Build Source Stamp: [branch tomcat/tc7.0.x/trunk] 1413553
 Blamelist: markt

 BUILD FAILED: failed compile_1


[junit] Nov 26, 2012 11:42:39 AM
org.apache.tomcat.util.http.mapper.TestMapper testPerformance
[junit] WARNING: testPerformance() test rerun completed in 4243 ms
[junit] Test org.apache.tomcat.util.http.mapper.TestMapper FAILED

Performance test for Mapper x BIO.   4243 ms  4s.
Nothing to worry about.

Re-running this test with NIO was 1.746 sec.

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



buildbot success in ASF Buildbot on tomcat-7-trunk

2012-11-26 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-7-trunk while 
building ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/tomcat-7-trunk/builds/938

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: bb-vm_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch tomcat/tc7.0.x/trunk] 1413563
Blamelist: markt

Build succeeded!

sincerely,
 -The Buildbot





[Bug 54208] ant extras build task fails

2012-11-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54208

Mark Thomas ma...@apache.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #1 from Mark Thomas ma...@apache.org ---
OSX 10.7.5, Java 1.6.0_37, Ant 1.8.4, Tomcat 7.0.33 source tarball

This is as close as I can get without paying to upgrade my Mac to an OS I don't
want and it works for me. It also works on other OSes and with a variety of Ant
and Java versions.

This looks like a local configuration problem rather than a problem with the
build script as it hard to see how an OS upgrade could break this.

The users list is the place to debug this further.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GUMP@vmgump]: Project tomcat-taglibs-standard (in module tomcat-taglibs) failed

2012-11-26 Thread Gump
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-taglibs-standard has an issue affecting its community 
integration.
This issue affects 2 projects,
 and has been outstanding for 207 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-taglibs-standard :  Standard Taglib
- tomcat-taglibs-standard-install :  JSP Taglibs


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-taglibs/tomcat-taglibs-standard/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -INFO- Optional dependency httpunit failed with reason build failed
 -DEBUG- (Apache Gump generated) Apache Maven Settings in: 
/srv/gump/public/workspace/tomcat-taglibs/standard/gump_mvn_settings.xml
 -INFO- Failed with reason build failed
 -DEBUG- Maven POM in: 
/srv/gump/public/workspace/tomcat-taglibs/standard/pom.xml
 -INFO- Failed to extract fallback artifacts from Gump Repository



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-taglibs/tomcat-taglibs-standard/gump_work/build_tomcat-taglibs_tomcat-taglibs-standard.html
Work Name: build_tomcat-taglibs_tomcat-taglibs-standard (Type: Build)
Work ended in a state of : Failed
Elapsed: 26 secs
Command Line: /opt/maven2/bin/mvn --batch-mode -DskipTests=true --settings 
/srv/gump/public/workspace/tomcat-taglibs/standard/gump_mvn_settings.xml 
install 
[Working Directory: /srv/gump/public/workspace/tomcat-taglibs/standard]
M2_HOME: /opt/maven2
-
[INFO] [compiler:compile {execution: default-compile}]
[INFO] Nothing to compile - all classes are up to date
[debug] execute contextualize
[INFO] [resources:testResources {execution: default-testResources}]
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory 
/srv/gump/public/workspace/tomcat-taglibs/standard/spec/src/test/resources
[INFO] Copying 3 resources
[INFO] [compiler:testCompile {execution: default-testCompile}]
[INFO] No sources to compile
[INFO] [surefire:test {execution: default-test}]
[INFO] Tests are skipped.
[INFO] [bundle:bundle {execution: default-bundle}]
[INFO] [install:install {execution: default-install}]
[INFO] Installing 
/srv/gump/public/workspace/tomcat-taglibs/standard/spec/target/taglibs-standard-spec-1.2-SNAPSHOT.jar
 to 
/srv/gump/public/workspace/mvnlocalrepo/shared/org/apache/taglibs/taglibs-standard-spec/1.2-SNAPSHOT/taglibs-standard-spec-1.2-SNAPSHOT.jar
[INFO] [bundle:install {execution: default-install}]
[INFO] Parsing 
file:/srv/gump/public/workspace/mvnlocalrepo/shared/repository.xml
[INFO] Installing 
org/apache/taglibs/taglibs-standard-spec/1.2-SNAPSHOT/taglibs-standard-spec-1.2-SNAPSHOT.jar
[INFO] Writing OBR metadata
[INFO] 
[INFO] Building JSTL Implementation
[INFO]task-segment: [install]
[INFO] 
[INFO] [remote-resources:process {execution: default}]
[INFO] snapshot org.apache.taglibs:taglibs-standard-spec:1.2-SNAPSHOT: checking 
for updates from apache.snapshots
[debug] execute contextualize
[INFO] [resources:resources {execution: default-resources}]
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 14 resources
[INFO] Copying 3 resources
[INFO] [compiler:compile {execution: default-compile}]
[INFO] Compiling 96 source files to 
/srv/gump/public/workspace/tomcat-taglibs/standard/impl/target/classes
[INFO] -
[ERROR] COMPILATION ERROR : 
[INFO] -
[ERROR] 
/srv/gump/public/workspace/tomcat-taglibs/standard/impl/src/main/java/org/apache/taglibs/standard/tag/common/sql/DataSourceWrapper.java:[38,7]
 error: DataSourceWrapper is not abstract and does not override abstract method 
getParentLogger() in CommonDataSource
[INFO] 1 error
[INFO] -
[INFO] 
[ERROR] BUILD FAILURE
[INFO] 
[INFO] Compilation failure
/srv/gump/public/workspace/tomcat-taglibs/standard/impl/src/main/java/org/apache/taglibs/standard/tag/common/sql/DataSourceWrapper.java:[38,7]
 error: DataSourceWrapper is not abstract and does not override abstract method 
getParentLogger() in CommonDataSource

[INFO] 
[INFO] For more information, run Maven with the -e switch
[INFO] 

svn commit: r1413675 - in /tomcat/trunk/java/javax/websocket: ContainerProvider.java ServerContainer.java

2012-11-26 Thread markt
Author: markt
Date: Mon Nov 26 15:13:46 2012
New Revision: 1413675

URL: http://svn.apache.org/viewvc?rev=1413675view=rev
Log:
Fill in some Javadoc. Address a TODO

Modified:
tomcat/trunk/java/javax/websocket/ContainerProvider.java
tomcat/trunk/java/javax/websocket/ServerContainer.java

Modified: tomcat/trunk/java/javax/websocket/ContainerProvider.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/javax/websocket/ContainerProvider.java?rev=1413675r1=1413674r2=1413675view=diff
==
--- tomcat/trunk/java/javax/websocket/ContainerProvider.java (original)
+++ tomcat/trunk/java/javax/websocket/ContainerProvider.java Mon Nov 26 
15:13:46 2012
@@ -19,13 +19,23 @@ package javax.websocket;
 import java.lang.reflect.InvocationTargetException;
 import java.lang.reflect.Method;
 
+/**
+ * Provides access to the implementation. This version of the API is hard-coded
+ * to use the Apache Tomcat WebSocket implementation.
+ */
 public class ContainerProvider {
 
 private static final String CONTAINER_PROVIDER_IMPL =
 org.apache.tomcat.websocket.ServerContainerImpl;
 
+/**
+ * Obtain a reference to the Server container used for processing incoming
+ * WebSocket connections.
+ */
 public static ServerContainer getServerContainer() {
-// TODO SecurityManager
+// Note: No special handling required when running under a
+//   SecurityManager as the caller and this class will have the 
same
+//   ClassLoader
 ServerContainer result = null;
 try {
 Class? clazz = Class.forName(CONTAINER_PROVIDER_IMPL);
@@ -40,6 +50,10 @@ public class ContainerProvider {
 return result;
 }
 
+/**
+ * Obtain a reference to the ClientContainer used to create outgoing
+ * WebSocket connections.
+ */
 public static ClientContainer getClientContainer() {
 return null;
 }

Modified: tomcat/trunk/java/javax/websocket/ServerContainer.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/javax/websocket/ServerContainer.java?rev=1413675r1=1413674r2=1413675view=diff
==
--- tomcat/trunk/java/javax/websocket/ServerContainer.java (original)
+++ tomcat/trunk/java/javax/websocket/ServerContainer.java Mon Nov 26 15:13:46 
2012
@@ -16,8 +16,18 @@
  */
 package javax.websocket;
 
+/**
+ * Defines the additional server specific methods.
+ */
 public interface ServerContainer extends ClientContainer {
 
+/**
+ * Publish the Endpoint in this ServerContainer.
+ *
+ * @param clazz The implementation class for the Endpoint
+ *
+ * @throws DeploymentException  If the publish process fails for any reason
+ */
 void publishServer(Class? extends Endpoint clazz)
 throws DeploymentException;
 }



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 54190] TestNonLoginAndBasicAuthenticator does not test session timeout properly

2012-11-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54190

Brian Burch br...@pingtoo.com changed:

   What|Removed |Added

  Attachment #29621|0   |1
is obsolete||

--- Comment #4 from Brian Burch br...@pingtoo.com ---
Created attachment 29641
  -- https://issues.apache.org/bugzilla/attachment.cgi?id=29641action=edit
New version of complete patch

This new version is a significant improvement over the previous:
1. Numeric http status has been replaced by standard api contstants.
2. the complex signatures of the doTestXxx methods have been simplified and
made more self-documenting.
3. more comments have been added and some comments reworded.
4. code has been cleaned up and validation improved.
5. several new test cases have been added with backward-compatible behaviour
(i.e. they succeed at the moment) and TODO comments have been added to
cross-reference suggested improvements that would make the BasicAuthenticator
more tolerant in future.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 54190] TestNonLoginAndBasicAuthenticator does not test session timeout properly

2012-11-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54190

Brian Burch br...@pingtoo.com changed:

   What|Removed |Added

  Attachment #29641|0   |1
is obsolete||

--- Comment #5 from Brian Burch br...@pingtoo.com ---
Created attachment 29642
  -- https://issues.apache.org/bugzilla/attachment.cgi?id=29642action=edit
Complete replacement for previous patches

Aesthetic improvements to the inner class, which will probbaly make Mark wonder
why I didn't do them before... the answer is: I hadn't gone back to review the
inner class once it was working. I must leave this code alone now!

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Time for Taglibs to be sent to the archive?

2012-11-26 Thread Jeremy Boynes
+0

It's perhaps not surprising that there is not much activity as there has been 
no update to the JSR in many years. The JSTL code in trunk does pass the 1.2 
TCK and could be released if someone had the energy to fix the website and 
rustle up votes. 

On Oct 13, 2012, at 10:58 AM, Henri Yandell wrote:

 Hard to argue against it. I've no energy for Taglibs coding. I wish
 we'd got a JSTL 1.2 released, but c'est la vie.
 
 All the steps listed sound good except removing the website.
 Historically on the Attic side we've kept the websites up with a
 notice that the project is dead, rather than going dark on people.
 
 Hen
 
 On Mon, Oct 1, 2012 at 12:55 AM, Henri Gomez henri.go...@gmail.com wrote:
 If there is no activity, it make sense.
 
 +0
 
 2012/10/1 Mark Thomas ma...@apache.org:
 In the two+ years since Taglibs moved to the Tomcat project there have
 been a few short bursts of activity totalling just over 200 commits but
 no releases. There has also been no progress towards a migration to
 svnpubsub for the taglibs part of the web site.
 
 Given the lack of progress I would propose that Taglibs is moved to our
 archive. This would mean:
 
 - removing the Taglibs link from tomcat.a.o
 - removing the Taglibs web pages
 - moving the tomcat/tagslibs svn tree to tomcat/archive/taglibs
 - making the Taglibs BZ project read-only
 - moving the Taglibs committers to emeritus status
 - removing the Taglibs from Gump
 
 There is nothing to remove from dist.a.o since there have been no releases
 
 Note: This is intended as a discussion topic - not a formal proposal/vote.
 
 Thoughts?
 
 Mark
 
 -
 To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
 For additional commands, e-mail: dev-h...@tomcat.apache.org
 
 
 -
 To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
 For additional commands, e-mail: dev-h...@tomcat.apache.org
 
 
 -
 To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
 For additional commands, e-mail: dev-h...@tomcat.apache.org
 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org