Re: [VOTE] Release Apache Tomcat 7.0.34
2012/12/6 Mark Thomas ma...@apache.org: The proposed Apache Tomcat 7.0.34 release is now available for voting. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.34/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-113/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_34/ The proposed 7.0.34 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 7.0.34 Stable +1. Tested on test app (use DeltaManager). Works fine. -- Keiichi.Fujino - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 54260] New: JSP unloading - NullPointerException when using .tag files
https://issues.apache.org/bugzilla/show_bug.cgi?id=54260 Bug ID: 54260 Summary: JSP unloading - NullPointerException when using .tag files Product: Tomcat 7 Version: 7.0.33 Hardware: PC OS: All Status: NEW Severity: normal Priority: P2 Component: Jasper Assignee: dev@tomcat.apache.org Reporter: laszlo.keszthe...@diepresse.com Classification: Unclassified Since Tomcat 7.0.30 (currently using version 7.0.33) we are faced with the following NullPointerException: Dec 7, 2012 2:10:28 PM org.apache.catalina.core.ContainerBase$ContainerBackgroundProcessor processChildren SEVERE: Exception invoking periodic operation: java.lang.NullPointerException at org.apache.jasper.util.FastRemovalDequeue$Entry.access$700(FastRemovalDe queue.java:254) at org.apache.jasper.util.FastRemovalDequeue.remove(FastRemovalDequeue.java :177) at org.apache.jasper.compiler.JspRuntimeContext.checkUnload(JspRuntimeConte xt.java:610) at org.apache.jasper.servlet.JspServlet.periodicEvent(JspServlet.java:360) at org.apache.catalina.core.StandardWrapper.backgroundProcess(StandardWrapp er.java:709) at org.apache.catalina.core.ContainerBase$ContainerBackgroundProcessor.proc essChildren(ContainerBase.java:1530) at org.apache.catalina.core.ContainerBase$ContainerBackgroundProcessor.proc essChildren(ContainerBase.java:1540) at org.apache.catalina.core.ContainerBase$ContainerBackgroundProcessor.proc essChildren(ContainerBase.java:1540) at org.apache.catalina.core.ContainerBase$ContainerBackgroundProcessor.proc essChildren(ContainerBase.java:1540) at org.apache.catalina.core.ContainerBase$ContainerBackgroundProcessor.run( ContainerBase.java:1519) at java.lang.Thread.run(Thread.java:662) Investigation results: I was able to debug and trace the exception and found that the Excpetion is caused by a '.tag', I'm including in my JSP, which has no UnloadHandle assigned when processed in org.apache.jasper.compiler.JspRuntimeContext.checkUnload() line 610: jspQueue.remove(jsw.getUnloadHandle()); Because jsw.getUnloadHandle() returns null, jspQueue.remove() fails and is throwing the NullPointerException everytime, aborting the unload. Reproducing the exceptiopn: It looks like the exception appears only when maxLoadedJsps and jspIdleTimeout are set to a value 0 in tomcat/conf/web.xml and .tag files are used with jsp-scriptlets. Web.xml changes: init-param param-namemaxLoadedJsps/param-name param-value1000/param-value /init-param init-param param-namejspIdleTimeout/param-name param-value5/param-value /init-param The exception can be observed in the example Tag Files - Display Products Example but you have to edit the WEB-INF/tags/displayProducts.tag and append the following example scriptlet: % String test = this is =; if (normalPrice != null) test = test + normalPrice + something; else test = test + onSale + =; StringBuilder tags=new StringBuilder(test); tags.append(.).append(test).append(...); // change here test = tags.toString(); request.setAttribute(test, test); % %=test % Start Tomcat and invoke the example jsp http://localhost:8080/examples/jsp/jsp2/tagfiles/products.jsp Wait and observe the catalina.out (or tomcat output) for exceptions. Normaly the exception won't appear. Now edit the previously added scriplet in WEB-INF/tags/displayProducts.tag modifying any string in one of the append statements. Call the example jsp again, tomcat should recompile the tag, wait and observe again your tomcat output. Do not shutdown or restart tomcat between these steps! Tomcat should recompile the tag on the fly. We were able to reproduce the exception on Tomcat 7.0.30, 7.0.32 and 7.0.33 on different machines using the described steps. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 54261] New: web-fragment.xml handling in container JARs
https://issues.apache.org/bugzilla/show_bug.cgi?id=54261 Bug ID: 54261 Summary: web-fragment.xml handling in container JARs Product: Tomcat 7 Version: trunk Hardware: All OS: All Status: NEW Severity: normal Priority: P2 Component: Catalina Assignee: dev@tomcat.apache.org Reporter: ma...@apache.org Classification: Unclassified Tomcat does not follow the language of section 8.2.1 of the Servlet specification. In short, JARs provided at the container level: - are scanned for SCIs - are scanned for static resources - are NOT scanned for web-fragment.xml - are NOT excluded by an absolute ordering Tomcat does not follow these last two points. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 7.0.34
On 06/12/2012 11:26, Mark Thomas wrote: The proposed Apache Tomcat 7.0.34 release is now available for voting. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.34/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-113/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_34/ The proposed 7.0.34 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 7.0.34 Stable Unit tests pass on 64-bit Windows and 64-bit Linux EL TCK passes JSP TCK passes with HTTP (direct) BIO, NIO APR/native (1.1.24) Servlet TCK passes with - HTTP (direct) BIO, NIO APR/native (1.1.24) - HTTP (mod_proxy_http) BIO, NIO APR/native (1.1.24) - AJP (mod_jk) BIO, NIO APR/native (1.1.24) - AJP (mod_proxy_ajp) BIO, NIO APR/native (1.1.24) All TCK tests run on 64-bit Linux with a security manager Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 7.0.34
2012/12/6 Mark Thomas ma...@apache.org: The proposed Apache Tomcat 7.0.34 release is now available for voting. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.34/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-113/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_34/ The proposed 7.0.34 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 7.0.34 Stable Maven plugin tested and some applications with the distrib. Cheers, Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org -- Olivier Lamy Talend: http://coders.talend.com http://twitter.com/olamy | http://linkedin.com/in/olamy - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 54262] New: absolute-ordering
https://issues.apache.org/bugzilla/show_bug.cgi?id=54262 Bug ID: 54262 Summary: absolute-ordering Product: Tomcat 7 Version: 7.0.33 Hardware: PC OS: Linux Status: NEW Severity: normal Priority: P2 Component: Catalina Assignee: dev@tomcat.apache.org Reporter: rstoyanc...@yahoo.com Classification: Unclassified The use of an absolute-ordering element does disable ServletContainerInitializer classpath scanning as discussed also in issue 53619. However, it does seem to require having at least one web-fragment name to be listed. In other words I would this: absolute-ordering / To turn off all web-fragments since none are named. A workaround is to list a web-fragment even if it doesn't exist but that shouldn't be necessary. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 54262] An empty absolute-ordering / should turn off all web-fragments
https://issues.apache.org/bugzilla/show_bug.cgi?id=54262 rstoyanc...@yahoo.com changed: What|Removed |Added Summary|absolute-ordering |An empty absolute-ordering ||/ should turn off all ||web-fragments -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1417194 - in /tomcat/trunk/java/org/apache/tomcat/util/buf: ByteChunk.java CharChunk.java
Mark,
On 12/4/12 4:21 PM, ma...@apache.org wrote:
+private int hashCode=0;
+// did we compute the hashcode ?
+private boolean hasHashCode = false;
Should hashCode and hasHashCode be volatile?
// Hash code
+@Override
+public int hashCode() {
+if (hasHashCode) {
+return hashCode;
+}
+int code = 0;
+
+code = hash();
+hashCode = code;
+hasHashCode = true;
+return code;
+}
Any particular reason for the dead store of 0 to 'code' local?
In fact, there seems to be much more code in there than necessary. Why not:
+public int hashCode() {
+if (hasHashCode) {
+return hashCode;
+}
+hashCode = hash();
+hasHashCode = true;
+return hashCode;
-chris
signature.asc
Description: OpenPGP digital signature
[Bug 54191] TomEE 1.5+ SNAPSHOT struggling with PrimeFaces p:calendar readonlyInput=#{someEL ? 'true' : 'false'}
https://issues.apache.org/bugzilla/show_bug.cgi?id=54191 Christopher Schultz ch...@christopherschultz.net changed: What|Removed |Added Attachment #29691|application/octet-stream|text/plain mime type|| -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 54191] TomEE 1.5+ SNAPSHOT struggling with PrimeFaces p:calendar readonlyInput=#{someEL ? 'true' : 'false'}
https://issues.apache.org/bugzilla/show_bug.cgi?id=54191 Christopher Schultz ch...@christopherschultz.net changed: What|Removed |Added Attachment #29692|application/octet-stream|text/plain mime type|| -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 54191] TomEE 1.5+ SNAPSHOT struggling with PrimeFaces p:calendar readonlyInput=#{someEL ? 'true' : 'false'}
https://issues.apache.org/bugzilla/show_bug.cgi?id=54191 --- Comment #16 from Christopher Schultz ch...@christopherschultz.net --- Sorry, your filter simply is not threadsafe, even if you have a CDI @SessionScoped annotation (in fact, that's exactly what makes it unsafe). Your code will fail at some point in other environments even if you don't seem to have time to debug it, now. There is almost certainly no Tomcat/TomEE/EL bug here. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1417282 - in /tomcat/trunk/webapps/docs/config: ajp.xml executor.xml http.xml
Konstantin, On 12/5/12 3:06 AM, Konstantin Kolinko wrote: 2012/12/5 Caldarale, Charles R chuck.caldar...@unisys.com: From: kkoli...@apache.org [mailto:kkoli...@apache.org] Subject: svn commit: r1417282 - in /tomcat/trunk/webapps/docs/config: ajp.xml executor.xml http.xml Author: kkolinko Date: Wed Dec 5 05:34:16 2012 New Revision: 1417282 Modified: tomcat/trunk/webapps/docs/config/ajp.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/ajp.xml? rev=1417282r1=1417281r2=1417282view=diff == --- tomcat/trunk/webapps/docs/config/ajp.xml (original) +++ tomcat/trunk/webapps/docs/config/ajp.xml Wed Dec 5 05:34:16 2012 @@ -285,9 +285,10 @@ attribute name=acceptorThreadPriority required=false pThe priority of the acceptor threads. The threads used to accept - new connections. The default value is - codejava.lang.Thread#NORM_PRIORITY/code. See the JavaDoc for the - java.lang.Thread class for more details on what this priority means./p + new connections. The default value is code5/code (the value of the The value of NORM_PRIORITY on Windows 64-bit JDK 7 appears to be 1, not 5. I haven't checked other versions or platforms. 1 is MIN_PRIORITY. The constants are evaluated at compile time. They cannot be different between systems. +1 This is part of the public java.util.Thread API. If those values change, bad things likely happen. From my Oracle Java 1.7 distro on 64-bit Mac OS: /** * The minimum priority that a thread can have. */ public final static int MIN_PRIORITY = 1; /** * The default priority that is assigned to a thread. */ public final static int NORM_PRIORITY = 5; /** * The maximum priority that a thread can have. */ public final static int MAX_PRIORITY = 10; -chris signature.asc Description: OpenPGP digital signature
RE: svn commit: r1417282 - in /tomcat/trunk/webapps/docs/config: ajp.xml executor.xml http.xml
From: Christopher Schultz [mailto:ch...@christopherschultz.net] Subject: Re: svn commit: r1417282 - in /tomcat/trunk/webapps/docs/config: ajp.xml executor.xml http.xml The value of NORM_PRIORITY on Windows 64-bit JDK 7 appears to be 1, not 5. I haven't checked other versions or platforms. This is part of the public java.util.Thread API. If those values change, bad things likely happen. Probably not, but regardless, I had a typo in my program that displayed the values, hence my erroneous statement. - Chuck THIS COMMUNICATION MAY CONTAIN CONFIDENTIAL AND/OR OTHERWISE PROPRIETARY MATERIAL and is thus for use only by the intended recipient. If you received this in error, please contact the sender and delete the e-mail and its attachments from all computers. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 54263] New: CVE-2012-5568 Tomcat is vulnerable to Slowloris denial of service
https://issues.apache.org/bugzilla/show_bug.cgi?id=54263 Bug ID: 54263 Summary: CVE-2012-5568 Tomcat is vulnerable to Slowloris denial of service Product: Tomcat 6 Version: 6.0.36 Hardware: All OS: All Status: NEW Severity: normal Priority: P2 Component: Catalina Assignee: dev@tomcat.apache.org Reporter: mmccl...@uplogix.com Classification: Unclassified NIST lists all versions prior to 7.0.28 as vulnerable. http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2012-5568 RedHat is also tracking this. https://bugzilla.redhat.com/show_bug.cgi?id=880011 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
RE: svn commit: r1417194 - in /tomcat/trunk/java/org/apache/tomcat/util/buf: ByteChunk.java CharChunk.java
From: Christopher Schultz [mailto:ch...@christopherschultz.net]
Subject: Re: svn commit: r1417194 - in
/tomcat/trunk/java/org/apache/tomcat/util/buf: ByteChunk.java CharChunk.java
On 12/4/12 4:21 PM, ma...@apache.org wrote:
+private int hashCode=0;
+// did we compute the hashcode ?
+private boolean hasHashCode = false;
Should hashCode and hasHashCode be volatile?
Yes, to insure program order is followed; otherwise there's no guarantee that
hashCode and hasHashCode are written in the required sequence.
In fact, there seems to be much more code in there than necessary. Why not:
+public int hashCode() {
+if (hasHashCode) {
+return hashCode;
+}
+hashCode = hash();
+hasHashCode = true;
+return hashCode;
Or:
public int hashCode() {
if (!hasHashCode) {
hashCode = hash();
hasHashCode = true;
}
return hashCode;
}
- Chuck
THIS COMMUNICATION MAY CONTAIN CONFIDENTIAL AND/OR OTHERWISE PROPRIETARY
MATERIAL and is thus for use only by the intended recipient. If you received
this in error, please contact the sender and delete the e-mail and its
attachments from all computers.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Tomcat Wiki] Update of PoweredBy by Mark Ryder
Dear Wiki user,
You have subscribed to a wiki page or wiki category on Tomcat Wiki for change
notification.
The PoweredBy page has been changed by Mark Ryder:
http://wiki.apache.org/tomcat/PoweredBy?action=diffrev1=448rev2=449
=== Webhost.US.Com ===
{{http://www.webhost.us.com/images/logo.gif|http://www.webhost.us.com/images/logo.gif|class=external_image
fkromjtocnoxhitqgdwz fkromjtocnoxhitqgdwz}} US Web Hosting
[[http://www.Webhost.US.Com/|Web Hosting US]] - Proud to be one of the best
Apache Tomcat US Web Hosting provider.
+
+ === Web Hosting UK ===
+
[[http://www.webhostinguk.com|{{http://www.webhostinguk.com/forum/styles/silver_orange/imageset/logo.png|http://www.webhostinguk.com}}]]
[[http://www.webhostinguk.com|Web Hosting UK]] - Tomcat Hosting offers on
reliable fast servers at WebhostingUK Limited.
=== WebHosting UK ===
[[http://www.webhosting.uk.com|{{http://www.webhosting.uk.com/web-hosting-uk.gif|http://www.webhosting.uk.com}}]]
[[http://www.webhosting.uk.com|Web Hosting UK]] - Tomcat Hosting Service
provider in UK.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[GUMP@vmgump]: Project tomcat-taglibs-standard (in module tomcat-taglibs) failed
To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at gene...@gump.apache.org.
Project tomcat-taglibs-standard has an issue affecting its community
integration.
This issue affects 2 projects,
and has been outstanding for 230 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-taglibs-standard : Standard Taglib
- tomcat-taglibs-standard-install : JSP Taglibs
Full details are available at:
http://vmgump.apache.org/gump/public/tomcat-taglibs/tomcat-taglibs-standard/index.html
That said, some information snippets are provided here.
The following annotations (debug/informational/warning/error messages) were
provided:
-INFO- Optional dependency httpunit failed with reason build failed
-DEBUG- (Apache Gump generated) Apache Maven Settings in:
/srv/gump/public/workspace/tomcat-taglibs/standard/gump_mvn_settings.xml
-INFO- Failed with reason build failed
-DEBUG- Maven POM in:
/srv/gump/public/workspace/tomcat-taglibs/standard/pom.xml
-INFO- Failed to extract fallback artifacts from Gump Repository
The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-taglibs/tomcat-taglibs-standard/gump_work/build_tomcat-taglibs_tomcat-taglibs-standard.html
Work Name: build_tomcat-taglibs_tomcat-taglibs-standard (Type: Build)
Work ended in a state of : Failed
Elapsed: 25 secs
Command Line: /opt/maven2/bin/mvn --batch-mode -DskipTests=true --settings
/srv/gump/public/workspace/tomcat-taglibs/standard/gump_mvn_settings.xml
install
[Working Directory: /srv/gump/public/workspace/tomcat-taglibs/standard]
M2_HOME: /opt/maven2
-
[debug] execute contextualize
[INFO] [resources:testResources {execution: default-testResources}]
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] skip non existing resourceDirectory
/srv/gump/public/workspace/tomcat-taglibs/standard/spec/src/test/resources
[INFO] Copying 3 resources
[INFO] [compiler:testCompile {execution: default-testCompile}]
[INFO] No sources to compile
[INFO] [surefire:test {execution: default-test}]
[INFO] Tests are skipped.
[INFO] [bundle:bundle {execution: default-bundle}]
[INFO] [install:install {execution: default-install}]
[INFO] Installing
/srv/gump/public/workspace/tomcat-taglibs/standard/spec/target/taglibs-standard-spec-1.2-SNAPSHOT.jar
to
/srv/gump/public/workspace/mvnlocalrepo/shared/org/apache/taglibs/taglibs-standard-spec/1.2-SNAPSHOT/taglibs-standard-spec-1.2-SNAPSHOT.jar
[INFO] [bundle:install {execution: default-install}]
[INFO] Parsing
file:/srv/gump/public/workspace/mvnlocalrepo/shared/repository.xml
[INFO] Installing
org/apache/taglibs/taglibs-standard-spec/1.2-SNAPSHOT/taglibs-standard-spec-1.2-SNAPSHOT.jar
[INFO] Writing OBR metadata
[INFO]
[INFO] Building JSTL Implementation
[INFO]task-segment: [install]
[INFO]
[INFO] [remote-resources:process {execution: default}]
[INFO] snapshot org.apache.taglibs:taglibs-standard-spec:1.2-SNAPSHOT: checking
for updates from apache.snapshots
Downloading:
http://localhost:8192/maven2/org/easymock/easymock/3.0/easymock-3.0.jar
111K downloaded (easymock-3.0.jar)
[debug] execute contextualize
[INFO] [resources:resources {execution: default-resources}]
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 14 resources
[INFO] Copying 3 resources
[INFO] [compiler:compile {execution: default-compile}]
[INFO] Compiling 96 source files to
/srv/gump/public/workspace/tomcat-taglibs/standard/impl/target/classes
[INFO] -
[ERROR] COMPILATION ERROR :
[INFO] -
[ERROR]
/srv/gump/public/workspace/tomcat-taglibs/standard/impl/src/main/java/org/apache/taglibs/standard/tag/common/sql/DataSourceWrapper.java:[38,7]
error: DataSourceWrapper is not abstract and does not override abstract method
getParentLogger() in CommonDataSource
[INFO] 1 error
[INFO] -
[INFO]
[ERROR] BUILD FAILURE
[INFO]
[INFO] Compilation failure
/srv/gump/public/workspace/tomcat-taglibs/standard/impl/src/main/java/org/apache/taglibs/standard/tag/common/sql/DataSourceWrapper.java:[38,7]
error: DataSourceWrapper is not abstract and does not override abstract method
getParentLogger() in CommonDataSource
[INFO]
[INFO] For more information, run Maven with the -e
