buildbot failure in ASF Buildbot on tomcat-trunk

2013-03-28 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building 
ASF Buildbot.
Full details are available at:
 http://ci.apache.org/builders/tomcat-trunk/builds/4194

Buildbot URL: http://ci.apache.org/

Buildslave for this Build: bb-vm_ubuntu

Build Reason: scheduler
Build Source Stamp: [branch tomcat/trunk] 1461958
Blamelist: kfujino

BUILD FAILED: failed compile_1

sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 54757] Deploy ROOT webapp

2013-03-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54757

ranl ran.leib...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #2 from ranl ran.leib...@gmail.com ---
Can't believe I've missed it !
Thanks and sorry

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Remove JvmRouteSessionIDBinderListener and SessionIDMessage.

2013-03-28 Thread Keiichi Fujino
Hi.

In the current implementation, JvmRouteBinderValve#changeSessionID
uses Manager#changeSessionId
in order to change session ID.
see r1446072, r1446077, r1461960.

As a result, The following classes are no longer used.
-JvmRouteSessionIDBinderListener
-SessionIDMessage

I'm going to remove these class.

Any objections and comment?

-- 
Keiichi.Fujino

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 54747] Cluster not work due to registerManager failed

2013-03-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54747

--- Comment #5 from Keiichi Fujino kfuj...@apache.org ---
According to the log message above, your /test context is using
org.apache.catalina.session.StandardManager as a session manager.

In this case, since you have a distributable / in web.xml,
Maybe Manager className=org.apache.catalina.session.StandardManager / has
been defined in context.xml.

You can check the following context.xml.
-webapps/test/META-INF/context.xml
-conf/context.xml
-conf/Catalina/localhost/test.xml

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Remove JvmRouteSessionIDBinderListener and SessionIDMessage.

2013-03-28 Thread Mark Thomas
Keiichi Fujino kfuj...@apache.org wrote:

Hi.

In the current implementation, JvmRouteBinderValve#changeSessionID
uses Manager#changeSessionId
in order to change session ID.
see r1446072, r1446077, r1461960.

As a result, The following classes are no longer used.
-JvmRouteSessionIDBinderListener
-SessionIDMessage

I'm going to remove these class.

Any objections and comment?

+1 - I'm always in favour of deleting code!

The remove classes should be marked as deprecated (with an explanation) just in 
case someone is depending on these.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 54747] Cluster not work due to registerManager failed

2013-03-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54747

--- Comment #6 from vincentj...@potix.com ---
(In reply to comment #5)
 According to the log message above, your /test context is using
 org.apache.catalina.session.StandardManager as a session manager.
 
 In this case, since you have a distributable / in web.xml,
 Maybe Manager className=org.apache.catalina.session.StandardManager /
 has been defined in context.xml.
 
 You can check the following context.xml.
 -webapps/test/META-INF/context.xml
 -conf/context.xml
 -conf/Catalina/localhost/test.xml

I checked the following three place.
1. -webapps/test/META-INF/context.xml
I don't have context.xml file under web project.
2. -conf/context.xml
The content is default, I didn't edit the file.
3. -conf/Catalina/localhost/test.xml
I can't find the file in the path.

Are there other settings I need to check?

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Tomcat JDBC Connection Pool - Deadlock

2013-03-28 Thread amit shah
Hello,
 I am using the tomcat jdbc connection pool independently in my web
application which is deployed on glassfish web server. While performing a
database operation, our application goes into a deadlock state. The two
threads involved in the deadlock have the below traces (from a thread dump)

thread1 Id=534 WAITING on
java.util.concurrent.locks.ReentrantReadWriteLock$FairSync@184ffd83 owned
by thread2 Id=529
at sun.misc.Unsafe.park(Native Method)
 -  waiting on
java.util.concurrent.locks.ReentrantReadWriteLock$FairSync@184ffd83
at java.util.concurrent.locks.LockSupport.park(LockSupport.java:186)
 at
java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:834)
at
java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireQueued(AbstractQueuedSynchronizer.java:867)
 at
java.util.concurrent.locks.AbstractQueuedSynchronizer.acquire(AbstractQueuedSynchronizer.java:1197)
at
java.util.concurrent.locks.ReentrantReadWriteLock$WriteLock.lock(ReentrantReadWriteLock.java:945)
 at
com.sun.ejb.containers.CMCSingletonContainer._getContext(CMCSingletonContainer.java:142)
at com.sun.ejb.containers.BaseContainer.getContext(BaseContainer.java:2528)
 ...

Number of locked synchronizers = 1
- java.util.concurrent.locks.ReentrantReadWriteLock$NonfairSync@3f88774b

, thread2 Id=529 WAITING on
java.util.concurrent.locks.ReentrantReadWriteLock$NonfairSync@3f88774bowned
by thread1 Id=534
at sun.misc.Unsafe.park(Native Method)
 -  waiting on
java.util.concurrent.locks.ReentrantReadWriteLock$NonfairSync@3f88774b
at java.util.concurrent.locks.LockSupport.park(LockSupport.java:186)
 at
java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:834)
at
java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireQueued(AbstractQueuedSynchronizer.java:867)
 at
java.util.concurrent.locks.AbstractQueuedSynchronizer.acquire(AbstractQueuedSynchronizer.java:1197)
at
java.util.concurrent.locks.ReentrantReadWriteLock$WriteLock.lock(ReentrantReadWriteLock.java:945)
 at
org.apache.tomcat.jdbc.pool.PooledConnection.lock(PooledConnection.java:609)
at
org.apache.tomcat.jdbc.pool.ConnectionPool.borrowConnection(ConnectionPool.java:752)
 ...

Number of locked synchronizers = 1
- java.util.concurrent.locks.ReentrantReadWriteLock$FairSync@184ffd83


Having a look at the source code for both
http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_34/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.javaof
these 
http://grepcode.com/file/repo1.maven.org/maven2/org.glassfish.ejb/ejb-container/3.1.1/com/sun/ejb/containers/CMCSingletonContainer.java?av=f
I
see different lock instances but still the dump indicates that they are the
same. Any idea on how can the java.util.lock instances be the same?

Thanks,
Amit.


[Bug 54757] Deploy ROOT webapp

2013-03-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54757

Christopher Schultz ch...@christopherschultz.net changed:

   What|Removed |Added

 Resolution|FIXED   |INVALID

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 53952] Add support for TLS 1.1 and 1.2

2013-03-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53952

Marcel Šebek sebe...@post.cz changed:

   What|Removed |Added

  Attachment #29458|0   |1
is obsolete||

--- Comment #14 from Marcel Šebek sebe...@post.cz ---
Created attachment 30111
  -- https://issues.apache.org/bugzilla/attachment.cgi?id=30111action=edit
Patch for tomcat native adding support for newer TLS versions

Ok, I've tested the patches and found an error in tcnative part. Here is a
fixed patch. The problem was that OpenSSL API is quite counter-intuitive. If
one wants more than one protocol to be supported, SSLv23_server_method() should
be called and unwanted protocols should then be disabled by SSL_OP_NO_*. Other
*_server_methods() always make available just one specific version of SSL/TLS.

To be precise, I've tested tcnative not with Tomcat, but with JBoss and
analogical patch for jboss-web. The reason is that I'm primarily interested in
JBoss and I don't know how to configure Tomcat.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 53952] Add support for TLS 1.1 and 1.2

2013-03-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53952

Marcel Šebek sebe...@post.cz changed:

   What|Removed |Added

  Attachment #29457|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 53952] Add support for TLS 1.1 and 1.2

2013-03-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53952

--- Comment #15 from Marcel Šebek sebe...@post.cz ---
Created attachment 30112
  -- https://issues.apache.org/bugzilla/attachment.cgi?id=30112action=edit
Patch for jboss-web

Just for the reference, here is the patch for jboss-web that I've tested.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 53952] Add support for TLS 1.1 and 1.2

2013-03-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=53952

--- Comment #16 from Marcel Šebek sebe...@post.cz ---
Oops, there seems to be a problem with OpenSSL 0.9.8. Previously, I've tested
1.0.1e and that worked, but the older version seems to have problems with
default protocol set. I currently have no time to find the precise culprit, so
in a week or so, I will attach fixed patches that works with all OpenSSL
versions.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 54747] Cluster not work due to registerManager failed

2013-03-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54747

--- Comment #7 from Konstantin Kolinko knst.koli...@gmail.com ---
(In reply to comment #4)
 Yes, I have the distributable / tag in web.xml

- What version of specification is your web.xml marked with?

- Do you have metadata-complete=true in your web.xml?

Note that distributable feature is not enables unless all web fragments have
the distributable / tag.

(In reply to comment #6)
 
 I checked the following three place.
 1. -webapps/test/META-INF/context.xml
 I don't have context.xml file under web project.
 2. -conf/context.xml
 The content is default, I didn't edit the file.
 3. -conf/Catalina/localhost/test.xml
 I can't find the file in the path.
 
 Are there other settings I need to check?

Also
4. conf/Catalina/localhost/context.xml.default

http://tomcat.apache.org/tomcat-7.0-doc/config/context.html#Defining_a_context

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: JarScanning

2013-03-28 Thread Nick Williams

On Feb 26, 2013, at 11:21 AM, Christopher Schultz wrote:

 Mark,
 
 On 2/21/13 8:34 AM, Mark Thomas wrote:
 JRE JARs.
 I think scanning of these should be made optional and disabled by
 default. This will reduce the list of JARs we have to maintain in
 jarsToSkip. I intend to implement this unless there are any objections.
 
 +1
 
 Will you be checking the ClassLoader to determine whether this is a JRE
 JAR or not? Does this apply to the JRE's endorsed JARs as well?
 White-listing will still work to enable individual JARs in these
 locations, right?
 
 jarsToScan
 This is a little more complicated.
 First of all, how does it work? The suggestion is:
 - If jarsToScan matches, scan it
 - else if jarsToSkip matches, skip it
 - else scan it
 
 +1
 
 Assuming that the above is acceptable, it would require the following:
 a) three new system properties
 tomcat.util.scan.DefaultJarScanner.jarsToScan
 org.apache.catalina.startup.ContextConfig.jarsToScan
 org.apache.catalina.startup.TldConfig.jarsToScan
 
 -1 for the global-ness of these settings.
 
 b)  add a parameter to JarScanner.scan()
 
 There are a couple of issues here.
 2. (and an issue with the current code [1]). These settings are all
 global rather than per web application. I would prefer that they were
 per web application with defaults configured globally. It is complicated
 by the fact that the JARs to skip/scan may vary depending on how the
 JarScanner is used.
 
 I would prefer to be able to set this stuff on a per-context basis. How
 much of this configuration could be configured with a Scanner?
 
 -chris


There hasn't been any movement on this for a while, so I wanted to see if any 
decision was made or if any work is being done. Note that Log4j2 is going to 
have a log4j-taglib artifact that (naturally) will have a TLD in its META-INF. 
Since Tomcat by default excludes log4j*.jar, that has to be removed from 
catalina.properties in order to make it work. It would be great for Tomcat 7/8 
to ship with jarsToScan set to whitelist log4j-taglib*.jar, or (perhaps better) 
*taglib*.jar (which would cover any JARs that accidentally fell under the 
blacklist but had the word taglib in them).

Nick


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 54765] New: fg

2013-03-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54765

Bug ID: 54765
   Summary: fg
   Product: Tomcat 6
   Version: unspecified
  Hardware: PC
Status: NEW
  Severity: normal
  Priority: P2
 Component: Connectors
  Assignee: dev@tomcat.apache.org
  Reporter: jaywa...@panhealth.com
Classification: Unclassified

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 54765] fg

2013-03-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54765

Chuck Caldarale chuck.caldar...@unisys.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID
 OS||All

--- Comment #1 from Chuck Caldarale chuck.caldar...@unisys.com ---
Bugzilla is not a playground.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 54747] Cluster not work due to registerManager failed

2013-03-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54747

--- Comment #8 from vincentj...@potix.com ---
(In reply to comment #7)
 (In reply to comment #4)
  Yes, I have the distributable / tag in web.xml
 
 - What version of specification is your web.xml marked with?

Version number is 3.0

 
 - Do you have metadata-complete=true in your web.xml?

No

 
 Note that distributable feature is not enables unless all web fragments have
 the distributable / tag.

My webapp doesn't contains any web fragments.

 
 (In reply to comment #6)
  
  I checked the following three place.
  1. -webapps/test/META-INF/context.xml
  I don't have context.xml file under web project.
  2. -conf/context.xml
  The content is default, I didn't edit the file.
  3. -conf/Catalina/localhost/test.xml
  I can't find the file in the path.
  
  Are there other settings I need to check?
 
 Also
 4. conf/Catalina/localhost/context.xml.default
 

Actually, the folder is empty in my machine.

 http://tomcat.apache.org/tomcat-7.0-doc/config/context.
 html#Defining_a_context

It is really strange that the same war file work fine for Tomcat 7.0.16 but not
with Tomcat 7.0.37.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 54747] Cluster not work due to registerManager failed

2013-03-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54747

--- Comment #9 from vincentj...@potix.com ---
Created attachment 30116
  -- https://issues.apache.org/bugzilla/attachment.cgi?id=30116action=edit
Test war

Add the war file I test on Tomcat 7.0.16 and 7.0.37.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1462408 - in /tomcat/trunk/java/org/apache/catalina/ha/session: JvmRouteSessionIDBinderListener.java SessionIDMessage.java mbeans-descriptors.xml

2013-03-28 Thread kfujino
Author: kfujino
Date: Fri Mar 29 05:47:40 2013
New Revision: 1462408

URL: http://svn.apache.org/r1462408
Log:
Remove unused class.
JvmRouteSessionIDBinderListener and SessionIDMessage are no longer used.

Removed:

tomcat/trunk/java/org/apache/catalina/ha/session/JvmRouteSessionIDBinderListener.java
tomcat/trunk/java/org/apache/catalina/ha/session/SessionIDMessage.java
Modified:
tomcat/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml

Modified: 
tomcat/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml?rev=1462408r1=1462407r2=1462408view=diff
==
--- tomcat/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml 
(original)
+++ tomcat/trunk/java/org/apache/catalina/ha/session/mbeans-descriptors.xml Fri 
Mar 29 05:47:40 2013
@@ -64,18 +64,6 @@
   returnType=void/
   /mbean
   mbean
-name=JvmRouteSessionIDBinderListener
-description=Monitors the jvmRoute activity
-domain=Catalina
-group=Listener
-type=org.apache.catalina.ha.session.JvmRouteSessionIDBinderListener
-attribute
-  name=numberOfSessions
-  description=number of jvmRoute session corrections
-  type=long
-  writeable=false/
-  /mbean
-  mbean
 name=DeltaManager
 description=Cluster Manager implementation of the Manager interface
 domain=Catalina



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org