[Bug 55354] JNDIRealm.getPrincipal(context,username,gssCredential) corrupts realm context
https://issues.apache.org/bugzilla/show_bug.cgi?id=55354 --- Comment #1 from Richard Begg --- Created attachment 30671 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30671&action=edit Patch to restore context params Here is a proposed patch for JNDIRealm.java which resolves the issue for me. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 55354] New: JNDIRealm.getPrincipal(context,username,gssCredential) corrupts realm context
https://issues.apache.org/bugzilla/show_bug.cgi?id=55354 Bug ID: 55354 Summary: JNDIRealm.getPrincipal(context,username,gssCredential) corrupts realm context Product: Tomcat 7 Version: 7.0.42 Hardware: PC Status: NEW Severity: normal Priority: P2 Component: Catalina Assignee: dev@tomcat.apache.org Reporter: richard.b...@identity-solutions.com.au The getPrincipal(context,username,gssCredential) method in JNDIRealm is designed to allow delegated credentials to be applied to the directory server connection as part of SPNEGO authentication. This is done by manipulation of a number of the directory context's environment parameters. However, as currently implemented, these environment parameters are forcibly cleared after the getUser() call regardless of whether the values were even changed (i.e. if isUseDelegatedCredential() returned false). If the container realm is defined to use GSSAPI authentication, only the first SPNEGO authentication request will succeed. All subsequent requests will fail with this exception: javax.naming.NamingException: [LDAP: error code 1 - 04DC: LdapErr: DSID-0C0906DC, comment: In order to perform this operation a successful bind must be completed on the connection., data 0, v1db0 The exception is due to the Context.SECURITY_AUTHENTICATION being cleared by getPrincipal() - resulting in a attempted "simple" bind with no username/password (i.e. anonymous). A workaround is to ensure that the connectionName and connectionPassword parameters are specified in the realm definition - however, if one is using GSSAPI - this shouldn't be necessary and certainly defeats the purpose of using GSSAPI in the first place. The code should preserve pre-existing environment parameters in the context before changing them, then restore those values afterwards - rather than just clearing the settings completely. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.0-RC1
Rainer,
On 8/3/13 6:06 AM, Rainer Jung wrote:
> - On APR in addition a crash (core) in:
>
> b76dfe74 Java_org_apache_tomcat_jni_Socket_recv (30b528, b30ff188,
> b30fd09c, b29500, b30ff214, 0) + 34
> fbc0f780 * org/apache/tomcat/jni/Socket.recv(J[BII)I+32362
> fbc0f72c * org/apache/tomcat/jni/Socket.recv(J[BII)I+0
> fbc068ec *
> org/apache/coyote/http11/upgrade/AprServletInputStream.doRead(Z[BII)I+73
> (line 101)
> fbc068ec *
> org/apache/coyote/http11/upgrade/AbstractServletInputStream.read([BII)I+20
> (line 229)
> fbc068ec *
> org/apache/tomcat/websocket/server/WsFrameServer.onDataAvailable()V+46
> (line 89)
> fbc06b84 *
> org/apache/tomcat/websocket/server/WsHttpUpgradeHandler$WsReadListener.onDataAvailable()V+4
> (line 384)
> fbc0771c *
> org/apache/coyote/http11/upgrade/AbstractServletInputStream.onDataAvailable()V+11
> (line 337)
> fbc06b84 *
> org/apache/coyote/http11/upgrade/AbstractProcessor.upgradeDispatch(Lorg/apache/tomcat/util/net/SocketStatus;)Lorg/apache/tomcat/util/net/AbstractEndpoint$Handler$SocketState;+11
> (line 189)
> fbc073e0 *
> org/apache/coyote/AbstractProtocol$AbstractConnectionHandler.process(Lorg/apache/tomcat/util/net/SocketWrapper;Lorg/apache/tomcat/util/net/SocketStatus;)Lorg/apache/tomcat/util/net/AbstractEndpoint$Handler$SocketState;+171
> (line 1221)
> fbc06848 *
> org/apache/coyote/http11/Http11AprProtocol$Http11ConnectionHandler.process(Lorg/apache/tomcat/util/net/SocketWrapper;Lorg/apache/tomcat/util/net/SocketStatus;)Lorg/apache/tomcat/util/net/AbstractEndpoint$Handler$SocketState;+76
> (line 546)
> fbc073e0 *
> org/apache/tomcat/util/net/AprEndpoint$SocketProcessor.doRun()V+26 (line
> 4492)
> fbc06b84 *
> org/apache/tomcat/util/net/AprEndpoint$SocketProcessor.run()V+55 (line 4468)
> ...
>
> GDB tells my:
>
> #7 0xb76dfe74 in Java_org_apache_tomcat_jni_Socket_recv (e=0x30b528,
> o=0xb30ff188, sock=, buf=0xb30ff214, offset=0,
> toread=8192) at src/network.c:733
> 733 if ((ss = (*s->net->recv)(s->opaque, sb, &nbytes)) ==
> APR_SUCCESS)
>
> #7 0xb76dfe74 in Java_org_apache_tomcat_jni_Socket_recv (e=0x30b528,
> o=0xb30ff188, sock=, buf=0xb30ff214, offset=0,
> toread=8192) at src/network.c:733
> sb =
> "\000\006\026\200\000\fÞ̳\017Ñ\000·\205{Í·\205{س\017Ñ\234³\017Ñ\030³\017Ш·\227(p»\204H\200ò\032\226x\000\000\000\023\000\000\000\000ûÁ\227hò\032\227\020³\017Ñ8³\017Ñ8ûÀhH\000\000\b¹³\017Ñh³\017ÑHûÀhH³\017ÑP\000\000\002°·\211+Ø\000\000\000u\000\000\000\000ò\032\227
> ò\032\226\210ò\032\226\210\000\000\000u\000\000\000\000³\017ÑhûÀhH»\204Hh¼Ð¬h\000\000\001\032\000\000\000\000³\017Ñ\230·\225x'·\225xH³\017Ò$³\017Ñ
>
> ³\017Ñ8·\225}ø\000\060´\000\000\000\000\000\000\000\000¶\000\000\000\000ûÁÄÀ"...
> s = 0xb29500
> nbytes = 8192
> ss =
>
> (gdb) print *s
> $5 = {pool = 0xb294c0, child = 0x0, sock = 0x0, opaque = 0xb297d8,
> jsbbuff = 0x330398 "HTTP/1.1 101 Switching Protocols\r\nServer:
> Apache-Coyote/1.1\r\nUpgrade: websocket\r\nConnection:
> upgrade\r\nSec-WebSocket-Accept: tPEj68f24a5073zco+NHsEUCKpY=\r\nDate:
> Fri, 02 Aug 2013 12:52:53 GMT\r\n\r\n",
> jrbbuff = 0xbfbc78 "GET /firehose HTTP/1.1\r\nSec-WebSocket-Version:
> 13\r\nUpgrade: websocket\r\nHost: localhost:59353\r\nSec-WebSocket-Key:
> qzlX6/aQxs4TAKyKCb+XLg==\r\nConnection: upgrade\r\n\r\n", net = 0x0, pe
> = 0xb87958, last_active = 0, timeout = -2}
>
> The reason for the crash is likely:
>
> (gdb) print s->net
> $7 = (tcn_nlayer_t *) 0x0
>
> So dereferencing it in (*s->net->recv) gives a segfault.
Sounds like https://issues.apache.org/bugzilla/show_bug.cgi?id=51813
I haven't committed a patch for this, yet. Can you add this same
information to that bug to make sure I get that particular call? I think
it's already there, but just in case.
-chris
signature.asc
Description: OpenPGP digital signature
Re: Tomcat Channel Issue in EC2 clustering environment
Jasintha, This is a question more appropriate for the users' list (us...@tomcat.apache.org). Consider re-posting there. -chris On 8/2/13 2:13 AM, Jasintha Dasanayaka wrote: > Hi all > > Axis2 Tribes utilizes Tomcat underneath. In Tomcat clustering, there's away > to add a listener to a channel, and get notifications based on different > scenarios such as member join, member leave etc. Axis2 tribes registers a > such listener in Tomcat, in order to identify whether a new member is > joined/left a Tomcat channel. > > We are using EC2 based clustering environment, In this case, > intermittently, we've seen that the memberDisappear event of that > particular listener hasn't been triggered when a member leaves a tomcat > channel. > > Any Idea ?? > > > /Jasintha > signature.asc Description: OpenPGP digital signature
buildbot success in ASF Buildbot on tomcat-trunk
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/4786 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source Stamp: [branch tomcat/trunk] 1510325 Blamelist: jboynes Build succeeded! sincerely, -The Buildbot
svn commit: r1510325 - /tomcat/trunk/build.xml
Author: jboynes Date: Sun Aug 4 19:43:16 2013 New Revision: 1510325 URL: http://svn.apache.org/r1510325 Log: Copy test file needed for TestWebappServiceLoader Modified: tomcat/trunk/build.xml Modified: tomcat/trunk/build.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=1510325&r1=1510324&r2=1510325&view=diff == --- tomcat/trunk/build.xml (original) +++ tomcat/trunk/build.xml Sun Aug 4 19:43:16 2013 @@ -1230,7 +1230,10 @@ - + + + + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1510210 - /tomcat/trunk/build.xml
On Aug 4, 2013, at 2:40 PM, Mark Thomas wrote: > On 04/08/2013 21:31, Nick Williams wrote: >> >> On Aug 4, 2013, at 2:27 PM, Mark Thomas wrote: >> >>> On 04/08/2013 21:02, Jeremy Boynes wrote: On Aug 4, 2013, at 8:37 AM, ma...@apache.org wrote: > Log: > Treat javax.servlet.ServletContainerInitializer files as text in source > > > + > Would this work to catch all service config files not just SCIs? >>> >>> What other ones are you expecting to find in the Tomcat source code? >>> >>> Mark >> >> Didn't someone say something about switching to an SCI to initialize Jasper >> in TC8? > > Which would still match the current pattern. > > Mark Yea. I realized my stupidity right after I pressed "send." :-) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1510210 - /tomcat/trunk/build.xml
On 04/08/2013 21:32, Jeremy Boynes wrote: > On Aug 4, 2013, at 12:27 PM, Mark Thomas wrote: > >> On 04/08/2013 21:02, Jeremy Boynes wrote: >>> On Aug 4, 2013, at 8:37 AM, ma...@apache.org wrote: Log: Treat javax.servlet.ServletContainerInitializer files as text in source + >>> >>> Would this work to catch all service config files not just SCIs? >>> >> >> What other ones are you expecting to find in the Tomcat source code? > > None as yet, just thinking :) > It was more "all files in META-INF/services would be text and calling out SCI > is being very specific) Then lets stick with the narrower definition until such time as we need to consider widening it. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1510210 - /tomcat/trunk/build.xml
On 04/08/2013 21:31, Nick Williams wrote: > > On Aug 4, 2013, at 2:27 PM, Mark Thomas wrote: > >> On 04/08/2013 21:02, Jeremy Boynes wrote: >>> On Aug 4, 2013, at 8:37 AM, ma...@apache.org wrote: Log: Treat javax.servlet.ServletContainerInitializer files as text in source + >>> >>> Would this work to catch all service config files not just SCIs? >>> >> >> What other ones are you expecting to find in the Tomcat source code? >> >> Mark > > Didn't someone say something about switching to an SCI to initialize Jasper > in TC8? Which would still match the current pattern. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1510310 - /tomcat/trunk/test/org/apache/catalina/startup/TestWebappServiceLoader.java
On Aug 4, 2013, at 11:55 AM, jboy...@apache.org wrote: > Author: jboynes > Date: Sun Aug 4 18:55:04 2013 > New Revision: 1510310 > > URL: http://svn.apache.org/r1510310 This may also have broken a clean build which I didn't catch as my IDE had copied service-config.txt to the output for me. I've got a patch for build.xml to copy it and am running a verification test for it at the moment before committing it. signature.asc Description: Message signed with OpenPGP using GPGMail
Re: svn commit: r1510210 - /tomcat/trunk/build.xml
On Aug 4, 2013, at 12:27 PM, Mark Thomas wrote: > On 04/08/2013 21:02, Jeremy Boynes wrote: >> On Aug 4, 2013, at 8:37 AM, ma...@apache.org wrote: >>> Log: >>> Treat javax.servlet.ServletContainerInitializer files as text in source >>> >>> >>> + >>> >> >> Would this work to catch all service config files not just SCIs? >> > > What other ones are you expecting to find in the Tomcat source code? None as yet, just thinking :) It was more "all files in META-INF/services would be text and calling out SCI is being very specific) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1510210 - /tomcat/trunk/build.xml
On Aug 4, 2013, at 2:27 PM, Mark Thomas wrote: > On 04/08/2013 21:02, Jeremy Boynes wrote: >> On Aug 4, 2013, at 8:37 AM, ma...@apache.org wrote: >>> Log: >>> Treat javax.servlet.ServletContainerInitializer files as text in source >>> >>> >>> + >>> >> >> Would this work to catch all service config files not just SCIs? >> > > What other ones are you expecting to find in the Tomcat source code? > > Mark Didn't someone say something about switching to an SCI to initialize Jasper in TC8? N - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1510210 - /tomcat/trunk/build.xml
On 04/08/2013 21:02, Jeremy Boynes wrote: > On Aug 4, 2013, at 8:37 AM, ma...@apache.org wrote: >> Log: >> Treat javax.servlet.ServletContainerInitializer files as text in source >> >> >> + >> > > Would this work to catch all service config files not just SCIs? > What other ones are you expecting to find in the Tomcat source code? Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
buildbot success in ASF Buildbot on tomcat-7-trunk
The Buildbot has detected a restored build on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/1321 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source Stamp: [branch tomcat/tc7.0.x/trunk] 1510247 Blamelist: markt Build succeeded! sincerely, -The Buildbot
Re: svn commit: r1510210 - /tomcat/trunk/build.xml
On Aug 4, 2013, at 8:37 AM, ma...@apache.org wrote: > Log: > Treat javax.servlet.ServletContainerInitializer files as text in source > > > + > Would this work to catch all service config files not just SCIs? signature.asc Description: Message signed with OpenPGP using GPGMail
Re: svn commit: r1510282 - in /tomcat/trunk: java/org/apache/catalina/startup/WebappServiceLoader.java test/org/apache/catalina/startup/TestWebappServiceLoader.java test/org/apache/catalina/startup/se
On Aug 4, 2013, at 11:32 AM, Mark Thomas wrote: > On 04/08/2013 20:00, jboy...@apache.org wrote: >> Author: jboynes >> Date: Sun Aug 4 18:00:40 2013 >> New Revision: 1510282 >> >> URL: http://svn.apache.org/r1510282 >> Log: >> Tests for WebappServiceLoader (requires EasyMock) > > Please fix the various checkstyle errors this commit has triggered. Curse you auto format. Done, sorry. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1510310 - /tomcat/trunk/test/org/apache/catalina/startup/TestWebappServiceLoader.java
Author: jboynes
Date: Sun Aug 4 18:55:04 2013
New Revision: 1510310
URL: http://svn.apache.org/r1510310
Log:
Fix checkstyle
Modified:
tomcat/trunk/test/org/apache/catalina/startup/TestWebappServiceLoader.java
Modified:
tomcat/trunk/test/org/apache/catalina/startup/TestWebappServiceLoader.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/startup/TestWebappServiceLoader.java?rev=1510310&r1=1510309&r2=1510310&view=diff
==
--- tomcat/trunk/test/org/apache/catalina/startup/TestWebappServiceLoader.java
(original)
+++ tomcat/trunk/test/org/apache/catalina/startup/TestWebappServiceLoader.java
Sun Aug 4 18:55:04 2013
@@ -32,16 +32,9 @@ import org.junit.Assert;
import org.junit.Before;
import org.junit.Test;
+import org.easymock.EasyMock;
import org.easymock.IMocksControl;
-import static org.easymock.EasyMock.createMockBuilder;
-import static org.easymock.EasyMock.createStrictControl;
-import static org.easymock.EasyMock.eq;
-import static org.easymock.EasyMock.expect;
-import static org.easymock.EasyMock.expectLastCall;
-import static org.easymock.EasyMock.isA;
-import static org.easymock.EasyMock.same;
-
public class TestWebappServiceLoader {
private static final String CONFIG_FILE =
"META-INF/services/javax.servlet.ServletContainerInitializer";
@@ -53,21 +46,23 @@ public class TestWebappServiceLoader {
@Before
public void init() {
-control = createStrictControl();
+control = EasyMock.createStrictControl();
parent = control.createMock(ClassLoader.class);
-cl = createMockBuilder(ClassLoader.class)
+cl = EasyMock.createMockBuilder(ClassLoader.class)
.withConstructor(parent)
.addMockedMethod("loadClass", String.class)
.createMock(control);
context = control.createMock(ServletContext.class);
-expect(context.getClassLoader()).andStubReturn(cl);
+EasyMock.expect(context.getClassLoader()).andStubReturn(cl);
}
@Test
public void testNoInitializersFound() throws IOException {
loader = new WebappServiceLoader<>(context);
-
expect(context.getAttribute(ServletContext.ORDERED_LIBS)).andReturn(null);
-
expect(cl.getResources(CONFIG_FILE)).andReturn(Collections.emptyEnumeration());
+EasyMock.expect(context.getAttribute(ServletContext.ORDERED_LIBS))
+.andReturn(null);
+EasyMock.expect(cl.getResources(CONFIG_FILE))
+.andReturn(Collections.emptyEnumeration());
control.replay();
Assert.assertTrue(loader.load(ServletContainerInitializer.class).isEmpty());
control.verify();
@@ -77,13 +72,14 @@ public class TestWebappServiceLoader {
@SuppressWarnings("unchecked")
public void testInitializerFromClasspath() throws IOException {
URL url = new URL("file://test");
-loader = createMockBuilder(WebappServiceLoader.class)
+loader = EasyMock.createMockBuilder(WebappServiceLoader.class)
.addMockedMethod("parseConfigFile", Set.class, URL.class)
.withConstructor(context).createMock(control);
-
expect(context.getAttribute(ServletContext.ORDERED_LIBS)).andReturn(null);
-expect(cl.getResources(CONFIG_FILE))
+EasyMock.expect(context.getAttribute(ServletContext.ORDERED_LIBS))
+.andReturn(null);
+EasyMock.expect(cl.getResources(CONFIG_FILE))
.andReturn(Collections.enumeration(Collections.singleton(url)));
-loader.parseConfigFile(isA(Set.class), same(url));
+loader.parseConfigFile(EasyMock.isA(Set.class), EasyMock.same(url));
control.replay();
Assert.assertTrue(loader.load(ServletContainerInitializer.class).isEmpty());
control.verify();
@@ -96,16 +92,20 @@ public class TestWebappServiceLoader {
URL sci1 = new URL("jar:file://jar1.jar!/" + CONFIG_FILE);
URL url2 = new URL("file://dir/");
URL sci2 = new URL("file://dir/" + CONFIG_FILE);
-loader = createMockBuilder(WebappServiceLoader.class)
+loader = EasyMock.createMockBuilder(WebappServiceLoader.class)
.addMockedMethod("parseConfigFile", Set.class, URL.class)
.withConstructor(context).createMock(control);
List jars = Arrays.asList("jar1.jar", "dir/");
-
expect(context.getAttribute(ServletContext.ORDERED_LIBS)).andReturn(jars);
-expect(context.getResource("/WEB-INF/lib/jar1.jar")).andReturn(url1);
-loader.parseConfigFile(isA(Set.class), eq(sci1));
-expect(context.getResource("/WEB-INF/lib/dir/")).andReturn(url2);
-loader.parseConfigFile(isA(Set.class), eq(sci2));
-
expect(parent.getResources(CONFIG_FILE)).andReturn(Collections.emptyEnumeration());
+EasyMock.expect(context.getAttribute(ServletContext.ORDERED_LIBS
Re: svn commit: r1510282 - in /tomcat/trunk: java/org/apache/catalina/startup/WebappServiceLoader.java test/org/apache/catalina/startup/TestWebappServiceLoader.java test/org/apache/catalina/startup/se
On 04/08/2013 20:00, jboy...@apache.org wrote: > Author: jboynes > Date: Sun Aug 4 18:00:40 2013 > New Revision: 1510282 > > URL: http://svn.apache.org/r1510282 > Log: > Tests for WebappServiceLoader (requires EasyMock) Please fix the various checkstyle errors this commit has triggered. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1510282 - in /tomcat/trunk: java/org/apache/catalina/startup/WebappServiceLoader.java test/org/apache/catalina/startup/TestWebappServiceLoader.java test/org/apache/catalina/startup/servic
Author: jboynes
Date: Sun Aug 4 18:00:40 2013
New Revision: 1510282
URL: http://svn.apache.org/r1510282
Log:
Tests for WebappServiceLoader (requires EasyMock)
Added:
tomcat/trunk/test/org/apache/catalina/startup/TestWebappServiceLoader.java
(with props)
tomcat/trunk/test/org/apache/catalina/startup/service-config.txt
Modified:
tomcat/trunk/java/org/apache/catalina/startup/WebappServiceLoader.java
Modified: tomcat/trunk/java/org/apache/catalina/startup/WebappServiceLoader.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/WebappServiceLoader.java?rev=1510282&r1=1510281&r2=1510282&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/startup/WebappServiceLoader.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/startup/WebappServiceLoader.java Sun
Aug 4 18:00:40 2013
@@ -128,8 +128,7 @@ public class WebappServiceLoader {
return loadServices(serviceType, servicesFound);
}
-private void parseConfigFile(Set servicesFound, URL url)
-throws IOException {
+void parseConfigFile(Set servicesFound, URL url) throws
IOException {
try (InputStream is = url.openStream()) {
InputStreamReader in =
new InputStreamReader(is, StandardCharsets.UTF_8);
@@ -149,8 +148,7 @@ public class WebappServiceLoader {
}
}
-private Collection loadServices(Class serviceType,
- Set servicesFound)
+Collection loadServices(Class serviceType, Set servicesFound)
throws IOException {
ClassLoader loader = context.getClassLoader();
List services = new ArrayList<>(servicesFound.size());
Added:
tomcat/trunk/test/org/apache/catalina/startup/TestWebappServiceLoader.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/startup/TestWebappServiceLoader.java?rev=1510282&view=auto
==
--- tomcat/trunk/test/org/apache/catalina/startup/TestWebappServiceLoader.java
(added)
+++ tomcat/trunk/test/org/apache/catalina/startup/TestWebappServiceLoader.java
Sun Aug 4 18:00:40 2013
@@ -0,0 +1,171 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.catalina.startup;
+
+import java.io.IOException;
+import java.net.URL;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+
+import javax.servlet.ServletContainerInitializer;
+import javax.servlet.ServletContext;
+
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.Test;
+
+import org.easymock.IMocksControl;
+
+import static org.easymock.EasyMock.createMockBuilder;
+import static org.easymock.EasyMock.createStrictControl;
+import static org.easymock.EasyMock.eq;
+import static org.easymock.EasyMock.expect;
+import static org.easymock.EasyMock.expectLastCall;
+import static org.easymock.EasyMock.isA;
+import static org.easymock.EasyMock.same;
+
+public class TestWebappServiceLoader {
+private static final String CONFIG_FILE =
+"META-INF/services/javax.servlet.ServletContainerInitializer";
+private IMocksControl control;
+private ClassLoader cl;
+private ClassLoader parent;
+private ServletContext context;
+private WebappServiceLoader loader;
+
+@Before
+public void init() {
+control = createStrictControl();
+parent = control.createMock(ClassLoader.class);
+cl = createMockBuilder(ClassLoader.class)
+.withConstructor(parent)
+.addMockedMethod("loadClass", String.class)
+.createMock(control);
+context = control.createMock(ServletContext.class);
+expect(context.getClassLoader()).andStubReturn(cl);
+}
+
+@Test
+public void testNoInitializersFound() throws IOException {
+loader = new WebappServiceLoader<>(context);
+
expect(context.getAttribute(ServletContext.ORDERED_LIBS)).andReturn(null);
+
expect(cl.getResources(CONFIG_FILE)).andReturn(Collections.emptyE
svn commit: r1510281 - in /tomcat/trunk: build.properties.default build.xml
Author: jboynes
Date: Sun Aug 4 17:59:37 2013
New Revision: 1510281
URL: http://svn.apache.org/r1510281
Log:
Add test dependency on EasyMock, cglib and objenesis
Modified:
tomcat/trunk/build.properties.default
tomcat/trunk/build.xml
Modified: tomcat/trunk/build.properties.default
URL:
http://svn.apache.org/viewvc/tomcat/trunk/build.properties.default?rev=1510281&r1=1510280&r2=1510281&view=diff
==
--- tomcat/trunk/build.properties.default (original)
+++ tomcat/trunk/build.properties.default Sun Aug 4 17:59:37 2013
@@ -205,6 +205,24 @@ hamcrest.home=${base.path}/hamcrest-${ha
hamcrest.jar=${hamcrest.home}/hamcrest-core-${hamcrest.version}.jar
hamcrest.loc=${base-maven.loc}/org/hamcrest/hamcrest-core/${hamcrest.version}/hamcrest-core-${hamcrest.version}.jar
+# - EasyMock, version 3.2 or later -
+easymock.version=3.2
+easymock.home=${base.path}/easymock-${easymock.version}
+easymock.loc=${base-sf.loc}/easymock/easymock-${easymock.version}.zip
+easymock.jar=${easymock.home}/easymock-${easymock.version}.jar
+
+# - cglib, used by EasyMock, version 2.2 or later -
+cglib.version=2.2.3
+cglib.home=${base.path}/cglib-${cglib.version}
+cglib.loc=${base-sf.loc}/cglib/cglib-nodep-${cglib.version}.jar
+cglib.jar=${cglib.home}/cglib-nodep-${cglib.version}.jar
+
+# - objenesis, used by EasyMock, version 1.2 or later -
+objenesis.version=1.2
+objenesis.home=${base.path}/objenesis-${objenesis.version}
+objenesis.loc=https://objenesis.googlecode.com/files/objenesis-${objenesis.version}-bin.zip
+objenesis.jar=${objenesis.home}/objenesis-${objenesis.version}.jar
+
# - Checkstyle, version 5.1 or later -
checkstyle.version=5.6
checkstyle.home=${base.path}/checkstyle-${checkstyle.version}
Modified: tomcat/trunk/build.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=1510281&r1=1510280&r2=1510281&view=diff
==
--- tomcat/trunk/build.xml (original)
+++ tomcat/trunk/build.xml Sun Aug 4 17:59:37 2013
@@ -190,6 +190,9 @@
+
+
+
@@ -2525,6 +2528,24 @@ Apache Tomcat ${version} native binaries
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
Re: Using a mock framework for testing?
On Jul 31, 2013, at 10:21 AM, Mark Thomas wrote: > On 31/07/2013 18:09, Jeremy Boynes wrote: >> Any objection to adding a dependency on a mocking framework to aid unit >> testing? >> The one I have used most is EasyMock which is Apache License 2.0. > > To save repeating the details of what I have said before: > http://markmail.org/message/io4q25hnrs2hgmxo > > Since then I still haven't seen a unit test that requires the use of > such a framework. > > There are a number of mock objects in the test classes already that > cover the most frequently required objects. I agree with the sentiment on using the embedded server for testing, especially when dealing with issues reported by users where it is important to reproduce them in the same way the issue was discovered. Where I have found mocks useful is for new work where they let you stress edge cases that would require scaffolding to reproduce. For example, I was looking at adding tests for WebappServiceLoader and wanted variations of the ServletContext and ClassLoader config used. For me, using EasyMock to set that up was simpler than defining test applications in those configurations. I'm going to go ahead and add that test with its EasyMock dependency. As I see it, it gives us another tool we can use where it helps. -- Jeremy signature.asc Description: Message signed with OpenPGP using GPGMail
svn commit: r1510276 - /tomcat/trunk/test/org/apache/catalina/nonblocking/TestNonBlockingAPI.java
Author: markt
Date: Sun Aug 4 17:42:15 2013
New Revision: 1510276
URL: http://svn.apache.org/r1510276
Log:
Better handling on test failure trying to debug failures on OSX with NIO.
Modified:
tomcat/trunk/test/org/apache/catalina/nonblocking/TestNonBlockingAPI.java
Modified:
tomcat/trunk/test/org/apache/catalina/nonblocking/TestNonBlockingAPI.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/nonblocking/TestNonBlockingAPI.java?rev=1510276&r1=1510275&r2=1510276&view=diff
==
--- tomcat/trunk/test/org/apache/catalina/nonblocking/TestNonBlockingAPI.java
(original)
+++ tomcat/trunk/test/org/apache/catalina/nonblocking/TestNonBlockingAPI.java
Sun Aug 4 17:42:15 2013
@@ -174,13 +174,16 @@ public class TestNonBlockingAPI extends
lineStart = lineEnd + 1;
lineEnd = resultString.indexOf('\n', lineStart);
System.out.println("Start : " + lineStart + ", End: " + lineEnd);
-line = resultString.substring(lineStart, lineEnd + 1);
+if (lineEnd > lineStart) {
+line = resultString.substring(lineStart, lineEnd + 1);
+} else {
+line = resultString.substring(lineStart);
+}
if (line.length() > 40) {
System.out.println(line.substring(0, 32));
} else {
System.out.println(line);
}
-Assert.assertTrue(line.endsWith("\r\n"));
if (chunkSize + 2 != line.length()) {
System.out.println("Chunk wrong length. Was " + line.length() +
" Expected " + (chunkSize + 2));
@@ -188,12 +191,19 @@ public class TestNonBlockingAPI extends
int pos = 0;
String seq = "0123456789ABCDEF";
// Assume starts with 0
-while (line.subSequence(pos, pos + seq.length()).equals(seq)) {
+while (pos + seq.length() < line.length() &&
+line.subSequence(pos, pos + seq.length()).equals(seq))
{
pos += seq.length();
}
-System.out.println("Failed at position " + pos + " " +
-line.substring(pos, pos + seq.length()));
+if (pos + seq.length() < line.length()) {
+System.out.println("Failed at position " + pos + " " +
+line.substring(pos, pos + seq.length()));
+} else {
+System.out.println("Failed at position " + pos + " " +
+line.substring(pos));
+}
}
+Assert.assertTrue(line.endsWith("\r\n"));
Assert.assertEquals(chunkSize + 2, line.length());
totalBodyRead += chunkSize;
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1510271 - /tomcat/trunk/java/org/apache/catalina/startup/WebappServiceLoader.java
Author: jboynes
Date: Sun Aug 4 17:39:53 2013
New Revision: 1510271
URL: http://svn.apache.org/r1510271
Log:
Remove redundant check.
Modified:
tomcat/trunk/java/org/apache/catalina/startup/WebappServiceLoader.java
Modified: tomcat/trunk/java/org/apache/catalina/startup/WebappServiceLoader.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/WebappServiceLoader.java?rev=1510271&r1=1510270&r2=1510271&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/startup/WebappServiceLoader.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/startup/WebappServiceLoader.java Sun
Aug 4 17:39:53 2013
@@ -144,9 +144,6 @@ public class WebappServiceLoader {
if (line.length() == 0) {
continue;
}
-if (servicesFound.contains(line)) {
-continue;
-}
servicesFound.add(line);
}
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1510247 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/StandardContext.java
Author: markt
Date: Sun Aug 4 16:47:47 2013
New Revision: 1510247
URL: http://svn.apache.org/r1510247
Log:
Improve error message
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardContext.java
Propchange: tomcat/tc7.0.x/trunk/
--
Merged /tomcat/trunk:r1510246
Modified:
tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardContext.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardContext.java?rev=1510247&r1=1510246&r2=1510247&view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardContext.java
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardContext.java Sun
Aug 4 16:47:47 2013
@@ -4861,7 +4861,7 @@ public class StandardContext extends Con
ExceptionUtils.handleThrowable(t);
getLogger().error
(sm.getString("standardContext.applicationListener",
- listeners[i]), t);
+ listeners[i].getClassName()), t);
ok = false;
}
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1510246 - /tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
Author: markt
Date: Sun Aug 4 16:46:33 2013
New Revision: 1510246
URL: http://svn.apache.org/r1510246
Log:
Improve error message
Modified:
tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/StandardContext.java?rev=1510246&r1=1510245&r2=1510246&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/StandardContext.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/StandardContext.java Sun Aug 4
16:46:33 2013
@@ -4768,7 +4768,7 @@ public class StandardContext extends Con
ExceptionUtils.handleThrowable(t);
getLogger().error
(sm.getString("standardContext.applicationListener",
- listeners[i]), t);
+ listeners[i].getClassName()), t);
ok = false;
}
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.0-RC1
On 03/08/2013 12:06, Rainer Jung wrote: > Overview: > > - one crash in tcnative during unit tests > - MBeans indicate common loader is gone (is that expected? > At least the common.loader entry still exists in catalina.properties) Expected as StandardClassLoader has been removed. That decision is reversible of there is a use case for having the class loader visible in JMX. > - some MBean data gone (resource cache statistics, environment content) Resource cache is expected. Env is not. Might need to add more JMX stats to new WebResource implementation. > - Catalina:j2eeType=WebModule,name=//localhost attribute > workDir switched from work/Catalina/localhost/_ > to work/Catalina/localhost/ROOT Expected. > - new SEVERE and Exceptions in unit test output, maybe expected Unless the test fails then these should be expected. > - bayeaux and tomcat-lite modules not bundled Expected. I won't be copying these to tc8.0.x/trunk > - MD5 OK > - signatures OK > - key in KEYS file > - gz and zip for src and bin consistent > ! src consistent with svn tag except: > - modules bayeux and tomcat-lite not in src See above. > - file > res/META-INF/tomcat-websocket.jar/services/javax.servlet.ServletContainerInitializer > has Unix line ends in svn, but the src archives > for Unix and Windows both contain it with DOS line ends It wasn't treated as a text file. Now fixed. > ! builds fine but > - several warning about unsafe or unchecked operations. > See full list at end of mail. I was expecting all of those to be unfixable. To double-check I disabled Eclipse's hide unavoidable generics errors and to my surprise ~30% were easily fixable. These have been fixed. The rest do look to be unavoidable. Digging into the 'fixes' all they appear to be doing is using a JRE method that already has @SupressWarnings so arguably Eclipse was right. Even so, I am no longer as strongly +1 for using this option as I have been. > - build result looks consistent with binaries > - no checkstyle complaints > - only few Javadoc warnings, I fixed those > ! Unit tests few failures and errors: These need looking at. Note: Many of the tests are timing sensitive and do not fail consistently. Making the tests less sensitive to timing is an ongoing task. > > - Timing: TestWebSocketFrameClient.testConnectToServerEndpointSSL() > took 63-66 seconds, but expects only 60 seconds. > > > - On NIO in addition (same test): > > java.lang.NullPointerException > at > org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.longPoll(Http11NioProtocol.java:276) > at > org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:692) > at > org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:223) > at > org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1592) > at > org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1550) > at > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) > at > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) > at java.lang.Thread.run(Thread.java:724) > > > - On APR in addition a crash (core) in: > > b76dfe74 Java_org_apache_tomcat_jni_Socket_recv (30b528, b30ff188, > b30fd09c, b29500, b30ff214, 0) + 34 > fbc0f780 * org/apache/tomcat/jni/Socket.recv(J[BII)I+32362 > fbc0f72c * org/apache/tomcat/jni/Socket.recv(J[BII)I+0 > fbc068ec * > org/apache/coyote/http11/upgrade/AprServletInputStream.doRead(Z[BII)I+73 > (line 101) > fbc068ec * > org/apache/coyote/http11/upgrade/AbstractServletInputStream.read([BII)I+20 > (line 229) > fbc068ec * > org/apache/tomcat/websocket/server/WsFrameServer.onDataAvailable()V+46 > (line 89) > fbc06b84 * > org/apache/tomcat/websocket/server/WsHttpUpgradeHandler$WsReadListener.onDataAvailable()V+4 > (line 384) > fbc0771c * > org/apache/coyote/http11/upgrade/AbstractServletInputStream.onDataAvailable()V+11 > (line 337) > fbc06b84 * > org/apache/coyote/http11/upgrade/AbstractProcessor.upgradeDispatch(Lorg/apache/tomcat/util/net/SocketStatus;)Lorg/apache/tomcat/util/net/AbstractEndpoint$Handler$SocketState;+11 > (line 189) > fbc073e0 * > org/apache/coyote/AbstractProtocol$AbstractConnectionHandler.process(Lorg/apache/tomcat/util/net/SocketWrapper;Lorg/apache/tomcat/util/net/SocketStatus;)Lorg/apache/tomcat/util/net/AbstractEndpoint$Handler$SocketState;+171 > (line 1221) > fbc06848 * > org/apache/coyote/http11/Http11AprProtocol$Http11ConnectionHandler.process(Lorg/apache/tomcat/util/net/SocketWrapper;Lorg/apache/tomcat/util/net/SocketStatus;)Lorg/apache/tomcat/util/net/AbstractEndpoint$Handler$SocketState;+76 > (line 546) > fbc073e0 * > org/apache/tomcat/util/net/AprEndpoint$SocketProcessor.doRun()V+26 (line > 4492) > fbc06b84 * > org/apache/tomcat/util/net/AprEndpoint$SocketProcessor.run()V+55 (line 4468) > ... >
svn commit: r1510210 - /tomcat/trunk/build.xml
Author: markt Date: Sun Aug 4 15:37:23 2013 New Revision: 1510210 URL: http://svn.apache.org/r1510210 Log: Treat javax.servlet.ServletContainerInitializer files as text in source Modified: tomcat/trunk/build.xml Modified: tomcat/trunk/build.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=1510210&r1=1510209&r2=1510210&view=diff == --- tomcat/trunk/build.xml (original) +++ tomcat/trunk/build.xml Sun Aug 4 15:37:23 2013 @@ -226,6 +226,7 @@ + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1510200 - in /tomcat/trunk/java: javax/websocket/ javax/websocket/server/ org/apache/tomcat/websocket/ org/apache/tomcat/websocket/pojo/ org/apache/tomcat/websocket/server/
Author: markt
Date: Sun Aug 4 15:08:37 2013
New Revision: 1510200
URL: http://svn.apache.org/r1510200
Log:
Fix some unchecked conversion warnings.
Modified:
tomcat/trunk/java/javax/websocket/ClientEndpointConfig.java
tomcat/trunk/java/javax/websocket/server/ServerEndpointConfig.java
tomcat/trunk/java/org/apache/tomcat/websocket/WsSession.java
tomcat/trunk/java/org/apache/tomcat/websocket/WsWebSocketContainer.java
tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoEndpointClient.java
tomcat/trunk/java/org/apache/tomcat/websocket/server/WsServerContainer.java
Modified: tomcat/trunk/java/javax/websocket/ClientEndpointConfig.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/javax/websocket/ClientEndpointConfig.java?rev=1510200&r1=1510199&r2=1510200&view=diff
==
--- tomcat/trunk/java/javax/websocket/ClientEndpointConfig.java (original)
+++ tomcat/trunk/java/javax/websocket/ClientEndpointConfig.java Sun Aug 4
15:08:37 2013
@@ -44,12 +44,12 @@ public interface ClientEndpointConfig ex
}
private Configurator configurator = DEFAULT_CONFIGURATOR;
-private List preferredSubprotocols = Collections.EMPTY_LIST;
-private List extensions = Collections.EMPTY_LIST;
+private List preferredSubprotocols = Collections.emptyList();
+private List extensions = Collections.emptyList();
private List> encoders =
-Collections.EMPTY_LIST;
+Collections.emptyList();
private List> decoders =
-Collections.EMPTY_LIST;
+Collections.emptyList();
public ClientEndpointConfig build() {
@@ -72,7 +72,7 @@ public interface ClientEndpointConfig ex
List preferredSubprotocols) {
if (preferredSubprotocols == null ||
preferredSubprotocols.size() == 0) {
-this.preferredSubprotocols = Collections.EMPTY_LIST;
+this.preferredSubprotocols = Collections.emptyList();
} else {
this.preferredSubprotocols =
Collections.unmodifiableList(preferredSubprotocols);
@@ -84,7 +84,7 @@ public interface ClientEndpointConfig ex
public Builder extensions(
List extensions) {
if (extensions == null || extensions.size() == 0) {
-this.extensions = Collections.EMPTY_LIST;
+this.extensions = Collections.emptyList();
} else {
this.extensions = Collections.unmodifiableList(extensions);
}
@@ -94,7 +94,7 @@ public interface ClientEndpointConfig ex
public Builder encoders(List> encoders) {
if (encoders == null || encoders.size() == 0) {
-this.encoders = Collections.EMPTY_LIST;
+this.encoders = Collections.emptyList();
} else {
this.encoders = Collections.unmodifiableList(encoders);
}
@@ -104,7 +104,7 @@ public interface ClientEndpointConfig ex
public Builder decoders(List> decoders) {
if (decoders == null || decoders.size() == 0) {
-this.decoders = Collections.EMPTY_LIST;
+this.decoders = Collections.emptyList();
} else {
this.decoders = Collections.unmodifiableList(decoders);
}
Modified: tomcat/trunk/java/javax/websocket/server/ServerEndpointConfig.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/javax/websocket/server/ServerEndpointConfig.java?rev=1510200&r1=1510199&r2=1510200&view=diff
==
--- tomcat/trunk/java/javax/websocket/server/ServerEndpointConfig.java
(original)
+++ tomcat/trunk/java/javax/websocket/server/ServerEndpointConfig.java Sun Aug
4 15:08:37 2013
@@ -59,10 +59,12 @@ public interface ServerEndpointConfig ex
private final Class endpointClass;
private final String path;
-private List> encoders =
Collections.EMPTY_LIST;
-private List> decoders =
Collections.EMPTY_LIST;
-private List subprotocols = Collections.EMPTY_LIST;
-private List extensions = Collections.EMPTY_LIST;
+private List> encoders =
+Collections.emptyList();
+private List> decoders =
+Collections.emptyList();
+private List subprotocols = Collections.emptyList();
+private List extensions = Collections.emptyList();
private Configurator configurator =
Configurator.fetchContainerDefaultConfigurator();
@@ -82,7 +84,7 @@ public interface ServerEndpointConfig ex
public Builder encoders(
List> encoders) {
if (encoders == null || encoders.size() == 0) {
-this.encoders = Collections.EMPTY_LIST;
+this.encoders = Colle
Re: [VOTE] Release Apache Tomcat 8.0.0-RC1
2013/8/2 Mark Thomas : > The proposed Apache Tomcat 8.0.0 release candidate 1 is now available > for voting. > > Given this is a release candidate I am working on the basis that it is > equivalent to an alpha. That said: > - Servlet 3.1 is complete > - JSP 2.3 is complete > - EL 3.0 is complete > - WebSocket 1.0 is complete > - DBCP2 is working but in a state of flux but the early stages of JMX > monitoring are available > > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0-RC1/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-048/ > The svn tag is: > http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0_RC1/ > > The proposed 8.0.0-RC1 release is: > [ ] Broken - do not release > [X] Alpha - go ahead and release as 8.0.0-RC1 alpha Tested with some applications > > Cheers, > > Mark > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > -- Olivier Lamy Ecetera: http://ecetera.com.au http://twitter.com/olamy | http://linkedin.com/in/olamy - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat 8 [2013/08/04]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |51497|New|Enh|2011-07-11|Use canonical IPv6 text representation in logs| |53737|Opn|Enh|2012-08-18|Use ServletContext.getJspConfigDescriptor() in Jas| |53930|New|Enh|2012-09-24|allow capture of catalina stdout/stderr to a comma| |54095|New|Enh|2012-11-03|[patch] support gzipped versions of static resourc| |54503|New|Enh|2013-01-29|SAML2 based single sign on| |54700|New|Enh|2013-03-15|Improvement: Add support for system property to sp| |54741|New|Enh|2013-03-22|Add org.apache.catalina.startup.Tomcat#addWebapp(S| |55006|New|Enh|2013-05-22|Add http proxy support for ClientEndpoint using sy| |55212|New|Enh|2013-07-08|Jasper does not validate XSD-based configuration f| |55215|Opn|Min|2013-07-08|Improvements to sample log4j configuration| |55243|New|Enh|2013-07-11|Add special search string for nested roles| |55246|New|Enh|2013-07-12|Delegate TLD processing for listeners to the JSP e| |55249|New|Nor|2013-07-12|JspC compiles tag files even if compile options is| |55251|New|Nor|2013-07-12|JspC fails silently if directory for generated web| |55252|New|Enh|2013-07-12|Separate Ant and command-line wrappers for JspC | +-+---+---+--+--+ | Total 15 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat 6 [2013/08/04]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |41679|New|Enh|2007-02-22|SemaphoreValve should be able to filter on url pat| |41883|Ass|Enh|2007-03-18|use abstract wrapper instead of plain X509Certific| |43001|New|Enh|2007-07-30|JspC lacks setMappedFile and setDie for use in Ant| |43400|New|Enh|2007-09-14|enum support for tag libs | |43548|Opn|Enh|2007-10-04|xml schema for tomcat-users.xml | |43682|New|Enh|2007-10-23|JULI: web-inf/classes/logging.properties to suppor| |43742|New|Enh|2007-10-30|.tag compiles performed one at a time -- extremel| |43979|New|Enh|2007-11-27|Add abstraction for Java and Classfile output | |44199|New|Enh|2008-01-10|expose current backlog queue size | |44225|New|Enh|2008-01-14|SSL connector tries to load the private keystore f| |44294|New|Enh|2008-01-25|Support for EL functions with varargs | |44645|New|Enh|2008-03-20|[Patch] JNDIRealm - Doesn't support JNDI "java.nam| |44787|New|Enh|2008-04-09|provide more error context on "java.lang.IllegalSt| |44818|New|Enh|2008-04-13|tomcat hangs with GET when content-length is defin| |45014|New|Enh|2008-05-15|Request and Response classes should have wrappers | |45282|New|Enh|2008-06-25|NioReceiver doesn't close cleanly, leaving sockets| |45428|New|Enh|2008-07-18|warn if the tomcat stop doesn't complete | |45832|New|Enh|2008-09-18|add DIGEST authentication support to Ant tasks| |45878|New|Enh|2008-09-24|Generated jars do not contain proper manifests or | |45879|Opn|Enh|2008-09-24|Windows installer fails to install NOTICE and RELE| |45931|Opn|Enh|2008-10-01|trimSpaces incorrectly modifies output| |46173|New|Enh|2008-11-09|Small patch for manager app: Setting an optional c| |46284|New|Enh|2008-11-24|Add flag to DeltaManager that blocks processing cl| |46350|New|Enh|2008-12-05|Maven repository should contain source bundles| |46558|Opn|Enh|2009-01-19|Shutdown port with address binding| |46727|New|Enh|2009-02-17|DefaultServlet - serving multiple encodings | |46902|New|Enh|2009-03-24|LoginValve to bypass restrictions of j_security_ch| |47214|New|Enh|2009-05-17|Inner classes that are explicitly referenced - sho| |47242|New|Enh|2009-05-22|request for AJP command line client | |47281|New|Enh|2009-05-28|Efficiency of the JDBCStore | |47407|New|Enh|2009-06-23|HttpSessionListener doesn't operate in the session| |47467|New|Enh|2009-07-02|Deployment of the war file by URL when contextpath| |47834|New|Enh|2009-09-14|TldConfig throws Exception when exploring unpacked| |47919|New|Enh|2009-09-30|Log Tomcat & Java environment variables in additio| |48358|Opn|Enh|2009-12-09|JSP-unloading reloaded| |48543|New|Enh|2010-01-14|[Patch] More flexibility in specifying -Dcatalina.| |48672|New|Enh|2010-02-03|Tomcat Virtual Host Manager (/host-manager) have b| |48674|New|Enh|2010-02-03|Tomcat Virtual Host Manager application doesn't pe| |48743|New|Enh|2010-02-15|Make the SLEEP variable in catalina.sh settable fr| |48899|New|Enh|2010-03-12|Guess URI charset should solve lot of problems| |48922|New|Enh|2010-03-16|org.apache.catalina.connector.Request clone static| |48928|New|Enh|2010-03-17|An alternative solution to preloading classes when| |49161|New|Enh|2010-04-21|Unknown Publisher when installing tomcat 6.0.26 | |49176|Opn|Enh|2010-04-23|Jasper in Dev Mode Is Memory Inefficient | |49464|New|Enh|2010-06-18|DefaultServlet and CharacterEncoding | |49531|New|Enh|2010-06-30|singlesignon failover not working on DeltaManager/| |49804|New|Enh|2010-08-23|Allow Embedded.redirectStreams value to be configu| |49939|New|Enh|2010-09-16|Expose a method via JMX which empties the webapp f| |49943|New|Enh|2010-09-16|Logging (via juli) does not reread configuration c| |50285|New|Enh|2010-11-17|Standard HTTP and AJP connectors silently ignore a| |50288|New|Enh|2010-11-17|Uploading a war file that already exists should au| |50692|
Bug report for Tomcat Connectors [2013/08/04]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |34526|Opn|Nor|2005-04-19|Truncated content in decompressed requests from mo| |35959|Opn|Enh|2005-08-01|mod_jk not independant of UseCanonicalName| |43303|New|Enh|2007-09-04|Versioning under Windows not reported by many conn| |43968|Inf|Enh|2007-11-26|[patch] support ipv6 with mod_jk | |44290|Inf|Nor|2008-01-24|mod_jk/1.2.26: retry is not useful for an importan| |44349|Inf|Maj|2008-02-04|mod_jk/1.2.26 module does not read worker.status.s| |44379|New|Enh|2008-02-07|convert the output of strftime into UTF-8 | |44454|New|Nor|2008-02-19|busy count reported in mod_jk inflated, causes inc| |44571|New|Enh|2008-03-10|Limits busy per worker to a threshold | |45063|New|Nor|2008-05-22|JK-1.2.26 IIS ISAPI filter issue when running diff| |45313|New|Nor|2008-06-30|mod_jk 1.2.26 & apache 2.2.9 static compiled on so| |46337|New|Nor|2008-12-04|real worker name is wrong | |46767|New|Enh|2009-02-25|mod_jk to send DECLINED in case no fail-over tomca| |47327|New|Enh|2009-06-07|remote_user not logged in apache logfile | |47617|Inf|Enh|2009-07-31|include time spent doing ajp_get_endpoint() in err| |47678|New|Cri|2009-08-11|Unable to allocate shared memory when using isapi_| |47714|New|Cri|2009-08-20|Reponse mixed between users | |47750|New|Maj|2009-08-27|Loss of worker settings when changing via jkstatus| |47795|New|Maj|2009-09-07|service sticky_session not being set correctly wit| |47840|Inf|Min|2009-09-14|A broken worker name is written in the log file. | |48191|New|Maj|2009-11-13|Problem with mod_jk 1.2.28 - Can not render up the| |48460|New|Nor|2009-12-30|mod_proxy_ajp document has three misleading portio| |48490|New|Nor|2010-01-05|Changing a node to stopped in uriworkermap.propert| |48513|New|Enh|2010-01-09|IIS Quick setup instructions | |48564|New|Nor|2010-01-18|Unable to turn off retries for LB worker | |48830|New|Nor|2010-03-01|IIS shutdown blocked in endpoint service when serv| |48891|Opn|Enh|2010-03-11|Missing EOL-style settings in tomcat/jk/trunk | |49035|New|Maj|2010-04-01|data lost when post a multipart/form-data form| |49063|New|Enh|2010-04-07|Please add JkStripSession status in jk-status work| |49135|New|Enh|2010-04-16|SPDY Connector for The Tomcat | |49469|New|Enh|2010-06-19|Workers status page has negative number of connect| |49732|Opn|Nor|2010-08-10|reply_timeout can't wait forever. | |49822|New|Enh|2010-08-25|Add hash lb worker method | |49903|New|Enh|2010-09-09|Make workers file reloadable | |50186|New|Nor|2010-10-31|Wrong documentation of connection_pool_timeout / c| |52334|New|Maj|2011-12-14|recover_time is not properly used | |52483|New|Enh|2012-01-18|Print JkOptions's options in log file and jkstatus| |52651|New|Nor|2012-02-13|JKSHMFile size limitation | |53324|Opn|Nor|2012-05-30|Starting with mod_jk 1.2.35 I cannot modify worker| |53542|New|Min|2012-07-13|Spelling mistake on 503 service unavailable page | |53762|New|Nor|2012-08-22|JK status manager: mass nodes handling doesn't wor| |53883|New|Maj|2012-09-17|isapi_redirect v 1.2.37 crashes w3wp.exe on the p| |53977|New|Maj|2012-10-07|32bits isapi connector cannot work in wow64 mode | |54027|New|Cri|2012-10-18|isapi send request to outside address instead of i| |54112|Opn|Blk|2012-11-07|ISAPI redirector not working when IIS recycles| |54117|New|Maj|2012-11-08|access violation exception in isapi_redirect.dll | |54177|New|Nor|2012-11-20|jkmanager generates non-well-formed XML for certai| |54596|New|Nor|2013-02-22|Relative path functionality truncates last charact| |54621|New|Nor|2013-02-28|[PATCH] custom mod_jk availability checks | |54646|New|Trv|2013-03-06|socket_keepalive is sometimes 1 or true or True in| |54923|New|Nor|2013-05-03|nsapi_redirect.so does not work with iPlanet on So| |55094|
Bug report for Tomcat Native [2013/08/04]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |46179|Opn|Maj|2008-11-10|apr ssl client authentication | |48655|Inf|Nor|2010-02-02|Active multipart downloads prevent tomcat shutdown| |49038|Inf|Nor|2010-04-02|Crash in tcnative | |51813|New|Cri|2011-09-14|Tomcat randomly crashes with [libtcnative-1.so.1+0| |52153|New|Maj|2011-11-08|periodic JVM crash (access violation) on buffer fl| |52319|New|Maj|2011-12-12|Tomcat 6 crashes with [libapr-1.so.0+0x196da] sig| |52627|New|Min|2012-02-08|Segmentation fault in org.apache.tomcat.jni.File.i| |53605|New|Nor|2012-07-26|use tcnative-1.1.24 Tomcat shutdown still crash | |53847|Inf|Nor|2012-09-10|High CPU usage in tomcat native 1.22+ | |53940|New|Enh|2012-09-27|Added support for new CRL loading after expiration| |53952|New|Nor|2012-10-02|Add support for TLS 1.1 and 1.2 | |54085|New|Nor|2012-11-01|ssl_socket_recv sometimes loops infinitely with no| |54664|New|Reg|2013-03-11|[1.1.27 branch] Poll.remove incorrectly reports AP| |55087|New|Cri|2013-06-10|tomcat crashes in tcnative-1.dll with OCSP when OC| |55113|New|Nor|2013-06-18|FIPS-compatible OpenSSL fails fingerprint test in | |55114|New|Nor|2013-06-18|BUILDING file in win32 source package contains UNI| +-+---+---+--+--+ | Total 16 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Taglibs [2013/08/04]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |38193|Ass|Enh|2006-01-09|[RDC] BuiltIn Grammar support for Field | |38600|Ass|Enh|2006-02-10|[RDC] Enable RDCs to be used in X+V markup (X+RDC)| |42413|New|Enh|2007-05-14|[PATCH] Log Taglib enhancements | |46052|New|Nor|2008-10-21|SetLocaleSupport is slow to initialize when many l| |48333|New|Enh|2009-12-02|TLD generator | +-+---+---+--+--+ | Total5 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat 7 [2013/08/04]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |16579|New|Enh|2003-01-30|documentation page layout/style breaks wrapping to| |18500|New|Enh|2003-03-30|Host aliases to match by regular expression | |28039|Opn|Enh|2004-03-30|Cluster Support for SingleSignOn | |40728|Inf|Enh|2006-10-11|Catalina MBeans use non-serializable classes | |40881|Opn|Enh|2006-11-02|Unable to receive message through TCP channel -> | |41007|Opn|Enh|2006-11-20|Can't define customized 503 error page| |43866|New|Enh|2007-11-14|add support for session attribute propagation with| |43925|Opn|Enh|2007-11-21|org.apache.jasper.runtime.BodyContentImpl causing | |44216|New|Enh|2008-01-11|Don't reuse session ID even if emptySessionPath=tr| |48550|New|Enh|2010-01-14|Update examples and default server.xml to use UTF-| |49395|New|Enh|2010-06-06|manager.findLeaks : display the date when the leak| |49589|New|Enh|2010-07-12|Tag handlers with constant attribute values are al| |49785|New|Enh|2010-08-19|Enabling TLS for JNDIRealm| |49821|New|Enh|2010-08-25|Tomcat CLI| |50019|New|Enh|2010-09-28|Adding JNDI "lookup-name" support In XML and Resou| |50175|New|Enh|2010-10-28|Enhance memory leak detection by selectively apply| |50234|New|Enh|2010-11-08|JspC use servlet 3.0 features | |50504|New|Enh|2010-12-21|Allow setting query string character set trough re| |50670|New|Enh|2011-01-27|Tribes | RpcChannel | Add option to specify extern| |51195|New|Enh|2011-05-13|"Find leaks" reports a false positive memory/class| |51294|Opn|Enh|2011-05-30|Since 7.0.12 do not work option unpackWARs=true fo| |51423|Inf|Enh|2011-06-23|[Patch] to add a path and a version parameters to | |51463|New|Enh|2011-07-01|Tomcat.setBaseDir (package org.apache.catalina.st| |51496|New|Enh|2011-07-11|NSIS - Warn that duplicate service name will resul| |51526|New|Enh|2011-07-18|Process web application context config with embedd| |51587|New|Enh|2011-07-29|Implement status and uptime commands | |51953|New|Enh|2011-10-04|Proposal: netmask filtering valve and filter | |52092|New|Enh|2011-10-26|Please make AsyncFileHandler and OneLineFormatter | |52235|New|Enh|2011-11-23|Please do a bit of SEO tuning for the web site| |52323|New|Enh|2011-12-13|Cobertura test code coverage support for build.xml| |52381|New|Enh|2011-12-22|Please add OSGi metadata | |52448|New|Enh|2012-01-11|Cache jar indexes in WebappClassLoader to speed up| |52489|New|Enh|2012-01-19|Enhancement request for code signing of war files | |52558|New|Enh|2012-01-30|CometConnectionManagerValve is adding non-serializ| |52688|New|Enh|2012-02-16|Add ability to remove old access log files| |52751|Opn|Enh|2012-02-23|Optimized configuration of the system info display| |52952|New|Enh|2012-03-20|Improve ExtensionValidator handling for embedded s| |53085|New|Enh|2012-04-16|[perf] [concurrency] DefaultInstanceManager.annota| |53387|New|Enh|2012-06-08|SSI: Allow to use $1 to get result of regular expr| |53411|Opn|Enh|2012-06-13|NullPointerException in org.apache.tomcat.util.buf| |53492|New|Enh|2012-07-01|Make JspC shell multithreaded | |53553|New|Enh|2012-07-16|[PATCH] Deploy uploaded WAR with context.xml from | |53602|New|Enh|2012-07-25|Support for HTTP status code 451 | |53620|New|Enh|2012-07-30|[juli] delay opening a file until something gets l| |54330|New|Enh|2012-12-19|Patch with some refactoring of Member.java| |54499|New|Enh|2013-01-29|Implementation of Extensible EL Interpreter | |54618|New|Enh|2013-02-28|Add filter implementing HTTP Strict Transport Secu| |54802|New|Enh|2013-04-04|Provide location information for exceptions thrown| |55104|New|Enh|2013-06-16|Allow passing arguments with spaces to Commons Dae| |55317|New|Enh|2013-07-28|Facilitate weaving by allowing ClassFileTransforme| +-+---+---+--+--+ | Total
Bug report for Tomcat Modules [2013/08/04]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |48240|New|Nor|2009-11-19|Tomcat-Lite missing @Override markers | |48268|New|Nor|2009-11-23|Patch to fix generics in tomcat-lite | |48861|New|Nor|2010-03-04|Files without AL headers | |49685|New|Nor|2010-08-02|Unsafe synchronization in class ManagedBean | |49686|New|Nor|2010-08-02|Using an instance lock to protect static shared da| |50571|Inf|Nor|2011-01-11|Tomcat 7 JDBC connection pool exception enhancemen| |51595|Inf|Nor|2011-08-01|org.apache.tomcat.jdbc.pool.jmx.ConnectionPool sho| |51879|Inf|Enh|2011-09-22|Improve access to Native Connection Methods | |52024|Inf|Enh|2011-10-13|Custom interceptor to support automatic failover o| |53088|Opn|Min|2012-04-17|Give PoolCleaner TimerTask a better name | |53198|New|Cri|2012-05-07|'driverClassName' Data Source Property Being Manda| |53199|Inf|Enh|2012-05-07|Refactor ConnectionPool to use ScheduledExecutorSe| |53200|New|Enh|2012-05-07|Be able to use SlowQueryReport without reporting f| |53770|New|Enh|2012-08-23|tomcat-pool: always log validation query syntax er| |53853|New|Nor|2012-09-11|Can tomcat-jdbc consider Thread#getContextClassLoa| |54225|New|Nor|2012-11-30|if initSQL property is set to an empty string a Nu| |54227|New|Nor|2012-11-30|maxAge should be checked on borrow| |54235|New|Nor|2012-12-03|tomcat jdbc pool stackoverflow error used with spr| |54395|New|Nor|2013-01-09|JdbcInterceptor config parameter parsing errors | |54437|New|Enh|2013-01-16|Update PoolProperties javadoc for ConnectState int| |54537|New|Cri|2013-02-07|StatementFinalizer closeInvoked is too slow for la| |54693|New|Enh|2013-03-13|Add a validationQueryTimeout property | |54929|New|Nor|2013-05-05|jdbc-pool cannot be used with Java 1.5, "java.lang| |54978|New|Nor|2013-05-15|Validate on Borrow should be tested on Reconnect i| |55078|New|Nor|2013-06-07|Configuring a DataSource Resource with dataSourceJ| |55342|New|Nor|2013-08-02|Lost interruption | |55343|New|Enh|2013-08-02|Add flag to ignore exceptions while creating initi| +-+---+---+--+--+ | Total 27 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
