Re: [VOTE] Release Apache Tomcat 8.0.0
Hi, Broken - do not release. It seems WebSocket support is broken for Google Chrome 32+. I tested Apache Wicket integration and it failed with: WebSocket connection to 'ws://localhost:8080/ws/wicket/websocket?pageId=0wicket-ajax-baseurl=behavior?0' failed: Invalid UTF-8 sequence in header value So I tested Tomcat's demo apps: http://localhost:8080/examples/websocket/echo.xhtml And I see the same error. Joakin from Jetty team recently informed me that there is a breaking change in Chrome's behavior in ver. 32: https://issues.apache.org/jira/browse/WICKET-5453?focusedCommentId=13853464page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13853464 I run Ubuntu 13.10 and my Chrome version is 32.0.1700.77 Martin Grigorov Wicket Training and Consulting On Tue, Jan 28, 2014 at 9:28 PM, Mark Thomas ma...@apache.org wrote: The proposed Apache Tomcat 8.0.0 release is now available for voting. This is the first non-RC release so I am leaving all the stability options open to get an idea of where folks think we currently stand. The main changes since RC10 are: - Fix broken sendfile support in NIO - Add a readOnly option for WebResourceSet - Fix the regression in handling ternary expressions - Separate out JARs for EL, JSP and WebSocket for embedded - Remove svn keywords from source - Numerous bug fixes and improvements It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1002/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0/ The proposed 8.0.0 release is: [ ] Broken - do not release [ ] Alpha - go ahead and release as 8.0.0 (alpha) [ ] Beta - go ahead and release as 8.0.0 (beta) [ ] Stable - go ahead and release as 8.0.0 (stable) Cheers, Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.0
2014-01-28 Mark Thomas ma...@apache.org The proposed Apache Tomcat 8.0.0 release is now available for voting. This is the first non-RC release so I am leaving all the stability options open to get an idea of where folks think we currently stand. The main changes since RC10 are: - Fix broken sendfile support in NIO - Add a readOnly option for WebResourceSet - Fix the regression in handling ternary expressions - Separate out JARs for EL, JSP and WebSocket for embedded - Remove svn keywords from source - Numerous bug fixes and improvements It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1002/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0/ The proposed 8.0.0 release is: [ ] Broken - do not release [ ] Alpha - go ahead and release as 8.0.0 (alpha) [X] Beta - go ahead and release as 8.0.0 (beta) [ ] Stable - go ahead and release as 8.0.0 (stable) Rémy
svn commit: r1562411 - in /tomcat/trunk: build.properties.default java/org/apache/tomcat/websocket/server/UpgradeUtil.java webapps/docs/changelog.xml
Author: markt
Date: Wed Jan 29 11:23:42 2014
New Revision: 1562411
URL: http://svn.apache.org/r1562411
Log:
Fix bug handling the Sec-WebSocket-Protocol header returned to the client
Modified:
tomcat/trunk/build.properties.default
tomcat/trunk/java/org/apache/tomcat/websocket/server/UpgradeUtil.java
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/build.properties.default
URL:
http://svn.apache.org/viewvc/tomcat/trunk/build.properties.default?rev=1562411r1=1562410r2=1562411view=diff
==
--- tomcat/trunk/build.properties.default (original)
+++ tomcat/trunk/build.properties.default Wed Jan 29 11:23:42 2014
@@ -176,7 +176,7 @@ nsis.loc=${base-sf.loc}/nsis/nsis-2.46.z
# - Commons Daemon, version 1.0-Alpha or later -
commons-daemon.version=1.0.15
-commons-daemon.home=${base.path}/commons-daemon-${commons-daemon.version}
+commons-daemon.home=${base.path}/commons-daemon-${commons-daemon.version}-test-signed
commons-daemon.jar=${commons-daemon.home}/commons-daemon-${commons-daemon.version}.jar
commons-daemon.native.win.home=${commons-daemon.home}/windows
commons-daemon.native.win.mgr.exe=${commons-daemon.native.win.home}/prunmgr.exe
Modified: tomcat/trunk/java/org/apache/tomcat/websocket/server/UpgradeUtil.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/websocket/server/UpgradeUtil.java?rev=1562411r1=1562410r2=1562411view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/websocket/server/UpgradeUtil.java
(original)
+++ tomcat/trunk/java/org/apache/tomcat/websocket/server/UpgradeUtil.java Wed
Jan 29 11:23:42 2014
@@ -128,7 +128,8 @@ public class UpgradeUtil {
Constants.CONNECTION_HEADER_VALUE);
resp.setHeader(HandshakeResponse.SEC_WEBSOCKET_ACCEPT,
getWebSocketAccept(key));
-if (subProtocol != null) {
+if (subProtocol != null subProtocol.length() 0) {
+// RFC6455 4.2.2 explicitly states is not valid here
resp.setHeader(Sec-WebSocket-Protocol, subProtocol);
}
if (!extensions.isEmpty()) {
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1562411r1=1562410r2=1562411view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Wed Jan 29 11:23:42 2014
@@ -31,8 +31,8 @@
body
!--
Subsection ordering:
- General, Catalina, Coyote, Jasper, Cluster, Web applications, Extras, Tribes,
- Other
+ General, Catalina, Coyote, Jasper, Cluster, WebSocket, Web applications,
+ Extras, Tribes, Other
Item Ordering:
@@ -43,11 +43,19 @@
Other fixed issues are added to the end of the list, chronologically.
They eventually become mixed with the numbered issues. (I.e., numbered
issues to not pop up wrt. others).
-
- Until the first Tomcat 8.0.0 release, only changes not back-ported to 7.0.x
- should be listed here.
--
-section name=Tomcat 8.0.0
+section name=Tomcat 8.0.1 (markt)
+ changelog
+subsection name=WebSocket
+ Do not return an empty string for the codeSec-WebSocket-Protocol/code
+ HTTP header when no sub-protocol has been requested or no sub-protocol
+ could be agreed as RFC6455 requires that no
+ codeSec-WebSocket-Protocol/code header is returned in this case.
+ (markt)
+/subsection
+ /changelog
+/section
+section name=Tomcat 8.0.0 (markt)
subsection name=Catalina
changelog
add
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1562413 - /tomcat/trunk/webapps/docs/changelog.xml
Author: markt Date: Wed Jan 29 11:26:48 2014 New Revision: 1562413 URL: http://svn.apache.org/r1562413 Log: Correct tag nesting Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1562413r1=1562412r2=1562413view=diff == --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Wed Jan 29 11:26:48 2014 @@ -45,15 +45,15 @@ issues to not pop up wrt. others). -- section name=Tomcat 8.0.1 (markt) - changelog -subsection name=WebSocket + subsection name=WebSocket +changelog Do not return an empty string for the codeSec-WebSocket-Protocol/code HTTP header when no sub-protocol has been requested or no sub-protocol could be agreed as RFC6455 requires that no codeSec-WebSocket-Protocol/code header is returned in this case. (markt) -/subsection - /changelog +/changelog + /subsection /section section name=Tomcat 8.0.0 (markt) subsection name=Catalina - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1562414 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/websocket/server/UpgradeUtil.java webapps/docs/changelog.xml
Author: markt
Date: Wed Jan 29 11:28:35 2014
New Revision: 1562414
URL: http://svn.apache.org/r1562414
Log:
Fix bug handling the Sec-WebSocket-Protocol header returned to the client
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/websocket/server/UpgradeUtil.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
Propchange: tomcat/tc7.0.x/trunk/
--
Merged /tomcat/trunk:r1562411
Modified:
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/websocket/server/UpgradeUtil.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/tomcat/websocket/server/UpgradeUtil.java?rev=1562414r1=1562413r2=1562414view=diff
==
---
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/websocket/server/UpgradeUtil.java
(original)
+++
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/websocket/server/UpgradeUtil.java
Wed Jan 29 11:28:35 2014
@@ -130,7 +130,8 @@ public class UpgradeUtil {
Constants.CONNECTION_HEADER_VALUE);
resp.setHeader(HandshakeResponse.SEC_WEBSOCKET_ACCEPT,
getWebSocketAccept(key));
-if (subProtocol != null) {
+if (subProtocol != null subProtocol.length() 0) {
+// RFC6455 4.2.2 explicitly states is not valid here
resp.setHeader(Sec-WebSocket-Protocol, subProtocol);
}
if (!extensions.isEmpty()) {
Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1562414r1=1562413r2=1562414view=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Wed Jan 29 11:28:35 2014
@@ -42,8 +42,8 @@
body
!--
Subsection ordering:
- General, Catalina, Coyote, Jasper, Cluster, Web applications, Extras, Tribes,
- jdbc-pool, Other
+ General, Catalina, Coyote, Jasper, Cluster, WebSocket, Web applications,
+ Extras, Tribes, jdbc-pool, Other
Item Ordering:
@@ -191,6 +191,15 @@
/fix
/changelog
/subsection
+ subsection name=WebSocket
+changelog
+ Do not return an empty string for the codeSec-WebSocket-Protocol/code
+ HTTP header when no sub-protocol has been requested or no sub-protocol
+ could be agreed as RFC6455 requires that no
+ codeSec-WebSocket-Protocol/code header is returned in this case.
+ (markt)
+/changelog
+ /subsection
subsection name=Web applications
changelog
fix
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
buildbot exception in ASF Buildbot on tomcat-trunk
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/5451 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source Stamp: [branch tomcat/trunk] 1562413 Blamelist: markt BUILD FAILED: exception compile upload_2 sincerely, -The Buildbot
Re: buildbot exception in ASF Buildbot on tomcat-trunk
On 29/01/2014 11:32, build...@apache.org wrote: The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/5451 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source Stamp: [branch tomcat/trunk] 1562413 Blamelist: markt BUILD FAILED: exception compile upload_2 I've been working on DBCP again so I need to update the snapshot version to build with. I'll do that shortly. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.0
On 29/01/2014 10:11, Martin Grigorov wrote: Hi, Broken - do not release. It seems WebSocket support is broken for Google Chrome 32+. I tested Apache Wicket integration and it failed with: WebSocket connection to 'ws://localhost:8080/ws/wicket/websocket?pageId=0wicket-ajax-baseurl=behavior?0' failed: Invalid UTF-8 sequence in header value So I tested Tomcat's demo apps: http://localhost:8080/examples/websocket/echo.xhtml And I see the same error. Thanks for the report. Tomcat was incorrectly sending back a value of rather than not sending the header at all. I've fixed that for 7.0.x and 8.0.x. I'm currently leaning towards not cancelling the release solely because of this issue. I think there is value in making 8.0.0 available even if 8.0.1 follows fairly quickly. My main reasoning is that this issue exists in both 8.0.0-RC10 and 8.0.0 and overall, 8.0.0 is better quality than 8.0.0. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.0
On Wed, Jan 29, 2014 at 12:37 PM, Mark Thomas ma...@apache.org wrote: On 29/01/2014 10:11, Martin Grigorov wrote: Hi, Broken - do not release. It seems WebSocket support is broken for Google Chrome 32+. I tested Apache Wicket integration and it failed with: WebSocket connection to 'ws://localhost:8080/ws/wicket/websocket?pageId=0wicket-ajax-baseurl=behavior?0' failed: Invalid UTF-8 sequence in header value So I tested Tomcat's demo apps: http://localhost:8080/examples/websocket/echo.xhtml And I see the same error. Thanks for the report. Tomcat was incorrectly sending back a value of rather than not sending the header at all. I've fixed that for 7.0.x and 8.0.x. I'm currently leaning towards not cancelling the release solely because of this issue. I think there is value in making 8.0.0 available even if 8.0.1 follows fairly quickly. My main reasoning is that this issue exists in both 8.0.0-RC10 and 8.0.0 and overall, 8.0.0 is better quality than 8.0.0. I'm OK with this. I can use Firefox or older Chrome until the next release. Thanks! Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1562420 - /tomcat/trunk/build.properties.default
Author: markt
Date: Wed Jan 29 11:43:20 2014
New Revision: 1562420
URL: http://svn.apache.org/r1562420
Log:
Update snapshot version
Modified:
tomcat/trunk/build.properties.default
Modified: tomcat/trunk/build.properties.default
URL:
http://svn.apache.org/viewvc/tomcat/trunk/build.properties.default?rev=1562420r1=1562419r2=1562420view=diff
==
--- tomcat/trunk/build.properties.default (original)
+++ tomcat/trunk/build.properties.default Wed Jan 29 11:43:20 2014
@@ -153,7 +153,7 @@ tomcat-native.win.2=${base-tomcat.loc.2}
#commons-dbcp.home=${base.path}/commons-dbcp-${commons-dbcp.version}-src
#commons-dbcp-src.loc.1=${base-commons.loc.1}/dbcp/source/commons-dbcp-${commons-dbcp.version}-src.tar.gz
#commons-dbcp-src.loc.2=${base-commons.loc.2}/dbcp/source/commons-dbcp-${commons-dbcp.version}-src.tar.gz
-commons-dbcp.version=2.0-20140113.123544-144
+commons-dbcp.version=2.0-20140129.093629-146
commons-dbcp.home=${base.path}/commons-dbcp2-2.0-SNAPSHOT-src
commons-dbcp-src.loc.1=https://repository.apache.org/content/repositories/snapshots/org/apache/commons/commons-dbcp2/2.0-SNAPSHOT/commons-dbcp2-${commons-dbcp.version}-src.tar.gz
commons-dbcp-src.loc.2=https://repository.apache.org/content/repositories/snapshots/org/apache/commons/commons-dbcp2/2.0-SNAPSHOT/commons-dbcp2-${commons-dbcp.version}-src.tar.gz
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Request parameters in HandshakeRequest
Hi, Apologies in advance if this is for users@. Should javax.websocket.server.HandshakeRequest#getParameterMap() contain the parameters from the query string ? There is javax.websocket.server.HandshakeRequest#getQueryString() but I don't see how WebSocket request can be done with POST method so I this the parameter map should contain the parsed query string, no ? In the voted 8.0.0 release the map is empty when there is non-empty query string. Thanks! Martin Grigorov Wicket Training and Consulting
buildbot failure in ASF Buildbot on tomcat-trunk
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/5452 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source Stamp: [branch tomcat/trunk] 1562420 Blamelist: markt BUILD FAILED: failed compile sincerely, -The Buildbot
svn commit: r1562421 - /tomcat/trunk/build.properties.default
Author: markt
Date: Wed Jan 29 11:51:45 2014
New Revision: 1562421
URL: http://svn.apache.org/r1562421
Log:
Revert accidental commit
Modified:
tomcat/trunk/build.properties.default
Modified: tomcat/trunk/build.properties.default
URL:
http://svn.apache.org/viewvc/tomcat/trunk/build.properties.default?rev=1562421r1=1562420r2=1562421view=diff
==
--- tomcat/trunk/build.properties.default (original)
+++ tomcat/trunk/build.properties.default Wed Jan 29 11:51:45 2014
@@ -176,7 +176,7 @@ nsis.loc=${base-sf.loc}/nsis/nsis-2.46.z
# - Commons Daemon, version 1.0-Alpha or later -
commons-daemon.version=1.0.15
-commons-daemon.home=${base.path}/commons-daemon-${commons-daemon.version}-test-signed
+commons-daemon.home=${base.path}/commons-daemon-${commons-daemon.version}
commons-daemon.jar=${commons-daemon.home}/commons-daemon-${commons-daemon.version}.jar
commons-daemon.native.win.home=${commons-daemon.home}/windows
commons-daemon.native.win.mgr.exe=${commons-daemon.native.win.home}/prunmgr.exe
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Request parameters in HandshakeRequest
On 29/01/2014 11:44, Martin Grigorov wrote: Hi, Apologies in advance if this is for users@. Should javax.websocket.server.HandshakeRequest#getParameterMap() contain the parameters from the query string ? It should. There is javax.websocket.server.HandshakeRequest#getQueryString() but I don't see how WebSocket request can be done with POST method so I this the parameter map should contain the parsed query string, no ? RFC6455 requires that only GET is used. In the voted 8.0.0 release the map is empty when there is non-empty query string. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Request parameters in HandshakeRequest
On Wed, Jan 29, 2014 at 1:06 PM, Mark Thomas ma...@apache.org wrote: On 29/01/2014 11:44, Martin Grigorov wrote: Hi, Apologies in advance if this is for users@. Should javax.websocket.server.HandshakeRequest#getParameterMap() contain the parameters from the query string ? It should. There is javax.websocket.server.HandshakeRequest#getQueryString() but I don't see how WebSocket request can be done with POST method so I this the parameter map should contain the parsed query string, no ? RFC6455 requires that only GET is used. In the voted 8.0.0 release the map is empty when there is non-empty query string. Mark False alarm. The problem was in my code. Found it while creating a demo app. Thanks! - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 6.0.39
On 28.1.2014 0:08, Mark Thomas wrote: The proposed Apache Tomcat 6.0.39 release candidate is now available for voting. ... The proposed 6.0.39 release is: [ ] Broken - do not release [X] Stable - go ahead and release as 6.0.39 Stable Tested .zip distribution on Windows 7 64-bit: - Tested SSL/TLS connectivity for BIO, NIO and APR connectors. - Crawled all links (except /manager, /host-manager and /examples/async*). No broken links found, except links to JavaDocs. - Smoke tests of BIO, NIO and APR, with and without TLS, all passed. -Ognjen - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56087] New: antiResourceLocking=false still locks ttf
https://issues.apache.org/bugzilla/show_bug.cgi?id=56087 Bug ID: 56087 Summary: antiResourceLocking=false still locks ttf Product: Tomcat 7 Version: 7.0.28 Hardware: PC Status: NEW Severity: normal Priority: P2 Component: Packaging Assignee: dev@tomcat.apache.org Reporter: p.ra...@gmx.net I cant delete a context because a TTF is still opend. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.0
I'm seeing consistent unit test failures in TestAsyncContextImpl when using APR: Testcase: testDispatchErrorWithThreadSingleThenComplete took 5.171 sec Testcase: testDispatchErrorSingleThenComplete took 2.226 sec Testcase: testTimeoutListenerCompleteNonAsyncDispatch took 2.257 sec FAILED Uri: /start, Status: 200, Time: 1005 duration needed = 2900 junit.framework.AssertionFailedError: Uri: /start, Status: 200, Time: 1005 duration needed = 2900 at org.apache.catalina.valves.TesterAccessLogValve.validateAccessLog(TesterAccessLogValve.java:85) at org.apache.catalina.core.TestAsyncContextImpl.doTestTimeout(TestAsyncContextImpl.java:523) at org.apache.catalina.core.TestAsyncContextImpl.testTimeoutListenerCompleteNonAsyncDispatch(TestAsyncContextImpl.java:401) The request is indeed logged as 127.0.0.1 - - 15:23:33.224 GET /start HTTP/1.1 200 96 http-apr-127.0.0.1-auto-3-exec-3 1005 (I have added some info to the access log) and the whole test output around that request looks pretty simple: 29-Jan-2014 15:23:31.220 INFO [main] org.apache.catalina.core.AprLifecycleListener.init Loaded APR based Apache Tomcat Native library 1.1.29 using APR version 1.5.0. 29-Jan-2014 15:23:31.221 INFO [main] org.apache.catalina.core.AprLifecycleListener.init APR capabilities: IPv6 [true], sendfile [true], accept filters [false], random [true]. 29-Jan-2014 15:23:32.175 INFO [main] org.apache.catalina.core.AprLifecycleListener.initializeSSL OpenSSL successfully initialized (OpenSSL 1.0.1f 6 Jan 2014) 29-Jan-2014 15:23:32.178 INFO [main] org.apache.coyote.AbstractProtocol.init Initializing ProtocolHandler [http-apr-127.0.0.1-auto-3] 29-Jan-2014 15:23:32.180 INFO [main] org.apache.catalina.core.StandardService.startInternal Starting service Tomcat 29-Jan-2014 15:23:32.180 INFO [main] org.apache.catalina.core.StandardEngine.startInternal Starting Servlet Engine: Apache Tomcat/8.0.X-rXX-dev 29-Jan-2014 15:23:32.210 INFO [main] org.apache.coyote.AbstractProtocol.start Starting ProtocolHandler [http-apr-127.0.0.1-auto-3-51922] 29-Jan-2014 15:23:33.326 INFO [main] org.apache.coyote.AbstractProtocol.pause Pausing ProtocolHandler [http-apr-127.0.0.1-auto-3-51922] 29-Jan-2014 15:23:33.377 INFO [main] org.apache.catalina.core.StandardService.stopInternal Stopping service Tomcat 29-Jan-2014 15:23:33.392 INFO [main] org.apache.coyote.AbstractProtocol.stop Stopping ProtocolHandler [http-apr-127.0.0.1-auto-3-51922] 29-Jan-2014 15:23:33.459 INFO [main] org.apache.coyote.AbstractProtocol.destroy Destroying ProtocolHandler [http-apr-127.0.0.1-auto-3-51922] so only startup and - after 1 second - shutdown messages. After that failure, more show up, I have just looked at this first one. Testcase: testTimeoutListenerNoCompleteAsyncDispatch took 5.049 sec FAILED Uri: /start, Status: 200, Time: 4006 duration needed = 5900 junit.framework.AssertionFailedError: Uri: /start, Status: 200, Time: 4006 duration needed = 5900 at org.apache.catalina.valves.TesterAccessLogValve.validateAccessLog(TesterAccessLogValve.java:85) at org.apache.catalina.core.TestAsyncContextImpl.doTestTimeout(TestAsyncContextImpl.java:523) at org.apache.catalina.core.TestAsyncContextImpl.testTimeoutListenerNoCompleteAsyncDispatch(TestAsyncContextImpl.java:420) Testcase: testDispatchErrorWithThreadMultiple took 1.453 sec Testcase: testDispatchErrorMultiple took 1.123 sec Testcase: testDispatchMultiple took 2.239 sec Testcase: testBug49528 took 2.47 sec FAILED expected:OK but was:null junit.framework.AssertionFailedError: expected:OK but was:null at org.apache.catalina.core.TestAsyncContextImpl.testBug49528(TestAsyncContextImpl.java:93) Testcase: testBug49567 took 1.665 sec FAILED expected:OK but was:null junit.framework.AssertionFailedError: expected:OK but was:null at org.apache.catalina.core.TestAsyncContextImpl.testBug49567(TestAsyncContextImpl.java:131) Testcase: testBug50352 took 1.822 sec FAILED expected:[Runnable]-onComplete- but was:[onTimeout]-onComplete- junit.framework.AssertionFailedError: expected:[Runnable]-onComplete- but was:[onTimeout]-onComplete- at org.apache.catalina.core.TestAsyncContextImpl.testBug50352(TestAsyncContextImpl.java:1032) and some more. Regards, Rainer - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56088] New: AbstractQueryReport$StatementProxy throws exception on Object methods if statement is closed
https://issues.apache.org/bugzilla/show_bug.cgi?id=56088 Bug ID: 56088 Summary: AbstractQueryReport$StatementProxy throws exception on Object methods if statement is closed Product: Tomcat Modules Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P2 Component: jdbc-pool Assignee: dev@tomcat.apache.org Reporter: igna...@bacamt.com If the StatemetProxy.hashcode is called after the delegated statement is closed the proxy throws an exception. This produces an incompatibility with the last version of hibernate. Hibernate issue at https://hibernate.atlassian.net/browse/HHH-8853. Although this problem appear in the last version of hibernate, looks like a silent bug in the statement proxy. For example, guava has an utility which hides solves this problem (https://code.google.com/p/guava-libraries/wiki/ReflectionExplained#AbstractInvocationHandler). -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1562458 - /tomcat/trunk/test/org/apache/catalina/valves/TesterAccessLogValve.java
Author: rjung
Date: Wed Jan 29 14:36:48 2014
New Revision: 1562458
URL: http://svn.apache.org/r1562458
Log:
More info if test fails in access log valve check.
Modified:
tomcat/trunk/test/org/apache/catalina/valves/TesterAccessLogValve.java
Modified: tomcat/trunk/test/org/apache/catalina/valves/TesterAccessLogValve.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/valves/TesterAccessLogValve.java?rev=1562458r1=1562457r2=1562458view=diff
==
--- tomcat/trunk/test/org/apache/catalina/valves/TesterAccessLogValve.java
(original)
+++ tomcat/trunk/test/org/apache/catalina/valves/TesterAccessLogValve.java Wed
Jan 29 14:36:48 2014
@@ -82,9 +82,9 @@ public class TesterAccessLogValve extend
for (int j = 0; j count; j++) {
Entry entry = entries.get(j);
assertEquals(status, entry.getStatus());
-assertTrue(entry.toString(),
+assertTrue(entry.toString() + duration is not = + (minTime -
ERROR_MARGIN),
entry.getTime() = minTime - ERROR_MARGIN);
-assertTrue(entry.toString(),
+assertTrue(entry.toString() + duration is not + (maxTime -
ERROR_MARGIN),
entry.getTime() maxTime + ERROR_MARGIN);
}
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.0
I can confirm that the issue with the empty Sec-WebSocket-Protocol header also affects Chrome 31.0.1650.63. The actual issue appears as an Invalid UTF-8 sequence in header value message in the Chrome dev tool. Although I had read what Martin reported for Chrome 32, I couldn't confirm it's the same issue since I'm on Chrome 31 and the dev tools don't even show the response headers and Firefox for some reason doesn't show the empty header. I had to use Wireshark to confirm it's the same issue. A (non-binding) vote not to release this way. This a pretty bad first-time user experience for anyone who tries 8.0. Rossen
Re: [VOTE] Release Apache Tomcat 8.0.0
On Wed, Jan 29, 2014 at 9:55 AM, Rossen Stoyanchev rstoyanc...@gopivotal.com wrote: I can confirm that the issue with the empty Sec-WebSocket-Protocol header also affects Chrome 31.0.1650.63. I haven't tested 8.0.0 myself yet, but if it's broken on Chrome 31, that's a far bigger problem than Chrome 32: http://www.netmarketshare.com/browser-market-share.aspx?qprid=2qpcustomd=0. Yoav The actual issue appears as an Invalid UTF-8 sequence in header value message in the Chrome dev tool. Although I had read what Martin reported for Chrome 32, I couldn't confirm it's the same issue since I'm on Chrome 31 and the dev tools don't even show the response headers and Firefox for some reason doesn't show the empty header. I had to use Wireshark to confirm it's the same issue. A (non-binding) vote not to release this way. This a pretty bad first-time user experience for anyone who tries 8.0. Rossen - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56087] antiResourceLocking=false still locks ttf
https://issues.apache.org/bugzilla/show_bug.cgi?id=56087 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID OS||All --- Comment #1 from Mark Thomas ma...@apache.org --- There is insufficient information in this bug report for a developer to reproduce this. Please use the Apache Tomcat user's mailing list to debug this issue and if that concludes that there is a bug then please re-open this issue and add the exact steps to reproduce the issue on a clean install of the latest stable 7.0.x release. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.0
I've reproduced this issue with Chrome 32.0.1700.102 and Chrome canary 34.0.1811.0. Chrome 32 is already mainstream anyway (thanks evergreen browsers): http://clicky.com/marketshare/global/web-browsers/google-chrome/ -- Brian Clozel On Wed, Jan 29, 2014 at 4:38 PM, Yoav Shapira yo...@apache.org wrote: On Wed, Jan 29, 2014 at 9:55 AM, Rossen Stoyanchev rstoyanc...@gopivotal.com wrote: I can confirm that the issue with the empty Sec-WebSocket-Protocol header also affects Chrome 31.0.1650.63. I haven't tested 8.0.0 myself yet, but if it's broken on Chrome 31, that's a far bigger problem than Chrome 32: http://www.netmarketshare.com/browser-market-share.aspx?qprid=2qpcustomd=0 . Yoav The actual issue appears as an Invalid UTF-8 sequence in header value message in the Chrome dev tool. Although I had read what Martin reported for Chrome 32, I couldn't confirm it's the same issue since I'm on Chrome 31 and the dev tools don't even show the response headers and Firefox for some reason doesn't show the empty header. I had to use Wireshark to confirm it's the same issue. A (non-binding) vote not to release this way. This a pretty bad first-time user experience for anyone who tries 8.0. Rossen - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
buildbot success in ASF Buildbot on tomcat-trunk
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/5454 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source Stamp: [branch tomcat/trunk] 1562458 Blamelist: rjung Build succeeded! sincerely, -The Buildbot
svn commit: r1562581 - in /tomcat/trunk: java/org/apache/tomcat/util/net/SocketWrapper.java webapps/docs/changelog.xml
Author: markt
Date: Wed Jan 29 20:37:31 2014
New Revision: 1562581
URL: http://svn.apache.org/r1562581
Log:
Fix regression in fix for BZ55996
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapper.java
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapper.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapper.java?rev=1562581r1=1562580r2=1562581view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapper.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/SocketWrapper.java Wed Jan 29
20:37:31 2014
@@ -27,7 +27,7 @@ public class SocketWrapperE {
private volatile E socket;
-private volatile long lastAccess = -1;
+private volatile long lastAccess = System.currentTimeMillis();
private long timeout = -1;
private boolean error = false;
private volatile int keepAliveLeft = 100;
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1562581r1=1562580r2=1562581view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Wed Jan 29 20:37:31 2014
@@ -45,13 +45,23 @@
issues to not pop up wrt. others).
--
section name=Tomcat 8.0.1 (markt)
+ subsection name=Coyote
+changelog
+ fix
+Correct regression in the fix for bug55996/bug that meant that
+asynchronous requests might timeout too early. (markt)
+ /fix
+/changelog
+ /subsection
subsection name=WebSocket
changelog
- Do not return an empty string for the codeSec-WebSocket-Protocol/code
- HTTP header when no sub-protocol has been requested or no sub-protocol
- could be agreed as RFC6455 requires that no
- codeSec-WebSocket-Protocol/code header is returned in this case.
- (markt)
+ fix
+Do not return an empty string for the
+codeSec-WebSocket-Protocol/code HTTP header when no sub-protocol
has
+been requested or no sub-protocol could be agreed as RFC6455 requires
+that no codeSec-WebSocket-Protocol/code header is returned in this
+case. (markt)
+ /fix
/changelog
/subsection
/section
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.0
On 29/01/2014 14:32, Rainer Jung wrote: I'm seeing consistent unit test failures in TestAsyncContextImpl when using APR: I can reproduce these and have hopefully found a fix. This is a serious enough regression (async timeouts are broken in some cases) to justify dropping 8.0.0 and tagging 8.0.1. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[VOTE][CANCELLED] Release Apache Tomcat 8.0.0
Testing has discovered a regression in the asynchronous timeouts. A 8.0.1 tag will follow once I've finished running the unit tests locally to check for further regressions. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1562584 - /tomcat/trunk/webapps/docs/changelog.xml
Author: markt Date: Wed Jan 29 20:40:52 2014 New Revision: 1562584 URL: http://svn.apache.org/r1562584 Log: 8.0.0 will not be released Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1562584r1=1562583r2=1562584view=diff == --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Wed Jan 29 20:40:52 2014 @@ -65,7 +65,7 @@ /changelog /subsection /section -section name=Tomcat 8.0.0 (markt) +section name=Tomcat 8.0.0 (markt) rtext=not released subsection name=Catalina changelog add - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1562585 - in /tomcat/trunk: build.properties.default res/maven/mvn.properties.default
Author: markt Date: Wed Jan 29 20:41:54 2014 New Revision: 1562585 URL: http://svn.apache.org/r1562585 Log: Prep for next release Modified: tomcat/trunk/build.properties.default tomcat/trunk/res/maven/mvn.properties.default Modified: tomcat/trunk/build.properties.default URL: http://svn.apache.org/viewvc/tomcat/trunk/build.properties.default?rev=1562585r1=1562584r2=1562585view=diff == --- tomcat/trunk/build.properties.default (original) +++ tomcat/trunk/build.properties.default Wed Jan 29 20:41:54 2014 @@ -25,7 +25,7 @@ # - Version Control Flags - version.major=8 version.minor=0 -version.build=0 +version.build=1 version.patch=0 version.suffix=-dev Modified: tomcat/trunk/res/maven/mvn.properties.default URL: http://svn.apache.org/viewvc/tomcat/trunk/res/maven/mvn.properties.default?rev=1562585r1=1562584r2=1562585view=diff == --- tomcat/trunk/res/maven/mvn.properties.default (original) +++ tomcat/trunk/res/maven/mvn.properties.default Wed Jan 29 20:41:54 2014 @@ -35,7 +35,7 @@ maven.asf.release.repo.url=https://repos maven.asf.release.repo.repositoryId=apache.releases # Release version info -maven.asf.release.deploy.version=8.0.0 +maven.asf.release.deploy.version=8.0.1 #Where do we load the libraries from tomcat.lib.path=../../output/build/lib - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.0
2014-01-29 Mark Thomas ma...@apache.org: The proposed Apache Tomcat 8.0.0 release is now available for voting. (...) It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1002/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0/ By the way, 1. I think Tomcat 8 tags should go into /tomcat/tc8.0.x/tags/ instead of tomcat/tags. It is better to move them there earlier. 2. The exe installer has not been signed. Did you intent to sign it after testing, or that just did not happen? Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.0
On 29/01/2014 21:03, Konstantin Kolinko wrote: 2014-01-29 Mark Thomas ma...@apache.org: The proposed Apache Tomcat 8.0.0 release is now available for voting. (...) It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.0/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1002/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_8_0_0/ By the way, 1. I think Tomcat 8 tags should go into /tomcat/tc8.0.x/tags/ instead of tomcat/tags. It is better to move them there earlier. 2. The exe installer has not been signed. Did you intent to sign it after testing, or that just did not happen? Hmm. That should have happened automatically. I'll check the results when I build 8.0.1. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1562596 - /tomcat/trunk/test/org/apache/catalina/authenticator/TestSSOnonLoginAndBasicAuthenticator.java
Author: markt
Date: Wed Jan 29 21:17:35 2014
New Revision: 1562596
URL: http://svn.apache.org/r1562596
Log:
Saw a failure on Windows.
Switch to our standard pattern for waiting that allows the possibility of a
long wait but will finish sooner if it can rather than using a fixed wait.
Modified:
tomcat/trunk/test/org/apache/catalina/authenticator/TestSSOnonLoginAndBasicAuthenticator.java
Modified:
tomcat/trunk/test/org/apache/catalina/authenticator/TestSSOnonLoginAndBasicAuthenticator.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/authenticator/TestSSOnonLoginAndBasicAuthenticator.java?rev=1562596r1=1562595r2=1562596view=diff
==
---
tomcat/trunk/test/org/apache/catalina/authenticator/TestSSOnonLoginAndBasicAuthenticator.java
(original)
+++
tomcat/trunk/test/org/apache/catalina/authenticator/TestSSOnonLoginAndBasicAuthenticator.java
Wed Jan 29 21:17:35 2014
@@ -99,9 +99,8 @@ public class TestSSOnonLoginAndBasicAuth
// now compute some delays - beware of the units!
private static final int EXTRA_DELAY_SECS = 5;
-private static final long REASONABLE_MSECS_TO_EXPIRY =
-(((MANAGER_SCAN_INTERVAL_SECS * MANAGER_EXPIRE_SESSIONS_FAST)
-+ EXTRA_DELAY_SECS) * 1000);
+private static final int TIMEOUT_WAIT_SECS = EXTRA_DELAY_SECS +
+(MANAGER_SCAN_INTERVAL_SECS * MANAGER_EXPIRE_SESSIONS_FAST) * 5;
private static final String CLIENT_AUTH_HEADER = authorization;
private static final String SERVER_AUTH_HEADER = WWW-Authenticate;
@@ -167,7 +166,7 @@ public class TestSSOnonLoginAndBasicAuth
* Wait until the SSO session times-out, then try to re-access
* the resource. This should be rejected with SC_FORBIDDEN 401 status.
*
- * Note: this test will run for slightly more than 1 minute.
+ * Note: this test should run for ~10 seconds.
*/
@Test
public void testBasicAccessAndSessionTimeout() throws Exception {
@@ -310,7 +309,7 @@ public class TestSSOnonLoginAndBasicAuth
*
* (see bugfix https://issues.apache.org/bugzilla/show_bug.cgi?id=52303)
*
- * Note: this test will run for slightly more than 3 minutes.
+ * Note: this test should run for ~20 seconds.
*/
@Test
public void testBasicExpiredAcceptProtectedWithCookies() throws Exception {
@@ -601,13 +600,27 @@ public class TestSSOnonLoginAndBasicAuth
// leave it to be expired by the manager
}
}
+
+
try {
-Thread.sleep(REASONABLE_MSECS_TO_EXPIRY);
+Thread.sleep(EXTRA_DELAY_SECS * 1000);
} catch (InterruptedException ie) {
// ignored
}
-// paranoid verification that active sessions have now gone
+// Paranoid verification that active sessions have now gone
+int count = 0;
+sessions = manager.findSessions();
+while (sessions.length != 0 count TIMEOUT_WAIT_SECS) {
+try {
+Thread.sleep(1000);
+} catch (InterruptedException e) {
+// Ignore
+}
+sessions = manager.findSessions();
+count++;
+}
+
sessions = manager.findSessions();
assertTrue(sessions.length == 0);
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1562597 - in /tomcat/trunk: java/org/apache/catalina/core/ java/org/apache/jasper/ java/org/apache/jasper/compiler/ java/org/apache/jasper/servlet/ webapps/docs/ webapps/docs/config/
Author: kkolinko
Date: Wed Jan 29 21:19:57 2014
New Revision: 1562597
URL: http://svn.apache.org/r1562597
Log:
Make the xmlBlockExternal option in Catalina and Jasper to be true by default.
Modified:
tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
tomcat/trunk/java/org/apache/jasper/JspC.java
tomcat/trunk/java/org/apache/jasper/compiler/ImplicitTagLibraryInfo.java
tomcat/trunk/java/org/apache/jasper/compiler/JspDocumentParser.java
tomcat/trunk/java/org/apache/jasper/compiler/TagPluginManager.java
tomcat/trunk/java/org/apache/jasper/compiler/TldCache.java
tomcat/trunk/java/org/apache/jasper/servlet/JasperInitializer.java
tomcat/trunk/java/org/apache/jasper/servlet/JspCServletContext.java
tomcat/trunk/webapps/docs/changelog.xml
tomcat/trunk/webapps/docs/config/context.xml
tomcat/trunk/webapps/docs/security-howto.xml
Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/StandardContext.java?rev=1562597r1=1562596r2=1562597view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/StandardContext.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/StandardContext.java Wed Jan 29
21:19:57 2014
@@ -675,7 +675,7 @@ public class StandardContext extends Con
/**
* Attribute used to turn on/off the use of external entities.
*/
-private boolean xmlBlockExternal = Globals.IS_SECURITY_ENABLED;
+private boolean xmlBlockExternal = true;
/**
Modified: tomcat/trunk/java/org/apache/jasper/JspC.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/JspC.java?rev=1562597r1=1562596r2=1562597view=diff
==
--- tomcat/trunk/java/org/apache/jasper/JspC.java (original)
+++ tomcat/trunk/java/org/apache/jasper/JspC.java Wed Jan 29 21:19:57 2014
@@ -135,6 +135,7 @@ public class JspC extends Task implement
protected static final String SWITCH_DUMP_SMAP = -dumpsmap;
protected static final String SWITCH_VALIDATE_TLD = -validateTld;
protected static final String SWITCH_BLOCK_EXTERNAL = -blockExternal;
+protected static final String SWITCH_NO_BLOCK_EXTERNAL =
-no-blockExternal;
protected static final String SHOW_SUCCESS =-s;
protected static final String LIST_ERRORS = -l;
protected static final int INC_WEBXML = 10;
@@ -166,7 +167,7 @@ public class JspC extends Task implement
protected boolean trimSpaces = false;
protected boolean genStringAsCharArray = false;
protected boolean validateTld;
-protected boolean blockExternal;
+protected boolean blockExternal = true;
protected boolean xpoweredBy;
protected boolean mappedFile = false;
protected boolean poolingEnabled = true;
@@ -377,6 +378,8 @@ public class JspC extends Task implement
setValidateTld(true);
} else if (tok.equals(SWITCH_BLOCK_EXTERNAL)) {
setBlockExternal(true);
+} else if (tok.equals(SWITCH_NO_BLOCK_EXTERNAL)) {
+setBlockExternal(false);
} else {
if (tok.startsWith(-)) {
throw new JasperException(Unrecognized option: + tok +
@@ -1452,9 +1455,8 @@ public class JspC extends Task implement
if (isValidateTld()) {
context.setInitParameter(Constants.XML_VALIDATION_TLD_INIT_PARAM,
true);
}
-if (isBlockExternal()) {
-context.setInitParameter(Constants.XML_BLOCK_EXTERNAL_INIT_PARAM,
true);
-}
+context.setInitParameter(Constants.XML_BLOCK_EXTERNAL_INIT_PARAM,
+String.valueOf(isBlockExternal()));
TldScanner scanner = new TldScanner(
context, true, isValidateTld(), isBlockExternal());
Modified:
tomcat/trunk/java/org/apache/jasper/compiler/ImplicitTagLibraryInfo.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/compiler/ImplicitTagLibraryInfo.java?rev=1562597r1=1562596r2=1562597view=diff
==
--- tomcat/trunk/java/org/apache/jasper/compiler/ImplicitTagLibraryInfo.java
(original)
+++ tomcat/trunk/java/org/apache/jasper/compiler/ImplicitTagLibraryInfo.java
Wed Jan 29 21:19:57 2014
@@ -128,7 +128,7 @@ class ImplicitTagLibraryInfo extends Tag
Constants.XML_BLOCK_EXTERNAL_INIT_PARAM);
boolean blockExternal;
if (blockExternalString == null) {
-blockExternal = Constants.IS_SECURITY_ENABLED;
+blockExternal = true;
} else {
blockExternal =
Boolean.parseBoolean(blockExternalString);
}
Modified:
svn commit: r1562627 - in /tomcat/tc8.0.x: ./ tags/
Author: markt Date: Wed Jan 29 23:06:33 2014 New Revision: 1562627 URL: http://svn.apache.org/r1562627 Log: Prep location for 8.0.x tags Added: tomcat/tc8.0.x/ tomcat/tc8.0.x/tags/ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1562629 - in /tomcat: tags/TOMCAT_8_0_0/ tags/TOMCAT_8_0_0_RC1/ tags/TOMCAT_8_0_0_RC10/ tags/TOMCAT_8_0_0_RC2/ tags/TOMCAT_8_0_0_RC3/ tags/TOMCAT_8_0_0_RC4/ tags/TOMCAT_8_0_0_RC5/ tags/TO
Author: markt Date: Wed Jan 29 23:10:09 2014 New Revision: 1562629 URL: http://svn.apache.org/r1562629 Log: Move 8.0.x tags to long term location Added: tomcat/tc8.0.x/tags/TOMCAT_8_0_0/ - copied from r1562627, tomcat/tags/TOMCAT_8_0_0/ tomcat/tc8.0.x/tags/TOMCAT_8_0_0_RC1/ - copied from r1562627, tomcat/tags/TOMCAT_8_0_0_RC1/ tomcat/tc8.0.x/tags/TOMCAT_8_0_0_RC10/ - copied from r1562627, tomcat/tags/TOMCAT_8_0_0_RC10/ tomcat/tc8.0.x/tags/TOMCAT_8_0_0_RC2/ - copied from r1562627, tomcat/tags/TOMCAT_8_0_0_RC2/ tomcat/tc8.0.x/tags/TOMCAT_8_0_0_RC3/ - copied from r1562627, tomcat/tags/TOMCAT_8_0_0_RC3/ tomcat/tc8.0.x/tags/TOMCAT_8_0_0_RC4/ - copied from r1562627, tomcat/tags/TOMCAT_8_0_0_RC4/ tomcat/tc8.0.x/tags/TOMCAT_8_0_0_RC5/ - copied from r1562627, tomcat/tags/TOMCAT_8_0_0_RC5/ tomcat/tc8.0.x/tags/TOMCAT_8_0_0_RC6/ - copied from r1562627, tomcat/tags/TOMCAT_8_0_0_RC6/ tomcat/tc8.0.x/tags/TOMCAT_8_0_0_RC7/ - copied from r1562627, tomcat/tags/TOMCAT_8_0_0_RC7/ tomcat/tc8.0.x/tags/TOMCAT_8_0_0_RC8/ - copied from r1562627, tomcat/tags/TOMCAT_8_0_0_RC8/ tomcat/tc8.0.x/tags/TOMCAT_8_0_0_RC9/ - copied from r1562627, tomcat/tags/TOMCAT_8_0_0_RC9/ Removed: tomcat/tags/TOMCAT_8_0_0/ tomcat/tags/TOMCAT_8_0_0_RC1/ tomcat/tags/TOMCAT_8_0_0_RC10/ tomcat/tags/TOMCAT_8_0_0_RC2/ tomcat/tags/TOMCAT_8_0_0_RC3/ tomcat/tags/TOMCAT_8_0_0_RC4/ tomcat/tags/TOMCAT_8_0_0_RC5/ tomcat/tags/TOMCAT_8_0_0_RC6/ tomcat/tags/TOMCAT_8_0_0_RC7/ tomcat/tags/TOMCAT_8_0_0_RC8/ tomcat/tags/TOMCAT_8_0_0_RC9/ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1562630 - in /tomcat/tc8.0.x/tags/TOMCAT_8_0_1: ./ build.properties.default
Author: markt Date: Wed Jan 29 23:11:21 2014 New Revision: 1562630 URL: http://svn.apache.org/r1562630 Log: Tag 8.0.1 Added: tomcat/tc8.0.x/tags/TOMCAT_8_0_1/ - copied from r1562626, tomcat/trunk/ Modified: tomcat/tc8.0.x/tags/TOMCAT_8_0_1/build.properties.default Modified: tomcat/tc8.0.x/tags/TOMCAT_8_0_1/build.properties.default URL: http://svn.apache.org/viewvc/tomcat/tc8.0.x/tags/TOMCAT_8_0_1/build.properties.default?rev=1562630r1=1562626r2=1562630view=diff == --- tomcat/tc8.0.x/tags/TOMCAT_8_0_1/build.properties.default (original) +++ tomcat/tc8.0.x/tags/TOMCAT_8_0_1/build.properties.default Wed Jan 29 23:11:21 2014 @@ -27,7 +27,7 @@ version.major=8 version.minor=0 version.build=1 version.patch=0 -version.suffix=-dev +version.suffix= # - Build control flags - # Note enabling validation uses Checkstyle which is LGPL licensed - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1562633 - in /tomcat/trunk: build.properties.default res/maven/mvn.properties.default
Author: markt Date: Wed Jan 29 23:20:49 2014 New Revision: 1562633 URL: http://svn.apache.org/r1562633 Log: Prep for next release Modified: tomcat/trunk/build.properties.default tomcat/trunk/res/maven/mvn.properties.default Modified: tomcat/trunk/build.properties.default URL: http://svn.apache.org/viewvc/tomcat/trunk/build.properties.default?rev=1562633r1=1562632r2=1562633view=diff == --- tomcat/trunk/build.properties.default (original) +++ tomcat/trunk/build.properties.default Wed Jan 29 23:20:49 2014 @@ -25,7 +25,7 @@ # - Version Control Flags - version.major=8 version.minor=0 -version.build=1 +version.build=2 version.patch=0 version.suffix=-dev Modified: tomcat/trunk/res/maven/mvn.properties.default URL: http://svn.apache.org/viewvc/tomcat/trunk/res/maven/mvn.properties.default?rev=1562633r1=1562632r2=1562633view=diff == --- tomcat/trunk/res/maven/mvn.properties.default (original) +++ tomcat/trunk/res/maven/mvn.properties.default Wed Jan 29 23:20:49 2014 @@ -35,7 +35,7 @@ maven.asf.release.repo.url=https://repos maven.asf.release.repo.repositoryId=apache.releases # Release version info -maven.asf.release.deploy.version=8.0.1 +maven.asf.release.deploy.version=8.0.2 #Where do we load the libraries from tomcat.lib.path=../../output/build/lib - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[VOTE] Release Apache Tomcat 8.0.1
The proposed Apache Tomcat 8.0.1 release is now available for voting. This should be the first non-RC release so I am leaving all the stability options open to get an idea of where folks think we currently stand. The main changes since RC10 are: - Fix broken sendfile support in NIO - Add a readOnly option for WebResourceSet - Fix the regression in handling ternary expressions - Separate out JARs for EL, JSP and WebSocket for embedded - Remove svn keywords from source - Numerous bug fixes and improvements The fixes since 8.0.0 are: - Fix regression in async timeout - Fix WebSocket bug that broke WebSocket support with newer versions of Chrome It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.1/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1003/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_1/ The proposed 8.0.1 release is: [ ] Broken - do not release [ ] Alpha - go ahead and release as 8.0.1 (alpha) [ ] Beta - go ahead and release as 8.0.1 (beta) [ ] Stable - go ahead and release as 8.0.1 (stable) Cheers, Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
