Early Access builds for JDK 9 b28 and JDK 8u40 b04 are available on java.net
Hi Mladen/Mark, Early Access build for JDK 9 b28 https://jdk9.java.net/download/ is available on java.net, summary of changes are listed here http://www.java.net/download/jdk9/changes/jdk9-b28.html Early Access build for JDK 8u40 b04 http://jdk8.java.net/download.html is available on java.net, summary of changes are listed here. http://www.java.net/download/jdk8u40/changes/jdk8u40-b04.html Rgds,Rory -- Rgds,Rory O'Donnell Quality Engineering Manager Oracle EMEA , Dublin, Ireland
[Bug 48400] HTTP Post Request is set to recoverable on timeout waiting for response from tomcat
https://issues.apache.org/bugzilla/show_bug.cgi?id=48400 Philippe Mouawad p.moua...@ubik-ingenierie.com changed: What|Removed |Added CC||p.mouawad@ubik-ingenierie.c ||om --- Comment #2 from Philippe Mouawad p.moua...@ubik-ingenierie.com --- Hello Rainer, Can those better defaults be found somewhere ? I looked at svn branch 1.3 but only found ROADMAP. Regarding don't retry POST by default, Can this be configured by setting: recovery_options=27 Thanks -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1622312 - in /tomcat/trunk: java/org/apache/catalina/util/CharsetMapper.java java/org/apache/tomcat/util/descriptor/web/FragmentJarScannerCallback.java webapps/docs/changelog.xml
On 03/09/2014 19:22, violet...@apache.org wrote: Author: violetagg Date: Wed Sep 3 18:22:14 2014 New Revision: 1622312 URL: http://svn.apache.org/r1622312 Log: Fix some potential resource leaks when reading files and other resources. Reported by Coverity Scan. Modified: tomcat/trunk/java/org/apache/catalina/util/CharsetMapper.java tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/FragmentJarScannerCallback.java I'm guessing you haven't started a Tomcat instance built after this change was made. Lots of FNFE appear in the logs. snip/ Modified: tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/FragmentJarScannerCallback.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/FragmentJarScannerCallback.java?rev=1622312r1=1622311r2=1622312view=diff == --- tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/FragmentJarScannerCallback.java (original) +++ tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/FragmentJarScannerCallback.java Wed Sep 3 18:22:14 2014 @@ -111,15 +111,13 @@ public class FragmentJarScannerCallback @Override public void scan(File file, String webappPath, boolean isWebapp) throws IOException { -InputStream stream = null; WebXml fragment = new WebXml(); fragment.setWebappJar(isWebapp); fragment.setDelegate(delegate); -try { -File fragmentFile = new File(file, FRAGMENT_LOCATION); +File fragmentFile = new File(file, FRAGMENT_LOCATION); +try (InputStream stream = new FileInputStream(fragmentFile)) { if (fragmentFile.isFile()) { -stream = new FileInputStream(fragmentFile); InputSource source = new InputSource(fragmentFile.toURI().toURL().toString()); source.setByteStream(stream); Here is the problem. You moved the creation of the stream to before the isFile() test. Should be an easy fix. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1622702 - /tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/FragmentJarScannerCallback.java
Author: markt Date: Fri Sep 5 14:04:31 2014 New Revision: 1622702 URL: http://svn.apache.org/r1622702 Log: Follow-up to 1622312 Restore the original logic while still avoiding the resource leak Modified: tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/FragmentJarScannerCallback.java Modified: tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/FragmentJarScannerCallback.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/FragmentJarScannerCallback.java?rev=1622702r1=1622701r2=1622702view=diff == --- tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/FragmentJarScannerCallback.java (original) +++ tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/FragmentJarScannerCallback.java Fri Sep 5 14:04:31 2014 @@ -116,13 +116,15 @@ public class FragmentJarScannerCallback fragment.setDelegate(delegate); File fragmentFile = new File(file, FRAGMENT_LOCATION); -try (InputStream stream = new FileInputStream(fragmentFile)) { +try { if (fragmentFile.isFile()) { -InputSource source = -new InputSource(fragmentFile.toURI().toURL().toString()); -source.setByteStream(stream); -if (!webXmlParser.parseWebXml(source, fragment, true)) { -ok = false; +try (InputStream stream = new FileInputStream(fragmentFile)) { +InputSource source = +new InputSource(fragmentFile.toURI().toURL().toString()); +source.setByteStream(stream); +if (!webXmlParser.parseWebXml(source, fragment, true)) { +ok = false; +} } } else { // If there is no web.xml, normal folder no impact on - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1622713 - in /tomcat/trunk/java/org/apache/tomcat/util/net: AprEndpoint.java res/LocalStrings.properties
Author: markt Date: Fri Sep 5 14:48:47 2014 New Revision: 1622713 URL: http://svn.apache.org/r1622713 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56910 -1 is not a supported option for maxConnections with the APR connector so don't allow it. Also prevent updates while the connector is running which is also unsupported. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java tomcat/trunk/java/org/apache/tomcat/util/net/res/LocalStrings.properties Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java?rev=1622713r1=1622712r2=1622713view=diff == --- tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java (original) +++ tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java Fri Sep 5 14:48:47 2014 @@ -355,6 +355,28 @@ public class AprEndpoint extends Abstrac } +/** + * This endpoint does not support code-1/code for unlimited connections, + * nor does it support setting this attribute while the endpoint is running. + * + * {@inheritDoc} + */ +@Override +public void setMaxConnections(int maxConnections) { +if (maxConnections == -1) { +log.warn(sm.getString(endpoint.apr.maxConnections.unlimited, +Integer.valueOf(getMaxConnections(; +return; +} +if (running) { +log.warn(sm.getString(endpoint.apr.maxConnections.running, +Integer.valueOf(getMaxConnections(; +return; +} +super.setMaxConnections(maxConnections); +} + + // - Public Methods /** Modified: tomcat/trunk/java/org/apache/tomcat/util/net/res/LocalStrings.properties URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/res/LocalStrings.properties?rev=1622713r1=1622712r2=1622713view=diff == --- tomcat/trunk/java/org/apache/tomcat/util/net/res/LocalStrings.properties (original) +++ tomcat/trunk/java/org/apache/tomcat/util/net/res/LocalStrings.properties Fri Sep 5 14:48:47 2014 @@ -52,6 +52,8 @@ endpoint.setAttribute=Set [{0}] to [{1}] endpoint.timeout.err=Error processing socket timeout endpoint.apr.failSslContextMake=Unable to create SSLContext. Check that SSLEngine is enabled in the AprLifecycleListener, the AprLifecycleListener has initialised correctly and that a valid SSLProtocol has been specified endpoint.apr.invalidSslProtocol=An invalid value [{0}] was provided for the SSLProtocol attribute +endpoint.apr.maxConnections.running=The APR endpoint does not support the setting of maxConnections while it is running. The existing value of [{0}] will continue to be used. +endpoint.apr.maxConnections.unlimited=The APR endpoint does not support unlimited connections. The existing value of [{0}] will continue to be used. endpoint.apr.noSendfileWithSSL=Sendfile is not supported for the APR/native connector when SSL is enabled endpoint.apr.noSslCertFile=Connector attribute SSLCertificateFile must be defined when using SSL with APR endpoint.apr.pollAddInvalid=Invalid attempted to add a socket [{0}] to the poller - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1622312 - in /tomcat/trunk: java/org/apache/catalina/util/CharsetMapper.java java/org/apache/tomcat/util/descriptor/web/FragmentJarScannerCallback.java webapps/docs/changelog.xml
Hi Mark, 2014-09-05 16:57 GMT+03:00 Mark Thomas ma...@apache.org: On 03/09/2014 19:22, violet...@apache.org wrote: Author: violetagg Date: Wed Sep 3 18:22:14 2014 New Revision: 1622312 URL: http://svn.apache.org/r1622312 Log: Fix some potential resource leaks when reading files and other resources. Reported by Coverity Scan. Modified: tomcat/trunk/java/org/apache/catalina/util/CharsetMapper.java tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/FragmentJarScannerCallback.java I'm guessing you haven't started a Tomcat instance built after this change was made. Lots of FNFE appear in the logs. snip/ Modified: tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/FragmentJarScannerCallback.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/FragmentJarScannerCallback.java?rev=1622312r1=1622311r2=1622312view=diff == --- tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/FragmentJarScannerCallback.java (original) +++ tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/FragmentJarScannerCallback.java Wed Sep 3 18:22:14 2014 @@ -111,15 +111,13 @@ public class FragmentJarScannerCallback @Override public void scan(File file, String webappPath, boolean isWebapp) throws IOException { -InputStream stream = null; WebXml fragment = new WebXml(); fragment.setWebappJar(isWebapp); fragment.setDelegate(delegate); -try { -File fragmentFile = new File(file, FRAGMENT_LOCATION); +File fragmentFile = new File(file, FRAGMENT_LOCATION); +try (InputStream stream = new FileInputStream(fragmentFile)) { if (fragmentFile.isFile()) { -stream = new FileInputStream(fragmentFile); InputSource source = new InputSource(fragmentFile.toURI().toURL().toString()); source.setByteStream(stream); Here is the problem. You moved the creation of the stream to before the isFile() test. Should be an easy fix. Thanks for the fix that you provided. I was not available today :( Please accept my apologies. I'll be more care in the future with the easy fixes. Regards, Violeta Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1622714 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/net/AprEndpoint.java java/org/apache/tomcat/util/net/res/LocalStrings.properties webapps/docs/changelog.xml
Author: markt Date: Fri Sep 5 14:52:54 2014 New Revision: 1622714 URL: http://svn.apache.org/r1622714 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56910 -1 is not a supported option for maxConnections with the APR connector so don't allow it. Also prevent updates while the connector is running which is also unsupported. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/res/LocalStrings.properties tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Propchange: tomcat/tc7.0.x/trunk/ -- Merged /tomcat/trunk:r1622713 Modified: tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java?rev=1622714r1=1622713r2=1622714view=diff == --- tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java (original) +++ tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java Fri Sep 5 14:52:54 2014 @@ -355,6 +355,28 @@ public class AprEndpoint extends Abstrac } +/** + * This endpoint does not support code-1/code for unlimited connections, + * nor does it support setting this attribute while the endpoint is running. + * + * {@inheritDoc} + */ +@Override +public void setMaxConnections(int maxConnections) { +if (maxConnections == -1) { +log.warn(sm.getString(endpoint.apr.maxConnections.unlimited, +Integer.valueOf(getMaxConnections(; +return; +} +if (running) { +log.warn(sm.getString(endpoint.apr.maxConnections.running, +Integer.valueOf(getMaxConnections(; +return; +} +super.setMaxConnections(maxConnections); +} + + // - Public Methods /** Modified: tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/res/LocalStrings.properties URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/res/LocalStrings.properties?rev=1622714r1=1622713r2=1622714view=diff == --- tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/res/LocalStrings.properties (original) +++ tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/res/LocalStrings.properties Fri Sep 5 14:52:54 2014 @@ -50,6 +50,8 @@ endpoint.sendfile.addfail=Sendfile failu endpoint.timeout.err=Error processing socket timeout endpoint.apr.failSslContextMake=Unable to create SSLContext. Check that SSLEngine is enabled in the AprLifecycleListener, the AprLifecycleListener has initialised correctly and that a valid SSLProtocol has been specified endpoint.apr.invalidSslProtocol=An invalid value [{0}] was provided for the SSLProtocol attribute +endpoint.apr.maxConnections.running=The APR endpoint does not support the setting of maxConnections while it is running. The existing value of [{0}] will continue to be used. +endpoint.apr.maxConnections.unlimited=The APR endpoint does not support unlimited connections. The existing value of [{0}] will continue to be used. endpoint.apr.noSslCertFile=Connector attribute SSLCertificateFile must be defined when using SSL with APR endpoint.apr.pollAddInvalid=Invalid attempted to add a socket [{0}] to the poller endpoint.apr.pollError=Poller failed with error [{0}] : [{1}] Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1622714r1=1622713r2=1622714view=diff == --- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original) +++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Fri Sep 5 14:52:54 2014 @@ -153,6 +153,10 @@ bug56780/bug: Enable Tomcat to start when using SSL with an IBM JRE in strict SP800-131a mode. (markt) /fix + fix +bug56910/bug: Prevent the invalid value of code-1/code being +used for codemaxConnections/code with APR connectors. (markt) + /fix /changelog /subsection subsection name=Jasper - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1622715 - /tomcat/trunk/webapps/docs/changelog.xml
Author: markt Date: Fri Sep 5 14:53:45 2014 New Revision: 1622715 URL: http://svn.apache.org/r1622715 Log: Missed an entry Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1622715r1=1622714r2=1622715view=diff == --- tomcat/trunk/webapps/docs/changelog.xml (original) +++ tomcat/trunk/webapps/docs/changelog.xml Fri Sep 5 14:53:45 2014 @@ -108,6 +108,14 @@ /fix /changelog /subsection + subsection name=Coyote +changelog + fix +bug56910/bug: Prevent the invalid value of code-1/code being +used for codemaxConnections/code with APR connectors. (markt) + /fix +/changelog + /subsection subsection name=Jasper changelog fix - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56910] when maxConnections=-1 AprEndpoint init error
https://issues.apache.org/bugzilla/show_bug.cgi?id=56910 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Mark Thomas ma...@apache.org --- In the end I decided to ignore values of -1, log a warning and continue using the current value. Fixed in 8.0.x for 8.0.13 onwards and in 7.0.x for 7.0.56 onwards. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1622312 - in /tomcat/trunk: java/org/apache/catalina/util/CharsetMapper.java java/org/apache/tomcat/util/descriptor/web/FragmentJarScannerCallback.java webapps/docs/changelog.xml
On 05/09/2014 15:51, Violeta Georgieva wrote: Hi Mark, 2014-09-05 16:57 GMT+03:00 Mark Thomas ma...@apache.org: On 03/09/2014 19:22, violet...@apache.org wrote: Author: violetagg Date: Wed Sep 3 18:22:14 2014 New Revision: 1622312 URL: http://svn.apache.org/r1622312 Log: Fix some potential resource leaks when reading files and other resources. Reported by Coverity Scan. Modified: tomcat/trunk/java/org/apache/catalina/util/CharsetMapper.java tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/FragmentJarScannerCallback.java I'm guessing you haven't started a Tomcat instance built after this change was made. Lots of FNFE appear in the logs. snip/ Modified: tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/FragmentJarScannerCallback.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/FragmentJarScannerCallback.java?rev=1622312r1=1622311r2=1622312view=diff == --- tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/FragmentJarScannerCallback.java (original) +++ tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/FragmentJarScannerCallback.java Wed Sep 3 18:22:14 2014 @@ -111,15 +111,13 @@ public class FragmentJarScannerCallback @Override public void scan(File file, String webappPath, boolean isWebapp) throws IOException { -InputStream stream = null; WebXml fragment = new WebXml(); fragment.setWebappJar(isWebapp); fragment.setDelegate(delegate); -try { -File fragmentFile = new File(file, FRAGMENT_LOCATION); +File fragmentFile = new File(file, FRAGMENT_LOCATION); +try (InputStream stream = new FileInputStream(fragmentFile)) { if (fragmentFile.isFile()) { -stream = new FileInputStream(fragmentFile); InputSource source = new InputSource(fragmentFile.toURI().toURL().toString()); source.setByteStream(stream); Here is the problem. You moved the creation of the stream to before the isFile() test. Should be an easy fix. Thanks for the fix that you provided. I was not available today :( Please accept my apologies. I'll be more care in the future with the easy fixes. I wouldn't worry about. It happens to all of us. Well, it happens a lot to me anyway. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56917] New: Create a configuration to write relative 302 responses instead of absolute
https://issues.apache.org/bugzilla/show_bug.cgi?id=56917 Bug ID: 56917 Summary: Create a configuration to write relative 302 responses instead of absolute Product: Tomcat 8 Version: trunk Hardware: All OS: All Status: NEW Severity: normal Priority: P2 Component: Catalina Assignee: dev@tomcat.apache.org Reporter: ajay.sindw...@gmail.com Create a Tomcat configuration to force tomcat to write relative location headers in 301/302 responses instead of absolute location headers. Purpose: Today Tomcat always writes an absolute response for redirects per RFC2616 standards. However as many modern browsers support 302s to relative Locations as explained in https://en.wikipedia.org/wiki/HTTP_location , our friendly Tomcat application server should allow configuration to write back 302s in the more friendly form. The ripple effect of this where applications choose to use this setting, will be very good for cpu cycles of web servers and load balancers all over the world. This can greatly reduce the need for ProxyPassReverse in the Apache web server, and also for URL rewriting happenin in physical load balancers. See this example where another gentleman has been compelled to recompile Tomcat to achieve the same thing http://community.jaspersoft.com/wiki/f5-load-balancer-and-tomcat-302-error -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56917] Create a configuration to write relative 302 responses instead of absolute
https://issues.apache.org/bugzilla/show_bug.cgi?id=56917 Chuck Caldarale chuck.caldar...@unisys.com changed: What|Removed |Added Severity|normal |enhancement -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56917] Create a configuration to write relative 302 responses instead of absolute
https://issues.apache.org/bugzilla/show_bug.cgi?id=56917 --- Comment #1 from Mark Thomas ma...@apache.org --- This would be contrary to the requirements of the Servlet specification. See https://java.net/jira/browse/SERVLET_SPEC-100 for the request to change that (and some other stuff). -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56551] Increase timeouts in CometChat example
https://issues.apache.org/bugzilla/show_bug.cgi?id=56551 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #2 from Mark Thomas ma...@apache.org --- I've looked through the chat example and I don't see any need to increase the timeouts. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 56917] Create a configuration to write relative 302 responses instead of absolute
https://issues.apache.org/bugzilla/show_bug.cgi?id=56917 --- Comment #2 from Ajay Sindwani ajay.sindw...@gmail.com --- Both the servlet spec and Tomcat need to be updated then. Tomcat doesn't have to wait for the servlet spec, unless the update is already accepted. The expense of doing 302 rewriting can be cleaned from numerous webserver environments. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org