[Bug 57251] WAR deployment unbelievably slow when unpackWARs=false
https://issues.apache.org/bugzilla/show_bug.cgi?id=57251 --- Comment #7 from Francisco A. Lozano --- Correction: - Tomcat 8 deployment speed with unpackWARs="false": 24-26 seconds. - Tomcat 8 deployment speed with unpackWARs="true": 5-6 seconds. - Tomcat 7 deployment speed with unpackWARS="false": 4-5 seconds. - Tomcat 7 deployment speed with unpackWARS="true": 4-5 seconds. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 57251] WAR deployment unbelievably slow when unpackWARs=false
https://issues.apache.org/bugzilla/show_bug.cgi?id=57251 --- Comment #6 from Francisco A. Lozano --- Apologies for my poor usage of English with regard to the word "stalled" - you're right, it doesn't stop at all, just takes a lot of time. I've prepared a WAR file which shows the issue. https://github.com/flozano/greenhouse/blob/dev/show_tomcat8_problem/greenhouse-1.0.0.BUILD-SNAPSHOT.war - Tomcat 8 deployment speed with unpackWARs="false": 24-26 seconds. - Tomcat 8 deployment speed with unpackWARs="true": 5-6 seconds. - Tomcat 7 deployment speed with unpackWARS="false": 4-5 seconds. - Tomcat 7 deployment speed with unpackWARS="false": 4-5 seconds. Hope it helps. PS: The WAR is a small modification of a pre-existing Spring sample project, don't expect it to work properly, but the startup part works well. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Taglibs 1.2.2
On Jan 26, 2015, at 9:17 AM, Jeremy Boynes wrote: > > The proposed 1.2.2 release is: > [ ] Broken - do not release > [X] Stable - go ahead and release as 1.2.2 Stable JSTL TCK passed in the following environment: Mac OSX 10.10.1 Java 1.7.0_75 Apache Tomcat 7.0.57 Apache Xalan 2.7.1 with the following configurations: -jstlel jar, in webapp, no security manager -jstlel jar, in webapp, with security manager -jstlel jar, in container, with security manager -compat jar, in container, with security manager signature.asc Description: Message signed with OpenPGP using GPGMail
svn commit: r1654978 - in /tomcat/trunk/java/org/apache/tomcat/util/net/jsse: JSSESocketFactory.java res/LocalStrings.properties
Author: fschumacher
Date: Tue Jan 27 05:54:24 2015
New Revision: 1654978
URL: http://svn.apache.org/r1654978
Log:
Remove variable name substitution from log format string as it is hard to
localize.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java
tomcat/trunk/java/org/apache/tomcat/util/net/jsse/res/LocalStrings.properties
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java?rev=1654978&r1=1654977&r2=1654978&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java
Tue Jan 27 05:54:24 2015
@@ -177,7 +177,7 @@ public class JSSESocketFactory implement
try {
socket.close();
} catch (IOException e) {
-log.warn(sm.getString("jsse.exceptionOnClose", "socket"), e);
+log.warn(sm.getString("jsse.exceptionOnClose"), e);
}
}
}
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/jsse/res/LocalStrings.properties
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/jsse/res/LocalStrings.properties?rev=1654978&r1=1654977&r2=1654978&view=diff
==
---
tomcat/trunk/java/org/apache/tomcat/util/net/jsse/res/LocalStrings.properties
(original)
+++
tomcat/trunk/java/org/apache/tomcat/util/net/jsse/res/LocalStrings.properties
Tue Jan 27 05:54:24 2015
@@ -27,7 +27,7 @@ jsse.unsupported_protocols=Some specifie
jsse.excludeDefaultProtocol=The SSL protocol [{0}] which is enabled by default
in this JRE was excluded from the defaults used by Tomcat
jsse.noDefaultCiphers=Unable to determine a default for ciphers for [{0}]. Set
an explicit value to ensure the connector can start.
jsse.noDefaultProtocols=Unable to determine a default for sslEnabledProtocols
for [{0}]. Set an explicit value to ensure the connector can start.
-jsse.exceptionOnClose=Failure to close {0}.
+jsse.exceptionOnClose=Failure to close socket.
jsseSupport.clientCertError=Error trying to obtain a certificate from the
client
jseeSupport.certTranslationError=Error translating certificate [{0}]
jsseSupport.noCertWant=No client certificate sent for want
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 57472] performance (classloader?) problems with signed jars in WEB-INF/lib
https://issues.apache.org/bugzilla/show_bug.cgi?id=57472 --- Comment #5 from Mark Thomas --- That is sort of what Tomcat 7 does. I think I can port the openJars / closeJars from Tomcat 7's WebappClassLoader to Tomcat 8's resources implementation. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1654487 - in /tomcat/tc8.0.x/trunk: build.properties.default res/maven/mvn.properties.default webapps/docs/changelog.xml
Mark, Mark, On 1/26/15 2:41 PM, Mark Thomas wrote: > On 26/01/2015 15:31, Christopher Schultz wrote: >> Mark, >> >> On 1/26/15 3:31 AM, Mark Thomas wrote: >>> On 24/01/2015 19:21, Konstantin Kolinko wrote: 2015-01-24 13:00 GMT+03:00 : > Author: markt > Date: Sat Jan 24 10:00:32 2015 > New Revision: 1654487 > > URL: http://svn.apache.org/r1654487 > Log: > Prep for next tag > > Modified: > tomcat/tc8.0.x/trunk/build.properties.default > tomcat/tc8.0.x/trunk/res/maven/mvn.properties.default > tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml > > Modified: tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml > URL: > http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml?rev=1654487&r1=1654486&r2=1654487&view=diff > == > --- tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml (original) > +++ tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml Sat Jan 24 10:00:32 > 2015 > @@ -44,7 +44,9 @@ >They eventually become mixed with the numbered issues. (I.e., numbered >issues to not "pop up" wrt. others). > --> > - > + 1. Typo: in development >>> >>> Fixed. Thanks. >>> 2. An interesting idea, but release manager would have to remove that text when creating a tag. If you do not mind that extra work, then an item should be added to Release process description in the Wiki. >>> >>> I'll see how I get on with it. It was a spur of the moment thing so I >>> might go off the idea. >> >> Assuming I'm reading that correctly, it implies that we might be >> publishing changelogs *before* a release has actually been rolled. > > It is mainly there for folks that look at the file in svn or on the CI > server. > >> I >> really like this idea, if for no other reason than the changelog often >> doesn't get updated with the latest release date until the *following* >> release, which is ... irritating. :) > > No easy way to fix that. If we have marker text that means "in development", we can re-build the site from svn trunk whenever we want and we can even remove the "in development" builds if we want. >> What about having instead of "release text" or whatever, maybe an ENUM >> which contains a few mnemonics like "dev", "release", "votefail", etc.? >> That can be validated by an XML validator and the XSLT can produce >> standardized text for each status. > > Not sure how that would help with the most important part which is the date. Good point. Do you not use a release script that does that for you? -chris signature.asc Description: OpenPGP digital signature
[Bug 57472] performance (classloader?) problems with signed jars in WEB-INF/lib
https://issues.apache.org/bugzilla/show_bug.cgi?id=57472 --- Comment #4 from Christopher Schultz --- Maybe a ThreadLocal list of JARs to close? Presumably, the ClassLoader is going to load a whole bunch of classes from these JAR files at once; probably the first time some feature/group of classes is used. When a request is completed, maybe we could tell the WebappClassLoader that the request is done and it can close any JAR files it opened during that request, rather than having it re-open the JAR each time it loads a class. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: regression in 8.0.18?
>From 8.0.15, sorry forgot to mention it Romain Manni-Bucau @rmannibucau http://www.tomitribe.com http://rmannibucau.wordpress.com https://github.com/rmannibucau 2015-01-26 20:46 GMT+01:00 Mark Thomas : > On 26/01/2015 18:17, Romain Manni-Bucau wrote: >> Hi guys, >> >> since I upgraded to 8.0.18 I get: > > from what? > > That code hasn't changed 8.0.17 -> 8.0.18 (I don't think) but it did > change in a previous version. > > Mark > >> >> SEVERE: Servlet.service() for servlet [jsp] in context with path >> [/test] threw exception [javax.el.ELException: The class >> [java.util.Iterator] must be public, non-abstract and not an >> interface] with root cause >> javax.el.ELException: The class [java.util.Iterator] must be public, >> non-abstract and not an interface >> at javax.el.ImportHandler.findClass(ImportHandler.java:171) >> at javax.el.ImportHandler.importClass(ImportHandler.java:111) >> at >> org.apache.jasper.runtime.PageContextImpl.getELContext(PageContextImpl.java:954) >> at org.apache.jsp.setup_jsp._jspx_meth_c_005fset_005f0(setup_jsp.java:261) >> at org.apache.jsp.setup_jsp._jspService(setup_jsp.java:136) >> at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70) >> at javax.servlet.http.HttpServlet.service(HttpServlet.java:725) >> at >> org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:431) >> at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:396) >> at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:340) >> at javax.servlet.http.HttpServlet.service(HttpServlet.java:725) >> >> with >> http://svn.apache.org/repos/asf/tomee/tomee/trunk/examples/moviefun/src/main/webapp/setup.jsp >> (this line: for (Iterator iterator = movies.iterator(); >> iterator.hasNext(); )) >> >> Is it expected? not sure I get why interfaces are forbidden in >> particular with <%@ page import="java.util.Iterator" %> >> >> I saw indirectly https://java.net/jira/browse/JSP-44 but this is not >> the cause, any pointer? >> >> will a flag be introduced for existing apps? >> >> Romain Manni-Bucau >> @rmannibucau >> http://www.tomitribe.com >> http://rmannibucau.wordpress.com >> https://github.com/rmannibucau >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >> For additional commands, e-mail: dev-h...@tomcat.apache.org >> > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: regression in 8.0.18?
On 26/01/2015 18:17, Romain Manni-Bucau wrote: > Hi guys, > > since I upgraded to 8.0.18 I get: from what? That code hasn't changed 8.0.17 -> 8.0.18 (I don't think) but it did change in a previous version. Mark > > SEVERE: Servlet.service() for servlet [jsp] in context with path > [/test] threw exception [javax.el.ELException: The class > [java.util.Iterator] must be public, non-abstract and not an > interface] with root cause > javax.el.ELException: The class [java.util.Iterator] must be public, > non-abstract and not an interface > at javax.el.ImportHandler.findClass(ImportHandler.java:171) > at javax.el.ImportHandler.importClass(ImportHandler.java:111) > at > org.apache.jasper.runtime.PageContextImpl.getELContext(PageContextImpl.java:954) > at org.apache.jsp.setup_jsp._jspx_meth_c_005fset_005f0(setup_jsp.java:261) > at org.apache.jsp.setup_jsp._jspService(setup_jsp.java:136) > at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:725) > at > org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:431) > at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:396) > at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:340) > at javax.servlet.http.HttpServlet.service(HttpServlet.java:725) > > with > http://svn.apache.org/repos/asf/tomee/tomee/trunk/examples/moviefun/src/main/webapp/setup.jsp > (this line: for (Iterator iterator = movies.iterator(); > iterator.hasNext(); )) > > Is it expected? not sure I get why interfaces are forbidden in > particular with <%@ page import="java.util.Iterator" %> > > I saw indirectly https://java.net/jira/browse/JSP-44 but this is not > the cause, any pointer? > > will a flag be introduced for existing apps? > > Romain Manni-Bucau > @rmannibucau > http://www.tomitribe.com > http://rmannibucau.wordpress.com > https://github.com/rmannibucau > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 57251] WAR deployment unbelievably slow when unpackWARs=false
https://issues.apache.org/bugzilla/show_bug.cgi?id=57251 --- Comment #5 from Mark Thomas --- Stalled suggests that the strtup stops which doesn't appear to be the case. A web application that demonstrated the issue would be a big help. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1654487 - in /tomcat/tc8.0.x/trunk: build.properties.default res/maven/mvn.properties.default webapps/docs/changelog.xml
On 26/01/2015 15:31, Christopher Schultz wrote: > Mark, > > On 1/26/15 3:31 AM, Mark Thomas wrote: >> On 24/01/2015 19:21, Konstantin Kolinko wrote: >>> 2015-01-24 13:00 GMT+03:00 : Author: markt Date: Sat Jan 24 10:00:32 2015 New Revision: 1654487 URL: http://svn.apache.org/r1654487 Log: Prep for next tag Modified: tomcat/tc8.0.x/trunk/build.properties.default tomcat/tc8.0.x/trunk/res/maven/mvn.properties.default tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml >>> Modified: tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml?rev=1654487&r1=1654486&r2=1654487&view=diff == --- tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml (original) +++ tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml Sat Jan 24 10:00:32 2015 @@ -44,7 +44,9 @@ They eventually become mixed with the numbered issues. (I.e., numbered issues to not "pop up" wrt. others). --> - + >>> >>> 1. Typo: in development >> >> Fixed. Thanks. >> >>> 2. An interesting idea, but release manager would have to remove that >>> text when creating a tag. If you do not mind that extra work, then an >>> item should be added to Release process description in the Wiki. >> >> I'll see how I get on with it. It was a spur of the moment thing so I >> might go off the idea. > > Assuming I'm reading that correctly, it implies that we might be > publishing changelogs *before* a release has actually been rolled. It is mainly there for folks that look at the file in svn or on the CI server. > I > really like this idea, if for no other reason than the changelog often > doesn't get updated with the latest release date until the *following* > release, which is ... irritating. :) No easy way to fix that. > What about having instead of "release text" or whatever, maybe an ENUM > which contains a few mnemonics like "dev", "release", "votefail", etc.? > That can be validated by an XML validator and the XSLT can produce > standardized text for each status. Not sure how that would help with the most important part which is the date. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1654852 - in /tomcat/trunk/java/org/apache: catalina/servlets/CGIServlet.java catalina/servlets/DefaultServlet.java tomcat/util/net/jsse/JSSESocketFactory.java tomcat/util/net/jsse/re
Am 26. Januar 2015 20:12:09 MEZ, schrieb Konstantin Kolinko
:
>2015-01-26 21:05 GMT+03:00 :
>> Author: fschumacher
>> Date: Mon Jan 26 18:05:06 2015
>> New Revision: 1654852
>>
>> URL: http://svn.apache.org/r1654852
>> Log:
>> Log failure to close a resource instead of ignoring it silently.
>>
>> Modified:
>> tomcat/trunk/java/org/apache/catalina/servlets/CGIServlet.java
>>
>tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java
>>
>tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java
>>
>tomcat/trunk/java/org/apache/tomcat/util/net/jsse/res/LocalStrings.properties
>>
>
>> Modified:
>tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java
>> URL:
>http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java?rev=1654852&r1=1654851&r2=1654852&view=diff
>>
>==
>> ---
>tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java
>(original)
>> +++
>tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java
>Mon Jan 26 18:05:06 2015
>> @@ -176,7 +176,8 @@ public class JSSESocketFactory implement
>> } finally {
>> try {
>> socket.close();
>> -} catch (IOException ignore) {
>> +} catch (IOException e) {
>> +log.warn(sm.getString("jsse.exceptionOnClose",
>"socket"), e);
>
>-1. Such substitution (passing "socket" as "{0}") really cannot be
>localized.
Ok. Will change it. I thought it would be nice to have a generic message which
could take the name of the variable.
Felix
>
>> }
>> }
>> }
>>
>> Modified
>tomcat/trunk/java/org/apache/tomcat/util/net/jsse/res/LocalStrings.properties
>> URL:
>http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/jsse/res/LocalStrings.properties?rev=1654852&r1=1654851&r2=1654852&view=diff
>>
>==
>> ---
>tomcat/trunk/java/org/apache/tomcat/util/net/jsse/res/LocalStrings.properties
>(original)
>> +++
>tomcat/trunk/java/org/apache/tomcat/util/net/jsse/res/LocalStrings.properties
>Mon Jan 26 18:05:06 2015
>> @@ -27,6 +27,7 @@ jsse.unsupported_protocols=Some specifie
>> jsse.excludeDefaultProtocol=The SSL protocol [{0}] which is enabled
>by default in this JRE was excluded from the defaults used by Tomcat
>> jsse.noDefaultCiphers=Unable to determine a default for ciphers for
>[{0}]. Set an explicit value to ensure the connector can start.
>> jsse.noDefaultProtocols=Unable to determine a default for
>sslEnabledProtocols for [{0}]. Set an explicit value to ensure the
>connector can start.
>> +jsse.exceptionOnClose=Failure to close {0}.
>> jsseSupport.clientCertError=Error trying to obtain a certificate
>from the client
>> jseeSupport.certTranslationError=Error translating certificate [{0}]
>> jsseSupport.noCertWant=No client certificate sent for want
>>
>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>
>
>-
>To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>For additional commands, e-mail: dev-h...@tomcat.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 57472] performance (classloader?) problems with signed jars in WEB-INF/lib
https://issues.apache.org/bugzilla/show_bug.cgi?id=57472 --- Comment #3 from Mark Thomas --- I can confirm that it is JAR verification that is causing the slow down. The way to avoid that is to keep the JAR open for the life of the web application. However, that causes a catch-22 problem. Keeping the files open will prevent the web application from being deleted. If the web application can't be deleted folks that undeploy that way won;t be able to so the web application can't be stopped (which would be the trigger to close the file). I need to think about the best way to fix this. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1654852 - in /tomcat/trunk/java/org/apache: catalina/servlets/CGIServlet.java catalina/servlets/DefaultServlet.java tomcat/util/net/jsse/JSSESocketFactory.java tomcat/util/net/jsse/re
2015-01-26 21:05 GMT+03:00 :
> Author: fschumacher
> Date: Mon Jan 26 18:05:06 2015
> New Revision: 1654852
>
> URL: http://svn.apache.org/r1654852
> Log:
> Log failure to close a resource instead of ignoring it silently.
>
> Modified:
> tomcat/trunk/java/org/apache/catalina/servlets/CGIServlet.java
> tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java
> tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java
>
> tomcat/trunk/java/org/apache/tomcat/util/net/jsse/res/LocalStrings.properties
>
> Modified:
> tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java
> URL:
> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java?rev=1654852&r1=1654851&r2=1654852&view=diff
> ==
> --- tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java
> (original)
> +++ tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java
> Mon Jan 26 18:05:06 2015
> @@ -176,7 +176,8 @@ public class JSSESocketFactory implement
> } finally {
> try {
> socket.close();
> -} catch (IOException ignore) {
> +} catch (IOException e) {
> +log.warn(sm.getString("jsse.exceptionOnClose", "socket"), e);
-1. Such substitution (passing "socket" as "{0}") really cannot be localized.
> }
> }
> }
>
> Modified:
> tomcat/trunk/java/org/apache/tomcat/util/net/jsse/res/LocalStrings.properties
> URL:
> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/jsse/res/LocalStrings.properties?rev=1654852&r1=1654851&r2=1654852&view=diff
> ==
> ---
> tomcat/trunk/java/org/apache/tomcat/util/net/jsse/res/LocalStrings.properties
> (original)
> +++
> tomcat/trunk/java/org/apache/tomcat/util/net/jsse/res/LocalStrings.properties
> Mon Jan 26 18:05:06 2015
> @@ -27,6 +27,7 @@ jsse.unsupported_protocols=Some specifie
> jsse.excludeDefaultProtocol=The SSL protocol [{0}] which is enabled by
> default in this JRE was excluded from the defaults used by Tomcat
> jsse.noDefaultCiphers=Unable to determine a default for ciphers for [{0}].
> Set an explicit value to ensure the connector can start.
> jsse.noDefaultProtocols=Unable to determine a default for
> sslEnabledProtocols for [{0}]. Set an explicit value to ensure the connector
> can start.
> +jsse.exceptionOnClose=Failure to close {0}.
> jsseSupport.clientCertError=Error trying to obtain a certificate from the
> client
> jseeSupport.certTranslationError=Error translating certificate [{0}]
> jsseSupport.noCertWant=No client certificate sent for want
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
regression in 8.0.18?
Hi guys, since I upgraded to 8.0.18 I get: SEVERE: Servlet.service() for servlet [jsp] in context with path [/test] threw exception [javax.el.ELException: The class [java.util.Iterator] must be public, non-abstract and not an interface] with root cause javax.el.ELException: The class [java.util.Iterator] must be public, non-abstract and not an interface at javax.el.ImportHandler.findClass(ImportHandler.java:171) at javax.el.ImportHandler.importClass(ImportHandler.java:111) at org.apache.jasper.runtime.PageContextImpl.getELContext(PageContextImpl.java:954) at org.apache.jsp.setup_jsp._jspx_meth_c_005fset_005f0(setup_jsp.java:261) at org.apache.jsp.setup_jsp._jspService(setup_jsp.java:136) at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70) at javax.servlet.http.HttpServlet.service(HttpServlet.java:725) at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:431) at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:396) at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:340) at javax.servlet.http.HttpServlet.service(HttpServlet.java:725) with http://svn.apache.org/repos/asf/tomee/tomee/trunk/examples/moviefun/src/main/webapp/setup.jsp (this line: for (Iterator iterator = movies.iterator(); iterator.hasNext(); )) Is it expected? not sure I get why interfaces are forbidden in particular with <%@ page import="java.util.Iterator" %> I saw indirectly https://java.net/jira/browse/JSP-44 but this is not the cause, any pointer? will a flag be introduced for existing apps? Romain Manni-Bucau @rmannibucau http://www.tomitribe.com http://rmannibucau.wordpress.com https://github.com/rmannibucau - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1654524 - /tomcat/trunk/java/org/apache/catalina/servlets/CGIServlet.java
Am 26.01.2015 um 09:28 schrieb Mark Thomas:
On 25/01/2015 22:57, Christopher Schultz wrote:
Felix,
On 1/24/15 2:33 PM, Felix Schumacher wrote:
Am 24.01.2015 um 17:13 schrieb Christopher Schultz:
Felix,
On 1/24/15 9:42 AM, fschumac...@apache.org wrote:
Author: fschumacher
Date: Sat Jan 24 14:42:27 2015
New Revision: 1654524
URL: http://svn.apache.org/r1654524
Log:
Close input and output streams in expandCGIScript to
avoid resource leaks. Issue reported by Coverity Scan.
Modified:
tomcat/trunk/java/org/apache/catalina/servlets/CGIServlet.java
Modified: tomcat/trunk/java/org/apache/catalina/servlets/CGIServlet.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/servlets/CGIServlet.java?rev=1654524&r1=1654523&r2=1654524&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/servlets/CGIServlet.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/servlets/CGIServlet.java
Sat Jan 24 14:42:27 2015
@@ -1133,6 +1133,10 @@ public final class CGIServlet extends Ht
File f = new File(destPath.toString());
if (f.exists()) {
+try {
+is.close();
+} catch (IOException ignore) {
+}
Should this be logged? It should very rarely happen, but it would be
good to know if there was a problem (which might represent a resource
leak).
I looked for other examples in the source code before and the first few
examples I found where ignoring the exception while closing, too. So I
thought it would be ok, do ignore this exception.
If we don't want this exception ignored, at what level should the
information be logged? I would go for debug or info.
I think I'm in a minority when it comes to wanting to log these
exceptions. I think it might even be appropriate to log them at the WARN
level. If they happen -- which should be very rare -- it could indicate
a serious problem with the system or the JVM.
Ideally, the only time we would ignore exceptions is when we genuinely
don't care. That could include:
- something has already gone wrong (which we logged) and we are just
trying to clean up the mess, exceptions are expected and aren't going to
tell us anything useful
- we know that the exception is impossible but we have to catch it
I think the main thing is not to fill the logs with exception messages
the user can do nothing about.
In this case WARN seems reasonable.
I have added the logging of the exceptions.
Felix
Mark
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1654852 - in /tomcat/trunk/java/org/apache: catalina/servlets/CGIServlet.java catalina/servlets/DefaultServlet.java tomcat/util/net/jsse/JSSESocketFactory.java tomcat/util/net/jsse/res/Lo
Author: fschumacher
Date: Mon Jan 26 18:05:06 2015
New Revision: 1654852
URL: http://svn.apache.org/r1654852
Log:
Log failure to close a resource instead of ignoring it silently.
Modified:
tomcat/trunk/java/org/apache/catalina/servlets/CGIServlet.java
tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java
tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java
tomcat/trunk/java/org/apache/tomcat/util/net/jsse/res/LocalStrings.properties
Modified: tomcat/trunk/java/org/apache/catalina/servlets/CGIServlet.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/servlets/CGIServlet.java?rev=1654852&r1=1654851&r2=1654852&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/servlets/CGIServlet.java (original)
+++ tomcat/trunk/java/org/apache/catalina/servlets/CGIServlet.java Mon Jan 26
18:05:06 2015
@@ -1135,7 +1135,8 @@ public final class CGIServlet extends Ht
if (f.exists()) {
try {
is.close();
-} catch (IOException ignore) {
+} catch (IOException e) {
+log("Could not close is", e);
}
// Don't need to expand if it already exists
return;
@@ -1172,7 +1173,8 @@ public final class CGIServlet extends Ht
} finally {
try {
is.close();
-} catch (IOException ignore) {
+} catch (IOException e) {
+log("Could not close is.", e);
}
fos.close();
}
Modified: tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java?rev=1654852&r1=1654851&r2=1654852&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java Mon Jan
26 18:05:06 2015
@@ -1541,7 +1541,8 @@ public class DefaultServlet extends Http
try (InputStream is = resource.getInputStream();
InputStreamReader reader = new InputStreamReader(is)) {
copyRange(reader, new PrintWriter(buffer));
-} catch (IOException ignored) {
+} catch (IOException e) {
+log("Failure to close reader", e);
}
return buffer.toString();
} else {
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java?rev=1654852&r1=1654851&r2=1654852&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java
Mon Jan 26 18:05:06 2015
@@ -176,7 +176,8 @@ public class JSSESocketFactory implement
} finally {
try {
socket.close();
-} catch (IOException ignore) {
+} catch (IOException e) {
+log.warn(sm.getString("jsse.exceptionOnClose", "socket"), e);
}
}
}
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/jsse/res/LocalStrings.properties
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/jsse/res/LocalStrings.properties?rev=1654852&r1=1654851&r2=1654852&view=diff
==
---
tomcat/trunk/java/org/apache/tomcat/util/net/jsse/res/LocalStrings.properties
(original)
+++
tomcat/trunk/java/org/apache/tomcat/util/net/jsse/res/LocalStrings.properties
Mon Jan 26 18:05:06 2015
@@ -27,6 +27,7 @@ jsse.unsupported_protocols=Some specifie
jsse.excludeDefaultProtocol=The SSL protocol [{0}] which is enabled by default
in this JRE was excluded from the defaults used by Tomcat
jsse.noDefaultCiphers=Unable to determine a default for ciphers for [{0}]. Set
an explicit value to ensure the connector can start.
jsse.noDefaultProtocols=Unable to determine a default for sslEnabledProtocols
for [{0}]. Set an explicit value to ensure the connector can start.
+jsse.exceptionOnClose=Failure to close {0}.
jsseSupport.clientCertError=Error trying to obtain a certificate from the
client
jseeSupport.certTranslationError=Error translating certificate [{0}]
jsseSupport.noCertWant=No client certificate sent for want
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.o
svn commit: r1654851 - /tomcat/trunk/java/org/apache/catalina/authenticator/DigestAuthenticator.java
Author: fschumacher
Date: Mon Jan 26 18:02:11 2015
New Revision: 1654851
URL: http://svn.apache.org/r1654851
Log:
Remove volatile from variables, as it is misleading. All
variables, that are mutable and read/written from different threads are only
modified/read within a synchronized block. All other variables are immutable
and are now declared final. Issue identified by Coverity Scan.
Modified:
tomcat/trunk/java/org/apache/catalina/authenticator/DigestAuthenticator.java
Modified:
tomcat/trunk/java/org/apache/catalina/authenticator/DigestAuthenticator.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/authenticator/DigestAuthenticator.java?rev=1654851&r1=1654850&r2=1654851&view=diff
==
---
tomcat/trunk/java/org/apache/catalina/authenticator/DigestAuthenticator.java
(original)
+++
tomcat/trunk/java/org/apache/catalina/authenticator/DigestAuthenticator.java
Mon Jan 26 18:02:11 2015
@@ -637,10 +637,10 @@ public class DigestAuthenticator extends
}
private static class NonceInfo {
-private volatile long timestamp;
-private volatile boolean seen[];
-private volatile int offset;
-private volatile int count = 0;
+private final long timestamp;
+private final boolean seen[];
+private final int offset;
+private int count = 0;
public NonceInfo(long currentTime, int seenWindowSize) {
this.timestamp = currentTime;
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 57503] New: Log4J Logging Information Incomplete
https://issues.apache.org/bugzilla/show_bug.cgi?id=57503 Bug ID: 57503 Summary: Log4J Logging Information Incomplete Product: Tomcat 8 Version: trunk Hardware: PC Status: NEW Severity: normal Priority: P2 Component: Documentation Assignee: dev@tomcat.apache.org Reporter: gsex...@mhsoftware.com The Logging in Tomcat documentation states in the Log4J section on step 2 states: Download Log4J (v1.2 or later). This is incorrect. The current version of log4j (2.1) does not work with Tomcat 8. I have verified this. I configured per the instructions and log4j did not work. When I replaced the 2.1 jar with the current 1.2.x jar, logging worked as expected. The documentation should reflect that version 1.2.x is required, or Tomcat should be updated to work with the 2.1 jar and the documentation updated to reflect that requirement. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[VOTE] Release Apache Taglibs 1.2.2
The proposed Apache Taglibs 1.2.2 release is now available for voting. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/taglibs/taglibs-standard-1.2.2/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1032/ The SVN tag is: http://svn.apache.org/repos/asf/tomcat/taglibs/standard/tags/taglibs-standard-1.2.2/ The proposed 1.2.2 release is: [ ] Broken - do not release [ ] Stable - go ahead and release as 1.2.2 Stable Thanks Jeremy signature.asc Description: Message signed with OpenPGP using GPGMail
[Bug 57251] WAR deployment unbelievably slow when unpackWARs=false
https://issues.apache.org/bugzilla/show_bug.cgi?id=57251 --- Comment #4 from Francisco A. Lozano --- I've collected several stack-traces during slow startup times and, when the startup gets "stalled", the stacks look like this: "localhost-startStop-1" #15 daemon prio=5 os_prio=0 tid=0x01954000 nid=0x52d1 runnable [0x7fb50c625000] java.lang.Thread.State: RUNNABLE at java.util.zip.Inflater.inflateBytes(Native Method) at java.util.zip.Inflater.inflate(Inflater.java:259) - locked <0xdab5ab88> (a java.util.zip.ZStreamRef) at java.util.zip.InflaterInputStream.read(InflaterInputStream.java:152) at java.util.zip.ZipInputStream.read(ZipInputStream.java:194) at java.util.jar.JarInputStream.read(JarInputStream.java:207) at java.util.zip.ZipInputStream.closeEntry(ZipInputStream.java:140) at java.util.zip.ZipInputStream.getNextEntry(ZipInputStream.java:118) at java.util.jar.JarInputStream.getNextEntry(JarInputStream.java:142) at java.util.jar.JarInputStream.getNextJarEntry(JarInputStream.java:179) at org.apache.catalina.webresources.JarWarResource.getJarInputStreamWrapper(JarWarResource.java:59) at org.apache.catalina.webresources.AbstractArchiveResource.getContent(AbstractArchiveResource.java:175) at org.apache.catalina.loader.WebappClassLoaderBase.findResourceInternal(WebappClassLoaderBase.java:2579) at org.apache.catalina.loader.WebappClassLoaderBase.findClassInternal(WebappClassLoaderBase.java:2405) at org.apache.catalina.loader.WebappClassLoaderBase.findClass(WebappClassLoaderBase.java:854) at org.apache.catalina.loader.WebappClassLoaderBase.loadClass(WebappClassLoaderBase.java:1274) - locked <0x81c173f8> (a org.apache.catalina.loader.WebappClassLoader) at org.apache.catalina.loader.WebappClassLoaderBase.loadClass(WebappClassLoaderBase.java:1157) at java.lang.ClassLoader.defineClass1(Native Method) at java.lang.ClassLoader.defineClass(ClassLoader.java:760) at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142) at org.apache.catalina.loader.WebappClassLoaderBase.findClassInternal(WebappClassLoaderBase.java:2472) - locked <0x81c173f8> (a org.apache.catalina.loader.WebappClassLoader) at org.apache.catalina.loader.WebappClassLoaderBase.findClass(WebappClassLoaderBase.java:854) at org.apache.catalina.loader.WebappClassLoaderBase.loadClass(WebappClassLoaderBase.java:1274) - locked <0x81c173f8> (a org.apache.catalina.loader.WebappClassLoader) at org.apache.catalina.loader.WebappClassLoaderBase.loadClass(WebappClassLoaderBase.java:1157) It happens from different places: - netty loading some classes in io.netty.util.internal.PlatformDependent.getSystemClassLoader - spring/aspectj startup in org.aspectj.weaver.tools.PointcutParser.resolvePointcutExpression and I guess many others -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1654844 - in /tomcat/taglibs/standard/trunk: build-tools/pom.xml compat/pom.xml impl/pom.xml jstlel/pom.xml pom.xml spec/pom.xml
Author: jboynes Date: Mon Jan 26 16:58:24 2015 New Revision: 1654844 URL: http://svn.apache.org/r1654844 Log: [maven-release-plugin] prepare release taglibs-standard-1.2.2 Modified: tomcat/taglibs/standard/trunk/build-tools/pom.xml tomcat/taglibs/standard/trunk/compat/pom.xml tomcat/taglibs/standard/trunk/impl/pom.xml tomcat/taglibs/standard/trunk/jstlel/pom.xml tomcat/taglibs/standard/trunk/pom.xml tomcat/taglibs/standard/trunk/spec/pom.xml Modified: tomcat/taglibs/standard/trunk/build-tools/pom.xml URL: http://svn.apache.org/viewvc/tomcat/taglibs/standard/trunk/build-tools/pom.xml?rev=1654844&r1=1654843&r2=1654844&view=diff == --- tomcat/taglibs/standard/trunk/build-tools/pom.xml (original) +++ tomcat/taglibs/standard/trunk/build-tools/pom.xml Mon Jan 26 16:58:24 2015 @@ -24,20 +24,20 @@ org.apache.taglibs taglibs-standard -1.2.2-SNAPSHOT +1.2.2 taglibs-build-tools -1.2.2-SNAPSHOT +1.2.2 Apache Standard Taglib Build Tools Build tool settings common to all Standard Taglib modules - scm:svn:http://svn.apache.org/repos/asf/tomcat/taglibs/standard/trunk/build-tools - scm:svn:https://svn.apache.org/repos/asf/tomcat/taglibs/standard/trunk/build-tools + scm:svn:http://svn.apache.org/repos/asf/tomcat/taglibs/standard/tags/taglibs-standard-1.2.2/build-tools + scm:svn:https://svn.apache.org/repos/asf/tomcat/taglibs/standard/tags/taglibs-standard-1.2.2/build-tools - http://svn.apache.org/viewvc/tomcat/taglibs/standard/trunk/build-tools + http://svn.apache.org/viewvc/tomcat/taglibs/standard/tags/taglibs-standard-1.2.2/build-tools Modified: tomcat/taglibs/standard/trunk/compat/pom.xml URL: http://svn.apache.org/viewvc/tomcat/taglibs/standard/trunk/compat/pom.xml?rev=1654844&r1=1654843&r2=1654844&view=diff == --- tomcat/taglibs/standard/trunk/compat/pom.xml (original) +++ tomcat/taglibs/standard/trunk/compat/pom.xml Mon Jan 26 16:58:24 2015 @@ -24,11 +24,11 @@ org.apache.taglibs taglibs-standard -1.2.2-SNAPSHOT +1.2.2 taglibs-standard-compat -1.2.2-SNAPSHOT +1.2.2 bundle Apache Standard Taglib 1.0 Compatibility @@ -39,10 +39,10 @@ - scm:svn:http://svn.apache.org/repos/asf/tomcat/taglibs/standard/trunk/compat - scm:svn:https://svn.apache.org/repos/asf/tomcat/taglibs/standard/trunk/compat + scm:svn:http://svn.apache.org/repos/asf/tomcat/taglibs/standard/tags/taglibs-standard-1.2.2/compat + scm:svn:https://svn.apache.org/repos/asf/tomcat/taglibs/standard/tags/taglibs-standard-1.2.2/compat - http://svn.apache.org/viewvc/tomcat/taglibs/standard/trunk/compat + http://svn.apache.org/viewvc/tomcat/taglibs/standard/tags/taglibs-standard-1.2.2/compat @@ -69,12 +69,12 @@ org.apache.taglibs taglibs-standard-spec -1.2.2-SNAPSHOT +1.2.2 org.apache.taglibs taglibs-standard-impl -1.2.2-SNAPSHOT +1.2.2 Modified: tomcat/taglibs/standard/trunk/impl/pom.xml URL: http://svn.apache.org/viewvc/tomcat/taglibs/standard/trunk/impl/pom.xml?rev=1654844&r1=1654843&r2=1654844&view=diff == --- tomcat/taglibs/standard/trunk/impl/pom.xml (original) +++ tomcat/taglibs/standard/trunk/impl/pom.xml Mon Jan 26 16:58:24 2015 @@ -24,11 +24,11 @@ org.apache.taglibs taglibs-standard -1.2.2-SNAPSHOT +1.2.2 taglibs-standard-impl -1.2.2-SNAPSHOT +1.2.2 bundle Apache Standard Taglib Implementation @@ -39,10 +39,10 @@ - scm:svn:http://svn.apache.org/repos/asf/tomcat/taglibs/standard/trunk/impl - scm:svn:https://svn.apache.org/repos/asf/tomcat/taglibs/standard/trunk/impl + scm:svn:http://svn.apache.org/repos/asf/tomcat/taglibs/standard/tags/taglibs-standard-1.2.2/impl + scm:svn:https://svn.apache.org/repos/asf/tomcat/taglibs/standard/tags/taglibs-standard-1.2.2/impl - http://svn.apache.org/viewvc/tomcat/taglibs/standard/trunk/impl + http://svn.apache.org/viewvc/tomcat/taglibs/standard/tags/taglibs-standard-1.2.2/impl @@ -69,7 +69,7 @@ org.apache.taglibs taglibs-standard-spec -1.2.2-SNAPSHOT +1.2.2 provided Modified: tomcat/taglibs/standard/trunk/jstlel/pom.xml URL: http://svn.apache.org/viewvc/tomcat/taglibs/standard/trunk/jstlel/pom.xml?rev=1654844&r1=1654843&r2=1654844&view=diff
svn commit: r1654846 - in /tomcat/taglibs/standard/trunk: build-tools/pom.xml compat/pom.xml impl/pom.xml jstlel/pom.xml pom.xml spec/pom.xml
Author: jboynes Date: Mon Jan 26 16:58:27 2015 New Revision: 1654846 URL: http://svn.apache.org/r1654846 Log: [maven-release-plugin] prepare for next development iteration Modified: tomcat/taglibs/standard/trunk/build-tools/pom.xml tomcat/taglibs/standard/trunk/compat/pom.xml tomcat/taglibs/standard/trunk/impl/pom.xml tomcat/taglibs/standard/trunk/jstlel/pom.xml tomcat/taglibs/standard/trunk/pom.xml tomcat/taglibs/standard/trunk/spec/pom.xml Modified: tomcat/taglibs/standard/trunk/build-tools/pom.xml URL: http://svn.apache.org/viewvc/tomcat/taglibs/standard/trunk/build-tools/pom.xml?rev=1654846&r1=1654845&r2=1654846&view=diff == --- tomcat/taglibs/standard/trunk/build-tools/pom.xml (original) +++ tomcat/taglibs/standard/trunk/build-tools/pom.xml Mon Jan 26 16:58:27 2015 @@ -24,20 +24,20 @@ org.apache.taglibs taglibs-standard -1.2.2 +1.2.3-SNAPSHOT taglibs-build-tools -1.2.2 +1.2.3-SNAPSHOT Apache Standard Taglib Build Tools Build tool settings common to all Standard Taglib modules - scm:svn:http://svn.apache.org/repos/asf/tomcat/taglibs/standard/tags/taglibs-standard-1.2.2/build-tools - scm:svn:https://svn.apache.org/repos/asf/tomcat/taglibs/standard/tags/taglibs-standard-1.2.2/build-tools + scm:svn:http://svn.apache.org/repos/asf/tomcat/taglibs/standard/trunk/build-tools + scm:svn:https://svn.apache.org/repos/asf/tomcat/taglibs/standard/trunk/build-tools - http://svn.apache.org/viewvc/tomcat/taglibs/standard/tags/taglibs-standard-1.2.2/build-tools + http://svn.apache.org/viewvc/tomcat/taglibs/standard/trunk/build-tools Modified: tomcat/taglibs/standard/trunk/compat/pom.xml URL: http://svn.apache.org/viewvc/tomcat/taglibs/standard/trunk/compat/pom.xml?rev=1654846&r1=1654845&r2=1654846&view=diff == --- tomcat/taglibs/standard/trunk/compat/pom.xml (original) +++ tomcat/taglibs/standard/trunk/compat/pom.xml Mon Jan 26 16:58:27 2015 @@ -24,11 +24,11 @@ org.apache.taglibs taglibs-standard -1.2.2 +1.2.3-SNAPSHOT taglibs-standard-compat -1.2.2 +1.2.3-SNAPSHOT bundle Apache Standard Taglib 1.0 Compatibility @@ -39,10 +39,10 @@ - scm:svn:http://svn.apache.org/repos/asf/tomcat/taglibs/standard/tags/taglibs-standard-1.2.2/compat - scm:svn:https://svn.apache.org/repos/asf/tomcat/taglibs/standard/tags/taglibs-standard-1.2.2/compat + scm:svn:http://svn.apache.org/repos/asf/tomcat/taglibs/standard/trunk/compat + scm:svn:https://svn.apache.org/repos/asf/tomcat/taglibs/standard/trunk/compat - http://svn.apache.org/viewvc/tomcat/taglibs/standard/tags/taglibs-standard-1.2.2/compat + http://svn.apache.org/viewvc/tomcat/taglibs/standard/trunk/compat @@ -69,12 +69,12 @@ org.apache.taglibs taglibs-standard-spec -1.2.2 +1.2.3-SNAPSHOT org.apache.taglibs taglibs-standard-impl -1.2.2 +1.2.3-SNAPSHOT Modified: tomcat/taglibs/standard/trunk/impl/pom.xml URL: http://svn.apache.org/viewvc/tomcat/taglibs/standard/trunk/impl/pom.xml?rev=1654846&r1=1654845&r2=1654846&view=diff == --- tomcat/taglibs/standard/trunk/impl/pom.xml (original) +++ tomcat/taglibs/standard/trunk/impl/pom.xml Mon Jan 26 16:58:27 2015 @@ -24,11 +24,11 @@ org.apache.taglibs taglibs-standard -1.2.2 +1.2.3-SNAPSHOT taglibs-standard-impl -1.2.2 +1.2.3-SNAPSHOT bundle Apache Standard Taglib Implementation @@ -39,10 +39,10 @@ - scm:svn:http://svn.apache.org/repos/asf/tomcat/taglibs/standard/tags/taglibs-standard-1.2.2/impl - scm:svn:https://svn.apache.org/repos/asf/tomcat/taglibs/standard/tags/taglibs-standard-1.2.2/impl + scm:svn:http://svn.apache.org/repos/asf/tomcat/taglibs/standard/trunk/impl + scm:svn:https://svn.apache.org/repos/asf/tomcat/taglibs/standard/trunk/impl - http://svn.apache.org/viewvc/tomcat/taglibs/standard/tags/taglibs-standard-1.2.2/impl + http://svn.apache.org/viewvc/tomcat/taglibs/standard/trunk/impl @@ -69,7 +69,7 @@ org.apache.taglibs taglibs-standard-spec -1.2.2 +1.2.3-SNAPSHOT provided Modified: tomcat/taglibs/standard/trunk/jstlel/pom.xml URL: http://svn.apache.org/viewvc/tomcat/taglibs/standard/trunk/jstlel/pom.xml?rev=1654846&r1=1654845&r2=1654846&view=diff
svn commit: r1654845 - /tomcat/taglibs/standard/tags/taglibs-standard-1.2.2/
Author: jboynes Date: Mon Jan 26 16:58:26 2015 New Revision: 1654845 URL: http://svn.apache.org/r1654845 Log: [maven-release-plugin] copy for tag taglibs-standard-1.2.2 Added: tomcat/taglibs/standard/tags/taglibs-standard-1.2.2/ - copied from r1654844, tomcat/taglibs/standard/trunk/ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 57251] WAR deployment unbelievably slow when unpackWARs=false
https://issues.apache.org/bugzilla/show_bug.cgi?id=57251 Francisco A. Lozano changed: What|Removed |Added Version|8.0.15 |8.0.17 --- Comment #3 from Francisco A. Lozano --- - JDK 1.8.0_20 and 31 - Linux and OS X - Slow on Tomcat 8.0.15, 8.0.17 - OK on Tomcat 7.0.57 -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 57251] WAR deployment unbelievably slow when unpackWARs=false
https://issues.apache.org/bugzilla/show_bug.cgi?id=57251 Francisco A. Lozano changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|DUPLICATE |--- -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 57251] WAR deployment unbelievably slow when unpackWARs=false
https://issues.apache.org/bugzilla/show_bug.cgi?id=57251 --- Comment #2 from Francisco A. Lozano --- I can see the "EOF" error is duplicate of 57173, but - is the deployment speed also? To me it looks like there is a speed-related regression between 8 and 7. I have an app which is webapp-3.0, with metadata-complete=true and an empty absolute-ordering element. The WAR is around 80MB. I am getting: - Tomcat 7.0.57, unpackWARs=false: deploys in 30-50 seconds. - Tomcat 8.0.17, unpackWARs=false: deploys in 350 seconds. - Tomcat 8.0.17, unpackWARs=true: deploys in 30-50 seconds. Can you please consider reopening? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 57497] JARs of lib folder not loaded into classpath, getting ClassNotFoundException
https://issues.apache.org/bugzilla/show_bug.cgi?id=57497 --- Comment #4 from Chuck Caldarale --- (In reply to udariramesh from comment #3) > I am bit confused with your comment. Could you please brief me your > suggestion. I did not understand your comment "Please use tomcat users > list". How can i use tomcat users list. By signing up for it: http://tomcat.apache.org/lists.html Make sure to read the usage rules. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1654835 - /tomcat/taglibs/standard/trunk/CHANGES.txt
Author: jboynes Date: Mon Jan 26 16:02:32 2015 New Revision: 1654835 URL: http://svn.apache.org/r1654835 Log: Update change list Modified: tomcat/taglibs/standard/trunk/CHANGES.txt Modified: tomcat/taglibs/standard/trunk/CHANGES.txt URL: http://svn.apache.org/viewvc/tomcat/taglibs/standard/trunk/CHANGES.txt?rev=1654835&r1=1654834&r2=1654835&view=diff == --- tomcat/taglibs/standard/trunk/CHANGES.txt (original) +++ tomcat/taglibs/standard/trunk/CHANGES.txt Mon Jan 26 16:02:32 2015 @@ -1,3 +1,9 @@ +Changes in 1.2.2 release + +57433 Double-check locking in ExpressionEvaluatorManager +57427 1.0 TLDs are missing from -compat jar +57289 XML factories should be located using the JSTL library's ClassLoader + Changes in 1.2.1 release - Documentation cleanup - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Release of Apache Taglibs
On Jan 8, 2015, at 9:26 PM, Jeremy Boynes wrote: > > On Jan 8, 2015, at 1:42 PM, Konstantin Kolinko wrote: >> >> 2015-01-08 9:42 GMT+03:00 Jeremy Boynes : >>> I made a couple of minor improvements to Apache Taglibs last year related >>> to XML parsing and to how we load libraries (it now uses the TCCL which >>> means the jars can be shared between webapps as well as be included in a >>> webapp as before). I would like to perform a minor release (1.2.2) to >>> include these. Before I do, are there any other issues that should be >>> addressed? >>> >>> One change in 1.2 I think was not useful was the split of the 1.0 EL >>> evaluator into its own jar. I propose to merge that back so we end up with >>> two jars: one with the javax classes and one with our implementation. >> >> I do not see a point in merging them back. Personally, I do not use >> JSTL 1.0 EL implementation and do not plan to use it. (IIRC, the only >> occurrence when I used them was when I made a typo in tag library url, >> like copy-pasting from a wrong tld file. Hilarity ensued). >> Unexpectedly using a wrong implementation may be confusing. > > That was the kind of thing that prompted me to split it off in the first > place. > > The other was to the allow users to use a newer EL implementation (such as > the one from the container) which could have performance or efficiency > improvements over the original one, especially now EL has been decoupled from > JSTL and JSP. However, I found a problem with the -compat packaging that > would prevent that jar being used; see #57427. As no-one else had reported > that my assumption was that this was not that useful. > >> Another point is that I do not like changing release packaging in a >> point release. Is this driven by a real users' demand? Have there >> been any public complaints from real users (e.g. an issue in >> Bugzilla)? What do we do with Maven artifacts? Abandon one of them? > > As I’d not seen any feedback on the split (public or private) I was thinking > of simply reverting to the 1.1.x model. Sounds better though to fix the > problems with the -compat version and defer merging until a potential 1.3 > release. I’ve fixed the issues with the -compat version and verified that that configuration also passes the TCK. I am going to update the release notes and start the release process. Cheers Jeremy signature.asc Description: Message signed with OpenPGP using GPGMail
[Bug 57497] JARs of lib folder not loaded into classpath, getting ClassNotFoundException
https://issues.apache.org/bugzilla/show_bug.cgi?id=57497 --- Comment #3 from udariram...@gmail.com --- Hi Violeta, I am bit confused with your comment. Could you please brief me your suggestion. I did not understand your comment "Please use tomcat users list". How can i use tomcat users list. Regards, Ramesh -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 57496] Hard-coded URL in SVG example
https://issues.apache.org/bugzilla/show_bug.cgi?id=57496 Christopher Schultz changed: What|Removed |Added OS||All --- Comment #1 from Christopher Schultz --- (In reply to Konstantin Kolinko from comment #0) > To fix this one has to convert this static HTML page into a JSP one. Or just use a relative reference. This should be easy, as the two documents are in the same directory (i.e. no "..", etc. needed). -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1654487 - in /tomcat/tc8.0.x/trunk: build.properties.default res/maven/mvn.properties.default webapps/docs/changelog.xml
Mark, On 1/26/15 3:31 AM, Mark Thomas wrote: > On 24/01/2015 19:21, Konstantin Kolinko wrote: >> 2015-01-24 13:00 GMT+03:00 : >>> Author: markt >>> Date: Sat Jan 24 10:00:32 2015 >>> New Revision: 1654487 >>> >>> URL: http://svn.apache.org/r1654487 >>> Log: >>> Prep for next tag >>> >>> Modified: >>> tomcat/tc8.0.x/trunk/build.properties.default >>> tomcat/tc8.0.x/trunk/res/maven/mvn.properties.default >>> tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml >>> >> >>> Modified: tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml >>> URL: >>> http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml?rev=1654487&r1=1654486&r2=1654487&view=diff >>> == >>> --- tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml (original) >>> +++ tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml Sat Jan 24 10:00:32 2015 >>> @@ -44,7 +44,9 @@ >>>They eventually become mixed with the numbered issues. (I.e., numbered >>>issues to not "pop up" wrt. others). >>> --> >>> - >>> + >> >> 1. Typo: in development > > Fixed. Thanks. > >> 2. An interesting idea, but release manager would have to remove that >> text when creating a tag. If you do not mind that extra work, then an >> item should be added to Release process description in the Wiki. > > I'll see how I get on with it. It was a spur of the moment thing so I > might go off the idea. Assuming I'm reading that correctly, it implies that we might be publishing changelogs *before* a release has actually been rolled. I really like this idea, if for no other reason than the changelog often doesn't get updated with the latest release date until the *following* release, which is ... irritating. :) What about having instead of "release text" or whatever, maybe an ENUM which contains a few mnemonics like "dev", "release", "votefail", etc.? That can be validated by an XML validator and the XSLT can produce standardized text for each status. -chris signature.asc Description: OpenPGP digital signature
svn commit: r1654823 - in /tomcat/tc7.0.x/trunk: build.properties.default res/maven/mvn.properties.default
Author: violetagg Date: Mon Jan 26 14:56:30 2015 New Revision: 1654823 URL: http://svn.apache.org/r1654823 Log: Prep for next version Modified: tomcat/tc7.0.x/trunk/build.properties.default tomcat/tc7.0.x/trunk/res/maven/mvn.properties.default Modified: tomcat/tc7.0.x/trunk/build.properties.default URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/build.properties.default?rev=1654823&r1=1654822&r2=1654823&view=diff == --- tomcat/tc7.0.x/trunk/build.properties.default (original) +++ tomcat/tc7.0.x/trunk/build.properties.default Mon Jan 26 14:56:30 2015 @@ -25,7 +25,7 @@ # - Version Control Flags - version.major=7 version.minor=0 -version.build=58 +version.build=59 version.patch=0 version.suffix=-dev Modified: tomcat/tc7.0.x/trunk/res/maven/mvn.properties.default URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/res/maven/mvn.properties.default?rev=1654823&r1=1654822&r2=1654823&view=diff == --- tomcat/tc7.0.x/trunk/res/maven/mvn.properties.default (original) +++ tomcat/tc7.0.x/trunk/res/maven/mvn.properties.default Mon Jan 26 14:56:30 2015 @@ -35,7 +35,7 @@ maven.asf.release.repo.url=https://repos maven.asf.release.repo.repositoryId=apache.releases # Release version info -maven.asf.release.deploy.version=7.0.58 +maven.asf.release.deploy.version=7.0.59 #Where do we load the libraries from tomcat.lib.path=../../output/build/lib - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[VOTE] Release Apache Tomcat 7.0.58
The proposed Apache Tomcat 7.0.58 release is now available for voting. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.58/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1031/ The svn tag is: http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_58/ The proposed 7.0.58 release is: [ ] Broken - do not release [ ] Stable - go ahead and release as 7.0.58 Stable Regards, Violeta
svn commit: r1654800 - /tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml
Author: markt Date: Mon Jan 26 13:44:57 2015 New Revision: 1654800 URL: http://svn.apache.org/r1654800 Log: Vote passed a few minutes ago Modified: tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml?rev=1654800&r1=1654799&r2=1654800&view=diff == --- tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml (original) +++ tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml Mon Jan 26 13:44:57 2015 @@ -67,7 +67,7 @@ - + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1654794 - in /tomcat/tc7.0.x/tags/TOMCAT_7_0_58: ./ build.properties.default
Author: violetagg Date: Mon Jan 26 13:32:56 2015 New Revision: 1654794 URL: http://svn.apache.org/r1654794 Log: Tag 7.0.58 Added: tomcat/tc7.0.x/tags/TOMCAT_7_0_58/ (props changed) - copied from r1654791, tomcat/tc7.0.x/trunk/ Modified: tomcat/tc7.0.x/tags/TOMCAT_7_0_58/build.properties.default Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_58/ -- bugtraq:append = false Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_58/ -- bugtraq:label = Bugzilla ID (optional) Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_58/ -- --- bugtraq:logregex (added) +++ bugtraq:logregex Mon Jan 26 13:32:56 2015 @@ -0,0 +1,2 @@ +(https?\://issues.apache.org/bugzilla/show_bug.cgi\?id=\d+|BZ\s?\d+) +(\d+) Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_58/ -- --- bugtraq:message (added) +++ bugtraq:message Mon Jan 26 13:32:56 2015 @@ -0,0 +1 @@ +Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=%BUGID% Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_58/ -- bugtraq:number = true Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_58/ -- bugtraq:url = https://issues.apache.org/bugzilla/show_bug.cgi?id=%BUGID% Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_58/ -- bugtraq:warnifnoissue = false Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_58/ -- --- svn:ignore (added) +++ svn:ignore Mon Jan 26 13:32:56 2015 @@ -0,0 +1,7 @@ +.* +build.properties +logs +nbproject +output +work +*.iml Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_58/ -- --- svn:mergeinfo (added) +++ svn:mergeinfo Mon Jan 26 13:32:56 2015 @@ -0,0 +1,2 @@ +/tomcat/tc8.0.x/trunk:1636525,1637336,1637685,1637709,1638726,1640089,1640276,1640349,1640363,1640366,1640642,1640672,1640674,1640689,1640884,1641001,1641065,1641067,1641375,1641638,1641723,1641726,1641729-1641730,1641736,1641988,1642669-1642670,1642698,1642701,1643205,1643215,1643217,1643230,1643232,1643273,1643285,1643329-1643330,1643511,1643513,1643521,1643539,1643571,1643581-1643582,1643635,1643655,1643738,1643964,1644018,1644333,1644954,1644992,1645014,1645360,1645456,1645627,1645642,1645686,1645903-1645904,1645908-1645909,1645913,1645920,1646458,1646460-1646462,1647043,1648816,1651420-1651422,1651844,1652939-1652940,1652973,1653798,1653817,1653841,1654042,1654161,1654736,1654767,1654787 +/tomcat/trunk:1156115-1157160,1157162-1157859,1157862-1157942,1157945-1160347,1160349-1163716,1163718-1166689,1166691-1174340,1174342-1175596,1175598-1175611,1175613-1175932,1175934-1177783,1177785-1177980,1178006-1180720,1180722-1183094,1183096-1187753,1187755,1187775,1187801,1187806,1187809,1187826-1188312,1188314-1188401,1188646-1188840,1188842-1190176,1190178-1195223,1195225-1195953,1195955,1195957-1201238,1201240-1203345,1203347-1206623,1206625-1208046,1208073,1208096,1208114,1208145,1208772,1209194-1212125,1212127-1220291,1220293,1220295-1221321,1221323-1222329,1222332-1222401,1222405-1222795,1222850-1222950,1222969-1225326,1225328-1225463,1225465,1225627,1225629-1226534,1226536-1228908,1228911-1228923,1228927-1229532,1229534-1230766,1230768-1231625,1231627-1233414,1233419-1235207,1235209-1237425,1237427,1237429-1237977,1237981,1237985,1237995,1238070,1238073,1239024-1239048,1239050-1239062,1239135,1239256,1239258-1239485,1239785-1240046,1240101,1240106,1240109,1240112,1240114 ,1240116,1240118,1240121,1240329,1240474-1240850,1240857,1241087,1241160,1241408-1241822,1241908-1241909,1241912-1242110,1242371-1292130,1292134-1292458,1292464-1292670,1292672-1292776,1292780-1293392,1293397-1297017,1297019-1297963,1297965-1299820,1300108,1300111-1300460,1300520-1300948,1300997,1301006,1301280,1302332,1302348,1302608-1302610,1302649,1302837,1303138,1303163,1303338,1303521,1303587,1303698,1303803,1303852,1304011,1304035,1304037,1304135,1304249,1304253,1304260,1304271,1304275,1304468,1304895,1304930-1304932,1305194,1305943,1305965,1306556,1306579-1306580,1307084,1307310,1307511-1307512,1307579,1307591,1307597,1310636,1310639-1310640,1310642,1310701,1311212,1311995,1327617,1327670,1331766,1333161,1333173,1333827,1334787,1335026,1335257,1335547,1335692,1335711,1335731,1336515,1336813,1336864,1336868,1336884,1337419,1337426,1337546,1337572,1337591-1337595,1337643,1337707,1337719,1337734,1337741,1337745,1338151-1338154,1338178,1342027,1342029,1342315,1342320,1342476,1342 498,1342503,1342717,1342795,1342805,1343044-1343046,1343335,1343394,1343400,1343629,1343
Re: [VOTE][RESULT] Release Apache Tomcat 8.0.18
The following votes were cast: Binding: +1: markt, remm, jfarcand, schultz, kfujino, violetagg, kkolinko Non-binding: +1: fschumacher, Martin Grigorov The vote therefore passes. I'll update dist.a.o etc now and announce once the mirrors catch up (probably tomorrow). Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 57489] java.util.concurrent.ExecutionException: java.io.IOException: Key must be cancelled
https://issues.apache.org/bugzilla/show_bug.cgi?id=57489 --- Comment #2 from Mark Thomas --- I've added some debig logging to trunk, 8.0.x (for 8.0.19 onwards) and 7.0.x (for 7.0.58 onwards). Any further information you can provide as to what is going on would be very helpful. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1654788 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/websocket/LocalStrings.properties java/org/apache/tomcat/websocket/WsSession.java webapps/docs/changelog.xml
Author: markt Date: Mon Jan 26 13:19:11 2015 New Revision: 1654788 URL: http://svn.apache.org/r1654788 Log: Add some debug logging to the WebSocket session to track creation and closure Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/tomcat/websocket/LocalStrings.properties tomcat/tc7.0.x/trunk/java/org/apache/tomcat/websocket/WsSession.java tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Propchange: tomcat/tc7.0.x/trunk/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Mon Jan 26 13:19:11 2015 @@ -1,2 +1,2 @@ -/tomcat/tc8.0.x/trunk:1636525,1637336,1637685,1637709,1638726,1640089,1640276,1640349,1640363,1640366,1640642,1640672,1640674,1640689,1640884,1641001,1641065,1641067,1641375,1641638,1641723,1641726,1641729-1641730,1641736,1641988,1642669-1642670,1642698,1642701,1643205,1643215,1643217,1643230,1643232,1643273,1643285,1643329-1643330,1643511,1643513,1643521,1643539,1643571,1643581-1643582,1643635,1643655,1643738,1643964,1644018,1644333,1644954,1644992,1645014,1645360,1645456,1645627,1645642,1645686,1645903-1645904,1645908-1645909,1645913,1645920,1646458,1646460-1646462,1647043,1648816,1651420-1651422,1651844,1652939-1652940,1652973,1653798,1653817,1653841,1654042,1654161,1654736,1654767 -/tomcat/trunk:1156115-1157160,1157162-1157859,1157862-1157942,1157945-1160347,1160349-1163716,1163718-1166689,1166691-1174340,1174342-1175596,1175598-1175611,1175613-1175932,1175934-1177783,1177785-1177980,1178006-1180720,1180722-1183094,1183096-1187753,1187755,1187775,1187801,1187806,1187809,1187826-1188312,1188314-1188401,1188646-1188840,1188842-1190176,1190178-1195223,1195225-1195953,1195955,1195957-1201238,1201240-1203345,1203347-1206623,1206625-1208046,1208073,1208096,1208114,1208145,1208772,1209194-1212125,1212127-1220291,1220293,1220295-1221321,1221323-1222329,1222332-1222401,1222405-1222795,1222850-1222950,1222969-1225326,1225328-1225463,1225465,1225627,1225629-1226534,1226536-1228908,1228911-1228923,1228927-1229532,1229534-1230766,1230768-1231625,1231627-1233414,1233419-1235207,1235209-1237425,1237427,1237429-1237977,1237981,1237985,1237995,1238070,1238073,1239024-1239048,1239050-1239062,1239135,1239256,1239258-1239485,1239785-1240046,1240101,1240106,1240109,1240112,1240114 ,1240116,1240118,1240121,1240329,1240474-1240850,1240857,1241087,1241160,1241408-1241822,1241908-1241909,1241912-1242110,1242371-1292130,1292134-1292458,1292464-1292670,1292672-1292776,1292780-1293392,1293397-1297017,1297019-1297963,1297965-1299820,1300108,1300111-1300460,1300520-1300948,1300997,1301006,1301280,1302332,1302348,1302608-1302610,1302649,1302837,1303138,1303163,1303338,1303521,1303587,1303698,1303803,1303852,1304011,1304035,1304037,1304135,1304249,1304253,1304260,1304271,1304275,1304468,1304895,1304930-1304932,1305194,1305943,1305965,1306556,1306579-1306580,1307084,1307310,1307511-1307512,1307579,1307591,1307597,1310636,1310639-1310640,1310642,1310701,1311212,1311995,1327617,1327670,1331766,1333161,1333173,1333827,1334787,1335026,1335257,1335547,1335692,1335711,1335731,1336515,1336813,1336864,1336868,1336884,1337419,1337426,1337546,1337572,1337591-1337595,1337643,1337707,1337719,1337734,1337741,1337745,1338151-1338154,1338178,1342027,1342029,1342315,1342320,1342476,1342 498,1342503,1342717,1342795,1342805,1343044-1343046,1343335,1343394,1343400,1343629,1343708,1343718,1343895,1344063,1344068,1344250,1344266,1344515,1344528,1344612,1344629,1344725,1344868,1344890,1344893,1344896,1344901,1345020,1345029,1345039,1345287-1345290,1345294,1345309,1345325,1345357,1345367,1345579-1345580,1345582,1345688,1345699,1345704,1345731-1345732,1345737,1345744,1345752,1345754,1345779,1345781,1345846,1346107,1346365,1346376,1346404,1346510,1346514,1346519,1346581,1346635,1346644,1346683,1346794,1346885,1346932,1347034,1347047,1347087,1347108-1347109,1347583,1347737,1348105,1348357,1348398,1348425,1348461-1348495,1348498,1348752,1348762,1348772,1348776,1348859,1348968,1348973,1348989,1349007,1349237,1349298,1349317,1349410,1349473,1349539,1349879,1349887,1349893,1349922,1349984,1350124,1350241,1350243,1350294-1350295,1350299,1350864,1350900,1351010,1351054,1351056,1351068,1351134-1351135,1351148,1351259,1351604,1351636-1351640,1351991,1351993,1352011,1352056,1352059,1 352661,1352663,1352788,1352799,1353087,1353125,1353240,1353261,1353414,1353468,1353501,1353581,1353708,1354137,1354170,1354197,1354255,1354362,1354375,1354469,1354664,1354685,1354817,1354847,1354856,1355726,1355810,1356006-1356007,1356014,1356045,1356125,1356422,1356505,1356898,1357042,1357401,1357407,1358586,1358590,1358612-1358613,1359102,1359340,1359981,1360059,1360455,1360460,1360838,1360847,1360892,1360942,1361263,1361430,1361754-1361755,1361762,1361769,1361772,1361962,1361982,1361985,1361991,1364141,1364149,1364411-1364412,1364448,1366708,1366720,1366729,1366734,1366910,1366945,1366953,1366959,1367214,1370346,1370364,1370373,1370386,1370
svn commit: r1654787 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/websocket/LocalStrings.properties java/org/apache/tomcat/websocket/WsSession.java webapps/docs/changelog.xml
Author: markt
Date: Mon Jan 26 13:12:32 2015
New Revision: 1654787
URL: http://svn.apache.org/r1654787
Log:
Add some debug logging to the WebSocket session to track creation and closure
Modified:
tomcat/tc8.0.x/trunk/ (props changed)
tomcat/tc8.0.x/trunk/java/org/apache/tomcat/websocket/LocalStrings.properties
tomcat/tc8.0.x/trunk/java/org/apache/tomcat/websocket/WsSession.java
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml
Propchange: tomcat/tc8.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Jan 26 13:12:32 2015
@@ -1 +1 @@
-/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886,1644890,1644892
,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654725,1654735,1654766
+/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886,1644890,1644892
,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654725,1654735,1654766,1654785
Modified:
tomcat/tc8.0.x/trunk/java/org/apache/tomcat/websocket/LocalStrings.properties
URL:
http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/java/org/apache/tomcat/websocket/LocalStrings.properties?rev=1654787&r1=1654786&r2=1654787&view=diff
==
---
tomcat/tc8.0.x/trunk/java/org/apache/tomcat/websocket/LocalStrings.properties
(original)
+++
tomcat/tc8.0.x/trunk/java/org/apache/tomcat/websocket/LocalStrings.properties
Mon Jan 26 13:12:32 2015
@@ -87,13 +87,15 @@ wsRemoteEndpoint.tooMuchData=Ping or pon
wsSession.timeout=The WebSocket session timeout expired
wsSession.closed=The WebSocket session [{0}] has been closed and no method
(apart from close()) may be called on a closed session
+wsSession.created=Created WebSocket session [{0}]
+wsSession.doClose=Closing WebSocket session [{1}]
wsSession.duplicateHandlerBinary=A binary message handler has already been
configured
wsSession.duplicateHandlerPong=A pong message handler has already been
configured
wsSession.duplicateHandlerText=A t
svn commit: r1654785 - in /tomcat/trunk/java/org/apache/tomcat/websocket: LocalStrings.properties WsSession.java
Author: markt
Date: Mon Jan 26 13:10:54 2015
New Revision: 1654785
URL: http://svn.apache.org/r1654785
Log:
Add some debug logging to the WebSocket session to track creation and closure
Modified:
tomcat/trunk/java/org/apache/tomcat/websocket/LocalStrings.properties
tomcat/trunk/java/org/apache/tomcat/websocket/WsSession.java
Modified: tomcat/trunk/java/org/apache/tomcat/websocket/LocalStrings.properties
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/websocket/LocalStrings.properties?rev=1654785&r1=1654784&r2=1654785&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/websocket/LocalStrings.properties
(original)
+++ tomcat/trunk/java/org/apache/tomcat/websocket/LocalStrings.properties Mon
Jan 26 13:10:54 2015
@@ -87,13 +87,15 @@ wsRemoteEndpoint.tooMuchData=Ping or pon
wsSession.timeout=The WebSocket session timeout expired
wsSession.closed=The WebSocket session [{0}] has been closed and no method
(apart from close()) may be called on a closed session
+wsSession.created=Created WebSocket session [{0}]
+wsSession.doClose=Closing WebSocket session [{1}]
wsSession.duplicateHandlerBinary=A binary message handler has already been
configured
wsSession.duplicateHandlerPong=A pong message handler has already been
configured
wsSession.duplicateHandlerText=A text message handler has already been
configured
wsSession.invalidHandlerTypePong=A pong message handler must implement
MessageHandler.Basic
wsSession.flushFailOnClose=Failed to flush batched messages on session close
wsSession.messageFailed=Unable to write the complete message as the WebSocket
connection has been closed
-wsSession.sendCloseFail=Failed to send close message to remote endpoint
+wsSession.sendCloseFail=Failed to send close message for session [{0}] to
remote endpoint
wsSession.removeHandlerFailed=Unable to remove the handler [{0}] as it was not
registered with this session
wsSession.unknownHandler=Unable to add the message handler [{0}] as it was for
the unrecognised type [{1}]
wsSession.unknownHandlerType=Unable to add the message handler [{0}] as it was
wrapped as the unrecognised type [{1}]
Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsSession.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/websocket/WsSession.java?rev=1654785&r1=1654784&r2=1654785&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/websocket/WsSession.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/websocket/WsSession.java Mon Jan 26
13:10:54 2015
@@ -179,6 +179,10 @@ public class WsSession implements Sessio
this.userProperties.putAll(endpointConfig.getUserProperties());
this.id = Long.toHexString(ids.getAndIncrement());
+
+if (log.isDebugEnabled()) {
+log.debug(sm.getString("wsSession.created", id));
+}
}
@@ -459,6 +463,9 @@ public class WsSession implements Sessio
return;
}
+if (log.isDebugEnabled()) {
+log.debug(sm.getString("wsSession.doClose", id));
+}
try {
wsRemoteEndpoint.setBatchingAllowed(false);
} catch (IOException e) {
@@ -566,7 +573,7 @@ public class WsSession implements Sessio
// Failed to send close message. Close the socket and let the
caller
// deal with the Exception
if (log.isDebugEnabled()) {
-log.debug(sm.getString("wsSession.sendCloseFail"), ioe);
+log.debug(sm.getString("wsSession.sendCloseFail", id), ioe);
}
wsRemoteEndpoint.close();
// Failure to send a close message is not unexpected in the case of
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 57497] JARs of lib folder not loaded into classpath, getting ClassNotFoundException
https://issues.apache.org/bugzilla/show_bug.cgi?id=57497 Violeta Georgieva changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Violeta Georgieva --- Hi, >From the provided information it seems to be an application configuration problem. Please use tomcat users list. If the root of the problem appeared to be in Tomcat then you can reopen this issue. Regards, Violeta -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 57489] java.util.concurrent.ExecutionException: java.io.IOException: Key must be cancelled
https://issues.apache.org/bugzilla/show_bug.cgi?id=57489 Mark Thomas changed: What|Removed |Added OS||All --- Comment #1 from Mark Thomas --- Hmm. Whatever is going wrong, is going wrong earlier than this stack trace. Something causes the WebSocket connection to close. It appears that Atmosphere isn't notified about this / doesn't notice it. Something happens later that causes Atmosphere to realise there is a dead WebSocket connection. Atmosphere triggers a 'dirty' close. This 'dirty' close fails because the WebSocket connection has already been closed. That triggers an error because, as far as I can tell, a normal WebSocket close reason (1000) is used. If abnormal closure was used (1006), Tomcat would swallow any error. What we really need to figure out is why is this connection closed in the first place. There isn't much in the way of debug logging for WebSocket session closure in Tomcat - I'll fix that for the next release - but it is worth seeing is Atmosphere's debug logging tells you anything useful. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 57497] JARs of lib folder not loaded into classpath, getting ClassNotFoundException
https://issues.apache.org/bugzilla/show_bug.cgi?id=57497 udariram...@gmail.com changed: What|Removed |Added CC||udariram...@gmail.com -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 57497] JARs of lib folder not loaded into classpath, getting ClassNotFoundException
https://issues.apache.org/bugzilla/show_bug.cgi?id=57497 udariram...@gmail.com changed: What|Removed |Added OS||All --- Comment #1 from udariram...@gmail.com --- Below are complete stack traces: java.lang.ClassNotFoundException: net.sourceforge.jtds.jdbc.Driver at org.apache.felix.framework.ModuleImpl.findClassOrResourceByDelegation(ModuleImpl. at org.apache.felix.framework.ModuleImpl.access$200(ModuleImpl.java:73) at org.apache.felix.framework.ModuleImpl$ModuleClassLoader.loadClass(ModuleImpl.java at java.lang.ClassLoader.loadClass(Unknown Source) at java.lang.Class.forName0(Native Method) at java.lang.Class.forName(Unknown Source) at com.globallogic.velocity.db.MSSQLConnection.getConnection(MSSQLConnection.java:40 at com.globallogic.velocity.db.DBConnectionFactory.getConnection(DBConnectionFactory at com.globallogic.velocity.schedule.Routine.createConnection(Routine.java:93) at com.globallogic.velocity.schedule.Routine.getConnection(Routine.java:62) at com.globallogic.velocity.schedule.ERPMasterRoutine.getStatement(ERPMasterRoutine. at com.globallogic.velocity.schedule.ERPMasterRoutine.syncProcess(ERPMasterRoutine.j at com.globallogic.velocity.schedule.ERPDatabaseSyncTask.execute(ERPDatabaseSyncTask at com.atlassian.sal.jira.scheduling.JiraPluginScheduler$JobDescriptor.runJob(JiraPl at com.atlassian.sal.jira.scheduling.JiraPluginScheduler.runJob(JiraPluginScheduler. at com.atlassian.scheduler.core.JobLauncher.runJob(JobLauncher.java:135) at com.atlassian.scheduler.core.JobLauncher.launchAndBuildResponse(JobLauncher.java: at com.atlassian.scheduler.core.JobLauncher.launch(JobLauncher.java:80) at com.atlassian.scheduler.quartz1.Quartz1Job.execute(Quartz1Job.java:32) at org.quartz.core.JobRunShell.run(JobRunShell.java:223) at org.quartz.simpl.SimpleThreadPool$WorkerThread.run(SimpleThreadPool.java:549) -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 57497] New: JARs of lib folder not loaded into classpath, getting ClassNotFoundException
https://issues.apache.org/bugzilla/show_bug.cgi?id=57497 Bug ID: 57497 Summary: JARs of lib folder not loaded into classpath, getting ClassNotFoundException Product: Tomcat 7 Version: 7.0.55 Hardware: All Status: NEW Severity: critical Priority: P2 Component: Catalina Assignee: dev@tomcat.apache.org Reporter: udariram...@gmail.com Hi, I am using tomcat 7.0.55 version for deploying our web based application(JIRA 6) and in our application we are trying to connect external databases(sql server) by using sqljdbc4.jar and jtds-1.2.5.jar. We tried by using both drivers, in both cases we are getting java.lang.ClassNotFoundException: net.sourceforge.jtds.jdbc.Driver exception while loading driver even we have both these JARS in C:\apache-tomcat-7.0.55\lib folder. Same is working with tomcat-5.5.29 version wehn we places these boths jars in C:\apache-tomcat-5.5.29\common\lib folder. Even it is not working, if we use data source concept. Same is working tomcat-5.5.29 version. Seems that JARs present under tomcat\lib folder not loading into classpath. Please help us what was changed in tomcat 7.0.55 version. We are struggling with this issue from past 10 days not get any solution till now. Regards, Ramesh -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn propchange: r1654768 - svn:log
Author: markt Revision: 1654768 Modified property: svn:log Modified: svn:log at Mon Jan 26 11:28:58 2015 -- --- svn:log (original) +++ svn:log Mon Jan 26 11:28:58 2015 @@ -0,0 +1,3 @@ +Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=57490 +Make it possible to use Tomcat's WebSocket client within a web application when running under a SecurityManager. +Based on a patch by Mikael Sterner. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 57490] Websocket client cannot connect from Tomcat servlet with a SecurityManager in place
https://issues.apache.org/bugzilla/show_bug.cgi?id=57490 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Mark Thomas --- Thanks for the report, test case and patch. I have applied a variation of the patch to trunk, 8.0.x (for 8.0.19 onwards) and 7.0.x (for 7./0.58 onwards). -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1654768 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/websocket/AsyncChannelGroupUtil.java webapps/docs/changelog.xml
Author: markt Date: Mon Jan 26 11:27:29 2015 New Revision: 1654768 URL: http://svn.apache.org/r1654768 Log: (empty) Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/tomcat/websocket/AsyncChannelGroupUtil.java tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Propchange: tomcat/tc7.0.x/trunk/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Mon Jan 26 11:27:29 2015 @@ -1,2 +1,2 @@ -/tomcat/tc8.0.x/trunk:1636525,1637336,1637685,1637709,1638726,1640089,1640276,1640349,1640363,1640366,1640642,1640672,1640674,1640689,1640884,1641001,1641065,1641067,1641375,1641638,1641723,1641726,1641729-1641730,1641736,1641988,1642669-1642670,1642698,1642701,1643205,1643215,1643217,1643230,1643232,1643273,1643285,1643329-1643330,1643511,1643513,1643521,1643539,1643571,1643581-1643582,1643635,1643655,1643738,1643964,1644018,1644333,1644954,1644992,1645014,1645360,1645456,1645627,1645642,1645686,1645903-1645904,1645908-1645909,1645913,1645920,1646458,1646460-1646462,1647043,1648816,1651420-1651422,1651844,1652939-1652940,1652973,1653798,1653817,1653841,1654042,1654161,1654736 -/tomcat/trunk:1156115-1157160,1157162-1157859,1157862-1157942,1157945-1160347,1160349-1163716,1163718-1166689,1166691-1174340,1174342-1175596,1175598-1175611,1175613-1175932,1175934-1177783,1177785-1177980,1178006-1180720,1180722-1183094,1183096-1187753,1187755,1187775,1187801,1187806,1187809,1187826-1188312,1188314-1188401,1188646-1188840,1188842-1190176,1190178-1195223,1195225-1195953,1195955,1195957-1201238,1201240-1203345,1203347-1206623,1206625-1208046,1208073,1208096,1208114,1208145,1208772,1209194-1212125,1212127-1220291,1220293,1220295-1221321,1221323-1222329,1222332-1222401,1222405-1222795,1222850-1222950,1222969-1225326,1225328-1225463,1225465,1225627,1225629-1226534,1226536-1228908,1228911-1228923,1228927-1229532,1229534-1230766,1230768-1231625,1231627-1233414,1233419-1235207,1235209-1237425,1237427,1237429-1237977,1237981,1237985,1237995,1238070,1238073,1239024-1239048,1239050-1239062,1239135,1239256,1239258-1239485,1239785-1240046,1240101,1240106,1240109,1240112,1240114 ,1240116,1240118,1240121,1240329,1240474-1240850,1240857,1241087,1241160,1241408-1241822,1241908-1241909,1241912-1242110,1242371-1292130,1292134-1292458,1292464-1292670,1292672-1292776,1292780-1293392,1293397-1297017,1297019-1297963,1297965-1299820,1300108,1300111-1300460,1300520-1300948,1300997,1301006,1301280,1302332,1302348,1302608-1302610,1302649,1302837,1303138,1303163,1303338,1303521,1303587,1303698,1303803,1303852,1304011,1304035,1304037,1304135,1304249,1304253,1304260,1304271,1304275,1304468,1304895,1304930-1304932,1305194,1305943,1305965,1306556,1306579-1306580,1307084,1307310,1307511-1307512,1307579,1307591,1307597,1310636,1310639-1310640,1310642,1310701,1311212,1311995,1327617,1327670,1331766,1333161,1333173,1333827,1334787,1335026,1335257,1335547,1335692,1335711,1335731,1336515,1336813,1336864,1336868,1336884,1337419,1337426,1337546,1337572,1337591-1337595,1337643,1337707,1337719,1337734,1337741,1337745,1338151-1338154,1338178,1342027,1342029,1342315,1342320,1342476,1342 498,1342503,1342717,1342795,1342805,1343044-1343046,1343335,1343394,1343400,1343629,1343708,1343718,1343895,1344063,1344068,1344250,1344266,1344515,1344528,1344612,1344629,1344725,1344868,1344890,1344893,1344896,1344901,1345020,1345029,1345039,1345287-1345290,1345294,1345309,1345325,1345357,1345367,1345579-1345580,1345582,1345688,1345699,1345704,1345731-1345732,1345737,1345744,1345752,1345754,1345779,1345781,1345846,1346107,1346365,1346376,1346404,1346510,1346514,1346519,1346581,1346635,1346644,1346683,1346794,1346885,1346932,1347034,1347047,1347087,1347108-1347109,1347583,1347737,1348105,1348357,1348398,1348425,1348461-1348495,1348498,1348752,1348762,1348772,1348776,1348859,1348968,1348973,1348989,1349007,1349237,1349298,1349317,1349410,1349473,1349539,1349879,1349887,1349893,1349922,1349984,1350124,1350241,1350243,1350294-1350295,1350299,1350864,1350900,1351010,1351054,1351056,1351068,1351134-1351135,1351148,1351259,1351604,1351636-1351640,1351991,1351993,1352011,1352056,1352059,1 352661,1352663,1352788,1352799,1353087,1353125,1353240,1353261,1353414,1353468,1353501,1353581,1353708,1354137,1354170,1354197,1354255,1354362,1354375,1354469,1354664,1354685,1354817,1354847,1354856,1355726,1355810,1356006-1356007,1356014,1356045,1356125,1356422,1356505,1356898,1357042,1357401,1357407,1358586,1358590,1358612-1358613,1359102,1359340,1359981,1360059,1360455,1360460,1360838,1360847,1360892,1360942,1361263,1361430,1361754-1361755,1361762,1361769,1361772,1361962,1361982,1361985,1361991,1364141,1364149,1364411-1364412,1364448,1366708,1366720,1366729,1366734,1366910,1366945,1366953,1366959,1367214,1370346,1370364,1370373,1370386,1370473,1370537,1370549,1370553,1370879,1370916,1370958,1370960,1370973,1371017,1371283,1371336,1371620,1371812,1371823,1371896,1371976,1371978,1371995,
svn commit: r1654767 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/tomcat/websocket/AsyncChannelGroupUtil.java webapps/docs/changelog.xml
Author: markt
Date: Mon Jan 26 11:25:14 2015
New Revision: 1654767
URL: http://svn.apache.org/r1654767
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=57490
Make it possible to use Tomcat's WebSocket client within a web application when
running under a SecurityManager.
Based on a patch by Mikael Sterner.
Modified:
tomcat/tc8.0.x/trunk/ (props changed)
tomcat/tc8.0.x/trunk/java/org/apache/tomcat/websocket/AsyncChannelGroupUtil.java
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml
Propchange: tomcat/tc8.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Mon Jan 26 11:25:14 2015
@@ -1 +1 @@
-/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886,1644890,1644892
,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654725,1654735
+/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886,1644890,1644892
,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654725,1654735,1654766
Modified:
tomcat/tc8.0.x/trunk/java/org/apache/tomcat/websocket/AsyncChannelGroupUtil.java
URL:
http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/java/org/apache/tomcat/websocket/AsyncChannelGroupUtil.java?rev=1654767&r1=1654766&r2=1654767&view=diff
==
---
tomcat/tc8.0.x/trunk/java/org/apache/tomcat/websocket/AsyncChannelGroupUtil.java
(original)
+++
tomcat/tc8.0.x/trunk/java/org/apache/tomcat/websocket/AsyncChannelGroupUtil.java
Mon Jan 26 11:25:14 2015
@@ -105,7 +105,13 @@ public class AsyncChannelGroupUtil {
private static class AsyncIOThreadFactory implements ThreadFactory {
-private AtomicInteger count = new AtomicInteger(0);
+static {
+// Load NewThreadPrivilegedAction since newThread() will not be
able
+// to if called from an InnocuousThread.
+// See https://issues.apache.org/bugzilla/show_bug.cgi?id=57490
+NewThreadPrivilegedAction.load();
+}
+
@O
svn commit: r1654766 - /tomcat/trunk/java/org/apache/tomcat/websocket/AsyncChannelGroupUtil.java
Author: markt
Date: Mon Jan 26 11:22:36 2015
New Revision: 1654766
URL: http://svn.apache.org/r1654766
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=57490
Make it possible to use Tomcat's WebSocket client within a web application when
running under a SecurityManager.
Based on a patch by Mikael Sterner.
Modified:
tomcat/trunk/java/org/apache/tomcat/websocket/AsyncChannelGroupUtil.java
Modified:
tomcat/trunk/java/org/apache/tomcat/websocket/AsyncChannelGroupUtil.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/websocket/AsyncChannelGroupUtil.java?rev=1654766&r1=1654765&r2=1654766&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/websocket/AsyncChannelGroupUtil.java
(original)
+++ tomcat/trunk/java/org/apache/tomcat/websocket/AsyncChannelGroupUtil.java
Mon Jan 26 11:22:36 2015
@@ -105,7 +105,13 @@ public class AsyncChannelGroupUtil {
private static class AsyncIOThreadFactory implements ThreadFactory {
-private AtomicInteger count = new AtomicInteger(0);
+static {
+// Load NewThreadPrivilegedAction since newThread() will not be
able
+// to if called from an InnocuousThread.
+// See https://issues.apache.org/bugzilla/show_bug.cgi?id=57490
+NewThreadPrivilegedAction.load();
+}
+
@Override
public Thread newThread(final Runnable r) {
@@ -113,16 +119,33 @@ public class AsyncChannelGroupUtil {
// the thread inherits the current ProtectionDomain which is
// essential to be able to use this with a Java Applet. See
// https://issues.apache.org/bugzilla/show_bug.cgi?id=57091
-return AccessController.doPrivileged(new
PrivilegedAction() {
-@Override
-public Thread run() {
-Thread t = new Thread(r);
-t.setName("WebSocketClient-AsyncIO-" +
count.incrementAndGet());
-t.setContextClassLoader(this.getClass().getClassLoader());
-t.setDaemon(true);
-return t;
-}
-});
+return AccessController.doPrivileged(new
NewThreadPrivilegedAction(r));
+}
+
+// Non-anonymous class so that AsyncIOThreadFactory can load it
+// explicitly
+private static class NewThreadPrivilegedAction implements
PrivilegedAction {
+
+private static AtomicInteger count = new AtomicInteger(0);
+
+private final Runnable r;
+
+public NewThreadPrivilegedAction(Runnable r) {
+this.r = r;
+}
+
+@Override
+public Thread run() {
+Thread t = new Thread(r);
+t.setName("WebSocketClient-AsyncIO-" +
count.incrementAndGet());
+t.setContextClassLoader(this.getClass().getClassLoader());
+t.setDaemon(true);
+return t;
+}
+
+private static void load() {
+// NO-OP. Just provides a hook to enable the class to be loaded
+}
}
}
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 57490] Websocket client cannot connect from Tomcat servlet with a SecurityManager in place
https://issues.apache.org/bugzilla/show_bug.cgi?id=57490 --- Comment #2 from Mark Thomas --- I do see this in Windows. I'll take a look at your patch. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 57490] Websocket client cannot connect from Tomcat servlet with a SecurityManager in place
https://issues.apache.org/bugzilla/show_bug.cgi?id=57490 Mark Thomas changed: What|Removed |Added OS||All --- Comment #1 from Mark Thomas --- Interesting. I don't see this issue on OSX. I'll check on Windows. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 57496] New: Hard-coded URL in SVG example
https://issues.apache.org/bugzilla/show_bug.cgi?id=57496 Bug ID: 57496 Summary: Hard-coded URL in SVG example Product: Tomcat 8 Version: 8.0.17 Hardware: PC Status: NEW Severity: minor Priority: P2 Component: Examples Assignee: dev@tomcat.apache.org Reporter: knst.koli...@gmail.com A minor glitch in the examples. The file \webapps\examples\jsp\jsp2\jspx\svgexample.html in Examples web application has the following text: Copy the following URL: http://localhost:8080/examples/jsp/jsp2/jspx/textRotate.jspx?name=JSPX";> http://localhost:8080/examples/jsp/jsp2/jspx/textRotate.jspx?name=JSPX If Tomcat runs on a different port number, the above link to localhost:8080 becomes wrong. I noted this when doing a recursive download (wget -r) of the examples webapp. To fix this one has to convert this static HTML page into a JSP one. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.0.18
2015-01-23 16:09 GMT+03:00 Mark Thomas : > The proposed Apache Tomcat 8.0.18 release is now available for voting. > > > The proposed 8.0.18 release is: > [ ] Broken - do not release > [x] Stable - go ahead and release as 8.0.18 Unit tests passed (BIO, NIO, NIO2, APR). Reproducer for bug 57476 OK. Smoke testing OK. Using JDK 7u72 32-bit on Windows 7. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: DigestAuthenticator and volatile variables in NonceInfo
On 24/01/2015 20:11, Felix Schumacher wrote: > Hi all, > > I looked at the coverity issue 86588 and it says, that the volatile > variable seen[] is unsafe, because only the reference is volatile and > not not the array elements. > > After a closer look, I am convinced, that all variables in that inner > class NonceInfo are needlessly declared volatile, since they are either > final (well, could be declared final) (this is timestamp) or are only > ever accessed inside the constructor and synchronized methods. > > I would vote to remove the volatile declarations and add final to > timestamp. > > Any thoughts? +1. I'd also make offset final. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1654487 - in /tomcat/tc8.0.x/trunk: build.properties.default res/maven/mvn.properties.default webapps/docs/changelog.xml
On 24/01/2015 19:21, Konstantin Kolinko wrote: > 2015-01-24 13:00 GMT+03:00 : >> Author: markt >> Date: Sat Jan 24 10:00:32 2015 >> New Revision: 1654487 >> >> URL: http://svn.apache.org/r1654487 >> Log: >> Prep for next tag >> >> Modified: >> tomcat/tc8.0.x/trunk/build.properties.default >> tomcat/tc8.0.x/trunk/res/maven/mvn.properties.default >> tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml >> > >> Modified: tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml >> URL: >> http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml?rev=1654487&r1=1654486&r2=1654487&view=diff >> == >> --- tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml (original) >> +++ tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml Sat Jan 24 10:00:32 2015 >> @@ -44,7 +44,9 @@ >>They eventually become mixed with the numbered issues. (I.e., numbered >>issues to not "pop up" wrt. others). >> --> >> - >> + > > 1. Typo: in development Fixed. Thanks. > 2. An interesting idea, but release manager would have to remove that > text when creating a tag. If you do not mind that extra work, then an > item should be added to Release process description in the Wiki. I'll see how I get on with it. It was a spur of the moment thing so I might go off the idea. Mark > >> + >> + >> >> >> > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1654738 - /tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml
Author: markt Date: Mon Jan 26 08:30:31 2015 New Revision: 1654738 URL: http://svn.apache.org/r1654738 Log: Fix typo Modified: tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml?rev=1654738&r1=1654737&r2=1654738&view=diff == --- tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml (original) +++ tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml Mon Jan 26 08:30:31 2015 @@ -44,7 +44,7 @@ They eventually become mixed with the numbered issues. (I.e., numbered issues to not "pop up" wrt. others). --> - + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r1654524 - /tomcat/trunk/java/org/apache/catalina/servlets/CGIServlet.java
On 25/01/2015 22:57, Christopher Schultz wrote:
> Felix,
>
> On 1/24/15 2:33 PM, Felix Schumacher wrote:
>> Am 24.01.2015 um 17:13 schrieb Christopher Schultz:
>>> Felix,
>>>
>>> On 1/24/15 9:42 AM, fschumac...@apache.org wrote:
Author: fschumacher
Date: Sat Jan 24 14:42:27 2015
New Revision: 1654524
URL: http://svn.apache.org/r1654524
Log:
Close input and output streams in expandCGIScript to
avoid resource leaks. Issue reported by Coverity Scan.
Modified:
tomcat/trunk/java/org/apache/catalina/servlets/CGIServlet.java
Modified: tomcat/trunk/java/org/apache/catalina/servlets/CGIServlet.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/servlets/CGIServlet.java?rev=1654524&r1=1654523&r2=1654524&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/servlets/CGIServlet.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/servlets/CGIServlet.java
Sat Jan 24 14:42:27 2015
@@ -1133,6 +1133,10 @@ public final class CGIServlet extends Ht
File f = new File(destPath.toString());
if (f.exists()) {
+try {
+is.close();
+} catch (IOException ignore) {
+}
>>> Should this be logged? It should very rarely happen, but it would be
>>> good to know if there was a problem (which might represent a resource
>>> leak).
>> I looked for other examples in the source code before and the first few
>> examples I found where ignoring the exception while closing, too. So I
>> thought it would be ok, do ignore this exception.
>>
>> If we don't want this exception ignored, at what level should the
>> information be logged? I would go for debug or info.
>
> I think I'm in a minority when it comes to wanting to log these
> exceptions. I think it might even be appropriate to log them at the WARN
> level. If they happen -- which should be very rare -- it could indicate
> a serious problem with the system or the JVM.
Ideally, the only time we would ignore exceptions is when we genuinely
don't care. That could include:
- something has already gone wrong (which we logged) and we are just
trying to clean up the mess, exceptions are expected and aren't going to
tell us anything useful
- we know that the exception is impossible but we have to catch it
I think the main thing is not to fill the logs with exception messages
the user can do nothing about.
In this case WARN seems reasonable.
Mark
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r1654737 - in /tomcat/tc7.0.x/trunk: ./ webapps/docs/changelog.xml webapps/docs/config/ajp.xml webapps/docs/config/http.xml
Author: kkolinko Date: Mon Jan 26 08:13:57 2015 New Revision: 1654737 URL: http://svn.apache.org/r1654737 Log: Clarify behaviour of useBodyEncodingForURI attribute and its relation to URIEncoding. Merged r1654736 from tomcat/tc8.0.x/trunk (r1654735 from tomcat/trunk). Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml tomcat/tc7.0.x/trunk/webapps/docs/config/ajp.xml tomcat/tc7.0.x/trunk/webapps/docs/config/http.xml Propchange: tomcat/tc7.0.x/trunk/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Mon Jan 26 08:13:57 2015 @@ -1,2 +1,2 @@ -/tomcat/tc8.0.x/trunk:1636525,1637336,1637685,1637709,1638726,1640089,1640276,1640349,1640363,1640366,1640642,1640672,1640674,1640689,1640884,1641001,1641065,1641067,1641375,1641638,1641723,1641726,1641729-1641730,1641736,1641988,1642669-1642670,1642698,1642701,1643205,1643215,1643217,1643230,1643232,1643273,1643285,1643329-1643330,1643511,1643513,1643521,1643539,1643571,1643581-1643582,1643635,1643655,1643738,1643964,1644018,1644333,1644954,1644992,1645014,1645360,1645456,1645627,1645642,1645686,1645903-1645904,1645908-1645909,1645913,1645920,1646458,1646460-1646462,1647043,1648816,1651420-1651422,1651844,1652939-1652940,1652973,1653798,1653817,1653841,1654042,1654161 -/tomcat/trunk:1156115-1157160,1157162-1157859,1157862-1157942,1157945-1160347,1160349-1163716,1163718-1166689,1166691-1174340,1174342-1175596,1175598-1175611,1175613-1175932,1175934-1177783,1177785-1177980,1178006-1180720,1180722-1183094,1183096-1187753,1187755,1187775,1187801,1187806,1187809,1187826-1188312,1188314-1188401,1188646-1188840,1188842-1190176,1190178-1195223,1195225-1195953,1195955,1195957-1201238,1201240-1203345,1203347-1206623,1206625-1208046,1208073,1208096,1208114,1208145,1208772,1209194-1212125,1212127-1220291,1220293,1220295-1221321,1221323-1222329,1222332-1222401,1222405-1222795,1222850-1222950,1222969-1225326,1225328-1225463,1225465,1225627,1225629-1226534,1226536-1228908,1228911-1228923,1228927-1229532,1229534-1230766,1230768-1231625,1231627-1233414,1233419-1235207,1235209-1237425,1237427,1237429-1237977,1237981,1237985,1237995,1238070,1238073,1239024-1239048,1239050-1239062,1239135,1239256,1239258-1239485,1239785-1240046,1240101,1240106,1240109,1240112,1240114 ,1240116,1240118,1240121,1240329,1240474-1240850,1240857,1241087,1241160,1241408-1241822,1241908-1241909,1241912-1242110,1242371-1292130,1292134-1292458,1292464-1292670,1292672-1292776,1292780-1293392,1293397-1297017,1297019-1297963,1297965-1299820,1300108,1300111-1300460,1300520-1300948,1300997,1301006,1301280,1302332,1302348,1302608-1302610,1302649,1302837,1303138,1303163,1303338,1303521,1303587,1303698,1303803,1303852,1304011,1304035,1304037,1304135,1304249,1304253,1304260,1304271,1304275,1304468,1304895,1304930-1304932,1305194,1305943,1305965,1306556,1306579-1306580,1307084,1307310,1307511-1307512,1307579,1307591,1307597,1310636,1310639-1310640,1310642,1310701,1311212,1311995,1327617,1327670,1331766,1333161,1333173,1333827,1334787,1335026,1335257,1335547,1335692,1335711,1335731,1336515,1336813,1336864,1336868,1336884,1337419,1337426,1337546,1337572,1337591-1337595,1337643,1337707,1337719,1337734,1337741,1337745,1338151-1338154,1338178,1342027,1342029,1342315,1342320,1342476,1342 498,1342503,1342717,1342795,1342805,1343044-1343046,1343335,1343394,1343400,1343629,1343708,1343718,1343895,1344063,1344068,1344250,1344266,1344515,1344528,1344612,1344629,1344725,1344868,1344890,1344893,1344896,1344901,1345020,1345029,1345039,1345287-1345290,1345294,1345309,1345325,1345357,1345367,1345579-1345580,1345582,1345688,1345699,1345704,1345731-1345732,1345737,1345744,1345752,1345754,1345779,1345781,1345846,1346107,1346365,1346376,1346404,1346510,1346514,1346519,1346581,1346635,1346644,1346683,1346794,1346885,1346932,1347034,1347047,1347087,1347108-1347109,1347583,1347737,1348105,1348357,1348398,1348425,1348461-1348495,1348498,1348752,1348762,1348772,1348776,1348859,1348968,1348973,1348989,1349007,1349237,1349298,1349317,1349410,1349473,1349539,1349879,1349887,1349893,1349922,1349984,1350124,1350241,1350243,1350294-1350295,1350299,1350864,1350900,1351010,1351054,1351056,1351068,1351134-1351135,1351148,1351259,1351604,1351636-1351640,1351991,1351993,1352011,1352056,1352059,1 352661,1352663,1352788,1352799,1353087,1353125,1353240,1353261,1353414,1353468,1353501,1353581,1353708,1354137,1354170,1354197,1354255,1354362,1354375,1354469,1354664,1354685,1354817,1354847,1354856,1355726,1355810,1356006-1356007,1356014,1356045,1356125,1356422,1356505,1356898,1357042,1357401,1357407,1358586,1358590,1358612-1358613,1359102,1359340,1359981,1360059,1360455,1360460,1360838,1360847,1360892,1360942,1361263,1361430,1361754-1361755,1361762,1361769,1361772,1361962,1361982,1361985,1361991,1364141,1364149,1364411-1364412,1364448,1366708,1366720,1366729,1366734,1366910,1366945,1366953,1366959,1367214,1370346,1370364,
svn commit: r1654736 - in /tomcat/tc8.0.x/trunk: ./ webapps/docs/changelog.xml webapps/docs/config/ajp.xml webapps/docs/config/http.xml
Author: kkolinko Date: Mon Jan 26 08:09:12 2015 New Revision: 1654736 URL: http://svn.apache.org/r1654736 Log: Clarify behaviour of useBodyEncodingForURI attribute and its relation to URIEncoding. Merged r1654735 from tomcat/trunk. Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml tomcat/tc8.0.x/trunk/webapps/docs/config/ajp.xml tomcat/tc8.0.x/trunk/webapps/docs/config/http.xml Propchange: tomcat/tc8.0.x/trunk/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Mon Jan 26 08:09:12 2015 @@ -1 +1 @@ -/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886,1644890,1644892 ,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654725 +/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886,1644890,1644892 ,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654725,1654735 Modified: tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml?rev=1654736&r1=1654735&r2=1654736&view=diff == --- tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml (original) +++ tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml Mon Jan 26 08:09:12 2015 @@ -45,6 +45,14 @@ issues to not "pop up" wrt. others). --> + + + +Clarify documentation for useBodyEncodingForURI +attribute of a connector. (kkolinko) + + + Modified: tomcat/tc8.0.x/trunk/webapps/docs/config/ajp.xml URL: http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/webapps/docs/config/ajp.xml?rev=1654736&r1=1654735&r2=1654736&view=diff == --- tomcat/tc8.0.x/trunk/webapps/docs/config/ajp.xml (original) +++ tomcat/tc8.0.x/trunk/webapps/docs/config/ajp.xml Mon Jan 26 08:09:12 2015 @@ -240,6 +240,8 @@ Request.setCharacterEncoding method was also used for the parameters fr
Re: [VOTE] Release Apache Tomcat 8.0.18
On Fri, Jan 23, 2015 at 3:09 PM, Mark Thomas wrote: > The proposed Apache Tomcat 8.0.18 release is now available for voting. > > The main changes since 8.0.17 are: > - Fix a regression that resulted in truncated responses for > forwarded responses larger than the output buffer > > There is also the usual collection of bug fixes, new features and > performance improvements. For full details, see the changelog: > > http://svn.us.apache.org/repos/asf/tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.18/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1030/ > The svn tag is: > http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_18/ > > The proposed 8.0.18 release is: > [ ] Broken - do not release > [ X ] Stable - go ahead and release as 8.0.18 > Tested Apache Wicket integration for JSR356. > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
