[GUMP@vmgump]: Project tomcat-trunk-test-nio (in module tomcat-trunk) failed

2016-05-05 Thread Bill Barker 
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-test-nio has an issue affecting its community integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-test-nio :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-nio/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/logs-NIO
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO/logs]



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-nio/gump_work/build_tomcat-trunk_tomcat-trunk-test-nio.html
Work Name: build_tomcat-trunk_tomcat-trunk-test-nio (Type: Build)
Work ended in a state of : Failed
Elapsed: 35 mins 3 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.3-SNAPSHOT.jar
 -Dtest.reports=output/logs-NIO 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20160506-native-src.tar.gz
 -Dexamples.sources.skip=true 
-Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar 
-Dtest.relaxTiming=true 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20160506.jar
 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20160506-native-src.tar.gz
 -Dtest.temp=output/test-tmp-NIO -Dtest.accesslog=true -Dexecute.t
 est.nio=true 
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-master/dest-20160506/bin/openssl
 -Dexecute.test.apr=false -Dtest.excludePerformance=true 
-Dexecute.test.nio2=false 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.5-SNAPSHOT.jar
 -Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja

[jira] [Commented] (MTOMCAT-263) tomcat7:exec-war can't create .extract/webapps

2016-05-05 Thread *$^¨%`£ 

[ 
https://issues.apache.org/jira/browse/MTOMCAT-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15273631#comment-15273631
 ] 

Olivier Lamy (*$^¨%`£) commented on MTOMCAT-263:


Sorry guys I didn't have a lot of spare time recently.
I will try in the next few weeks.
[~monowai] I will sue those springboot folks as they have stolen my idea :-) 
Yup it looks this plugin is the ancestor of all the buzzy microservices :P 

> tomcat7:exec-war can't create .extract/webapps
> --
>
> Key: MTOMCAT-263
> URL: https://issues.apache.org/jira/browse/MTOMCAT-263
> Project: Apache Tomcat Maven Plugin
>  Issue Type: Bug
>Affects Versions: 2.1, 2.2
>Reporter: jieryn
>Assignee: Olivier Lamy (*$^¨%`£)
> Fix For: 3.0
>
> Attachments: MTOMCAT-263_1.patch
>
>
> bash$ java -jar target/app-1.0-SNAPSHOT-war-exec.jar
> Exception in thread "main" java.lang.Exception: FATAL: impossible to create 
> directories:.extract/webapps
> at 
> org.apache.tomcat.maven.runner.Tomcat7Runner.extract(Tomcat7Runner.java:586)
> at 
> org.apache.tomcat.maven.runner.Tomcat7Runner.run(Tomcat7Runner.java:204)
> at 
> org.apache.tomcat.maven.runner.Tomcat7RunnerCli.main(Tomcat7RunnerCli.java:212)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[jira] [Commented] (MTOMCAT-263) tomcat7:exec-war can't create .extract/webapps

2016-05-05 Thread Magnus Skoglund (JIRA) 

[ 
https://issues.apache.org/jira/browse/MTOMCAT-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15273629#comment-15273629
 ] 

Magnus Skoglund commented on MTOMCAT-263:
-

I am sorry to say, but I did a local fork, and a release, to use for
myself. Had to skip the tests, since I do not understand them. Works fine
with latest tomcat 7 version.




> tomcat7:exec-war can't create .extract/webapps
> --
>
> Key: MTOMCAT-263
> URL: https://issues.apache.org/jira/browse/MTOMCAT-263
> Project: Apache Tomcat Maven Plugin
>  Issue Type: Bug
>Affects Versions: 2.1, 2.2
>Reporter: jieryn
>Assignee: Olivier Lamy (*$^¨%`£)
> Fix For: 3.0
>
> Attachments: MTOMCAT-263_1.patch
>
>
> bash$ java -jar target/app-1.0-SNAPSHOT-war-exec.jar
> Exception in thread "main" java.lang.Exception: FATAL: impossible to create 
> directories:.extract/webapps
> at 
> org.apache.tomcat.maven.runner.Tomcat7Runner.extract(Tomcat7Runner.java:586)
> at 
> org.apache.tomcat.maven.runner.Tomcat7Runner.run(Tomcat7Runner.java:204)
> at 
> org.apache.tomcat.maven.runner.Tomcat7RunnerCli.main(Tomcat7RunnerCli.java:212)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[jira] [Commented] (MTOMCAT-263) tomcat7:exec-war can't create .extract/webapps

2016-05-05 Thread Mike Holdsworth (JIRA) 

[ 
https://issues.apache.org/jira/browse/MTOMCAT-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272834#comment-15272834
 ] 

Mike Holdsworth commented on MTOMCAT-263:
-

If you're still waiting on this plugin getting some love you're probably better 
off either taking a lead and 
[forking|https://github.com/apache/tomcat-maven-plugin/tree/trunk/tomcat7-war-runner
 ] it or moving on and reconsidering your deployment approach.

Around 18 months after posting my question I switched to using SpringBoot. Took 
some time but easily one of the smarter moves I've  made. 

Good luck


> tomcat7:exec-war can't create .extract/webapps
> --
>
> Key: MTOMCAT-263
> URL: https://issues.apache.org/jira/browse/MTOMCAT-263
> Project: Apache Tomcat Maven Plugin
>  Issue Type: Bug
>Affects Versions: 2.1, 2.2
>Reporter: jieryn
>Assignee: Olivier Lamy (*$^¨%`£)
> Fix For: 3.0
>
> Attachments: MTOMCAT-263_1.patch
>
>
> bash$ java -jar target/app-1.0-SNAPSHOT-war-exec.jar
> Exception in thread "main" java.lang.Exception: FATAL: impossible to create 
> directories:.extract/webapps
> at 
> org.apache.tomcat.maven.runner.Tomcat7Runner.extract(Tomcat7Runner.java:586)
> at 
> org.apache.tomcat.maven.runner.Tomcat7Runner.run(Tomcat7Runner.java:204)
> at 
> org.apache.tomcat.maven.runner.Tomcat7RunnerCli.main(Tomcat7RunnerCli.java:212)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1742455 - /tomcat/tc7.0.x/trunk/webapps/docs/config/listeners.xml

2016-05-05 Thread markt 
Author: markt
Date: Thu May  5 17:24:41 2016
New Revision: 1742455

URL: http://svn.apache.org/viewvc?rev=1742455=rev
Log:
Update docs since most users won't need to enable this option.

Modified:
tomcat/tc7.0.x/trunk/webapps/docs/config/listeners.xml

Modified: tomcat/tc7.0.x/trunk/webapps/docs/config/listeners.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/config/listeners.xml?rev=1742455=1742454=1742455=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/config/listeners.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/config/listeners.xml Thu May  5 17:24:41 
2016
@@ -229,6 +229,9 @@
 sun.java2d.Disposer class by a web application does not
 result in a memory leak.
 Defaults to false because a thread is launched.
+Note: The underlying leak has been fixed in Java 1.6.0 update 21
+onwards and Java 7 onwards. This option is unnecessary if running on a
+fixed version of Java.
   
 
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat Native 1.2.7

2016-05-05 Thread Rainer Jung 

Am 04.05.2016 um 11:42 schrieb Mark Thomas:

Version 1.2.7 includes the following changes:

- Windows binaries rebuild with OpenSSL 1.0.2h

The proposed release artefacts can be found at [1],
and the build was done using tag [2].

The Apache Tomcat Native 1.2.7 is
  [X] Stable, go ahead and release
  [ ] Broken because of ...


+1 to release, thanks for RMing.

Detailed results especially about unit test failures see below.

There were two JVM crashes, but that's not a regression on my setup. I 
did some partial analysis, see at the end of the message.


We might still want to remove some resolved items from TODO.txt and
probably can resolve some more for the next releases.

- Tested with APR 1.5.2 and OpenSSL 1.0.2h
- Platforms Solaris 10 Sparc, SLES 11 64 Bits, RHEL 6 64 Bits
- configure flag "--enable-maintainer-mode"
- Using Java versions 1.8.0_72 for tcnative build, tests/examples
  and TC trunk unit tests
  - Using "-XX:-UseCompressedClassPointers" in combination with
Java 8 on 64 Bit Linux
- SHA1 and MD5 OK
- signatures OK
- gz and zip for sources consistent
- source dist consistent with svn tag
- config.guess and config.sub from apr 1.5.2 (copied by buildconf)
  2 years old, not so nice but still OK.
- VERSIONS says OpenSSL 1.0.2h and APR 1.5.2
- recreated release with jnirelease script, results are
  consistent with source dist, except for minor expected diffs in
  CHANGELOG.txt and generated docs
- make succeeds and builds lib
  - no C warnings
- tcnative tests OK
- unit test results for TC trunk (apr, nio and nio2)

  - Tests failing for all connectors
and all platforms:
  - org.apache.tomcat.util.net.openssl.ciphers.TestCipher
  - org.apache.tomcat.util.net.openssl.ciphers.
TestOpenSSLCipherConfigurationParser

  - no further Tests fail on Solaris

  - Tests failing on both Linux distributions for all connectors
  - org.apache.catalina.core.TestAsyncContextImpl
(all failures in TesterAccessLogValve.validateAccessLog
 line 93, so I'll add test.relaxTiming="true" next time).

  - Tests failing for RHEL 6
- NIO2:

  - org.apache.catalina.tribes.group.TestGroupChannelMemberArrival

Testcase: testMemberArrival took 15.511 sec
FAILED
Checking member arrival length for [Listener-10]. Was [8] but should 
have been [9]
Checking member arrival length for [Listener-6]. Was [8] but should have 
been [9]
Checking member arrival length for [Listener-5]. Was [8] but should have 
been [9]
junit.framework.AssertionFailedError: Checking member arrival length for 
[Listener-10]. Was [8] but should have been [9]
Checking member arrival length for [Listener-6]. Was [8] but should have 
been [9]
Checking member arrival length for [Listener-5]. Was [8] but should have 
been [9]
at 
org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.testMemberArrival(TestGroupChannelMemberArrival.java:94)


  - org.apache.catalina.tribes.group.interceptors.
TestOrderInterceptor

Testcase: testOrder1 took 17.577 sec
FAILED
null
junit.framework.AssertionFailedError
at 
org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.testOrder1(TestOrderInterceptor.java:96)


  - org.apache.tomcat.websocket.TestWsWebSocketContainer

Testcase: testWriteTimeoutClientEndpoint took 12.32 sec
FAILED
Time out was [11836] ms
junit.framework.AssertionFailedError: Time out was [11836] ms
at 
org.apache.tomcat.websocket.TestWsWebSocketContainer.doTestWriteTimeoutClient(TestWsWebSocketContainer.java:374)
at 
org.apache.tomcat.websocket.TestWsWebSocketContainer.testWriteTimeoutClientEndpoint(TestWsWebSocketContainer.java:309)


- APR:
  - org.apache.coyote.http2.TestHttp2Section_5_1
(JVM Crash see below)

  - Tests failing on SLES 11:
- APR
  - org.apache.catalina.nonblocking.TestNonBlockingAPI
(JVM Crash see below)
  - org.apache.tomcat.websocket.TestWsWebSocketContainer

Testcase: testSessionExpirySession took 12.25 sec
FAILED
expected:<1> but was:<0>
junit.framework.AssertionFailedError: expected:<1> but was:<0>
at 
org.apache.tomcat.websocket.TestWsWebSocketContainer.testSessionExpirySession(TestWsWebSocketContainer.java:768)



Info about the crashes:

I checked the stacks and both times the crash happened in:

#0 0x003f6d232a45 in raise () from /lib64/libc.so.6
#1 0x003f6d234225 in abort () from /lib64/libc.so.6
#2 0x003f6d22b9d5 in __assert_fail () from /lib64/libc.so.6
#3 0x7fcde806946a in Java_org_apache_tomcat_jni_Socket_timeoutSet 
(e=, o=, sock=out>,

timeout=) at src/network.c:1188

although it happened for different tests and different machines. Both on 
64 Bit Linux distributions. There's no Hot Spot error file. The line 
thta triggers the assertion is:


1188 TCN_ASSERT(s->opaque != NULL);

The crash on RHEL in org.apache.coyote.http2.TestHttp2Section_5_1 
happens at the end of the first unit test after the stopping message, 
but before the

svn commit: r1742452 - /tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

2016-05-05 Thread markt 
Author: markt
Date: Thu May  5 16:34:07 2016
New Revision: 1742452

URL: http://svn.apache.org/viewvc?rev=1742452=rev
Log:
Correct version info for 8.0.x

Modified:
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml?rev=1742452=1742451=1742452=diff
==
--- tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml Thu May  5 16:34:07 2016
@@ -166,7 +166,7 @@
   
 Remove the java2DDisposerProtection option from the
 JreMemoryLeakPreventionListener. The leak is fixed in Java
-7 onwards and Tomcat 9 requires Java 8 so the option is unnecessary.
+7 onwards and Tomcat 8 requires Java 7 so the option is unnecessary.
 (markt)
   
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1742450 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java webapps/docs/changelog.xml webapps/docs/config/listeners.xml

2016-05-05 Thread markt 
Author: markt
Date: Thu May  5 16:32:55 2016
New Revision: 1742450

URL: http://svn.apache.org/viewvc?rev=1742450=rev
Log:
Remove unnecessary code

Modified:
tomcat/tc8.0.x/trunk/   (props changed)

tomcat/tc8.0.x/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml
tomcat/tc8.0.x/trunk/webapps/docs/config/listeners.xml

Propchange: tomcat/tc8.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu May  5 16:32:55 2016
@@ -1,2 +1,2 @@
 /tomcat/tc8.5.x/trunk:1735042,1737966
-/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1637890,1637892,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886
 
,1644890,1644892,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657
 
592,1657607,1657609,1657682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659174,1659184,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661770,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662696,1662736,1662985,1662988-1662989,1663264,1663277,1663298,1663534,1663562,1663676,1663715,1663754,1663768,1663772,1663781,1663893,1663995,1664143,1664163,1664174,1664301,1664317,1664347,1664657,1664659,1664710,1664863-1664864,1664866,1665085,1665292,1665559,1665653,1665661,1665672,1665694,1665697,1665736,1665779,1665976-1665977,1665980-1665981,1665985-1665986,1665989,1665998,1666004,1666008,1666013,1666017,1666024,1666116,1666386-1
 
666387,1666494,1666496,1666552,1666569,1666579,137,149,1666757,1666966,1666972,1666985,1666995,1666997,1667292,1667402,1667406,1667546,1667615,1667630,1667636,1667688,1667764,1667871,1668026,1668135,1668193,1668593,1668596,1668630,1668639,1668843,1669353,1669370,1669451,1669800,1669838,1669876,1669882,1670394,1670433,1670591,1670598-1670600,1670610,1670631,1670719,1670724,1670726,1670730,1670940,1671112,1672272,1672284,1673754,1674294,1675461,1675486,1675594,1675830,1676231,1676250-1676251,1676364,1676381,1676393,1676479,1676525,1676552,1676615,1676630,1676634,1676721,1676926,1676943,1677140,1677802,1678011,1678162,1678174,1678339,1678426-1678427,1678694,1678701,1679534,1679708,1679710,1679716,1680034,1680246,1681056,1681123,1681138,1681280,1681283,1681286,1681450,1681697,1681699,1681701,1681729,1681770,1681779,1681793,1681807,1681837-1681838,1681854,1681862,1681958,1682028,1682033,1682311,1682315,1682317,1682320,1682324,1682330,1682842,1684172,1684366,1684383,1684526-168452

svn commit: r1742451 - /tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

2016-05-05 Thread markt 
Author: markt
Date: Thu May  5 16:33:39 2016
New Revision: 1742451

URL: http://svn.apache.org/viewvc?rev=1742451=rev
Log:
Correct version info for 8.5.x

Modified:
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml?rev=1742451=1742450=1742451=diff
==
--- tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml Thu May  5 16:33:39 2016
@@ -179,7 +179,7 @@
   
 Remove the java2DDisposerProtection option from the
 JreMemoryLeakPreventionListener. The leak is fixed in Java
-7 onwards and Tomcat 9 requires Java 8 so the option is unnecessary.
+7 onwards and Tomcat 8 requires Java 7 so the option is unnecessary.
 (markt)
   
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1742449 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java webapps/docs/changelog.xml webapps/docs/config/listeners.xml

2016-05-05 Thread markt 
Author: markt
Date: Thu May  5 16:32:34 2016
New Revision: 1742449

URL: http://svn.apache.org/viewvc?rev=1742449=rev
Log:
Remove unnecessary code

Modified:
tomcat/tc8.5.x/trunk/   (props changed)

tomcat/tc8.5.x/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml
tomcat/tc8.5.x/trunk/webapps/docs/config/listeners.xml

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu May  5 16:32:34 2016
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501,1741677
 
,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387
+/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501,1741677
 
,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448

Modified: 
tomcat/tc8.5.x/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java?rev=1742449=1742448=1742449=diff
==
--- 
tomcat/tc8.5.x/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java
 (original)
+++ 
tomcat/tc8.5.x/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java
 Thu May  5 16:32:34 2016
@@ -90,19 +90,6 @@ public class JreMemoryLeakPreventionList
 }
 
 /**
- * Protect against the memory leak caused when the
- * sun.java2d.Disposer class is loaded by a web application.
- * Defaults to false because a new Thread is launched.
- */
-private boolean java2dDisposerProtection = false;
-public boolean isJava2DDisposerProtection() {
-return java2dDisposerProtection;
-}
-public void setJava2DDisposerProtection(boolean java2dDisposerProtection) {
-this.java2dDisposerProtection = java2dDisposerProtection;
-}
-
-/**
  * Protect against the memory leak caused when the first call to
  * sun.misc.GC.requestLatency(long) is triggered by a web
  * application. This first call will start a GC Daemon thread with the
@@ -281,17 +268,6 @@ public class JreMemoryLeakPreventionList
 java.awt.Toolkit.getDefaultToolkit();
 }
 
-// Trigger the creation of the "Java2D Disposer" thread.
-// See https://bz.apache.org/bugzilla/show_bug.cgi?id=51687
-if(java2dDisposerProtection) {
-try {
-Class.forName("sun.java2d.Disposer");
-} catch (ClassNotFoundException cnfe) {
-// Ignore this case: we must be running on a
-//

svn commit: r1742448 - in /tomcat/trunk: java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java webapps/docs/changelog.xml webapps/docs/config/listeners.xml

2016-05-05 Thread markt 
Author: markt
Date: Thu May  5 16:31:48 2016
New Revision: 1742448

URL: http://svn.apache.org/viewvc?rev=1742448=rev
Log:
Remove unnecessary code

Modified:

tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java
tomcat/trunk/webapps/docs/changelog.xml
tomcat/trunk/webapps/docs/config/listeners.xml

Modified: 
tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java?rev=1742448=1742447=1742448=diff
==
--- 
tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java 
(original)
+++ 
tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java 
Thu May  5 16:31:48 2016
@@ -75,19 +75,6 @@ public class JreMemoryLeakPreventionList
 }
 
 /**
- * Protect against the memory leak caused when the
- * sun.java2d.Disposer class is loaded by a web application.
- * Defaults to false because a new Thread is launched.
- */
-private boolean java2dDisposerProtection = false;
-public boolean isJava2DDisposerProtection() {
-return java2dDisposerProtection;
-}
-public void setJava2DDisposerProtection(boolean java2dDisposerProtection) {
-this.java2dDisposerProtection = java2dDisposerProtection;
-}
-
-/**
  * Protect against the memory leak caused when the first call to
  * sun.misc.GC.requestLatency(long) is triggered by a web
  * application. This first call will start a GC Daemon thread with the
@@ -240,17 +227,6 @@ public class JreMemoryLeakPreventionList
 java.awt.Toolkit.getDefaultToolkit();
 }
 
-// Trigger the creation of the "Java2D Disposer" thread.
-// See https://bz.apache.org/bugzilla/show_bug.cgi?id=51687
-if(java2dDisposerProtection) {
-try {
-Class.forName("sun.java2d.Disposer");
-} catch (ClassNotFoundException cnfe) {
-// Ignore this case: we must be running on a
-// non-Sun-based JRE.
-}
-}
-
 /*
  * Several components end up calling
  * sun.misc.GC.requestLatency(long) which creates a daemon

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1742448=1742447=1742448=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Thu May  5 16:31:48 2016
@@ -181,6 +181,12 @@
 the contents of WEB-INF/classes as a possible exploded 
JAR.
 (markt)
   
+  
+Remove the java2DDisposerProtection option from the
+JreMemoryLeakPreventionListener. The leak is fixed in Java
+7 onwards and Tomcat 9 requires Java 8 so the option is unnecessary.
+(markt)
+  
 
   
   

Modified: tomcat/trunk/webapps/docs/config/listeners.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/listeners.xml?rev=1742448=1742447=1742448=diff
==
--- tomcat/trunk/webapps/docs/config/listeners.xml (original)
+++ tomcat/trunk/webapps/docs/config/listeners.xml Thu May  5 16:31:48 2016
@@ -213,13 +213,6 @@
 startup on non-Sun JVMs. The default is true.
   
 
-  
-Enables protection so that loading the
-sun.java2d.Disposer class by a web application does not
-result in a memory leak.
-Defaults to false because a thread is launched.
-  
-
   
 Enables protection so that the PoolCleaner thread started by
 com.sun.jndi.ldap.LdapPoolManager does not result in a



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[jira] [Commented] (MTOMCAT-263) tomcat7:exec-war can't create .extract/webapps

2016-05-05 Thread Patrick Wiltrout (JIRA) 

[ 
https://issues.apache.org/jira/browse/MTOMCAT-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272527#comment-15272527
 ] 

Patrick Wiltrout commented on MTOMCAT-263:
--

Olivier,
I am also waiting on the 2.3 release, any timelines around that?

> tomcat7:exec-war can't create .extract/webapps
> --
>
> Key: MTOMCAT-263
> URL: https://issues.apache.org/jira/browse/MTOMCAT-263
> Project: Apache Tomcat Maven Plugin
>  Issue Type: Bug
>Affects Versions: 2.1, 2.2
>Reporter: jieryn
>Assignee: Olivier Lamy (*$^¨%`£)
> Fix For: 3.0
>
> Attachments: MTOMCAT-263_1.patch
>
>
> bash$ java -jar target/app-1.0-SNAPSHOT-war-exec.jar
> Exception in thread "main" java.lang.Exception: FATAL: impossible to create 
> directories:.extract/webapps
> at 
> org.apache.tomcat.maven.runner.Tomcat7Runner.extract(Tomcat7Runner.java:586)
> at 
> org.apache.tomcat.maven.runner.Tomcat7Runner.run(Tomcat7Runner.java:204)
> at 
> org.apache.tomcat.maven.runner.Tomcat7RunnerCli.main(Tomcat7RunnerCli.java:212)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1742433 - /tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/compat/Jre6Compat.java

2016-05-05 Thread markt 
Author: markt
Date: Thu May  5 14:39:17 2016
New Revision: 1742433

URL: http://svn.apache.org/viewvc?rev=1742433=rev
Log:
Reduce visibility

Modified:
tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/compat/Jre6Compat.java

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/compat/Jre6Compat.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/compat/Jre6Compat.java?rev=1742433=1742432=1742433=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/compat/Jre6Compat.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/compat/Jre6Compat.java Thu 
May  5 14:39:17 2016
@@ -16,7 +16,7 @@
  */
 package org.apache.tomcat.util.compat;
 
-public class Jre6Compat extends JreCompat {
+class Jre6Compat extends JreCompat {
 
 protected static final Class sslParametersClass;
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1742432 - /tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/compat/JreCompat.java

2016-05-05 Thread markt 
Author: markt
Date: Thu May  5 14:38:02 2016
New Revision: 1742432

URL: http://svn.apache.org/viewvc?rev=1742432=rev
Log:
Correct comment

Modified:
tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/compat/JreCompat.java

Modified: tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/compat/JreCompat.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/compat/JreCompat.java?rev=1742432=1742431=1742432=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/compat/JreCompat.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/compat/JreCompat.java Thu 
May  5 14:38:02 2016
@@ -25,7 +25,7 @@ import org.apache.tomcat.util.res.String
 
 /**
  * This is the base implementation class for JRE compatibility and provides an
- * implementation based on Java 6. Sub-classes may extend this class and 
provide
+ * implementation based on Java 5. Sub-classes may extend this class and 
provide
  * alternative implementations for later JRE versions
  */
 public class JreCompat {



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat Native 1.2.7

2016-05-05 Thread Mark Thomas 
On 04/05/2016 10:42, Mark Thomas wrote:
> Version 1.2.7 includes the following changes:
> 
> - Windows binaries rebuild with OpenSSL 1.0.2h
> 
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
> 
> The Apache Tomcat Native 1.2.7 is
>  [X] Stable, go ahead and release
>  [ ] Broken because of ...

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 59431] Websocket memory leak org.apache.tomcat.websocket.server.WsFrameServer

2016-05-05 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=59431

--- Comment #2 from hugo.lar...@yahoo.com ---
Hi,

How can you tell that they are eligible for GC?

Additionally when I made the dump i had 30 sessions but even the active
sessions could not allocate 5MB each

This it what MAT say in the problem suspect tab:
103 instances of "org.apache.tomcat.websocket.server.WsFrameServer", loaded by
"org.apache.catalina.loader.StandardClassLoader @ 0xcd11dbe0" occupy 543 285
448 (92,59%) bytes. 

Keywords
org.apache.tomcat.websocket.server.WsFrameServer
org.apache.catalina.loader.StandardClassLoader @ 0xcd11dbe0

I dont think MAT would classify the object as suspects if they are eligible for
GC.

I really wish that I could reproduce the leak.

Thanks,
Hugo

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 59431] Websocket memory leak org.apache.tomcat.websocket.server.WsFrameServer

2016-05-05 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=59431

Mark Thomas  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEW |RESOLVED

--- Comment #1 from Mark Thomas  ---
The attached image shows that the WsFrameServer object has no GC root and is
therefore eligible for GC.

A quick test with the latest 7.0.x code with YourKit shows WsFrameServer
objects in memory but all of them are eligible for GC.

For this type of bug report to be valid, you need to provide a reproducible
test case that results in one or more WsFrameServer objects in memory and not
eligible for GC with no active WebSocket conenctions.

The users list is the best place to debug the memory issues you are
experiencing.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1742388 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/coyote/AsyncStateMachine.java webapps/docs/changelog.xml

2016-05-05 Thread markt 
Author: markt
Date: Thu May  5 09:25:53 2016
New Revision: 1742388

URL: http://svn.apache.org/viewvc?rev=1742388=rev
Log:
Always clear the nonBlocking listeners on complete. If complete is called from 
a non-container thread a number of states are possible. It is more robust to 
always clear the listeners.

Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/java/org/apache/coyote/AsyncStateMachine.java
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu May  5 09:25:53 2016
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501,1741677
 
,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369
+/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501,1741677
 
,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387

Modified: tomcat/tc8.5.x/trunk/java/org/apache/coyote/AsyncStateMachine.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/coyote/AsyncStateMachine.java?rev=1742388=1742387=1742388=diff
==
--- tomcat/tc8.5.x/trunk/java/org/apache/coyote/AsyncStateMachine.java [UTF-8] 
(original)
+++ tomcat/tc8.5.x/trunk/java/org/apache/coyote/AsyncStateMachine.java [UTF-8] 
Thu May  5 09:25:53 2016
@@ -272,6 +272,7 @@ public class AsyncStateMachine {
 
 public synchronized boolean asyncComplete() {
 pauseNonContainerThread();
+clearNonBlockingListeners();
 boolean doComplete = false;
 if (state == AsyncState.STARTING) {
 state = AsyncState.MUST_COMPLETE;
@@ -282,7 +283,6 @@ public class AsyncStateMachine {
 state == AsyncState.ERROR) {
 state = AsyncState.MUST_COMPLETE;
 } else if (state == AsyncState.READ_WRITE_OP) {
-clearNonBlockingListeners();
 state = AsyncState.MUST_COMPLETE;
 } else {
 throw new IllegalStateException(

Modified: tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml?rev=1742388=1742387=1742388=diff
==
--- tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml Thu May  5 09:25:53 2016
@@ -231,6 +231,10 @@
   
 59421: Add direct HTTP/2 connection support. (remm)
   
+  
+Correctly handle a call to AsyncContext.complete() from a
+non-container thread when non-blocking I/O is being used. (markt)
+

svn commit: r1742387 - in /tomcat/trunk: java/org/apache/coyote/AsyncStateMachine.java webapps/docs/changelog.xml

2016-05-05 Thread markt 
Author: markt
Date: Thu May  5 09:25:19 2016
New Revision: 1742387

URL: http://svn.apache.org/viewvc?rev=1742387=rev
Log:
Always clear the nonBlocking listeners on complete. If complete is called from 
a non-container thread a number of states are possible. It is more robust to 
always clear the listeners.

Modified:
tomcat/trunk/java/org/apache/coyote/AsyncStateMachine.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/coyote/AsyncStateMachine.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/AsyncStateMachine.java?rev=1742387=1742386=1742387=diff
==
--- tomcat/trunk/java/org/apache/coyote/AsyncStateMachine.java [UTF-8] 
(original)
+++ tomcat/trunk/java/org/apache/coyote/AsyncStateMachine.java [UTF-8] Thu May  
5 09:25:19 2016
@@ -272,6 +272,7 @@ public class AsyncStateMachine {
 
 public synchronized boolean asyncComplete() {
 pauseNonContainerThread();
+clearNonBlockingListeners();
 boolean doComplete = false;
 if (state == AsyncState.STARTING) {
 state = AsyncState.MUST_COMPLETE;
@@ -282,7 +283,6 @@ public class AsyncStateMachine {
 state == AsyncState.ERROR) {
 state = AsyncState.MUST_COMPLETE;
 } else if (state == AsyncState.READ_WRITE_OP) {
-clearNonBlockingListeners();
 state = AsyncState.MUST_COMPLETE;
 } else {
 throw new IllegalStateException(

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1742387=1742386=1742387=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Thu May  5 09:25:19 2016
@@ -238,6 +238,10 @@
   
 59421: Add direct HTTP/2 connection support. (remm)
   
+  
+Correctly handle a call to AsyncContext.complete() from a
+non-container thread when non-blocking I/O is being used. (markt)
+  
 
   
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1742372 - in /tomcat/tc7.0.x/trunk: BUILDING.txt build.xml test/org/apache/catalina/valves/TesterAccessLogValve.java

2016-05-05 Thread markt 
Author: markt
Date: Thu May  5 08:18:12 2016
New Revision: 1742372

URL: http://svn.apache.org/viewvc?rev=1742372=rev
Log:
Back-port test configuration option to relax timing constraints (required for 
Gump tests)

Modified:
tomcat/tc7.0.x/trunk/BUILDING.txt
tomcat/tc7.0.x/trunk/build.xml

tomcat/tc7.0.x/trunk/test/org/apache/catalina/valves/TesterAccessLogValve.java

Modified: tomcat/tc7.0.x/trunk/BUILDING.txt
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/BUILDING.txt?rev=1742372=1742371=1742372=diff
==
--- tomcat/tc7.0.x/trunk/BUILDING.txt (original)
+++ tomcat/tc7.0.x/trunk/BUILDING.txt Thu May  5 08:18:12 2016
@@ -415,20 +415,27 @@ For example:
 
 junit.formatter.usefile=false
 
- 5. Optional support is provided for the Cobertura code coverage tool. It
- can be enabled using the following property:
+ 5. Optional support is provided for the Cobertura code coverage tool.
 
+* NOTE: Cobertura is licensed under GPL v2 with parts of it being under
+  Apache License v1.1. See http://cobertura.sf.net for details. Using it
+  during Tomcat build is optional and is off by default.
+
+ Cobertura can be enabled using the following property:
+ 
 test.cobertura=true
 
  The report files by default are written to
 
 output/coverage
 
-* NOTE: Cobertura is licensed under GPL v2 with parts of it being under
-  Apache License v1.1. See http://cobertura.sf.net for details. Using it
-  during Tomcat build is optional and is off by default.
+ 6. Some tests include checks that the access log valve entries are as 
expected.
+These checks include timings. On slower / loaded systems these checks will
+often fail. The checks may be relaxed by using the following property:
+
+test.relaxTiming=true
 
- 6. It is known that some platforms (e.g. OSX El Capitan) require IPv4 to
+ 7. It is known that some platforms (e.g. OSX El Capitan) require IPv4 to
 be the default for the multicast tests to work. This is configured by
 the following property:
 

Modified: tomcat/tc7.0.x/trunk/build.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/build.xml?rev=1742372=1742371=1742372=diff
==
--- tomcat/tc7.0.x/trunk/build.xml (original)
+++ tomcat/tc7.0.x/trunk/build.xml Thu May  5 08:18:12 2016
@@ -69,6 +69,7 @@
   
   
   
+  
   
   
   
@@ -170,6 +171,7 @@
   
   
   
+  
   
   
   
@@ -1440,6 +1442,7 @@
 
 
 
+
 
 
 

Modified: 
tomcat/tc7.0.x/trunk/test/org/apache/catalina/valves/TesterAccessLogValve.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/test/org/apache/catalina/valves/TesterAccessLogValve.java?rev=1742372=1742371=1742372=diff
==
--- 
tomcat/tc7.0.x/trunk/test/org/apache/catalina/valves/TesterAccessLogValve.java 
(original)
+++ 
tomcat/tc7.0.x/trunk/test/org/apache/catalina/valves/TesterAccessLogValve.java 
Thu May  5 08:18:12 2016
@@ -31,8 +31,10 @@ import org.apache.catalina.connector.Res
 
 public class TesterAccessLogValve extends ValveBase implements AccessLog {
 
-// Timing tests need a small error margin to prevent failures
-private static final long ERROR_MARGIN = 100;
+private static final boolean RELAX_TIMING = 
Boolean.getBoolean("tomcat.test.relaxTiming");
+
+// Timing tests need an error margin to prevent failures.
+private static final long ERROR_MARGIN = RELAX_TIMING ? 2000 : 100;
 
 private final Queue entries = new ConcurrentLinkedQueue();
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1742370 - in /tomcat/tc8.5.x/trunk: ./ test/org/apache/tomcat/util/scan/TestStandardJarScanner.java

2016-05-05 Thread markt 
Author: markt
Date: Thu May  5 08:04:08 2016
New Revision: 1742370

URL: http://svn.apache.org/viewvc?rev=1742370=rev
Log:
Address Gump failure

Modified:
tomcat/tc8.5.x/trunk/   (props changed)

tomcat/tc8.5.x/trunk/test/org/apache/tomcat/util/scan/TestStandardJarScanner.java

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu May  5 08:04:08 2016
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501,1741677
 
,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276
+/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501,1741677
 
,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369

Modified: 
tomcat/tc8.5.x/trunk/test/org/apache/tomcat/util/scan/TestStandardJarScanner.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/test/org/apache/tomcat/util/scan/TestStandardJarScanner.java?rev=1742370=1742369=1742370=diff
==
--- 
tomcat/tc8.5.x/trunk/test/org/apache/tomcat/util/scan/TestStandardJarScanner.java
 (original)
+++ 
tomcat/tc8.5.x/trunk/test/org/apache/tomcat/util/scan/TestStandardJarScanner.java
 Thu May  5 08:04:08 2016
@@ -62,7 +62,13 @@ public class TestStandardJarScanner {
 } else {
 size = urls.length;
 }
-Assert.assertEquals(size, callbacks.size());
+// Some JREs (Gump) construct a class path that includes JARs that
+// reference additional JARs via the Class-Path attribute of the
+// Manifest. These JARs are not returned in ClassLoader.getURLs().
+// Therefore, this test looks for at least as many JARs as there 
are
+// URLs but it can't check for an exact match.
+Assert.assertTrue("[" + callbacks.size() + "] callbacks but 
expected at least [" +
+size + "]", callbacks.size() >= size);
 
 } else {
 Assert.fail("Unexpected class loader type: " + 
cl.getClass().getName());



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1742371 - in /tomcat/tc8.0.x/trunk: ./ test/org/apache/tomcat/util/scan/TestStandardJarScanner.java

2016-05-05 Thread markt 
Author: markt
Date: Thu May  5 08:04:38 2016
New Revision: 1742371

URL: http://svn.apache.org/viewvc?rev=1742371=rev
Log:
Address Gump failure

Modified:
tomcat/tc8.0.x/trunk/   (props changed)

tomcat/tc8.0.x/trunk/test/org/apache/tomcat/util/scan/TestStandardJarScanner.java

Propchange: tomcat/tc8.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu May  5 08:04:38 2016
@@ -1,2 +1,2 @@
 /tomcat/tc8.5.x/trunk:1735042,1737966
-/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1637890,1637892,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886
 
,1644890,1644892,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657
 
592,1657607,1657609,1657682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659174,1659184,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661770,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662696,1662736,1662985,1662988-1662989,1663264,1663277,1663298,1663534,1663562,1663676,1663715,1663754,1663768,1663772,1663781,1663893,1663995,1664143,1664163,1664174,1664301,1664317,1664347,1664657,1664659,1664710,1664863-1664864,1664866,1665085,1665292,1665559,1665653,1665661,1665672,1665694,1665697,1665736,1665779,1665976-1665977,1665980-1665981,1665985-1665986,1665989,1665998,1666004,1666008,1666013,1666017,1666024,1666116,1666386-1
 
666387,1666494,1666496,1666552,1666569,1666579,137,149,1666757,1666966,1666972,1666985,1666995,1666997,1667292,1667402,1667406,1667546,1667615,1667630,1667636,1667688,1667764,1667871,1668026,1668135,1668193,1668593,1668596,1668630,1668639,1668843,1669353,1669370,1669451,1669800,1669838,1669876,1669882,1670394,1670433,1670591,1670598-1670600,1670610,1670631,1670719,1670724,1670726,1670730,1670940,1671112,1672272,1672284,1673754,1674294,1675461,1675486,1675594,1675830,1676231,1676250-1676251,1676364,1676381,1676393,1676479,1676525,1676552,1676615,1676630,1676634,1676721,1676926,1676943,1677140,1677802,1678011,1678162,1678174,1678339,1678426-1678427,1678694,1678701,1679534,1679708,1679710,1679716,1680034,1680246,1681056,1681123,1681138,1681280,1681283,1681286,1681450,1681697,1681699,1681701,1681729,1681770,1681779,1681793,1681807,1681837-1681838,1681854,1681862,1681958,1682028,1682033,1682311,1682315,1682317,1682320,1682324,1682330,1682842,1684172,1684366,1684383,1684526-168452

svn commit: r1742369 - /tomcat/trunk/test/org/apache/tomcat/util/scan/TestStandardJarScanner.java

2016-05-05 Thread markt 
Author: markt
Date: Thu May  5 08:03:35 2016
New Revision: 1742369

URL: http://svn.apache.org/viewvc?rev=1742369=rev
Log:
Address Gump failure

Modified:
tomcat/trunk/test/org/apache/tomcat/util/scan/TestStandardJarScanner.java

Modified: 
tomcat/trunk/test/org/apache/tomcat/util/scan/TestStandardJarScanner.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/util/scan/TestStandardJarScanner.java?rev=1742369=1742368=1742369=diff
==
--- tomcat/trunk/test/org/apache/tomcat/util/scan/TestStandardJarScanner.java 
(original)
+++ tomcat/trunk/test/org/apache/tomcat/util/scan/TestStandardJarScanner.java 
Thu May  5 08:03:35 2016
@@ -62,7 +62,13 @@ public class TestStandardJarScanner {
 } else {
 size = urls.length;
 }
-Assert.assertEquals(size, callbacks.size());
+// Some JREs (Gump) construct a class path that includes JARs that
+// reference additional JARs via the Class-Path attribute of the
+// Manifest. These JARs are not returned in ClassLoader.getURLs().
+// Therefore, this test looks for at least as many JARs as there 
are
+// URLs but it can't check for an exact match.
+Assert.assertTrue("[" + callbacks.size() + "] callbacks but 
expected at least [" +
+size + "]", callbacks.size() >= size);
 
 } else {
 Assert.fail("Unexpected class loader type: " + 
cl.getClass().getName());



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GUMP@vmgump]: Project tomcat-trunk-test-apr (in module tomcat-trunk) failed

2016-05-05 Thread Bill Barker 
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-test-apr has an issue affecting its community integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-test-apr :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-apr/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/logs-APR
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-APR/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-APR/logs]



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-apr/gump_work/build_tomcat-trunk_tomcat-trunk-test-apr.html
Work Name: build_tomcat-trunk_tomcat-trunk-test-apr (Type: Build)
Work ended in a state of : Failed
Elapsed: 37 mins 47 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.3-SNAPSHOT.jar
 -Dtest.reports=output/logs-APR 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20160505-native-src.tar.gz
 -Dexamples.sources.skip=true 
-Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar 
-Dtest.apr.loc=/srv/gump/public/workspace/tomcat-native-trunk/dest-20160505/lib 
-Dtest.relaxTiming=true 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20160505.jar
 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20160505-nat
 ive-src.tar.gz -Dtest.temp=output/test-tmp-APR -Dtest.accesslog=true 
-Dexecute.test.nio=false 
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-master/dest-20160505/bin/openssl
 -Dexecute.test.apr=true -Dtest.excludePerformance=true 
-Dexecute.test.nio2=false 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.5-SNAPSHOT.jar
 -Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jaspic-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina

[GUMP@vmgump]: Project tomcat-tc7.0.x-test-bio (in module tomcat-7.0.x) failed

2016-05-05 Thread Bill Barker 
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-tc7.0.x-test-bio has an issue affecting its community 
integration.
This issue affects 1 projects,
 and has been outstanding for 5 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-tc7.0.x-test-bio :  Tomcat 7.x, a web server implementing Java 
Servlet 3.0,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-test-bio/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on tomcat-tc7.0.x-dbcp exists, no need to add for property 
tomcat-dbcp-src.jar.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -DEBUG- Dependency on tomcat-tc7.0.x-dbcp exists, no need to add for property 
tomcat-dbcp.home.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-7.0.x/output/logs-BIO
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-7.0.x/output/test-tmp-BIO/logs



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-7.0.x/tomcat-tc7.0.x-test-bio/gump_work/build_tomcat-7.0.x_tomcat-tc7.0.x-test-bio.html
Work Name: build_tomcat-7.0.x_tomcat-tc7.0.x-test-bio (Type: Build)
Work ended in a state of : Failed
Elapsed: 33 mins 36 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Dbase.path=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-build-libs 
-Dcommons-pool.home=/srv/gump/public/workspace/commons-pool-1.x 
-Dtest.temp=output/test-tmp-BIO 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.3-SNAPSHOT.jar
 -Dexamples.sources.skip=true 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20160505.jar
 
-Dtomcat-dbcp-src.jar=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps/tomcat-dbcp-src.jar
 -Dtomcat-dbcp.home=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps 
-Dtest.excludePerformance=true 
-Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dcommons-dbcp.home=/srv/gump/public/workspace/commons-dbcp-1.x 
-Dexecute.test.apr=false -Dexe
 cute.test.bio=true 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20160505-native-src.tar.gz
 -Dtest.reports=output/logs-BIO 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20160505-native-src.tar.gz
 -Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar 
-Dexecute.test.nio=false -Dtest.accesslog=true 
-Dtomcat-dbcp.jar=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-deps/tomcat-dbcp-20160505.jar
 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.5-SNAPSHOT.jar
 -Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-7.0.x]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-7.0.x/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/jasper.jar:/srv/gump/public

[GUMP@vmgump]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed

2016-05-05 Thread Bill Barker 
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-test-nio2 has an issue affecting its community integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-test-nio2 :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-nio2/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/logs-NIO2
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO2/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO2/logs]



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-nio2/gump_work/build_tomcat-trunk_tomcat-trunk-test-nio2.html
Work Name: build_tomcat-trunk_tomcat-trunk-test-nio2 (Type: Build)
Work ended in a state of : Failed
Elapsed: 33 mins 37 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.3-SNAPSHOT.jar
 -Dtest.reports=output/logs-NIO2 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20160505-native-src.tar.gz
 -Dexamples.sources.skip=true 
-Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar 
-Dtest.relaxTiming=true 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20160505.jar
 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20160505-native-src.tar.gz
 -Dtest.temp=output/test-tmp-NIO2 -Dtest.accesslog=true -Dexecute
 .test.nio=false 
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-master/dest-20160505/bin/openssl
 -Dexecute.test.apr=false -Dtest.excludePerformance=true 
-Dexecute.test.nio2=true 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.5-SNAPSHOT.jar
 -Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jaspic-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina

[Bug 59431] New: Websocket memory leak org.apache.tomcat.websocket.server.WsFrameServer

2016-05-05 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=59431

Bug ID: 59431
   Summary: Websocket memory leak
org.apache.tomcat.websocket.server.WsFrameServer
   Product: Tomcat 7
   Version: 7.0.69
  Hardware: All
OS: Linux
Status: NEW
  Severity: normal
  Priority: P2
 Component: WebSocket
  Assignee: dev@tomcat.apache.org
  Reporter: hugo.lar...@yahoo.com

Created attachment 33826
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=33826=edit
image

Hello,

I have been struggling with memory problem for a while. For some reason the
memory (1,3 GB) get full after some days of usage. 

Im using websocket to send and receive queries to client connected with Tyrus
with the following function.
The WsPayload is stored in the session userproperties and later ofcourse
removed.

I have a dump file of the heap and I see with Mat abnormal amount
org.apache.tomcat.websocket.server.WsFrameServer objects each occupying 5MB.
There is no relations between amount of objects and sessions. The sessions are
about 30-70.

The dump file is 30 MB so its not possible to attache it but will attach a
screenshot of MAT 

@OnMessage
public void onMessage(Session session, final ByteBuffer message) {
try (ByteArrayInputStream ins = new  
ByteArrayInputStream(message.array());
ObjectInputStream in = new ObjectInputStream(new
GZIPInputStream(ins))){
WsPayLoad sPayLoad = (WsPayLoad) in.readObject();

WsHelper.putRespWsPayloadsSess(session, sPayLoad, message);
} catch (IOException | ClassNotFoundException e) {
e.printStackTrace();
}
}

BR,
Hugo Larson

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org