[Bug 59710] java.io.IOException: Connection timed out

2016-06-30 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=59710

hugo.lar...@yahoo.com changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

--- Comment #5 from hugo.lar...@yahoo.com ---
java.io.IOException: Connection timed out
at sun.nio.ch.FileDispatcherImpl.read0(Native Method)
at sun.nio.ch.SocketDispatcher.read(SocketDispatcher.java:39)
at sun.nio.ch.IOUtil.readIntoNativeBuffer(IOUtil.java:223)
at sun.nio.ch.IOUtil.read(IOUtil.java:192)
at sun.nio.ch.SocketChannelImpl.read(SocketChannelImpl.java:384)
at
org.apache.tomcat.util.net.SecureNioChannel.read(SecureNioChannel.java:442)
at
org.apache.coyote.http11.upgrade.NioServletInputStream.fillReadBuffer(NioServletInputStream.java:136)
at
org.apache.coyote.http11.upgrade.NioServletInputStream.doRead(NioServletInputStream.java:80)
at
org.apache.coyote.http11.upgrade.AbstractServletInputStream.read(AbstractServletInputStream.java:129)
at
org.apache.tomcat.websocket.server.WsFrameServer.onDataAvailable(WsFrameServer.java:56)
at
org.apache.tomcat.websocket.server.WsHttpUpgradeHandler$WsReadListener.onDataAvailable(WsHttpUpgradeHandler.java:204)
at
org.apache.coyote.http11.upgrade.AbstractServletInputStream.onDataAvailable(AbstractServletInputStream.java:203)
at
org.apache.coyote.http11.upgrade.AbstractProcessor.upgradeDispatch(AbstractProcessor.java:93)
at
org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:621)
at
org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1756)
at
org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1715)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at
org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
at java.lang.Thread.run(Thread.java:745)

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 59774] New: Trailing dot still present in docs of AccessLogValve

2016-06-30 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=59774

Bug ID: 59774
   Summary: Trailing dot still present in docs of AccessLogValve
   Product: Tomcat 8
   Version: 8.5.x-trunk
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P2
 Component: Documentation
  Assignee: dev@tomcat.apache.org
  Reporter: m...@normi.net

Created attachment 33997
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=33997=edit
Patch to fix ALV docs.

r1417352 moved the trailing dot in the AccessLogValve prefix to the
fileDateFormat, but did not update all docs. Attached patch does that (base of
patch is the docs directory). Should be applied to TC8, 8.5, 9 and trunk.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GUMP@vmgump]: Project tomcat-trunk-test-apr (in module tomcat-trunk) failed

2016-06-30 Thread Bill Barker 
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-test-apr has an issue affecting its community integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Timed Out'.
For reference only, the following projects are affected by this:
- tomcat-trunk-test-apr :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...


Full details are available at:

http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-apr/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -INFO- Failed with reason build timed out
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/logs-APR
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-APR/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-APR/logs]



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-apr/gump_work/build_tomcat-trunk_tomcat-trunk-test-apr.html
Work Name: build_tomcat-trunk_tomcat-trunk-test-apr (Type: Build)
Work ended in a state of : Failed
Elapsed: 1 hour 2 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.5-SNAPSHOT.jar
 -Dtest.reports=output/logs-APR 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20160630-native-src.tar.gz
 -Dexamples.sources.skip=true 
-Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar 
-Dtest.apr.loc=/srv/gump/public/workspace/tomcat-native-trunk/dest-20160630/lib 
-Dtest.relaxTiming=true 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20160630.jar
 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20160630-nat
 ive-src.tar.gz -Dtest.temp=output/test-tmp-APR -Dtest.accesslog=true 
-Dexecute.test.nio=false 
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-master/dest-20160630/bin/openssl
 -Dexecute.test.apr=true -Dtest.excludePerformance=true 
-Dexecute.test.nio2=false 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.5-SNAPSHOT.jar
 -Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jaspic-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina

Re: [VOTE] Release Apache Tomcat Native 1.2.8

2016-06-30 Thread Rémy Maucherat 
2016-06-28 22:25 GMT+02:00 Mark Thomas :

> Version 1.2.8 includes the following changes:
>
> - Fix OCSP / no OCSP status of Windows  builds
> - Improve handling of OS level EAGAIN return codes
> - Fix a potential performance problem on Linux and OSX
>
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
>
> The Apache Tomcat Native 1.2.8 is
>  [X] Stable, go ahead and release
>  [ ] Broken because of ...
>
> Good fixes, ran without issues for me.

Rémy

Re: [VOTE] Release Apache Tomcat Native 1.2.8

2016-06-30 Thread jean-frederic clere 
On 06/28/2016 10:25 PM, Mark Thomas wrote:
> Version 1.2.8 includes the following changes:
> 
> - Fix OCSP / no OCSP status of Windows  builds
> - Improve handling of OS level EAGAIN return codes
> - Fix a potential performance problem on Linux and OSX
> 
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
> 
> The Apache Tomcat Native 1.2.8 is
>  [X] Stable, go ahead and release

According to my tests there is an improvement with the apr connector
(See http://www.slideshare.net/jfclere/native-128)

Cheers

Jean-Frederic

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1750788 - /tomcat/trunk/java/org/apache/catalina/connector/Request.java

2016-06-30 Thread markt 
Author: markt
Date: Thu Jun 30 12:21:02 2016
New Revision: 1750788

URL: http://svn.apache.org/viewvc?rev=1750788=rev
Log:
Simplify. Re-use existing method rather than duplicating it.

Modified:
tomcat/trunk/java/org/apache/catalina/connector/Request.java

Modified: tomcat/trunk/java/org/apache/catalina/connector/Request.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/Request.java?rev=1750788=1750787=1750788=diff
==
--- tomcat/trunk/java/org/apache/catalina/connector/Request.java (original)
+++ tomcat/trunk/java/org/apache/catalina/connector/Request.java Thu Jun 30 
12:21:02 2016
@@ -775,12 +775,8 @@ public class Request implements HttpServ
  * @exception IOException if an input/output error occurs
  */
 public void finishRequest() throws IOException {
-// Optionally disable swallowing of additional request data.
-Context context = getContext();
-if (context != null &&
-response.getStatus() == 
HttpServletResponse.SC_REQUEST_ENTITY_TOO_LARGE &&
-!context.getSwallowAbortedUploads()) {
-coyoteRequest.action(ActionCode.DISABLE_SWALLOW_INPUT, null);
+if (response.getStatus() == 
HttpServletResponse.SC_REQUEST_ENTITY_TOO_LARGE) {
+checkSwallowInput();
 }
 }
 
@@ -2640,7 +2636,9 @@ public class Request implements HttpServ
 
 
 /**
- * Disable swallowing of remaining input if configured
+ * Check the configuration for aborted uploads and if configured to do so,
+ * disable the swallowing of any remaining input and close the connection
+ * once the response has been written.
  */
 protected void checkSwallowInput() {
 Context context = getContext();



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1750776 - /tomcat/trunk/java/org/apache/coyote/http2/Stream.java

2016-06-30 Thread markt 
Author: markt
Date: Thu Jun 30 11:50:07 2016
New Revision: 1750776

URL: http://svn.apache.org/viewvc?rev=1750776=rev
Log:
Align HTTP/2 with AJP and HTTP/1.1 and commit the response before any body data 
is written to OutputBuffer

Modified:
tomcat/trunk/java/org/apache/coyote/http2/Stream.java

Modified: tomcat/trunk/java/org/apache/coyote/http2/Stream.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http2/Stream.java?rev=1750776=1750775=1750776=diff
==
--- tomcat/trunk/java/org/apache/coyote/http2/Stream.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http2/Stream.java Thu Jun 30 11:50:07 
2016
@@ -467,6 +467,9 @@ public class Stream extends AbstractStre
 throw new IllegalStateException(
 sm.getString("stream.closed", getConnectionId(), 
getIdentifier()));
 }
+if (!coyoteResponse.isCommitted()) {
+coyoteResponse.sendHeaders();
+}
 int len = chunk.getLength();
 int offset = 0;
 while (len > 0) {
@@ -497,9 +500,6 @@ public class Stream extends AbstractStre
 getIdentifier(), Integer.toString(buffer.position()),
 Boolean.toString(writeInProgress), 
Boolean.toString(closed)));
 }
-if (!coyoteResponse.isCommitted()) {
-coyoteResponse.sendHeaders();
-}
 if (buffer.position() == 0) {
 if (closed && !endOfStreamSent) {
 // Handling this special case here is simpler than trying



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1750774 - /tomcat/trunk/java/org/apache/coyote/http11/Http11OutputBuffer.java

2016-06-30 Thread markt 
Author: markt
Date: Thu Jun 30 11:43:18 2016
New Revision: 1750774

URL: http://svn.apache.org/viewvc?rev=1750774=rev
Log:
Remove duplicate committed flag from HTTP/1.1 OutputBuffer and use the flag on 
the response (like AJP and HTTP/2 do)

Modified:
tomcat/trunk/java/org/apache/coyote/http11/Http11OutputBuffer.java

Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11OutputBuffer.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11OutputBuffer.java?rev=1750774=1750773=1750774=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/Http11OutputBuffer.java 
(original)
+++ tomcat/trunk/java/org/apache/coyote/http11/Http11OutputBuffer.java Thu Jun 
30 11:43:18 2016
@@ -60,12 +60,6 @@ public class Http11OutputBuffer implemen
 
 
 /**
- * Committed flag.
- */
-protected boolean committed;
-
-
-/**
  * Finished flag.
  */
 protected boolean finished;
@@ -129,7 +123,6 @@ public class Http11OutputBuffer implemen
 activeFilters = new OutputFilter[0];
 lastActiveFilter = -1;
 
-committed = false;
 finished = false;
 
 outputStreamOutputBuffer = new SocketOutputBuffer();
@@ -200,7 +193,7 @@ public class Http11OutputBuffer implemen
 @Override
 public int doWrite(ByteChunk chunk) throws IOException {
 
-if (!committed) {
+if (!response.isCommitted()) {
 // Send the connector a request for commit. The connector should
 // then validate the headers, send them (using sendHeaders) and
 // set the filters accordingly.
@@ -258,7 +251,7 @@ public class Http11OutputBuffer implemen
  */
 public void reset() {
 
-if (committed) {
+if (response.isCommitted()) {
 throw new IllegalStateException(sm.getString("iob.illegalreset"));
 }
 
@@ -295,7 +288,6 @@ public class Http11OutputBuffer implemen
 // Reset pointers
 pos = 0;
 lastActiveFilter = -1;
-committed = false;
 finished = false;
 byteCount = 0;
 }
@@ -327,7 +319,7 @@ public class Http11OutputBuffer implemen
 
 
 public void sendAck() throws IOException {
-if (!committed) {
+if (!response.isCommitted()) {
 socketWrapper.write(isBlocking(), Constants.ACK_BYTES, 0, 
Constants.ACK_BYTES.length);
 if (flushBuffer(true)) {
 throw new IOException(sm.getString("iob.failedwrite.ack"));
@@ -342,8 +334,6 @@ public class Http11OutputBuffer implemen
  * @throws IOException an underlying I/O error occurred
  */
 protected void commit() throws IOException {
-// The response is now committed
-committed = true;
 response.setCommitted(true);
 
 if (pos > 0) {



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1750773 - /tomcat/trunk/java/org/apache/coyote/http11/Http11OutputBuffer.java

2016-06-30 Thread markt 
Author: markt
Date: Thu Jun 30 11:37:22 2016
New Revision: 1750773

URL: http://svn.apache.org/viewvc?rev=1750773=rev
Log:
Add some final modifiers

Modified:
tomcat/trunk/java/org/apache/coyote/http11/Http11OutputBuffer.java

Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11OutputBuffer.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/Http11OutputBuffer.java?rev=1750773=1750772=1750773=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/Http11OutputBuffer.java 
(original)
+++ tomcat/trunk/java/org/apache/coyote/http11/Http11OutputBuffer.java Thu Jun 
30 11:37:22 2016
@@ -56,7 +56,7 @@ public class Http11OutputBuffer implemen
 /**
  * Associated Coyote response.
  */
-protected Response response;
+protected final Response response;
 
 
 /**
@@ -74,7 +74,7 @@ public class Http11OutputBuffer implemen
 /**
  * The buffer used for header composition.
  */
-protected byte[] headerBuffer;
+protected final byte[] headerBuffer;
 
 
 /**



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org