date:20160923

[Bug 56614] Add a switch to ignore annotations detection on tag instances for performance reason

2016-09-23 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=56614

--- Comment #11 from Dan Armstrong  ---
I have submitted a fix to this issue via a pull request on the github copy of
the source for both Tomcat 7 and Tomcat 8.  Please merged these into the main
Tomcat source repositories.

Lock contention alleviated via concurrent maps, while still maintaining the
necessary weak keys.

https://github.com/apache/tomcat70/pull/11

https://github.com/apache/tomcat85/pull/5

Please also check if the Tomcat 9 in development has the same implementation
based on WeakHashMap.  It is a serious point of lock contention under heavy
concurrency.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

RE: [PATCH] - rat-output.xml tweaks for tc8.0.x tc8.5.x trunk

2016-09-23 Thread Gavin McDonald



> -Original Message-
> From: Huxing Zhang [mailto:huxing@alibaba-inc.com]
> Sent: Friday, September 23, 2016 12:58 PM
> To: Tomcat Developers List ; gavin
> 
> Subject: Re: [PATCH] - rat-output.xml tweaks for tc8.0.x tc8.5.x trunk
> 
> Hi Gavin,
> 
> Please file the patch to trunk, and it will be backported to 8.5.x, 8.x if
> possible.

That isn’t what I meant.

There are 3 patches , one for trunk, one for 8.0 and one for 8.5 - they are all
the same file. but have different tweaks made to them. There is nothing to 
backport as such.

My question was, when filing a Bugzilla Issue - which Product do I use - I'm 
going to 
use 'Tomcat8' as that is the closest match and it gives me more Components to 
choose from - 'Documentation' being wrong but still the closest thing to what my
patch is about so using that. (To be clear the rat-excludes file being patched 
in 
all 3 versions does not get included in any release)

I created Bug 60170

HTH

Gav...

> 
> --
> From:Gavin McDonald 
> Time:2016 Sep 23 (Fri) 07:17
> To:Tomcat Developers List 
> Subject:RE: [PATCH] - rat-output.xml tweaks for tc8.0.x tc8.5.x trunk
> 
> 
> 
> 
> > -Original Message-
> > From: Christopher Schultz [mailto:ch...@christopherschultz.net]
> > Sent: Friday, September 23, 2016 3:25 AM
> > To: Tomcat Developers List 
> > Subject: Re: [PATCH] - rat-output.xml tweaks for tc8.0.x tc8.5.x trunk
> >
> > Gavin,
> >
> > On 9/22/16 1:03 AM, Gavin McDonald wrote:
> > > Please find attached 3 patches for tweaks to the rat-excludes file
> > > in trunk and the 8.0 and 8.5 branches.
> > >
> > > RAT tests are currently producing invalid xml reports due to files
> > > that should be excluded (and therefore xml parser cant convert to
> > > html for pretty reports etc)
> > >
> > > HTH
> > >
> > > Gav...
> >
> > The attachment(s) must have been stripped.
> 
> Yeah I noticed :(
> 
> > Would you like to file a BZ issue
> > and attach to that?
> 
> Sure, not sure what component to put it under. Ideas ?
> 
> The patches affect versions 8, 8.5 and trunk , which version do you want me
> to use?
> 
> Thanks
> 
> Gav...
> 
> >
> > -chris
> 
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional
> commands, e-mail: dev-h...@tomcat.apache.org
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional
> commands, e-mail: dev-h...@tomcat.apache.org
> 
> 
> 
> -
> No virus found in this message.
> Checked by AVG - www.avg.com
> Version: 2016.0.7640 / Virus Database: 4656/13064 - Release Date: 09/22/16


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60170] Tweak RAT excludes file

2016-09-23 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=60170

--- Comment #2 from Gav...  ---
Created attachment 34297
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34297=edit
patch for rat-excludes file in 8.0.x

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60170] Tweak RAT excludes file

2016-09-23 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=60170

--- Comment #1 from Gav...  ---
Created attachment 34296
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34296=edit
patch for rat-excludes file in 8.5.x

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60170] New: Tweak RAT excludes file

2016-09-23 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=60170

Bug ID: 60170
   Summary: Tweak RAT excludes file
   Product: Tomcat 8
   Version: 8.5.x-trunk
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P2
 Component: Documentation
  Assignee: dev@tomcat.apache.org
  Reporter: ga...@16degrees.com.au

Created attachment 34295
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34295=edit
patch for rat-excludes file in trunk

Please find attached to this bug 3 patches for the same file in 3 different
versions of Tomcat.

In order for the RAT tests to pass these files that do not contain license
headers anyway, need to be excluded from the tests so that a valid xml report
file can be compiled.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60169] New: ClassFormatException in processAnnotationsFile during Startup

2016-09-23 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=60169

Bug ID: 60169
   Summary: ClassFormatException in processAnnotationsFile during
Startup
   Product: Tomcat 8
   Version: 8.0.36
  Hardware: PC
OS: other
Status: NEW
  Severity: minor
  Priority: P2
 Component: Catalina
  Assignee: dev@tomcat.apache.org
  Reporter: scaj...@ca.com

Attempting to run Tomcat 8.5.036 on z/OS with 64 bit IBM Java 8 causes a
ClassFormatException in processAnnotationsFile during Startup.


Steps to Reproduce:
Start Tomcat


Actual Results:
Tomcat fails to start.  STDERR shows the following error for multiple files:

org.apache.catalina.startup.ContextConfig processAnnotationsFile
SEVERE: Unable to process file
./cai/esd/CCS14/6B/nsmem/browser/help/abrowser/idmsagent/element.class. for
annotations
org.apache.tomcat.util.bcel.classfile.ClassFormatException: It is not a Java
.class file
.at
org.apache.tomcat.util.bcel.classfile.ClassParser.readID(ClassParser.java:202)
.at
org.apache.tomcat.util.bcel.classfile.ClassParser.parse(ClassParser.java:80)
.at
org.apache.catalina.startup.ContextConfig.processAnnotationsStream(ContextConfig.java:2042)
.at
org.apache.catalina.startup.ContextConfig.processAnnotationsFile(ContextConfig.java:2025)
.at
org.apache.catalina.startup.ContextConfig.processAnnotationsFile(ContextConfig.java:2019)
.at
org.apache.catalina.startup.ContextConfig.processAnnotationsFile(ContextConfig.java:2019)
.at
org.apache.catalina.startup.ContextConfig.processAnnotationsFile(ContextConfig.java:2019)
.at
org.apache.catalina.startup.ContextConfig.processAnnotationsFile(ContextConfig.java:2019)
.at
org.apache.catalina.startup.ContextConfig.processAnnotationsFile(ContextConfig.java:2019)
.at
org.apache.catalina.startup.ContextConfig.processAnnotationsFile(ContextConfig.java:2019)
.at
org.apache.catalina.startup.ContextConfig.processAnnotationsFile(ContextConfig.java:2019)
.at
org.apache.catalina.startup.ContextConfig.processAnnotationsFile(ContextConfig.java:2019)
.at
org.apache.catalina.startup.ContextConfig.processAnnotationsFile(ContextConfig.java:2019)
org.apache.catalina.startup.ContextConfig.processAnnotationsFile(ContextConfig.java:2019)
.at
org.apache.catalina.startup.ContextConfig.processAnnotationsUrl(ContextConfig.java:1961)
.at
org.apache.catalina.startup.ContextConfig.processAnnotations(ContextConfig.java:1912)
.at
org.apache.catalina.startup.ContextConfig.webConfig(ContextConfig.java:1157)
.at
org.apache.catalina.startup.ContextConfig.configureStart(ContextConfig.java:779)
.at
org.apache.catalina.startup.ContextConfig.lifecycleEvent(ContextConfig.java:306)
.at
org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:95)
.at
org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:90)
.at
org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5202)
.at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:147)
.at
org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:725)
.at org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:701) 
.at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:717)   
.at
org.apache.catalina.startup.HostConfig.deployDirectory(HostConfig.java:1092)
.at
org.apache.catalina.startup.HostConfig$DeployDirectory.run(HostConfig.java:1834)
.at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) 
.at java.util.concurrent.FutureTask.run(FutureTask.java:267)
.at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1143)
.at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:618)
.at java.lang.Thread.run(Thread.java:785)   

SYSOUT shows:
JVMJZBL1023N Invoking org.apache.catalina.startup.Bootstrap.main()...
JVMJZBL1056I Arguments to main...
JVMJZBL1057I start   
CEE5230S The signal SIGXCPU was received.


Workaround:
In context.xml, add the following line:


This seems to prevent the scanning for annotations files since not all of our
.class files are Java .class files.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 47678] Unable to allocate shared memory when using isapi_redirect.dll as an extension and filter

2016-09-23 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=47678

Mark Thomas  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #6 from Mark Thomas  ---
I can't reproduce the double init with the current code.

A review of the svn history suggests this was fixed in r1297439.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 54117] access violation exception in isapi_redirect.dll

2016-09-23 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=54117

--- Comment #16 from Mark Thomas  ---
Mladen - Ping.

It has been rather a long time but do you happen to remember what you fixed for
this or, better still, do you still have the patch? I couldn't find a relevant
change in the svn history so I am wondering if the change was committed to svn
or not.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 57066] isapi_redirect.dll is crashing intermittently when downloading large files

2016-09-23 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=57066

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME
 OS||All

--- Comment #1 from Mark Thomas  ---
Apologies for the very delayed response to this report.

The logs confirm that you are using a modified isapi_redirect.dll file. The
line numbers are off by over 100 lines from what I'd expect to see for 1.2.37.
We have no visibility of the changes. We simply cannot provide support for
something we don't have access to.

For those of you facing similar issues reading this in the archives, I urge to
to encourage providers of such modified files to provide patches upstream for
consideration.

I've tested IIS7, ISAPI 1.2.42-dev and 9.0.x-dev (both current trunk) with ab
on a 10MB file under load and I see no errors.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1762057 - in /tomcat/jk/trunk: native/common/jk_uri_worker_map.c xdocs/miscellaneous/changelog.xml

2016-09-23 Thread markt

Author: markt
Date: Fri Sep 23 12:52:02 2016
New Revision: 1762057

URL: http://svn.apache.org/viewvc?rev=1762057=rev
Log:
Minor code clean-up and optimization

Modified:
tomcat/jk/trunk/native/common/jk_uri_worker_map.c
tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml

Modified: tomcat/jk/trunk/native/common/jk_uri_worker_map.c
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/native/common/jk_uri_worker_map.c?rev=1762057=1762056=1762057=diff
==
--- tomcat/jk/trunk/native/common/jk_uri_worker_map.c (original)
+++ tomcat/jk/trunk/native/common/jk_uri_worker_map.c Fri Sep 23 12:52:02 2016
@@ -429,6 +429,7 @@ static void extension_fix_fail_on_status
 unsigned int i;
 int j;
 int cnt = 1;
+size_t status_len;
 char *status;
 #ifdef _MT_CODE_PTHREAD
 char *lasts;
@@ -436,7 +437,8 @@ static void extension_fix_fail_on_status
 
 JK_TRACE_ENTER(l);
 
-for (i = 0; i < (unsigned int)strlen(extensions->fail_on_status_str); i++) 
{
+status_len = strlen(extensions->fail_on_status_str);
+for (i = 0; i < status_len; i++) {
 if (extensions->fail_on_status_str[i] == ',' ||
 extensions->fail_on_status_str[i] == ' ')
 cnt++;
@@ -1073,6 +1075,8 @@ const char *map_uri_to_worker_ext(jk_uri
 unsigned int vhost_len;
 int reject_unsafe;
 int collapse_slashes;
+size_t uri_len;
+size_t remain;
 int rv = -1;
 char  url[JK_MAX_URI_LEN+1];
 
@@ -1142,11 +1146,13 @@ const char *map_uri_to_worker_ext(jk_uri
 /* Make the copy of the provided uri and strip
  * everything after the first ';' char.
  */
-for (i = 0; i < strlen(uri); i++) {
-if (i == JK_MAX_URI_LEN) {
+uri_len = strlen(uri);
+remain = JK_MAX_URI_LEN - vhost_len;
+for (i = 0; i < uri_len; i++) {
+if (i == remain) {
 jk_log(l, JK_LOG_WARNING,
"URI %s is invalid. URI must be smaller than %d chars",
-   uri, JK_MAX_URI_LEN);
+   uri, remain);
 JK_TRACE_EXIT(l);
 return NULL;
 }

Modified: tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml?rev=1762057=1762056=1762057=diff
==
--- tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml (original)
+++ tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml Fri Sep 23 12:52:02 2016
@@ -121,6 +121,9 @@
 configured with an invalid value for JkShmFile. This causes the server
 startup to fail. (markt)
   
+  
+Minor code clean-up and optimization. (markt)
+  
 
   
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60164] Add log4j-web*.jar to tomcat.util.scan.StandardJarScanFilter.jarsToScan

2016-09-23 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=60164

--- Comment #1 from Violeta Georgieva  ---
Hi,

I see that by default we specify to scan log4j-core*.jar.
I checked this jar (the latest version) and I think we can remove it and
instead of it add log4j-web*.jar, but I don't know what the status is with
these jar files in the older versions of Log4J 2.

Wdyt?

Regards,
Violeta

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

buildbot success in on tomcat-trunk

2016-09-23 Thread buildbot

The Buildbot has detected a restored build on builder tomcat-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/1706

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
triggered this build
Build Source Stamp: [branch tomcat/trunk] 1762053
Blamelist: violetagg

Build succeeded!

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1762053 - /tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java

2016-09-23 Thread violetagg

Author: violetagg
Date: Fri Sep 23 11:38:35 2016
New Revision: 1762053

URL: http://svn.apache.org/viewvc?rev=1762053=rev
Log:
The buffer limit should be the position plus length.

Modified:
tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java

Modified: tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java?rev=1762053=1762052=1762053=diff
==
--- tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java 
(original)
+++ tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java Fri Sep 
23 11:38:35 2016
@@ -641,7 +641,7 @@ public class Http2UpgradeHandler extends
 try {
 socketWrapper.write(true, header, 0, header.length);
 int orgLimit = data.limit();
-data.limit(len);
+data.limit(data.position() + len);
 socketWrapper.write(true, data);
 data.limit(orgLimit);
 socketWrapper.flush(true);



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

buildbot failure in on tomcat-trunk

2016-09-23 Thread buildbot

The Buildbot has detected a new failure on builder tomcat-trunk while building 
. Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/1705

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
triggered this build
Build Source Stamp: [branch tomcat/trunk] 1762051
Blamelist: violetagg

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1762051 - in /tomcat/trunk/java/org/apache/coyote/http2: Http2UpgradeHandler.java Stream.java

2016-09-23 Thread violetagg

Author: violetagg
Date: Fri Sep 23 11:06:12 2016
New Revision: 1762051

URL: http://svn.apache.org/viewvc?rev=1762051=rev
Log:
When there is ByteBuffer use the new method SocketWrapperBase.write(boolean, 
ByteBuffer)

Modified:
tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java
tomcat/trunk/java/org/apache/coyote/http2/Stream.java

Modified: tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java?rev=1762051=1762050=1762051=diff
==
--- tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java 
(original)
+++ tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java Fri Sep 
23 11:06:12 2016
@@ -537,7 +537,7 @@ public class Http2UpgradeHandler extends
 ByteUtil.set31Bits(header, 5, 
stream.getIdentifier().intValue());
 try {
 socketWrapper.write(true, header, 0, header.length);
-socketWrapper.write(true, target.array(), 
target.arrayOffset(), target.limit());
+socketWrapper.write(true, target);
 socketWrapper.flush(true);
 } catch (IOException ioe) {
 handleAppInitiatedIOException(ioe);
@@ -606,7 +606,7 @@ public class Http2UpgradeHandler extends
 }
 ByteUtil.set31Bits(header, 5, 
stream.getIdentifier().intValue());
 socketWrapper.write(true, header, 0, header.length);
-socketWrapper.write(true, target.array(), 
target.arrayOffset(), target.limit());
+socketWrapper.write(true, target);
 socketWrapper.flush(true);
 }
 }
@@ -640,8 +640,10 @@ public class Http2UpgradeHandler extends
 synchronized (socketWrapper) {
 try {
 socketWrapper.write(true, header, 0, header.length);
-socketWrapper.write(true, data.array(), data.arrayOffset() + 
data.position(),
-len);
+int orgLimit = data.limit();
+data.limit(len);
+socketWrapper.write(true, data);
+data.limit(orgLimit);
 socketWrapper.flush(true);
 } catch (IOException ioe) {
 handleAppInitiatedIOException(ioe);

Modified: tomcat/trunk/java/org/apache/coyote/http2/Stream.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http2/Stream.java?rev=1762051=1762050=1762051=diff
==
--- tomcat/trunk/java/org/apache/coyote/http2/Stream.java (original)
+++ tomcat/trunk/java/org/apache/coyote/http2/Stream.java Fri Sep 23 11:06:12 
2016
@@ -555,7 +555,6 @@ public class Stream extends AbstractStre
 !writeInProgress && closed && left == 
connectionReservation);
 streamReservation -= connectionReservation;
 left -= connectionReservation;
-buffer.position(buffer.position() + connectionReservation);
 }
 }
 buffer.clear();



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60161] RewriteValve: Add more logging support similar to mod-rewrite

2016-09-23 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=60161

--- Comment #10 from Santhana Preethi  ---
(In reply to Remy Maucherat from comment #9)
> 
> Since the issue is about configuring the valve logging, I have a possible
> patch for that. It allows creating subcategories for the container logger,
> and exploits the ValveBase.containerLog field to use that other logger.

The proposed patch does allow adjusting the log level of ONLY the RewriteValve.
It is definitely better than the current situation. 

(In reply to Remy Maucherat from comment #8)
>
> I also don't see what the processing time is used for in a sub component,
> this screams like a feature from 15 years ago [use a debugger instead].

Often, Url Rewriting involves complex regex matching. Logging the processing
time for the rewrite will be useful for debugging any slow requests. Also,
httpd already logs the rules applied for every URI at a higher log level (3 and
above).

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[VOTE] Release Apache Tomcat Native 1.2.9

2016-09-23 Thread Mark Thomas

Version 1.2.9 includes the following change:

- Update minimum recommended OpenSSL version to 1.0.2i
- Windows binaries built with OpenSSL 1.0.2i

The proposed release artefacts can be found at [1],
and the build was done using tag [2].

The Apache Tomcat Native 1.2.9 is
 [ ] Stable, go ahead and release
 [ ] Broken because of ...

Thanks,

Mark


[1]
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/1.2.9/
[2] https://svn.apache.org/repos/asf/tomcat/native/tags/TOMCAT_NATIVE_1_2_9

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r15504 - in /dev/tomcat/tomcat-connectors/native/1.2.9: ./ binaries/ source/

2016-09-23 Thread markt

Author: markt
Date: Fri Sep 23 09:43:30 2016
New Revision: 15504

Log:
Upload Tomcat Native 1.2.9 for voting

Added:
dev/tomcat/tomcat-connectors/native/1.2.9/
dev/tomcat/tomcat-connectors/native/1.2.9/binaries/

dev/tomcat/tomcat-connectors/native/1.2.9/binaries/tomcat-native-1.2.9-ocsp-win32-bin.zip
   (with props)

dev/tomcat/tomcat-connectors/native/1.2.9/binaries/tomcat-native-1.2.9-ocsp-win32-bin.zip.asc

dev/tomcat/tomcat-connectors/native/1.2.9/binaries/tomcat-native-1.2.9-ocsp-win32-bin.zip.md5

dev/tomcat/tomcat-connectors/native/1.2.9/binaries/tomcat-native-1.2.9-ocsp-win32-bin.zip.sha1

dev/tomcat/tomcat-connectors/native/1.2.9/binaries/tomcat-native-1.2.9-win32-bin.zip
   (with props)

dev/tomcat/tomcat-connectors/native/1.2.9/binaries/tomcat-native-1.2.9-win32-bin.zip.asc

dev/tomcat/tomcat-connectors/native/1.2.9/binaries/tomcat-native-1.2.9-win32-bin.zip.md5

dev/tomcat/tomcat-connectors/native/1.2.9/binaries/tomcat-native-1.2.9-win32-bin.zip.sha1
dev/tomcat/tomcat-connectors/native/1.2.9/source/

dev/tomcat/tomcat-connectors/native/1.2.9/source/tomcat-native-1.2.9-src.tar.gz 
  (with props)

dev/tomcat/tomcat-connectors/native/1.2.9/source/tomcat-native-1.2.9-src.tar.gz.asc

dev/tomcat/tomcat-connectors/native/1.2.9/source/tomcat-native-1.2.9-src.tar.gz.md5

dev/tomcat/tomcat-connectors/native/1.2.9/source/tomcat-native-1.2.9-src.tar.gz.sha1

dev/tomcat/tomcat-connectors/native/1.2.9/source/tomcat-native-1.2.9-win32-src.zip
   (with props)

dev/tomcat/tomcat-connectors/native/1.2.9/source/tomcat-native-1.2.9-win32-src.zip.asc

dev/tomcat/tomcat-connectors/native/1.2.9/source/tomcat-native-1.2.9-win32-src.zip.md5

dev/tomcat/tomcat-connectors/native/1.2.9/source/tomcat-native-1.2.9-win32-src.zip.sha1

Added: 
dev/tomcat/tomcat-connectors/native/1.2.9/binaries/tomcat-native-1.2.9-ocsp-win32-bin.zip
==
Binary file - no diff available.

Propchange: 
dev/tomcat/tomcat-connectors/native/1.2.9/binaries/tomcat-native-1.2.9-ocsp-win32-bin.zip
--
svn:mime-type = application/octet-stream

Added: 
dev/tomcat/tomcat-connectors/native/1.2.9/binaries/tomcat-native-1.2.9-ocsp-win32-bin.zip.asc
==
--- 
dev/tomcat/tomcat-connectors/native/1.2.9/binaries/tomcat-native-1.2.9-ocsp-win32-bin.zip.asc
 (added)
+++ 
dev/tomcat/tomcat-connectors/native/1.2.9/binaries/tomcat-native-1.2.9-ocsp-win32-bin.zip.asc
 Fri Sep 23 09:43:30 2016
@@ -0,0 +1,17 @@
+-BEGIN PGP SIGNATURE-
+Version: GnuPG v2
+
+iQIcBAABCAAGBQJX5PflAAoJEBDAHFovYFnndWEQALo/vEPS7mMCQaUzb7Hw8yoQ
+LAUH4hN1+T8ReNDkYK/aIdAdRnaDY96BEpVO3BvtX3cGgcHEVGROxv1tQsuC+0m8
+xF6+WjA2U3SZhXEhqkdz+u11fwx4/LDwuCX41Ja53cxdT0/OL9+xH8BbgAkHhQEa
+VFxjx6ejYc6nPG2wYVvLOaluOT502DmcJJy+mbnquGeWXALlROCjjwepcMs7jqDv
+i1ylJqBz8iux4lvV7b6rHtau7aSIsJShs+XxSKZBSWTHT2F5eruG+dj0+kRwy2IO
+baF9dIUxXgRWcxy6stbuybNZ8ybHvsyPyV+YohjJvHChMI6Sqk5W3qyunM67wNzz
+dlscsJhWFKdaYiU3Kc/jzb0G3xd7bP+1K+5yVtOiQHnSqTHTD1gYkc9sUC5+A8pL
+FdblqoVAnn8FcuO1fbkNP+Q5Q+sVp6lTE8JMjiFR4YZn+Cx72XYK80cS88p+wC6k
+Ofjw3Hl0LkCoPT9NPPm7zCDRKyan6Y9KiD56ttdR/4Wlaat12qxFKXetiKV2kp1Z
+LIPh588il0vwnUZW4UPCcgJ1GWalVdfyoi0fPbJqkGXn4q+2Z3Yy/PsEoxQymd/C
+lSYI1c2Iu/xZibbg836UPCNv5AP7mVfMF0sTjrLidADq6IJMpueJ04ckAy/2O6Ma
+XfICo8Lo1y3vhoXuDQdK
+=Hkim
+-END PGP SIGNATURE-

Added: 
dev/tomcat/tomcat-connectors/native/1.2.9/binaries/tomcat-native-1.2.9-ocsp-win32-bin.zip.md5
==
--- 
dev/tomcat/tomcat-connectors/native/1.2.9/binaries/tomcat-native-1.2.9-ocsp-win32-bin.zip.md5
 (added)
+++ 
dev/tomcat/tomcat-connectors/native/1.2.9/binaries/tomcat-native-1.2.9-ocsp-win32-bin.zip.md5
 Fri Sep 23 09:43:30 2016
@@ -0,0 +1 @@
+e7018bf464760054fab9510746cacfbb *tomcat-native-1.2.9-ocsp-win32-bin.zip
\ No newline at end of file

Added: 
dev/tomcat/tomcat-connectors/native/1.2.9/binaries/tomcat-native-1.2.9-ocsp-win32-bin.zip.sha1
==
--- 
dev/tomcat/tomcat-connectors/native/1.2.9/binaries/tomcat-native-1.2.9-ocsp-win32-bin.zip.sha1
 (added)
+++ 
dev/tomcat/tomcat-connectors/native/1.2.9/binaries/tomcat-native-1.2.9-ocsp-win32-bin.zip.sha1
 Fri Sep 23 09:43:30 2016
@@ -0,0 +1 @@
+c051e46e1c72271d464b0272f0cd64efa2d1e6c3 
*tomcat-native-1.2.9-ocsp-win32-bin.zip
\ No newline at end of file

Added: 
dev/tomcat/tomcat-connectors/native/1.2.9/binaries/tomcat-native-1.2.9-win32-bin.zip
==
Binary file - no diff available.

Propchange: 
dev/tomcat/tomcat-connectors/native/1.2.9/binaries/tomcat-native-1.2.9-win32-bin.zip
--

svn commit: r1762034 - in /tomcat/native/trunk: build.properties.default native/include/tcn_version.h native/os/win32/libtcnative.rc xdocs/miscellaneous/changelog.xml

2016-09-23 Thread markt

Author: markt
Date: Fri Sep 23 08:56:12 2016
New Revision: 1762034

URL: http://svn.apache.org/viewvc?rev=1762034=rev
Log:
Prep for next tag

Modified:
tomcat/native/trunk/build.properties.default
tomcat/native/trunk/native/include/tcn_version.h
tomcat/native/trunk/native/os/win32/libtcnative.rc
tomcat/native/trunk/xdocs/miscellaneous/changelog.xml

Modified: tomcat/native/trunk/build.properties.default
URL: 
http://svn.apache.org/viewvc/tomcat/native/trunk/build.properties.default?rev=1762034=1762033=1762034=diff
==
--- tomcat/native/trunk/build.properties.default (original)
+++ tomcat/native/trunk/build.properties.default Fri Sep 23 08:56:12 2016
@@ -18,7 +18,7 @@
 # - Version Control Flags -
 version.major=1
 version.minor=2
-version.build=9
+version.build=10
 version.patch=0
 version.suffix=-dev
 

Modified: tomcat/native/trunk/native/include/tcn_version.h
URL: 
http://svn.apache.org/viewvc/tomcat/native/trunk/native/include/tcn_version.h?rev=1762034=1762033=1762034=diff
==
--- tomcat/native/trunk/native/include/tcn_version.h (original)
+++ tomcat/native/trunk/native/include/tcn_version.h Fri Sep 23 08:56:12 2016
@@ -63,7 +63,7 @@ extern "C" {
 #define TCN_MINOR_VERSION   2
 
 /** patch level */
-#define TCN_PATCH_VERSION   9
+#define TCN_PATCH_VERSION   10
 
 /**
  *  This symbol is defined for internal, "development" copies of TCN. This

Modified: tomcat/native/trunk/native/os/win32/libtcnative.rc
URL: 
http://svn.apache.org/viewvc/tomcat/native/trunk/native/os/win32/libtcnative.rc?rev=1762034=1762033=1762034=diff
==
--- tomcat/native/trunk/native/os/win32/libtcnative.rc (original)
+++ tomcat/native/trunk/native/os/win32/libtcnative.rc Fri Sep 23 08:56:12 2016
@@ -20,7 +20,7 @@ LANGUAGE 0x9,0x1
  "See the License for the specific language governing " \
  "permissions and limitations under the License."
 
-#define TCN_VERSION "1.2.9"
+#define TCN_VERSION "1.2.10"
 1000 ICON "apache.ico"
 
 1001 DIALOGEX 0, 0, 252, 51
@@ -36,8 +36,8 @@ BEGIN
 END
 
 1 VERSIONINFO
- FILEVERSION 1,2,9,0
- PRODUCTVERSION 1,2,9,0
+ FILEVERSION 1,2,10,0
+ PRODUCTVERSION 1,2,10,0
  FILEFLAGSMASK 0x3fL
 #ifdef _DEBUG
  FILEFLAGS 0x1L

Modified: tomcat/native/trunk/xdocs/miscellaneous/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/native/trunk/xdocs/miscellaneous/changelog.xml?rev=1762034=1762033=1762034=diff
==
--- tomcat/native/trunk/xdocs/miscellaneous/changelog.xml (original)
+++ tomcat/native/trunk/xdocs/miscellaneous/changelog.xml Fri Sep 23 08:56:12 
2016
@@ -34,14 +34,16 @@
   This is the Changelog for Tomcat Native 1.2.
   
 
-
+
   
+  
+
+
   
 
   Update minimum recommended OpenSSL version to 1.0.2i. (markt)
 
   
-  
 
 
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60167] New: PasswdUserDatabase cannot parsing /etc/passwd with empty-line

2016-09-23 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=60167

Bug ID: 60167
   Summary: PasswdUserDatabase cannot parsing /etc/passwd with
empty-line
   Product: Tomcat 8
   Version: 8.0.x-trunk
  Hardware: PC
OS: Linux
Status: NEW
  Severity: minor
  Priority: P2
 Component: Catalina
  Assignee: dev@tomcat.apache.org
  Reporter: sch...@gmail.com

summary:

  When PasswdUserDatabase initialize @/etc/passwd/@ with empty-line,
  cannot parsing completely.

  *
https://tomcat.apache.org/tomcat-8.0-doc/config/host.html#User_Web_Applications




my /etc/passwd:

  <...>
  lxc-dnsmasq:x:114:125:LXC dnsmasq,,,:/var/lib/lxc:/bin/false
  moodle:x:1002:1002:,,,:/home/moodle:/bin/bash
  tomcat8:x:117:126::/usr/share/tomcat8:/bin/false


  # 시스템 관리자

  jehos:x:1001:1001:성제호,,,:/home/jehos:/bin/bash
  <...>




try:
  GET http://localhost:8080/~myid

expect:
  ~myid/public_html/index.html

actual:
  404 not found

workaround:
  remove all empty-lines,
  in my case, just comment out (#)

suspect:
 
https://github.com/apache/tomcat/blob/trunk/java/org/apache/catalina/startup/PasswdUserDatabase.java#L147

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1762020 - in /tomcat/native/tags/TOMCAT_NATIVE_1_2_9: ./ build.properties.default native/include/tcn_version.h

2016-09-23 Thread markt

Author: markt
Date: Fri Sep 23 08:09:54 2016
New Revision: 1762020

URL: http://svn.apache.org/viewvc?rev=1762020=rev
Log:
Tag 1.2.9

Added:
tomcat/native/tags/TOMCAT_NATIVE_1_2_9/
  - copied from r1762019, tomcat/native/trunk/
Modified:
tomcat/native/tags/TOMCAT_NATIVE_1_2_9/build.properties.default
tomcat/native/tags/TOMCAT_NATIVE_1_2_9/native/include/tcn_version.h

Modified: tomcat/native/tags/TOMCAT_NATIVE_1_2_9/build.properties.default
URL: 
http://svn.apache.org/viewvc/tomcat/native/tags/TOMCAT_NATIVE_1_2_9/build.properties.default?rev=1762020=1762019=1762020=diff
==
--- tomcat/native/tags/TOMCAT_NATIVE_1_2_9/build.properties.default (original)
+++ tomcat/native/tags/TOMCAT_NATIVE_1_2_9/build.properties.default Fri Sep 23 
08:09:54 2016
@@ -20,7 +20,7 @@ version.major=1
 version.minor=2
 version.build=9
 version.patch=0
-version.suffix=-dev
+version.suffix=
 
 # - Default Base Path for Dependent Packages -
 # Please note this path must be absolute, not relative,

Modified: tomcat/native/tags/TOMCAT_NATIVE_1_2_9/native/include/tcn_version.h
URL: 
http://svn.apache.org/viewvc/tomcat/native/tags/TOMCAT_NATIVE_1_2_9/native/include/tcn_version.h?rev=1762020=1762019=1762020=diff
==
--- tomcat/native/tags/TOMCAT_NATIVE_1_2_9/native/include/tcn_version.h 
(original)
+++ tomcat/native/tags/TOMCAT_NATIVE_1_2_9/native/include/tcn_version.h Fri Sep 
23 08:09:54 2016
@@ -69,7 +69,7 @@ extern "C" {
  *  This symbol is defined for internal, "development" copies of TCN. This
  *  symbol will be #undef'd for releases.
  */
-#define TCN_IS_DEV_VERSION  1
+#define TCN_IS_DEV_VERSION  0
 
 
 /** The formatted string of APU's version */



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 56614] Add a switch to ignore annotations detection on tag instances for performance reason

RE: [PATCH] - rat-output.xml tweaks for tc8.0.x tc8.5.x trunk

[Bug 60170] Tweak RAT excludes file

[Bug 60170] Tweak RAT excludes file

[Bug 60170] New: Tweak RAT excludes file

[Bug 60169] New: ClassFormatException in processAnnotationsFile during Startup

[Bug 47678] Unable to allocate shared memory when using isapi_redirect.dll as an extension and filter

[Bug 54117] access violation exception in isapi_redirect.dll

[Bug 57066] isapi_redirect.dll is crashing intermittently when downloading large files

svn commit: r1762057 - in /tomcat/jk/trunk: native/common/jk_uri_worker_map.c xdocs/miscellaneous/changelog.xml

[Bug 60164] Add log4j-web*.jar to tomcat.util.scan.StandardJarScanFilter.jarsToScan

buildbot success in on tomcat-trunk

svn commit: r1762053 - /tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java

buildbot failure in on tomcat-trunk

svn commit: r1762051 - in /tomcat/trunk/java/org/apache/coyote/http2: Http2UpgradeHandler.java Stream.java

[Bug 60161] RewriteValve: Add more logging support similar to mod-rewrite

[VOTE] Release Apache Tomcat Native 1.2.9

svn commit: r15504 - in /dev/tomcat/tomcat-connectors/native/1.2.9: ./ binaries/ source/

svn commit: r1762034 - in /tomcat/native/trunk: build.properties.default native/include/tcn_version.h native/os/win32/libtcnative.rc xdocs/miscellaneous/changelog.xml

[Bug 60167] New: PasswdUserDatabase cannot parsing /etc/passwd with empty-line

svn commit: r1762020 - in /tomcat/native/tags/TOMCAT_NATIVE_1_2_9: ./ build.properties.default native/include/tcn_version.h

21 matches

Site Navigation

Mail list logo

Footer information