How to open and navigate tomcat project in IDE

[Hoa Phan]

Hi, is there a guide to open tomcat project in an IDE so that IO can
navigate through source code with all support from the IDE?

I tried to open with IntelliJ but couldn't get it to recognize the source
code.
I tried Eclipse too but got the same thing.
I tried:

*ant ide-eclipse*
but got:



















































*Buildfile:
C:\Users\hoaphan\tomcat\build.xmldownload-compile:testexist: [echo]
Testing  for
/usr/share/java/tomcat-native-1.1.29/tomcat-native.tar.gzdownloadfile-2:proxyflags:setproxy:testexist:
[echo] Testing  for
/usr/share/java/commons-daemon-1.0.15/commons-daemon-1.0.15.jardownloadgz-2:testexist:
[echo] Testing  for
/usr/share/java/commons-daemon-1.0.15/commons-daemon-1.0.15-native-src.tar.gzdownloadfile-2:proxyflags:setproxy:testexist:
[echo] Testing  for
/usr/share/java/commons-pool2-2.1-SNAPSHOT-src/build.xmldownloadgz-2:proxyflags:setproxy:trydownload.check:trydownload:proxyflags:setproxy:trydownload.check:trydownload:BUILD
FAILEDC:\Users\hoaphan\tomcat\build.xml:2583: The following error occurred
while execut*

[GUMP@vmgump-vm3]: Project tomcat-tc8.0.x-test-nio (in module tomcat-8.0.x) failed

[Bill Barker]

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-tc8.0.x-test-nio has an issue affecting its community 
integration.
This issue affects 1 projects,
 and has been outstanding for 7 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-tc8.0.x-test-nio :  Tomcat 8.x, a web server implementing the Java 
Servlet 3.1,
...


Full details are available at:
http://vmgump-vm3.apache.org/tomcat-8.0.x/tomcat-tc8.0.x-test-nio/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-8.0.x/output/logs-NIO
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-8.0.x/output/test-tmp-NIO/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-8.0.x/output/test-tmp-NIO/logs]



The following work was performed:
http://vmgump-vm3.apache.org/tomcat-8.0.x/tomcat-tc8.0.x-test-nio/gump_work/build_tomcat-8.0.x_tomcat-tc8.0.x-test-nio.html
Work Name: build_tomcat-8.0.x_tomcat-tc8.0.x-test-nio (Type: Build)
Work ended in a state of : Failed
Elapsed: 20 mins 6 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Dbase.path=/srv/gump/public/workspace/tomcat-8.0.x/tomcat-build-libs 
-Dexecute.test.nio2=false -Dtest.temp=output/test-tmp-NIO 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Dtest.accesslog=true 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.6-SNAPSHOT.jar
 -Dexamples.sources.skip=true 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20170126.jar
 
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-1.0.2/dest-20170126/bin/openssl
 -Dexecute.test.nio=true 
-Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dexecute.test.apr=false -Dexecute.test.bio=false 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20170126-native-src.tar.gz
 -Dtest.report
 s=output/logs-NIO 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20170126-native-src.tar.gz
 -Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar 
-Dtest.relaxTiming=true -Dtest.excludePerformance=true 
-Djava.net.preferIPv4Stack=/srv/gump/public/workspace/tomcat-8.0.x/true 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.5-SNAPSHOT.jar
 -Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-8.0.x]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-8.0.x/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina-tribes.jar:/srv/gump/public/wor

Re: HTTP response reason phrases

[Huxing Zhang]

Hi,

I think the problem is that how we target tomcat 8.5 to the users.
Is it a biased to 8.0, or is it biased to 9.0?

For the former case, we should keep the backward compatibility as much
as possible.
For the latter case, breaking things should be assumable by end users.

IMO, 8.5 should be the former case. However, I don't think most of the
user will be affected by this change.
Therefore the priority should be MINOR or even TRIVIAL.

Overall, I am +0 to add an option to restore the reason phase in 8.5(
a warning message should be logged if this option is turned on), and
drop the option in 9.x.

Anyway, we should note this change in 8.5 migration guide [1].

[1] http://tomcat.apache.org/migration-85.html



On Wed, Jan 25, 2017 at 3:08 AM, Christopher Schultz
 wrote:
>
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA256
>
> All,
>
> I'm cross-posting dev@ and users@, but please only reply to dev@ if
> you'd like to get involved in this discussion.
>
> I'd like to openly-discuss r1702765 [1]. There have been some
> complaints on both users@ and dev@ and some BZ issues filed against
> Tomcat 8.5 and 9.0 for removing the reason phrase. It happened in
> r1702765 with no referenced BZ issue and was first released with
> Tomcat 8.5.0 -- the initial release of Tomcat 8.5 -- as well as 9.0.0.M1
> .
>
> This issue doesn't really affect me, but some recent conversations
> about the "stability" (in terms of "things not changing") of Tomcat
> have me thinking about the implications of making this change in
> Tomcat 8.5.x and not in just Tomcat 9.0.x.
>
> It is well-known within this community that Tomcat 8.0.x and Tomcat
> 8.5.x are distinct versions, but since the major version number is the
> same, many have expectations that nothing serious is going to change.
> Of course, 8.5.x has *many* serious changes to it with respect to
> Tomcat 8.0.x. But this one seems to be tripping a lot of people up.
>
> Those who are filing bugs, etc. are quite adamant that the reason
> phrase is "required" for certain things. To be sure, the reason phrase
> will only be required by non-compliant clients, and so technically the
> client is at fault, here.
>
> I'm wondering what the wider community thinks about this change and
> whether or not we should consider reverting it for Tomcat 8.5.x.
>
> Again, please reply to the dev@ list, since that's where this
> discussion belongs. I just wanted to make sure I reached the widest
> audience possible to begin a discussion.
>
> Thanks,
> - -chris
>
> [1] http://svn.apache.org/viewvc?view=revision&revision=r1702765
> -BEGIN PGP SIGNATURE-
> Comment: GPGTools - http://gpgtools.org
> Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
>
> iQIcBAEBCAAGBQJYh6ZCAAoJEBzwKT+lPKRYnJgQAIe57jJw2iUk86I63NGsqPnY
> IKWjZoMuqd8vlczn8/FF/drWMV7ObYsrhsYmJATR5iVI+/xdEXB7n8cMO7B7+ryV
> Sxe1Tcmh/tBNJ83a8C+zSHWvnIELYRonHm9syApa7onPKcsoEe6MTrsdL1M+An9U
> 9IvXtH3BfYKAynze5pkNS6I+ILjgWvNSclJFHmDNHWmRPyqdob4OtMWkSSU3qRBX
> FfbEk9IMrEbIit6CH75dw9xfaUDDRudnw3MBkKaV8VOLUoykvSMK1w9GdufO4ohP
> Dw/+l6CkXl8xCSRcNwXrDdJcisT9gN6Ey7+g7zrgAcg62RP3ftrQMCzT2VDQV3b4
> IlZfTi+vEdsKKzGUdH+OLbN0+hiW0bnuxJmTG2zQSGwKsIh78aFdPKShv4u22XKB
> xfcKn9c6XGUHH88j0ZVSOLh2AmORCvuDfQNA3NJCOceRwQsV1OHAda65fFlkjyiz
> Q/yMMV8VlblGJRItN1nEwheIs9ru3MokRBhaXQ78ehSkRxbkIPawP6ZSiojmv/80
> aKx3/T413GOK4e18sK3XFHP4NowkR7VR/a1R5Py7L2kpzhMJcc4bstYuE9hugfiN
> BaECAT66qahCmP0xVoiFEB2A0+sD0wRKZ6K1gPCarPdLKh6cX4poRcMK4i0jgG2a
> cao/Frb1y8JDm8maw1Q8
> =oQCi
> -END PGP SIGNATURE-
>
> -
> To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: users-h...@tomcat.apache.org
>



-- 
Best Regards！

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: HTTP response reason phrases

[Rémy Maucherat]

2017-01-24 20:08 GMT+01:00 Christopher Schultz :

> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA256
>
> All,
>
> I'm cross-posting dev@ and users@, but please only reply to dev@ if
> you'd like to get involved in this discussion.
>
> I'd like to openly-discuss r1702765 [1]. There have been some
> complaints on both users@ and dev@ and some BZ issues filed against
> Tomcat 8.5 and 9.0 for removing the reason phrase. It happened in
> r1702765 with no referenced BZ issue and was first released with
> Tomcat 8.5.0 -- the initial release of Tomcat 8.5 -- as well as 9.0.0.M1
> .
>
> This issue doesn't really affect me, but some recent conversations
> about the "stability" (in terms of "things not changing") of Tomcat
> have me thinking about the implications of making this change in
> Tomcat 8.5.x and not in just Tomcat 9.0.x.
>
> It is well-known within this community that Tomcat 8.0.x and Tomcat
> 8.5.x are distinct versions, but since the major version number is the
> same, many have expectations that nothing serious is going to change.
> Of course, 8.5.x has *many* serious changes to it with respect to
> Tomcat 8.0.x. But this one seems to be tripping a lot of people up.
>

- 8.5 is already changing a number of things (since it's supposed to be 9,
so it's normal).
- the clients we're talking about are ancient.
- I only saw "a few" people affected, not "a lot".

It's better to avoid breaking things, but I don't see the benefit of
reverting it or bothering with an option.

Rémy

>
> Those who are filing bugs, etc. are quite adamant that the reason
> phrase is "required" for certain things. To be sure, the reason phrase
> will only be required by non-compliant clients, and so technically the
> client is at fault, here.
>
> I'm wondering what the wider community thinks about this change and
> whether or not we should consider reverting it for Tomcat 8.5.x.
>
> Again, please reply to the dev@ list, since that's where this
> discussion belongs. I just wanted to make sure I reached the widest
> audience possible to begin a discussion.
>
> Thanks,
> - -chris
>
> [1] http://svn.apache.org/viewvc?view=revision&revision=r1702765
> -BEGIN PGP SIGNATURE-
> Comment: GPGTools - http://gpgtools.org
> Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
>
> iQIcBAEBCAAGBQJYh6ZCAAoJEBzwKT+lPKRYnJgQAIe57jJw2iUk86I63NGsqPnY
> IKWjZoMuqd8vlczn8/FF/drWMV7ObYsrhsYmJATR5iVI+/xdEXB7n8cMO7B7+ryV
> Sxe1Tcmh/tBNJ83a8C+zSHWvnIELYRonHm9syApa7onPKcsoEe6MTrsdL1M+An9U
> 9IvXtH3BfYKAynze5pkNS6I+ILjgWvNSclJFHmDNHWmRPyqdob4OtMWkSSU3qRBX
> FfbEk9IMrEbIit6CH75dw9xfaUDDRudnw3MBkKaV8VOLUoykvSMK1w9GdufO4ohP
> Dw/+l6CkXl8xCSRcNwXrDdJcisT9gN6Ey7+g7zrgAcg62RP3ftrQMCzT2VDQV3b4
> IlZfTi+vEdsKKzGUdH+OLbN0+hiW0bnuxJmTG2zQSGwKsIh78aFdPKShv4u22XKB
> xfcKn9c6XGUHH88j0ZVSOLh2AmORCvuDfQNA3NJCOceRwQsV1OHAda65fFlkjyiz
> Q/yMMV8VlblGJRItN1nEwheIs9ru3MokRBhaXQ78ehSkRxbkIPawP6ZSiojmv/80
> aKx3/T413GOK4e18sK3XFHP4NowkR7VR/a1R5Py7L2kpzhMJcc4bstYuE9hugfiN
> BaECAT66qahCmP0xVoiFEB2A0+sD0wRKZ6K1gPCarPdLKh6cX4poRcMK4i0jgG2a
> cao/Frb1y8JDm8maw1Q8
> =oQCi
> -END PGP SIGNATURE-
>
> -
> To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: users-h...@tomcat.apache.org
>
>

svn commit: r1780275 - in /tomcat/site/trunk: docs/ xdocs/stylesheets/

[markt]

Author: markt
Date: Wed Jan 25 22:09:23 2017
New Revision: 1780275

URL: http://svn.apache.org/viewvc?rev=1780275&view=rev
Log:
First pass at adding current event ad to Tomcat site

Modified:
tomcat/site/trunk/docs/bugreport.html
tomcat/site/trunk/docs/ci.html
tomcat/site/trunk/docs/contact.html
tomcat/site/trunk/docs/download-60.html
tomcat/site/trunk/docs/download-70.html
tomcat/site/trunk/docs/download-80.html
tomcat/site/trunk/docs/download-90.html
tomcat/site/trunk/docs/download-connectors.html
tomcat/site/trunk/docs/download-native.html
tomcat/site/trunk/docs/download-taglibs.html
tomcat/site/trunk/docs/findhelp.html
tomcat/site/trunk/docs/getinvolved.html
tomcat/site/trunk/docs/heritage.html
tomcat/site/trunk/docs/index.html
tomcat/site/trunk/docs/irc.html
tomcat/site/trunk/docs/legal.html
tomcat/site/trunk/docs/lists.html
tomcat/site/trunk/docs/maven-plugin.html
tomcat/site/trunk/docs/migration-6.html
tomcat/site/trunk/docs/migration-7.html
tomcat/site/trunk/docs/migration-8.html
tomcat/site/trunk/docs/migration-85.html
tomcat/site/trunk/docs/migration-9.html
tomcat/site/trunk/docs/migration.html
tomcat/site/trunk/docs/oldnews-2010.html
tomcat/site/trunk/docs/oldnews-2011.html
tomcat/site/trunk/docs/oldnews-2012.html
tomcat/site/trunk/docs/oldnews-2013.html
tomcat/site/trunk/docs/oldnews-2014.html
tomcat/site/trunk/docs/oldnews-2015.html
tomcat/site/trunk/docs/oldnews.html
tomcat/site/trunk/docs/presentations.html
tomcat/site/trunk/docs/resources.html
tomcat/site/trunk/docs/security-3.html
tomcat/site/trunk/docs/security-4.html
tomcat/site/trunk/docs/security-5.html
tomcat/site/trunk/docs/security-6.html
tomcat/site/trunk/docs/security-7.html
tomcat/site/trunk/docs/security-8.html
tomcat/site/trunk/docs/security-9.html
tomcat/site/trunk/docs/security-impact.html
tomcat/site/trunk/docs/security-jk.html
tomcat/site/trunk/docs/security-native.html
tomcat/site/trunk/docs/security-taglibs.html
tomcat/site/trunk/docs/security.html
tomcat/site/trunk/docs/svn.html
tomcat/site/trunk/docs/taglibs.html
tomcat/site/trunk/docs/tomcat-55-eol.html
tomcat/site/trunk/docs/tomcat-60-eol.html
tomcat/site/trunk/docs/tools.html
tomcat/site/trunk/docs/whichversion.html
tomcat/site/trunk/docs/whoweare.html
tomcat/site/trunk/xdocs/stylesheets/tomcat-site.xsl

Modified: tomcat/site/trunk/docs/bugreport.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/bugreport.html?rev=1780275&r1=1780274&r2=1780275&view=diff
==
--- tomcat/site/trunk/docs/bugreport.html (original)
+++ tomcat/site/trunk/docs/bugreport.html Wed Jan 25 22:09:23 2017
@@ -17,7 +17,7 @@
 
 
 
-http://www.apache.org/"; target="_blank">
+http://www.apache.org/events/current-event.html"; target="_blank">http://www.apache.org/events/current-event-234x60.png"; alt="Upcoming 
Event" style="margin-right: 15px;">http://www.apache.org/"; 
target="_blank">
 
 Apache Tomcat®
 

Modified: tomcat/site/trunk/docs/ci.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/ci.html?rev=1780275&r1=1780274&r2=1780275&view=diff
==
--- tomcat/site/trunk/docs/ci.html (original)
+++ tomcat/site/trunk/docs/ci.html Wed Jan 25 22:09:23 2017
@@ -16,7 +16,7 @@
 
 
 
-http://www.apache.org/"; target="_blank">
+http://www.apache.org/events/current-event.html"; target="_blank">http://www.apache.org/events/current-event-234x60.png"; alt="Upcoming 
Event" style="margin-right: 15px;">http://www.apache.org/"; 
target="_blank">
 
 Apache Tomcat®
 

Modified: tomcat/site/trunk/docs/contact.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/contact.html?rev=1780275&r1=1780274&r2=1780275&view=diff
==
--- tomcat/site/trunk/docs/contact.html (original)
+++ tomcat/site/trunk/docs/contact.html Wed Jan 25 22:09:23 2017
@@ -16,7 +16,7 @@
 
 
 
-http://www.apache.org/"; target="_blank">
+http://www.apache.org/events/current-event.html"; target="_blank">http://www.apache.org/events/current-event-234x60.png"; alt="Upcoming 
Event" style="margin-right: 15px;">http://www.apache.org/"; 
target="_blank">
 
 Apache Tomcat®
 

Modified: tomcat/site/trunk/docs/download-60.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/download-60.html?rev=1780275&r1=1780274&r2=1780275&view=diff
==
--- tomcat/site/trunk/docs/download-60.html (original)
+++ tomcat/site/trunk/docs/download-60.html Wed Jan 25 22:09:23 2017
@@ -16,7 +16,7 @@
 
 
 
-http://www.apache.org/"; target="_blank">
+http://www.apache.org/events/current-event.html"; target="_blank">http://www.apache.org/events/

Re: HTTP response reason phrases

[Romain Manni-Bucau]

2017-01-25 20:51 GMT+01:00 Christopher Schultz :

> Romain,
>
> On 1/25/17 5:30 AM, Romain Manni-Bucau wrote:
> > 8.5 just being almost a N-1 spec version of tomcat 9 I think they should
> > stay aligned as much as possible.
>
> Yes, but 8.5 is a N+0 spec version of Tomcat 8.0. I think since Tomcat
> 8.5 is being pushed as the hurry-up upgrade for Tomcat 8.0, it should be
> more compatible with Tomcat 8.0 when there is a choice.
>
> I think Rainer articulated this better than I could.
>
>
I see (interesting to see that .5 is closer to 1 for some and to 0 for
others ;)).

However I think it doesn't change the fact it delay the issue for some time
so would be curious to see the actual issue having it configurable, if none
it is surely the best way to make everyone happy, no?


> On 1/25/17 5:09 AM, Rainer Jung wrote:
> > So given the fact that there's no workaround for people who need to
> > support clients which require a non-empty reason phrase and also that
> > our story for users of 8.0 is to migrate soon and easy to 8.5, I would
> > be +1 for a configurable option to bring back reason phrases. Default
> > would be "no reason phrases".
>
> -chris
>
>
>

[Bug 60620] [JRE] Memory leak found in java.util.concurrent.ForkJoinPool

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60620

Mark Thomas  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #3 from Mark Thomas  ---
Fixed in r1780268 for 8.0.42 onwards.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1780268 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/core/ java/org/apache/catalina/startup/ webapps/docs/ webapps/docs/config/

[markt]

Author: markt
Date: Wed Jan 25 20:44:59 2017
New Revision: 1780268

URL: http://svn.apache.org/viewvc?rev=1780268&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60620
Add memory protection for ForkJoinPool.commonPool() related memory leaks.

Added:

tomcat/tc8.0.x/trunk/java/org/apache/catalina/startup/SafeForkJoinWorkerThreadFactory.java
  - copied unchanged from r1778061, 
tomcat/trunk/java/org/apache/catalina/startup/SafeForkJoinWorkerThreadFactory.java
Modified:
tomcat/tc8.0.x/trunk/   (props changed)
tomcat/tc8.0.x/trunk/build.xml

tomcat/tc8.0.x/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml
tomcat/tc8.0.x/trunk/webapps/docs/config/listeners.xml

Propchange: tomcat/tc8.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Wed Jan 25 20:44:59 2017
@@ -1,2 +1,2 @@
 
/tomcat/tc8.5.x/trunk:1735042,1737966,1743139-1743140,1744151,1747537,1747925,1748002,1754614,1754643,1762124,1762183,1762203,1763792,1772948,1777014,1779719
-/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1637890,1637892,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886
 
,1644890,1644892,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657
 
592,1657607,1657609,1657682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659174,1659184,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661770,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662696,1662736,1662985,1662988-1662989,1663264,1663277,1663298,1663534,1663562,1663676,1663715,1663754,1663768,1663772,1663781,1663893,1663995,1664143,1664163,1664174,1664301,1664317,1664347,1664657,1664659,1664710,1664863-1664864,1664866,1665085,1665292,1665559,1665653,1665661,1665672,1665694,1665697,1665736,1665779,1665976-1665977,1665980-1665981,1665985-1665986,1665989,1665998,1666004,1666008,1666013,1666017,1666024,1666116,1666386-1
 
666387,1666494,1666496,1666552,1666569,1666579,137,149,1666757,1666966,1666972,1666985,1666995,1666997,1667292,1667402,1667406,1667546,1667615,1667630,1667636,1667688,1667764,1667871,1668026,1668135,1668193,1668593,1668596,1668630,1668639,1668843,1669353,1669370,1669451,1669800,1669838,1669876,1669882,1670394,1670433,1670591,1670598-1670600,1670610,1670631,1670719,1670724,1670726,1670730,1670940,1671112,1672272,1672284,1673754,1674294,1675461,1675486,1675594,1675830,1676231,1676250-1676251,1676364,1676381,1676393,1676479,1676525,1676552,1676615,1676630,1676634,1676721,1676926,1676943,1677140,1677802,1678011,1678162,1678174,1678339,1678426-1678427,1678694,1678701,1679534,1679708,1679710,1679716,1680034,1680246,1681056,1681123,1681138,1681280,1681283,1681286,1681450,1681697,1681699,1681701,1681729,1681770,1681779,1681793,1681807,1681837-1

[Bug 60632] Last logs lost when running Tomcat with systemd and journald

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60632

--- Comment #2 from Mark Thomas  ---
I'd prefer to see this enabled with an environment variable (that should also
set the length of the sleep). That way the default behaviour doesn't change,
those that need to fix it have an option to do so and the delay can be set to
an appropriate value for each system.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: svn commit: r1780262 - /tomcat/trunk/test/org/apache/jasper/runtime/TestTagHandlerPool.java

[Konstantin Kolinko]

2017-01-25 23:05 GMT+03:00  :
> Author: markt
> Date: Wed Jan 25 20:05:01 2017
> New Revision: 1780262
>
> URL: http://svn.apache.org/viewvc?rev=1780262&view=rev
> Log:
> Add a unit test used to investigate https://github.com/apache/tomcat85/pull/5
> TagHandlerPool is effectively using a SynchronizedStack. This is known to 
> perform better than ConcurrentLinkedDeque in some cases and testing confirmed 
> that for TagHandlerPool.


1. Rename to TestTagHandlerPoolPerformance ?

In build.xml there is exclude pattern for such tests:


2. A test class with a single @Ignore'd method  ->
I remember that in such case the annotation had to be moved to class level.

(I do not remember the reason, but I think that we will see it soon enough.)

Best regards,
Konstantin Kolinko

> Added:
> tomcat/trunk/test/org/apache/jasper/runtime/TestTagHandlerPool.java   
> (with props)
>
> Added: tomcat/trunk/test/org/apache/jasper/runtime/TestTagHandlerPool.java
> URL: 
> http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/jasper/runtime/TestTagHandlerPool.java?rev=1780262&view=auto
> ==
> --- tomcat/trunk/test/org/apache/jasper/runtime/TestTagHandlerPool.java 
> (added)
> +++ tomcat/trunk/test/org/apache/jasper/runtime/TestTagHandlerPool.java Wed 
> Jan 25 20:05:01 2017
> @@ -0,0 +1,95 @@
> +/*
> + * Licensed to the Apache Software Foundation (ASF) under one or more
> + * contributor license agreements.  See the NOTICE file distributed with
> + * this work for additional information regarding copyright ownership.
> + * The ASF licenses this file to You under the Apache License, Version 2.0
> + * (the "License"); you may not use this file except in compliance with
> + * the License.  You may obtain a copy of the License at
> + *
> + *  http://www.apache.org/licenses/LICENSE-2.0
> + *
> + * Unless required by applicable law or agreed to in writing, software
> + * distributed under the License is distributed on an "AS IS" BASIS,
> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> + * See the License for the specific language governing permissions and
> + * limitations under the License.
> + */
> +package org.apache.jasper.runtime;
> +
> +import javax.servlet.jsp.JspException;
> +import javax.servlet.jsp.tagext.Tag;
> +
> +import org.junit.Ignore;
> +import org.junit.Test;
> +
> +import org.apache.catalina.Wrapper;
> +import org.apache.catalina.startup.Tomcat;
> +import org.apache.catalina.startup.TomcatBaseTest;
> +import org.apache.tomcat.unittest.tags.Bug53545;
> +
> +
> +public class TestTagHandlerPool extends TomcatBaseTest {
> +
> +/*
> + * Performance test. Comment out @Ignore to run the test.
> + */
> +@Ignore
> +@Test
> +public void testConcurrency() throws Exception {
> +// Create a working TagHandlerPool
> +Tomcat tomcat = getTomcatInstanceTestWebapp(false, true);
> +
> +Wrapper w = (Wrapper) 
> tomcat.getHost().findChildren()[0].findChild("jsp");
> +TagHandlerPool tagHandlerPool = new TagHandlerPool();
> +tagHandlerPool.init(w.getServlet().getServletConfig());
> +
> +for (int i = 1; i < 9; i++) {
> +doTestConcurrency(tagHandlerPool, i);
> +}
> +}
> +
> +
> +private void doTestConcurrency(TagHandlerPool tagHandlerPool, int 
> threadCount) throws Exception {
> +long start = System.nanoTime();
> +
> +Thread[] threads = new Thread[threadCount];
> +
> +for (int i = 0; i < threadCount; i++) {
> +threads[i] = new Thread(new 
> TagHandlerPoolRunnable(tagHandlerPool));
> +}
> +
> +for (int i = 0; i < threadCount; i++) {
> +threads[i].start();
> +}
> +
> +for (int i = 0; i < threadCount; i++) {
> +threads[i].join();
> +}
> +
> +long duration = System.nanoTime() - start;
> +
> +System.out.println(threadCount + " threads completed in " + duration 
> + "ns");
> +}
> +
> +
> +private class TagHandlerPoolRunnable implements Runnable {
> +
> +private final TagHandlerPool tagHandlerPool;
> +
> +private TagHandlerPoolRunnable(TagHandlerPool tagHandlerPool) {
> +this.tagHandlerPool = tagHandlerPool;
> +}
> +
> +@Override
> +public void run() {
> +try {
> +for (int i = 0; i < 50; i++) {
> +Tag t = tagHandlerPool.get(Bug53545.class);
> +tagHandlerPool.reuse(t);
> +}
> +} catch (JspException e) {
> +e.printStackTrace();
> +}
> +}
> +}
> +}
>
> Propchange: 
> tomcat/trunk/test/org/apache/jasper/runtime/TestTagHandlerPool.java
> --
> svn:eol-style = native
>
>
>
> -
> To un

[Bug 60623] When startStopThreads is 1, don't rely on an executor and instead start synchronously

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60623

--- Comment #14 from Mark Thomas  ---
Why isn't the log4j2 issue just as much as a problem for an Executor thread
that is used to start multiple web applications?

I remain unconvinced that switching to the main thread when startStopThreads ==
1 is any worse that the current behaviour.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1780267 [1/2] - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/ java/org/apache/tomcat/util/collections/ test/org/apache/catalina/core/ webapps/docs/

[markt]

Author: markt
Date: Wed Jan 25 20:23:21 2017
New Revision: 1780267

URL: http://svn.apache.org/viewvc?rev=1780267&view=rev
Log:
Reduce the contention in the default InstanceManager implementation when 
multiple threads are managing objects and need to reference the annotation 
cache.
Prior to this patch, TestDefaultInstanceManager#testConcurrency() showed a 
roughly linear increase in execution time as the thread count increased. With 
this patch applied, the test shows broadly no change in execution time as the 
thread count is increased from 1 to 8 on a machine with 8 cores available.

Added:

tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/collections/ManagedConcurrentWeakHashMap.java
  - copied, changed from r1780264, 
tomcat/tc8.0.x/trunk/java/org/apache/tomcat/util/collections/ManagedConcurrentWeakHashMap.java
Modified:
tomcat/tc7.0.x/trunk/   (props changed)

tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java
tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/LocalStrings.properties
tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardContext.java

tomcat/tc7.0.x/trunk/test/org/apache/catalina/core/TestDefaultInstanceManager.java
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc7.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Wed Jan 25 20:23:21 2017
@@ -1,3 +1,3 @@
 
/tomcat/tc8.0.x/trunk:1636525,1637336,1637685,1637709,1638726,1640089,1640276,1640349,1640363,1640366,1640642,1640672,1640674,1640689,1640884,1641001,1641065,1641067,1641375,1641638,1641723,1641726,1641729-1641730,1641736,1641988,1642669-1642670,1642698,1642701,1643205,1643215,1643217,1643230,1643232,1643273,1643285,1643329-1643330,1643511,1643513,1643521,1643539,1643571,1643581-1643582,1643635,1643655,1643738,1643964,1644018,1644333,1644954,1644992,1645014,1645360,1645456,1645627,1645642,1645686,1645903-1645904,1645908-1645909,1645913,1645920,1646458,1646460-1646462,1646735,1646738-1646741,1646744,1646746,1646748-1646755,1646757,1646759-1646760,1647043,1648816,1651420-1651422,1651844,1652926,1652939-1652940,1652973,1653798,1653817,1653841,1654042,1654161,1654736,1654767,1654787,1656592,1659907,1662986,1663265,1663278,1663325,1663535,1663567,1663679,1663997,1664175,1664321,1664872,1665061,1665086,1666027,1666395,1666503,1666506,1666560,1666570,1666581,1666759,1666967,1666988,1667553
 
-1667555,1667558,1667617,1667633,1667637,1667747,1667767,1667873,1668028,1668137,1668634,1669432,1669801,1669840,1669895-1669896,1670398,1670435,1670592,1670605-1670607,1670609,1670632,1670720,1670725,1670727,1670731,1671114,1672273,1672285,1673759,1674220,1674295,1675469,1675488,1675595,1675831,1676232,1676367-1676369,1676382,1676394,1676483,1676556,1676635,1678178,1679536,1679988,1680256,1681124,1681182,1681703,1681730,1681840,1681864,1681869,1682010,1682034,1682047,1682052-1682053,1682062,1682064,1682070,1682312,1682325,1682331,1682386,1684367,1684385,1685759,1685774,1685827,1685892,1687341,1688904,1689358,1689657,1689921,1692850,1693093,1693108,1693324,1694060,1694115,1694291,1694427,1694431,1694503,1694549,1694789,1694873,1694881,1695356,1695372,1695823-1695825,1696200,1696281,1696379,1696468,1700608,1700871,1700897,1700978,1701094,1701124,1701608,1701668,1701676,1701766,1701944,1702248,1702252,1702314,1702390,1702723,1702725,1702728,1702730,1702733,1702735,1702737,1702739,1702
 
742,1702744,1702748,1702751,1702754,1702758,1702760,1702763,1702766,1708779,1708782,1708806,1709314,1709670,1710347,1710442,1710448,1710490,1710574,1710578,1712226,1712229,1712235,1712255,1712618,1712649,1712655,1712860,1712899,1712903,1712906,1712913,1712926,1712975,1713185,1713262,1713287,1713613,1713621,1713872,1713976,1713994,1713998,1714004,1714013,1714059,1714538,1714580,1715189,1715207,1715544,1715549,1715637,1715639-1715645,1715667,1715683,1715866,1715978,1715981,1716216-1716217,1716355,1716414,1716421,1717208-1717209,1717257,1717283,1717288,1717291,1717421,1717517,1717529,1718797,1718840-1718843,1719348,1719357-1719358,1719400,1719491,1719737,1720235,1720396,1720442,1720446,1720450,1720463,1720658-1720660,1720756,1720816,1721813,1721818,1721831,1721861,1721867,1721882,1722523,1722527,1722800,1722926,1722941,1722997,1723130,1723440,1723488,1723890,1724434,1724674,1724792,1724803,1724902,1725128,1725131,1725154,1725167,1725911,1725921,1725929,1725963-1725965,1725970,1725974,1
 
726171-1726173,1726175,1726179-1726182,1726190-1726191,1726195-1726200,1726203,1726226,1726576,1726630,1726992,1727029,1727037,1727671,1727676,1727900,1728028,1728092,1728439,1728449,1729186,1729362,1731009,1731303,1731867,1731872,1731874,1731876,1731885,1731947,1731955,1731959,1731977,1731984,1732360,1732490,1732672,1732902,1733166,1733603,1733619,1733735,1733752,1733764,1733915,1733941,1733964,1734115,1734133,1734261,1734421,1734531,1736286,1737967,1738173,1738182,1738992,1739039,1739089-1739091,1739294,1739777,173982

svn commit: r1780267 [2/2] - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/ java/org/apache/tomcat/util/collections/ test/org/apache/catalina/core/ webapps/docs/

[markt]

Modified: 
tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardContext.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardContext.java?rev=1780267&r1=1780266&r2=1780267&view=diff
==
--- tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardContext.java 
(original)
+++ tomcat/tc7.0.x/trunk/java/org/apache/catalina/core/StandardContext.java Wed 
Jan 25 20:23:21 2017
@@ -5,9 +5,9 @@
  * The ASF licenses this file to You under the Apache License, Version 2.0
  * (the "License"); you may not use this file except in compliance with
  * the License.  You may obtain a copy of the License at
- * 
+ *
  *  http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -206,7 +206,7 @@ public class StandardContext extends Con
  *  element.
  */
 protected boolean allowCasualMultipartParsing = false;
- 
+
 /**
  * Control whether remaining request data will be read
  * (swallowed) even if the request violates a data size constraint.
@@ -236,13 +236,13 @@ public class StandardContext extends Con
  */
 private boolean antiJARLocking = false;
 
-
+
 /**
  * The antiResourceLocking flag for this Context.
  */
 private boolean antiResourceLocking = false;
 
-
+
 /**
  * The set of application listener class names configured for this
  * application, in the order they were encountered in the resulting merged
@@ -250,7 +250,7 @@ public class StandardContext extends Con
  */
 private ApplicationListener applicationListeners[] =
 new ApplicationListener[0];
-
+
 private final Object applicationListenersLock = new Object();
 
 /**
@@ -265,7 +265,7 @@ public class StandardContext extends Con
  * SCIs and other code may use the pluggability APIs to add listener
  * instances directly to this list before the application starts.
  */
-private Object applicationEventListenersObjects[] = 
+private Object applicationEventListenersObjects[] =
 new Object[0];
 
 
@@ -274,7 +274,7 @@ public class StandardContext extends Con
  * SCIs and other code may use the pluggability APIs to add listener
  * instances directly to this list before the application starts.
  */
-private Object applicationLifecycleListenersObjects[] = 
+private Object applicationLifecycleListenersObjects[] =
 new Object[0];
 
 
@@ -283,8 +283,8 @@ public class StandardContext extends Con
  */
 private Map>> initializers =
 new LinkedHashMap>>();
-
-
+
+
 /**
  * The set of application parameters defined for this application.
  */
@@ -292,13 +292,13 @@ public class StandardContext extends Con
 new ApplicationParameter[0];
 
 private final Object applicationParametersLock = new Object();
-
+
 
 /**
- * The broadcaster that sends j2ee notifications. 
+ * The broadcaster that sends j2ee notifications.
  */
 private NotificationBroadcasterSupport broadcaster = null;
-
+
 /**
  * The Locale to character set mapper for this application.
  */
@@ -329,7 +329,7 @@ public class StandardContext extends Con
  */
 private volatile SecurityConstraint constraints[] =
 new SecurityConstraint[0];
-
+
 private final Object constraintsLock = new Object();
 
 
@@ -364,12 +364,12 @@ public class StandardContext extends Con
  */
 private boolean crossContext = false;
 
-
+
 /**
  * Encoded path.
  */
 private String encodedPath = null;
-
+
 
 /**
  * Unencoded path for this web application.
@@ -390,13 +390,13 @@ public class StandardContext extends Con
 private String displayName = null;
 
 
-/** 
+/**
  * Override the default context xml location.
  */
 private String defaultContextXml;
 
 
-/** 
+/**
  * Override the default web xml location.
  */
 private String defaultWebXml;
@@ -470,7 +470,7 @@ public class StandardContext extends Con
 /**
  * The mapper associated with this context.
  */
-private org.apache.tomcat.util.http.mapper.Mapper mapper = 
+private org.apache.tomcat.util.http.mapper.Mapper mapper =
 new org.apache.tomcat.util.http.mapper.Mapper();
 
 
@@ -554,8 +554,8 @@ public class StandardContext extends Con
  * The original document root for this web application.
  */
 private String originalDocBase = null;
-
-
+
+
 /**
  * The privileged flag for this web application.
  */
@@ -594,7 +594,7 @@ public class StandardContext extends Con
  */
 private HashMap servletMappings =
 new HashMap

svn commit: r1780266 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/core/ test/org/apache/catalina/core/ webapps/docs/

[markt]

Author: markt
Date: Wed Jan 25 20:14:42 2017
New Revision: 1780266

URL: http://svn.apache.org/viewvc?rev=1780266&view=rev
Log:
Reduce the contention in the default InstanceManager implementation when 
multiple threads are managing objects and need to reference the annotation 
cache.
Prior to this patch, TestDefaultInstanceManager#testConcurrency() showed a 
roughly linear increase in execution time as the thread count increased. With 
this patch applied, the test shows broadly no change in execution time as the 
thread count is increased from 1 to 8 on a machine with 8 cores available.

Modified:
tomcat/tc8.0.x/trunk/   (props changed)

tomcat/tc8.0.x/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java
tomcat/tc8.0.x/trunk/java/org/apache/catalina/core/LocalStrings.properties
tomcat/tc8.0.x/trunk/java/org/apache/catalina/core/StandardContext.java

tomcat/tc8.0.x/trunk/test/org/apache/catalina/core/TestDefaultInstanceManager.java
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Wed Jan 25 20:14:42 2017
@@ -1,2 +1,2 @@
 
/tomcat/tc8.5.x/trunk:1735042,1737966,1743139-1743140,1744151,1747537,1747925,1748002,1754614,1754643,1762124,1762183,1762203,1763792,1772948,1777014,1779719
-/tomcat/trunk:1636524,1637156,1637176,1637188,1637331,1637684,1637695,1637890,1637892,1638720-1638725,1639653,1640010,1640083-1640084,1640088,1640275,1640322,1640347,1640361,1640365,1640403,1640410,1640652,1640655-1640658,1640688,1640700-1640883,1640903,1640976,1640978,1641000,1641026,1641038-1641039,1641051-1641052,1641058,1641064,1641300,1641369,1641374,1641380,1641486,1641634,1641656-1641692,1641704,1641707-1641718,1641720-1641722,1641735,1641981,1642233,1642280,1642554,1642564,1642595,1642606,1642668,1642679,1642697,1642699,1642766,1643002,1643045,1643054-1643055,1643066,1643121,1643128,1643206,1643209-1643210,1643216,1643249,1643270,1643283,1643309-1643310,1643323,1643365-1643366,1643370-1643371,1643465,1643474,1643536,1643570,1643634,1643649,1643651,1643654,1643675,1643731,1643733-1643734,1643761,1643766,1643814,1643937,1643963,1644017,1644169,1644201-1644203,1644321,1644323,1644516,1644523,1644529,1644535,1644730,1644768,1644784-1644785,1644790,1644793,1644815,1644884,1644886
 
,1644890,1644892,1644910,1644924,1644929-1644930,1644935,1644989,1645011,1645247,1645355,1645357-1645358,1645455,1645465,1645469,1645471,1645473,1645475,1645486-1645488,1645626,1645641,1645685,1645743,1645763,1645951-1645953,1645955,1645993,1646098-1646106,1646178,1646220,1646302,1646304,1646420,1646470-1646471,1646476,1646559,1646717-1646723,1646773,1647026,1647042,1647530,1647655,1648304,1648815,1648907,1649973,1650081,1650365,1651116,1651120,1651280,1651470,1652938,1652970,1653041,1653471,1653550,1653574,1653797,1653815-1653816,1653819,1653840,1653857,1653888,1653972,1654013,1654030,1654050,1654123,1654148,1654159,1654513,1654515,1654517,1654522,1654524,1654725,1654735,1654766,1654785,1654851-1654852,1654978,1655122-1655124,1655126-1655127,1655129-1655130,1655132-1655133,1655312,1655351,1655438,1655441,1655454,168,1656087,1656299,1656319,1656331,1656345,1656350,1656590,1656648-1656650,1656657,1657041,1657054,1657374,1657492,1657510,1657565,1657580,1657584,1657586,1657589,1657
 
592,1657607,1657609,1657682,1657907,1658207,1658734,1658781,1658790,1658799,1658802,1658804,1658833,1658840,1658966,1659043,1659053,1659059,1659174,1659184,1659188-1659189,1659216,1659263,1659293,1659304,1659306-1659307,1659382,1659384,1659428,1659471,1659486,1659505,1659516,1659521,1659524,1659559,1659562,1659803,1659806,1659814,1659833,1659862,1659905,1659919,1659948,1659967,1659983-1659984,1660060,1660074,1660077,1660133,1660168,1660331-1660332,1660353,1660358,1660924,1661386,1661770,1661867,1661972,1661990,1662200,1662308-1662309,1662548,1662614,1662696,1662736,1662985,1662988-1662989,1663264,1663277,1663298,1663534,1663562,1663676,1663715,1663754,1663768,1663772,1663781,1663893,1663995,1664143,1664163,1664174,1664301,1664317,1664347,1664657,1664659,1664710,1664863-1664864,1664866,1665085,1665292,1665559,1665653,1665661,1665672,1665694,1665697,1665736,1665779,1665976-1665977,1665980-1665981,1665985-1665986,1665989,1665998,1666004,1666008,1666013,1666017,1666024,1666116,1666386-1
 
666387,1666494,1666496,1666552,1666569,1666579,137,149,1666757,1666966,1666972,1666985,1666995,1666997,1667292,1667402,1667406,1667546,1667615,1667630,1667636,1667688,1667764,1667871,1668026,1668135,1668193,1668593,1668596,1668630,1668639,1668843,1669353,1669370,1669451,1669800,1669838,1669876,1669882,1670394,1670433,1670591,1670598-1670600,1670610,1670631,1670719,1670724,1670726,1670730,1670940,1671112,1672272,1672284,1673754,1674294,1675461,1675486,1675594,1675830,1676231,1676250-1676251,1676364,1676381,1676393,1676479,1676525,1676552,1676615,1676630,1676634,1676721,1676926,1676943,1677140,1

svn commit: r1780265 - in /tomcat/tc8.5.x/trunk/java/org/apache: catalina/core/DefaultInstanceManager.java catalina/core/StandardContext.java tomcat/InstanceManager.java

[markt]

Author: markt
Date: Wed Jan 25 20:13:22 2017
New Revision: 1780265

URL: http://svn.apache.org/viewvc?rev=1780265&view=rev
Log:
Remove the Java 8 specific code

Modified:

tomcat/tc8.5.x/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java
tomcat/tc8.5.x/trunk/java/org/apache/catalina/core/StandardContext.java
tomcat/tc8.5.x/trunk/java/org/apache/tomcat/InstanceManager.java

Modified: 
tomcat/tc8.5.x/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java?rev=1780265&r1=1780264&r2=1780265&view=diff
==
--- 
tomcat/tc8.5.x/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java 
(original)
+++ 
tomcat/tc8.5.x/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java 
Wed Jan 25 20:13:22 2017
@@ -243,7 +243,6 @@ public class DefaultInstanceManager impl
 }
 
 
-@Override
 public void backgroundProcess() {
 annotationCache.maintain();
 }

Modified: 
tomcat/tc8.5.x/trunk/java/org/apache/catalina/core/StandardContext.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/catalina/core/StandardContext.java?rev=1780265&r1=1780264&r2=1780265&view=diff
==
--- tomcat/tc8.5.x/trunk/java/org/apache/catalina/core/StandardContext.java 
(original)
+++ tomcat/tc8.5.x/trunk/java/org/apache/catalina/core/StandardContext.java Wed 
Jan 25 20:13:22 2017
@@ -5569,9 +5569,9 @@ public class StandardContext extends Con
 }
 }
 InstanceManager instanceManager = getInstanceManager();
-if (instanceManager != null) {
+if (instanceManager instanceof DefaultInstanceManager) {
 try {
-instanceManager.backgroundProcess();
+((DefaultInstanceManager)instanceManager).backgroundProcess();
 } catch (Exception e) {
 log.warn(sm.getString(
 "standardContext.backgroundProcess.instanceManager",

Modified: tomcat/tc8.5.x/trunk/java/org/apache/tomcat/InstanceManager.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/tomcat/InstanceManager.java?rev=1780265&r1=1780264&r2=1780265&view=diff
==
--- tomcat/tc8.5.x/trunk/java/org/apache/tomcat/InstanceManager.java (original)
+++ tomcat/tc8.5.x/trunk/java/org/apache/tomcat/InstanceManager.java Wed Jan 25 
20:13:22 2017
@@ -39,13 +39,4 @@ public interface InstanceManager {
 
 public void destroyInstance(Object o)
 throws IllegalAccessException, InvocationTargetException;
-
-/**
- * Called by the component using the InstanceManager periodically to 
perform
- * any regular maintenance that might be required. By default, this method
- * is a NO-OP.
- */
-public default void backgroundProcess() {
-// NO-OP by default
-}
 }



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1780263 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/core/ java/org/apache/tomcat/ test/org/apache/catalina/core/ webapps/docs/

[markt]

Author: markt
Date: Wed Jan 25 20:07:58 2017
New Revision: 1780263

URL: http://svn.apache.org/viewvc?rev=1780263&view=rev
Log:
Reduce the contention in the default InstanceManager implementation when 
multiple threads are managing objects and need to reference the annotation 
cache.
Prior to this patch, TestDefaultInstanceManager#testConcurrency() showed a 
roughly linear increase in execution time as the thread count increased. With 
this patch applied, the test shows broadly no change in execution time as the 
thread count is increased from 1 to 8 on a machine with 8 cores available.

Modified:
tomcat/tc8.5.x/trunk/   (props changed)

tomcat/tc8.5.x/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java
tomcat/tc8.5.x/trunk/java/org/apache/catalina/core/LocalStrings.properties
tomcat/tc8.5.x/trunk/java/org/apache/catalina/core/StandardContext.java
tomcat/tc8.5.x/trunk/java/org/apache/tomcat/InstanceManager.java

tomcat/tc8.5.x/trunk/test/org/apache/catalina/core/TestDefaultInstanceManager.java
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Wed Jan 25 20:07:58 2017
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501
 
,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747404,1747506,1747536,1747
 
924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1756289,1756408-1756410,1
 
756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,

svn commit: r1780262 - /tomcat/trunk/test/org/apache/jasper/runtime/TestTagHandlerPool.java

[markt]

Author: markt
Date: Wed Jan 25 20:05:01 2017
New Revision: 1780262

URL: http://svn.apache.org/viewvc?rev=1780262&view=rev
Log:
Add a unit test used to investigate https://github.com/apache/tomcat85/pull/5
TagHandlerPool is effectively using a SynchronizedStack. This is known to 
perform better than ConcurrentLinkedDeque in some cases and testing confirmed 
that for TagHandlerPool.

Added:
tomcat/trunk/test/org/apache/jasper/runtime/TestTagHandlerPool.java   (with 
props)

Added: tomcat/trunk/test/org/apache/jasper/runtime/TestTagHandlerPool.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/jasper/runtime/TestTagHandlerPool.java?rev=1780262&view=auto
==
--- tomcat/trunk/test/org/apache/jasper/runtime/TestTagHandlerPool.java (added)
+++ tomcat/trunk/test/org/apache/jasper/runtime/TestTagHandlerPool.java Wed Jan 
25 20:05:01 2017
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.jasper.runtime;
+
+import javax.servlet.jsp.JspException;
+import javax.servlet.jsp.tagext.Tag;
+
+import org.junit.Ignore;
+import org.junit.Test;
+
+import org.apache.catalina.Wrapper;
+import org.apache.catalina.startup.Tomcat;
+import org.apache.catalina.startup.TomcatBaseTest;
+import org.apache.tomcat.unittest.tags.Bug53545;
+
+
+public class TestTagHandlerPool extends TomcatBaseTest {
+
+/*
+ * Performance test. Comment out @Ignore to run the test.
+ */
+@Ignore
+@Test
+public void testConcurrency() throws Exception {
+// Create a working TagHandlerPool
+Tomcat tomcat = getTomcatInstanceTestWebapp(false, true);
+
+Wrapper w = (Wrapper) 
tomcat.getHost().findChildren()[0].findChild("jsp");
+TagHandlerPool tagHandlerPool = new TagHandlerPool();
+tagHandlerPool.init(w.getServlet().getServletConfig());
+
+for (int i = 1; i < 9; i++) {
+doTestConcurrency(tagHandlerPool, i);
+}
+}
+
+
+private void doTestConcurrency(TagHandlerPool tagHandlerPool, int 
threadCount) throws Exception {
+long start = System.nanoTime();
+
+Thread[] threads = new Thread[threadCount];
+
+for (int i = 0; i < threadCount; i++) {
+threads[i] = new Thread(new 
TagHandlerPoolRunnable(tagHandlerPool));
+}
+
+for (int i = 0; i < threadCount; i++) {
+threads[i].start();
+}
+
+for (int i = 0; i < threadCount; i++) {
+threads[i].join();
+}
+
+long duration = System.nanoTime() - start;
+
+System.out.println(threadCount + " threads completed in " + duration + 
"ns");
+}
+
+
+private class TagHandlerPoolRunnable implements Runnable {
+
+private final TagHandlerPool tagHandlerPool;
+
+private TagHandlerPoolRunnable(TagHandlerPool tagHandlerPool) {
+this.tagHandlerPool = tagHandlerPool;
+}
+
+@Override
+public void run() {
+try {
+for (int i = 0; i < 50; i++) {
+Tag t = tagHandlerPool.get(Bug53545.class);
+tagHandlerPool.reuse(t);
+}
+} catch (JspException e) {
+e.printStackTrace();
+}
+}
+}
+}

Propchange: tomcat/trunk/test/org/apache/jasper/runtime/TestTagHandlerPool.java
--
svn:eol-style = native



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60645] StatementFinalizer is not thread-safe

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60645

Christopher Schultz  changed:

   What|Removed |Added

 OS||All

--- Comment #1 from Christopher Schultz  ---
The JDBC spec doesn't mandate thread-safety for the various classes, so you
shouldn't expect them to be thread-safe.

That said, it seems like StatementFinalizer should probably be thread-safe in
case the JDBC driver itself guarantees thread safety. Or, even better, a
MT-safe StatementFinalizer could be provided when it is required (which I would
think would be an unusual situation).

Would you care to donate your MT-safe StatementFinalizer class to the project?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: HTTP response reason phrases

[Christopher Schultz]

Romain,

On 1/25/17 5:30 AM, Romain Manni-Bucau wrote:
> 8.5 just being almost a N-1 spec version of tomcat 9 I think they should
> stay aligned as much as possible.

Yes, but 8.5 is a N+0 spec version of Tomcat 8.0. I think since Tomcat
8.5 is being pushed as the hurry-up upgrade for Tomcat 8.0, it should be
more compatible with Tomcat 8.0 when there is a choice.

I think Rainer articulated this better than I could.

On 1/25/17 5:09 AM, Rainer Jung wrote:
> So given the fact that there's no workaround for people who need to
> support clients which require a non-empty reason phrase and also that
> our story for users of 8.0 is to migrate soon and easy to 8.5, I would
> be +1 for a configurable option to bring back reason phrases. Default
> would be "no reason phrases".

-chris




signature.asc
Description: OpenPGP digital signature

[GUMP@vmgump-vm3]: Project tomcat-tc8.0.x-test-nio2 (in module tomcat-8.0.x) failed

[Bill Barker]

To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-tc8.0.x-test-nio2 has an issue affecting its community 
integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-tc8.0.x-test-nio2 :  Tomcat 8.x, a web server implementing the 
Java Servlet 3.1,
...


Full details are available at:

http://vmgump-vm3.apache.org/tomcat-8.0.x/tomcat-tc8.0.x-test-nio2/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
commons-daemon.native.src.tgz.
 -DEBUG- Dependency on commons-daemon exists, no need to add for property 
tomcat-native.tar.gz.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-8.0.x/output/logs-NIO2
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-8.0.x/output/test-tmp-NIO2/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-8.0.x/output/test-tmp-NIO2/logs]



The following work was performed:
http://vmgump-vm3.apache.org/tomcat-8.0.x/tomcat-tc8.0.x-test-nio2/gump_work/build_tomcat-8.0.x_tomcat-tc8.0.x-test-nio2.html
Work Name: build_tomcat-8.0.x_tomcat-tc8.0.x-test-nio2 (Type: Build)
Work ended in a state of : Failed
Elapsed: 19 mins 58 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only org.apache.tools.ant.Main 
-Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Dbase.path=/srv/gump/public/workspace/tomcat-8.0.x/tomcat-build-libs 
-Dexecute.test.nio2=true -Dtest.temp=output/test-tmp-NIO2 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Dtest.accesslog=true 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.6-SNAPSHOT.jar
 -Dexamples.sources.skip=true 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20170125.jar
 
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-1.0.2/dest-20170125/bin/openssl
 -Dexecute.test.nio=false 
-Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dexecute.test.apr=false -Dexecute.test.bio=false 
-Dcommons-daemon.native.src.tgz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20170125-native-src.tar.gz
 -Dtest.repor
 ts=output/logs-NIO2 
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20170125-native-src.tar.gz
 -Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar 
-Dtest.relaxTiming=true -Dtest.excludePerformance=true 
-Djava.net.preferIPv4Stack=/srv/gump/public/workspace/tomcat-8.0.x/true 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.5-SNAPSHOT.jar
 -Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-8.0.x]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-8.0.x/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-8.0.x/output/build/lib/catalina-tribes.jar:/srv/gump/public/wo

[Bug 60645] New: StatementFinalizer is not thread-safe

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60645

Bug ID: 60645
   Summary: StatementFinalizer is not thread-safe
   Product: Tomcat Modules
   Version: unspecified
  Hardware: PC
Status: NEW
  Severity: normal
  Priority: P2
 Component: jdbc-pool
  Assignee: dev@tomcat.apache.org
  Reporter: ba...@semedy.com
  Target Milestone: ---

The interceptor

org.apache.tomcat.jdbc.pool.interceptor.StatementFinalizer

is not thread-safe. 

Some JDBC drivers (e.g. MSSQL) allow to use a single JDBC connection in
multiple threads (a statement cannot be shared across threads). 

In our application we use multiple different threads which operate on the same
JDBC connection. If a statement is created then the StatementFinalizer stores
it in a java.util.LinkedList (which is not thread-safe and may damage the data
structure).

This might lead to a

java.lang.NullPointerException
at java.util.LinkedList.unlink(LinkedList.java:211)
at java.util.LinkedList.remove(LinkedList.java:526)
at
org.apache.tomcat.jdbc.pool.interceptor.StatementFinalizer.closeInvoked(StatementFinalizer.java:59)
at
org.apache.tomcat.jdbc.pool.interceptor.AbstractCreateStatementInterceptor.invoke(AbstractCreateStatementInterceptor.java:59)
at
org.apache.tomcat.jdbc.pool.JdbcInterceptor.invoke(JdbcInterceptor.java:108)
at
org.apache.tomcat.jdbc.pool.interceptor.ConnectionState.invoke(ConnectionState.java:152)
at
org.apache.tomcat.jdbc.pool.JdbcInterceptor.invoke(JdbcInterceptor.java:108)
at
org.apache.tomcat.jdbc.pool.TrapException.invoke(TrapException.java:40)


Our workaround was to create our own thread-safe statement finalizer.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

buildbot success in on tomcat-trunk

[buildbot]

The Buildbot has detected a restored build on builder tomcat-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/2064

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
triggered this build
Build Source Stamp: [branch tomcat/trunk] 1780196
Blamelist: markt

Build succeeded!

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1780196 - /tomcat/trunk/test/org/apache/catalina/core/TestDefaultInstanceManager.java

[markt]

Author: markt
Date: Wed Jan 25 14:45:15 2017
New Revision: 1780196

URL: http://svn.apache.org/viewvc?rev=1780196&view=rev
Log:
Need to trigger maintenance for the weak cache after GC completes to clear out 
dead entries.

Modified:
tomcat/trunk/test/org/apache/catalina/core/TestDefaultInstanceManager.java

Modified: 
tomcat/trunk/test/org/apache/catalina/core/TestDefaultInstanceManager.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/core/TestDefaultInstanceManager.java?rev=1780196&r1=1780195&r2=1780196&view=diff
==
--- tomcat/trunk/test/org/apache/catalina/core/TestDefaultInstanceManager.java 
(original)
+++ tomcat/trunk/test/org/apache/catalina/core/TestDefaultInstanceManager.java 
Wed Jan 25 14:45:15 2017
@@ -61,6 +61,7 @@ public class TestDefaultInstanceManager
 // Spin a while until GC happens or we wait too long
 int loop = 0;
 while (loop < 10) {
+instanceManager.backgroundProcess();
 if (instanceManager.getAnnotationCacheSize() == count) {
 break;
 }



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

buildbot failure in on tomcat-trunk

[buildbot]

The Buildbot has detected a new failure on builder tomcat-trunk while building 
. Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/2063

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
triggered this build
Build Source Stamp: [branch tomcat/trunk] 1780189
Blamelist: markt

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1780189 - in /tomcat/trunk: java/org/apache/catalina/core/ java/org/apache/tomcat/ webapps/docs/

[markt]

Author: markt
Date: Wed Jan 25 14:26:53 2017
New Revision: 1780189

URL: http://svn.apache.org/viewvc?rev=1780189&view=rev
Log:
Reduce the contention in the default InstanceManager implementation when 
multiple threads are managing objects and need to reference the annotation 
cache.
Prior to this patch, TestDefaultInstanceManager#testConcurrency() showed a 
roughly linear increase in execution time as the thread count increased. With 
this patch applied, the test shows broadly no change in execution time as the 
thread count is increased from 1 to 8 on a machine with 8 cores available.

Modified:
tomcat/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java
tomcat/trunk/java/org/apache/catalina/core/LocalStrings.properties
tomcat/trunk/java/org/apache/catalina/core/StandardContext.java
tomcat/trunk/java/org/apache/tomcat/InstanceManager.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java?rev=1780189&r1=1780188&r2=1780189&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java Wed 
Jan 25 14:26:53 2017
@@ -34,7 +34,6 @@ import java.util.List;
 import java.util.Map;
 import java.util.Properties;
 import java.util.Set;
-import java.util.WeakHashMap;
 
 import javax.annotation.PostConstruct;
 import javax.annotation.PreDestroy;
@@ -53,6 +52,7 @@ import org.apache.catalina.util.Introspe
 import org.apache.juli.logging.Log;
 import org.apache.tomcat.InstanceManager;
 import org.apache.tomcat.util.ExceptionUtils;
+import org.apache.tomcat.util.collections.ManagedConcurrentWeakHashMap;
 import org.apache.tomcat.util.res.StringManager;
 
 public class DefaultInstanceManager implements InstanceManager {
@@ -74,8 +74,8 @@ public class DefaultInstanceManager impl
 protected final boolean privileged;
 protected final boolean ignoreAnnotations;
 private final Set restrictedClasses;
-private final Map, AnnotationCacheEntry[]> annotationCache =
-new WeakHashMap<>();
+private final ManagedConcurrentWeakHashMap, 
AnnotationCacheEntry[]> annotationCache =
+new ManagedConcurrentWeakHashMap<>();
 private final Map postConstructMethods;
 private final Map preDestroyMethods;
 
@@ -190,10 +190,7 @@ public class DefaultInstanceManager impl
 
 // At the end the postconstruct annotated
 // method is invoked
-AnnotationCacheEntry[] annotations;
-synchronized (annotationCache) {
-annotations = annotationCache.get(clazz);
-}
+AnnotationCacheEntry[] annotations = annotationCache.get(clazz);
 for (AnnotationCacheEntry entry : annotations) {
 if (entry.getType() == AnnotationCacheEntryType.POST_CONSTRUCT) {
 Method postConstruct = getMethod(clazz, entry);
@@ -227,10 +224,7 @@ public class DefaultInstanceManager impl
 
 // At the end the postconstruct annotated
 // method is invoked
-AnnotationCacheEntry[] annotations = null;
-synchronized (annotationCache) {
-annotations = annotationCache.get(clazz);
-}
+AnnotationCacheEntry[] annotations = annotationCache.get(clazz);
 if (annotations == null) {
 // instance not created through the instance manager
 return;
@@ -249,6 +243,12 @@ public class DefaultInstanceManager impl
 }
 
 
+@Override
+public void backgroundProcess() {
+annotationCache.maintain();
+}
+
+
 /**
  * Make sure that the annotations cache has been populated for the provided
  * class.
@@ -268,10 +268,7 @@ public class DefaultInstanceManager impl
 List annotations = null;
 
 while (clazz != null) {
-AnnotationCacheEntry[] annotationsArray = null;
-synchronized (annotationCache) {
-annotationsArray = annotationCache.get(clazz);
-}
+AnnotationCacheEntry[] annotationsArray = 
annotationCache.get(clazz);
 if (annotationsArray == null) {
 if (annotations == null) {
 annotations = new ArrayList<>();
@@ -446,10 +443,7 @@ public class DefaultInstanceManager impl
 Class clazz = instance.getClass();
 
 while (clazz != null) {
-AnnotationCacheEntry[] annotations;
-synchronized (annotationCache) {
-annotations = annotationCache.get(clazz);
-}
+AnnotationCacheEntry[] annotations = annotationCache.get(clazz);
 for (AnnotationCacheEntry entry : annotations) {
 if (entry.getType() == AnnotationCacheEntryType.SETTER) {
 lookupMe

[Bug 60126] The code of method invoke0(JspWriter) is exceeding the 65535 bytes limit

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60126

--- Comment #10 from Ralf Hauser  ---
(In reply to Christopher Schultz from comment #9)
> Please take this conversation to the users list. If you do so, please
> provide examples of the .java files that will not compile successfully.
cannot upload it to a public repository but the .java should be in your mail as
of
19.01.2017 08:10 GMT

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60614] please document how to use JNDI datasource in server.xml with GlobalNamingResources (after CVE-2016-6797)

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60614

Mark Thomas  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEW |RESOLVED

--- Comment #3 from Mark Thomas  ---
The changes for CVE-2016-6797 only affected the use of ResourceLink to make
global resources available to individual web application. It did not affect the
direct definition of a resource within a web application.

This looks like an issue with the Debian distro. The users@ list is the best
place to flush that out if you want feedback from the Tomcat community before
opening a Debian bug.

If the users@ discussion identifies a Tomcat bug, this issue can be re-opened.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60611] empty org.apache.dbcp.dbcp2.BasicDataSource ?

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60611

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #2 from Mark Thomas  ---
The changes for CVE-2016-6797 only affected the use of ResourceLink to make
global resources available to individual web application. It did not affect the
direct definition of a resource within a web application.

This looks like an issue with the Debian distro. The users@ list is the best
place to flush that out if you want feedback from the Tomcat community before
opening a Debian bug.

If the users@ discussion identifies a Tomcat bug, this issue can be re-opened.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60614] please document how to use JNDI datasource in server.xml with GlobalNamingResources (after CVE-2016-6797)

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60614

--- Comment #2 from Ralf Hauser  ---
some further thoughts:

10) first I thought having 
factory ="org.apache.commons.dbcp.BasicDataSourceFactory"
is the problem, as it is trying to instantiate an
 org.apache.tomcat.dbcp.dbcp2.BasicDataSource, but it wasn't 
11) I ended up parsing the server.xml file out of the servlets where I needed
the
BasicDataSources myself and doing a 
 org.apache.commons.dbcp.BasicDataSourceFactory.createDataSource(Properties
properties)
ugly work-around, but appears to work

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 6.0.50

[Rémy Maucherat]

2017-01-22 16:59 GMT+01:00 Violeta Georgieva :

> The proposed Apache Tomcat 6.0.50 release is now available for voting.
>
> Note: This is the last Tomcat 6 release.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-6/v6.0.50/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1119/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc6.0.x/tags/TOMCAT_6_0_50/
>
> The proposed 6.0.50 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 6.0.50 Stable
>
> Rémy

Re: HTTP response reason phrases

[Romain Manni-Bucau]

Hi guys,

8.5 just being almost a N-1 spec version of tomcat 9 I think they should
stay aligned as much as possible. Also note that fixing it in 8.5 will just
delay the issue for 9.x. I'm not sure I see the blocking point to add a
configuration for that (agree it is not spec compliant but it is a nice
feature for broken clients which are widely spread in some languages) but
please keep 8.5 and 9 aligned since migrations are expected (and are)
smooth for now.


Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | JavaEE Factory


2017-01-25 11:27 GMT+01:00 Rainer Jung :

> Am 25.01.2017 um 11:09 schrieb Rainer Jung:
>
>> Am 24.01.2017 um 21:03 schrieb Mark Thomas:
>>
>>> On 24/01/2017 19:08, Christopher Schultz wrote:
>>>
>>> I'm wondering what the wider community thinks about this change and
 whether or not we should consider reverting it for Tomcat 8.5.x.

>>>
>>> 8.5.x has been out for 10 months and stable for 7. It is probably still
>>> early enough that we are seeing issues from the early adopters. We
>>> might, therefore, see more issues moving forwards.
>>>
>>> This change is listed in the change-log for 8.5.0.
>>>
>>> The root cause is non-specification compliant clients. I generally don't
>>> view specification non-compliance in third party code a good reason to
>>> make a change in Tomcat.
>>>
>>> Overall I am -0 on reverting the change for 8.5.x.
>>>
>>
>> For 8.5 we should be aware of the fact, that 8.5 was meant as a quick
>> replacement for 8.0 with a reduced support time for 8.0. We also used
>> wording like "superseded" on the "Which version" page and probably the
>> overall impression is people should soon switch from 8.0 to 8.5 and the
>> switch is an easy one to do as long as you do not start to use the new
>> features.
>>
>> Dropping the reason phrase probably is mostly motivated by the new
>> language "A client SHOULD ignore the reason-phrase content." in RFC 7230
>> section 3.1.2. Although also the older RFC 2616 already allowed an empty
>> reason phrase "Reason-Phrase  = *" the language
>> was less strict: "The client is not required to examine or display the
>> Reason-Phrase.".
>>
>> IMHO it was only later that servers actually started to drop the reason
>> phrase to save a few bytes. Originally it was deemed useful as the old
>> spec states "The Reason-Phrase is intended to give a short textual
>> description of the Status-Code. The ... Reason-Phrase is intended for
>> the human user."
>>
>> The compatibility break with clients who do not confirm to the newer
>> http spec and instead demand the reason phrase will break any
>> communication with them. It is not a "be strict in what you send"
>> situation for us as a server, because the spec does not require us to
>> send an empty reason phrase.
>>
>> So given the fact that there's no workaround for people who need to
>> support clients which require a non-empty reason phrase and also that
>> our story for users of 8.0 is to migrate soon and easy to 8.5, I would
>> be +1 for a configurable option to bring back reason phrases. Default
>> would be "no reason phrases".
>>
>
> I forgot: an option only for 8.5. Dropping it in 9.0 is fine for me.
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: HTTP response reason phrases

[Rainer Jung]

Am 25.01.2017 um 11:09 schrieb Rainer Jung:

Am 24.01.2017 um 21:03 schrieb Mark Thomas:

On 24/01/2017 19:08, Christopher Schultz wrote:


I'm wondering what the wider community thinks about this change and
whether or not we should consider reverting it for Tomcat 8.5.x.


8.5.x has been out for 10 months and stable for 7. It is probably still
early enough that we are seeing issues from the early adopters. We
might, therefore, see more issues moving forwards.

This change is listed in the change-log for 8.5.0.

The root cause is non-specification compliant clients. I generally don't
view specification non-compliance in third party code a good reason to
make a change in Tomcat.

Overall I am -0 on reverting the change for 8.5.x.


For 8.5 we should be aware of the fact, that 8.5 was meant as a quick
replacement for 8.0 with a reduced support time for 8.0. We also used
wording like "superseded" on the "Which version" page and probably the
overall impression is people should soon switch from 8.0 to 8.5 and the
switch is an easy one to do as long as you do not start to use the new
features.

Dropping the reason phrase probably is mostly motivated by the new
language "A client SHOULD ignore the reason-phrase content." in RFC 7230
section 3.1.2. Although also the older RFC 2616 already allowed an empty
reason phrase "Reason-Phrase  = *" the language
was less strict: "The client is not required to examine or display the
Reason-Phrase.".

IMHO it was only later that servers actually started to drop the reason
phrase to save a few bytes. Originally it was deemed useful as the old
spec states "The Reason-Phrase is intended to give a short textual
description of the Status-Code. The ... Reason-Phrase is intended for
the human user."

The compatibility break with clients who do not confirm to the newer
http spec and instead demand the reason phrase will break any
communication with them. It is not a "be strict in what you send"
situation for us as a server, because the spec does not require us to
send an empty reason phrase.

So given the fact that there's no workaround for people who need to
support clients which require a non-empty reason phrase and also that
our story for users of 8.0 is to migrate soon and easy to 8.5, I would
be +1 for a configurable option to bring back reason phrases. Default
would be "no reason phrases".


I forgot: an option only for 8.5. Dropping it in 9.0 is fine for me.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: HTTP response reason phrases

[Rainer Jung]

Am 24.01.2017 um 21:03 schrieb Mark Thomas:

On 24/01/2017 19:08, Christopher Schultz wrote:


I'm wondering what the wider community thinks about this change and
whether or not we should consider reverting it for Tomcat 8.5.x.


8.5.x has been out for 10 months and stable for 7. It is probably still
early enough that we are seeing issues from the early adopters. We
might, therefore, see more issues moving forwards.

This change is listed in the change-log for 8.5.0.

The root cause is non-specification compliant clients. I generally don't
view specification non-compliance in third party code a good reason to
make a change in Tomcat.

Overall I am -0 on reverting the change for 8.5.x.


For 8.5 we should be aware of the fact, that 8.5 was meant as a quick 
replacement for 8.0 with a reduced support time for 8.0. We also used 
wording like "superseded" on the "Which version" page and probably the 
overall impression is people should soon switch from 8.0 to 8.5 and the 
switch is an easy one to do as long as you do not start to use the new 
features.


Dropping the reason phrase probably is mostly motivated by the new 
language "A client SHOULD ignore the reason-phrase content." in RFC 7230 
section 3.1.2. Although also the older RFC 2616 already allowed an empty 
reason phrase "Reason-Phrase  = *" the language 
was less strict: "The client is not required to examine or display the 
Reason-Phrase.".


IMHO it was only later that servers actually started to drop the reason 
phrase to save a few bytes. Originally it was deemed useful as the old 
spec states "The Reason-Phrase is intended to give a short textual 
description of the Status-Code. The ... Reason-Phrase is intended for 
the human user."


The compatibility break with clients who do not confirm to the newer 
http spec and instead demand the reason phrase will break any 
communication with them. It is not a "be strict in what you send" 
situation for us as a server, because the spec does not require us to 
send an empty reason phrase.


So given the fact that there's no workaround for people who need to 
support clients which require a non-empty reason phrase and also that 
our story for users of 8.0 is to migrate soon and easy to 8.5, I would 
be +1 for a configurable option to bring back reason phrases. Default 
would be "no reason phrases".


Regards,

Rainer

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1780161 - /tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

[violetagg]

Author: violetagg
Date: Wed Jan 25 10:02:21 2017
New Revision: 1780161

URL: http://svn.apache.org/viewvc?rev=1780161&view=rev
Log:
Correct changelog sections

Modified:
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1780161&r1=1780160&r2=1780161&view=diff
==
--- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Wed Jan 25 10:02:21 2017
@@ -150,10 +150,6 @@
   
 60513: Fix thread safety issue with RMI cleanup code. (remm)
   
-
-  
-  
-
   
 60620:
 Extend the JreMemoryLeakPreventionListener to provide



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 6.0.50

[Violeta Georgieva]

Hi,

2017-01-22 17:59 GMT+02:00 Violeta Georgieva :
>
> The proposed Apache Tomcat 6.0.50 release is now available for voting.
>
> Note: This is the last Tomcat 6 release.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-6/v6.0.50/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1119/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc6.0.x/tags/TOMCAT_6_0_50/
>
> The proposed 6.0.50 release is:
> [ ] Broken - do not release
> [ ] Stable - go ahead and release as 6.0.50 Stable

We need more votes.

Thanks,
Violeta

[ANN] Apache Tomcat 8.0.41 available

[Violeta Georgieva]

The Apache Tomcat team announces the immediate availability of Apache
Tomcat 8.0.41.

Please note that Tomcat 8.x users should normally be using 8.5.x
releases in preference to 8.0.x releases.

Apache Tomcat 8.0 is an open source software implementation of the Java
Servlet, JavaServer Pages, Java Unified Expression Language and Java
WebSocket technologies.

Apache Tomcat 8.0.41 includes fixes for issues identified in 8.0.39 as
well as other enhancements and changes. The notable changes since 8.0.39
include:


- Improve handling of varargs in UEL expressions

- Ensure that the endpoint is able to unlock the acceptor thread during
  shutdown if the endpoint is configured to listen to any local address of
  a specific type such as 0.0.0.0 or ::


Please refer to the change log for the complete list of changes:
http://tomcat.apache.org/tomcat-8.0-doc/changelog.html

Downloads:
http://tomcat.apache.org/download-80.cgi

Migration guides from Apache Tomcat 5.5.x, 6.0.x and 7.0.x:
http://tomcat.apache.org/migration.html

Enjoy!

- The Apache Tomcat team

[ANN] Apache Tomcat 7.0.75 released

[Violeta Georgieva]

The Apache Tomcat team announces the immediate availability of Apache
Tomcat 7.0.75.

Apache Tomcat is an open source software implementation of the Java
Servlet, JavaServer Pages, Java Expression Language and Java
WebSocket technologies.

This release contains a number of bug fixes and improvements compared to
version 7.0.73. The notable changes since 7.0.73 include:


- Add support for varargs in UEL expressions

- Ensure that the endpoint is able to unlock the acceptor thread during
  shutdown if the endpoint is configured to listen to any local address of
  a specific type such as 0.0.0.0 or ::


Please refer to the change log for the complete list of changes:
http://tomcat.apache.org/tomcat-7.0-doc/changelog.html

Downloads:
http://tomcat.apache.org/download-70.cgi

Migration guides from Apache Tomcat 5.5.x and 6.0.x:
http://tomcat.apache.org/migration.html

Enjoy

The Apache Tomcat team

svn commit: r17987 - /release/tomcat/tomcat-7/v7.0.73/

[violetagg]

Author: violetagg
Date: Wed Jan 25 09:26:52 2017
New Revision: 17987

Log:
Remove 7.0.73

Removed:
release/tomcat/tomcat-7/v7.0.73/


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r17986 - /release/tomcat/tomcat-8/v8.0.39/

[violetagg]

Author: violetagg
Date: Wed Jan 25 09:24:51 2017
New Revision: 17986

Log:
Remove 8.0.39

Removed:
release/tomcat/tomcat-8/v8.0.39/


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1780154 - in /tomcat/site/trunk/docs/tomcat-7.0-doc: ./ api/ api/org/apache/catalina/ api/org/apache/catalina/ant/ api/org/apache/catalina/ant/jmx/ api/org/apache/catalina/authenticator/

[violetagg]

Author: violetagg
Date: Wed Jan 25 09:16:37 2017
New Revision: 1780154

URL: http://svn.apache.org/viewvc?rev=1780154&view=rev
Log:
Update docs for Apache Tomcat 7.0.75 release.


[This commit notification would consist of 68 parts, 
which exceeds the limit of 50 ones, so it was shortened to the summary.]

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1780151 - in /tomcat/site/trunk: ./ docs/ xdocs/

[violetagg]

Author: violetagg
Date: Wed Jan 25 08:52:57 2017
New Revision: 1780151

URL: http://svn.apache.org/viewvc?rev=1780151&view=rev
Log:
Updates (excluding docs) for 7.0.75 release

Modified:
tomcat/site/trunk/build.properties.default
tomcat/site/trunk/docs/doap_Tomcat.rdf
tomcat/site/trunk/docs/download-70.html
tomcat/site/trunk/docs/index.html
tomcat/site/trunk/docs/migration-7.html
tomcat/site/trunk/docs/oldnews.html
tomcat/site/trunk/docs/whichversion.html
tomcat/site/trunk/xdocs/doap_Tomcat.rdf
tomcat/site/trunk/xdocs/download-70.xml
tomcat/site/trunk/xdocs/index.xml
tomcat/site/trunk/xdocs/migration-7.xml
tomcat/site/trunk/xdocs/oldnews.xml
tomcat/site/trunk/xdocs/whichversion.xml

Modified: tomcat/site/trunk/build.properties.default
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/build.properties.default?rev=1780151&r1=1780150&r2=1780151&view=diff
==
--- tomcat/site/trunk/build.properties.default (original)
+++ tomcat/site/trunk/build.properties.default Wed Jan 25 08:52:57 2017
@@ -37,7 +37,7 @@ tomcat.loc=http://www.apache.org/dist/to
 
 # - Tomcat versions -
 tomcat60=6.0.48
-tomcat70=7.0.73
+tomcat70=7.0.75
 tomcat80=8.0.41
 tomcat85=8.5.11
 tomcat90=9.0.0.M17

Modified: tomcat/site/trunk/docs/doap_Tomcat.rdf
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/doap_Tomcat.rdf?rev=1780151&r1=1780150&r2=1780151&view=diff
==
--- tomcat/site/trunk/docs/doap_Tomcat.rdf (original)
+++ tomcat/site/trunk/docs/doap_Tomcat.rdf Wed Jan 25 08:52:57 2017
@@ -74,8 +74,8 @@
 
   
 Latest Stable 7.0.x Release
-2016-11-14
-7.0.73
+2017-01-24
+7.0.75
   
 
 

Modified: tomcat/site/trunk/docs/download-70.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/download-70.html?rev=1780151&r1=1780150&r2=1780151&view=diff
==
--- tomcat/site/trunk/docs/download-70.html (original)
+++ tomcat/site/trunk/docs/download-70.html Wed Jan 25 08:52:57 2017
@@ -222,7 +222,7 @@
 Quick Navigation
 
 
-[define v]7.0.73[end]
+[define v]7.0.75[end]
 https://www.apache.org/dist/tomcat/tomcat-7/KEYS";>KEYS |
 [v] |
 Browse |

Modified: tomcat/site/trunk/docs/index.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/index.html?rev=1780151&r1=1780150&r2=1780151&view=diff
==
--- tomcat/site/trunk/docs/index.html (original)
+++ tomcat/site/trunk/docs/index.html Wed Jan 25 08:52:57 2017
@@ -245,6 +245,40 @@ project logo are trademarks of the Apach
 
 
 
+
+2017-01-24 Tomcat 7.0.75 Released
+
+
+
+The Apache Tomcat Project is proud to announce the release of version 7.0.75 of
+Apache Tomcat. This release contains a number of bug fixes and improvements
+compared to version 7.0.73. The notable changes since 7.0.73 include:
+
+
+
+
+Add support for varargs in UEL expressions.
+
+Ensure that the endpoint is able to unlock the acceptor thread during
+shutdown if the endpoint is configured to listen to any local address
+of a specific type such as 0.0.0.0 or ::.
+
+
+
+
+
+Full details of these changes, and all the other changes, are available in the
+Tomcat 7 
changelog.
+
+
+
+
+
+Download
+
+
+
+
 
 2017-01-24 Tomcat 8.0.41 Released
 
@@ -384,38 +418,6 @@ Apache Tomcat 6.0.47.
 
 
 
-
-
-2016-11-14 Tomcat 7.0.73 Released
-
-
-
-The Apache Tomcat Project is proud to announce the release of version 7.0.73 of
-Apache Tomcat. This release contains a number of bug fixes and improvements
-compared to version 7.0.72. The notable changes since 7.0.72 include:
-
-
-
-
-Improve handling of I/O errors with async processing
-
-Fail earlier on invalid HTTP requests
-
-
-
-
-
-Full details of these changes, and all the other changes, are available in the
-Tomcat 7 
changelog.
-
-
-
-
-
-Download
-
-
-
 
 
 2016-10-05 Tomcat Native 1.2.10 
Released

Modified: tomcat/site/trunk/docs/migration-7.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/migration-7.html?rev=1780151&r1=1780150&r2=1780151&view=diff
==
--- tomcat/site/trunk/docs/migration-7.html (original)
+++ tomcat/site/trunk/docs/migration-7.html Wed Jan 25 08:52:57 2017
@@ -1097,7 +1097,8 @@ of Apache Tomcat.
   "7.0.69":"1738539",
   "7.0.70":"1748587",
   "7.0.72":"1760687",
-  "7.0.73":"1768587"
+  "7.0.73":"1768587",
+  "7.0.75":"1779379"
 };
 
 formSubmit.action = 
"http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/"; +
@@ -1177,8 +1178,9 @@ of Apache Tomcat.
 7.0.68
 7.0.69
 7.0.70
-7.0.72
-7.0.73
+7.0.72
+7.0.73
+7.0.75
 , new version:
   

[Bug 60581] tomcat8 at 100% cpu when trying https on port 80

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60581

--- Comment #3 from Emmanuel Bourg  ---
Yes it looks like the same issue. The best solution for now is to install the
tomcat8 package from the jessie-backports repository.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 60581] tomcat8 at 100% cpu when trying https on port 80

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=60581

--- Comment #2 from Ralf Hauser  ---
Could that be related?
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=851304

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1780146 - in /tomcat/site/trunk/docs/tomcat-8.0-doc: ./ api/ api/org/apache/catalina/ api/org/apache/catalina/ant/ api/org/apache/catalina/ant/jmx/ api/org/apache/catalina/authenticator/

[violetagg]

Author: violetagg
Date: Wed Jan 25 08:30:55 2017
New Revision: 1780146

URL: http://svn.apache.org/viewvc?rev=1780146&view=rev
Log:
Update docs for Apache Tomcat 8.0.41 release.


[This commit notification would consist of 74 parts, 
which exceeds the limit of 50 ones, so it was shortened to the summary.]

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1780142 - in /tomcat/site/trunk: ./ docs/ xdocs/

[violetagg]

Author: violetagg
Date: Wed Jan 25 08:11:37 2017
New Revision: 1780142

URL: http://svn.apache.org/viewvc?rev=1780142&view=rev
Log:
Updates (excluding docs) for 8.0.41 release

Modified:
tomcat/site/trunk/build.properties.default
tomcat/site/trunk/docs/doap_Tomcat.rdf
tomcat/site/trunk/docs/download-80.html
tomcat/site/trunk/docs/index.html
tomcat/site/trunk/docs/migration-8.html
tomcat/site/trunk/docs/oldnews.html
tomcat/site/trunk/docs/whichversion.html
tomcat/site/trunk/xdocs/doap_Tomcat.rdf
tomcat/site/trunk/xdocs/download-80.xml
tomcat/site/trunk/xdocs/index.xml
tomcat/site/trunk/xdocs/migration-8.xml
tomcat/site/trunk/xdocs/oldnews.xml
tomcat/site/trunk/xdocs/whichversion.xml

Modified: tomcat/site/trunk/build.properties.default
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/build.properties.default?rev=1780142&r1=1780141&r2=1780142&view=diff
==
--- tomcat/site/trunk/build.properties.default (original)
+++ tomcat/site/trunk/build.properties.default Wed Jan 25 08:11:37 2017
@@ -38,7 +38,7 @@ tomcat.loc=http://www.apache.org/dist/to
 # - Tomcat versions -
 tomcat60=6.0.48
 tomcat70=7.0.73
-tomcat80=8.0.39
+tomcat80=8.0.41
 tomcat85=8.5.11
 tomcat90=9.0.0.M17
 

Modified: tomcat/site/trunk/docs/doap_Tomcat.rdf
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/doap_Tomcat.rdf?rev=1780142&r1=1780141&r2=1780142&view=diff
==
--- tomcat/site/trunk/docs/doap_Tomcat.rdf (original)
+++ tomcat/site/trunk/docs/doap_Tomcat.rdf Wed Jan 25 08:11:37 2017
@@ -67,8 +67,8 @@
 
   
 Latest Stable 8.0.x Release
-2016-11-14
-8.0.39
+2017-01-24
+8.0.41
   
 
 

Modified: tomcat/site/trunk/docs/download-80.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/download-80.html?rev=1780142&r1=1780141&r2=1780142&view=diff
==
--- tomcat/site/trunk/docs/download-80.html (original)
+++ tomcat/site/trunk/docs/download-80.html Wed Jan 25 08:11:37 2017
@@ -223,7 +223,7 @@
 
 
 [define v]8.5.11[end]
-[define w]8.0.39[end]
+[define w]8.0.41[end]
 https://www.apache.org/dist/tomcat/tomcat-8/KEYS";>KEYS |
 [v] |
 [w] |

Modified: tomcat/site/trunk/docs/index.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/index.html?rev=1780142&r1=1780141&r2=1780142&view=diff
==
--- tomcat/site/trunk/docs/index.html (original)
+++ tomcat/site/trunk/docs/index.html Wed Jan 25 08:11:37 2017
@@ -245,6 +245,41 @@ project logo are trademarks of the Apach
 
 
 
+
+2017-01-24 Tomcat 8.0.41 Released
+
+
+
+The Apache Tomcat Project is proud to announce the release of version 8.0.41
+of Apache Tomcat. Apache Tomcat 8.0.41 includes fixes for issues identified in
+8.0.39 as well as other enhancements and changes. The notable changes since
+8.0.39 include:
+
+
+
+Improve handling of varargs in UEL expressions.
+
+Ensure that the endpoint is able to unlock the acceptor thread during
+shutdown if the endpoint is configured to listen to any local address
+of a specific type such as 0.0.0.0 or ::.
+
+
+
+
+
+Full details of these changes, and all the other changes, are available in the
+Tomcat 8
+changelog.
+
+
+
+
+
+Download
+
+
+
+
 
 2017-01-16 Tomcat 8.5.11 Released
 
@@ -349,39 +384,6 @@ Apache Tomcat 6.0.47.
 
 
 
-
-
-2016-11-14 Tomcat 8.0.39 Released
-
-
-
-The Apache Tomcat Project is proud to announce the release of version 8.0.39
-of Apache Tomcat. Apache Tomcat 8.0.39 includes fixes for issues identified in
-8.0.38 as well as other enhancements and changes. The notable changes since
-8.0.38 include:
-
-
-
-Improve handling of I/O errors with async processing
-
-Fail earlier on invalid HTTP requests
-
-
-
-
-
-Full details of these changes, and all the other changes, are available in the
-Tomcat 8
-changelog.
-
-
-
-
-
-Download
-
-
-
 
 
 2016-11-14 Tomcat 7.0.73 Released

Modified: tomcat/site/trunk/docs/migration-8.html
URL: 
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/migration-8.html?rev=1780142&r1=1780141&r2=1780142&view=diff
==
--- tomcat/site/trunk/docs/migration-8.html (original)
+++ tomcat/site/trunk/docs/migration-8.html Wed Jan 25 08:11:37 2017
@@ -766,7 +766,8 @@ of Apache Tomcat.
   "8.0.36":"1747548",
   "8.0.37":"1758752",
   "8.0.38":"1763661",
-  "8.0.39":"1768639"
+  "8.0.39":"1768639",
+  "8.0.41":"1779395"
 };
 
 formSubmit.action = 
"http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/"; +
@@ -827,8 +828,9 @@ of Apache Tomcat.
 8.0.35
 8.0.36
 8.0.37
-8.0.38
-8.0.39
+8.0.38
+8.0.39