[Bug 61105] Roll log files by default

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61105

--- Comment #11 from Violeta Georgieva  ---
The change is applied and will be available in 9.0.0.M22 onwards.
The log files will be kept by default 90 days.

Do we want this change in the previous versions? May be with different default
value?

Thanks,
Violeta

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

buildbot failure in on tomcat-trunk

[buildbot]

The Buildbot has detected a new failure on builder tomcat-trunk while building 
. Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/2471

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
triggered this build
Build Source Stamp: [branch tomcat/trunk] 1798977
Blamelist: violetagg

BUILD FAILED: failed compile_1

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 61105] Roll log files by default

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61105

--- Comment #10 from Violeta Georgieva  ---
(In reply to Konstantin Kolinko from comment #9)
> (In reply to Violeta Georgieva from comment #8)
> > Any comments?
> 
> Generally: I like it.
> 
> 1. Typo in method name: obtainDateFormPath  s/Form/From/

Fixed

> 2. Building a pattern,
> 
> > pattern = Pattern.compile("^(" + prefix + ")\\d{4}-\\d{1,2}-\\d{1,2}(" + 
> > suffix + ")$");
> 
> This should use  (Pattern.quote(prefix) + "..." + Pattern.quote(suffix))
> 
> Prefix and suffix can contain special characters, e.g. '.' = any character.
> Wrapping them with Pattern.quote() solves this issue.
>

Fixed, added a test also

> 3. Temporary directory handling in unit test
> 
> There is a base Test class that provides support for temporary directories,
> 
> https://github.com/apache/tomcat/blob/trunk/test/org/apache/catalina/startup/
> LoggingBaseTest.java
> 
> Differences:
> - It respects system property "tomcat.test.temp"
> - It uses creates a random directory for the test, to allow running several
> tests in parallel
> tempDir = Files.createTempDirectory(tempBasePath, "test").toFile();
> 
> Maybe it is not a good idea to use LoggingBaseTest directly as a base class,
> as it initializes logging and this test tests logging, but it can be used to
> copy some code.

Fixed

Thanks for the review,
Violeta

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat issue #60: Introduce new logging configuration per handler - maxDays.

[violetagg]

Github user violetagg commented on the issue:

https://github.com/apache/tomcat/pull/60
  
The change was applied with commit 
https://github.com/apache/tomcat/commit/cb884bfdcb537edadd9185fbd8af126c72af4ba5


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] tomcat pull request #60: Introduce new logging configuration per handler - m...

[violetagg]

Github user violetagg closed the pull request at:

https://github.com/apache/tomcat/pull/60


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

svn commit: r1798977 - in /tomcat/trunk: conf/logging.properties java/org/apache/juli/AsyncFileHandler.java java/org/apache/juli/FileHandler.java test/org/apache/juli/TestFileHandler.java webapps/docs

[violetagg]

Author: violetagg
Date: Fri Jun 16 19:17:39 2017
New Revision: 1798977

URL: http://svn.apache.org/viewvc?rev=1798977=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61105
Add a new JULI FileHandler configuration for specifying the maximum number of 
days to keep the log files. By default the log files will be kept 90 days as 
configured in logging.properties.

Added:
tomcat/trunk/test/org/apache/juli/TestFileHandler.java   (with props)
Modified:
tomcat/trunk/conf/logging.properties
tomcat/trunk/java/org/apache/juli/AsyncFileHandler.java
tomcat/trunk/java/org/apache/juli/FileHandler.java
tomcat/trunk/webapps/docs/changelog.xml
tomcat/trunk/webapps/docs/logging.xml

Modified: tomcat/trunk/conf/logging.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/conf/logging.properties?rev=1798977=1798976=1798977=diff
==
--- tomcat/trunk/conf/logging.properties (original)
+++ tomcat/trunk/conf/logging.properties Fri Jun 16 19:17:39 2017
@@ -25,18 +25,22 @@ handlers = 1catalina.org.apache.juli.Asy
 1catalina.org.apache.juli.AsyncFileHandler.level = FINE
 1catalina.org.apache.juli.AsyncFileHandler.directory = ${catalina.base}/logs
 1catalina.org.apache.juli.AsyncFileHandler.prefix = catalina.
+1catalina.org.apache.juli.AsyncFileHandler.maxDays = 90
 
 2localhost.org.apache.juli.AsyncFileHandler.level = FINE
 2localhost.org.apache.juli.AsyncFileHandler.directory = ${catalina.base}/logs
 2localhost.org.apache.juli.AsyncFileHandler.prefix = localhost.
+2localhost.org.apache.juli.AsyncFileHandler.maxDays = 90
 
 3manager.org.apache.juli.AsyncFileHandler.level = FINE
 3manager.org.apache.juli.AsyncFileHandler.directory = ${catalina.base}/logs
 3manager.org.apache.juli.AsyncFileHandler.prefix = manager.
+3manager.org.apache.juli.AsyncFileHandler.maxDays = 90
 
 4host-manager.org.apache.juli.AsyncFileHandler.level = FINE
 4host-manager.org.apache.juli.AsyncFileHandler.directory = 
${catalina.base}/logs
 4host-manager.org.apache.juli.AsyncFileHandler.prefix = host-manager.
+4host-manager.org.apache.juli.AsyncFileHandler.maxDays = 90
 
 java.util.logging.ConsoleHandler.level = FINE
 java.util.logging.ConsoleHandler.formatter = org.apache.juli.OneLineFormatter

Modified: tomcat/trunk/java/org/apache/juli/AsyncFileHandler.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/juli/AsyncFileHandler.java?rev=1798977=1798976=1798977=diff
==
--- tomcat/trunk/java/org/apache/juli/AsyncFileHandler.java (original)
+++ tomcat/trunk/java/org/apache/juli/AsyncFileHandler.java Fri Jun 16 19:17:39 
2017
@@ -71,11 +71,15 @@ public class AsyncFileHandler extends Fi
 protected volatile boolean closed = false;
 
 public AsyncFileHandler() {
-this(null, null, null);
+this(null, null, null, DEFAULT_MAX_DAYS);
 }
 
 public AsyncFileHandler(String directory, String prefix, String suffix) {
-super(directory, prefix, suffix);
+this(directory, prefix, suffix, DEFAULT_MAX_DAYS);
+}
+
+public AsyncFileHandler(String directory, String prefix, String suffix, 
int maxDays) {
+super(directory, prefix, suffix, maxDays);
 open();
 }
 

Modified: tomcat/trunk/java/org/apache/juli/FileHandler.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/juli/FileHandler.java?rev=1798977=1798976=1798977=diff
==
--- tomcat/trunk/java/org/apache/juli/FileHandler.java (original)
+++ tomcat/trunk/java/org/apache/juli/FileHandler.java Fri Jun 16 19:17:39 2017
@@ -26,7 +26,16 @@ import java.io.OutputStream;
 import java.io.OutputStreamWriter;
 import java.io.PrintWriter;
 import java.io.UnsupportedEncodingException;
+import java.nio.file.DirectoryStream;
+import java.nio.file.Files;
+import java.nio.file.Path;
 import java.sql.Timestamp;
+import java.time.DateTimeException;
+import java.time.LocalDate;
+import java.time.format.DateTimeFormatter;
+import java.time.temporal.ChronoUnit;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
 import java.util.concurrent.locks.ReadWriteLock;
 import java.util.concurrent.locks.ReentrantReadWriteLock;
 import java.util.logging.ErrorManager;
@@ -36,6 +45,7 @@ import java.util.logging.Handler;
 import java.util.logging.Level;
 import java.util.logging.LogManager;
 import java.util.logging.LogRecord;
+import java.util.regex.Pattern;
 
 /**
  * Implementation of Handler that appends log messages to a file
@@ -74,24 +84,37 @@ import java.util.logging.LogRecord;
  *   formatter - The java.util.logging.Formatter
  *implementation class name for this Handler. Default value:
  *java.util.logging.SimpleFormatter
+ *   maxDays - The maximum number of days to keep the log
+ *files. If the specified value is =0 then the log files
+ *  

[Bug 61194] Duplicate sessions I'd is getting create

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61194

Mark Thomas  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |INVALID

--- Comment #4 from Mark Thomas  ---
Again, use the users@ mailing list.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 61194] Duplicate sessions I'd is getting create

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61194

meer.ab...@gmail.com changed:

   What|Removed |Added

 Resolution|INVALID |---
 Status|RESOLVED|REOPENED

--- Comment #3 from meer.ab...@gmail.com ---
Problem is occurring when session is getting expired after some specific time
we clear the cookie but still it shows session expired because it contains two
session same code was working with tomcat 8.0 now we migrated to 8.5.x.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 61189] CGIServlet should be able to set specific environment variables

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61189

--- Comment #1 from Konstantin Kolinko  ---
> I don't like to put them in /etc/init.d/tomcat or catalina.sh, because they
> may be lost after a Tomcat update.

The place for custom environment variables in Apache Tomcat is bin/setenv.sh.
This is documented in RUNNING.txt.

http://tomcat.apache.org/tomcat-8.5-doc/RUNNING.txt

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 61105] Roll log files by default

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61105

--- Comment #9 from Konstantin Kolinko  ---
(In reply to Violeta Georgieva from comment #8)
> Any comments?

Generally: I like it.

1. Typo in method name: obtainDateFormPath  s/Form/From/

2. Building a pattern,

> pattern = Pattern.compile("^(" + prefix + ")\\d{4}-\\d{1,2}-\\d{1,2}(" + 
> suffix + ")$");

This should use  (Pattern.quote(prefix) + "..." + Pattern.quote(suffix))

Prefix and suffix can contain special characters, e.g. '.' = any character.
Wrapping them with Pattern.quote() solves this issue.

3. Temporary directory handling in unit test

There is a base Test class that provides support for temporary directories,

https://github.com/apache/tomcat/blob/trunk/test/org/apache/catalina/startup/LoggingBaseTest.java

Differences:
- It respects system property "tomcat.test.temp"
- It uses creates a random directory for the test, to allow running several
tests in parallel
tempDir = Files.createTempDirectory(tempBasePath, "test").toFile();

Maybe it is not a good idea to use LoggingBaseTest directly as a base class,
as it initializes logging and this test tests logging, but it can be used to
copy some code.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 61195] Backport properties change to ease migration to Tomcat 9

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61195

Chuck Caldarale  changed:

   What|Removed |Added

   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 61195] New: Backport properties change to ease migration to Tomcat 9

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61195

Bug ID: 61195
   Summary: Backport properties change to ease migration to Tomcat
9
   Product: Tomcat 8
   Version: 8.5.x-trunk
  Hardware: PC
OS: Mac OS X 10.1
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
  Assignee: dev@tomcat.apache.org
  Reporter: stephane.nic...@gmail.com
  Target Milestone: 

Could you please consider backporting the properties change that were
introduced in Tomcat 9? 

My immediate need is setAcceptCount on AbstractProtocol that is called
setBacklog in the tomcat 8.5 API. Having two different method signature
requires me to use reflection in order to support Tomcat 8.5 and Tomcat 9 at
the same time in Spring Boot. As we want to support Java 9 as well in that
release, using Tomcat 9 is required but we'd like to compile the code against
the 8.5 API.

There are other candidates here:
https://svn.apache.org/viewvc?view=revisionrevision=1767250

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 61194] Duplicate sessions I'd is getting create

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61194

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #2 from Mark Thomas  ---
Bugzilla is not a support forum. Please use the users mailing list.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 61194] Duplicate sessions I'd is getting create

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61194

--- Comment #1 from mgrigorov  ---
Please provide more information.
This description is not enough to investigate the problem.
What is your setup?
In what conditions the problem occurs ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 61187] Problem with tomcat 7.0.52 version

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61187

--- Comment #7 from Dillesh  ---
(In reply to mgrigorov from comment #6)
> Please ask questions in users@ mailing list.
> BugZilla is not support forum!

Hi Team,
Thank you for your support.

Thanks
Dillesh

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 61194] New: Duplicate sessions I'd is getting create

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61194

Bug ID: 61194
   Summary: Duplicate sessions I'd is getting create
   Product: Tomcat 8
   Version: 8.5.15
  Hardware: Other
OS: Linux
Status: NEW
  Severity: critical
  Priority: P2
 Component: Cluster
  Assignee: dev@tomcat.apache.org
  Reporter: meer.ab...@gmail.com
  Target Milestone: 

In cluster environment duplicate sessions are getting created 
With different path
1:/
2:/foo
Issue is first session is getting update 
While /foo  is being idle hence session expired is not getting clear

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 61105] Roll log files by default

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61105

--- Comment #8 from Violeta Georgieva  ---
Any comments?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

JDK 9 EA Build 174 & JDK 8u152 b04 are available on jdk.java.net

[Rory O'Donnell]

Hi Mark, *
*

*JDK 9 Early Access*  build 174  is available at : - jdk.java.net/9/

A summary of all the changes in this build are listed here 
.


Changes which were introduced since the last availability email that may 
be of interest :


 * b172 - JDK-8179014 : JFileChooser with Windows look and feel crashes
   on win 10
 * b173 - JDK-8180582 : the bind to rmiregistry is rejected by
   registryFilter even though registryFilter is set
 * b174 - JDK-8181702  : deprecate for removal the following tool
   modules:jdk.xml.bind and jdk.xml.ws

*JDK 9 Schedule Update*

 * The new GA date for JDK 9 is now set to 2017-09-21 [1]
 * We have updated the OpenJDK JDK 9 project page [2] with the new
   milestones and GA date.


*JDK 8u152 Early Access*  build 04 is available at : - jdk.java.net/8/ 



A summary of all the changes in this build are listed here 
.

Information and schedules specific to OpenJDK 8u152 release [3]

Rgds,Rory

[1] http://mail.openjdk.java.net/pipermail/jdk9-dev/2017-June/005867.html
[2] http://openjdk.java.net/projects/jdk9/
[3] http://openjdk.java.net/projects/jdk8u/releases/8u152.html

--
Rgds,Rory O'Donnell
Quality Engineering Manager
Oracle EMEA , Dublin, Ireland

[Bug 61187] Problem with tomcat 7.0.52 version

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61187

mgrigorov  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |INVALID

--- Comment #6 from mgrigorov  ---
Please ask questions in users@ mailing list.
BugZilla is not support forum!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 61187] Problem with tomcat 7.0.52 version

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61187

Dillesh  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|INVALID |---

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 61187] Problem with tomcat 7.0.52 version

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=61187

--- Comment #5 from Dillesh  ---
(In reply to Mark Thomas from comment #4)
> There is not enough information in this report to enable the problem to be
> replicated for investigation.
> 
> As previously suggested, please test with the latest stable release and if
> you still experience problems please follow up on the users mailing list.
> 
> If the mailing list discussion concludes that there is a Tomcat bug, feel
> free to re-open this issue. You'll need to provide the information that
> demonstrates that there is a bug. For example, a test case that demonstrates
> it, code analysis that shows there is a problem etc.

Hi Team,
Thank you for your quick response, And please confirm below points.
Connection pool issue was in with 7.0.52 version?
And it is fixed in 7.0.78 version?
Please confirm above points
so will test with tomcat 7.0.78 version.
And will let you know the results. 

Thank you in advance.

Thanks
Dillesh

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org