Re: Tag Tomcat 7/8.0

2018-06-28 Thread Konstantin Kolinko
2018-06-28 23:11 GMT+03:00 Violeta Georgieva :
> Hi,
>
> 2018-06-26 21:16 GMT+03:00 Violeta Georgieva :
>>
>> Hi,
>>
>> I'm planning to tag Tomcat 7/8.0 tomorrow.
>> If you want to include something please reply here.
>> Please note that this will be the last Tomcat 8.0 release.
>
> I'm currently not able to build Tomcat 7/8.0 when there are no dependencies.
>
> BUILD FAILED
> C:\TOMCAT_7_0_89\build.xml:2761: The following error occurred while
> executing th
> is line:
> C:\TOMCAT_7_0_89\build.xml:3088: Failed to download
> [C:/temp/libs/tomcat-native-
> 1.2.17/tomcat-native.tar.gz]. All download sources are unavailable.
>
>
> Ant installation is 1.9.12.
> I am able to download from the browser.
>
> Do I miss something from the latest changes in the Tomcat's build?

See
https://bz.apache.org/bugzilla/show_bug.cgi?id=62164

It is not possible to download dependencies when your preferred ASF
mirror (as auto-selected by closer.lua page) uses HTTP.

This is solved by setting the property "base-apache.loc.1" in
build.properties to the root address of your preferred mirror.

In my case (see error message in comment 6 in that bug) such value is:
base-apache.loc.1=http://apache-mirror.rbc.ru/pub/apache


It may be that similar setting will be necessary for SourceForce, the
property "base-sf.loc".

I recently added checksum checks for downloaded files, so downloading
over http: should be OK.

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Tag Tomcat 7/8.0

2018-06-28 Thread Violeta Georgieva
Hi,

2018-06-26 21:16 GMT+03:00 Violeta Georgieva :
>
> Hi,
>
> I'm planning to tag Tomcat 7/8.0 tomorrow.
> If you want to include something please reply here.
> Please note that this will be the last Tomcat 8.0 release.

I'm currently not able to build Tomcat 7/8.0 when there are no dependencies.

BUILD FAILED
C:\TOMCAT_7_0_89\build.xml:2761: The following error occurred while
executing th
is line:
C:\TOMCAT_7_0_89\build.xml:3088: Failed to download
[C:/temp/libs/tomcat-native-
1.2.17/tomcat-native.tar.gz]. All download sources are unavailable.


Ant installation is 1.9.12.
I am able to download from the browser.

Do I miss something from the latest changes in the Tomcat's build?

Regards,
Violeta


[Bug 62507] Insufficient control over keystore loading to support DKS-keystores

2018-06-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62507

Kenny Stimson  changed:

   What|Removed |Added

 CC||kenny_stim...@yahoo.com
 OS||All

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1834632 - in /tomcat/tc7.0.x/tags/TOMCAT_7_0_89: ./ build.properties.default

2018-06-28 Thread violetagg
Author: violetagg
Date: Thu Jun 28 17:59:32 2018
New Revision: 1834632

URL: http://svn.apache.org/viewvc?rev=1834632=rev
Log:
Tag 7.0.89

Added:
tomcat/tc7.0.x/tags/TOMCAT_7_0_89/   (props changed)
  - copied from r1834631, tomcat/tc7.0.x/trunk/
Modified:
tomcat/tc7.0.x/tags/TOMCAT_7_0_89/build.properties.default

Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_89/
--
bugtraq:append = false

Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_89/
--
bugtraq:label = Bugzilla ID (optional)

Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_89/
--
--- bugtraq:logregex (added)
+++ bugtraq:logregex Thu Jun 28 17:59:32 2018
@@ -0,0 +1,2 @@
+(https?\://(bz|issues)\.apache\.org/bugzilla/show_bug.cgi\?id=\d+|BZ\s?\d+)
+(\d+)

Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_89/
--
bugtraq:message = Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=%BUGID%

Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_89/
--
bugtraq:url = https://bz.apache.org/bugzilla/show_bug.cgi?id=%BUGID%

Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_89/
--
--- svn:ignore (added)
+++ svn:ignore Thu Jun 28 17:59:32 2018
@@ -0,0 +1,7 @@
+.*
+build.properties
+logs
+nbproject
+output
+work
+*.iml

Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_89/
--
--- svn:mergeinfo (added)
+++ svn:mergeinfo Thu Jun 28 17:59:32 2018
@@ -0,0 +1,3 @@
+/tomcat/tc8.0.x/trunk:1636525,1637336,1637685,1637709,1638726,1640089,1640276,1640349,1640363,1640366,1640642,1640672,1640674,1640689,1640884,1641001,1641065,1641067,1641375,1641638,1641723,1641726,1641729-1641730,1641736,1641988,1642669-1642670,1642698,1642701,1643205,1643215,1643217,1643230,1643232,1643273,1643285,1643329-1643330,1643511,1643513,1643521,1643539,1643571,1643581-1643582,1643635,1643655,1643738,1643964,1644018,1644333,1644525,1644954,1644992,1645014,1645360,1645456,1645627,1645642,1645686,1645903-1645904,1645908-1645909,1645913,1645920,1646458,1646460-1646462,1646735,1646738-1646741,1646744,1646746,1646748-1646755,1646757,1646759-1646760,1647043,1648816,1651420-1651422,1651844,1652926,1652939-1652940,1652973,1653798,1653817,1653841,1654042,1654161,1654736,1654767,1654787,1656592,1659907,1662986,1663265,1663278,1663325,1663535,1663567,1663679,1663997,1664175,1664321,1664872,1665061,1665086,1666027,1666395,1666503,1666506,1666560,1666570,1666581,1666759,1666967,1666988
 
,1667553-1667555,1667558,1667617,1667633,1667637,1667747,1667767,1667873,1668028,1668137,1668634,1669432,1669801,1669840,1669895-1669896,1670398,1670435,1670592,1670605-1670607,1670609,1670632,1670720,1670725,1670727,1670731,1671114,1672273,1672285,1673759,1674220,1674295,1675469,1675488,1675595,1675831,1676232,1676367-1676369,1676382,1676394,1676483,1676556,1676635,1678178,1679536,1679988,1680256,1681124,1681182,1681703,1681730,1681840,1681864,1681869,1682010,1682034,1682047,1682052-1682053,1682062,1682064,1682070,1682312,1682325,1682331,1682386,1684367,1684385,1685759,1685774,1685827,1685892,1687341,1688904,1689358,1689657,1689921,1692850,1693093,1693108,1693324,1694060,1694115,1694291,1694427,1694431,1694503,1694549,1694789,1694873,1694881,1695356,1695372,1695823-1695825,1696200,1696281,1696379,1696468,1700608,1700871,1700897,1700978,1701094,1701124,1701608,1701668,1701676,1701766,1701944,1702248,1702252,1702314,1702390,1702723,1702725,1702728,1702730,1702733,1702735,1702737,1702
 
739,1702742,1702744,1702748,1702751,1702754,1702758,1702760,1702763,1702766,1708779,1708782,1708806,1709314,1709670,1710347,1710442,1710448,1710490,1710574,1710578,1712226,1712229,1712235,1712255,1712618,1712649,1712655,1712860,1712899,1712903,1712906,1712913,1712926,1712975,1713185,1713262,1713287,1713613,1713621,1713872,1713976,1713994,1713998,1714004,1714013,1714059,1714538,1714580,1715189,1715207,1715544,1715549,1715637,1715639-1715645,1715667,1715683,1715866,1715978,1715981,1716216-1716217,1716355,1716414,1716421,1717208-1717209,1717257,1717283,1717288,1717291,1717421,1717517,1717529,1718797,1718840-1718843,1719348,1719357-1719358,1719400,1719491,1719737,1720235,1720396,1720442,1720446,1720450,1720463,1720658-1720660,1720756,1720816,1721813,1721818,1721831,1721861,1721867,1721882,1722523,1722527,1722800,1722926,1722941,1722997,1723130,1723440,1723488,1723890,1724434,1724674,1724792,1724803,1724902,1725128,1725131,1725154,1725167,1725911,1725921,1725929,1725963-1725965,1725970,1
 

[Bug 62507] New: Insufficient control over keystore loading to support DKS-keystores

2018-06-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62507

Bug ID: 62507
   Summary: Insufficient control over keystore loading to support
DKS-keystores
   Product: Tomcat 8
   Version: 8.5.x-trunk
  Hardware: PC
Status: NEW
  Severity: enhancement
  Priority: P2
 Component: Meta
  Assignee: dev@tomcat.apache.org
  Reporter: kenny_stim...@yahoo.com
  Target Milestone: 

This ticket has been created out of a discussion originally raised here: 
https://github.com/spring-projects/spring-boot/issues/13590

Overview:
I am trying to configure ssl using a dks-keystore through
'application.properties'. I raised a ticket with the team handling spring-boot
and they have stated that there is currently no mechanism for them to be able
to stop tomcat from calling 'java.security.KeyStore.load(InputStream, char[])'
in favor of 'java.security.KeyStore.load(URI, DomainLoadStoreParameter)'

Here is the stacktrace I provided, showing the path that is taken for the
configuration of the SSL context:
java.lang.UnsupportedOperationException: This keystore must be loaded using a
DomainLoadStoreParameter
at
sun.security.provider.DomainKeyStore.engineLoad(DomainKeyStore.java:713)
~[na:1.8.0_111]
at
sun.security.provider.DomainKeyStore$DKS.engineLoad(DomainKeyStore.java:68)
~[na:1.8.0_111]
at java.security.KeyStore.load(KeyStore.java:1445) ~[na:1.8.0_111]
at
org.apache.tomcat.util.net.SSLUtilBase.getStore(SSLUtilBase.java:136)
~[tomcat-embed-core-8.5.14.jar!/:8.5.14]
at
org.apache.tomcat.util.net.SSLHostConfigCertificate.getCertificateKeystore(SSLHostConfigCertificate.java:187)
[tomcat-embed-core-8.5.14.jar!/:8.5.14]
at
org.apache.tomcat.util.net.jsse.JSSEUtil.getKeyManagers(JSSEUtil.java:185)
[tomcat-embed-core-8.5.14.jar!/:8.5.14]
at
org.apache.tomcat.util.net.AbstractJsseEndpoint.createSSLContext(AbstractJsseEndpoint.java:112)
[tomcat-embed-core-8.5.14.jar!/:8.5.14]
at
org.apache.tomcat.util.net.AbstractJsseEndpoint.initialiseSsl(AbstractJsseEndpoint.java:85)
[tomcat-embed-core-8.5.14.jar!/:8.5.14]
at org.apache.tomcat.util.net.NioEndpoint.bind(NioEndpoint.java:225)
[tomcat-embed-core-8.5.14.jar!/:8.5.14]
at
org.apache.tomcat.util.net.AbstractEndpoint.start(AbstractEndpoint.java:978)
[tomcat-embed-core-8.5.14.jar!/:8.5.14]
at org.apache.coyote.AbstractProtocol.start(AbstractProtocol.java:628)
[tomcat-embed-core-8.5.14.jar!/:8.5.14]
at
org.apache.catalina.connector.Connector.startInternal(Connector.java:993)
[tomcat-embed-core-8.5.14.jar!/:8.5.14]
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:150)
[tomcat-embed-core-8.5.14.jar!/:8.5.14]
at
org.apache.catalina.core.StandardService.addConnector(StandardService.java:225)
[tomcat-embed-core-8.5.14.jar!/:8.5.14]
at
org.springframework.boot.context.embedded.tomcat.TomcatEmbeddedServletContainer.addPreviouslyRemovedConnectors(TomcatEmbeddedServletContainer.java:247)
[spring-boot-1.5.3.RELEASE.jar!/:1.5.3.RELEASE]
at
org.springframework.boot.context.embedded.tomcat.TomcatEmbeddedServletContainer.start(TomcatEmbeddedServletContainer.java:190)
[spring-boot-1.5.3.RELEASE.jar!/:1.5.3.RELEASE]
at
org.springframework.boot.context.embedded.EmbeddedWebApplicationContext.startEmbeddedServletContainer(EmbeddedWebApplicationContext.java:297)
[spring-boot-1.5.3.RELEASE.jar!/:1.5.3.RELEASE]
at
org.springframework.boot.context.embedded.EmbeddedWebApplicationContext.finishRefresh(EmbeddedWebApplicationContext.java:145)
[spring-boot-1.5.3.RELEASE.jar!/:1.5.3.RELEASE]
at
org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:545)
[spring-context-4.3.8.RELEASE.jar!/:4.3.8.RELEASE]
at
org.springframework.boot.context.embedded.EmbeddedWebApplicationContext.refresh(EmbeddedWebApplicationContext.java:122)
[spring-boot-1.5.3.RELEASE.jar!/:1.5.3.RELEASE]
at
org.springframework.boot.SpringApplication.refresh(SpringApplication.java:737)
[spring-boot-1.5.3.RELEASE.jar!/:1.5.3.RELEASE]
at
org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:370)
[spring-boot-1.5.3.RELEASE.jar!/:1.5.3.RELEASE]
at
org.springframework.boot.SpringApplication.run(SpringApplication.java:314)
[spring-boot-1.5.3.RELEASE.jar!/:1.5.3.RELEASE]
at
org.springframework.boot.SpringApplication.run(SpringApplication.java:1162)
[spring-boot-1.5.3.RELEASE.jar!/:1.5.3.RELEASE]
at
org.springframework.boot.SpringApplication.run(SpringApplication.java:1151)
[spring-boot-1.5.3.RELEASE.jar!/:1.5.3.RELEASE]
at [Redacted]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
~[na:1.8.0_111]
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
~[na:1.8.0_111]
at

[Bug 61632] Improve search for tcnative-1.dll on Windows when current directory is not bin/ (e.g. in Eclipse IDE, separate catalina_base)

2018-06-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=61632

--- Comment #3 from Remy Maucherat  ---
For 56676, I added bin/native as a default location for tcnative.

So ... :
- The default location can be changed to just "bin" and the testsuite should be
adjusted to reflect that
- The installer/zip should now install to bin/native to avoid the issue

Decision ?

Personally, I prefer bin/native to avoid polluting my bin folder.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 54700] Improvement: Add support for system property to specify location of APR/native library [PATCH]

2018-06-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=54700

Remy Maucherat  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #6 from Remy Maucherat  ---
After implementing 56676, I think this one is too liberal (and safe ?), so I
would rather not add it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62498] FileDirContext validate not working properly for directories

2018-06-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62498

--- Comment #5 from Martin Drößler  ---
> Note: testValidateFailure() only passes because it calls
> testValidateInternal(dummyFile, null) but it should be
> testValidateInternal(dummyFile, dummyFile) which currently fails.
Well, thats the whole point. It shouldn't pass. I didn't know that you prefer a
failing test for the correct behaviour instead of a working test to demonstrate
the wrong behaviour.


> I can't see a way to trigger this with VirtualDirContext either.
Well, I do! So let me show you:

Compare the following lines of VirtualDirContext: 215 and 305

In the second one (part of the method "doLookup") the path variable is extended
to have a trailing slash - as is should be!

But in the other (part of method "file") it's not! You check for 
> name.startsWith(path + "/")
but then do a 
> String res = name.substring(path.length())
which of course will result in "/" - which is then passed to 
> file = new File(resourcesDir, res);
and this results in exactly the described behaviour!

Do you really want me to implement a whole webapp to further demonstrate this
obvious bug?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 53411] NullPointerException in org.apache.tomcat.util.buf.CharChunk

2018-06-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=53411

Mark Thomas  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED

--- Comment #11 from Mark Thomas  ---
The improvements suggested in comment #5 have been implemented on 9.0.x and
will be included in 9.0.11 onwards.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1834599 - in /tomcat/trunk: java/org/apache/catalina/core/ java/org/apache/catalina/mapper/ webapps/docs/

2018-06-28 Thread markt
Author: markt
Date: Thu Jun 28 12:13:34 2018
New Revision: 1834599

URL: http://svn.apache.org/viewvc?rev=1834599=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=53411
Improve the handling of HTTP requests that do not explicitly specify a host 
name when no default host is configured. Also improve the tracking of changes 
to the default host as hosts are added and removed while Tomcat is running.

Modified:
tomcat/trunk/java/org/apache/catalina/core/LocalStrings.properties
tomcat/trunk/java/org/apache/catalina/core/LocalStrings_es.properties
tomcat/trunk/java/org/apache/catalina/core/LocalStrings_fr.properties
tomcat/trunk/java/org/apache/catalina/core/LocalStrings_ja.properties
tomcat/trunk/java/org/apache/catalina/core/StandardEngine.java
tomcat/trunk/java/org/apache/catalina/core/StandardEngineValve.java
tomcat/trunk/java/org/apache/catalina/mapper/LocalStrings.properties
tomcat/trunk/java/org/apache/catalina/mapper/Mapper.java
tomcat/trunk/java/org/apache/catalina/mapper/MapperListener.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/catalina/core/LocalStrings.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/LocalStrings.properties?rev=1834599=1834598=1834599=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/LocalStrings.properties 
(original)
+++ tomcat/trunk/java/org/apache/catalina/core/LocalStrings.properties Thu Jun 
28 12:13:34 2018
@@ -187,7 +187,6 @@ standardContext.workCreateException=Fail
 standardContext.workCreateFail=Failed to create work directory [{0}] for 
context [{1}]
 standardContextValve.acknowledgeException=Failed to acknowledge request with a 
100 (Continue) response
 standardEngine.jvmRouteFail=Failed to set Engine's jvmRoute attribute from 
system property
-standardEngine.noHost=No Host matches server name [{0}]
 standardEngine.notHost=Child of an Engine must be a Host
 standardEngine.notParent=Engine cannot have a parent Container
 standardHost.clientAbort=Remote Client Aborted Request, IOException: [{0}]

Modified: tomcat/trunk/java/org/apache/catalina/core/LocalStrings_es.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/LocalStrings_es.properties?rev=1834599=1834598=1834599=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/LocalStrings_es.properties 
(original)
+++ tomcat/trunk/java/org/apache/catalina/core/LocalStrings_es.properties Thu 
Jun 28 12:13:34 2018
@@ -119,7 +119,6 @@ standardContext.workCreateException = No
 standardContext.workCreateFail = No pude crear el directorio de trabajo [{0}] 
para el contexto [{1}]
 standardContextValve.acknowledgeException = No pude reconocer el requerimiento 
con una respuesta 100 (Continuar)
 standardEngine.jvmRouteFail = No pude poner el atributo jvmRoute del Motor 
para la propiedad del sistema
-standardEngine.noHost = No hay M\u00E1quina que coincida con nombre de 
servidor [{0}]
 standardEngine.notHost = El Hijo de un Motor debe de ser un M\u00E1quina
 standardEngine.notParent = El Motor no puede tener un Contenedor padre
 standardHost.clientAbort = El Cliente Remoto Abort\u00F3 el Requerimiento, 
IOException: [{0}]

Modified: tomcat/trunk/java/org/apache/catalina/core/LocalStrings_fr.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/LocalStrings_fr.properties?rev=1834599=1834598=1834599=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/LocalStrings_fr.properties 
(original)
+++ tomcat/trunk/java/org/apache/catalina/core/LocalStrings_fr.properties Thu 
Jun 28 12:13:34 2018
@@ -60,7 +60,6 @@ standardContext.startingContext=Exceptio
 standardContext.stoppingContext=Exception \u00e0 l''arr\u00eat du Context [{0}]
 standardContext.resourcesStart=Erreur lors du d\u00e9marrage des ressources 
statiques
 standardContext.urlPattern.patternWarning=ATTENTION: Le mod\u00e8le (pattern) 
URL [{0}] doit commencer par un ''/'' dans l''API Servlet 2.4
-standardEngine.noHost=Aucune h\u00f4te (host) ne correspond au nom de serveur 
[{0}]
 standardEngine.notHost=Le fils d''un moteur (child of an Engine) doit 
\u00eatre un h\u00f4te
 standardEngine.notParent=Un moteur (engine) ne peut avoir de conteneur parent 
(container)
 standardHost.invalidErrorReportValveClass=Impossible de charger la classe 
valve de rapport d''erreur: [{0}]

Modified: tomcat/trunk/java/org/apache/catalina/core/LocalStrings_ja.properties
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/LocalStrings_ja.properties?rev=1834599=1834598=1834599=diff
==
--- tomcat/trunk/java/org/apache/catalina/core/LocalStrings_ja.properties 
(original)

[Bug 62501] New: Race condition (?) in session attribute replication

2018-06-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62501

Bug ID: 62501
   Summary: Race condition (?) in session attribute replication
   Product: Tomcat 9
   Version: 9.0.8
  Hardware: PC
OS: Linux
Status: NEW
  Severity: major
  Priority: P2
 Component: Cluster
  Assignee: dev@tomcat.apache.org
  Reporter: antosh...@mail.ru
  Target Milestone: -

Default cluster configuration from documentation (SimpleTcpCluster). 2 nodes. 
I implemented javax.servlet.Filter to add some data to a session just after
login. And from time to time it does not replicated on stand by server. To
investigate problem i connected to tomcat with remote debug and added some
debug messages. Here is output:

1) session created 0BDAA9C29A23767A928DD59A6AC30F4E
2) receive session id change
SESSION-ID-CHANGED#localhost#/Midlevel#0BDAA9C29A23767A928DD59A6AC30F4E, found
delta session DeltaSession[0BDAA9C29A23767A928DD59A6AC30F4E]
3) execute id change: old id = 0BDAA9C29A23767A928DD59A6AC30F4E new id =
C760E8517DE686E79A1D08DD8A685465
4) handleSESSION_DELTA delta session id = C760E8517DE686E79A1D08DD8A685465
found session = DeltaSession[C760E8517DE686E79A1D08DD8A685465]
5) receive session id change
SESSION-ID-CHANGED#localhost#/Midlevel#C760E8517DE686E79A1D08DD8A685465 delta
session DeltaSession[C760E8517DE686E79A1D08DD8A685465]
6) handleSESSION_DELTA delta session id = 21952C40B449448726888BFEF0263FAD
found session = null
7) execute id change: old id = C760E8517DE686E79A1D08DD8A685465 new id =
21952C40B449448726888BFEF0263FAD

on line 5) standby receive command to change id, but before change id happens
delta message (already with new id) was received and not found session as a
result session attribute was lost.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62164] Build for Eclipse IDE does not work

2018-06-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62164

--- Comment #7 from Konstantin Kolinko  ---
(In reply to Konstantin Kolinko from comment #6)
> (In reply to Mark Thomas from comment #3)
> > I can understand Ant not allowing an https -> http redirect but I'm not sure
> > why http -> https isn't allowed.
> > 
> 
> This is actually a regression in Apache Ant 1.9.10+.
> The code of Get task was broken during a checkstyle cleanup.
> 
> I filed this into Bugzilla for Apache Ant:
> https://bz.apache.org/bugzilla/show_bug.cgi?id=62499

The bug in Apache Ant have been fixed. The fix will be available in the next
releases of 1.9.x and 1.10.x.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 56676] Normalize access to native library

2018-06-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=56676

Remy Maucherat  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Remy Maucherat  ---
Thanks for the suggestion, but I used bin/native for the default location.
Implemented for 9.0.11. There are no backports plans at the moment.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1834595 - in /tomcat/trunk: java/org/apache/tomcat/jni/Library.java webapps/docs/changelog.xml

2018-06-28 Thread remm
Author: remm
Date: Thu Jun 28 11:15:33 2018
New Revision: 1834595

URL: http://svn.apache.org/viewvc?rev=1834595=rev
Log:
56676: Use bin/native as a default location for the native libraries. 
bin/native is already used by the testsuite, and it can be useful for 
development and embedded. I don't plan to backport the change.

Modified:
tomcat/trunk/java/org/apache/tomcat/jni/Library.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/tomcat/jni/Library.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/jni/Library.java?rev=1834595=1834594=1834595=diff
==
--- tomcat/trunk/java/org/apache/tomcat/jni/Library.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/jni/Library.java Thu Jun 28 11:15:33 
2018
@@ -34,12 +34,13 @@ public final class Library {
 
 private Library() throws Exception {
 boolean loaded = false;
-String path = System.getProperty("java.library.path");
-String [] paths = path.split(File.pathSeparator);
 StringBuilder err = new StringBuilder();
+File binLib = new File(System.getProperty("catalina.home"), "bin");
+File nativeLib = new File(binLib, "native");
 for (int i = 0; i < NAMES.length; i++) {
+File library = new File(nativeLib, 
System.mapLibraryName(NAMES[i]));
 try {
-System.loadLibrary(NAMES[i]);
+System.load(library.getPath());
 loaded = true;
 } catch (ThreadDeath t) {
 throw t;
@@ -48,13 +49,9 @@ public final class Library {
 // the JNI code identical between Tomcat 6/7/8/9
 throw t;
 } catch (Throwable t) {
-String name = System.mapLibraryName(NAMES[i]);
-for (int j = 0; j < paths.length; j++) {
-java.io.File fd = new java.io.File(paths[j] , name);
-if (fd.exists()) {
-// File exists but failed to load
-throw t;
-}
+if (library.exists()) {
+// File exists but failed to load
+throw t;
 }
 if (i > 0) {
 err.append(", ");
@@ -66,6 +63,38 @@ public final class Library {
 }
 }
 if (!loaded) {
+String path = System.getProperty("java.library.path");
+String [] paths = path.split(File.pathSeparator);
+for (int i = 0; i < NAMES.length; i++) {
+try {
+System.loadLibrary(NAMES[i]);
+loaded = true;
+} catch (ThreadDeath t) {
+throw t;
+} catch (VirtualMachineError t) {
+// Don't use a Java 7 multiple exception catch so we can 
keep
+// the JNI code identical between Tomcat 6/7/8/9
+throw t;
+} catch (Throwable t) {
+String name = System.mapLibraryName(NAMES[i]);
+for (int j = 0; j < paths.length; j++) {
+java.io.File fd = new java.io.File(paths[j] , name);
+if (fd.exists()) {
+// File exists but failed to load
+throw t;
+}
+}
+if (i > 0) {
+err.append(", ");
+}
+err.append(t.getMessage());
+}
+if (loaded) {
+break;
+}
+}
+}
+if (!loaded) {
 StringBuilder names = new StringBuilder();
 for (String name : NAMES) {
 names.append(name);

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1834595=1834594=1834595=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Thu Jun 28 11:15:33 2018
@@ -64,6 +64,10 @@
 reduce the use of ThreadLocals and to increase the use of caching.
 (markt)
   
+  
+56676: Add a default location for the native library, as
+bin/native, which the testsuite already uses. (remm)
+  
 
   
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62498] FileDirContext validate not working properly for directories

2018-06-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62498

--- Comment #4 from Mark Thomas  ---
I can't see a way to trigger this with VirtualDirContext either. Awaiting
reproduction steps from a clean Tomcat install.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62498] FileDirContext validate not working properly for directories

2018-06-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62498

--- Comment #3 from Mark Thomas  ---
Note: The provided test cases will fail on Windows.

Note: testValidateFailure() only passes because it calls
testValidateInternal(dummyFile, null) but it should be
testValidateInternal(dummyFile, dummyFile) which currently fails.

I don't see a way for this failure to occur in a standard directory deployment.
There is code in FileDirContext that explicitly prevents this problem from
occurring.

It may be possible to trigger the issue with VirtualDirContext. I'll take a
look.

What are the steps to trigger this issue starting from a clean install of the
latest Tomcat 7.0.x release? I suspect a fix, if required, is required
somewhere other than where proposed but to be able be sure we need to be able
to reproduce it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62273] Add support for alternate URL specification

2018-06-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62273

--- Comment #20 from Mark Thomas  ---
The status is:
- Browser behaviour is inconsistent between browsers
  https://cwiki.apache.org/confluence/display/TOMCAT/Encoding+and+URIs
- Browser behaviour appears to be inconsistent with the spec the browsers are
  working to although it isn't the easiest spec to read
- Tomcat implements RFC7230 / RFC3986 by default
- Users can configure relaxedPathChars and/or relaxedQueryChars on the
  Connector as required

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62273] Add support for alternate URL specification

2018-06-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62273

--- Comment #19 from remmeier  ---
what is now the conclusion of this topic? since the topic has been resolved(?).
The change is still breaking and not aligned with what the major browser
vendors do as far as I understand?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1834585 - /tomcat/jk/trunk/HOWTO-RELEASE.txt

2018-06-28 Thread markt
Author: markt
Date: Thu Jun 28 09:27:14 2018
New Revision: 1834585

URL: http://svn.apache.org/viewvc?rev=1834585=rev
Log:
Fix typo

Modified:
tomcat/jk/trunk/HOWTO-RELEASE.txt

Modified: tomcat/jk/trunk/HOWTO-RELEASE.txt
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/HOWTO-RELEASE.txt?rev=1834585=1834584=1834585=diff
==
--- tomcat/jk/trunk/HOWTO-RELEASE.txt (original)
+++ tomcat/jk/trunk/HOWTO-RELEASE.txt Thu Jun 28 09:27:14 2018
@@ -150,7 +150,7 @@ Build binaries and upload distributions
 
 Build mod_jk for a specific web server and OS.  Package it as appropriate for
 the OS and sign the archive using PGP. Please include the ASF License, the
-generated docs, and the tools.  Please name the distribuiton as follows:
+generated docs, and the tools.  Please name the distribution as follows:
 
 tomcat-connectors-{version}-{os-version-cpu}-{web server-version}.(tar.gz|zip)
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62500] Add Shell Script to Create CATALINA_BASE Directories

2018-06-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62500

--- Comment #11 from Michael Osipov <1983-01...@gmx.net> ---
(In reply to Igal Sapir from comment #7)
> (In reply to Michael Osipov from comment #4)
> > (In reply to Igal Sapir from comment #3)
> > > > Shall I share?
> > > 
> > > Sure, why not :)
> > 
> > Will do tomorrow as soon as I get access to our company's Subversion server.
> 
> Michael, I just realized that you are a committer.  If you want to take this
> one yourself then that's fine by me - please let me know.  
> 
> Otherwise I will take your files and edit if/as needed.

Not necessary, you raised the issue. Attached my scripts and a sample
server.xml I use for filtering. Scripts only differ for platform specific
things and stuff I need at work, but 90 % are reusable.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62500] Add Shell Script to Create CATALINA_BASE Directories

2018-06-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62500

--- Comment #10 from Michael Osipov <1983-01...@gmx.net> ---
Created attachment 35997
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=35997=edit
Sample server.xml for filtering with sed(1)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62500] Add Shell Script to Create CATALINA_BASE Directories

2018-06-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62500

--- Comment #9 from Michael Osipov <1983-01...@gmx.net> ---
Created attachment 35996
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=35996=edit
Create instance on FreeBSD

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62500] Add Shell Script to Create CATALINA_BASE Directories

2018-06-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62500

--- Comment #8 from Michael Osipov <1983-01...@gmx.net> ---
Created attachment 35995
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=35995=edit
Create instance on HP-UX

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62498] FileDirContext validate not working properly for directories

2018-06-28 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62498

--- Comment #2 from Martin Drößler  ---
Created attachment 35994
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=35994=edit
TestCase

I attached a TestCase to demonstrate the behaviour.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org