SSL Unit Tests Failing

2018-10-01 Thread Igal Sapir
When trying to run the unit test cases with `ant clean test` on the current
trunk [1] I am getting two (per connector) failures:

org.apache.tomcat.util.net.openssl.ciphers.TestCipher FAILED [2]

org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfigurationParser
FAILED [3]

Server version: Apache Tomcat/9.0.13-dev
Server built:   Oct 2 2018 05:24:55 UTC
Server number:  9.0.13.0
OS Name:Linux
OS Version: 4.18.9-200.fc28.x86_64
Architecture:   amd64
JVM Version:1.8.0_181-b13
JVM Vendor: Oracle Corporation

Am I missing something?  Other than the obvious "missing ciphers", that is.

Thanks,

Igal

[1] git-svn-id: https://svn.apache.org/repos/asf/tomcat/trunk@1842498
13f79535-47bb-0310-9956-ffa450edef68

[2] Testsuite: org.apache.tomcat.util.net.openssl.ciphers.TestCipher
Tests run: 3, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 0.697 sec

Testcase: testNames took 0.168 sec
Testcase: testAllOpenSSLCiphersMapped took 0.361 sec
FAILED
No mapping found in IBM's JSSE implementation for
ECDHE-PSK-3DES-EDE-CBC-SHA+TLSv1 when one was expected

junit.framework.AssertionFailedError: No mapping found in IBM's JSSE
implementation for ECDHE-PSK-3DES-EDE-CBC-SHA+TLSv1 when one was expected

at
org.apache.tomcat.util.net.openssl.ciphers.TestCipher.testAllOpenSSLCiphersMapped(TestCipher.java:66)

Testcase: testOpenSSLCipherAvailability took 0.06 sec
FAILED
ECDHE-ARIA128-GCM-SHA256+TLSv1.2 DHE-RSA-ARIA128-GCM-SHA256+TLSv1.2
DHE-DSS-ARIA256-GCM-SHA384+TLSv1.2 ECDHE-ECDSA-ARIA128-GCM-SHA256+TLSv1.2
ARIA256-GCM-SHA384+TLSv1.2 ECDHE-ARIA256-GCM-SHA384+TLSv1.2
DHE-RSA-ARIA256-GCM-SHA384+TLSv1.2 RSA-PSK-ARIA256-GCM-SHA384+TLSv1.2
ECDHE-ECDSA-ARIA256-GCM-SHA384+TLSv1.2 ARIA128-GCM-SHA256+TLSv1.2
DHE-PSK-ARIA128-GCM-SHA256+TLSv1.2 RSA-PSK-ARIA128-GCM-SHA256+TLSv1.2
DHE-DSS-ARIA128-GCM-SHA256+TLSv1.2 PSK-ARIA256-GCM-SHA384+TLSv1.2
DHE-PSK-ARIA256-GCM-SHA384+TLSv1.2 PSK-ARIA128-GCM-SHA256+TLSv1.2
expected:<0> but was:<16>
junit.framework.AssertionFailedError: ECDHE-ARIA128-GCM-SHA256+TLSv1.2
DHE-RSA-ARIA128-GCM-SHA256+TLSv1.2 DHE-DSS-ARIA256-GCM-SHA384+TLSv1.2
ECDHE-ECDSA-ARIA128-GCM-SHA256+TLSv1.2 ARIA256-GCM-SHA384+TLSv1.2
ECDHE-ARIA256-GCM-SHA384+TLSv1.2 DHE-RSA-ARIA256-GCM-SHA384+TLSv1.2
RSA-PSK-ARIA256-GCM-SHA384+TLSv1.2 ECDHE-ECDSA-ARIA256-GCM-SHA384+TLSv1.2
ARIA128-GCM-SHA256+TLSv1.2 DHE-PSK-ARIA128-GCM-SHA256+TLSv1.2
RSA-PSK-ARIA128-GCM-SHA256+TLSv1.2 DHE-DSS-ARIA128-GCM-SHA256+TLSv1.2
PSK-ARIA256-GCM-SHA384+TLSv1.2 DHE-PSK-ARIA256-GCM-SHA384+TLSv1.2
PSK-ARIA128-GCM-SHA256+TLSv1.2  expected:<0> but was:<16>
at
org.apache.tomcat.util.net.openssl.ciphers.TestCipher.testOpenSSLCipherAvailability(TestCipher.java:100)

[3] Testsuite:
org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfigurationParser
Tests run: 86, Failures: 40, Errors: 0, Skipped: 1, Time elapsed: 5.473 sec
- Standard Error -
Error in cipher list
140015003477824:error:1410D0B9:SSL routines:SSL_CTX_set_cipher_list:no
cipher match:ssl/ssl_lib.c:2193:

Error in cipher list
140182557382464:error:1410D0B9:SSL routines:SSL_CTX_set_cipher_list:no
cipher match:ssl/ssl_lib.c:2193:

Error in cipher list
140372866819904:error:1410D0B9:SSL routines:SSL_CTX_set_cipher_list:no
cipher match:ssl/ssl_lib.c:2193:

Error in cipher list
139680405661504:error:1410D0B9:SSL routines:SSL_CTX_set_cipher_list:no
cipher match:ssl/ssl_lib.c:2193:

Error in cipher list
140699554305856:error:1410D0B9:SSL routines:SSL_CTX_set_cipher_list:no
cipher match:ssl/ssl_lib.c:2193:

Error in cipher list
139897177433920:error:1410D0B9:SSL routines:SSL_CTX_set_cipher_list:no
cipher match:ssl/ssl_lib.c:2193:

Error in cipher list
139891985295168:error:1410D0B9:SSL routines:SSL_CTX_set_cipher_list:no
cipher match:ssl/ssl_lib.c:2193:

Error in cipher list
140442752255808:error:1410D0B9:SSL routines:SSL_CTX_set_cipher_list:no
cipher match:ssl/ssl_lib.c:2193:

Error in cipher list
139855064180544:error:1410D0B9:SSL routines:SSL_CTX_set_cipher_list:no
cipher match:ssl/ssl_lib.c:2193:

Error in cipher list
140598129956672:error:1410D0B9:SSL routines:SSL_CTX_set_cipher_list:no
cipher match:ssl/ssl_lib.c:2193:

Error in cipher list
139768227612480:error:1410D0B9:SSL routines:SSL_CTX_set_cipher_list:no
cipher match:ssl/ssl_lib.c:2193:

Error in cipher list
139839666202432:error:1410D0B9:SSL routines:SSL_CTX_set_cipher_list:no
cipher match:ssl/ssl_lib.c:2193:

Error in cipher list
140216997062464:error:1410D0B9:SSL routines:SSL_CTX_set_cipher_list:no
cipher match:ssl/ssl_lib.c:2193:

Error in cipher list
140194450589504:error:1410D0B9:SSL routines:SSL_CTX_set_cipher_list:no
cipher match:ssl/ssl_lib.c:2193:

Error in cipher list
140636605155136:error:1410D0B9:SSL routines:SSL_CTX_set_cipher_list:no
cipher match:ssl/ssl_lib.c:2193:



Testcase: testARIA128 took 0.535 sec
FAILED
Expected 8 ciphers but got 0 for the specification 'ARIA128'
expected:<[TLS_DHE_DSS_WITH_ARIA_128_GCM_SHA256,

[GUMP@vmgump-vm3]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed

2018-10-01 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-test-nio2 has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 3 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-test-nio2 :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...


Full details are available at:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-test-nio2/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on bnd exists, no need to add for property bndlib.jar.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/logs-NIO2
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO2/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO2/logs]



The following work was performed:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-test-nio2/gump_work/build_tomcat-trunk_tomcat-trunk-test-nio2.html
Work Name: build_tomcat-trunk_tomcat-trunk-test-nio2 (Type: Build)
Work ended in a state of : Failed
Elapsed: 24 mins 20 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only -Dsun.zip.disableMemoryMapping=true 
org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Djava.net.preferIPv4Stack=/srv/gump/public/workspace/tomcat-trunk/true 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.7-SNAPSHOT.jar
 -Dtest.reports=output/logs-NIO2 -Dexecute.test.nio2=true 
-Dexamples.sources.skip=true 
-Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.7.3a-201803300640/ecj-4.7.3a.jar
 -Dbndlib.jar=/srv/gump/packages/bnd/bndlib-4.0.0/biz.aQute.bndlib-4.0.0.jar 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/target/commons-daemon-1.1.1-SNAPSHOT.jar
 
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-master/dest-20181002/bin/openssl
 -Dtest.temp=output/test-tmp-NIO2
  -Dtest.accesslog=true -Dexecute.test.nio=false 
-Dbnd.jar=/srv/gump/packages/bnd/bnd-4.0.0/biz.aQute.bnd-4.0.0.jar 
-Dexecute.test.apr=false -Dtest.excludePerformance=true -Dtest.relaxTiming=true 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.7-SNAPSHOT.jar
 -Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja
 

Re: Bugzilla permanent CC addresses

2018-10-01 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Mark,

On 10/1/18 15:10, Mark Thomas wrote:
> On 01/10/18 20:04, Christopher Schultz wrote:
>> All,
>> 
>> Does anyone know why these two email addresses are CC'd every
>> time a BZ message is sent?
>> 
>> kakvi...@yahoo.co.in usma...@ieml.ru
> 
> Because those two users have configured their accounts to be CC'd
> on every Tomcat issue.
> 
> I haven't see anything that suggests mail to those addresses is 
> bouncing. Have you?

No errors. Just curious why they were being CC'd. Can any random
person on the Internet register for that, or are those
administratively-added to the Bugzilla instance/products/components?

I can't imagine why anyone would want to get an email about everything
in ASF Bugzilla. Just seems fishy.

- -chris
-BEGIN PGP SIGNATURE-
Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/

iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAluyt6AACgkQHPApP6U8
pFjpug//U4GO8cyKRoIAUKhJOo9uNMjyCcgVlchepO17z/QJpWV6Ns2BGUo3+/pB
pOM+5YtGW51ojGixW9LI/q4kd1vnucEyOOes5S/JdR2QtAfo8NjbTNsTkwZdzOtD
9Jd0N4eOPGTySA7zzZkg35fcDvogD5DJiKmAUFiBjoifxKLj/Akd1+89uo8RAw/w
KjCw3VMJmOrjq2n0ou+jJ3gQz4mRgDAWdnD3WK9LW4UMoaat6JU1P2SXi4mQxeiy
edylMmxegR01Xk5Kbvmd8Ay5FjYdIN5UpUOlTHYinEN7ed2VvQDpSP5wAAESQ1Q6
vJk5rSfsFLjoQToJVZl4Dm5sEudwluRQUw3LXrO1ZVwO9l/aMGu7L6BX1sOAYPva
/t8mlB117+o/0XprQ/D2PSb4nGsiBPp99WJWA+Y7oskWBAy9hc8oQJOROfjmr7JN
V+zWvwkc6mo0/4N0b4TV8PmCRUZzgs73C3vXZ84jvITpX4lBUaQkCU1dLY+GZrmb
CgZNsW9S/iFrjpTg2QXwbjLTGckqWxcHAbWygReC3jzVGyDwhQUuG/fRPvBN1dDy
YHs7DvCS8A3GF4ABw5CMhGIswioJWEHi90EEqV8P0ojog43naFG0HojAdlDvkm8d
EiljRnzcE0fDJ8S44wKSm6mgcS6Vl3hG1H4H4PUy8+1cvtgrcDQ=
=r1ux
-END PGP SIGNATURE-

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62788] New: Add explicit ".encoding=UTF-8" to FileHandler configurations in logging.properties

2018-10-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62788

Bug ID: 62788
   Summary: Add explicit ".encoding=UTF-8" to FileHandler
configurations in logging.properties
   Product: Tomcat 9
   Version: 9.0.12
  Hardware: PC
Status: NEW
  Severity: enhancement
  Priority: P2
 Component: Catalina
  Assignee: dev@tomcat.apache.org
  Reporter: knst.koli...@gmail.com
  Target Milestone: -

This is inspired by a StackOverflow question [1].

While most of Tomcat 8.5/9.0 uses UTF-8 by default, the default configuration
of (Async)FileHandlers in logging.properties is to use the system default
character set.

1. There is no configuration for the "encoding" property of those FileHandlers
in the default 'logging.properties' file.

2. The default value for that property is to use the system default character
set. As documented in javadoc [2].


I find this odd.

My proposal is to add explicit configuration for the 'encoding' property of
AsyncFileHandlers in Tomcat 9.0.x onwards to be 'UTF-8':

1catalina.org.apache.juli.AsyncFileHandler.encoding = UTF-8

etc.


I think that for a ConsoleHandler [3] it is expected to use the system
encoding. It is used for monitoring at development time, and should not be used
on a production system.

I think that a file written by a FileHandler is expected to preserve all
information written to it, and UTF-8 suits better for this purpose.


[1]
https://stackoverflow.com/questions/52591511/how-to-set-character-encoding-to-servletcontext-logs-in-tomcat

[2]
http://tomcat.apache.org/tomcat-9.0-doc/api/org/apache/juli/FileHandler.html

[3]
https://docs.oracle.com/javase/6/docs/api/java/util/logging/ConsoleHandler.html

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62757] JspCompilationContext is unable to compile class for JSP due to a null tagHandlerClass in Generator.TagHandlerInfo

2018-10-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62757

--- Comment #5 from Jordi Llach  ---
Thanks for the feedback, I can perfectly understand the rationale of your
comment

As said the problem is in JspServletWrapper's loadTagFile method, it should
check whether it has to reload or not by only checking the reload attribute,
and not by using getReloadInternal() method. Otherwise during application
startup JspRuntimeContext's checkCompile method can prevent some tag files to
be loaded, because it changes the value of the flag compileCheckInProgress, as
we saw in the stacktrace that comes from the TagFileProcessor.

I also noticed that JspServletWrapper's getDependants and loadTagFile methods
change reload attribute without proper synchronization, as JspServletWrapper's
getServlet and setServletClassLastModifiedTime do, so I "fixed" it, but that
was not the problem, maybe unnecessary ?

Maybe I am wrong but I also realized that JspServletWrapper's getServlet method
should execute always in case JspServletWrapper's attribute theServlet is null.
With the previous code JspRuntimeContext's checkCompile method could prevent a
first request to a jsp to initialize its JspServletWrapper's attribute
theServlet because it set compileCheckInProgress to true and thus
getReloadInternal method returns false

About TagFileProcessor change, I just fully initialized JspServletWrapper's
JspCompilationContext prior puting the former into the Map managed by
JspRuntimeContext. The rationale behind this change is that given that
JspRuntimeContext's checkCompile will iterate through this Map of jsp/tags I
just wanted to ensure that their content is fully initialized.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Bug 62140 implementation question

2018-10-01 Thread Marek Czernek

Hi there,

I'd like to resolve Bug 62140 [0]. I just wanted to gather some opinions 
about the implementation details. In my mind, the following solution is 
quite reasonable:


1. Create new help scripts, such as help.sh and help.bat. These files
   contain a method for each functional verb that prints some info
   about the verb and exits with 0.
2. Source the files in both catalina.sh and catalina.bat
3. When user enters catalina.[sh|bat] $verb help (or -h, --help?),
   execute one of the methods.

In my mind, the above solution is quite straightforward. Any gotchas, or 
obvious problems?


[0] https://bz.apache.org/bugzilla/show_bug.cgi?id=62140

Cheers,
--

Marek Czernek

JWS/JBCS Associate Quality Engineer, RHCA

Find me at www.halfastack.com



[Bug 62757] JspCompilationContext is unable to compile class for JSP due to a null tagHandlerClass in Generator.TagHandlerInfo

2018-10-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62757

--- Comment #4 from Mark Thomas  ---
I can't tell which part of the patch is addressing this issue and which parts
are addressing other issues - or what those issues are. Given I've already
managed to introduce a regression here I'm hesitant to make more changes than I
need to - especially without an explanation of why those changes are required.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Proposed patch for o.a.c.users.MemoryUserDatabase

2018-10-01 Thread Igal Sapir

On 10/1/2018 12:08 PM, Mark Thomas wrote:

On 27/09/18 16:57, Christopher Schultz wrote:

All,

I have a proposed patch to MemoryUserDatabase that changes the
behavior when a triggered-reload fails. Recently, markt added code to
allow database reloads, but if there is an error reloading the
database, the database is emptied and perhaps an administrator can no
longer make e.g. calls to the manager.

This patch makes an open-failure into a no-op: the user database will
not be changed unless there is a successful load from the file.

Seems reasonable to me.


This patch changes the way that data is loaded by the Digester.
Instead of modifying the role/group/user maps directly, the data are
loaded into new maps and then all maps are updated atomically.

This patch removes a bunch of code from this class, and I have a unit
test (not attached) which demonstrates that (a) it works and (b)
thread-safety is maintained.

Woot for less code ;)


+1

Igal


Mark



Thanks,
-chris

For review:

### Eclipse Workspace Patch 1.0
#P tomcat-trunk
Index: java/org/apache/catalina/users/MemoryUserDatabase.java
===
--- java/org/apache/catalina/users/MemoryUserDatabase.java  (revision
1842017)
+++ java/org/apache/catalina/users/MemoryUserDatabase.java  (working copy)
@@ -31,6 +31,7 @@
  import java.util.concurrent.ConcurrentHashMap;
  import java.util.concurrent.locks.Lock;
  import java.util.concurrent.locks.ReentrantReadWriteLock;
+import java.util.regex.Pattern;

  import org.apache.catalina.Globals;
  import org.apache.catalina.Group;
@@ -39,11 +40,10 @@
  import org.apache.catalina.UserDatabase;
  import org.apache.juli.logging.Log;
  import org.apache.juli.logging.LogFactory;
-import org.apache.tomcat.util.digester.AbstractObjectCreationFactory;
+import org.apache.tomcat.util.digester.CallParamRule;
  import org.apache.tomcat.util.digester.Digester;
  import org.apache.tomcat.util.file.ConfigFileLoader;
  import org.apache.tomcat.util.res.StringManager;
-import org.xml.sax.Attributes;

  /**
   * Concrete implementation of {@link UserDatabase} that loads all
defined users,
@@ -107,7 +107,7 @@
  /**
   * The set of {@link Group}s defined in this database, keyed by
group name.
   */
-protected final Map groups = new
ConcurrentHashMap<>();
+protected Map groups = new ConcurrentHashMap<>();

  /**
   * The unique global identifier of this user database.
@@ -140,12 +140,12 @@
  /**
   * The set of {@link Role}s defined in this database, keyed by
role name.
   */
-protected final Map roles = new ConcurrentHashMap<>();
+protected Map roles = new ConcurrentHashMap<>();

  /**
   * The set of {@link User}s defined in this database, keyed by
user name.
   */
-protected final Map users = new ConcurrentHashMap<>();
+protected Map users = new ConcurrentHashMap<>();

  private final ReentrantReadWriteLock dbLock = new
ReentrantReadWriteLock();
  private final Lock readLock = dbLock.readLock();
@@ -415,54 +415,139 @@
   */
  @Override
  public void open() throws Exception {
+String pathName = getPathname();
+URI uri = ConfigFileLoader.getURI(pathName);
+URL url = uri.toURL();
+URLConnection uConn = url.openConnection();

-writeLock.lock();
-try {
-// Erase any previous groups and users
-users.clear();
-groups.clear();
-roles.clear();
+try (InputStream is = uConn.getInputStream()) {
+this.lastModified = uConn.getLastModified();

-String pathName = getPathname();
-URI uri = ConfigFileLoader.getURI(pathName);
-URL url = uri.toURL();
-URLConnection uConn = url.openConnection();
+// Construct a digester to read the XML input file
+Digester digester = new Digester();
+try {
+digester.setFeature(
+
"http://apache.org/xml/features/allow-java-encodings;, true);
+} catch (Exception e) {
+
log.warn(sm.getString("memoryUserDatabase.xmlFeatureEncoding"), e);
+}

-try (InputStream is = uConn.getInputStream()) {
-this.lastModified = uConn.getLastModified();
+Bundle bundle = new Bundle();
+digester.push(bundle);
+digester.addCallMethod("tomcat-users/role", "addRole", 2);
+digester.addRule("tomcat-users/role", new
CallParamRule(0, "rolename"));
+digester.addRule("tomcat-users/role", new
CallParamRule(1, "description"));
+digester.addCallMethod("tomcat-users/group", "addGroup", 3);
+digester.addRule("tomcat-users/group", new
CallParamRule(0, "groupname"));
+digester.addRule("tomcat-users/group", new
CallParamRule(1, "description"));
+digester.addRule("tomcat-users/group", new
CallParamRule(2, "roles"));
+

[Bug 62739] Tomcat should allow blank Host header

2018-10-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62739

--- Comment #3 from Mark Thomas  ---
Is there an ETA on your fix? We have reached the start of the month and I
expect we'll want to tag a new version with this fix included in the next few
days.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Bugzilla permanent CC addresses

2018-10-01 Thread Mark Thomas
On 01/10/18 20:04, Christopher Schultz wrote:
> All,
> 
> Does anyone know why these two email addresses are CC'd every time a
> BZ message is sent?
> 
> kakvi...@yahoo.co.in
> usma...@ieml.ru

Because those two users have configured their accounts to be CC'd on
every Tomcat issue.

I haven't see anything that suggests mail to those addresses is
bouncing. Have you?

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: Proposed patch for o.a.c.users.MemoryUserDatabase

2018-10-01 Thread Mark Thomas
On 27/09/18 16:57, Christopher Schultz wrote:
> All,
> 
> I have a proposed patch to MemoryUserDatabase that changes the
> behavior when a triggered-reload fails. Recently, markt added code to
> allow database reloads, but if there is an error reloading the
> database, the database is emptied and perhaps an administrator can no
> longer make e.g. calls to the manager.
> 
> This patch makes an open-failure into a no-op: the user database will
> not be changed unless there is a successful load from the file.

Seems reasonable to me.

> This patch changes the way that data is loaded by the Digester.
> Instead of modifying the role/group/user maps directly, the data are
> loaded into new maps and then all maps are updated atomically.
> 
> This patch removes a bunch of code from this class, and I have a unit
> test (not attached) which demonstrates that (a) it works and (b)
> thread-safety is maintained.
Woot for less code ;)

Mark


> 
> Thanks,
> -chris
> 
> For review:
> 
> ### Eclipse Workspace Patch 1.0
> #P tomcat-trunk
> Index: java/org/apache/catalina/users/MemoryUserDatabase.java
> ===
> --- java/org/apache/catalina/users/MemoryUserDatabase.java(revision
> 1842017)
> +++ java/org/apache/catalina/users/MemoryUserDatabase.java(working copy)
> @@ -31,6 +31,7 @@
>  import java.util.concurrent.ConcurrentHashMap;
>  import java.util.concurrent.locks.Lock;
>  import java.util.concurrent.locks.ReentrantReadWriteLock;
> +import java.util.regex.Pattern;
> 
>  import org.apache.catalina.Globals;
>  import org.apache.catalina.Group;
> @@ -39,11 +40,10 @@
>  import org.apache.catalina.UserDatabase;
>  import org.apache.juli.logging.Log;
>  import org.apache.juli.logging.LogFactory;
> -import org.apache.tomcat.util.digester.AbstractObjectCreationFactory;
> +import org.apache.tomcat.util.digester.CallParamRule;
>  import org.apache.tomcat.util.digester.Digester;
>  import org.apache.tomcat.util.file.ConfigFileLoader;
>  import org.apache.tomcat.util.res.StringManager;
> -import org.xml.sax.Attributes;
> 
>  /**
>   * Concrete implementation of {@link UserDatabase} that loads all
> defined users,
> @@ -107,7 +107,7 @@
>  /**
>   * The set of {@link Group}s defined in this database, keyed by
> group name.
>   */
> -protected final Map groups = new
> ConcurrentHashMap<>();
> +protected Map groups = new ConcurrentHashMap<>();
> 
>  /**
>   * The unique global identifier of this user database.
> @@ -140,12 +140,12 @@
>  /**
>   * The set of {@link Role}s defined in this database, keyed by
> role name.
>   */
> -protected final Map roles = new ConcurrentHashMap<>();
> +protected Map roles = new ConcurrentHashMap<>();
> 
>  /**
>   * The set of {@link User}s defined in this database, keyed by
> user name.
>   */
> -protected final Map users = new ConcurrentHashMap<>();
> +protected Map users = new ConcurrentHashMap<>();
> 
>  private final ReentrantReadWriteLock dbLock = new
> ReentrantReadWriteLock();
>  private final Lock readLock = dbLock.readLock();
> @@ -415,54 +415,139 @@
>   */
>  @Override
>  public void open() throws Exception {
> +String pathName = getPathname();
> +URI uri = ConfigFileLoader.getURI(pathName);
> +URL url = uri.toURL();
> +URLConnection uConn = url.openConnection();
> 
> -writeLock.lock();
> -try {
> -// Erase any previous groups and users
> -users.clear();
> -groups.clear();
> -roles.clear();
> +try (InputStream is = uConn.getInputStream()) {
> +this.lastModified = uConn.getLastModified();
> 
> -String pathName = getPathname();
> -URI uri = ConfigFileLoader.getURI(pathName);
> -URL url = uri.toURL();
> -URLConnection uConn = url.openConnection();
> +// Construct a digester to read the XML input file
> +Digester digester = new Digester();
> +try {
> +digester.setFeature(
> +
> "http://apache.org/xml/features/allow-java-encodings;, true);
> +} catch (Exception e) {
> +
> log.warn(sm.getString("memoryUserDatabase.xmlFeatureEncoding"), e);
> +}
> 
> -try (InputStream is = uConn.getInputStream()) {
> -this.lastModified = uConn.getLastModified();
> +Bundle bundle = new Bundle();
> +digester.push(bundle);
> +digester.addCallMethod("tomcat-users/role", "addRole", 2);
> +digester.addRule("tomcat-users/role", new
> CallParamRule(0, "rolename"));
> +digester.addRule("tomcat-users/role", new
> CallParamRule(1, "description"));
> +digester.addCallMethod("tomcat-users/group", "addGroup", 3);
> +digester.addRule("tomcat-users/group", new
> CallParamRule(0, "groupname"));
> +

Bugzilla permanent CC addresses

2018-10-01 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

All,

Does anyone know why these two email addresses are CC'd every time a
BZ message is sent?

kakvi...@yahoo.co.in
usma...@ieml.ru

Thanks,
- -chris
-BEGIN PGP SIGNATURE-
Comment: GPGTools - http://gpgtools.org
Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/

iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAluyb7gACgkQHPApP6U8
pFiNJQ//eRBlcPNioLXiOFtmGrdScOcRTuT3hBEGrECmXWQw6wMI5KMNZD+YM9vM
7pC/OCVFd8Cl2qqWfs+NtitoLANyvlknYZfvQU05n4qGDHgvpEFaqWHCdWhd1GTo
8rxaFe0/5ZU2cFAci4Z8AyyGjxHCtJrhHY81IZ0E3l60XIWooUwIGMmBxlow15td
6814uvNbO28X76pmKyW5X3a9s4L62Pb8hFRtNaprijsUj6U9CvT7HI/S0MkaUiGD
npNgDmWlUmo0MY9b40mPPAaoyBRWg6+nsdKtV31tosU9R3IqXwjK/HMmvJDyPy1R
vskGlsp28jDYp4xbGPDQ8ZETaCryJCrreJ3wpNirYM66DnKYTksJbDDkGHome0+k
S60w/JdBHir7GlGmlDSb0bmSmYFT9vYc+E2J3x+1T1hFwnWRBJ+rGycUctqQa4zR
G3TfNzWrMr0R/0YTbz3zpu90cmgwyi64BqOPe9FR9TWo+lGo4rhidIg8esFvUgX2
gTOkXOH+3UvEqJHiABYjmQtv5oUFgac4oduGVE+BOi7v5+pXu/7EibIiVk0IszPV
/JLp/sAJYfI8LhFlUWPmZhFFf0k+KgUBY6LKMzsVpqHwbOQUTxtbFSITfSPr01Oy
GucdT9WkEOy9Fd0KkPdPSFHn4owg+21gVh04f6BFOCNyKZjZMMI=
=fEhz
-END PGP SIGNATURE-

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62748] Add support for TLS 1.3 (RFC 8446)

2018-10-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62748

--- Comment #9 from Christopher Schultz  ---
(In reply to Azat from comment #5)
> I did patch both tomcat7 src and tomcat-native with the patches you provided.
> Results are kind of strange. 

Patching Tomcat 7 would indeed be strange. The patches are for Tomcat 9 trunk.
Assuming we can get them to work, they will be back-ported to 8.5.x and 7.0.x
in that order.

Could you try testing with Tomcat 9 by any chance?

> sslabs test (which now supports RFC 8446 version )
> and htbridge SSLServer test [work]

That's probably because they are only performing the TLS handshake. When I try
with openssl s_client, the handshake is successful, but issuing a "GET /"
request fails.

> chrome 70 Beta with final
> version of TLS version enabled I wasn't able to connect to my site.Chrome
> beta showed me ERR_CONNECTION_ABORTED message

I think this is the same thing I saw with s_client, as you did as well:

> read R BLOCK
> read:errno=0

I think this is a bug in Tomcat which is triggered by something unique to TLS
1.3.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GUMP@vmgump-vm3]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed

2018-10-01 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-test-nio2 has an issue affecting its community integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-test-nio2 :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...


Full details are available at:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-test-nio2/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on bnd exists, no need to add for property bndlib.jar.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/logs-NIO2
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO2/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO2/logs]



The following work was performed:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-test-nio2/gump_work/build_tomcat-trunk_tomcat-trunk-test-nio2.html
Work Name: build_tomcat-trunk_tomcat-trunk-test-nio2 (Type: Build)
Work ended in a state of : Failed
Elapsed: 24 mins 8 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only -Dsun.zip.disableMemoryMapping=true 
org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Djava.net.preferIPv4Stack=/srv/gump/public/workspace/tomcat-trunk/true 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.7-SNAPSHOT.jar
 -Dtest.reports=output/logs-NIO2 -Dexecute.test.nio2=true 
-Dexamples.sources.skip=true 
-Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.7.3a-201803300640/ecj-4.7.3a.jar
 -Dbndlib.jar=/srv/gump/packages/bnd/bndlib-4.0.0/biz.aQute.bndlib-4.0.0.jar 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/target/commons-daemon-1.1.1-SNAPSHOT.jar
 
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-master/dest-20181001/bin/openssl
 -Dtest.temp=output/test-tmp-NIO2
  -Dtest.accesslog=true -Dexecute.test.nio=false 
-Dbnd.jar=/srv/gump/packages/bnd/bnd-4.0.0/biz.aQute.bnd-4.0.0.jar 
-Dexecute.test.apr=false -Dtest.excludePerformance=true -Dtest.relaxTiming=true 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.7-SNAPSHOT.jar
 -Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jaspic-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/bu
 
ild/lib

[VOTE] Release JK 1.2.46

2018-10-01 Thread Mark Thomas
Tag:
http://svn.apache.org/viewvc/tomcat/jk/tags/JK_1_2_46/

Source:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/jk/


This is a maintenance release with a handful of bug fixes (compared to
1.2.44) and some clean-up. It also includes Windows binaries for IIS.


The proposed JK 1.2.46 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 1.2.46

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[VOTE][CANCELLED] Release JK 1.2.45

2018-10-01 Thread Mark Thomas
Wrong version. I'll start a new vote thread.

Mark


On 01/10/18 12:21, Mark Thomas wrote:
> Tag:
> http://svn.apache.org/viewvc/tomcat/jk/tags/JK_1_2_45/
> 
> Source:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/jk/
> 
> 
> This is a maintenance release with a handful of bug fixes (compared to
> 1.2.43) and some clean-up. It also includes Windows binaries for IIS.
> 
> 
> The proposed JK 1.2.45 release is:
> [ ] Broken - do not release
> [ ] Stable - go ahead and release as 1.2.45
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release JK 1.2.45

2018-10-01 Thread Mark Thomas
On 01/10/18 13:05, Rainer Jung wrote:
> s/1.2.45/1.2.46/g ?

Yep. That is what I get for doing stuff in a hurry. I'll fix this shortly.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1842498 - /tomcat/trunk/TOMCAT-NEXT.txt

2018-10-01 Thread remm
Author: remm
Date: Mon Oct  1 13:32:46 2018
New Revision: 1842498

URL: http://svn.apache.org/viewvc?rev=1842498=rev
Log:
Add new features I'll try to work on.

Modified:
tomcat/trunk/TOMCAT-NEXT.txt

Modified: tomcat/trunk/TOMCAT-NEXT.txt
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/TOMCAT-NEXT.txt?rev=1842498=1842497=1842498=diff
==
--- tomcat/trunk/TOMCAT-NEXT.txt (original)
+++ tomcat/trunk/TOMCAT-NEXT.txt Mon Oct  1 13:32:46 2018
@@ -28,7 +28,6 @@ Items carried over from the 9.0.x list:
 3.  Consider wrapping the SocketWrapper with a facade to detect / prevent
 components retaining references longer than they should.
 
-
 New items for 10.0.x onwards:
 
 1.  Remove APR connector.
@@ -38,3 +37,7 @@ New items for 10.0.x onwards:
 
 3.  Remove the ExtensionValidator and associated classes (assuming that the
 minimum Java version is Java 9 or later).
+
+4.  New builder style alternate embedded API (likely also for 9.x).
+
+5.  Cloud aware cluster membership provider(s) (likely also for 9.x).



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62786] New: Post Resources ignored in server.xml when Resources tag present in context.xml

2018-10-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62786

Bug ID: 62786
   Summary: Post Resources ignored in server.xml when Resources
tag present in context.xml
   Product: Tomcat 8
   Version: 8.5.x-trunk
  Hardware: PC
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
  Assignee: dev@tomcat.apache.org
  Reporter: steeve.bero...@orchestranetworks.com
  Target Milestone: 

Hello,

We have noticed that when "Resources" tag is declared in context.xml, it hides
PostResources declaration in a given context in server.xml.
When we copy the same context and put it in a separated file (under
[engine]/[host]/[context].xml, everything runs correctly so I guess that this
is a bug because we don't have the same behaviour for a given context.
We have reproduced this on all Tomcat 8.0.x and 8.5.x so far.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62748] Add support for TLS 1.3 (RFC 8446)

2018-10-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62748

--- Comment #8 from Azat  ---
Created attachment 36179
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=36179=edit
screenshots from latest mozilla beta build with an error

I've added screenshots from the latest Mozilla beta where the error (secure
connection failed) is shown when trying to access the website in question
(debug.ieml.ru) after applying the patches

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release JK 1.2.45

2018-10-01 Thread Rainer Jung

s/1.2.45/1.2.46/g ?

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[VOTE] Release JK 1.2.45

2018-10-01 Thread Mark Thomas
Tag:
http://svn.apache.org/viewvc/tomcat/jk/tags/JK_1_2_45/

Source:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/jk/


This is a maintenance release with a handful of bug fixes (compared to
1.2.43) and some clean-up. It also includes Windows binaries for IIS.


The proposed JK 1.2.45 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 1.2.45

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GUMP@vmgump-vm3]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed

2018-10-01 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-test-nio2 has an issue affecting its community integration.
This issue affects 1 projects.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-test-nio2 :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...


Full details are available at:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-test-nio2/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on bnd exists, no need to add for property bndlib.jar.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/logs-NIO2
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO2/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO2/logs]



The following work was performed:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-test-nio2/gump_work/build_tomcat-trunk_tomcat-trunk-test-nio2.html
Work Name: build_tomcat-trunk_tomcat-trunk-test-nio2 (Type: Build)
Work ended in a state of : Failed
Elapsed: 23 mins 48 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only -Dsun.zip.disableMemoryMapping=true 
org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Djava.net.preferIPv4Stack=/srv/gump/public/workspace/tomcat-trunk/true 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.7-SNAPSHOT.jar
 -Dtest.reports=output/logs-NIO2 -Dexecute.test.nio2=true 
-Dexamples.sources.skip=true 
-Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.7.3a-201803300640/ecj-4.7.3a.jar
 -Dbndlib.jar=/srv/gump/packages/bnd/bndlib-4.0.0/biz.aQute.bndlib-4.0.0.jar 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/target/commons-daemon-1.1.1-SNAPSHOT.jar
 
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-master/dest-20181001/bin/openssl
 -Dtest.temp=output/test-tmp-NIO2
  -Dtest.accesslog=true -Dexecute.test.nio=false 
-Dbnd.jar=/srv/gump/packages/bnd/bnd-4.0.0/biz.aQute.bnd-4.0.0.jar 
-Dexecute.test.apr=false -Dtest.excludePerformance=true -Dtest.relaxTiming=true 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-3.7-SNAPSHOT.jar
 -Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja
 
r:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jaspic-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/bu
 
ild

svn commit: r29812 - in /dev/tomcat/tomcat-connectors/jk: ./ binaries/windows/ binaries/windows/symbols/

2018-10-01 Thread markt
Author: markt
Date: Mon Oct  1 08:45:35 2018
New Revision: 29812

Log:
Upload 1.2.46 for voting

Added:

dev/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.46-windows-i386-symbols.zip
   (with props)

dev/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.46-windows-i386-symbols.zip.asc

dev/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.46-windows-i386-symbols.zip.sha512

dev/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.46-windows-x86_64-symbols.zip
   (with props)

dev/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.46-windows-x86_64-symbols.zip.asc

dev/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.46-windows-x86_64-symbols.zip.sha512

dev/tomcat/tomcat-connectors/jk/binaries/windows/tomcat-connectors-1.2.46-windows-i386-iis.zip
   (with props)

dev/tomcat/tomcat-connectors/jk/binaries/windows/tomcat-connectors-1.2.46-windows-i386-iis.zip.asc

dev/tomcat/tomcat-connectors/jk/binaries/windows/tomcat-connectors-1.2.46-windows-i386-iis.zip.sha512

dev/tomcat/tomcat-connectors/jk/binaries/windows/tomcat-connectors-1.2.46-windows-x86_64-iis.zip
   (with props)

dev/tomcat/tomcat-connectors/jk/binaries/windows/tomcat-connectors-1.2.46-windows-x86_64-iis.zip.asc

dev/tomcat/tomcat-connectors/jk/binaries/windows/tomcat-connectors-1.2.46-windows-x86_64-iis.zip.sha512
dev/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.46-src.tar.gz   (with 
props)
dev/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.46-src.tar.gz.asc
dev/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.46-src.tar.gz.sha512
dev/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.46-src.zip   (with 
props)
dev/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.46-src.zip.asc
dev/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.46-src.zip.sha512
Modified:
dev/tomcat/tomcat-connectors/jk/README.html
dev/tomcat/tomcat-connectors/jk/binaries/windows/README.html

Modified: dev/tomcat/tomcat-connectors/jk/README.html
==
--- dev/tomcat/tomcat-connectors/jk/README.html (original)
+++ dev/tomcat/tomcat-connectors/jk/README.html Mon Oct  1 08:45:35 2018
@@ -47,13 +47,13 @@ nearest mirror site!
 
 
 % pgpk -a KEYS
-% pgpv tomcat-connectors-1.2.45-src.tar.gz.asc
+% pgpv tomcat-connectors-1.2.46-src.tar.gz.asc
 or,
 % pgp -ka KEYS
-% pgp tomcat-connectors-1.2.45-src.tar.gz.asc
+% pgp tomcat-connectors-1.2.46-src.tar.gz.asc
 or,
 % gpg --import KEYS
-% gpg --verify tomcat-connectors-1.2.45-src.tar.gz.asc
+% gpg --verify tomcat-connectors-1.2.46-src.tar.gz.asc
 
 
 We offer SHA1 and SHA512 hashes as alternatives to validate the integrity

Modified: dev/tomcat/tomcat-connectors/jk/binaries/windows/README.html
==
--- dev/tomcat/tomcat-connectors/jk/binaries/windows/README.html (original)
+++ dev/tomcat/tomcat-connectors/jk/binaries/windows/README.html Mon Oct  1 
08:45:35 2018
@@ -22,7 +22,7 @@
connector to fail.
 
 
-The current stable release is 1.2.45
+The current stable release is 1.2.46
 
 See the Apache Tomcat Connectors
 http://tomcat.apache.org/connectors-doc/miscellaneous/changelog.html;>changelog

Added: 
dev/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.46-windows-i386-symbols.zip
==
Binary file - no diff available.

Propchange: 
dev/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.46-windows-i386-symbols.zip
--
svn:executable = *

Propchange: 
dev/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.46-windows-i386-symbols.zip
--
svn:mime-type = application/octet-stream

Added: 
dev/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.46-windows-i386-symbols.zip.asc
==
--- 
dev/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.46-windows-i386-symbols.zip.asc
 (added)
+++ 
dev/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.46-windows-i386-symbols.zip.asc
 Mon Oct  1 08:45:35 2018
@@ -0,0 +1,17 @@
+-BEGIN PGP SIGNATURE-
+Comment: GPGTools - http://gpgtools.org
+
+iQIzBAABCgAdFiEEqcXfTSLpmZjZh1pREMAcWi9gWecFAlux2ZUACgkQEMAcWi9g
+WeeYeBAA8a6GR8fWXFxv1ejGhL/RDv2GdP9p7lBKNiH2pdYhu5MpOdJjkjQc/DC/
+9/DB6JCnpvw/WyC/GduMUyTgsaXR/Zum1DdgmBepU+XX7f7xnw2vcAiB9IE6k7WW
+y/1LNxh6C+2qyz+mcMxQ/4BskzyxpKjIWo2/l5NSDywCeQ7JOx7pkOM6i/MJSkHB
+8lDpCITcS71Q7XrVFXYW70oSk/ZksamkwC7UlvQZpS6RLh9dBOb+wHlcyb5k3Gja

svn commit: r29811 - in /dev/tomcat/tomcat-connectors/jk: ./ binaries/windows/ binaries/windows/symbols/

2018-10-01 Thread markt
Author: markt
Date: Mon Oct  1 08:19:34 2018
New Revision: 29811

Log:
Drop 1.2.45

Removed:

dev/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.45-windows-i386-symbols.zip

dev/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.45-windows-i386-symbols.zip.asc

dev/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.45-windows-i386-symbols.zip.sha512

dev/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.45-windows-x86_64-symbols.zip

dev/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.45-windows-x86_64-symbols.zip.asc

dev/tomcat/tomcat-connectors/jk/binaries/windows/symbols/tomcat-connectors-1.2.45-windows-x86_64-symbols.zip.sha512

dev/tomcat/tomcat-connectors/jk/binaries/windows/tomcat-connectors-1.2.45-windows-i386-iis.zip

dev/tomcat/tomcat-connectors/jk/binaries/windows/tomcat-connectors-1.2.45-windows-i386-iis.zip.asc

dev/tomcat/tomcat-connectors/jk/binaries/windows/tomcat-connectors-1.2.45-windows-i386-iis.zip.sha512

dev/tomcat/tomcat-connectors/jk/binaries/windows/tomcat-connectors-1.2.45-windows-x86_64-iis.zip

dev/tomcat/tomcat-connectors/jk/binaries/windows/tomcat-connectors-1.2.45-windows-x86_64-iis.zip.asc

dev/tomcat/tomcat-connectors/jk/binaries/windows/tomcat-connectors-1.2.45-windows-x86_64-iis.zip.sha512
dev/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.45-src.tar.gz
dev/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.45-src.tar.gz.asc
dev/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.45-src.tar.gz.sha512
dev/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.45-src.zip
dev/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.45-src.zip.asc
dev/tomcat/tomcat-connectors/jk/tomcat-connectors-1.2.45-src.zip.sha512


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1842432 - /tomcat/jk/trunk/xdocs/news/20180301.xml

2018-10-01 Thread markt
Author: markt
Date: Mon Oct  1 07:55:34 2018
New Revision: 1842432

URL: http://svn.apache.org/viewvc?rev=1842432=rev
Log:
1.2.46 slipped

Modified:
tomcat/jk/trunk/xdocs/news/20180301.xml

Modified: tomcat/jk/trunk/xdocs/news/20180301.xml
URL: 
http://svn.apache.org/viewvc/tomcat/jk/trunk/xdocs/news/20180301.xml?rev=1842432=1842431=1842432=diff
==
--- tomcat/jk/trunk/xdocs/news/20180301.xml (original)
+++ tomcat/jk/trunk/xdocs/news/20180301.xml Mon Oct  1 07:55:34 2018
@@ -31,7 +31,7 @@
 
 
 
-
+
 The Apache Tomcat team is proud to announce the immediate availability
of Tomcat Connectors 1.2.46. This is a maintenance release.
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62748] Add support for TLS 1.3 (RFC 8446)

2018-10-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62748

--- Comment #7 from Azat  ---
the same thing happens with win 10 chrome 70 beta client, connection fails with
ERR_EMPTY_RESPONSE at the same time ssl_connect show no obvious error
openssl s_client  -CAfile /etc/pki/tls/certs/ca-bundle.crt -connect de 
   
  
bug.ieml.ru:443 -debug
CONNECTED(0005)
write to 0x24e4ad0 [0x25ac450] (315 bytes => 315 (0x13B))
 - 16 03 01 01 36 01 00 01-32 03 03 98 de ab ab cd   6...2...
0010 - 05 75 3f 43 93 c4 4f 5b-a3 6b 7d cb 89 ca 23 bc   .u?C..O[.k}...#.
0020 - 3f 47 f3 eb 0b c6 a0 a9-c3 19 82 20 29 00 2e ca   ?G. )...
0030 - ed ce fe ce 3a 42 5e 96-0b 9d df f7 78 57 4b 7e   :B^.xWK~
0040 - 25 08 12 5c d0 0d 52 3d-3e eb 50 98 00 3e 13 02   %..\..R=>.P..>..
0050 - 13 03 13 01 c0 2c c0 30-00 9f cc a9 cc a8 cc aa   .,.0
0060 - c0 2b c0 2f 00 9e c0 24-c0 28 00 6b c0 23 c0 27   .+./...$.(.k.#.'
0070 - 00 67 c0 0a c0 14 00 39-c0 09 c0 13 00 33 00 9d   .g.9.3..
0080 - 00 9c 00 3d 00 3c 00 35-00 2f 00 ff 01 00 00 ab   ...=.<.5./..
0090 - 00 00 00 12 00 10 00 00-0d 64 65 62 75 67 2e 69   .debug.i
00a0 - 65 6d 6c 2e 72 75 00 0b-00 04 03 00 01 02 00 0a   eml.ru..
00b0 - 00 0c 00 0a 00 1d 00 17-00 1e 00 19 00 18 00 23   ...#
00c0 - 00 00 00 16 00 00 00 17-00 00 00 0d 00 30 00 2e   .0..
00d0 - 04 03 05 03 06 03 08 07-08 08 08 09 08 0a 08 0b   
00e0 - 08 04 08 05 08 06 04 01-05 01 06 01 03 03 02 03   
00f0 - 03 01 02 01 03 02 02 02-04 02 05 02 06 02 00 2b   ...+
0100 - 00 09 08 03 04 03 03 03-02 03 01 00 2d 00 02 01   -...
0110 - 01 00 33 00 26 00 24 00-1d 00 20 a2 a3 36 41 f4   ..3.&.$... ..6A.
0120 - 7b 11 b9 5d 92 ec 2e 00-48 3f cd 36 8b 5a a4 ba   {..]H?.6.Z..
0130 - eb d9 e0 9f bd b7 c0 84-84 07 7b  ..{
read from 0x24e4ad0 [0x25a3233] (5 bytes => 5 (0x5))
 - 16 03 03 00 7az
read from 0x24e4ad0 [0x25a3238] (122 bytes => 122 (0x7A))
 - 02 00 00 76 03 03 ca 58-7e 45 44 89 37 b3 f0 c3   ...v...X~ED.7...
0010 - 69 87 1f d6 e2 1d ec 43-92 39 84 5b b3 f3 c1 6a   i..C.9.[...j
0020 - 3c 94 4f 29 57 f9 20 29-00 2e ca ed ce fe ce 3a   <.O)W. )...:
0030 - 42 5e 96 0b 9d df f7 78-57 4b 7e 25 08 12 5c d0   B^.xWK~%..\.
0040 - 0d 52 3d 3e eb 50 98 13-02 00 00 2e 00 2b 00 02   .R=>.P...+..
0050 - 03 04 00 33 00 24 00 1d-00 20 94 2d bf f2 97 00   ...3.$... .-
0060 - 03 f2 8a 3e 86 f9 1b e4-aa 17 cd a2 98 fb d3 1c   ...>
0070 - 50 0d a8 84 dc df 51 53-9a 20 P.QS.
read from 0x24e4ad0 [0x25a3233] (5 bytes => 5 (0x5))
 - 14 03 03 00 01.
read from 0x24e4ad0 [0x25a3238] (1 bytes => 1 (0x1))
 - 01.
read from 0x24e4ad0 [0x25a3233] (5 bytes => 5 (0x5))
 - 17 03 03 00 1b.
read from 0x24e4ad0 [0x25a3238] (27 bytes => 27 (0x1B))
 - 25 19 8f 8a 2b a7 d8 aa-1c bb ed 0a cd 5a de e5   %...+Z..
0010 - 68 39 a2 88 8c fb bc e7-ac 05 1f  h9.
read from 0x24e4ad0 [0x25a3233] (5 bytes => 5 (0x5))
 - 17 03 03 10 f3.
read from 0x24e4ad0 [0x25a3238] (4339 bytes => 3926 (0xF56))
 - da c7 cf 80 eb e8 17 f9-4b 2f ad 1c 13 32 9a df   K/...2..
0010 - b0 f6 df 53 96 09 1b d2-c7 73 77 d2 10 32 cb c2   ...S.sw..2..
0020 - 45 cd 66 cc ed 36 1b 0e-4f c0 9a 4b 5d 52 29 fa   E.f..6..O..K]R).
0030 - 5e 1c 11 f2 5f 0b 24 e8-ee c7 1c b1 2b ad bd ea   ^..._.$.+...
0040 - 0e ee e7 ff d9 53 c9 1f-56 70 c7 71 64 5b 1a b2   .S..Vp.qd[..
0050 - 0b 01 6c f0 bf cc 6d 8b-e3 1a 1c a0 d9 9f 16 a6   ..l...m.
0060 - 7e 76 0a 34 5b 70 00 f8-fa c7 c0 2c 8a 85 5d 9d   ~v.4[p.,..].
0070 - 01 4d da cc 66 ed 08 8d-1a 7a 77 a0 3f e2 8c f5   .M..fzw.?...
0080 - ca 77 df e2 e3 b0 65 2e-6c 04 0f ab ef 7c 3a 21   .we.l|:!
0090 - c1 e1 03 d4 d1 64 7f c2-6c e5 50 f9 0a ee cc 3e   .d..l.P>
00a0 - 1b 51 cf 40 4c 10 fc 76-22 fa 96 5d 83 a1 35 fc   .Q.@L..v"..]..5.
00b0 - 68 61 9e f1 2a a3 fd 4c-0b bd df ab d7 ac 0a 18   ha..*..L
00c0 - e2 97 35 da 26 e6 dc 1e-e5 8a 0b c8 d4 cd f4 a7   ..5.&...
00d0 - f9 41 6c 89 92 b2 c9 18-b2 f8 95 62 54 7f 2f 99   .AlbT./.
00e0 - 9d 65 c1 82 cb 60 95 64-1b e8 2c b8 44 96 30 2c   .e...`.d..,.D.0,
00f0 - 42 28 bc c4 e1 23 7d 0a-20 3c 90 4a 8e 2c 13 45   B(...#}. <.J.,.E
0100 - ee 4d ff 40 49 38 96 7f-45 ba 06 da cd d3 06 e6   .M.@I8..E...
0110 - 24 8e 49 f6 f4 6a c8 e8-09 3e ff 53 26 d2 13 12   $.I..j...>.S&...
0120 - 6c bf 37 6a b3 af 45 d6-c4 73 23 70 51 ea 76 86   l.7j..E..s#pQ.v.
0130 - 29 fa 42 ed 37 79 e3 23-66 a7 0c 20 1d b9 20 ba   ).B.7y.#f.. .. .