[GUMP@vmgump-vm3]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed

2019-03-29 Thread Bill Barker
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at gene...@gump.apache.org.

Project tomcat-trunk-test-nio2 has an issue affecting its community integration.
This issue affects 1 projects,
 and has been outstanding for 6 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-trunk-test-nio2 :  Tomcat 9.x, a web server implementing the Java 
Servlet 4.0,
...


Full details are available at:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-test-nio2/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Dependency on bnd exists, no need to add for property bndlib.jar.
 -INFO- Failed with reason build failed
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/logs-NIO2
 -INFO- Project Reports in: 
/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO2/logs
 -WARNING- No directory 
[/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO2/logs]



The following work was performed:
http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-test-nio2/gump_work/build_tomcat-trunk_tomcat-trunk-test-nio2.html
Work Name: build_tomcat-trunk_tomcat-trunk-test-nio2 (Type: Build)
Work ended in a state of : Failed
Elapsed: 24 mins 53 secs
Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true 
-Dbuild.sysclasspath=only -Dsun.zip.disableMemoryMapping=true 
org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml 
-Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs 
-Dbnd.jar=/srv/gump/packages/bnd/bnd-4.0.0/biz.aQute.bnd-4.0.0.jar 
-Dsaaj-api.jar=/srv/gump/packages/saaj-api/saaj-api-1.3.5.jar 
-Djaxrpc-lib.jar=/srv/gump/packages/jaxrpc/geronimo-spec-jaxrpc-1.1-rc4.jar 
-Dtest.temp=output/test-tmp-NIO2 
-Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar 
-Djava.net.preferIPv4Stack=/srv/gump/public/workspace/tomcat-trunk/true 
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-3.1-SNAPSHOT.jar
 -Dexamples.sources.skip=true 
-Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/target/commons-daemon-1.1.1-SNAPSHOT.jar
 
-Dtest.openssl.path=/srv/gump/public/workspace/openssl-master/dest-20190330/bin/openssl
 -Dexecute
 .test.nio=false 
-Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar 
-Dbndlib.jar=/srv/gump/packages/bnd/bndlib-4.0.0/biz.aQute.bndlib-4.0.0.jar 
-Dexecute.test.apr=false 
-Dwsdl4j-lib.jar=/srv/gump/packages/wsdl4j/wsdl4j-1.6.3.jar 
-Dtest.reports=output/logs-NIO2 -Dexecute.test.nio2=true 
-Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.10-201812060815/ecj-4.10.jar 
-Dtest.relaxTiming=true -Dtest.excludePerformance=true -Dtest.accesslog=true 
-Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-4.1-SNAPSHOT.jar
 -Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test 
[Working Directory: /srv/gump/public/workspace/tomcat-trunk]
CLASSPATH: 
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja
 

[Bug 63286] Inconsistencies between AccessLogValve and mod_log_config

2019-03-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63286

--- Comment #4 from Michael Osipov  ---
That's fine by me. Though, %{UNIT}T can be introduced in 8.5 and 9, can't it?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[tomcat] branch master updated: A few mow items for the TODO list

2019-03-29 Thread markt
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/master by this push:
 new 08750f1  A few mow items for the TODO list
08750f1 is described below

commit 08750f1826bf72334bc575cefe4953c89d3862c6
Author: Mark Thomas 
AuthorDate: Fri Mar 29 21:49:25 2019 +

A few mow items for the TODO list
---
 TOMCAT-NEXT.txt | 44 
 1 file changed, 24 insertions(+), 20 deletions(-)

diff --git a/TOMCAT-NEXT.txt b/TOMCAT-NEXT.txt
index 25d7277..c06b05c 100644
--- a/TOMCAT-NEXT.txt
+++ b/TOMCAT-NEXT.txt
@@ -30,30 +30,34 @@ Items carried over from the 9.0.x list:
 
 New items for 10.0.x onwards:
 
-1.  Remove APR connector.
+ 1.  Remove APR connector.
 
-2.  Remove org.apache.tomcat.jni and replace with the minimum necessary to
-interface with OpenSSL and clones.
-We might want to park this one until we see what is available direct from
-the JRE with project Panama.
+ 2.  Remove org.apache.tomcat.jni and replace with the minimum necessary to
+ interface with OpenSSL and clones.
+ We might want to park this one until we see what is available direct from
+ the JRE with project Panama.
 
-3.  Remove the ExtensionValidator and associated classes (assuming that the
-minimum Java version is Java 9 or later).
+ 3.  Remove the ExtensionValidator and associated classes (assuming that the
+ minimum Java version is Java 9 or later).
 
-4.  Clean-up content-type header processing. Remove the optional space after 
the
-';' character (if any). Don't mutate the header if there is no charset
-parameter. See BZ 62912 for some discussion and additional references.
+ 4.  Clean-up content-type header processing. Remove the optional space after
+ the ';' character (if any). Don't mutate the header if there is no charset
+ parameter. See BZ 62912 for some discussion and additional references.
 
-5.  Consider applying the delayed log file opening (until there is something to
-log). See BZ 53620.
+ 5.  Consider applying the delayed log file opening (until there is something 
to
+ log). See BZ 53620.
 
-6. Consider including
-   UTF-8
-   in conf/web.xml
+ 6. Consider including
+UTF-8
+in conf/web.xml
 
-7. Consider including
-   UTF-8
-   in conf/web.xml
+ 7. Consider including
+UTF-8
+in conf/web.xml
 
-8. RFC 3986 states (section 2.2) that a %nn encoded delimiter is NOT equivalent
-   to the decoded form. Provide an option no to decode delimiters in %nn form.
+ 8. RFC 3986 states (section 2.2) that a %nn encoded delimiter is NOT 
equivalent
+to the decoded form. Provide an option not to decode delimiters in %nn 
form.
+
+ 9. BZ 56966. Refactor internal request timing to use System.nanoTime()
+
+10. BZ 63286. Make behaviour of %D and %T consistent with httpd.


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63286] Inconsistencies between AccessLogValve and mod_log_config

2019-03-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63286

--- Comment #3 from Mark Thomas  ---
We can't change the behaviour in the middle of the 9.0.x series. The risk of
braking things for users is too great. I've added it to the TODO list for
10.0.x.

Meanwhile, we can clearly document the current behaviour and note the
differences with httpd. Working on that now...

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 56966] AccessLogValve's elapsed time has 15ms precision on Windows

2019-03-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=56966

--- Comment #9 from Mark Thomas  ---
The API changes to implement this mean it needs to wait for a new major
version. I have added it to the 10.0.x TODO list.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63023] Provide a way to load SecurityProviders into the system classloader compatible with Java 9+

2019-03-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63023

Jonathan Horowitz  changed:

   What|Removed |Added

Version|9.0.16  |9.0.x

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Commons-Daemon LibraryPath is broken for Java 11

2019-03-29 Thread Gerwin Jansen
Hi,

I have found 3 issues in the LibraryPath feature of commons-daemon:
DAEMON-396 LibraryPath is broken for Java 
11

  1.  LibraryPath is not set for Java 11 jvm.dll
  2.  LibraryPath does replace PATH instead of append.
  3.  PATH does not include JAVA_HOME/bin

Tomcat is affected by this bug. Do I need to open a Bugzilla issue to track the 
dependency?

Regards,
Gerwin


[Bug 63286] Inconsistencies between AccessLogValve and mod_log_config

2019-03-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63286

--- Comment #2 from Michael Osipov  ---
(In reply to Mark Thomas from comment #1)
> Also see bug 56966. I don't recall why that stalled. It may have been
> related to the API changes required. Probably time to take another look.

It looks related, but the issue you mention is about resolution, this one's
different. Three years have passed since the ticket has been touched.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 63286] Inconsistencies between AccessLogValve and mod_log_config

2019-03-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=63286

--- Comment #1 from Mark Thomas  ---
Also see bug 56966. I don't recall why that stalled. It may have been related
to the API changes required. Probably time to take another look.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



JDK 13 - Early Access build 14 is available

2019-03-29 Thread Rory O'Donnell

Hi Mark,

*OpenJDK builds *- JDK 13 - Early Access build 14 is available at 
http://jdk.java.net/13/


 * These early-access, open-source builds are provided under the GNU
   General Public License, versionĀ 2, with the Classpath Exception
   .
 * Changes in this build
   

 * Release notes [1]
 * JDK 13 Schedule proposal accepted [2]
 o 2019/06/13 Rampdown Phase One
 o 2019/07/18 Rampdown Phase Two
 o 2019/08/08 Initial Release Candidate
 o 2019/08/22 Final Release Candidate
 o 2019/09/17 General Availability

*jpackage EA *

 * This is an early access build of JEP 343: Packaging Tool
   , aimed at testing a prototype
   implementation of jpackage, which is a new tool for packaging
   self-contained Java applications along with a Java Runtime Environment.
 * Build 30 is now available http://jdk.java.net/jpackage/
 * Please send feedback via e-mail to core-libs-...@openjdk.java.net
   

*Quality Outreach report for **March 2019*

 * The report for March 2019 is available here
   

 * Thanks to all those contributed !

*Recent Blog:* A new (Japanese) era for Java! 



Rgds,Rory

[1] http://jdk.java.net/13/release-notes
[2] https://mail.openjdk.java.net/pipermail/jdk-dev/2019-March/002736.html

--
Rgds,Rory O'Donnell
Quality Engineering Manager
Oracle EMEA , Dublin, Ireland



[tomcat] branch master updated: Move timeout utility method to use it in two additional locations

2019-03-29 Thread remm
This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/master by this push:
 new 27f06bc  Move timeout utility method to use it in two additional 
locations
27f06bc is described below

commit 27f06bca46a20cb3faab1221fca7bfd8e88bceda
Author: remm 
AuthorDate: Fri Mar 29 10:33:01 2019 +0100

Move timeout utility method to use it in two additional locations
---
 .../apache/tomcat/util/net/AbstractEndpoint.java   |  5 
 java/org/apache/tomcat/util/net/Nio2Endpoint.java  | 27 +-
 .../tomcat/util/net/NioBlockingSelector.java   | 12 ++
 .../apache/tomcat/util/net/SecureNio2Channel.java  | 12 +-
 4 files changed, 24 insertions(+), 32 deletions(-)

diff --git a/java/org/apache/tomcat/util/net/AbstractEndpoint.java 
b/java/org/apache/tomcat/util/net/AbstractEndpoint.java
index 6a6f86e..0b8b683 100644
--- a/java/org/apache/tomcat/util/net/AbstractEndpoint.java
+++ b/java/org/apache/tomcat/util/net/AbstractEndpoint.java
@@ -134,6 +134,11 @@ public abstract class AbstractEndpoint {
 }
 
 
+public static long toTimeout(long timeout) {
+// Many calls can't do infinite timeout so use Long.MAX_VALUE if 
timeout is <= 0
+return (timeout > 0) ? timeout : Long.MAX_VALUE;
+}
+
 // - Fields
 
 /**
diff --git a/java/org/apache/tomcat/util/net/Nio2Endpoint.java 
b/java/org/apache/tomcat/util/net/Nio2Endpoint.java
index 823d9bc..fd31ac1 100644
--- a/java/org/apache/tomcat/util/net/Nio2Endpoint.java
+++ b/java/org/apache/tomcat/util/net/Nio2Endpoint.java
@@ -532,7 +532,7 @@ public class Nio2Endpoint extends 
AbstractJsseEndpoint 0) ? timeout : Long.MAX_VALUE;
-}
-
 public static void startInline() {
 inlineCompletion.set(Boolean.TRUE);
 }
diff --git a/java/org/apache/tomcat/util/net/NioBlockingSelector.java 
b/java/org/apache/tomcat/util/net/NioBlockingSelector.java
index 322b172..6702557 100644
--- a/java/org/apache/tomcat/util/net/NioBlockingSelector.java
+++ b/java/org/apache/tomcat/util/net/NioBlockingSelector.java
@@ -114,11 +114,7 @@ public class NioBlockingSelector {
 try {
 if ( att.getWriteLatch()==null || 
att.getWriteLatch().getCount()==0) att.startWriteLatch(1);
 poller.add(att,SelectionKey.OP_WRITE,reference);
-if (writeTimeout < 0) {
-
att.awaitWriteLatch(Long.MAX_VALUE,TimeUnit.MILLISECONDS);
-} else {
-
att.awaitWriteLatch(writeTimeout,TimeUnit.MILLISECONDS);
-}
+
att.awaitWriteLatch(AbstractEndpoint.toTimeout(writeTimeout),TimeUnit.MILLISECONDS);
 } catch (InterruptedException ignore) {
 // Ignore
 }
@@ -184,11 +180,7 @@ public class NioBlockingSelector {
 try {
 if ( att.getReadLatch()==null || 
att.getReadLatch().getCount()==0) att.startReadLatch(1);
 poller.add(att,SelectionKey.OP_READ, reference);
-if (readTimeout < 0) {
-att.awaitReadLatch(Long.MAX_VALUE, 
TimeUnit.MILLISECONDS);
-} else {
-att.awaitReadLatch(readTimeout, TimeUnit.MILLISECONDS);
-}
+
att.awaitReadLatch(AbstractEndpoint.toTimeout(readTimeout), 
TimeUnit.MILLISECONDS);
 } catch (InterruptedException ignore) {
 // Ignore
 }
diff --git a/java/org/apache/tomcat/util/net/SecureNio2Channel.java 
b/java/org/apache/tomcat/util/net/SecureNio2Channel.java
index 6eae95d..cb670ae 100644
--- a/java/org/apache/tomcat/util/net/SecureNio2Channel.java
+++ b/java/org/apache/tomcat/util/net/SecureNio2Channel.java
@@ -256,7 +256,7 @@ public class SecureNio2Channel extends Nio2Channel  {
 return 0;
 } else {
 if (async) {
-sc.write(netOutBuffer, 
Nio2Endpoint.toNio2Timeout(timeout),
+sc.write(netOutBuffer, 
AbstractEndpoint.toTimeout(timeout),
 TimeUnit.MILLISECONDS, socket, 
handshakeWriteCompletionHandler);
 } else {
 try {
@@ -294,7 +294,7 @@ public class SecureNio2Channel extends Nio2Channel  {
 if (handshakeStatus != HandshakeStatus.NEED_UNWRAP || 
netOutBuffer.remaining() > 0) {
 //should actually return OP_READ if we have NEED_UNWRAP
 if (async) {
-sc.write(netOutBuffer, 
Nio2Endpoint.toNio2Timeout(timeout),
+sc.write(netOutBuffer,