[GUMP@vmgump-vm3]: Project tomcat-tc7.0.x-test-apr (in module tomcat-7.0.x) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-test-apr has an issue affecting its community integration. This issue affects 1 projects. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-tc7.0.x-test-apr : Tomcat 7.x, a web server implementing Java Servlet 3.0, ... Full details are available at: http://vmgump-vm3.apache.org/tomcat-7.0.x/tomcat-tc7.0.x-test-apr/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -INFO- Failed with reason build failed -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-7.0.x/output/logs-APR -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-7.0.x/output/test-tmp-APR/logs The following work was performed: http://vmgump-vm3.apache.org/tomcat-7.0.x/tomcat-tc7.0.x-test-apr/gump_work/build_tomcat-7.0.x_tomcat-tc7.0.x-test-apr.html Work Name: build_tomcat-7.0.x_tomcat-tc7.0.x-test-apr (Type: Build) Work ended in a state of : Failed Elapsed: 23 mins 57 secs Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only -Dsun.zip.disableMemoryMapping=true org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar -Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-3.1-SNAPSHOT.jar -Dtest.reports=output/logs-APR -Dexamples.sources.skip=true -Dbase.path=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-build-libs -Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.10-201812060815/ecj-4.10.jar -Dtest.apr.loc=/srv/gump/public/workspace/tomcat-native-1.2-1.0.2/dest-20190410/lib -Dtest.relaxTiming=true -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/target/commons-daemon-1.1.1-SNAPSHOT.jar -Dtest.temp=output/test-tmp-APR -Dtest.accesslog=true -Dexecute.test.nio=false -Dtest.exclude=**/TestFlushableGZIPOutputStream.java -Dexecute.test.bio=false -Dexecute.test.apr=true -Dtest.ex cludePerformance=true -Deasymock.jar=/srv/gump/packages/easymock3/easymock-3.6.jar -Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar -Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test [Working Directory: /srv/gump/public/workspace/tomcat-7.0.x] CLASSPATH: /usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-7.0.x/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/servlet-api.ja r:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-util.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-dbcp.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/
[GUMP@vmgump-vm3]: Project tomcat-tc7.0.x-test-nio (in module tomcat-7.0.x) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-test-nio has an issue affecting its community integration. This issue affects 1 projects. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-tc7.0.x-test-nio : Tomcat 7.x, a web server implementing Java Servlet 3.0, ... Full details are available at: http://vmgump-vm3.apache.org/tomcat-7.0.x/tomcat-tc7.0.x-test-nio/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -INFO- Failed with reason build failed -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-7.0.x/output/logs-NIO -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-7.0.x/output/test-tmp-NIO/logs The following work was performed: http://vmgump-vm3.apache.org/tomcat-7.0.x/tomcat-tc7.0.x-test-nio/gump_work/build_tomcat-7.0.x_tomcat-tc7.0.x-test-nio.html Work Name: build_tomcat-7.0.x_tomcat-tc7.0.x-test-nio (Type: Build) Work ended in a state of : Failed Elapsed: 20 mins 44 secs Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only -Dsun.zip.disableMemoryMapping=true org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar -Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-3.1-SNAPSHOT.jar -Dtest.reports=output/logs-NIO -Dexamples.sources.skip=true -Dbase.path=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-build-libs -Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.10-201812060815/ecj-4.10.jar -Dtest.relaxTiming=true -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/target/commons-daemon-1.1.1-SNAPSHOT.jar -Dtest.temp=output/test-tmp-NIO -Dtest.accesslog=true -Dexecute.test.nio=true -Dtest.exclude=**/TestFlushableGZIPOutputStream.java -Dexecute.test.bio=false -Dexecute.test.apr=false -Dtest.excludePerformance=true -Deasymock.jar=/srv/gump/packages/easymock3/easymock-3.6.jar - Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar -Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test [Working Directory: /srv/gump/public/workspace/tomcat-7.0.x] CLASSPATH: /usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-7.0.x/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/servlet-api.ja r:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-util.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-dbcp.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/
[GUMP@vmgump-vm3]: Project tomcat-tc7.0.x-test-bio (in module tomcat-7.0.x) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-test-bio has an issue affecting its community integration. This issue affects 1 projects. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-tc7.0.x-test-bio : Tomcat 7.x, a web server implementing Java Servlet 3.0, ... Full details are available at: http://vmgump-vm3.apache.org/tomcat-7.0.x/tomcat-tc7.0.x-test-bio/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -INFO- Failed with reason build failed -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-7.0.x/output/logs-BIO -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-7.0.x/output/test-tmp-BIO/logs The following work was performed: http://vmgump-vm3.apache.org/tomcat-7.0.x/tomcat-tc7.0.x-test-bio/gump_work/build_tomcat-7.0.x_tomcat-tc7.0.x-test-bio.html Work Name: build_tomcat-7.0.x_tomcat-tc7.0.x-test-bio (Type: Build) Work ended in a state of : Failed Elapsed: 19 mins 20 secs Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only -Dsun.zip.disableMemoryMapping=true org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar -Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-3.1-SNAPSHOT.jar -Dtest.reports=output/logs-BIO -Dexamples.sources.skip=true -Dbase.path=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-build-libs -Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.10-201812060815/ecj-4.10.jar -Dtest.relaxTiming=true -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/target/commons-daemon-1.1.1-SNAPSHOT.jar -Dtest.temp=output/test-tmp-BIO -Dtest.accesslog=true -Dexecute.test.nio=false -Dtest.exclude=**/TestFlushableGZIPOutputStream.java -Dexecute.test.bio=true -Dexecute.test.apr=false -Dtest.excludePerformance=true -Deasymock.jar=/srv/gump/packages/easymock3/easymock-3.6.jar - Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar -Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test [Working Directory: /srv/gump/public/workspace/tomcat-7.0.x] CLASSPATH: /usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-7.0.x/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/servlet-api.ja r:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-tribes.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/catalina-ha.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-util.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/tomcat-dbcp.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-7.0.x/output/build/lib/
[GUMP@vmgump-vm3]: Project tomcat-tc7.0.x-validate (in module tomcat-7.0.x) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-tc7.0.x-validate has an issue affecting its community integration. This issue affects 1 projects. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-tc7.0.x-validate : Tomcat 7.x, a web server implementing Java Servlet 3.0, ... Full details are available at: http://vmgump-vm3.apache.org/tomcat-7.0.x/tomcat-tc7.0.x-validate/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on checkstyle exists, no need to add for property checkstyle.jar. -INFO- Failed with reason build failed The following work was performed: http://vmgump-vm3.apache.org/tomcat-7.0.x/tomcat-tc7.0.x-validate/gump_work/build_tomcat-7.0.x_tomcat-tc7.0.x-validate.html Work Name: build_tomcat-7.0.x_tomcat-tc7.0.x-validate (Type: Build) Work ended in a state of : Failed Elapsed: 19 secs Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only -Dsun.zip.disableMemoryMapping=true org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Dbase.path=/srv/gump/public/workspace/tomcat-7.0.x/tomcat-build-libs -Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-8.20-SNAPSHOT.jar -Dexecute.validate=true validate [Working Directory: /srv/gump/public/workspace/tomcat-7.0.x] CLASSPATH: /usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-8.20-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/commons-beanutils/dist/commons-beanutils-20190410.jar:/srv/gump/packages/commons-collections3/commons-collections-3.2.1.jar:/srv/gump/public/workspace/commons-cli/target/commons-cli-1.5-SNAPSHOT.jar:/srv/gump/public/workspace/commons-lang-trunk/target/commons-lang3-3.9-SNAPSHOT.jar:/srv/gump/pu blic/workspace/apache-commons/logging/target/commons-logging-20190410.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-20190410.jar:/srv/gump/public/workspace/google-guava/guava/target/guava-HEAD-jre-SNAPSHOT.jar - Buildfile: /srv/gump/public/workspace/tomcat-7.0.x/build.xml build-prepare: [delete] Deleting directory /srv/gump/public/workspace/tomcat-7.0.x/output/build/temp [mkdir] Created dir: /srv/gump/public/workspace/tomcat-7.0.x/output/build/temp compile-prepare: download-validate: proxyflags: setproxy: testexist: [echo] Testing for /srv/gump/public/workspace/checkstyle/target/checkstyle-8.20-SNAPSHOT.jar downloadfile: validate: [mkdir] Created dir: /srv/gump/public/workspace/tomcat-7.0.x/output/res/checkstyle [checkstyle] Running Checkstyle 8.20-SNAPSHOT on 2715 files [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-7.0.x/test/org/apache/tomcat/websocket/TesterFirehoseServer.java:40: Wrong order for 'javax.websocket.ClientEndpointConfig.Configurator' import. [ImportOrder] [checkstyle] [ERROR] /srv/gump/public/workspace/tomcat-7.0.x/test/org/apache/tomcat/websocket/TesterFirehoseServer.java:52: Wrong order for 'org.junit.Assert' import. [ImportOrder] BUILD FAILED /srv/gump/public/workspace/tomcat-7.0.x/build.xml:548: Got 2 errors and 0 warnings. Total time: 19 seconds - To subscribe to this information via syndicated feeds: - RSS: http://vmgump-vm3.apache.org/tomcat-7.0.x/tomcat-tc7.0.x-validate/rss.xml - Atom: http://vmgump-vm3.apache.org/tomcat-7.0.x/tomcat-tc7.0.x-validate/atom.xml == Gump Tracking Only === Produced by Apache Gump(TM) version 2.3. Gump Run 2019041007, vmgump-vm3.apache.org:vmgump:2019041007 Gump E-mail Identifier (unique within run) #5. -- Apache Gump http://gump.apache.org/ [Instance: vmgump-vm3] - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Tagging 9.0.18
На вт, 9.04.2019 г. в 20:45 ч. Mark Thomas написа: > > Hi all, > > I'm a bit behind again this month - mainly because I was at the http > workshop last week (very useful - a write-up is on the way). I've been > through the open bugs and resolved those that don't require more > research / 3rd party releases etc. so I am close to tagging. > > I want to run the unit tests as a final check before I tag. Depending on > how things go I intend to tag either later today or early tomorrow. > > I'll also tag 8.5.x and possibly 7.0.x as well. I can help with 7.0.x if you want? Regards, Violeta > > Mark > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org
Tagging 9.0.18
Hi all, I'm a bit behind again this month - mainly because I was at the http workshop last week (very useful - a write-up is on the way). I've been through the open bugs and resolved those that don't require more research / 3rd party releases etc. so I am close to tagging. I want to run the unit tests as a final check before I tag. Depending on how things go I intend to tag either later today or early tomorrow. I'll also tag 8.5.x and possibly 7.0.x as well. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on issue #139: service.bat handles changed Service at installation
markt-asf commented on issue #139: service.bat handles changed Service at installation URL: https://github.com/apache/tomcat/pull/139#issuecomment-481356608 The patch needs some more work. Currently it works if you install a different service name using the installer (because `tomcat9[w].exe` are renamed) but it fails if you install from the zip and try `service.bat install foo` I suggest you update the patch to first look for `tomcat9[w].exe` and then, if that is not found, `servicename[w].exe` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63306] Memory leak during websocket connection close
https://bz.apache.org/bugzilla/show_bug.cgi?id=63306 Mark Thomas changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #4 from Mark Thomas --- I can't re-create the scenario you describe. I have been using the Snake game from the WebSocket examples and disabling the WiFi on the client device. What I observe is: - Tomcat continues to be able to write to the client without any apparent error - There is (eventually) an I/O exception on read but it takes about 15 minutes to occur If I give it long enough, everything does get tidied up. I have been unable to trigger a permanent memory leak. I strongly suspect that the time taken for the connection to fail will be highly dependent on the network. It is not clear whether you are seeing the same behaviour as I am or if you are seeing a genuine memory leak. I have also done some testing with the TesterFirehoseServer class. Using the async API appears to trigger this issue more readily than the basic API. This time the I/O exception was on write but it was still after about 15 minutes. If you believe you have found a genuine memory leak then feel free to re-open this issue but you will need to provide the steps to reproduce it (possibly with a simple test web application) on a clean install of the latest 7.0.x release. Generally, I'd expect the WebSocket implementation in 8.5.x onwards to perform better. It uses the I/O layer directly rather than using the Servlet non-blocking I/O API. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 7.0.x updated: Add a standalone server and client for testing connection failures
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 7.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/7.0.x by this push:
new d70a569 Add a standalone server and client for testing connection
failures
d70a569 is described below
commit d70a569f2759138847d0d9448f11694d04aaa6c8
Author: Mark Thomas
AuthorDate: Tue Apr 9 15:51:46 2019 +0100
Add a standalone server and client for testing connection failures
---
.../tomcat/websocket/TesterFirehoseServer.java | 100 -
1 file changed, 99 insertions(+), 1 deletion(-)
diff --git a/test/org/apache/tomcat/websocket/TesterFirehoseServer.java
b/test/org/apache/tomcat/websocket/TesterFirehoseServer.java
index a4f7fff..222ed05 100644
--- a/test/org/apache/tomcat/websocket/TesterFirehoseServer.java
+++ b/test/org/apache/tomcat/websocket/TesterFirehoseServer.java
@@ -17,9 +17,18 @@
package org.apache.tomcat.websocket;
import java.io.IOException;
+import java.net.URI;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import java.util.Queue;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicInteger;
import javax.servlet.ServletContextEvent;
+import javax.websocket.ClientEndpointConfig;
+import javax.websocket.ContainerProvider;
import javax.websocket.DeploymentException;
import javax.websocket.OnClose;
import javax.websocket.OnError;
@@ -27,11 +36,20 @@ import javax.websocket.OnMessage;
import javax.websocket.OnOpen;
import javax.websocket.RemoteEndpoint.Basic;
import javax.websocket.Session;
+import javax.websocket.WebSocketContainer;
+import javax.websocket.ClientEndpointConfig.Configurator;
import javax.websocket.server.ServerContainer;
import javax.websocket.server.ServerEndpoint;
+import org.apache.catalina.Context;
+import org.apache.catalina.servlets.DefaultServlet;
+import org.apache.catalina.startup.Tomcat;
+import org.apache.catalina.startup.TomcatBaseTest;
+import org.apache.tomcat.websocket.TesterMessageCountClient.BasicText;
+import
org.apache.tomcat.websocket.TesterMessageCountClient.TesterProgrammaticEndpoint;
import org.apache.tomcat.websocket.server.Constants;
import org.apache.tomcat.websocket.server.WsContextListener;
+import org.junit.Assert;
/**
* Sends {@link #MESSAGE_COUNT} messages of size {@link #MESSAGE_SIZE} bytes as
@@ -39,7 +57,7 @@ import org.apache.tomcat.websocket.server.WsContextListener;
*/
public class TesterFirehoseServer {
-public static final int MESSAGE_COUNT = 10;
+public static final int MESSAGE_COUNT = 100;
public static final String MESSAGE;
public static final int MESSAGE_SIZE = 1024;
public static final int WAIT_TIME_MILLIS = 6;
@@ -139,4 +157,84 @@ public class TesterFirehoseServer {
openConnectionCount.decrementAndGet();
}
}
+
+
+/*
+ * Run as a stand-alone server for testing over a real network
+ */
+public static class Standalone extends TomcatBaseTest {
+
+public static void main(String... args) throws Exception {
+Standalone s = new Standalone();
+s.start();
+}
+
+public void start() throws Exception {
+setUpPerTestClass();
+setUp();
+Tomcat tomcat = getTomcatInstance();
+// No file system docBase required
+Context ctx = tomcat.addContext("", null);
+
ctx.addApplicationListener(TesterFirehoseServer.Config.class.getName());
+Tomcat.addServlet(ctx, "default", new DefaultServlet());
+ctx.addServletMapping("/", "default");
+
+tomcat.start();
+
+while (true) {
+Thread.sleep(1000);
+}
+}
+}
+
+
+/*
+ * Run as a stand-alone client for testing over a real network.
+ *
+ * args[0] is host:port
+ */
+public static class Client {
+
+public static void main(String... args) throws Exception {
+
+WebSocketContainer wsContainer =
ContainerProvider.getWebSocketContainer();
+
+// BZ 62596
+final StringBuilder dummyValue = new StringBuilder(4000);
+for (int i = 0; i < 4000; i++) {
+dummyValue.append('A');
+}
+ClientEndpointConfig clientEndpointConfig =
+ClientEndpointConfig.Builder.create().configurator(new
Configurator() {
+@Override
+public void beforeRequest(Map>
headers) {
+headers.put("Dummy",
Collections.singletonList(dummyValue.toString()));
+super.beforeRequest(headers);
+}
+}).build();
+
+Session wsSession = wsContainer.connectToServer(
+
[Bug 63311] Allow to use https: protocol in xsi:schemaLocation of web.xml, web-fragment.xml (validation fails with recent releases of Spring)
https://bz.apache.org/bugzilla/show_bug.cgi?id=63311 --- Comment #4 from Konstantin Kolinko --- I tested builds of current master and 7.0.x branches. The issue is fixed. Thank you. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63324] CrawlerSessionManagerValve is getting put into Session, which causes problems when serializing sessions
https://bz.apache.org/bugzilla/show_bug.cgi?id=63324 --- Comment #5 from Martin L --- Thanks for your feedback. I've applied your suggestions, but needed to customize them a bit, depending on the branch. There are 3 PRs, one for 7.0.x, one for 8.5.x and one for master. In 7.0.x the test setup looks a slightly bit different, and you need to implement both interface methods of HttpSessionBindingListener https://github.com/apache/tomcat/pull/156 In 8.5.x I couldn't use the signature Map.remove(key, value). I was getting a `method remove in interface Map cannot be applied to given types; clientIdSessionId.remove(clientIdentifier, event.getSession().getId());` when running the tests. So I needed to check for the same value in an extra if. https://github.com/apache/tomcat/pull/155 In master is the "cleanest" solution. https://github.com/apache/tomcat/pull/154 Do you want me to upload all 3 patches here? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 7.0.x updated: Fix debug message parameter
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 7.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/7.0.x by this push:
new 05fd80a Fix debug message parameter
05fd80a is described below
commit 05fd80a299a39e76af5514c562b775d449eeca6f
Author: Mark Thomas
AuthorDate: Tue Apr 9 12:51:35 2019 +0100
Fix debug message parameter
---
java/org/apache/tomcat/websocket/LocalStrings.properties | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/java/org/apache/tomcat/websocket/LocalStrings.properties
b/java/org/apache/tomcat/websocket/LocalStrings.properties
index cad3df4..c8808e4 100644
--- a/java/org/apache/tomcat/websocket/LocalStrings.properties
+++ b/java/org/apache/tomcat/websocket/LocalStrings.properties
@@ -94,7 +94,7 @@ wsSession.timeout=The WebSocket session timeout expired
wsSession.closed=The WebSocket session [{0}] has been closed and no method
(apart from close()) may be called on a closed session
wsSession.created=Created WebSocket session [{0}]
-wsSession.doClose=Closing WebSocket session [{1}]
+wsSession.doClose=Closing WebSocket session [{0}]
wsSession.duplicateHandlerBinary=A binary message handler has already been
configured
wsSession.duplicateHandlerPong=A pong message handler has already been
configured
wsSession.duplicateHandlerText=A text message handler has already been
configured
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [tomcat] branch master updated: Fix the HTTP/2 equivalent of swallowInput
On Tue, Apr 9, 2019 at 10:43 AM Mark Thomas wrote:
> On 09/04/2019 08:50, Rémy Maucherat wrote:
>
>
>
> > Thanks for the fix. I can indeed see that HttpParser.onHeadersComplete
> has:
> > output.headersEnd(streamId); // <- dispatch is done here
> >
> > if (headersEndStream) {
> > output.receivedEndOfStream(streamId);
> > headersEndStream = false;
> > }
> >
> > I guess it's possible to rely on syncing but normally thread dispatching
> > should not occur until after the state is properly set, it's simply
> safer.
>
> I did think about swapping the order of those statements. When I tested
> it I saw one test failure with trailer headers (I didn't investigate
> further) so I went for a different solution.
>
There is a failure indeed, but it's a logging issue only it seems (the
callback log the events in order, so it doesn't match the comparison string
anymore).
>
> It may be the swapping the order is safe but that would need more
> investigation. Also, triggering EOS before end of headers just seems
> wrong to me.
>
I agree it seems wrong. There's another occurrence of the behavior though,
in Http2Parser.readDataFrame, where it does:
if (endOfStream) {
output.receivedEndOfStream(streamId);
}
output.endRequestBodyFrame(streamId);
I will try to investigate, but only after the next build, it's clearly not
worth breaking something.
Rémy
[GUMP@vmgump-vm3]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test-nio2 has an issue affecting its community integration. This issue affects 1 projects. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - tomcat-trunk-test-nio2 : Tomcat 9.x, a web server implementing the Java Servlet 4.0, ... Full details are available at: http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-test-nio2/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Dependency on bnd exists, no need to add for property bndlib.jar. -INFO- Failed with reason build failed -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-trunk/output/logs-NIO2 -INFO- Project Reports in: /srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO2/logs -WARNING- No directory [/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-NIO2/logs] The following work was performed: http://vmgump-vm3.apache.org/tomcat-trunk/tomcat-trunk-test-nio2/gump_work/build_tomcat-trunk_tomcat-trunk-test-nio2.html Work Name: build_tomcat-trunk_tomcat-trunk-test-nio2 (Type: Build) Work ended in a state of : Failed Elapsed: 24 mins 47 secs Command Line: /usr/lib/jvm/java-8-oracle/bin/java -Djava.awt.headless=true -Dbuild.sysclasspath=only -Dsun.zip.disableMemoryMapping=true org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs -Dbnd.jar=/srv/gump/packages/bnd/bnd-4.0.0/biz.aQute.bnd-4.0.0.jar -Dsaaj-api.jar=/srv/gump/packages/saaj-api/saaj-api-1.3.5.jar -Djaxrpc-lib.jar=/srv/gump/packages/jaxrpc/geronimo-spec-jaxrpc-1.1-rc4.jar -Dtest.temp=output/test-tmp-NIO2 -Djunit.jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar -Djava.net.preferIPv4Stack=/srv/gump/public/workspace/tomcat-trunk/true -Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-3.1-SNAPSHOT.jar -Dexamples.sources.skip=true -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/target/commons-daemon-1.1.1-SNAPSHOT.jar -Dtest.openssl.path=/srv/gump/public/workspace/openssl-master/dest-20190409/bin/openssl -Dexecute .test.nio=false -Dhamcrest.jar=/srv/gump/packages/hamcrest/hamcrest-core-1.3.jar -Dbndlib.jar=/srv/gump/packages/bnd/bndlib-4.0.0/biz.aQute.bndlib-4.0.0.jar -Dexecute.test.apr=false -Dwsdl4j-lib.jar=/srv/gump/packages/wsdl4j/wsdl4j-1.6.3.jar -Dtest.reports=output/logs-NIO2 -Dexecute.test.nio2=true -Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.10-201812060815/ecj-4.10.jar -Dtest.relaxTiming=true -Dtest.excludePerformance=true -Dtest.accesslog=true -Deasymock.jar=/srv/gump/public/workspace/easymock/core/target/easymock-4.1-SNAPSHOT.jar -Dcglib.jar=/srv/gump/packages/cglib/cglib-nodep-2.2.jar test [Working Directory: /srv/gump/public/workspace/tomcat-trunk] CLASSPATH: /usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/webapps/examples/WEB-INF/classes:/srv/gump/public/workspace/tomcat-trunk/output/testclasses:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/bootstrap.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/bin/tomcat-juli.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/annotations-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/servlet-api.ja r:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jsp-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/el-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/websocket-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jaspic-api.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-ant.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-storeconfig.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/tomcat-coyote.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/jasper-el.jar:/srv/gump/public/workspace/tomcat-trunk/output/build/lib/catalina-tribes.jar:/srv
[GitHub] [tomcat] kkolinko commented on issue #154: Don't place CrawlerSessionManagerValve into session, place data-holder only
kkolinko commented on issue #154: Don't place CrawlerSessionManagerValve into session, place data-holder only URL: https://github.com/apache/tomcat/pull/154#issuecomment-481178151 I commented in Bugzilla, starting with https://bz.apache.org/bugzilla/show_bug.cgi?id=63324#c2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63324] CrawlerSessionManagerValve is getting put into Session, which causes problems when serializing sessions
https://bz.apache.org/bugzilla/show_bug.cgi?id=63324
--- Comment #4 from Konstantin Kolinko ---
Based on the analysis in comment #3 I think that a possible solution is to
adjust the original proposal as follows. I am quoting fragments from attachment
36515
[[[
+private static class CrawlerHttpSessionBindingListener implements
HttpSessionBindingListener {
+private final Map clientIdSessionId;
+private final Map sessionIdClientId;
]]]
Three changes are needed:
1. Declare CrawlerHttpSessionBindingListener to implement java.io.Serializable.
2. The "clientIdSessionId" field should be declared transient.
3. The "sessionIdClientId" field does not need to be a Map. Just add a String
field "String clientIdentifier" that stores a single value. The field can be
transient as well.
[[[
+@Override
+public void valueUnbound(HttpSessionBindingEvent event) {
+String clientIdentifier =
sessionIdClientId.remove(event.getSession().getId());
+if (clientIdentifier != null) {
+clientIdSessionId.remove(clientIdentifier);
+}
}
]]]
4. Add a check that clientIdSessionId is not null.
Duplicate removals can he handled by using method Map.remove(key, value) that
removes a key only if the value matches.
if (clientIdentifier != null && clientIdSessionId != null) {
clientIdSessionId.remove(clientIdentifier, event.getSession().getId());
}
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63324] CrawlerSessionManagerValve is getting put into Session, which causes problems when serializing sessions
https://bz.apache.org/bugzilla/show_bug.cgi?id=63324
--- Comment #3 from Konstantin Kolinko ---
Note that the assumption of CrawlerSessionManagerValve is that the clients does
not support cookies. Thus it forcefully assigns them to the same session based
on their IP addresses.
[[[
if (isBot) {
sessionId = clientIdSessionId.get(clientIdentifier);
]]]
1) If the client really does not support cookies, once you stop and start
Tomcat, the "clientIdSessionId" map is lost and you have lost access to those
sessions. They will never be accessed again.
They will just time out after some time elapses - "sessionInactiveInterval" in
CrawlerSessionManagerValve defaults to 60 seconds.
(Thus it makes sense to do not serialize those sessions at all, to do not
replicate them etc.
Serializing the original maps (like proposed by PR 154) does not make any
sense.)
2) If client supports cookies, you do not need a CrawlerSessionManagerValve.
Thus you not not need a value in a "clientIdSessionId" map. You will access the
session using the sessionid provided by a Cookie.
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] mlem commented on issue #154: Don't serialize CrawlerSessionManagerValve into session attributes
mlem commented on issue #154: Don't serialize CrawlerSessionManagerValve into session attributes URL: https://github.com/apache/tomcat/pull/154#issuecomment-481173301 > But the implementation doesn't actually stop anything from being serialized: those two big maps are still serialized along with the rest of the stream. What you are avoiding is serializing the class loader which is happening because of the Valve itself. In comparison to the container object (which holds plenty of stuff, as I've seen) this doesn't seem like a big deal. As I understood, there is one entry for each crawler (1 crawler = 1 entry in map x2 = clientId x2 + sessionId x2). we would need to have plenty of crawlers within 60 seconds to fill this map big enough to make it serious. > Instead of storing something in the session, CrawlerSessionManagerValve should instead be changed to be an HttpSessionListener which won't be serialized when the session is written-out. It has the added benefit of being simpler than the current code. That sounds good, but I would need to hook into the lifecycle of this valve (or into the lifecycle of the web application itself). Due to the dynamic nature of your valves, I don't know where this class get's initialized. Can you point me out, where I would register this listener? > Using an HttpSessionListener gets tricky because it has to be registered with every web application. That is do-able but will add a fair amount of complexity - particularly to handle automatic deployment. > > The patch looks reasonable. I can't think of a better way to handle this. I see it the same way. And thanks. I'll change the title again. Do you need a changed commit message too? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63324] CrawlerSessionManagerValve is getting put into Session, which causes problems when serializing sessions
https://bz.apache.org/bugzilla/show_bug.cgi?id=63324 --- Comment #2 from Konstantin Kolinko --- Created attachment 36515 --> https://bz.apache.org/bugzilla/attachment.cgi?id=36515=edit 154.patch (a copy of PR 154) A copy of the current code in PR 154, formatted as a patch. I'll comment on it, so let's keep a copy here. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [tomcat] branch master updated: Fix the HTTP/2 equivalent of swallowInput
On 09/04/2019 08:50, Rémy Maucherat wrote:
> Thanks for the fix. I can indeed see that HttpParser.onHeadersComplete has:
> output.headersEnd(streamId); // <- dispatch is done here
>
> if (headersEndStream) {
> output.receivedEndOfStream(streamId);
> headersEndStream = false;
> }
>
> I guess it's possible to rely on syncing but normally thread dispatching
> should not occur until after the state is properly set, it's simply safer.
I did think about swapping the order of those statements. When I tested
it I saw one test failure with trailer headers (I didn't investigate
further) so I went for a different solution.
It may be the swapping the order is safe but that would need more
investigation. Also, triggering EOS before end of headers just seems
wrong to me.
Mark
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 63237] Consider processing mbeans-descriptors.xml at compile time
https://bz.apache.org/bugzilla/show_bug.cgi?id=63237 --- Comment #6 from Konstantin Kolinko --- (In reply to Phillip Webb from comment #4) > That's a really interesting metric and quite a significant amount if we're > talking about using embedded Tomcat in a serverless environment where runs > are very short lived. 1. I guess that in your use case of short-lived Tomcats (or whatever those "serverless" environment is) you do not need JMX support at all. (And thus no need to really parse these files). 2. The topic of JMX was also mentioned in thread "Becoming graalvm friendly?" on dev#. https://tomcat.markmail.org/thread/kayfacujrpt2diht -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [tomcat] branch master updated: Fix the HTTP/2 equivalent of swallowInput
On Mon, Apr 8, 2019 at 10:49 PM Mark Thomas wrote:
> On 08/04/2019 20:38, Mark Thomas wrote:
>
>
>
> > I'm not sure. Do you have the complete logs for those tests? I'd like to
> > look at everything sent from the client to the server for stream 3.
>
> Thanks for the logs (sent off-list). They didn't line up with my code
> which made me realise I was working with the 8.5.x branch rather than
> master. As soon as I switched to the right branch I was able to exploit
> the timing gap I thought I'd found.
>
> > I'd got as far as thinking that the server wasn't (always) marking
> > stream 3 as half-closed and my next steps are to try and figure out why.
>
> The short version is that the thread (A) parsing the incoming frames
> first signals end of headers. This starts the container thread (B) with
> a new StreamProcessor to process the request.
>
> Thread A then continues and signals end of stream.
>
> If Thread B processes the request, writes the response and gets as far
> as the new check I added before thread A signals end of stream, you see
> the reset.
>
> This only happens with NIO2.
>
> There should be a sync that prevents this. There is in the non-async case.
>
> Next steps are to figure out which sync is missing and where it needs to
> go.
>
Thanks for the fix. I can indeed see that HttpParser.onHeadersComplete has:
output.headersEnd(streamId); // <- dispatch is done here
if (headersEndStream) {
output.receivedEndOfStream(streamId);
headersEndStream = false;
}
I guess it's possible to rely on syncing but normally thread dispatching
should not occur until after the state is properly set, it's simply safer.
Rémy
>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>
[Bug 63320] StatementCache interceptor does not cache statements that return values in dedicated columns
https://bz.apache.org/bugzilla/show_bug.cgi?id=63320 Keiichi Fujino changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #2 from Keiichi Fujino --- Thanks for the report. The fix will be in : - 9.0.x for 9.0.18 onwards - 8.5.x for 8.5.40 onwards - 7.0.x for 7.0.94 onwards -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 7.0.x updated: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63320 Ensure that StatementCache caches statements that include arrays in arguments.
This is an automated email from the ASF dual-hosted git repository.
kfujino pushed a commit to branch 7.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/7.0.x by this push:
new e5c260d Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63320
Ensure that StatementCache caches statements that include arrays in arguments.
e5c260d is described below
commit e5c260d9a881271f374e5385519b4bc30a0c5bf8
Author: KeiichiFujino
AuthorDate: Tue Apr 9 16:25:43 2019 +0900
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63320
Ensure that StatementCache caches statements that include arrays in
arguments.
---
.../org/apache/tomcat/jdbc/pool/interceptor/StatementCache.java | 4 ++--
webapps/docs/changelog.xml| 8
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git
a/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementCache.java
b/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementCache.java
index 90a5bb0..7f5d049 100644
---
a/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementCache.java
+++
b/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementCache.java
@@ -335,7 +335,7 @@ public class StatementCache extends
StatementDecoratorInterceptor {
public int hashCode() {
final int prime = 31;
int result = 1;
-result = prime * result + Arrays.hashCode(args);
+result = prime * result + Arrays.deepHashCode(args);
result = prime * result
+ ((stmtType == null) ? 0 : stmtType.hashCode());
return result;
@@ -350,7 +350,7 @@ public class StatementCache extends
StatementDecoratorInterceptor {
if (getClass() != obj.getClass())
return false;
CacheKey other = (CacheKey) obj;
-if (!Arrays.equals(args, other.args))
+if (!Arrays.deepEquals(args, other.args))
return false;
if (stmtType == null) {
if (other.stmtType != null)
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 8813a12..71aeca6 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -172,6 +172,14 @@
+
+
+
+63320: Ensure that StatementCache caches
+statements that include arrays in arguments. (kfujino)
+
+
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch 8.5.x updated: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63320 Ensure that StatementCache caches statements that include arrays in arguments.
This is an automated email from the ASF dual-hosted git repository.
kfujino pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new 7fc16d1 Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63320
Ensure that StatementCache caches statements that include arrays in arguments.
7fc16d1 is described below
commit 7fc16d19d3aa54f4d67a3185af19195792d22f9c
Author: KeiichiFujino
AuthorDate: Tue Apr 9 16:15:59 2019 +0900
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63320
Ensure that StatementCache caches statements that include arrays in
arguments.
---
.../org/apache/tomcat/jdbc/pool/interceptor/StatementCache.java | 4 ++--
webapps/docs/changelog.xml| 8
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git
a/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementCache.java
b/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementCache.java
index 15d0e49..03b7f84 100644
---
a/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementCache.java
+++
b/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementCache.java
@@ -359,7 +359,7 @@ public class StatementCache extends
StatementDecoratorInterceptor implements Sta
public int hashCode() {
final int prime = 31;
int result = 1;
-result = prime * result + Arrays.hashCode(args);
+result = prime * result + Arrays.deepHashCode(args);
result = prime * result
+ ((stmtType == null) ? 0 : stmtType.hashCode());
return result;
@@ -374,7 +374,7 @@ public class StatementCache extends
StatementDecoratorInterceptor implements Sta
if (getClass() != obj.getClass())
return false;
CacheKey other = (CacheKey) obj;
-if (!Arrays.equals(args, other.args))
+if (!Arrays.deepEquals(args, other.args))
return false;
if (stmtType == null) {
if (other.stmtType != null)
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 13df265..03c1f53 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -161,6 +161,14 @@
+
+
+
+63320: Ensure that StatementCache caches
+statements that include arrays in arguments. (kfujino)
+
+
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch master updated: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63320 Ensure that StatementCache caches statements that include arrays in arguments.
This is an automated email from the ASF dual-hosted git repository.
kfujino pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new 9ea280c Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63320
Ensure that StatementCache caches statements that include arrays in arguments.
9ea280c is described below
commit 9ea280c7266765a20b405059f9b02be5d5942133
Author: KeiichiFujino
AuthorDate: Tue Apr 9 16:04:33 2019 +0900
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63320
Ensure that StatementCache caches statements that include arrays in
arguments.
---
.../java/org/apache/tomcat/jdbc/pool/interceptor/StatementCache.java | 4 ++--
webapps/docs/changelog.xml| 4
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git
a/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementCache.java
b/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementCache.java
index 4d20f86..55baf23 100644
---
a/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementCache.java
+++
b/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementCache.java
@@ -346,7 +346,7 @@ public class StatementCache extends
StatementDecoratorInterceptor implements Sta
public int hashCode() {
final int prime = 31;
int result = 1;
-result = prime * result + Arrays.hashCode(args);
+result = prime * result + Arrays.deepHashCode(args);
result = prime * result
+ ((stmtType == null) ? 0 : stmtType.hashCode());
return result;
@@ -361,7 +361,7 @@ public class StatementCache extends
StatementDecoratorInterceptor implements Sta
if (getClass() != obj.getClass())
return false;
CacheKey other = (CacheKey) obj;
-if (!Arrays.equals(args, other.args))
+if (!Arrays.deepEquals(args, other.args))
return false;
if (stmtType == null) {
if (other.stmtType != null)
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index e4ccff3..da228e1 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -181,6 +181,10 @@
Connection that expired reconnects rather than closes it. Patch
provided
by toby1984. (kfujino)
+
+63320: Ensure that StatementCache caches
+statements that include arrays in arguments. (kfujino)
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
