RE: [tomcat] branch master updated: Fixed false positives in unit tests on Windows
Mark,
I just realized that you refactored my fix for the false positive unit test
[1] a while ago. Unfortunately your refactoring still shows false
positives if the path of the command prompt has a lower-cased driver
letter, e.g.
expected: but
was:
I pushed a different fix earlier, prior to noticing your refactoring (TBH I
thought that I never pushed the fix in the first place), which does an
equalsIgnoreCase() [2]
The only unit tests where I experience this issue
are TestAbstractArchiveResource.java and TestFileResource.java and the
problem seems to be with the Driver Letter which appears in brackets, e.g.
[E] vs. [e].
If you think that a full case-insensitive comparison is not right then I
can modify only the drive letter if the pattern "jar:war:file:/[X]" is
found.
Any thoughts?
Igal
[1]
https://github.com/apache/tomcat/commit/db71c925106915581f1b60b0fda9c352fcdd9138#diff-717001e0451788fe9f26d1176a4fff54
[2]
https://github.com/apache/tomcat/commit/985d0086329c012a994c842f0a88a9b33989827c#diff-717001e0451788fe9f26d1176a4fff54R43
On Thu, Apr 11, 2019 at 11:28 AM wrote:
> This is an automated email from the ASF dual-hosted git repository.
>
> isapir pushed a commit to branch master
> in repository https://gitbox.apache.org/repos/asf/tomcat.git
>
>
> The following commit(s) were added to refs/heads/master by this push:
> new 985d008 Fixed false positives in unit tests on Windows
> 985d008 is described below
>
> commit 985d0086329c012a994c842f0a88a9b33989827c
> Author: Igal Sapir
> AuthorDate: Thu Apr 11 08:45:22 2019 -0700
>
> Fixed false positives in unit tests on Windows
>
> When the drive letter is lower cased in a Windows command prompt the
> test cases were failing with
> expected: but
> was:
> ---
> .../org/apache/catalina/webresources/TestAbstractArchiveResource.java | 4
> ++--
> test/org/apache/catalina/webresources/TestFileResource.java | 2
> +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git
> a/test/org/apache/catalina/webresources/TestAbstractArchiveResource.java
> b/test/org/apache/catalina/webresources/TestAbstractArchiveResource.java
> index 9c59fd8..e573d91 100644
> ---
> a/test/org/apache/catalina/webresources/TestAbstractArchiveResource.java
> +++
> b/test/org/apache/catalina/webresources/TestAbstractArchiveResource.java
> @@ -48,7 +48,7 @@ public class TestAbstractArchiveResource extends
> TomcatBaseTest {
>
> expectedURL.append(docBase.getCanonicalFile().toURI().toURL().toString());
>
> expectedURL.append("*/WEB-INF/lib/test.jar!/META-INF/resources/index.html");
>
> -Assert.assertEquals(expectedURL.toString(),
> webResource.getURL().toString());
> +
> Assert.assertTrue(expectedURL.toString().equalsIgnoreCase(webResource.getURL().toString()));
> }
>
>
> @@ -71,7 +71,7 @@ public class TestAbstractArchiveResource extends
> TomcatBaseTest {
>
> expectedURL.append(docBase.getCanonicalFile().toURI().toURL().toString());
>
> expectedURL.append("WEB-INF/lib/test-lib.jar!/META-INF/tags/echo.tag");
>
> -Assert.assertEquals(expectedURL.toString(),
> webResource.getURL().toString());
> +
> Assert.assertTrue(expectedURL.toString().equalsIgnoreCase(webResource.getURL().toString()));
> }
>
> }
> diff --git a/test/org/apache/catalina/webresources/TestFileResource.java
> b/test/org/apache/catalina/webresources/TestFileResource.java
> index 315212a..2bd7ef3 100644
> --- a/test/org/apache/catalina/webresources/TestFileResource.java
> +++ b/test/org/apache/catalina/webresources/TestFileResource.java
> @@ -40,6 +40,6 @@ public class TestFileResource extends TomcatBaseTest {
>
> // Build the expected location the same way the webapp base dir
> is built
> File f = new File("test/webapp/WEB-INF/classes");
> -
> Assert.assertEquals(f.getCanonicalFile().toURI().toURL().toString(),
> out.toString().trim());
> +
> Assert.assertTrue(f.getCanonicalFile().toURI().toURL().toString().equalsIgnoreCase(out.toString().trim()));
> }
> }
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
[tomcat] branch master updated: Update ServerInfo to reflect actual information instead of placeholders when running development builds
This is an automated email from the ASF dual-hosted git repository.
csutherl pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new c8748aa Update ServerInfo to reflect actual information instead of
placeholders when running development builds
c8748aa is described below
commit c8748aaf9f3f7bc9f38c5805ed80e1a333696216
Author: Coty Sutherland
AuthorDate: Thu Apr 11 15:45:55 2019 -0400
Update ServerInfo to reflect actual information instead of placeholders
when running development builds
---
java/org/apache/catalina/util/ServerInfo.java | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/java/org/apache/catalina/util/ServerInfo.java
b/java/org/apache/catalina/util/ServerInfo.java
index 020d926..a70b5bf 100644
--- a/java/org/apache/catalina/util/ServerInfo.java
+++ b/java/org/apache/catalina/util/ServerInfo.java
@@ -68,11 +68,11 @@ public class ServerInfo {
} catch (Throwable t) {
ExceptionUtils.handleThrowable(t);
}
-if (info == null)
-info = "Apache Tomcat 9.0.x-dev";
-if (built == null)
+if (info == null || info.equals("Apache Tomcat/@VERSION@"))
+info = "Apache Tomcat/9.0.x-dev";
+if (built == null || built.equals("@VERSION_BUILT@"))
built = "unknown";
-if (number == null)
+if (number == null || number.equals("@VERSION_NUMBER@"))
number = "9.0.x";
serverInfo = info;
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch master updated: Add check for registration of the proper objects
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new ccc5e92 Add check for registration of the proper objects
ccc5e92 is described below
commit ccc5e92914e5cf073533f9bca52dc48d4ecd2afe
Author: remm
AuthorDate: Thu Apr 11 21:19:34 2019 +0200
Add check for registration of the proper objects
---
test/org/apache/catalina/mbeans/TestRegistration.java | 5 +
1 file changed, 5 insertions(+)
diff --git a/test/org/apache/catalina/mbeans/TestRegistration.java
b/test/org/apache/catalina/mbeans/TestRegistration.java
index 5204c3e..2049f81 100644
--- a/test/org/apache/catalina/mbeans/TestRegistration.java
+++ b/test/org/apache/catalina/mbeans/TestRegistration.java
@@ -214,6 +214,11 @@ public class TestRegistration extends TomcatBaseTest {
additional.removeAll(expected);
Assert.assertTrue("Unexpected Tomcat MBeans: " + additional,
additional.isEmpty());
+// Check a known attribute
+String connectorName = Arrays.asList(connectorMBeanNames("auto-" +
index, protocol)).get(0);
+// This should normally return "http", but any non null non exception
is good enough
+Assert.assertNotNull(mbeanServer.getAttribute(new
ObjectName(connectorName), "scheme"));
+
tomcat.stop();
// There should still be some Tomcat MBeans
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch master updated: Fixed false positives in unit tests on Windows
This is an automated email from the ASF dual-hosted git repository.
isapir pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new 985d008 Fixed false positives in unit tests on Windows
985d008 is described below
commit 985d0086329c012a994c842f0a88a9b33989827c
Author: Igal Sapir
AuthorDate: Thu Apr 11 08:45:22 2019 -0700
Fixed false positives in unit tests on Windows
When the drive letter is lower cased in a Windows command prompt the test
cases were failing with
expected: but
was:
---
.../org/apache/catalina/webresources/TestAbstractArchiveResource.java | 4 ++--
test/org/apache/catalina/webresources/TestFileResource.java | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git
a/test/org/apache/catalina/webresources/TestAbstractArchiveResource.java
b/test/org/apache/catalina/webresources/TestAbstractArchiveResource.java
index 9c59fd8..e573d91 100644
--- a/test/org/apache/catalina/webresources/TestAbstractArchiveResource.java
+++ b/test/org/apache/catalina/webresources/TestAbstractArchiveResource.java
@@ -48,7 +48,7 @@ public class TestAbstractArchiveResource extends
TomcatBaseTest {
expectedURL.append(docBase.getCanonicalFile().toURI().toURL().toString());
expectedURL.append("*/WEB-INF/lib/test.jar!/META-INF/resources/index.html");
-Assert.assertEquals(expectedURL.toString(),
webResource.getURL().toString());
+
Assert.assertTrue(expectedURL.toString().equalsIgnoreCase(webResource.getURL().toString()));
}
@@ -71,7 +71,7 @@ public class TestAbstractArchiveResource extends
TomcatBaseTest {
expectedURL.append(docBase.getCanonicalFile().toURI().toURL().toString());
expectedURL.append("WEB-INF/lib/test-lib.jar!/META-INF/tags/echo.tag");
-Assert.assertEquals(expectedURL.toString(),
webResource.getURL().toString());
+
Assert.assertTrue(expectedURL.toString().equalsIgnoreCase(webResource.getURL().toString()));
}
}
diff --git a/test/org/apache/catalina/webresources/TestFileResource.java
b/test/org/apache/catalina/webresources/TestFileResource.java
index 315212a..2bd7ef3 100644
--- a/test/org/apache/catalina/webresources/TestFileResource.java
+++ b/test/org/apache/catalina/webresources/TestFileResource.java
@@ -40,6 +40,6 @@ public class TestFileResource extends TomcatBaseTest {
// Build the expected location the same way the webapp base dir is
built
File f = new File("test/webapp/WEB-INF/classes");
-Assert.assertEquals(f.getCanonicalFile().toURI().toURL().toString(),
out.toString().trim());
+
Assert.assertTrue(f.getCanonicalFile().toURI().toURL().toString().equalsIgnoreCase(out.toString().trim()));
}
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.40
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Mark,
On 4/11/19 12:40, Mark Thomas wrote:
> On 11/04/2019 15:21, Christopher Schultz wrote:
>
>
>
>> I'm having a bit of trouble building the bundled tcnative. I'm
>> tried building against OpenSSL 1.0.2k and 1.1.1 and both of the
>> "configure" invocations given me a message similar to the
>> following:
>>
>> checking for OpenSSL library... using openssl from
>> /home/cschultz/openssl-1.0.2k/target/target/${exec_prefix}/lib
>> and /home/cschultz/openssl-1.0.2k/target/target/include checking
>> OpenSSL library version >= 1.0.2... configure: error: Your
>> version of OpenSSL is not compatible with this version of
>> tcnative
>>
>> Any ideas for what to check? That ${exec_prefix} in there looks a
>> little fishy. Here's my configure command:
>>
>> ./configure --with-apr=/usr/bin
>> --with-ssl=/home/cschultz/openssl-1.0.2k/target/target
>
> That looks odd with 2 targets on the end.
You're right, it does.
I corrected that and it seems that was the problem. :(
That "configure" command was generated by my test-tomcat script. Hmm.
I'll have to see what's wrong, there.
Aha. A hardware migration + directory re-organization has simply
broken the path. Oddly, this causes the build to fail. Had it
fallen-back to the OS's default OpenSSL version (1.1.0j in my case), I
would have expected it to succeed.
Perhaps the fallback isn't working reliably?
>> --with-java-home=/usr/lib/jvm/java-8-openjdk-amd64
>
> I did a little testing with this.
>
> I agree the ${exec_prefix} looks odd but it doesn't appear to be
> breaking anything.
>
> When I provide a valid path to an OpenSSL build everything works
> as expected (1.0.2, 1.1.0, 1.1.1 and master).
>
> When I provide an invalid path to an OpenSSL build then it appears
> to pick up up the version of OpenSSL installed by the OS.
>
> I see two (minor) problems we could fix:
>
> 1. The ${exec_prefix} oddity
>
> 2. If an invalid OpenSSL path is specified the build should fail
> rather than pick up a system default.
>
> Given that everything appears to work as intended with valid input,
> I don't see any immediate need to roll a Tomcat Native release.
+1 - no release is necessary.
- -chris
-BEGIN PGP SIGNATURE-
Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/
iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlyvdkIACgkQHPApP6U8
pFiYohAAmO0ouLCMydseViHj2PxfP10mj7uvgB5tCM8FEcoluuB97Lrq1erCT/CY
EC5DHGuRdOBvIv+DSw4qkUOE0cCTUe90KZhoWPKJYQuM/Ins+fQwSy98aJMmXLHD
d3rvyZ4fGnF6twwg6Sf/eFstq1tzkqUIC0cPuVwytirqZDNCVdgTSLp0xUkEf8yp
wFY2AAjOGuW6fTLCs7ie85JrAF/eo9vjM40HRCTTpCL03gYvPi5mfYNbEtLUWJ4K
0qZOJGvbl8oxuAkG42ZzUZueA/pEtZDk6jfD1KDc8OOOkk77Yix/gVHdwSZpZR8l
F8ihXEAigUdRqEyFo0sQ0KyaRq27E5yrrMMURpN2iOYJl9pyhcpowIEF7NMwMVYM
tfH01qg/D/2AQYnpYnO9o7ou1rsyyXWVViJu6xIkZwC7eHuWkfGjQHGrfcYkc95o
erTZ/VTkBE95zLNJHfkrMb3NQ7vX1h0E8hfBAIJNnhMrVRPbfsdGDjU+KST6qoid
MXuQnvIefp2CQCtqPVSUVxC9irXdDWeR/IIDNThguVOu69SrEkK7BGQyHGEpPQvV
7ieuWQ4PVyQw85QUdzkbIhAtswl75b118e/NUtBiijUCGtX/tgLpaSgME+TeENny
E3v0GaU1aLD9l9mwCQqWz5BEFHAymxC0XxqzPhsiSnLB21xA/hs=
=6Wkm
-END PGP SIGNATURE-
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.40
On 11/04/2019 15:21, Christopher Schultz wrote:
> I'm having a bit of trouble building the bundled tcnative. I'm tried
> building against OpenSSL 1.0.2k and 1.1.1 and both of the "configure"
> invocations given me a message similar to the following:
>
> checking for OpenSSL library... using openssl from
> /home/cschultz/openssl-1.0.2k/target/target/${exec_prefix}/lib and
> /home/cschultz/openssl-1.0.2k/target/target/include
> checking OpenSSL library version >= 1.0.2... configure: error: Your
> version of OpenSSL is not compatible with this version of tcnative
>
> Any ideas for what to check? That ${exec_prefix} in there looks a little
> fishy. Here's my configure command:
>
> ./configure --with-apr=/usr/bin
> --with-ssl=/home/cschultz/openssl-1.0.2k/target/target
That looks odd with 2 targets on the end.
> --with-java-home=/usr/lib/jvm/java-8-openjdk-amd64
I did a little testing with this.
I agree the ${exec_prefix} looks odd but it doesn't appear to be
breaking anything.
When I provide a valid path to an OpenSSL build everything works as
expected (1.0.2, 1.1.0, 1.1.1 and master).
When I provide an invalid path to an OpenSSL build then it appears to
pick up up the version of OpenSSL installed by the OS.
I see two (minor) problems we could fix:
1. The ${exec_prefix} oddity
2. If an invalid OpenSSL path is specified the build should fail rather
than pick up a system default.
Given that everything appears to work as intended with valid input, I
don't see any immediate need to roll a Tomcat Native release.
Thoughts?
Mark
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 9.0.18
On 11/04/2019 16:20, Mark Thomas wrote: > On 11/04/2019 16:14, Rémy Maucherat wrote: >> On Thu, Apr 11, 2019 at 4:15 PM Mark Thomas wrote: >> >>> Anything else? >>> >> >> Fix the gitbox <-> github sync. > > Fair point. > > I'll see what I can do. It should be fixed now. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 9.0.18
чт, 11 апр. 2019 г. в 17:15, Mark Thomas : > > What other things do we need to take care of before the 9.0.19 tag? > I just ran org.apache.catalina.core.TestSwallowAbortedUploads test (the one failing with Java 7) with Tomcat 9 + Java 8 1. The test ran successfully with Tomcat 9 + Java 8u202 (64-bit) + All connectors. On Windows 10. 2. I see the following strange error in TEST-org.apache.catalina.core.TestSwallowAbortedUploads.NIO.txt 11-Apr-2019 18:44:22.065 SEVERE [http-nio-127.0.0.1-auto-3-exec-10] org.apache.coyote.http11.Http11Processor.endRequest Error finishing request java.nio.InvalidMarkException at java.nio.Buffer.reset(Buffer.java:306) at org.apache.coyote.http11.Http11InputBuffer.fill(Http11InputBuffer.java:732) at org.apache.coyote.http11.Http11InputBuffer.access$300(Http11InputBuffer.java:40) at org.apache.coyote.http11.Http11InputBuffer$SocketInputBuffer.doRead(Http11InputBuffer.java:1063) at org.apache.coyote.http11.filters.ChunkedInputFilter.readBytes(ChunkedInputFilter.java:301) at org.apache.coyote.http11.filters.ChunkedInputFilter.doRead(ChunkedInputFilter.java:176) at org.apache.coyote.http11.filters.ChunkedInputFilter.end(ChunkedInputFilter.java:229) at org.apache.coyote.http11.Http11InputBuffer.endRequest(Http11InputBuffer.java:599) at org.apache.coyote.http11.Http11Processor.endRequest(Http11Processor.java:1098) at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:448) at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66) at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:836) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1415) at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61) at java.lang.Thread.run(Thread.java:748) in TEST-org.apache.catalina.core.TestSwallowAbortedUploads.NIO.txt. The test case was [testChunkedPUTNoLimit] It is odd. https://docs.oracle.com/javase/7/docs/api/java/nio/InvalidMarkException.html There is a "byteBuffer.mark()" call at Http11InputBuffer.java:726, several lines above the reset() call that fails. This does not cause a test case failure. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch master updated: Switch async IO API default to false
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new ebf1518 Switch async IO API default to false
ebf1518 is described below
commit ebf1518cdd6365811525428ecf5c4b6b6737ba92
Author: remm
AuthorDate: Thu Apr 11 16:05:42 2019 +0200
Switch async IO API default to false
---
java/org/apache/tomcat/util/net/AbstractEndpoint.java | 2 +-
webapps/docs/changelog.xml| 2 +-
webapps/docs/config/http.xml | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/java/org/apache/tomcat/util/net/AbstractEndpoint.java
b/java/org/apache/tomcat/util/net/AbstractEndpoint.java
index 682012c..155cabe 100644
--- a/java/org/apache/tomcat/util/net/AbstractEndpoint.java
+++ b/java/org/apache/tomcat/util/net/AbstractEndpoint.java
@@ -744,7 +744,7 @@ public abstract class AbstractEndpoint {
/**
* Expose async IO capability.
*/
-private boolean useAsyncIO = true;
+private boolean useAsyncIO = false;
public void setUseAsyncIO(boolean useAsyncIO) { this.useAsyncIO =
useAsyncIO; }
public boolean getUseAsyncIO() { return useAsyncIO; }
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index ed2855b..96bd8e3 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -61,7 +61,7 @@
Add asynchronous IO from NIO2 to the NIO connector, with support for
the async IO implementations for HTTP/2 and Websockets. The
useAsyncIO boolean attribute on the Connector element
-allows disabling usage of the asynchronous IO API. (remm)
+allows enabling use of the asynchronous IO API. (remm)
diff --git a/webapps/docs/config/http.xml b/webapps/docs/config/http.xml
index 9e68e39..fe8ba89 100644
--- a/webapps/docs/config/http.xml
+++ b/webapps/docs/config/http.xml
@@ -762,7 +762,7 @@
(bool)Use this attribute to enable or disable usage of the
-asynchronous IO API. The default value is true.
+asynchronous IO API. The default value is false.
@@ -906,7 +906,7 @@
(bool)Use this attribute to enable or disable usage of the
-asynchronous IO API. The default value is true.
+asynchronous IO API. The default value is false.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tomcat] branch master updated (ebf1518 -> 4bc60ea)
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git. from ebf1518 Switch async IO API default to false new 72952ec Remove trailing whitespace new 4bc60ea Correct missing / wrong format files in source distribution The 20720 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: build.xml | 7 ++- java/org/apache/tomcat/util/json/JSONParser.jj | 14 +++--- res/tomcat-maven/tomcat.yaml | 4 ++-- webapps/docs/changelog.xml | 13 + 4 files changed, 28 insertions(+), 10 deletions(-) - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 7.0.94
ср, 10 апр. 2019 г. в 20:22, Mark Thomas : > > The proposed Apache Tomcat 7.0.94 release is now available for voting. > The following test is failing for me: TEST-org.apache.catalina.core.TestSwallowAbortedUploads.BIO.txt TEST-org.apache.catalina.core.TestSwallowAbortedUploads.NIO.txt Details are below. All other tests are OK, with several known failures with Java 6 (thus far I run the whole testsuite with Java 6 and Java 7). I tested on Windows 10, using Java 6 (6u45 32-bit), 7 (7u80 32-bit), 8 (8u202 64-bit), Testing with APR connector shows no failures, the test succeeds. I enabled debug logging in the test by setting org.apache.catalina.core.TestSwallowAbortedUploads.level = FINE 1) The following test case method fais with NIO and BIO. Testcase: testAbortedUploadLimitedNoSwallow took 0,499 sec FAILED Limited upload with swallow disabled does not generate client exception junit.framework.AssertionFailedError: Limited upload with swallow disabled does not generate client exception at org.apache.catalina.core.TestSwallowAbortedUploads.testAbortedUploadLimitedNoSwallow(TestSwallowAbortedUploads.java:129) Debug logging: апр 11, 2019 5:22:28 PM org.apache.catalina.core.TestSwallowAbortedUploads$AbortedUploadServlet doPost FINE: IllegalStateException during getParts() апр 11, 2019 5:22:28 PM org.apache.catalina.core.TestSwallowAbortedUploads doAbortedUploadTest FINE: Response line: HTTP/1.1 500 Internal Server Error апр 11, 2019 5:22:28 PM org.apache.catalina.core.TestSwallowAbortedUploads doAbortedUploadTest FINE: Response headers: [Server: Apache-Coyote/1.1, Content-Type: text/plain;charset=ISO-8859-1, Transfer-Encoding: chunked, Date: Thu, 11 Apr 2019 14:22:28 GMT, Connection: close] апр 11, 2019 5:22:28 PM org.apache.catalina.core.TestSwallowAbortedUploads doAbortedUploadTest FINE: Response body: 28IllegalStateException during getParts()0 2) The following test case fails with NIO and Java 7, Java 8. For some reason it runs successfully with Java 6. Testcase: testAbortedPOST413NoSwallow took 0,431 sec FAILED Limited upload with swallow disabled does not generate client exception junit.framework.AssertionFailedError: Limited upload with swallow disabled does not generate client exception at org.apache.catalina.core.TestSwallowAbortedUploads.testAbortedPOST413NoSwallow(TestSwallowAbortedUploads.java:175) Debug logging: апр 11, 2019 5:22:44 PM org.apache.catalina.core.TestSwallowAbortedUploads doAbortedPOSTTest FINE: Response line: HTTP/1.1 413 Request Entity Too Large апр 11, 2019 5:22:44 PM org.apache.catalina.core.TestSwallowAbortedUploads doAbortedPOSTTest FINE: Response headers: [Server: Apache-Coyote/1.1, Content-Type: text/plain;charset=UTF-8, Transfer-Encoding: chunked, Date: Thu, 11 Apr 2019 14:22:43 GMT, Connection: close] апр 11, 2019 5:22:44 PM org.apache.catalina.core.TestSwallowAbortedUploads doAbortedPOSTTest FINE: Response body: 2OK0 3) The following message was logged once: апр 11, 2019 5:22:34 PM org.apache.catalina.core.TestSwallowAbortedUploads$AbortedUploadServlet doPost SEVERE: Exception during getParts() java.io.IOException: The temporary upload location [*SKIPPED*\apache-tomcat-7.0.94-src\output\test-tmp\work\Tomcat\localhost\_] is not valid at org.apache.catalina.connector.Request.parseParts(Request.java:2888) at org.apache.catalina.connector.Request.getParts(Request.java:2820) at org.apache.catalina.connector.RequestFacade.getParts(RequestFacade.java:1075) at org.apache.catalina.core.TestSwallowAbortedUploads$AbortedUploadServlet.doPost(TestSwallowAbortedUploads.java:193) at javax.servlet.http.HttpServlet.service(HttpServlet.java:650) at javax.servlet.http.HttpServlet.service(HttpServlet.java:731) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:303) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:219) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:110) at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:494) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:169) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:104) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:116) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:445) at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1137) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:637) at org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:317) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at
Re: [VOTE] Release Apache Tomcat 9.0.18
On 11/04/2019 16:14, Rémy Maucherat wrote: > On Thu, Apr 11, 2019 at 4:15 PM Mark Thomas wrote: > >> Anything else? >> > > Fix the gitbox <-> github sync. Fair point. I'll see what I can do. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 9.0.18
On 11/04/2019 15:22, Rainer Jung wrote: > Am 11.04.2019 um 16:15 schrieb Mark Thomas: >> On 11/04/2019 15:11, Rémy Maucherat wrote: >> >>> I already made the fix but the commit emails is stuck. >>> https://github.com/apache/tomcat/commit/4c6c3e9f434ca1a5cecf04f1b9148fb221b3af37 >>> >> >> Great. Thanks. >> >> What other things do we need to take care of before the 9.0.19 tag? >> >> JSONParser.jj vs JSONParser.jjt .jj is the correct line-ending. I've modified the build script to ensure it is included in the source bundle with the correct line endings. > - file only in git but not in src distribution: > res/ide-support/idea/tomcat.iml That file appears in the src distro when I built it on my dev machine. I've modified the build script to set the correct line endings. > - files res/tomcat-maven/Dockerfile and res/tomcat-maven/tomcat.yaml > have DOS line ends in Unix src tar.gz. I've modified the build script to set the correct line endings. I think we are ready for 9.0.19. Any objections? I'm planning to tag etc in an hour or two. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 9.0.18
On Thu, Apr 11, 2019 at 4:15 PM Mark Thomas wrote: > Anything else? > Fix the gitbox <-> github sync. Rémy > > Mark > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
Re: [VOTE] Release Apache Tomcat 9.0.18
On Thu, Apr 11, 2019 at 4:15 PM Mark Thomas wrote: > On 11/04/2019 15:11, Rémy Maucherat wrote: > > > I already made the fix but the commit emails is stuck. > > > https://github.com/apache/tomcat/commit/4c6c3e9f434ca1a5cecf04f1b9148fb221b3af37 > > Great. Thanks. > > What other things do we need to take care of before the 9.0.19 tag? > > JSONParser.jj vs JSONParser.jjt > > Flip the useAsyncIO default > Done already as well. Again, my apologies. The TestRegistration JMX test only checks object names, so that's how this fell though the crack ... I'll improve it later to check at least one known attribute. Beyond that, the rest is cosmetic non regressions, we can make the list arbitrarily long but IMO now is not the right time for that. Rémy > > Anything else? > > Mark > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
Re: [VOTE] Release Apache Tomcat 9.0.18
Am 11.04.2019 um 16:15 schrieb Mark Thomas: On 11/04/2019 15:11, Rémy Maucherat wrote: I already made the fix but the commit emails is stuck. https://github.com/apache/tomcat/commit/4c6c3e9f434ca1a5cecf04f1b9148fb221b3af37 Great. Thanks. What other things do we need to take care of before the 9.0.19 tag? JSONParser.jj vs JSONParser.jjt Flip the useAsyncIO default Anything else? I also saw the following minor points: - file only in git but not in src distribution: res/ide-support/idea/tomcat.iml - files res/tomcat-maven/Dockerfile and res/tomcat-maven/tomcat.yaml have DOS line ends in Unix src tar.gz. Regards, Rainer - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.40
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
All,
Gah. I replied to Mark only yesterday. :(
On 4/10/19 10:58, Mark Thomas wrote:
> The proposed Apache Tomcat 8.5.40 release is now available for
> voting.
>
> The major changes compared to the 8.5.39 release are:
>
> - Fix for CVE-2019-0232 a RCE vulnerability on Windows
>
> - Add support for Java 11 to the JSP compiler. Java 12 and 13 are
> also now supported if used with a ECJ version with support for
> those Java versions
>
> - Various NIO2 stability improvements
>
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat85/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.40/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-120
8/
>
> The tag is: https://github.com/apache/tomcat/tree/8.5.40
> 5ec070352b283535946327b44228b610a27a76c5
>
>
> The proposed 8.5.40 release is: [ ] Broken - do not release [ ]
> Stable - go ahead and release as 8.5.40
I'm having a bit of trouble building the bundled tcnative. I'm tried
building against OpenSSL 1.0.2k and 1.1.1 and both of the "configure"
invocations given me a message similar to the following:
checking for OpenSSL library... using openssl from
/home/cschultz/openssl-1.0.2k/target/target/${exec_prefix}/lib and
/home/cschultz/openssl-1.0.2k/target/target/include
checking OpenSSL library version >= 1.0.2... configure: error: Your
version of OpenSSL is not compatible with this version of tcnative
Any ideas for what to check? That ${exec_prefix} in there looks a little
fishy. Here's my configure command:
./configure --with-apr=/usr/bin
- --with-ssl=/home/cschultz/openssl-1.0.2k/target/target
- --with-java-home=/usr/lib/jvm/java-8-openjdk-amd64
- -chris
-BEGIN PGP SIGNATURE-
Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/
iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlyvTXEACgkQHPApP6U8
pFjhjhAAtwtSAb3LDFBOH+1QalBOdgoMR9ewqqGsQWSTKcvO1agdtzDeIuqOqBN8
vEkJqHLGeuIECNGYShtobU0mPPgyuYL36BTBZgGaziBgEPqbqzxFU7P4zCc8BN8J
W7pWbX9Pz8h+OYeegxiwzX+Rvb/57gpBgiD8haerhvuf6xpkzpVBiyLkGtmFqSD7
lxzomgZ3yFwFaYD7nAeuwjPB/NK37VGkzBPxMPaqZ2ftd1B9ziEMjqzs34kFsOAE
/+rAuQi9THnJqgG07OjUH5qI4YmFYzHNmbQyGFHXt4dYDE9juhNsfQLHBuaijqDb
ZAMNk6sHllm55QOIADxUsBEa8AAm5LvGF4PGcPzcL9jJ57qRYm7hqSHpyz7D7v5Z
bvjoA5kwPzKRH7PGDSTBME07eog5lCRil00ZCpp+dWzRtnu/FJdjQLKQfGVsf9i0
oIdJY7hHGnUEyVZsOdKc0EecSgf0KvmtcOnhL5MIuif5U8KHkiZuwuXJeEq2S4cP
IXoRPEOjARyP4BLFxgfWL/dNLgoi2wFf500zkcoW5PjtJOq9rfx3YsfbO9W+aU+k
2vAbEw83dv9LJxxK/Dv+00JLqIVIYxLmgp49LpqICva2Pk1SuRzbL2UQJt1fA6mn
/QTyKGH4hn5B2XGeiyYKdE867RqASaSo6z7sc4REcoIp1PnxCpY=
=77BG
-END PGP SIGNATURE-
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 9.0.18
On 11/04/2019 15:11, Rémy Maucherat wrote: > I already made the fix but the commit emails is stuck. > https://github.com/apache/tomcat/commit/4c6c3e9f434ca1a5cecf04f1b9148fb221b3af37 Great. Thanks. What other things do we need to take care of before the 9.0.19 tag? JSONParser.jj vs JSONParser.jjt Flip the useAsyncIO default Anything else? Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 9.0.18
On Thu, Apr 11, 2019 at 4:08 PM Mark Thomas wrote: > On 11/04/2019 14:52, Mark Thomas wrote: > > On 11/04/2019 14:31, Rainer Jung wrote: > >> Am 11.04.2019 um 14:51 schrieb Rémy Maucherat: > >>> On Thu, Apr 11, 2019 at 2:00 PM Rainer Jung > >>> wrote: > >>> > Am 10.04.2019 um 15:44 schrieb Mark Thomas: > > The proposed Apache Tomcat 9.0.18 release is now available for > voting. > > > > The major changes compared to the 9.0.17 release are: > > > > - Fix for CVE-2019-0232 a RCE vulnerability on Windows > > > > - Add support for Java 11 to the JSP compiler. Java 12 and 13 are > also > > now supported if used with a ECJ version with support for those > > Java > > versions > > > > - Various NIO2 stability improvements > > > > Along with lots of other bug fixes and improvements. > > > > For full details, see the changelog: > > https://ci.apache.org/projects/tomcat/tomcat9/docs/changelog.html > > > > It can be obtained from: > > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.18/ > > The Maven staging repo is: > > > https://repository.apache.org/content/repositories/orgapachetomcat-1207/ > > > > The tag is: > > https://github.com/apache/tomcat/tree/9.0.18 > > 0862607e5da91a7c476a6350288d8d8a9380f556 > > > > The proposed 9.0.18 release is: > > [ ] Broken - do not release > > [ ] Stable - go ahead and release as 9.0.18 > > > > > > Due to the security fix contained in this release, the voting period > > may > > be shortened once sufficient votes are cast to enable a faster > release. > > The MBeans for beans with j2eeType seem to be not filled with data. I > have not checked since 9.0.12, so I don't know when that heppaned. > Just > wantd to give a heads up before investigating more. > > Example diff for one bean: > > Name: > > > Catalina:j2eeType=Servlet,WebModule=//localhost/,name=default,J2EEApplication=none,J2EEServer=none > > -modelerType: org.apache.catalina.mbeans.ContainerMBean > -maxTime: 0 > -requestCount: 0 > -servletClass: org.apache.catalina.servlets.DefaultServlet > -countAllocated: 0 > -available: 0 > -backgroundProcessorDelay: -1 > -processingTime: XXX > -loadOnStartup: 1 > -singleThreadModel: false > -loadTime: XXX > -stateName: STARTED > -minTime: XXX > -classLoadTime: XXX > -asyncSupported: false > -objectName: > > > Catalina:j2eeType=Servlet,WebModule=//localhost/,name=default,J2EEApplication=none,J2EEServer=none > > -maxInstances: 20 > -errorCount: 0 > +modelerType: org.apache.tomcat.util.modeler.BaseModelMBean > +empty: false > > The modelerType has changed, all attributes missing. > > >>> > >>> The good news is that 8.5 seems fine. > >>> > >>> I'll investigate. If we need to do a new release (IMO: yes), I'll flip > >>> the > >>> useAsyncIO default value ... > >> > >> I did some more checks: > >> > >> - as you said, 8.5.40 is fine > >> > >> - using the same scripts, 9.0.17 is also fine, so this looks like a real > >> code regression > >> > >> Thus I would also be -1 for the 9.0.18 release. > > > https://github.com/apache/tomcat/commit/8cbe4ba594dc41615faafb216fcb4ff3e0d8fafc > > seems to be the trigger. I haven't reviewed the commit yet. > Yes, sorry :( I already made the fix but the commit emails is stuck. https://github.com/apache/tomcat/commit/4c6c3e9f434ca1a5cecf04f1b9148fb221b3af37 Rémy
[Bug 63306] Memory leak during websocket connection close
https://bz.apache.org/bugzilla/show_bug.cgi?id=63306 --- Comment #5 from Shailesh <05.shail...@gmail.com> --- Hi Mark, Thanks for your inputs. At present we only know that end users are from different subnets of network and uses wired and wireless network. We could not find the pattern in the application logs or heap dump. We got multiple heap dumps and memory is increasing at the rate of around 160 MB per day, in the same HashMap. We will try to upgrade to tomcat 8.5 and update you. Thank you. Regards, Shailesh -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 9.0.18
On 11/04/2019 14:52, Mark Thomas wrote: > On 11/04/2019 14:31, Rainer Jung wrote: >> Am 11.04.2019 um 14:51 schrieb Rémy Maucherat: >>> On Thu, Apr 11, 2019 at 2:00 PM Rainer Jung >>> wrote: >>> Am 10.04.2019 um 15:44 schrieb Mark Thomas: > The proposed Apache Tomcat 9.0.18 release is now available for voting. > > The major changes compared to the 9.0.17 release are: > > - Fix for CVE-2019-0232 a RCE vulnerability on Windows > > - Add support for Java 11 to the JSP compiler. Java 12 and 13 are also > now supported if used with a ECJ version with support for those > Java > versions > > - Various NIO2 stability improvements > > Along with lots of other bug fixes and improvements. > > For full details, see the changelog: > https://ci.apache.org/projects/tomcat/tomcat9/docs/changelog.html > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.18/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1207/ > > The tag is: > https://github.com/apache/tomcat/tree/9.0.18 > 0862607e5da91a7c476a6350288d8d8a9380f556 > > The proposed 9.0.18 release is: > [ ] Broken - do not release > [ ] Stable - go ahead and release as 9.0.18 > > > Due to the security fix contained in this release, the voting period > may > be shortened once sufficient votes are cast to enable a faster release. The MBeans for beans with j2eeType seem to be not filled with data. I have not checked since 9.0.12, so I don't know when that heppaned. Just wantd to give a heads up before investigating more. Example diff for one bean: Name: Catalina:j2eeType=Servlet,WebModule=//localhost/,name=default,J2EEApplication=none,J2EEServer=none -modelerType: org.apache.catalina.mbeans.ContainerMBean -maxTime: 0 -requestCount: 0 -servletClass: org.apache.catalina.servlets.DefaultServlet -countAllocated: 0 -available: 0 -backgroundProcessorDelay: -1 -processingTime: XXX -loadOnStartup: 1 -singleThreadModel: false -loadTime: XXX -stateName: STARTED -minTime: XXX -classLoadTime: XXX -asyncSupported: false -objectName: Catalina:j2eeType=Servlet,WebModule=//localhost/,name=default,J2EEApplication=none,J2EEServer=none -maxInstances: 20 -errorCount: 0 +modelerType: org.apache.tomcat.util.modeler.BaseModelMBean +empty: false The modelerType has changed, all attributes missing. >>> >>> The good news is that 8.5 seems fine. >>> >>> I'll investigate. If we need to do a new release (IMO: yes), I'll flip >>> the >>> useAsyncIO default value ... >> >> I did some more checks: >> >> - as you said, 8.5.40 is fine >> >> - using the same scripts, 9.0.17 is also fine, so this looks like a real >> code regression >> >> Thus I would also be -1 for the 9.0.18 release. https://github.com/apache/tomcat/commit/8cbe4ba594dc41615faafb216fcb4ff3e0d8fafc seems to be the trigger. I haven't reviewed the commit yet. Mark Another minor observation: file java/org/apache/tomcat/util/json/JSONParser.jj is in git but missing from the src distribution. >> >> There is an explicit .jj exclusion in build.xml. But that exclusion is >> older than the jj file, so I'm not sure whether it should get bundloed >> or not. At least the release build process does not generate it, so it >> seems we should better bundle it. > > That file looks like a jjt file rather than a jj file. Maybe a rename is > required? > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 9.0.18
On 11/04/2019 14:31, Rainer Jung wrote: > Am 11.04.2019 um 14:51 schrieb Rémy Maucherat: >> On Thu, Apr 11, 2019 at 2:00 PM Rainer Jung >> wrote: >> >>> Am 10.04.2019 um 15:44 schrieb Mark Thomas: The proposed Apache Tomcat 9.0.18 release is now available for voting. The major changes compared to the 9.0.17 release are: - Fix for CVE-2019-0232 a RCE vulnerability on Windows - Add support for Java 11 to the JSP compiler. Java 12 and 13 are also now supported if used with a ECJ version with support for those Java versions - Various NIO2 stability improvements Along with lots of other bug fixes and improvements. For full details, see the changelog: https://ci.apache.org/projects/tomcat/tomcat9/docs/changelog.html It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.18/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1207/ The tag is: https://github.com/apache/tomcat/tree/9.0.18 0862607e5da91a7c476a6350288d8d8a9380f556 The proposed 9.0.18 release is: [ ] Broken - do not release [ ] Stable - go ahead and release as 9.0.18 Due to the security fix contained in this release, the voting period may be shortened once sufficient votes are cast to enable a faster release. >>> >>> The MBeans for beans with j2eeType seem to be not filled with data. I >>> have not checked since 9.0.12, so I don't know when that heppaned. Just >>> wantd to give a heads up before investigating more. >>> >>> Example diff for one bean: >>> >>> Name: >>> >>> Catalina:j2eeType=Servlet,WebModule=//localhost/,name=default,J2EEApplication=none,J2EEServer=none >>> >>> -modelerType: org.apache.catalina.mbeans.ContainerMBean >>> -maxTime: 0 >>> -requestCount: 0 >>> -servletClass: org.apache.catalina.servlets.DefaultServlet >>> -countAllocated: 0 >>> -available: 0 >>> -backgroundProcessorDelay: -1 >>> -processingTime: XXX >>> -loadOnStartup: 1 >>> -singleThreadModel: false >>> -loadTime: XXX >>> -stateName: STARTED >>> -minTime: XXX >>> -classLoadTime: XXX >>> -asyncSupported: false >>> -objectName: >>> >>> Catalina:j2eeType=Servlet,WebModule=//localhost/,name=default,J2EEApplication=none,J2EEServer=none >>> >>> -maxInstances: 20 >>> -errorCount: 0 >>> +modelerType: org.apache.tomcat.util.modeler.BaseModelMBean >>> +empty: false >>> >>> The modelerType has changed, all attributes missing. >>> >> >> The good news is that 8.5 seems fine. >> >> I'll investigate. If we need to do a new release (IMO: yes), I'll flip >> the >> useAsyncIO default value ... > > I did some more checks: > > - as you said, 8.5.40 is fine > > - using the same scripts, 9.0.17 is also fine, so this looks like a real > code regression > > Thus I would also be -1 for the 9.0.18 release. > >>> Another minor observation: file >>> java/org/apache/tomcat/util/json/JSONParser.jj is in git but missing >>> from the src distribution. > > There is an explicit .jj exclusion in build.xml. But that exclusion is > older than the jj file, so I'm not sure whether it should get bundloed > or not. At least the release build process does not generate it, so it > seems we should better bundle it. That file looks like a jjt file rather than a jj file. Maybe a rename is required? - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 9.0.18
On Thu, Apr 11, 2019 at 3:38 PM Mark Thomas wrote: > On 11/04/2019 12:59, Rainer Jung wrote: > > > > >> Due to the security fix contained in this release, the voting period may > >> be shortened once sufficient votes are cast to enable a faster release. > > > > The MBeans for beans with j2eeType seem to be not filled with data. I > > have not checked since 9.0.12, so I don't know when that happened. Just > > wanted to give a heads up before investigating more. > > It works correctly in 9.0.17 so this appears to be a regression between > 9.0.17 and 9.0.18. > > Nothing jumps out at me in the changelog. I'm starting the binary search > to find the commit where this started. > I have no idea what's going on, the attribute infos seem to be generated correctly, and the only modeler commits is the intern add. Rémy
Re: [VOTE] Release Apache Tomcat 9.0.18
On 11/04/2019 12:59, Rainer Jung wrote: >> Due to the security fix contained in this release, the voting period may >> be shortened once sufficient votes are cast to enable a faster release. > > The MBeans for beans with j2eeType seem to be not filled with data. I > have not checked since 9.0.12, so I don't know when that happened. Just > wanted to give a heads up before investigating more. It works correctly in 9.0.17 so this appears to be a regression between 9.0.17 and 9.0.18. Nothing jumps out at me in the changelog. I'm starting the binary search to find the commit where this started. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 9.0.18
Am 11.04.2019 um 14:51 schrieb Rémy Maucherat: On Thu, Apr 11, 2019 at 2:00 PM Rainer Jung wrote: Am 10.04.2019 um 15:44 schrieb Mark Thomas: The proposed Apache Tomcat 9.0.18 release is now available for voting. The major changes compared to the 9.0.17 release are: - Fix for CVE-2019-0232 a RCE vulnerability on Windows - Add support for Java 11 to the JSP compiler. Java 12 and 13 are also now supported if used with a ECJ version with support for those Java versions - Various NIO2 stability improvements Along with lots of other bug fixes and improvements. For full details, see the changelog: https://ci.apache.org/projects/tomcat/tomcat9/docs/changelog.html It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.18/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1207/ The tag is: https://github.com/apache/tomcat/tree/9.0.18 0862607e5da91a7c476a6350288d8d8a9380f556 The proposed 9.0.18 release is: [ ] Broken - do not release [ ] Stable - go ahead and release as 9.0.18 Due to the security fix contained in this release, the voting period may be shortened once sufficient votes are cast to enable a faster release. The MBeans for beans with j2eeType seem to be not filled with data. I have not checked since 9.0.12, so I don't know when that heppaned. Just wantd to give a heads up before investigating more. Example diff for one bean: Name: Catalina:j2eeType=Servlet,WebModule=//localhost/,name=default,J2EEApplication=none,J2EEServer=none -modelerType: org.apache.catalina.mbeans.ContainerMBean -maxTime: 0 -requestCount: 0 -servletClass: org.apache.catalina.servlets.DefaultServlet -countAllocated: 0 -available: 0 -backgroundProcessorDelay: -1 -processingTime: XXX -loadOnStartup: 1 -singleThreadModel: false -loadTime: XXX -stateName: STARTED -minTime: XXX -classLoadTime: XXX -asyncSupported: false -objectName: Catalina:j2eeType=Servlet,WebModule=//localhost/,name=default,J2EEApplication=none,J2EEServer=none -maxInstances: 20 -errorCount: 0 +modelerType: org.apache.tomcat.util.modeler.BaseModelMBean +empty: false The modelerType has changed, all attributes missing. The good news is that 8.5 seems fine. I'll investigate. If we need to do a new release (IMO: yes), I'll flip the useAsyncIO default value ... I did some more checks: - as you said, 8.5.40 is fine - using the same scripts, 9.0.17 is also fine, so this looks like a real code regression Thus I would also be -1 for the 9.0.18 release. Another minor observation: file java/org/apache/tomcat/util/json/JSONParser.jj is in git but missing from the src distribution. There is an explicit .jj exclusion in build.xml. But that exclusion is older than the jj file, so I'm not sure whether it should get bundloed or not. At least the release build process does not generate it, so it seems we should better bundle it. Regards, Rainer - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 9.0.18
On Wed, Apr 10, 2019 at 9:44 AM Mark Thomas wrote: > The proposed Apache Tomcat 9.0.18 release is now available for voting. > > The major changes compared to the 9.0.17 release are: > > - Fix for CVE-2019-0232 a RCE vulnerability on Windows > > - Add support for Java 11 to the JSP compiler. Java 12 and 13 are also > now supported if used with a ECJ version with support for those Java > versions > > - Various NIO2 stability improvements > > Along with lots of other bug fixes and improvements. > > For full details, see the changelog: > https://ci.apache.org/projects/tomcat/tomcat9/docs/changelog.html > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.18/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1207/ > The tag is: > https://github.com/apache/tomcat/tree/9.0.18 > 0862607e5da91a7c476a6350288d8d8a9380f556 > > The proposed 9.0.18 release is: > [ ] Broken - do not release > [x] Stable - go ahead and release as 9.0.18 > +1 > > > Due to the security fix contained in this release, the voting period may > be shortened once sufficient votes are cast to enable a faster release. > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
Re: [VOTE] Release Apache Tomcat 8.5.40
On Wed, Apr 10, 2019 at 10:58 AM Mark Thomas wrote: > The proposed Apache Tomcat 8.5.40 release is now available for voting. > > The major changes compared to the 8.5.39 release are: > > - Fix for CVE-2019-0232 a RCE vulnerability on Windows > > - Add support for Java 11 to the JSP compiler. Java 12 and 13 are also > now supported if used with a ECJ version with support for those Java > versions > > - Various NIO2 stability improvements > > > Along with lots of other bug fixes and improvements. > > For full details, see the changelog: > https://ci.apache.org/projects/tomcat/tomcat85/docs/changelog.html > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.40/ > > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1208/ > > The tag is: > https://github.com/apache/tomcat/tree/8.5.40 > 5ec070352b283535946327b44228b610a27a76c5 > > > The proposed 8.5.40 release is: > [ ] Broken - do not release > [x] Stable - go ahead and release as 8.5.40 > +1 > > > Due to the security fix contained in this release, the voting period may > be shortened once sufficient votes are cast to enable a faster release. > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
Re: [VOTE] Release Apache Tomcat 9.0.18
On Thu, Apr 11, 2019 at 2:00 PM Rainer Jung wrote: > Am 10.04.2019 um 15:44 schrieb Mark Thomas: > > The proposed Apache Tomcat 9.0.18 release is now available for voting. > > > > The major changes compared to the 9.0.17 release are: > > > > - Fix for CVE-2019-0232 a RCE vulnerability on Windows > > > > - Add support for Java 11 to the JSP compiler. Java 12 and 13 are also > >now supported if used with a ECJ version with support for those Java > >versions > > > > - Various NIO2 stability improvements > > > > Along with lots of other bug fixes and improvements. > > > > For full details, see the changelog: > > https://ci.apache.org/projects/tomcat/tomcat9/docs/changelog.html > > > > It can be obtained from: > > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.18/ > > The Maven staging repo is: > > https://repository.apache.org/content/repositories/orgapachetomcat-1207/ > > The tag is: > > https://github.com/apache/tomcat/tree/9.0.18 > > 0862607e5da91a7c476a6350288d8d8a9380f556 > > > > The proposed 9.0.18 release is: > > [ ] Broken - do not release > > [ ] Stable - go ahead and release as 9.0.18 > > > > > > Due to the security fix contained in this release, the voting period may > > be shortened once sufficient votes are cast to enable a faster release. > > The MBeans for beans with j2eeType seem to be not filled with data. I > have not checked since 9.0.12, so I don't know when that heppaned. Just > wantd to give a heads up before investigating more. > > Example diff for one bean: > > Name: > > Catalina:j2eeType=Servlet,WebModule=//localhost/,name=default,J2EEApplication=none,J2EEServer=none > -modelerType: org.apache.catalina.mbeans.ContainerMBean > -maxTime: 0 > -requestCount: 0 > -servletClass: org.apache.catalina.servlets.DefaultServlet > -countAllocated: 0 > -available: 0 > -backgroundProcessorDelay: -1 > -processingTime: XXX > -loadOnStartup: 1 > -singleThreadModel: false > -loadTime: XXX > -stateName: STARTED > -minTime: XXX > -classLoadTime: XXX > -asyncSupported: false > -objectName: > > Catalina:j2eeType=Servlet,WebModule=//localhost/,name=default,J2EEApplication=none,J2EEServer=none > -maxInstances: 20 > -errorCount: 0 > +modelerType: org.apache.tomcat.util.modeler.BaseModelMBean > +empty: false > > The modelerType has changed, all attributes missing. > The good news is that 8.5 seems fine. I'll investigate. If we need to do a new release (IMO: yes), I'll flip the useAsyncIO default value ... Rémy > > Another minor observation: file > java/org/apache/tomcat/util/json/JSONParser.jj is in git but missing > from the src distribution. > > Regards, > > Rainer > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
Re: [VOTE] Release Apache Tomcat 9.0.18
Am 10.04.2019 um 15:44 schrieb Mark Thomas: The proposed Apache Tomcat 9.0.18 release is now available for voting. The major changes compared to the 9.0.17 release are: - Fix for CVE-2019-0232 a RCE vulnerability on Windows - Add support for Java 11 to the JSP compiler. Java 12 and 13 are also now supported if used with a ECJ version with support for those Java versions - Various NIO2 stability improvements Along with lots of other bug fixes and improvements. For full details, see the changelog: https://ci.apache.org/projects/tomcat/tomcat9/docs/changelog.html It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.18/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1207/ The tag is: https://github.com/apache/tomcat/tree/9.0.18 0862607e5da91a7c476a6350288d8d8a9380f556 The proposed 9.0.18 release is: [ ] Broken - do not release [ ] Stable - go ahead and release as 9.0.18 Due to the security fix contained in this release, the voting period may be shortened once sufficient votes are cast to enable a faster release. The MBeans for beans with j2eeType seem to be not filled with data. I have not checked since 9.0.12, so I don't know when that heppaned. Just wantd to give a heads up before investigating more. Example diff for one bean: Name: Catalina:j2eeType=Servlet,WebModule=//localhost/,name=default,J2EEApplication=none,J2EEServer=none -modelerType: org.apache.catalina.mbeans.ContainerMBean -maxTime: 0 -requestCount: 0 -servletClass: org.apache.catalina.servlets.DefaultServlet -countAllocated: 0 -available: 0 -backgroundProcessorDelay: -1 -processingTime: XXX -loadOnStartup: 1 -singleThreadModel: false -loadTime: XXX -stateName: STARTED -minTime: XXX -classLoadTime: XXX -asyncSupported: false -objectName: Catalina:j2eeType=Servlet,WebModule=//localhost/,name=default,J2EEApplication=none,J2EEServer=none -maxInstances: 20 -errorCount: 0 +modelerType: org.apache.tomcat.util.modeler.BaseModelMBean +empty: false The modelerType has changed, all attributes missing. Another minor observation: file java/org/apache/tomcat/util/json/JSONParser.jj is in git but missing from the src distribution. Regards, Rainer - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Tagging 9.0.18
On 10/04/2019 22:31, Rainer Jung wrote: > Am 09.04.2019 um 19:45 schrieb Mark Thomas: >> Hi all, >> >> I'm a bit behind again this month - mainly because I was at the http >> workshop last week (very useful - a write-up is on the way). > > I'm very keen on reading your notes. On the httpd dev list Bill > mentioned three links to notes taken by Daniel Stenberg (curl etc.): Done: https://cwiki.apache.org/confluence/display/TOMCAT/http+workshop+2019 Feel free to ask questions if anything isn't clear. I added some of the TODOs to the hackathin ideas but there are more that couldbe used if needed. Mark > > https://daniel.haxx.se/blog/2019/04/02/the-http-workshop-2019-begins/ > > https://daniel.haxx.se/blog/2019/04/04/more-amsterdamned-workshop/ > > https://daniel.haxx.se/blog/2019/04/04/workshop-season-4-finale/ > > Regards, > > Rainer > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 7.0.94
On Wed, Apr 10, 2019 at 7:22 PM Mark Thomas wrote: > The proposed Apache Tomcat 7.0.94 release is now available for voting. > > The major changes compared to the 7.0.93 release are: > > - Fix for CVE-2019-0232 a RCE vulnerability on Windows > > - Add support for Java 11 to the JSP compiler. Java 12 and 13 are also > now supported if used with a ECJ version with support for those Java > versions > > - Update Tomcat's packaged-renamed copy of Apache Commons DBCP to the > latest DBCP 1.4.x and Pool 1.6.x source (as of 2019-03-15) to pick up > various bug fixes > > Along with lots of other bug fixes and improvements. > > > For full details, see the changelog: > https://ci.apache.org/projects/tomcat/tomcat7/docs/changelog.html > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.94/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1209/ > The tag is: > https://github.com/apache/tomcat/tree/7.0.94 > 9ddb14a0e76080feee34f3eca89e5413b93852f9 > > The proposed 7.0.94 release is: > [ ] Broken - do not release > [X] Stable - go ahead and release as 7.0.94 Stable > > Rémy
Re: [VOTE] Release Apache Tomcat 8.5.40
On Wed, Apr 10, 2019 at 4:58 PM Mark Thomas wrote: > The proposed 8.5.40 release is: > [ ] Broken - do not release > [X] Stable - go ahead and release as 8.5.40 > Rémy
Re: [VOTE] Release Apache Tomcat 7.0.94
На ср, 10.04.2019 г. в 20:22 ч. Mark Thomas написа: > > The proposed Apache Tomcat 7.0.94 release is now available for voting. > > The major changes compared to the 7.0.93 release are: > > - Fix for CVE-2019-0232 a RCE vulnerability on Windows > > - Add support for Java 11 to the JSP compiler. Java 12 and 13 are also > now supported if used with a ECJ version with support for those Java > versions > > - Update Tomcat's packaged-renamed copy of Apache Commons DBCP to the > latest DBCP 1.4.x and Pool 1.6.x source (as of 2019-03-15) to pick up > various bug fixes > > Along with lots of other bug fixes and improvements. > > > For full details, see the changelog: > https://ci.apache.org/projects/tomcat/tomcat7/docs/changelog.html > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.94/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1209/ > The tag is: > https://github.com/apache/tomcat/tree/7.0.94 > 9ddb14a0e76080feee34f3eca89e5413b93852f9 > > The proposed 7.0.94 release is: > [ ] Broken - do not release > [X] Stable - go ahead and release as 7.0.94 Stable Regards, Violeta > Mark > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 8.5.40
На ср, 10.04.2019 г. в 17:58 ч. Mark Thomas написа: > > The proposed Apache Tomcat 8.5.40 release is now available for voting. > > The major changes compared to the 8.5.39 release are: > > - Fix for CVE-2019-0232 a RCE vulnerability on Windows > > - Add support for Java 11 to the JSP compiler. Java 12 and 13 are also > now supported if used with a ECJ version with support for those Java > versions > > - Various NIO2 stability improvements > > > Along with lots of other bug fixes and improvements. > > For full details, see the changelog: > https://ci.apache.org/projects/tomcat/tomcat85/docs/changelog.html > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.40/ > > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1208/ > > The tag is: > https://github.com/apache/tomcat/tree/8.5.40 > 5ec070352b283535946327b44228b610a27a76c5 > > > The proposed 8.5.40 release is: > [ ] Broken - do not release > [X] Stable - go ahead and release as 8.5.40 Regards, Violeta > > Due to the security fix contained in this release, the voting period may > be shortened once sufficient votes are cast to enable a faster release. > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 9.0.18
На ср, 10.04.2019 г. в 16:44 ч. Mark Thomas написа: > > The proposed Apache Tomcat 9.0.18 release is now available for voting. > > The major changes compared to the 9.0.17 release are: > > - Fix for CVE-2019-0232 a RCE vulnerability on Windows > > - Add support for Java 11 to the JSP compiler. Java 12 and 13 are also > now supported if used with a ECJ version with support for those Java > versions > > - Various NIO2 stability improvements > > Along with lots of other bug fixes and improvements. > > For full details, see the changelog: > https://ci.apache.org/projects/tomcat/tomcat9/docs/changelog.html > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.18/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1207/ > The tag is: > https://github.com/apache/tomcat/tree/9.0.18 > 0862607e5da91a7c476a6350288d8d8a9380f556 > > The proposed 9.0.18 release is: > [ ] Broken - do not release > [X] Stable - go ahead and release as 9.0.18 Regards, Violeta > > Due to the security fix contained in this release, the voting period may > be shortened once sufficient votes are cast to enable a faster release. > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release Apache Tomcat 7.0.94
2019年4月11日(木) 2:22 Mark Thomas : > The proposed Apache Tomcat 7.0.94 release is now available for voting. > > The major changes compared to the 7.0.93 release are: > > - Fix for CVE-2019-0232 a RCE vulnerability on Windows > > - Add support for Java 11 to the JSP compiler. Java 12 and 13 are also > now supported if used with a ECJ version with support for those Java > versions > > - Update Tomcat's packaged-renamed copy of Apache Commons DBCP to the > latest DBCP 1.4.x and Pool 1.6.x source (as of 2019-03-15) to pick up > various bug fixes > > Along with lots of other bug fixes and improvements. > > > For full details, see the changelog: > https://ci.apache.org/projects/tomcat/tomcat7/docs/changelog.html > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.94/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1209/ > The tag is: > https://github.com/apache/tomcat/tree/7.0.94 > 9ddb14a0e76080feee34f3eca89e5413b93852f9 > > The proposed 7.0.94 release is: > [ ] Broken - do not release > [X] Stable - go ahead and release as 7.0.94 Stable > +1 Tested on simple hand-made app.(enable session replication). > Mark > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > > -- Keiichi.Fujino
Re: [VOTE] Release Apache Tomcat 8.5.40
2019年4月10日(水) 23:58 Mark Thomas : > The proposed Apache Tomcat 8.5.40 release is now available for voting. > > The major changes compared to the 8.5.39 release are: > > - Fix for CVE-2019-0232 a RCE vulnerability on Windows > > - Add support for Java 11 to the JSP compiler. Java 12 and 13 are also > now supported if used with a ECJ version with support for those Java > versions > > - Various NIO2 stability improvements > > > Along with lots of other bug fixes and improvements. > > For full details, see the changelog: > https://ci.apache.org/projects/tomcat/tomcat85/docs/changelog.html > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.40/ > > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1208/ > > The tag is: > https://github.com/apache/tomcat/tree/8.5.40 > 5ec070352b283535946327b44228b610a27a76c5 > > > The proposed 8.5.40 release is: > [ ] Broken - do not release > [X] Stable - go ahead and release as 8.5.40 > +1 Tested on simple hand-made app.(enable session replication). > Due to the security fix contained in this release, the voting period may > be shortened once sufficient votes are cast to enable a faster release. > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > > -- Keiichi.Fujino
Re: [VOTE] Release Apache Tomcat 9.0.18
2019年4月10日(水) 22:44 Mark Thomas : > The proposed Apache Tomcat 9.0.18 release is now available for voting. > > The major changes compared to the 9.0.17 release are: > > - Fix for CVE-2019-0232 a RCE vulnerability on Windows > > - Add support for Java 11 to the JSP compiler. Java 12 and 13 are also > now supported if used with a ECJ version with support for those Java > versions > > - Various NIO2 stability improvements > > Along with lots of other bug fixes and improvements. > > For full details, see the changelog: > https://ci.apache.org/projects/tomcat/tomcat9/docs/changelog.html > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.18/ > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1207/ > The tag is: > https://github.com/apache/tomcat/tree/9.0.18 > 0862607e5da91a7c476a6350288d8d8a9380f556 > > The proposed 9.0.18 release is: > [ ] Broken - do not release > [X] Stable - go ahead and release as 9.0.18 > > +1 Tested on simple hand-made app.(enable session replication). > Due to the security fix contained in this release, the voting period may > be shortened once sufficient votes are cast to enable a faster release. > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > > -- Keiichi.Fujino
