Re: [Bug 63833] NPE in DBCP when attempting to connect to a database that doesn't exist

[Phil Steitz]

On 10/16/19 7:55 AM, Mark Thomas wrote:

On 12/10/2019 00:03, Phil Steitz wrote:

How about adding the DBCP unit tests to the source tree?  I suspect some
would have failed due to this change.  If others think this is a good
idea, I could take a stab at genericising them and creating a PR to add
them.

+1

I'd suggest several commits. Something like:

- Copy latest 1.x from Commons
- Fix package naming issues
- Fix any running issues
- Fix warnings (inc. generics)

That way it should be easy to trace what changed from Commons and why.
The exact detail of how the changes are split between commits is not
important. It is the easy traceability that matters.



I just submitted a PR with the BasicDataSource tests and its 
dependencies with commits in the order above.  I disabled tests that 
were failing due to this issue (BZ 63833).   If this looks OK, I will 
continue to add the rest of them.  I can also do a separate PR to fix BZ 
63833 and re-enable the failing tests.  I could not find a 1.6 JDK to 
test with, so my testing was with 1.7 and 1.8 using test.name to limit 
execution to the tests that I was adding.


Phil



Mark



On 10/11/19 3:31 PM, bugzi...@apache.org wrote:

https://bz.apache.org/bugzilla/show_bug.cgi?id=63833

Phil Steitz  changed:

     What    |Removed |Added


   OS|    |All

--- Comment #2 from Phil Steitz  ---
This is a regression from the generics conversion in
PoolableConnectionFactory.

The original DBCP 1.x code effectively null-checked the object to be
destroyed:
  public void destroyObject(Object obj) throws Exception {
  if(obj instanceof PoolableConnection) {
  ((PoolableConnection)obj).reallyClose();
  }

Removing the instanceOf check makes NPE possible:
  public void destroyObject(PoolableConnection obj) throws Exception {
  obj.reallyClose();
  }

Solution is to add an explicit null check in destroyObject.

Similar changes should be made to activate, passivate, validate methods.



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] [tomcat] psteitz opened a new pull request #216: Add Commons DBCP 1.x unit tests to 7.0.x branch

[GitBox]

psteitz opened a new pull request #216: Add Commons DBCP 1.x unit tests to 
7.0.x branch
URL: https://github.com/apache/tomcat/pull/216
 
 
   Initial batch of unit tests ported from commons dbcp 1.5 branch.  Tests 
failing due to BZ 63833 are disabled by renaming the test cases.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

buildbot success in on tomcat-trunk

[buildbot]

The Buildbot has detected a restored build on builder tomcat-trunk while 
building tomcat. Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/4683

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: asf946_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit' 
triggered this build
Build Source Stamp: [branch master] e3f18d5d8f5667200cab034596d81a9b5db604b4
Blamelist: Mark Thomas 

Build succeeded!

Sincerely,
 -The Buildbot




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 63815] Expansion of JAVA_OPTS in catalina.sh containing '*' stops startup on linux

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=63815

Mark Thomas  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #8 from Mark Thomas  ---
I didn;t see any objections so I went ahead and applied the patch.

Fixed in:
- master for 9.0.28 onwards
- 8.5.x for 8.5.48 onwards
- 7.0.x for 7.0.98 onwards

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch 7.0.x updated: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63815

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 7.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/7.0.x by this push:
 new ca6e460  Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63815
ca6e460 is described below

commit ca6e46027ab976e88f7e581f464de9ab7746d54a
Author: Mark Thomas 
AuthorDate: Wed Oct 16 14:05:16 2019 +0100

Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63815

Quote CATALINA_OPTS and JAVA_OPTS when used to prevent expansion of *.
---
 bin/catalina.sh| 16 
 bin/daemon.sh  |  4 ++--
 bin/tool-wrapper.sh|  2 +-
 webapps/docs/changelog.xml |  7 +++
 4 files changed, 18 insertions(+), 11 deletions(-)

diff --git a/bin/catalina.sh b/bin/catalina.sh
index f873a8f..ca09baa 100755
--- a/bin/catalina.sh
+++ b/bin/catalina.sh
@@ -350,7 +350,7 @@ if [ "$1" = "debug" ] ; then
 echo "Using Security Manager"
   fi
   shift
-  exec "$_RUNJDB" "$LOGGING_CONFIG" $LOGGING_MANAGER $JAVA_OPTS 
$CATALINA_OPTS \
+  exec "$_RUNJDB" "$LOGGING_CONFIG" $LOGGING_MANAGER "$JAVA_OPTS" 
"$CATALINA_OPTS" \
 -D$ENDORSED_PROP="$JAVA_ENDORSED_DIRS" \
 -classpath "$CLASSPATH" \
 -sourcepath "$CATALINA_HOME"/../../java \
@@ -361,7 +361,7 @@ if [ "$1" = "debug" ] ; then
 -Djava.io.tmpdir="$CATALINA_TMPDIR" \
 org.apache.catalina.startup.Bootstrap "$@" start
 else
-  exec "$_RUNJDB" "$LOGGING_CONFIG" $LOGGING_MANAGER $JAVA_OPTS 
$CATALINA_OPTS \
+  exec "$_RUNJDB" "$LOGGING_CONFIG" $LOGGING_MANAGER "$JAVA_OPTS" 
"$CATALINA_OPTS" \
 -D$ENDORSED_PROP="$JAVA_ENDORSED_DIRS" \
 -classpath "$CLASSPATH" \
 -sourcepath "$CATALINA_HOME"/../../java \
@@ -380,7 +380,7 @@ elif [ "$1" = "run" ]; then
   echo "Using Security Manager"
 fi
 shift
-eval exec "\"$_RUNJAVA\"" "\"$LOGGING_CONFIG\"" $LOGGING_MANAGER 
$JAVA_OPTS $CATALINA_OPTS \
+eval exec "\"$_RUNJAVA\"" "\"$LOGGING_CONFIG\"" $LOGGING_MANAGER 
"$JAVA_OPTS" "$CATALINA_OPTS" \
   -D$ENDORSED_PROP="\"$JAVA_ENDORSED_DIRS\"" \
   -classpath "\"$CLASSPATH\"" \
   -Djava.security.manager \
@@ -390,7 +390,7 @@ elif [ "$1" = "run" ]; then
   -Djava.io.tmpdir="\"$CATALINA_TMPDIR\"" \
   org.apache.catalina.startup.Bootstrap "$@" start
   else
-eval exec "\"$_RUNJAVA\"" "\"$LOGGING_CONFIG\"" $LOGGING_MANAGER 
$JAVA_OPTS $CATALINA_OPTS \
+eval exec "\"$_RUNJAVA\"" "\"$LOGGING_CONFIG\"" $LOGGING_MANAGER 
"$JAVA_OPTS" "$CATALINA_OPTS" \
   -D$ENDORSED_PROP="\"$JAVA_ENDORSED_DIRS\"" \
   -classpath "\"$CLASSPATH\"" \
   -Dcatalina.base="\"$CATALINA_BASE\"" \
@@ -448,7 +448,7 @@ elif [ "$1" = "start" ] ; then
   echo "Using Security Manager"
 fi
 shift
-eval $_NOHUP "\"$_RUNJAVA\"" "\"$LOGGING_CONFIG\"" $LOGGING_MANAGER 
$JAVA_OPTS $CATALINA_OPTS \
+eval $_NOHUP "\"$_RUNJAVA\"" "\"$LOGGING_CONFIG\"" $LOGGING_MANAGER 
"$JAVA_OPTS" "$CATALINA_OPTS" \
   -D$ENDORSED_PROP="\"$JAVA_ENDORSED_DIRS\"" \
   -classpath "\"$CLASSPATH\"" \
   -Djava.security.manager \
@@ -460,7 +460,7 @@ elif [ "$1" = "start" ] ; then
   >> "$CATALINA_OUT" 2>&1 "&"
 
   else
-eval $_NOHUP "\"$_RUNJAVA\"" "\"$LOGGING_CONFIG\"" $LOGGING_MANAGER 
$JAVA_OPTS $CATALINA_OPTS \
+eval $_NOHUP "\"$_RUNJAVA\"" "\"$LOGGING_CONFIG\"" $LOGGING_MANAGER 
"$JAVA_OPTS" "$CATALINA_OPTS" \
   -D$ENDORSED_PROP="\"$JAVA_ENDORSED_DIRS\"" \
   -classpath "\"$CLASSPATH\"" \
   -Dcatalina.base="\"$CATALINA_BASE\"" \
@@ -513,7 +513,7 @@ elif [ "$1" = "stop" ] ; then
 fi
   fi
 
-  eval "\"$_RUNJAVA\"" $LOGGING_MANAGER $JAVA_OPTS \
+  eval "\"$_RUNJAVA\"" $LOGGING_MANAGER "$JAVA_OPTS" \
 -D$ENDORSED_PROP="\"$JAVA_ENDORSED_DIRS\"" \
 -classpath "\"$CLASSPATH\"" \
 -Dcatalina.base="\"$CATALINA_BASE\"" \
@@ -600,7 +600,7 @@ elif [ "$1" = "stop" ] ; then
 
 elif [ "$1" = "configtest" ] ; then
 
-eval "\"$_RUNJAVA\"" $LOGGING_MANAGER $JAVA_OPTS \
+eval "\"$_RUNJAVA\"" $LOGGING_MANAGER "$JAVA_OPTS" \
   -D$ENDORSED_PROP="\"$JAVA_ENDORSED_DIRS\"" \
   -classpath "\"$CLASSPATH\"" \
   -Dcatalina.base="\"$CATALINA_BASE\"" \
diff --git a/bin/daemon.sh b/bin/daemon.sh
index afa4c89..3c517ba 100755
--- a/bin/daemon.sh
+++ b/bin/daemon.sh
@@ -208,7 +208,7 @@ case "$1" in
   -outfile "&1" \
   -errfile "&2" \
   -classpath "$CLASSPATH" \
-  "$LOGGING_CONFIG" $JAVA_OPTS $CATALINA_OPTS \
+  "$LOGGING_CONFIG" "$JAVA_OPTS" "$CATALINA_OPTS" \
   -D$ENDORSED_PROP="$JAVA_ENDORSED_DIRS" \
   -Dcatalina.base="$CATALINA_BASE" \
   -Dcatalina.home="$CATALINA_HOME" \
@@ -225,7 +225,7 @@ case "$1" in
   -outfile "$CATALINA_OUT" \
   -errfile "&1" \
   -classpath "$CLASSPATH" \
-  "$LOGGING_CONFIG" $JAVA_OPTS $CATALINA_OPTS \
+  "$LOGGING_CONFIG" "$JAVA_OPTS" "$CATALINA_OPTS" \
   

[tomcat] branch 8.5.x updated: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63815

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/8.5.x by this push:
 new d713e8e  Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63815
d713e8e is described below

commit d713e8e8ab02ce9d1f47110891464378bafbf0b6
Author: Mark Thomas 
AuthorDate: Wed Oct 16 14:05:16 2019 +0100

Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63815

Quote CATALINA_OPTS and JAVA_OPTS when used to prevent expansion of *.
---
 bin/catalina.sh| 16 
 bin/daemon.sh  |  4 ++--
 bin/tool-wrapper.sh|  2 +-
 webapps/docs/changelog.xml |  7 +++
 4 files changed, 18 insertions(+), 11 deletions(-)

diff --git a/bin/catalina.sh b/bin/catalina.sh
index 5fbdb72..baa0bd9 100755
--- a/bin/catalina.sh
+++ b/bin/catalina.sh
@@ -354,7 +354,7 @@ if [ "$1" = "debug" ] ; then
 echo "Using Security Manager"
   fi
   shift
-  exec "$_RUNJDB" "$LOGGING_CONFIG" $LOGGING_MANAGER $JAVA_OPTS 
$CATALINA_OPTS \
+  exec "$_RUNJDB" "$LOGGING_CONFIG" $LOGGING_MANAGER "$JAVA_OPTS" 
"$CATALINA_OPTS" \
 -D$ENDORSED_PROP="$JAVA_ENDORSED_DIRS" \
 -classpath "$CLASSPATH" \
 -sourcepath "$CATALINA_HOME"/../../java \
@@ -365,7 +365,7 @@ if [ "$1" = "debug" ] ; then
 -Djava.io.tmpdir="$CATALINA_TMPDIR" \
 org.apache.catalina.startup.Bootstrap "$@" start
 else
-  exec "$_RUNJDB" "$LOGGING_CONFIG" $LOGGING_MANAGER $JAVA_OPTS 
$CATALINA_OPTS \
+  exec "$_RUNJDB" "$LOGGING_CONFIG" $LOGGING_MANAGER "$JAVA_OPTS" 
"$CATALINA_OPTS" \
 -D$ENDORSED_PROP="$JAVA_ENDORSED_DIRS" \
 -classpath "$CLASSPATH" \
 -sourcepath "$CATALINA_HOME"/../../java \
@@ -384,7 +384,7 @@ elif [ "$1" = "run" ]; then
   echo "Using Security Manager"
 fi
 shift
-eval exec "\"$_RUNJAVA\"" "\"$LOGGING_CONFIG\"" $LOGGING_MANAGER 
$JAVA_OPTS $CATALINA_OPTS \
+eval exec "\"$_RUNJAVA\"" "\"$LOGGING_CONFIG\"" $LOGGING_MANAGER 
"$JAVA_OPTS" "$CATALINA_OPTS" \
   -D$ENDORSED_PROP="\"$JAVA_ENDORSED_DIRS\"" \
   -classpath "\"$CLASSPATH\"" \
   -Djava.security.manager \
@@ -394,7 +394,7 @@ elif [ "$1" = "run" ]; then
   -Djava.io.tmpdir="\"$CATALINA_TMPDIR\"" \
   org.apache.catalina.startup.Bootstrap "$@" start
   else
-eval exec "\"$_RUNJAVA\"" "\"$LOGGING_CONFIG\"" $LOGGING_MANAGER 
$JAVA_OPTS $CATALINA_OPTS \
+eval exec "\"$_RUNJAVA\"" "\"$LOGGING_CONFIG\"" $LOGGING_MANAGER 
"$JAVA_OPTS" "$CATALINA_OPTS" \
   -D$ENDORSED_PROP="\"$JAVA_ENDORSED_DIRS\"" \
   -classpath "\"$CLASSPATH\"" \
   -Dcatalina.base="\"$CATALINA_BASE\"" \
@@ -452,7 +452,7 @@ elif [ "$1" = "start" ] ; then
   echo "Using Security Manager"
 fi
 shift
-eval $_NOHUP "\"$_RUNJAVA\"" "\"$LOGGING_CONFIG\"" $LOGGING_MANAGER 
$JAVA_OPTS $CATALINA_OPTS \
+eval $_NOHUP "\"$_RUNJAVA\"" "\"$LOGGING_CONFIG\"" $LOGGING_MANAGER 
"$JAVA_OPTS" "$CATALINA_OPTS" \
   -D$ENDORSED_PROP="\"$JAVA_ENDORSED_DIRS\"" \
   -classpath "\"$CLASSPATH\"" \
   -Djava.security.manager \
@@ -464,7 +464,7 @@ elif [ "$1" = "start" ] ; then
   >> "$CATALINA_OUT" 2>&1 "&"
 
   else
-eval $_NOHUP "\"$_RUNJAVA\"" "\"$LOGGING_CONFIG\"" $LOGGING_MANAGER 
$JAVA_OPTS $CATALINA_OPTS \
+eval $_NOHUP "\"$_RUNJAVA\"" "\"$LOGGING_CONFIG\"" $LOGGING_MANAGER 
"$JAVA_OPTS" "$CATALINA_OPTS" \
   -D$ENDORSED_PROP="\"$JAVA_ENDORSED_DIRS\"" \
   -classpath "\"$CLASSPATH\"" \
   -Dcatalina.base="\"$CATALINA_BASE\"" \
@@ -517,7 +517,7 @@ elif [ "$1" = "stop" ] ; then
 fi
   fi
 
-  eval "\"$_RUNJAVA\"" $LOGGING_MANAGER $JAVA_OPTS \
+  eval "\"$_RUNJAVA\"" $LOGGING_MANAGER "$JAVA_OPTS" \
 -D$ENDORSED_PROP="\"$JAVA_ENDORSED_DIRS\"" \
 -classpath "\"$CLASSPATH\"" \
 -Dcatalina.base="\"$CATALINA_BASE\"" \
@@ -604,7 +604,7 @@ elif [ "$1" = "stop" ] ; then
 
 elif [ "$1" = "configtest" ] ; then
 
-eval "\"$_RUNJAVA\"" $LOGGING_MANAGER $JAVA_OPTS \
+eval "\"$_RUNJAVA\"" $LOGGING_MANAGER "$JAVA_OPTS" \
   -D$ENDORSED_PROP="\"$JAVA_ENDORSED_DIRS\"" \
   -classpath "\"$CLASSPATH\"" \
   -Dcatalina.base="\"$CATALINA_BASE\"" \
diff --git a/bin/daemon.sh b/bin/daemon.sh
index afa4c89..3c517ba 100755
--- a/bin/daemon.sh
+++ b/bin/daemon.sh
@@ -208,7 +208,7 @@ case "$1" in
   -outfile "&1" \
   -errfile "&2" \
   -classpath "$CLASSPATH" \
-  "$LOGGING_CONFIG" $JAVA_OPTS $CATALINA_OPTS \
+  "$LOGGING_CONFIG" "$JAVA_OPTS" "$CATALINA_OPTS" \
   -D$ENDORSED_PROP="$JAVA_ENDORSED_DIRS" \
   -Dcatalina.base="$CATALINA_BASE" \
   -Dcatalina.home="$CATALINA_HOME" \
@@ -225,7 +225,7 @@ case "$1" in
   -outfile "$CATALINA_OUT" \
   -errfile "&1" \
   -classpath "$CLASSPATH" \
-  "$LOGGING_CONFIG" $JAVA_OPTS $CATALINA_OPTS \
+  "$LOGGING_CONFIG" "$JAVA_OPTS" "$CATALINA_OPTS" \
   

[tomcat] branch master updated: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63815

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/master by this push:
 new fe11123  Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63815
fe11123 is described below

commit fe11123f994d66e2e0f9069ba8b701593ff44c99
Author: Mark Thomas 
AuthorDate: Wed Oct 16 14:05:16 2019 +0100

Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63815

Quote CATALINA_OPTS and JAVA_OPTS when used to prevent expansion of *.
---
 bin/catalina.sh| 16 
 bin/daemon.sh  |  4 ++--
 bin/tool-wrapper.sh|  2 +-
 webapps/docs/changelog.xml |  7 +++
 4 files changed, 18 insertions(+), 11 deletions(-)

diff --git a/bin/catalina.sh b/bin/catalina.sh
index 5fbdb72..baa0bd9 100755
--- a/bin/catalina.sh
+++ b/bin/catalina.sh
@@ -354,7 +354,7 @@ if [ "$1" = "debug" ] ; then
 echo "Using Security Manager"
   fi
   shift
-  exec "$_RUNJDB" "$LOGGING_CONFIG" $LOGGING_MANAGER $JAVA_OPTS 
$CATALINA_OPTS \
+  exec "$_RUNJDB" "$LOGGING_CONFIG" $LOGGING_MANAGER "$JAVA_OPTS" 
"$CATALINA_OPTS" \
 -D$ENDORSED_PROP="$JAVA_ENDORSED_DIRS" \
 -classpath "$CLASSPATH" \
 -sourcepath "$CATALINA_HOME"/../../java \
@@ -365,7 +365,7 @@ if [ "$1" = "debug" ] ; then
 -Djava.io.tmpdir="$CATALINA_TMPDIR" \
 org.apache.catalina.startup.Bootstrap "$@" start
 else
-  exec "$_RUNJDB" "$LOGGING_CONFIG" $LOGGING_MANAGER $JAVA_OPTS 
$CATALINA_OPTS \
+  exec "$_RUNJDB" "$LOGGING_CONFIG" $LOGGING_MANAGER "$JAVA_OPTS" 
"$CATALINA_OPTS" \
 -D$ENDORSED_PROP="$JAVA_ENDORSED_DIRS" \
 -classpath "$CLASSPATH" \
 -sourcepath "$CATALINA_HOME"/../../java \
@@ -384,7 +384,7 @@ elif [ "$1" = "run" ]; then
   echo "Using Security Manager"
 fi
 shift
-eval exec "\"$_RUNJAVA\"" "\"$LOGGING_CONFIG\"" $LOGGING_MANAGER 
$JAVA_OPTS $CATALINA_OPTS \
+eval exec "\"$_RUNJAVA\"" "\"$LOGGING_CONFIG\"" $LOGGING_MANAGER 
"$JAVA_OPTS" "$CATALINA_OPTS" \
   -D$ENDORSED_PROP="\"$JAVA_ENDORSED_DIRS\"" \
   -classpath "\"$CLASSPATH\"" \
   -Djava.security.manager \
@@ -394,7 +394,7 @@ elif [ "$1" = "run" ]; then
   -Djava.io.tmpdir="\"$CATALINA_TMPDIR\"" \
   org.apache.catalina.startup.Bootstrap "$@" start
   else
-eval exec "\"$_RUNJAVA\"" "\"$LOGGING_CONFIG\"" $LOGGING_MANAGER 
$JAVA_OPTS $CATALINA_OPTS \
+eval exec "\"$_RUNJAVA\"" "\"$LOGGING_CONFIG\"" $LOGGING_MANAGER 
"$JAVA_OPTS" "$CATALINA_OPTS" \
   -D$ENDORSED_PROP="\"$JAVA_ENDORSED_DIRS\"" \
   -classpath "\"$CLASSPATH\"" \
   -Dcatalina.base="\"$CATALINA_BASE\"" \
@@ -452,7 +452,7 @@ elif [ "$1" = "start" ] ; then
   echo "Using Security Manager"
 fi
 shift
-eval $_NOHUP "\"$_RUNJAVA\"" "\"$LOGGING_CONFIG\"" $LOGGING_MANAGER 
$JAVA_OPTS $CATALINA_OPTS \
+eval $_NOHUP "\"$_RUNJAVA\"" "\"$LOGGING_CONFIG\"" $LOGGING_MANAGER 
"$JAVA_OPTS" "$CATALINA_OPTS" \
   -D$ENDORSED_PROP="\"$JAVA_ENDORSED_DIRS\"" \
   -classpath "\"$CLASSPATH\"" \
   -Djava.security.manager \
@@ -464,7 +464,7 @@ elif [ "$1" = "start" ] ; then
   >> "$CATALINA_OUT" 2>&1 "&"
 
   else
-eval $_NOHUP "\"$_RUNJAVA\"" "\"$LOGGING_CONFIG\"" $LOGGING_MANAGER 
$JAVA_OPTS $CATALINA_OPTS \
+eval $_NOHUP "\"$_RUNJAVA\"" "\"$LOGGING_CONFIG\"" $LOGGING_MANAGER 
"$JAVA_OPTS" "$CATALINA_OPTS" \
   -D$ENDORSED_PROP="\"$JAVA_ENDORSED_DIRS\"" \
   -classpath "\"$CLASSPATH\"" \
   -Dcatalina.base="\"$CATALINA_BASE\"" \
@@ -517,7 +517,7 @@ elif [ "$1" = "stop" ] ; then
 fi
   fi
 
-  eval "\"$_RUNJAVA\"" $LOGGING_MANAGER $JAVA_OPTS \
+  eval "\"$_RUNJAVA\"" $LOGGING_MANAGER "$JAVA_OPTS" \
 -D$ENDORSED_PROP="\"$JAVA_ENDORSED_DIRS\"" \
 -classpath "\"$CLASSPATH\"" \
 -Dcatalina.base="\"$CATALINA_BASE\"" \
@@ -604,7 +604,7 @@ elif [ "$1" = "stop" ] ; then
 
 elif [ "$1" = "configtest" ] ; then
 
-eval "\"$_RUNJAVA\"" $LOGGING_MANAGER $JAVA_OPTS \
+eval "\"$_RUNJAVA\"" $LOGGING_MANAGER "$JAVA_OPTS" \
   -D$ENDORSED_PROP="\"$JAVA_ENDORSED_DIRS\"" \
   -classpath "\"$CLASSPATH\"" \
   -Dcatalina.base="\"$CATALINA_BASE\"" \
diff --git a/bin/daemon.sh b/bin/daemon.sh
index afa4c89..3c517ba 100755
--- a/bin/daemon.sh
+++ b/bin/daemon.sh
@@ -208,7 +208,7 @@ case "$1" in
   -outfile "&1" \
   -errfile "&2" \
   -classpath "$CLASSPATH" \
-  "$LOGGING_CONFIG" $JAVA_OPTS $CATALINA_OPTS \
+  "$LOGGING_CONFIG" "$JAVA_OPTS" "$CATALINA_OPTS" \
   -D$ENDORSED_PROP="$JAVA_ENDORSED_DIRS" \
   -Dcatalina.base="$CATALINA_BASE" \
   -Dcatalina.home="$CATALINA_HOME" \
@@ -225,7 +225,7 @@ case "$1" in
   -outfile "$CATALINA_OUT" \
   -errfile "&1" \
   -classpath "$CLASSPATH" \
-  "$LOGGING_CONFIG" $JAVA_OPTS $CATALINA_OPTS \
+  "$LOGGING_CONFIG" "$JAVA_OPTS" "$CATALINA_OPTS" \
   

[Bug 63826] Don't deliver libtcnative and Commons Daemon tarballs with Windows releases

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=63826

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Mark Thomas  ---
Agreed.

Fixed in:
- master for 9.0.28 onwards
- 8.5.x for 8.5.48 onwards
- 7.0.x for 7.0.98 onwards

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch 8.5.x updated: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63826

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/8.5.x by this push:
 new 1ec84d4  Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63826
1ec84d4 is described below

commit 1ec84d408b795210c46a5348de3f22e16f259af4
Author: Mark Thomas 
AuthorDate: Sun Oct 20 20:14:53 2019 +0100

Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63826

Remove commons-daemon-native.tar.gz and tomcat-native.tar.gz from the
binary zip distributions for Windows since compiled versions of those
components are already included within the zip distriubutions.
---
 build.xml  |  4 
 webapps/docs/changelog.xml | 10 ++
 2 files changed, 14 insertions(+)

diff --git a/build.xml b/build.xml
index c274aab..f8c7d62 100644
--- a/build.xml
+++ b/build.xml
@@ -2379,6 +2379,8 @@ skip.installer property in build.properties" />
 
 
 
+
+
   
 
 
@@ -2404,6 +2406,8 @@ skip.installer property in build.properties" />
 
 
 
+
+
   
   
 
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index fa45ae4..9116dcf 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -75,6 +75,16 @@
   
 
   
+  
+
+  
+63826: Remove commons-daemon-native.tar.gz and
+tomcat-native.tar.gz from the binary zip distributions for
+Windows since compiled versions of those components are already
+included within the zip distriubutions. (markt)
+  
+
+  
 
 
   


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch 7.0.x updated: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63826

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 7.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/7.0.x by this push:
 new 0152437  Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63826
0152437 is described below

commit 01524378e75a80e87b42cabca12109b7da4f9ad5
Author: Mark Thomas 
AuthorDate: Sun Oct 20 20:14:53 2019 +0100

Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63826

Remove commons-daemon-native.tar.gz and tomcat-native.tar.gz from the
binary zip distributions for Windows since compiled versions of those
components are already included within the zip distriubutions.
---
 build.xml  |  4 
 webapps/docs/changelog.xml | 10 ++
 2 files changed, 14 insertions(+)

diff --git a/build.xml b/build.xml
index 0b2b8d2..e421448 100644
--- a/build.xml
+++ b/build.xml
@@ -2526,6 +2526,8 @@ skip.installer property in build.properties" />
 
 
 
+
+
   
 
 
@@ -2551,6 +2553,8 @@ skip.installer property in build.properties" />
 
 
 
+
+
   
   
 
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 9d45831..160ad9d 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -94,6 +94,16 @@
   
 
   
+  
+
+  
+63826: Remove commons-daemon-native.tar.gz and
+tomcat-native.tar.gz from the binary zip distributions for
+Windows since compiled versions of those components are already
+included within the zip distriubutions. (markt)
+  
+
+  
 
 
   


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch master updated: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63826

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/master by this push:
 new e3f18d5  Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63826
e3f18d5 is described below

commit e3f18d5d8f5667200cab034596d81a9b5db604b4
Author: Mark Thomas 
AuthorDate: Sun Oct 20 20:14:53 2019 +0100

Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63826

Remove commons-daemon-native.tar.gz and tomcat-native.tar.gz from the
binary zip distributions for Windows since compiled versions of those
components are already included within the zip distriubutions.
---
 build.xml  |  4 
 webapps/docs/changelog.xml | 10 ++
 2 files changed, 14 insertions(+)

diff --git a/build.xml b/build.xml
index 020531c..c87c744 100644
--- a/build.xml
+++ b/build.xml
@@ -2367,6 +2367,8 @@ skip.installer property in build.properties" />
 
 
 
+
+
   
 
 
@@ -2392,6 +2394,8 @@ skip.installer property in build.properties" />
 
 
 
+
+
   
   
 
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 5998058..aa8e88d 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -79,6 +79,16 @@
   
 
   
+  
+
+  
+63826: Remove commons-daemon-native.tar.gz and
+tomcat-native.tar.gz from the binary zip distributions for
+Windows since compiled versions of those components are already
+included within the zip distriubutions. (markt)
+  
+
+  
 
 
   


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [tomcat] branch master updated: Minor optimisation - add new line to access log message outside the sync

[Mark Thomas]

> Mark,
> 
> On 10/18/19 12:22, ma...@apache.org wrote:
>> This is an automated email from the ASF dual-hosted git
>> repository.
> 
>> markt pushed a commit to branch master in repository
>> https://gitbox.apache.org/repos/asf/tomcat.git
> 
> 
>> The following commit(s) were added to refs/heads/master by this
>> push: new b8cc215  Minor optimisation - add new line to access log
>> message outside the sync b8cc215 is described below
> 
> Doesn't this perform a string-mutation instead of a stream-append?

No. Both message and write are writers.

> Or is it more critical to hold the lock for as short a period as possible?

I was looking for hot-spots, making sure the header parsing changes
weren't having a measurable impact. The header parsing never even
appeared in the results. But the AccessLog did.

The new code is marginally faster but the hot spots were dominated by
I/O (on localhost) and profiler calls. The % of call time spent waiting
for that sync dropped from ~13% to ~12%.

I don't trust the numbers from the profiler as the test was well into
the realm where the profiler has a significant impact on the figures but
I do trust the direction of travel (downwards).

The AccessLog is still a bottleneck. I don't see any easy way to remove
that without significantly increasing the extent to which entries are
added out of chronological order.

Mark


> 
> -chris
> 
>> commit b8cc21574938dc8f46b88396de0694e1ce7aa0a7 Author: Mark Thomas
>>  AuthorDate: Fri Oct 18 17:03:47 2019 +0100
> 
>> Minor optimisation - add new line to access log message outside the
>> sync --- java/org/apache/catalina/valves/AccessLogValve.java | 2
>> +- 1 file changed, 1 insertion(+), 1 deletion(-)
> 
>> diff --git a/java/org/apache/catalina/valves/AccessLogValve.java
>> b/java/org/apache/catalina/valves/AccessLogValve.java index
>> fe2943e..b133e10 100644 ---
>> a/java/org/apache/catalina/valves/AccessLogValve.java +++
>> b/java/org/apache/catalina/valves/AccessLogValve.java @@ -610,10
>> +610,10 @@ public class AccessLogValve extends
>> AbstractAccessLogValve {
> 
>> // Log this message try { +
>> message.write(System.lineSeparator()); synchronized(this) { if
>> (writer != null) { message.writeTo(writer); -
>> writer.println(""); if (!buffered) { writer.flush(); }
> 
> 
>> -
> 
> 
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 63867] Add option for reason phrase

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=63867

--- Comment #6 from Michael Osipov  ---
(In reply to Christopher Schultz from comment #5)
> (In reply to Michael Osipov from comment #4)
> > (In reply to Mark Thomas from comment #3)
> > > I think I would be a good thing (long term) for a number of companies to 
> > > be
> > > forced to go through a multi-million dollar hardware fix / replacement
> > > program so that the next time a system like this is designed more thought 
> > > it
> > > is given to the question "What happens when (not if) the client needs to 
> > > be
> > > updated?".
> > 
> > +1
> 
> So, I *completely* agree with this statement and it's sentiment, but,
> honestly, this response is pretty hostile to the Tomcat community. If anyone
> wants to know the answer to the question "why do people use Jetty instead of
> Tomcat?" then this kind of the response is going to be a part of the answer.
> 
> I honestly don't understand why this issue is so contentious. HTTP/2 does
> not have reason phrases at all, and they are practically optional in
> HTTP/1.1 because there are no requirements for their content
> (https://tools.ietf.org/html/rfc7231#section-6.1).
> 
> There is an interesting conversation about the reason phrase NOT being
> resurrected in HTTP/2 here: https://github.com/http2/http2-spec/issues/202.
> I find mnot's comment from 2018-02-04 to be the most compelling support for
> dropping the reason phrase.
> 
> But when it comes down to it, inclusion of reason phrases are NOT prohibited
> by any version of HTTP/1.1 and some applications -- regardless of how
> foolish it is to have done so -- are evidently dependent upon their presence.
> 
> The servlet spec has both HttpServletResponse.setStatus(int,String) which
> has been deprecated since spec 2.1 (release in 1998, so over 20 years ago)
> and HttpServletResponse.sendError(int,String). The former method argues that
> the usage of the "msg" parameter is ambiguous and suggests that #sendError
> should be user instead, but then the docs for #sendError imply that the
> "msg" parameter is used as the response *entity* and not as a reason phrase.
> So, IMO, there is still plenty of ambiguity there.
> 
> If sendError(int,String) does set a reason phrase, then NOT respecting the
> application's attempts to set the reason phrase seems like a bug to me --
> excepting of course the case where h2 is the protocol, but again, that is
> the application's choice.
> 
> If Tomcat wants to omit reason phrases BY DEFAULT then I think that is
> reasonable. But if an application calls response.setStatus(200, "Super
> Duper") -- or response.sendError(200, "Super Duper") then I think it's
> reasonable to expect that the response on the wire will actually include
> that text.

sendError() ia designed to deliver an HTML page, not the reason phrase.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 63867] Add option for reason phrase

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=63867

--- Comment #5 from Christopher Schultz  ---
(In reply to Michael Osipov from comment #4)
> (In reply to Mark Thomas from comment #3)
> > I think I would be a good thing (long term) for a number of companies to be
> > forced to go through a multi-million dollar hardware fix / replacement
> > program so that the next time a system like this is designed more thought it
> > is given to the question "What happens when (not if) the client needs to be
> > updated?".
> 
> +1

So, I *completely* agree with this statement and it's sentiment, but, honestly,
this response is pretty hostile to the Tomcat community. If anyone wants to
know the answer to the question "why do people use Jetty instead of Tomcat?"
then this kind of the response is going to be a part of the answer.

I honestly don't understand why this issue is so contentious. HTTP/2 does not
have reason phrases at all, and they are practically optional in HTTP/1.1
because there are no requirements for their content
(https://tools.ietf.org/html/rfc7231#section-6.1).

There is an interesting conversation about the reason phrase NOT being
resurrected in HTTP/2 here: https://github.com/http2/http2-spec/issues/202. I
find mnot's comment from 2018-02-04 to be the most compelling support for
dropping the reason phrase.

But when it comes down to it, inclusion of reason phrases are NOT prohibited by
any version of HTTP/1.1 and some applications -- regardless of how foolish it
is to have done so -- are evidently dependent upon their presence.

The servlet spec has both HttpServletResponse.setStatus(int,String) which has
been deprecated since spec 2.1 (release in 1998, so over 20 years ago) and
HttpServletResponse.sendError(int,String). The former method argues that the
usage of the "msg" parameter is ambiguous and suggests that #sendError should
be user instead, but then the docs for #sendError imply that the "msg"
parameter is used as the response *entity* and not as a reason phrase. So, IMO,
there is still plenty of ambiguity there.

If sendError(int,String) does set a reason phrase, then NOT respecting the
application's attempts to set the reason phrase seems like a bug to me --
excepting of course the case where h2 is the protocol, but again, that is the
application's choice.

If Tomcat wants to omit reason phrases BY DEFAULT then I think that is
reasonable. But if an application calls response.setStatus(200, "Super Duper")
-- or response.sendError(200, "Super Duper") then I think it's reasonable to
expect that the response on the wire will actually include that text.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [tomcat] branch master updated: Minor optimisation - add new line to access log message outside the sync

[Christopher Schultz]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Mark,

On 10/18/19 12:22, ma...@apache.org wrote:
> This is an automated email from the ASF dual-hosted git
> repository.
>
> markt pushed a commit to branch master in repository
> https://gitbox.apache.org/repos/asf/tomcat.git
>
>
> The following commit(s) were added to refs/heads/master by this
> push: new b8cc215  Minor optimisation - add new line to access log
> message outside the sync b8cc215 is described below

Doesn't this perform a string-mutation instead of a stream-append?

Or is it more critical to hold the lock for as short a period as possibl
e?

- -chris

> commit b8cc21574938dc8f46b88396de0694e1ce7aa0a7 Author: Mark Thomas
>  AuthorDate: Fri Oct 18 17:03:47 2019 +0100
>
> Minor optimisation - add new line to access log message outside the
> sync --- java/org/apache/catalina/valves/AccessLogValve.java | 2
> +- 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/java/org/apache/catalina/valves/AccessLogValve.java
> b/java/org/apache/catalina/valves/AccessLogValve.java index
> fe2943e..b133e10 100644 ---
> a/java/org/apache/catalina/valves/AccessLogValve.java +++
> b/java/org/apache/catalina/valves/AccessLogValve.java @@ -610,10
> +610,10 @@ public class AccessLogValve extends
> AbstractAccessLogValve {
>
> // Log this message try { +
> message.write(System.lineSeparator()); synchronized(this) { if
> (writer != null) { message.writeTo(writer); -
> writer.println(""); if (!buffered) { writer.flush(); }
>
>
> -
>
>
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
-BEGIN PGP SIGNATURE-
Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/

iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAl2sVi4ACgkQHPApP6U8
pFiMAA/8ChWuK3QDa2mOrHkVNKxexYiWD/yr3D/wex6w0BNpmKia6UzCs+qhFgwh
0jxbvbUzEUP11BJym2iZNOryLSk++ZCsq3s/e3730a0wn3eqaFaiCHH9xk2sogZ0
IWK1apDnGgB23mbQ5b+sshJinSWw6453X1XJUjnZtkv9Z89wac6cnfHs1WSqcqv4
bsxyZexlcs+bH3EUqxBqxlIGYxQS3GWQPFboWls04yCksBXwzGgT8s0CWJ94nfb8
jDA1ru0VIvJCwsqCY6ICqA9fXSByHfaZguXBbJ7rdMRHzrrSmwd/uei+leyN5Ch9
WhrwNZ1NlBmjvqQs2dhtMzZqhwWK7X4VEyg34KK0JI1Sx8LlajKd0VaD0J3Vz/FH
iu2ej/8YMorSIT8l6gVM28Yh8h+Zd+YeVvrZ7MZRZ0iFz+fXqS2EuR3s6oDU+6X+
7DSgkY1KMHi14t21fn5YZpAXe01OUI/tLUlP0OXzFrLzstscxOy3Bg24Ka1qT17N
rzGanNFlZxqtidyDpj+C17l8RACJbm7bBhlAg9+DaiwjkN+BbE0kKkcapjj0u41p
ay5mmX81tGG1qz4WfznD03fSI+H0xnVHdlRG5ewAMOceoKybOiVJjfIRh3mxG2rg
tqMCET6SvV3qaGja5trfRib6RVh/mTxAVdvHVW0YmRP/a1SY6Gw=
=g4kR
-END PGP SIGNATURE-

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 63867] Add option for reason phrase

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=63867

--- Comment #4 from Michael Osipov  ---
(In reply to Mark Thomas from comment #3)
> I think I would be a good thing (long term) for a number of companies to be
> forced to go through a multi-million dollar hardware fix / replacement
> program so that the next time a system like this is designed more thought it
> is given to the question "What happens when (not if) the client needs to be
> updated?".

+1

> b) Spring Boot supports multiple embedded Servlet containers. Maybe one of
> the alternatives is more compatible with the clients.
> 
> c) Figure out why Tomcat 8.5.x doesn't work with Spring Boot 2.2.x and fix
> it.

+1

You maybe should ask yourself whether Spring Boot is the right stack to chose
if you need 10+ years stability. The regular Spring Framework and Tomcat do
offer this, obviously Spring Boot does not.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

JDK 14 - Early Access build 19 is available

[Rory O'Donnell]

Hi Mark,

*OpenJDK builds  - JDK 14 *- Early Access build 19 is available at 
http://jdk.java.net/14/


These early-access, open-source builds are provided under the GNU 
General Public License, version 2, with the Classpath Exception 
.


 * Release notes
 o https://jdk.java.net/14/release-notes

 * JEPs targeted to JDK 14, so far
 o 352 - Non-Volatile Mapped Byte Buffers
   
 o 358 - Helpful NullPointerExceptions
   
 o 349 - JFR Event Streaming 
 * *I want to draw your attention to some notable changes in previous
   builds of JDK 14.*
 o *Build 14* - Classes are now loaded and linked by
   Class.forName() (JDK-8212117
   )
 + we need help testing changes to 3-arg Class.forName method.
   The method has always been specified to link the class but
   the implementation has historically not done this when
   invoked with the "initialize" parameter set to false. The
   bug has been fixed in JDK 14 but it has the potential to
   change the behavior of code that uses Class.forName to load
   classes that cannot be linked.


 * Changes in this build
   



*Openjdk Builds - JDK 13.0.1 *General Availability - 
https://jdk.java.net/13/


These early-access, open-source builds are provided under the GNU 
General Public License, version 2, with the Classpath Exception 
.


 * Release notes 
 * Changes in this release
   



*Crypto roadmap updated*    - 
https://www.java.com/en/jre-jdk-cryptoroadmap.html


Targeted Date^(2) 	Targeted Release(s) 	Algorithm/Protocol 	Action 	How 
to test/enable change 	Change Log
2019-10-15 	13, 11, 8, 7 	ECC on TLS 	Disable non-NIST Suite B EC curves 
(sect283k1, sect283r1, sect409k1, sect409r1, sect571k1, sect571r1, 
secp256k1) when negotiating TLS sessions 	Disabling non-NIST Suite B EC 
curves when negotiating TLS sessions 
 	2019-10-08 
Announced.



Rgds,Rory

--
Rgds, Rory O'Donnell
Quality Engineering Manager
Oracle EMEA, Dublin, Ireland

Bug report for Taglibs [2019/10/20]

[bugzilla]

+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|38193|Ass|Enh|2006-01-09|[RDC] BuiltIn Grammar support for Field   |
|38600|Ass|Enh|2006-02-10|[RDC] Enable RDCs to be used in X+V markup (X+RDC)|
|42413|New|Enh|2007-05-14|[PATCH] Log Taglib enhancements   |
|46052|New|Nor|2008-10-21|SetLocaleSupport is slow to initialize when many l|
|48333|New|Enh|2009-12-02|TLD generator |
|57548|New|Min|2015-02-08|Auto-generate the value for org.apache.taglibs.sta|
|57684|New|Min|2015-03-10|Version info should be taken from project version |
|59359|New|Enh|2016-04-20|(Task) Extend validity period for signing KEY - be|
|59668|New|Nor|2016-06-06|x:forEach retains the incorrect scope when used in|
|61875|New|Nor|2017-12-08|Investigate whether Xalan can be removed  |
+-+---+---+--+--+
| Total   10 bugs   |
+---+

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Bug report for Tomcat 9 [2019/10/20]

[bugzilla]

+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|57505|New|Enh|2015-01-27|Add integration tests for JspC|
|57661|New|Enh|2015-03-04|Delay sending of 100 continue response until appli|
|58242|New|Enh|2015-08-13|Scanning jars in classpath to get annotations in p|
|58530|New|Enh|2015-10-23|Proposal for new Manager HTML GUI |
|58548|New|Enh|2015-10-26|support certifcate transparency   |
|58859|New|Enh|2016-01-14|Allow to limit charsets / encodings supported by T|
|59203|New|Enh|2016-03-21|Try to call Thread.interrupt before calling Thread|
|59344|Ver|Enh|2016-04-18|PEM file support for JSSE |
|59750|New|Enh|2016-06-24|Amend "authenticate" method with context by means |
|60997|New|Enh|2017-04-17|Enhance SemaphoreValve to support denied status an|
|61971|New|Enh|2018-01-06|documentation for using tomcat with systemd   |
|62048|New|Enh|2018-01-25|Missing logout function in Manager and Host-Manage|
|62072|New|Enh|2018-02-01|Add support for request compression   |
|62140|New|Enh|2018-02-27|catalina.sh should document the verbs it accepts a|
|62312|New|Enh|2018-04-18|Add Proxy Authentication support to websocket clie|
|62405|New|Enh|2018-05-23|Add Rereadable Request Filter |
|62488|New|Enh|2018-06-25|Obtain dependencies from Maven Central where possi|
|62611|New|Enh|2018-08-09|Compress log files after rotation |
|62695|Inf|Nor|2018-09-07|Provide sha512 checksums for Tomcat releases publi|
|62723|New|Enh|2018-09-14|Clarify "channelSendOptions" value in cluster docu|
|62773|New|Enh|2018-09-28|Change DeltaManager to handle session deserializat|
|62814|New|Enh|2018-10-10|Use readable names for cluster channel/map options|
|62843|New|Enh|2018-10-22|Tomcat Russian localization   |
|62920|New|Enh|2018-11-17|Maven Plugin For Tomcat 9.0.x |
|62964|New|Enh|2018-11-29|Add RFC7807 conformant Problem Details for HTTP st|
|63023|New|Enh|2018-12-20|Provide a way to load SecurityProviders into the s|
|63049|New|Enh|2018-12-31|Add support in system properties override from com|
|63191|Inf|Nor|2019-02-20|RemoteEndpoint.Async#sendText(String, SendHandler)|
|63237|New|Enh|2019-03-06|Consider processing mbeans-descriptors.xml at comp|
|63362|New|Enh|2019-04-18|GlobalRequestProcessor statistics in MBean does no|
|63389|New|Enh|2019-04-27|Enable Servlet Warmup for Containerization|
|63493|New|Enh|2019-06-10|enhancement - add JMX counters to monitor authenti|
|63505|New|Enh|2019-06-14|enhancement - support of stored procedures for Dat|
|63545|New|Enh|2019-07-06|enhancement - add a new pattern attribute for logg|
|63691|New|Enh|2019-08-24|Add a no-op JarScanner|
|63829|New|Maj|2019-10-10|CompressionConfig does compare request header valu|
|63859|New|Reg|2019-10-17|AJP cping/cpong mode failing on Tomcat 9.x|
|63864|New|Enh|2019-10-18|Use new TokenList parser for Http11Processor Trans|
|63867|New|Enh|2019-10-18|Add option for reason phrase  |
+-+---+---+--+--+
| Total   39 bugs   |
+---+

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Bug report for Tomcat 8 [2019/10/20]

[bugzilla]

+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|55243|New|Enh|2013-07-11|Add special search string for nested roles|
|55252|New|Enh|2013-07-12|Separate Ant and command-line wrappers for JspC   |
|55383|New|Enh|2013-08-07|Improve markup and design of Tomcat's HTML pages  |
|9|New|Enh|2013-09-14|UserDatabaseRealm enhacement: may use local JNDI  |
|55675|New|Enh|2013-10-18|Checking and handling invalid configuration option|
|55788|New|Enh|2013-11-16|TagPlugins should key on tag QName rather than imp|
|56166|New|Enh|2014-02-20|Suggestions for exception handling (avoid potentia|
|56398|New|Enh|2014-04-11|Support Arquillian-based unit testing |
|56399|New|Enh|2014-04-11|Re-factor request/response recycling so Coyote and|
|56402|New|Enh|2014-04-11|Add support for HTTP Upgrade to AJP components|
|56448|New|Enh|2014-04-23|Implement a robust solution for client initiated S|
|56522|Opn|Enh|2014-05-14|jasper-el 8 does not comply to EL Spec 3.0 regardi|
|56546|New|Enh|2014-05-19|Improve thread trace logging in WebappClassLoader.|
|56713|New|Enh|2014-07-12|Limit time that incoming request waits while webap|
|56890|Inf|Maj|2014-08-26|getRealPath returns null  |
|56966|New|Enh|2014-09-11|AccessLogValve's elapsed time has 15ms precision o|
|57130|New|Enh|2014-10-22|Allow digest.sh to accept password from a file or |
|57421|New|Enh|2015-01-07|Farming default directories   |
|57486|New|Enh|2015-01-23|Improve reuse of ProtectedFunctionMapper instances|
|57701|New|Enh|2015-03-13|Implement "[Redeploy]" button for a web applicatio|
|57830|New|Enh|2015-04-18|Add support for ProxyProtocol |
|58052|Opn|Enh|2015-06-19|RewriteValve: Implement additional RewriteRule dir|
|58072|New|Enh|2015-06-23|ECDH curve selection  |
|58577|New|Enh|2015-11-03|JMX Proxy Servlet can't handle overloaded methods |
|58837|New|Enh|2016-01-12|support "X-Content-Security-Policy" a.k.a as "CSP"|
|58935|Opn|Enh|2016-01-29|Re-deploy from war without deleting context   |
|59232|New|Enh|2016-03-24|Make the context name of an app available via JNDI|
|59423|New|Enh|2016-05-03|amend "No LoginModules configured for ..." with hi|
|59758|New|Enh|2016-06-27|Add http proxy username-password credentials suppo|
|60281|Ver|Nor|2016-10-20|Pathname of uploaded WAR file should not be contai|
|60721|Ver|Nor|2017-02-10|Unable to find key spec if more applications use b|
|60781|New|Nor|2017-02-27|Access Log Valve does not escape the same as mod_l|
|60849|New|Enh|2017-03-13|Tomcat NIO Connector not able to handle SSL renego|
|61668|Ver|Min|2017-10-26|Possible NullPointerException in org.apache.coyote|
|61877|New|Enh|2017-12-08|use web.xml from CATALINA_HOME by default |
|61917|New|Enh|2017-12-19|AddDefaultCharsetFilter only supports text/* respo|
|62150|New|Enh|2018-03-01|Behavior of relative paths with RequestDispatcher |
|62214|New|Enh|2018-03-22|The "userSubtree=true" and "roleSubtree=true" in J|
|62245|New|Enh|2018-04-02|[Documentation] Mention contextXsltFile in Default|
|62912|New|Enh|2018-11-15|Tomcat adds a space character in the Content-Type |
|63080|New|Enh|2019-01-16|Support rfc7239 Forwarded header  |
|63195|Inf|Enh|2019-02-21|Add easy way to test RemoteIpValve works properly |
|63286|New|Enh|2019-03-25|Inconsistencies between AccessLogValve and mod_log|
|63681|New|Enh|2019-08-21|Introduce RealmBase#authenticate(GSSName, GSSCrede|
|63802|New|Cri|2019-10-04|epoll spin detection is missing   |
|63815|New|Nor|2019-10-08|Expansion of JAVA_OPTS in catalina.sh containing '|
|63826|New|Enh|2019-10-09|Don't deliver libtcnative and Commons Daemon tarba|
|63828|New|Enh|2019-10-10|Allow WebdavServlet to serve only a subset of a We|
|63830|New|Min|2019-10-10|Tests in org.apache.coyote.http2.TestHttp2Limits f|
|63831|New|Nor|2019-10-10|Tests in org.apache.coyote.http2.TestHttp2InitialC|
|63835|New|Enh|2019-10-11|Add support for Keep-Alive header |

Bug report for Tomcat Connectors [2019/10/20]

[bugzilla]

+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|46767|New|Enh|2009-02-25|mod_jk to send DECLINED in case no fail-over tomca|
|47327|New|Enh|2009-06-07|Return tomcat authenticated user back to mod_jk (A|
|47750|New|Maj|2009-08-27|ISAPI: Loss of worker settings when changing via j|
|48830|New|Nor|2010-03-01|IIS shutdown blocked in endpoint service when serv|
|49822|New|Enh|2010-08-25|Add hash lb worker method |
|49903|New|Enh|2010-09-09|Make workers file reloadable  |
|52483|New|Enh|2012-01-18|Print JkOptions's options in log file and jkstatus|
|54621|New|Enh|2013-02-28|[PATCH] custom mod_jk availability checks |
|56489|New|Enh|2014-05-05|Include a directory for configuration files   |
|56576|New|Enh|2014-05-29|Websocket support |
|57402|New|Enh|2014-12-30|Provide correlation ID between mod_jk log and acce|
|57403|New|Enh|2014-12-30|Persist configuration changes made via status work|
|57407|New|Enh|2014-12-31|Make session_cookie, session_path and session_cook|
|57790|New|Enh|2015-04-03|Check worker names for typos  |
|61476|New|Enh|2017-09-01|Allow reset of an individual worker stat value|
|61621|New|Enh|2017-10-15|Content-Type is forced to lowercase when it goes t|
|62093|New|Enh|2018-02-09|Allow use_server_errors to apply to specific statu|
|63214|New|Nor|2019-02-27|Using JkAutoAlias, Filenames with Spaces Cannot be|
|63808|Opn|Enh|2019-10-05|the fact that JkMount makes other directives ineff|
+-+---+---+--+--+
| Total   19 bugs   |
+---+

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Bug report for Tomcat Modules [2019/10/20]

[bugzilla]

+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|50571|Inf|Nor|2011-01-11|Tomcat 7 JDBC connection pool exception enhancemen|
|51595|Inf|Nor|2011-08-01|org.apache.tomcat.jdbc.pool.jmx.ConnectionPool sho|
|51879|Inf|Enh|2011-09-22|Improve access to Native Connection Methods   |
|52024|Inf|Enh|2011-10-13|Custom interceptor to support automatic failover o|
|53199|Inf|Enh|2012-05-07|Refactor ConnectionPool to use ScheduledExecutorSe|
|54437|New|Enh|2013-01-16|Update PoolProperties javadoc for ConnectState int|
|54929|Inf|Nor|2013-05-05|jdbc-pool cannot be used with Java 1.5, "java.lang|
|55078|New|Nor|2013-06-07|Configuring a DataSource Resource with dataSourceJ|
|55662|New|Enh|2013-10-17|Add a way to set an instance of java.sql.Driver di|
|56046|New|Enh|2014-01-21|org.apache.tomcat.jdbc.pool.XADataSource InitSQL p|
|56088|New|Maj|2014-01-29|AbstractQueryReport$StatementProxy throws exceptio|
|56310|Inf|Maj|2014-03-25|PooledConnection and XAConnection not handled corr|
|56586|New|Nor|2014-06-02|initSQL should be committed if defaultAutoCommit =|
|56775|New|Nor|2014-07-28|PoolCleanerTime schedule issue|
|56779|New|Nor|2014-07-28|Allow multiple connection initialization statement|
|56790|New|Nor|2014-07-29|Resizing pool.maxActive to a higher value at runti|
|56798|New|Nor|2014-07-31|Idle eviction strategy could perform better (and i|
|56804|New|Nor|2014-08-02|Use a default validationQueryTimeout other than "f|
|56805|New|Nor|2014-08-02|datasource.getConnection() may be unnecessarily bl|
|56837|New|Nor|2014-08-11|if validationQuery have error with timeBetweenEvic|
|56970|New|Nor|2014-09-11|MaxActive vs. MaxTotal for commons-dbcp and tomcat|
|57460|New|Nor|2015-01-19|[DB2]Connection broken after few hours but not rem|
|57729|New|Enh|2015-03-20|Add QueryExecutionReportInterceptor to log query e|
|58489|Opn|Maj|2015-10-08|QueryStatsComparator throws IllegalArgumentExcepti|
|59077|New|Nor|2016-02-26|DataSourceFactory creates a neutered data source  |
|59569|New|Nor|2016-05-18|isWrapperFor/unwrap implementations incorrect |
|59879|New|Nor|2016-07-18|StatementCache interceptor returns ResultSet objec|
|60195|New|Nor|2016-10-02|No javadoc in Maven Central   |
|60522|New|Nor|2016-12-27|An option for setting if the transaction should be|
|60524|Inf|Nor|2016-12-28|NPE in SlowQueryReport in tomcat-jdbc-7.0.68  |
|60645|New|Nor|2017-01-25|StatementFinalizer is not thread-safe |
|61032|New|Nor|2017-04-24|min pool size is not being respected  |
|61103|New|Nor|2017-05-18|StatementCache potentially caching non-functional |
|61302|New|Enh|2017-07-15|Refactoring of DataSourceProxy|
|61303|New|Enh|2017-07-15|Refactoring of ConnectionPool |
|62432|New|Nor|2018-06-06|Memory Leak in Statement Finalizer?   |
|62598|New|Enh|2018-08-04|support pool with multiple JDBC data sources  |
|62910|Inf|Nor|2018-11-15|tomcat-jdbc global pool transaction problem   |
|63612|Inf|Cri|2019-07-26|PooledConnection#connectUsingDriver, Thread.curren|
|63705|New|Nor|2019-08-29|The tomcat pool doesn't register all connection th|
+-+---+---+--+--+
| Total   40 bugs   |
+---+

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Bug report for Tomcat Native [2019/10/20]

[bugzilla]

+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|53940|New|Enh|2012-09-27|Added support for new CRL loading after expiration|
|62626|New|Nor|2018-08-15|Tomcat 9.0.10 APR/Native crashes  |
|62911|New|Enh|2018-11-15|Add support for proxying ocsp  requests via ProxyH|
|63199|Inf|Nor|2019-02-22|sslsocket handshake JVM crash |
|63405|New|Nor|2019-05-06|Tomcat 7.0.91.0 EXCEPTION_ACCESS_VIOLATION - Probl|
|63671|New|Nor|2019-08-19|libtcnative does not compile with OpenSSL < 1.1.0 |
|63701|Inf|Maj|2019-08-27|SSL initialize hangs with OpenSSL 1.1.1   |
+-+---+---+--+--+
| Total7 bugs   |
+---+

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Bug report for Tomcat 7 [2019/10/20]

[bugzilla]

+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
|50944|Ver|Blk|2011-03-18|JSF: java.lang.NullPointerException at com.sun.fac|
|53620|New|Enh|2012-07-30|[juli] delay opening a file until something gets l|
|55104|New|Enh|2013-06-16|Allow passing arguments with spaces to Commons Dae|
|55470|New|Enh|2013-08-23|Help users for ClassNotFoundExceptions during star|
|55477|New|Enh|2013-08-23|Add a solution to map an realm name to a security |
|56148|New|Enh|2014-02-17|support (multiple) ocsp stapling  |
|56181|New|Enh|2014-02-23|RemoteIpValve & RemoteIpFilter: HttpServletRequest|
|56300|New|Enh|2014-03-22|[Tribes] No useful examples, lack of documentation|
|56438|New|Enh|2014-04-21|If jar scan does not find context config or TLD co|
|56614|New|Enh|2014-06-12|Add a switch to ignore annotations detection on ta|
|56787|New|Enh|2014-07-29|Simplified jndi name parsing  |
|57367|New|Enh|2014-12-18|If JAR scan experiences a stack overflow, give the|
|57827|New|Enh|2015-04-17|Enable adding/removing of members via jmx in a sta|
|57872|New|Enh|2015-04-29|Do not auto-switch session cookie to version=1 due|
|57892|New|Enh|2015-05-05|Log once a warning if a symbolic link is ignored (|
|60597|New|Enh|2017-01-17|Add ability to set cipher suites for websocket cli|
|63167|New|Enh|2019-02-12|Network Requirements To Resolve No Members Active |
|63833|New|Nor|2019-10-10|NPE in DBCP when attempting to connect to a databa|
|63836|New|Nor|2019-10-11|TestWebdavServletOptions test fails with OutOfMemo|
|63838|New|Enh|2019-10-11|Illegal reflective access by WebappClassLoaderBase|
+-+---+---+--+--+
| Total   20 bugs   |
+---+

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org