RE: [VOTE] Release Apache Tomcat 8.5.57

2020-07-01 Thread George Stanchev 
I ran ant ide-eclipse and the generated project contains a reference to



But D:\work\My Projects\java\Tomcat\8.5.57-src\libraries-download\cglib-3.3.0 
contains only cglib-nodep-3.3.0.jar not cglib-nodep-2.2.2.jar. Not sure if I 
did something wrong…The resulting eclipse project of course complains from 
unsatisfied dependencies…

George

From: Coty Sutherland 
Sent: Wednesday, July 01, 2020 1:48 PM
To: Tomcat Developers List 
Subject: Re: [VOTE] Release Apache Tomcat 8.5.57

On Tue, Jun 30, 2020 at 6:14 PM Mark Thomas 
mailto:ma...@apache.org>> wrote:
The proposed Apache Tomcat 8.5.57 release is now available for voting.

The notable changes compared to the 8.5.56 release are:

- Implement a significant portion of the TLS environment variables
  for the rewrite valve.

- Reduce memory footprint of closed HTTP/2 streams

- Improve parsing of RFC 2109 cookies

Along with lots of other bug fixes and improvements.

For full details, see the changelog:
https://ci.apache.org/projects/tomcat/tomcat85/docs/changelog.html

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.57/

The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1274/

The tag is:
https://github.com/apache/tomcat/tree/8.5.57
9c649984ef92c2534a734c6584220a9a0c0c3462

The proposed 8.5.57 release is:
[ ] Broken - do not release
[x] Stable - go ahead and release as 8.5.57

+1


-
To unsubscribe, e-mail: 
dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: 
dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 8.5.57

2020-07-01 Thread Coty Sutherland 
On Tue, Jun 30, 2020 at 6:14 PM Mark Thomas  wrote:

> The proposed Apache Tomcat 8.5.57 release is now available for voting.
>
> The notable changes compared to the 8.5.56 release are:
>
> - Implement a significant portion of the TLS environment variables
>   for the rewrite valve.
>
> - Reduce memory footprint of closed HTTP/2 streams
>
> - Improve parsing of RFC 2109 cookies
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat85/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.57/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1274/
>
> The tag is:
> https://github.com/apache/tomcat/tree/8.5.57
> 9c649984ef92c2534a734c6584220a9a0c0c3462
>
> The proposed 8.5.57 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 8.5.57
>

+1


> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: [VOTE] Release Apache Tomcat 10.0.0-M7

2020-07-01 Thread Coty Sutherland 
On Tue, Jun 30, 2020 at 2:16 PM Mark Thomas  wrote:

> The proposed Apache Tomcat 10.0.0-M7 release is now available for
> voting.
>
> Apache Tomcat 10.x implements Jakarta EE 9 and, as such, the primary
> package for all the specification APIs has changed from javax.* to
> jakarta.*
> Applications that run on Tomcat 9 will not run on Tomcat 10 without
> changes.
>
> The notable changes compared to 10.0.0-M6 are:
>
> - Implement a significant portion of the TLS environment variables
>   for the rewrite valve.
>
> - Add the Jakarta EE 9 schema.
>
> - Improvements to the creatio of OSGi manifests.
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat10/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.0.0-M7/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1272/
> The tag is:
> https://github.com/apache/tomcat/tree/10.0.0-M7
> c549413165721180b15f62033c1be6c5970028fd
>
> The proposed 10.0.0-M7 release is:
> [ ] Broken - do not release
> [x] Alpha  - go ahead and release as 10.0.0-M7
>

+1


> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: [VOTE] Release Apache Tomcat 9.0.37

2020-07-01 Thread Coty Sutherland 
On Tue, Jun 30, 2020 at 4:41 PM Mark Thomas  wrote:

> The proposed Apache Tomcat 9.0.37 release is now available for voting.
>
> The notable changes compared to the 9.0.36 release are:
>
> - Implement a significant portion of the TLS environment variables
>   for the rewrite valve.
>
> - Improvements to the creation of OSGi manifests.
>
> - Reduce memory footprint of closed HTTP/2 streams
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat9/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.37/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1273/
> The tag is:
> https://github.com/apache/tomcat/tree/9.0.37
> bd68c421ea32fea08263db73cd5b987ab606a0bb
>
> The proposed 9.0.37 release is:
> [ ] Broken - do not release
> [x] Stable - go ahead and release as 9.0.37
>

+1


> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: [VOTE] Release Apache Tomcat 10.0.0-M7

2020-07-01 Thread Martin Grigorov 
On Tue, Jun 30, 2020 at 9:16 PM Mark Thomas  wrote:

> The proposed Apache Tomcat 10.0.0-M7 release is now available for
> voting.
>
> Apache Tomcat 10.x implements Jakarta EE 9 and, as such, the primary
> package for all the specification APIs has changed from javax.* to
> jakarta.*
> Applications that run on Tomcat 9 will not run on Tomcat 10 without
> changes.
>
> The notable changes compared to 10.0.0-M6 are:
>
> - Implement a significant portion of the TLS environment variables
>   for the rewrite valve.
>
> - Add the Jakarta EE 9 schema.
>
> - Improvements to the creatio of OSGi manifests.
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat10/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.0.0-M7/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1272/
> The tag is:
> https://github.com/apache/tomcat/tree/10.0.0-M7
> c549413165721180b15f62033c1be6c5970028fd
>
> The proposed 10.0.0-M7 release is:
> [ ] Broken - do not release
> [ X ] Alpha  - go ahead and release as 10.0.0-M7
>


Regards,
Martin


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: [VOTE] Release Apache Tomcat 8.5.57

2020-07-01 Thread Martin Grigorov 
On Wed, Jul 1, 2020 at 1:14 AM Mark Thomas  wrote:

> The proposed Apache Tomcat 8.5.57 release is now available for voting.
>
> The notable changes compared to the 8.5.56 release are:
>
> - Implement a significant portion of the TLS environment variables
>   for the rewrite valve.
>
> - Reduce memory footprint of closed HTTP/2 streams
>
> - Improve parsing of RFC 2109 cookies
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat85/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.57/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1274/
>
> The tag is:
> https://github.com/apache/tomcat/tree/8.5.57
> 9c649984ef92c2534a734c6584220a9a0c0c3462
>
> The proposed 8.5.57 release is:
> [ ] Broken - do not release
> [ X ] Stable - go ahead and release as 8.5.57
>

Regards,
Martin


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: [VOTE] Release Apache Tomcat 9.0.37

2020-07-01 Thread Martin Grigorov 
On Tue, Jun 30, 2020 at 11:41 PM Mark Thomas  wrote:

> The proposed Apache Tomcat 9.0.37 release is now available for voting.
>
> The notable changes compared to the 9.0.36 release are:
>
> - Implement a significant portion of the TLS environment variables
>   for the rewrite valve.
>
> - Improvements to the creation of OSGi manifests.
>
> - Reduce memory footprint of closed HTTP/2 streams
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat9/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.37/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1273/
> The tag is:
> https://github.com/apache/tomcat/tree/9.0.37
> bd68c421ea32fea08263db73cd5b987ab606a0bb
>
> The proposed 9.0.37 release is:
> [ ] Broken - do not release
> [ X ] Stable - go ahead and release as 9.0.37
>


Regards,
Martin


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

[tomcat] branch 8.5.x updated: Fix typos

2020-07-01 Thread violetagg 
This is an automated email from the ASF dual-hosted git repository.

violetagg pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/8.5.x by this push:
 new 707dfc9  Fix typos
707dfc9 is described below

commit 707dfc988963f3e70a48251f4241d679094d79f2
Author: Violeta Georgieva [VMware] 
AuthorDate: Wed Jul 1 17:57:01 2020 +0300

Fix typos
---
 webapps/docs/changelog.xml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index c155da0..408877e 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -90,7 +90,7 @@
   
   
 64509: Correctly parse RFC 2109 version 1 cookies that use a
-comma as a separater between cookies when using the RFC 6265 cookie
+comma as a separator between cookies when using the RFC 6265 cookie
 processor. Based on a patch by W J Carpenter. (markt)
   
   
@@ -100,7 +100,7 @@
   
   
 Correctly parse RFC 2109 version 1 cookies that have additional linear
-white space around cookie attrubute names and values when using the RFC
+white space around cookie attribute names and values when using the RFC
 6265 cookie processor. (markt)
   
   
@@ -145,7 +145,7 @@
 shell feature that is not available by default on Solaris 10. (markt)
   
   
-64514: Fixes some missing class dependency issus in 
bootstrap
+64514: Fixes some missing class dependency issues in 
bootstrap
 to address packaging/dependency concerns for JPMS and OSGi. Pull 
request
 provided by Raymond Augé. (markt)
   


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch 9.0.x updated: Fix typos

2020-07-01 Thread violetagg 
This is an automated email from the ASF dual-hosted git repository.

violetagg pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/9.0.x by this push:
 new 19ad89e  Fix typos
19ad89e is described below

commit 19ad89e063da0a37999248b145123deaa3c4907f
Author: Violeta Georgieva [VMware] 
AuthorDate: Wed Jul 1 17:57:01 2020 +0300

Fix typos
---
 webapps/docs/changelog.xml | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 2d9b527..65c6ddd 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -94,7 +94,7 @@
   
   
 64509: Correctly parse RFC 2109 version 1 cookies that use a
-comma as a separater between cookies when using the RFC 6265 cookie
+comma as a separator between cookies when using the RFC 6265 cookie
 processor. Based on a patch by W J Carpenter. (markt)
   
   
@@ -104,7 +104,7 @@
   
   
 Correctly parse RFC 2109 version 1 cookies that have additional linear
-white space around cookie attrubute names and values when using the RFC
+white space around cookie attribute names and values when using the RFC
 6265 cookie processor. (markt)
   
   
@@ -164,7 +164,7 @@
 Update the OWB module to Apache OpenWebBeans 2.0.17. (remm)
   
   
-64514: Fixes some missing class dependency issus in 
bootstrap
+64514: Fixes some missing class dependency issues in 
bootstrap
 to address packaging/dependency concerns for JPMS and OSGi. Pull 
request
 provided by Raymond Augé. (markt)
   
@@ -258,7 +258,7 @@
 contains an unexpected request attribute. (markt)
   
   
-64485: Fix possible resource leak geting last modified from
+64485: Fix possible resource leak getting last modified from
 ConfigurationSource.Resource. (remm)
   
 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 8.5.57

2020-07-01 Thread Michael Osipov 

Am 2020-07-01 um 00:14 schrieb Mark Thomas:

The proposed Apache Tomcat 8.5.57 release is now available for voting.

The notable changes compared to the 8.5.56 release are:

- Implement a significant portion of the TLS environment variables
   for the rewrite valve.

- Reduce memory footprint of closed HTTP/2 streams

- Improve parsing of RFC 2109 cookies

Along with lots of other bug fixes and improvements.

For full details, see the changelog:
https://ci.apache.org/projects/tomcat/tomcat85/docs/changelog.html

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.57/

The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1274/

The tag is:
https://github.com/apache/tomcat/tree/8.5.57
9c649984ef92c2534a734c6584220a9a0c0c3462

The proposed 8.5.57 release is:
[ ] Broken - do not release
[X] Stable - go ahead and release as 8.5.57


Passes smoothly on AdoptOpenJDK 8u252 on FreeBSD 12-STABLE.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 8.5.57

2020-07-01 Thread Rémy Maucherat 
On Wed, Jul 1, 2020 at 12:14 AM Mark Thomas  wrote:

> The proposed Apache Tomcat 8.5.57 release is now available for voting.
>
> The notable changes compared to the 8.5.56 release are:
>
> - Implement a significant portion of the TLS environment variables
>   for the rewrite valve.
>
> - Reduce memory footprint of closed HTTP/2 streams
>
> - Improve parsing of RFC 2109 cookies
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat85/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.57/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1274/
>
> The tag is:
> https://github.com/apache/tomcat/tree/8.5.57
> 9c649984ef92c2534a734c6584220a9a0c0c3462
>
> The proposed 8.5.57 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.5.57
>
> Rémy

Re: [VOTE] Release Apache Tomcat 9.0.37

2020-07-01 Thread Rémy Maucherat 
On Tue, Jun 30, 2020 at 10:41 PM Mark Thomas  wrote:

> The proposed Apache Tomcat 9.0.37 release is now available for voting.
>
> The notable changes compared to the 9.0.36 release are:
>
> - Implement a significant portion of the TLS environment variables
>   for the rewrite valve.
>
> - Improvements to the creation of OSGi manifests.
>
> - Reduce memory footprint of closed HTTP/2 streams
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat9/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.37/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1273/
> The tag is:
> https://github.com/apache/tomcat/tree/9.0.37
> bd68c421ea32fea08263db73cd5b987ab606a0bb
>
> The proposed 9.0.37 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 9.0.37
>
> Rémy

Tag Tomcat 7

2020-07-01 Thread Violeta Georgieva 
Hi,

Tomorrow I'm going to prepare Tomcat 7 for a release/vote.
Please reply here if you need more time for additional fixes.

Thanks,
Violeta

Re: [VOTE] Release Apache Tomcat 8.5.57

2020-07-01 Thread Mark Thomas 
On 30/06/2020 23:14, Mark Thomas wrote:



> The proposed 8.5.57 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.5.57

Unit tests pass for NIO, NIO2 and APR/Native (with 1.2.24) on MacOS,
Windows and Linux.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 9.0.37

2020-07-01 Thread Mark Thomas 
On 30/06/2020 21:41, Mark Thomas wrote:



> The proposed 9.0.37 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 9.0.37

Unit tests pass for NIO, NIO2 and APR/Native (with 1.2.24) on MacOS,
Windows and Linux.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 10.0.0-M7

2020-07-01 Thread Mark Thomas 
On 30/06/2020 19:15, Mark Thomas wrote:



> The proposed 10.0.0-M7 release is:
> [ ] Broken - do not release
> [X] Alpha  - go ahead and release as 10.0.0-M7

Unit tests pass for NIO, NIO2 and APR/Native (with 1.2.24) on MacOS,
Windows and Linux.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 64097] Service loader implementation incomplete

2020-07-01 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=64097

--- Comment #9 from sandeepii...@gmail.com ---


(In reply to Mark Thomas from comment #8)
> You aren't using the EL API from 8.5.51. The EL API you are using suffers
> from this bug. The users list is the place to see help.

Hi Mark, Thanks for your reply. Can you please let me know how can i check that
i am not using EL API from 8.5.51 and so i can update it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 10.0.0-M7

2020-07-01 Thread Rémy Maucherat 
On Tue, Jun 30, 2020 at 8:16 PM Mark Thomas  wrote:

> The proposed Apache Tomcat 10.0.0-M7 release is now available for
> voting.
>
> Apache Tomcat 10.x implements Jakarta EE 9 and, as such, the primary
> package for all the specification APIs has changed from javax.* to
> jakarta.*
> Applications that run on Tomcat 9 will not run on Tomcat 10 without
> changes.
>
> The notable changes compared to 10.0.0-M6 are:
>
> - Implement a significant portion of the TLS environment variables
>   for the rewrite valve.
>
> - Add the Jakarta EE 9 schema.
>
> - Improvements to the creatio of OSGi manifests.
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat10/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.0.0-M7/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1272/
> The tag is:
> https://github.com/apache/tomcat/tree/10.0.0-M7
> c549413165721180b15f62033c1be6c5970028fd
>
> The proposed 10.0.0-M7 release is:
> [ ] Broken - do not release
> [X] Alpha  - go ahead and release as 10.0.0-M7
>
> Rémy

[GitHub] [tomcat] rmaucher commented on pull request #310: Remove extraneous spaces around the colons of the output of the contexts list in the text-based manager

2020-07-01 Thread GitBox 


rmaucher commented on pull request #310:
URL: https://github.com/apache/tomcat/pull/310#issuecomment-652262531


   hostManagerServlet.listitem has the same issue. I agree there doesn't seem 
to be a purpose to using a string here since there's nothing to translate, so 
the best solution is to remove it.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] [tomcat] Holomark edited a comment on pull request #310: Remove extraneous spaces around the colons of the output of the contexts list in the text-based manager

2020-07-01 Thread GitBox 


Holomark edited a comment on pull request #310:
URL: https://github.com/apache/tomcat/pull/310#issuecomment-652226783


   I understand your comment, but I really believe this principle doesn't apply 
here. I may have not made my example clear, I am not trying to bend Tomcat to 
the whims of a plugin.
   
   Here is a sample output from http://localhost:8080/manager/text/list on my 
machine, with a typical Tomcat installation:
   ```
   OK - Listed applications for virtual host [localhost]
   /:running:0:ROOT
   /webstart:running:0:webstart
   /manager:running:0:manager
   /docs:running:0:docs
   ```
   
   Here is the same output, in the context of a French configured system
   ```
   OK - Applications listées pour l''hôte virtuel (virtual host) [localhost]
   / : running : 0 : ROOT
   /webstart : running : 0 : webstart
   /manager : running : 0 : manager
   /docs : running : 0 : docs
   ```
   
   As you can expect, an automated script splits the line on the colons. I 
believe this is a fair assumption, as far as I understand the text-based 
manager _is_ meant to be script-friendly.
   This is not about translation, this is breaking the contract.
   
   Actually I'd say the initial mistake was to put this line with the localized 
strings.
   I was tempted to propose the following correction:
   Those lines [from the 
ManagerServlet](https://github.com/Holomark/tomcat/blob/21d2000c99134b7ec54424ea210cf9b2fd6aae38/java/org/apache/catalina/manager/ManagerServlet.java#L1079)
   ```java
   if (context.getState().isAvailable()) {
   
writer.println(smClient.getString("managerServlet.listitem",
   displayPath,
   "running",
   "" + context.getManager().findSessions().length,
   context.getDocBase()));
   } else {
   
writer.println(smClient.getString("managerServlet.listitem",
   displayPath,
   "stopped",
   "0",
   context.getDocBase()));
   }
   ```
   ... would be tweaked to:
   ```java
   if (context.getState().isAvailable()) {
   writer.println(String.join(":",
   displayPath,
   "running",
   "" + context.getManager().findSessions().length,
   context.getDocBase()));
   } else {
   writer.println(String.join(":",
   displayPath,
   "stopped",
   "0",
   context.getDocBase()));
   ```
   ... and the `managerServlet.listitem` line in LocalStrings_xx.properties 
removed (It is not used elsewhere).
   
   I stepped back and proposed only a correction that seemed more innocuous to 
`LocalStrings_fr.properties`, as I have never contributed to this project, and 
barely in any other open source project.
   
   Am I wrong ? I may be missing something.
   
   Thank you for your time.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 64570] New: Transaction not rollbacked if autocommit is false

2020-07-01 Thread bugzilla 
https://bz.apache.org/bugzilla/show_bug.cgi?id=64570

Bug ID: 64570
   Summary: Transaction not rollbacked if autocommit is false
   Product: Tomcat Modules
   Version: unspecified
  Hardware: PC
OS: Linux
Status: NEW
  Severity: normal
  Priority: P2
 Component: jdbc-pool
  Assignee: dev@tomcat.apache.org
  Reporter: ronald.dehuys...@gmail.com
  Target Milestone: ---

Created attachment 37344
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=37344=edit
Packet capturing using wireshark

I think I found a bug in the Tomcat JDBC Pool.

If I start a connection with autoCommit set to false and default autoCommit is
set to true, the active transaction is not rollbacked when the connection is
closed.

I think the bug is located in the terminateTransaction method in the
ConnectionPool class: if one sets the autoCommit manually to false and
afterwards the connection is closed without committing or rollback, the
transaction stays open.

See line 888 of ConnectionPool. 

Code to reproduce:

conn = dataSource.getConnection();
conn.setAutoCommit(false);
ps = conn.prepareStatement(sqlStatement, ResultSet.TYPE_FORWARD_ONLY,
ResultSet.CONCUR_READ_ONLY);
ps.setFetchSize(100);
paramsSetter.accept(ps);
rs = ps.executeQuery();
while(rs.next()) {
 // do something with result
}
rs.close()
ps.close()
conn.close()


=> Postgres connection stays in state: Ready for query (in a transaction)

All other connection pools rollback active transaction on close of connection.


See wireshark capture:
Correct behaviour: packet 2698 -> 2701 (same for commons-dbcp, hikari and c3p0)
Incorrect behaviour: packet 12018 -> missing rollback

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] [tomcat] Holomark commented on pull request #310: Remove extraneous spaces around the colons of the output of the contexts list in the text-based manager

2020-07-01 Thread GitBox 


Holomark commented on pull request #310:
URL: https://github.com/apache/tomcat/pull/310#issuecomment-652226783


   I understand your comment, but I really believe this principle doesn't apply 
here. I may have not made my example clear, I am not trying to bend Tomcat to 
the whims of a plugin.
   
   Here is a sample output from http://localhost:8080/manager/text/list on my 
machine, with a typical Tomcat installation:
   ```
   OK - Listed applications for virtual host [localhost]
   /:running:0:ROOT
   /webstart:running:0:webstart
   /manager:running:0:manager
   /docs:running:0:docs
   ```
   
   Here is the same output, in the context of a French configured system
   ```
   OK - Applications listées pour l''hôte virtuel (virtual host) [localhost]
   / : running : 0 : ROOT
   /webstart : running : 0 : webstart
   /manager : running : 0 : manager
   /docs : running : 0 : docs
   ```
   
   As you can expect, an automated script splits the line on the colons. I 
believe this is a fair assumption. 
   This is not about translation, this is breaking the contract.
   
   Actually I'd say the initial mistake was to put this line with the localized 
strings.
   I was tempted to propose the following correction:
   Those lines [from the 
ManagerServlet](https://github.com/Holomark/tomcat/blob/21d2000c99134b7ec54424ea210cf9b2fd6aae38/java/org/apache/catalina/manager/ManagerServlet.java#L1079)
   ```java
   if (context.getState().isAvailable()) {
   
writer.println(smClient.getString("managerServlet.listitem",
   displayPath,
   "running",
   "" + context.getManager().findSessions().length,
   context.getDocBase()));
   } else {
   
writer.println(smClient.getString("managerServlet.listitem",
   displayPath,
   "stopped",
   "0",
   context.getDocBase()));
   }
   ```
   ... would be tweaked to:
   ```java
   if (context.getState().isAvailable()) {
   writer.println(String.join(":",
   displayPath,
   "running",
   "" + context.getManager().findSessions().length,
   context.getDocBase()));
   } else {
   writer.println(String.join(":",
   displayPath,
   "stopped",
   "0",
   context.getDocBase()));
   ```
   ... and the `managerServlet.listitem` line in LocalStrings_xx.properties 
removed (It is not used elsewhere).
   
   I stepped back and proposed only a correction that seemed more innocuous to 
`LocalStrings_fr.properties`, as I have never contributed to this project, and 
barely in any other open source project.
   
   Am I wrong ? I may be missing something.
   
   Thank you for your time.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org