[Bug 65301] New: the enableLookups configuration is not fully active

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=65301

Bug ID: 65301
   Summary: the enableLookups configuration is not fully active
   Product: Tomcat 9
   Version: 9.0.41
  Hardware: PC
OS: Linux
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
  Assignee: dev@tomcat.apache.org
  Reporter: wan...@bonree.com
  Target Milestone: -

Created attachment 37857
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=37857&action=edit
key line

when I use org.apache.catalina.valves.RemoteIpValve to get real protocol from
"X-Forwarded-Proto", sometimes it take too many times to search local machine
hostname.

the thread dump as follows :
"http-nio-8080-exec-1" #85 daemon prio=5 os_prio=0 tid=0x7f0ef8fdd000
nid=0x79 runnable [0x7f0e8d1d4000]
   java.lang.Thread.State: RUNNABLE
at java.net.Inet4AddressImpl.getHostByAddr(Native Method)
at java.net.InetAddress$2.getHostByAddr(InetAddress.java:932)
at java.net.InetAddress.getHostFromNameService(InetAddress.java:617)
at java.net.InetAddress.getHostName(InetAddress.java:559)
at java.net.InetAddress.getHostName(InetAddress.java:531)
at
org.apache.tomcat.util.net.NioEndpoint$NioSocketWrapper.populateLocalName(NioEndpoint.java:1354)
at
org.apache.tomcat.util.net.SocketWrapperBase.getLocalName(SocketWrapperBase.java:275)
at
org.apache.coyote.AbstractProcessor.action(AbstractProcessor.java:472)
at org.apache.coyote.Request.action(Request.java:432)
at
org.apache.catalina.connector.Request.getLocalName(Request.java:1331)
at
org.apache.catalina.valves.RemoteIpValve.invoke(RemoteIpValve.java:612)

when I see org.apache.catalina.valves.RemoteIpValve in tomcat , getLocalName
methord must search ip from machine dnsserver,why this does not check whether
it's(enableLookups) on or not ,like line num 663 in this class.

the methord getLoaclName alawys call dns to search local ip.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] [tomcat] jeanouii commented on pull request #418: DefaultServlet - Strip BOM improvements.

[GitBox]

jeanouii commented on pull request #418:
URL: https://github.com/apache/tomcat/pull/418#issuecomment-838918360


   Moving the PR away from Draft after incorporating feedback


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] [tomcat] jeanouii commented on a change in pull request #418: DefaultServlet - Strip BOM improvements.

[GitBox]

jeanouii commented on a change in pull request #418:
URL: https://github.com/apache/tomcat/pull/418#discussion_r630372233



##
File path: java/org/apache/catalina/servlets/DefaultServlet.java
##
@@ -335,8 +344,15 @@ public void init() throws ServletException {
 }
 }
 
-if (getServletConfig().getInitParameter("useBomIfPresent") != null) {
-useBomIfPresent = 
Boolean.parseBoolean(getServletConfig().getInitParameter("useBomIfPresent"));
+final String useBomIfPresentConfig = 
getServletConfig().getInitParameter("useBomIfPresent");
+if (useBomIfPresentConfig != null) {
+if (!Arrays.asList("true", "false", 
"pass-through").contains(useBomIfPresentConfig)) {

Review comment:
   I made it such as it's fully backward compatible from a suer perspective 
and according to the discussions on the list. So we should be good in that 
regard.
   
   @martin-g All good to me. All feedback always welcome




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 62150] Behavior of relative paths with RequestDispatcher has changed

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=62150

Mark Thomas  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|NEW |RESOLVED

--- Comment #8 from Mark Thomas  ---
Reviewing this, I am resolving it as WONTFIX.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 58837] support "X-Content-Security-Policy" a.k.a as "CSP"

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=58837

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #9 from Mark Thomas  ---
The mod_headers like component has had some interest lately. The new issue has
more up to date info.

*** This bug has been marked as a duplicate of bug 65267 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 65267] Implement mod_headers like filter

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=65267

Mark Thomas  changed:

   What|Removed |Added

 CC||hau...@acm.org

--- Comment #2 from Mark Thomas  ---
*** Bug 58837 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 55383] Improve markup and design of Tomcat's HTML pages

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=55383

Mark Thomas  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #56 from Mark Thomas  ---
This was completed for 8.5.x onwards. It had been left open as it had not been
addressed for 7.0.x. Now 7.0.x is EOL (without this issue being addressed) I am
marking this issue as resolved.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] [tomcat] jeanouii commented on a change in pull request #418: DefaultServlet - Strip BOM improvements.

[GitBox]

jeanouii commented on a change in pull request #418:
URL: https://github.com/apache/tomcat/pull/418#discussion_r630184741



##
File path: java/org/apache/catalina/servlets/DefaultServlet.java
##
@@ -335,8 +344,15 @@ public void init() throws ServletException {
 }
 }
 
-if (getServletConfig().getInitParameter("useBomIfPresent") != null) {
-useBomIfPresent = 
Boolean.parseBoolean(getServletConfig().getInitParameter("useBomIfPresent"));
+final String useBomIfPresentConfig = 
getServletConfig().getInitParameter("useBomIfPresent");
+if (useBomIfPresentConfig != null) {
+if (!Arrays.asList("true", "false", 
"pass-through").contains(useBomIfPresentConfig)) {

Review comment:
   I'll get the changes in and see if I can add more tests.
   Thanks for the quick follow up
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] [tomcat] rmaucher commented on a change in pull request #418: DefaultServlet - Strip BOM improvements.

[GitBox]

rmaucher commented on a change in pull request #418:
URL: https://github.com/apache/tomcat/pull/418#discussion_r630155632



##
File path: java/org/apache/catalina/servlets/DefaultServlet.java
##
@@ -335,8 +344,15 @@ public void init() throws ServletException {
 }
 }
 
-if (getServletConfig().getInitParameter("useBomIfPresent") != null) {
-useBomIfPresent = 
Boolean.parseBoolean(getServletConfig().getInitParameter("useBomIfPresent"));
+final String useBomIfPresentConfig = 
getServletConfig().getInitParameter("useBomIfPresent");
+if (useBomIfPresentConfig != null) {
+if (!Arrays.asList("true", "false", 
"pass-through").contains(useBomIfPresentConfig)) {

Review comment:
   Good point on the compatibility, but the field is private right now in 
DefaultServlet, so it's ok to change to another type. The init-param config 
remains compatible.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] [tomcat] martin-g commented on a change in pull request #418: DefaultServlet - Strip BOM improvements.

[GitBox]

martin-g commented on a change in pull request #418:
URL: https://github.com/apache/tomcat/pull/418#discussion_r630108180



##
File path: java/org/apache/catalina/servlets/DefaultServlet.java
##
@@ -335,8 +344,15 @@ public void init() throws ServletException {
 }
 }
 
-if (getServletConfig().getInitParameter("useBomIfPresent") != null) {
-useBomIfPresent = 
Boolean.parseBoolean(getServletConfig().getInitParameter("useBomIfPresent"));
+final String useBomIfPresentConfig = 
getServletConfig().getInitParameter("useBomIfPresent");
+if (useBomIfPresentConfig != null) {
+if (!Arrays.asList("true", "false", 
"pass-through").contains(useBomIfPresentConfig)) {

Review comment:
   What do you suggest, @rmaucher ?!
   Should I avoid commenting the minor things until the PR is merged ?
   
   I have approved the PR - that means that overall it looks good to me!
   
   I am not sure about the API break (from `boolean` to `String`) but the 
public part of the Tomcat API is very blur to me so I leave this to more 
experienced Tomcat developers.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] [tomcat] rmaucher commented on a change in pull request #418: DefaultServlet - Strip BOM improvements.

[GitBox]

rmaucher commented on a change in pull request #418:
URL: https://github.com/apache/tomcat/pull/418#discussion_r630072656



##
File path: java/org/apache/catalina/servlets/DefaultServlet.java
##
@@ -335,8 +344,15 @@ public void init() throws ServletException {
 }
 }
 
-if (getServletConfig().getInitParameter("useBomIfPresent") != null) {
-useBomIfPresent = 
Boolean.parseBoolean(getServletConfig().getInitParameter("useBomIfPresent"));
+final String useBomIfPresentConfig = 
getServletConfig().getInitParameter("useBomIfPresent");
+if (useBomIfPresentConfig != null) {
+if (!Arrays.asList("true", "false", 
"pass-through").contains(useBomIfPresentConfig)) {

Review comment:
   I think the important part in this sort of PR is the functionality and 
associated testing. There is always a round of polish afterwards these days.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] [tomcat] martin-g commented on a change in pull request #418: DefaultServlet - Strip BOM improvements.

[GitBox]

martin-g commented on a change in pull request #418:
URL: https://github.com/apache/tomcat/pull/418#discussion_r630065973



##
File path: java/org/apache/catalina/servlets/DefaultServlet.java
##
@@ -335,8 +344,15 @@ public void init() throws ServletException {
 }
 }
 
-if (getServletConfig().getInitParameter("useBomIfPresent") != null) {
-useBomIfPresent = 
Boolean.parseBoolean(getServletConfig().getInitParameter("useBomIfPresent"));
+final String useBomIfPresentConfig = 
getServletConfig().getInitParameter("useBomIfPresent");
+if (useBomIfPresentConfig != null) {
+if (!Arrays.asList("true", "false", 
"pass-through").contains(useBomIfPresentConfig)) {

Review comment:
   The list could be extracted to a constant of type `Set`. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 9.0.46

[jean-frederic clere]

On 08/05/2021 20:14, Mark Thomas wrote:

[X] Stable - go ahead and release as 9.0.46


Tested on fedora34 looks OK.

--
Cheers

Jean-Frederic

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: JSTL issue

[Jean-Louis MONTEIRO]

Hi,

I went ahead and pull the code into a draft PR.
I'd appreciate any feedback or guidance.

https://github.com/apache/tomcat/pull/418

Lemme know if that's ok.
I believe I should maybe open something in the bug tracker?

Thanks

Le mer. 5 mai 2021 à 16:38, Christopher Schultz <
ch...@christopherschultz.net> a écrit :

> Jean-Louis,
>
> On 5/5/21 09:49, Jean-Louis MONTEIRO wrote:
> > Now that we crossed the finish line with TomEE compatibility, I'd like
> > to give back the BOM changes according to this discussion.
> >
> > I did the updated and created another subclass for
> > DefaultServletEncodingBaseTest
> > image.png
> > Did some fixes around that test to take the changes into account.
> > I'll see if I can get this to fully pass
> >
> > image.png
> >
> > Good news, it's backward compatible as we wanted.
> > I may post if I need some help or guidance.
> >
> > As soon as it's done, I believe we want a bugzilla ticket so I can link
> > it to a PR?
>
> All the images were stripped from the list-posting.
>
> Either Bugzilla or GitHub PR is fine.
>
> -chris
>
> > Le jeu. 15 avr. 2021 à 19:19, Christopher Schultz
> > mailto:ch...@christopherschultz.net>> a
> > écrit :
> >
> > Mark,
> >
> > On 4/15/21 04:57, Mark Thomas wrote:
> >  > If we wanted to address this and provide a way to allow JSTL to
> > have the
> >  > control over the included content required to pass this TCK test
> > then we
> >  > could modify 'useBomIfPresent' as follows:
> >  >
> >  > - true   - no change - remains the default
> >  >
> >  > - false  - no change
> >  >
> >  > - ignore - as current false but does not strip the BoM from the
> > output
> >
> > I might re-name the "ignore" case to "pass-through" to be perfectly
> > clear about what's happening. "Ignore" might be mis-interpreted to
> mean
> > that the BOM would be removed. "Pass-through" makes it clear that the
> > BOM will still be sent IMHO.
> >
> > -chris
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> > 
> > For additional commands, e-mail: dev-h...@tomcat.apache.org
> > 
> >
> >
> >
> > --
> > Jean-Louis
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

-- 
Jean-Louis

[GitHub] [tomcat] jeanouii opened a new pull request #418: DefaultServlet - Strip BOM improvements.

[GitBox]

jeanouii opened a new pull request #418:
URL: https://github.com/apache/tomcat/pull/418


   Draft PR mainly to gather feedback from community


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 10.0.6

[Martin Grigorov]

On Sat, May 8, 2021 at 7:18 PM Mark Thomas  wrote:

> The proposed Apache Tomcat 10.0.6 release is now available for
> voting.
>
> Apache Tomcat 10.x implements Jakarta EE 9 and, as such, the primary
> package for all the specification APIs has changed from javax.* to
> jakarta.*
>
> Applications that run on Tomcat 9 will not run on Tomcat 10 without
> changes. Java EE applications designed for Tomcat 9 and earlier may be
> placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat will
> automatically convert them to Jakarta EE and copy them to the webapps
> directory
>
> The notable changes compared to 10.0.5 are:
>
> - Ensure the correct escaping of attribute values and search filters in
>the JNDIRealm.
>
> - HandlesTypes should include classes that use the specified annotation
>types on fields or methods.
>
> - Refactor the creation of WebSocket end point, decoder and encoder
>instances to be more IoC friendly. Instances are now created via the
>InstanceManager where possible.
>
> Along with lots of other bug fixes and improvements.
>
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat10/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.0.6/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1309
> The tag is:
> https://github.com/apache/tomcat/tree/10.0.6
> f725f57f195de035a5cbc6602a1f7a3ad43ee5b5
>
> The proposed 10.0.6 release is:
> [ ] Broken - do not release
> [ X ] Stable - go ahead and release as 10.0.6 (stable)
>

Regards,
Martin


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: [VOTE] Release Apache Tomcat 9.0.46

[Martin Grigorov]

On Sat, May 8, 2021 at 9:15 PM Mark Thomas  wrote:

> The proposed Apache Tomcat 9.0.46 release is now available for voting.
>
> The notable changes compared to the 9.0.45 release are:
>
> - Ensure the correct escaping of attribute values and search filters in
>the JNDIRealm.
>
> - HandlesTypes should include classes that use the specified annotation
>types on fields or methods.
>
> - Refactor the creation of WebSocket end point, decoder and encoder
>instances to be more IoC friendly. Instances are now created via the
>InstanceManager where possible.
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat9/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.46/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1310/
> The tag is:
> https://github.com/apache/tomcat/tree/9.0.46
> 37ae42a2996911b9ba6b88e7b0828f855b9d38f6
>
> The proposed 9.0.46 release is:
> [ ] Broken - do not release
> [ X ] Stable - go ahead and release as 9.0.46
>

Regards,
Martin


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: [External] : Re: JDK 17 Early Access build 21 is available

[Rory O'Donnell]

Many thanks Martin!

On 11/05/2021 08:14, Martin Grigorov wrote:

Hi Rory,

Apache Tomcat's build and test pass successfully with JDK 17-ea+21-1866 on
Linux x86_64 and aarch64!

Regards,
Martin

On Mon, May 10, 2021 at 12:04 PM Rory O'Donnell 
wrote:


Hi Mark, **

*OpenJDK 17 Early Access build 21 is now available at
**https://urldefense.com/v3/__https://jdk.java.net/17*__;Kg!!GqivPVa7Brio!JogNHVnQQWpj5snQbaUE82EWY2wKyB4nMUMOX2iQfI92qAABrrvYufVk835ZWWfpVwU$
  


   * These early-access , open-source builds are provided under the
   o GNU General Public License, version 2, with the Classpath
 Exception 

   * Schedule
   o 2021/06/10 Rampdown Phase One
   o 2021/07/15 Rampdown Phase Two
   o 2021/08/05 Initial Release Candidate
   o 2021/08/19 Final Release Candidate
   o 2021/09/14 General Availability

   * JEPs targeted to JDK 17, so far:
   o JEP 356: Enhanced Pseudo-Random Number Generators
 
   o JEP 382: New macOS Rendering Pipeline
 
   o JEP 391: macOS/AArch64 Port 
   o JEP 398: Deprecate the Applet API for Removal
 
   o JEP 410: Remove the Experimental AOT and JIT Compiler
 

   * Release Notes are available at 
https://urldefense.com/v3/__https://jdk.java.net/17/release-notes__;!!GqivPVa7Brio!JogNHVnQQWpj5snQbaUE82EWY2wKyB4nMUMOX2iQfI92qAABrrvYufVk835ZJdLCP4c$
 


   * Changes in recent builds that maybe of interest:
   o Build 21:
   + JDK-8196415: JARs signed with SHA-1 algorithms are
 restricted by default.
   + JDK-8265989: System property for the native character
 encoding name.
   + JDK-8265137: java.util.Random suddenly has new public
 methods nowhere documented.
   # [*Reported by Apache Lucene]*
   o Build 20
   + JDK-8037397: RegEx pattern matching loses character class
 after intersection (&&) operator.
   + JDK-8264208: A new public method that returns the `Charset`
 used in the `Console.
   o Build 19
   + JDK-8228988: AnnotationParser throws NullPointerException on
 incompatible member type.
   # *[Reported by ByteBuddy]*
   + JDK-8258794: Support for CLDR version 39.
   + JDK-8262108: SimpleDateFormat formatting broken for sq_MK
 Locale.
   # *[**Reported by ApacheCommons]*
   o Build 18
   + JDK-8260693: Provide the support for specifying a signer in
 keytool -genkeypair.
   + JDK-8263763: Synthetic constructor parameters of enum are
 not considered for annotation indices.
   # *[Reported by ByteBuddy]*

*Topics of interest from 'Insider Java':*

   * Security and Sandboxing Post SecurityManager : Link
 <
https://urldefense.com/v3/__https://inside.java/2021/04/23/security-and-sandboxing-post-securitymanager/__;!!GqivPVa7Brio!JogNHVnQQWpj5snQbaUE82EWY2wKyB4nMUMOX2iQfI92qAABrrvYufVk835ZUW8e5mk$
   * Foreign Memory Access and NIO channels - Going Further : Link
 


*Project Loom Early-Access Build: **Build 17-loom+6-225*
*(2021/4/1)*

   * These early-access builds are provided under the GNU General Public
 License, version 2, with the Classpath Exception
 .
   * These builds are produced for the purpose of gathering feedback. Use
 for any other purpose is at your own risk.
   * Please send feedback via e-mail to loom-...@openjdk.java.net
 . To send e-mail to this address
 you must first subscribe to the mailing list
 .**

*April 2021 Critical Patch Update Released:*

   * As part of the April 2021 CPU we released JDK 16.0.1, JDK 11.0.11
 LTS, JDK 8u291 and JDK 7u301 as well as OpenJDK 16.0.1 (publicly
 available).

Rgds,Rory

--
Rgds, Rory O'Donnell
Quality Engineering Manager
Oracle EMEA, Dublin, Ireland




--
Rgds, Rory O'Donnell
Quality Engineering Manager
Oracle EMEA, Dublin, Ireland


---

Re: [VOTE] Release Apache Tomcat 8.5.66

[Martin Grigorov]

On Sun, May 9, 2021 at 2:12 AM Mark Thomas  wrote:

> The proposed Apache Tomcat 8.5.66 release is now available for voting.
>
> The notable changes compared to the 8.5.65 release are:
>
> - Ensure the correct escaping of attribute values and search filters in
>the JNDIRealm.
>
> - HandlesTypes should include classes that use the specified annotation
>types on fields or methods.
>
> - Refactor the creation of WebSocket end point, decoder and encoder
>instances to be more IoC friendly. Instances are now created via the
>InstanceManager where possible.
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> https://ci.apache.org/projects/tomcat/tomcat85/docs/changelog.html
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.66/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1311/
>
> The tag is:
> https://github.com/apache/tomcat/tree/8.5.66
> 12afa2cd11ffa9522cd98acc228ecb1bad6b8006
>
> The proposed 8.5.66 release is:
> [ ] Broken - do not release
> [ X ] Stable - go ahead and release as 8.5.66
>

Regards,
Martin


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: Disabling Some Test Cases by Pattern

[Martin Grigorov]

Hi Igal,

On Mon, May 10, 2021 at 4:28 AM Igal Sapir  wrote:

> I am trying to disable some test cases that constantly fail on my machine.
> I have added the following to build.properties:
>
>
> test.exclude=org.apache.catalina.tribes.group.Test**,org.apache.catalina.tribes.group.interceptors.Test**
>
> But I still get the following failures:
>
>[concat] Testsuites with failed tests:
>[concat]
>
> TEST-org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.NIO2.txt
>[concat]
>
> TEST-org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.NIO2.txt
>[concat]
>
> TEST-org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.NIO2.txt
>[concat]
>
> TEST-org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.NIO2.txt
>
> I expect the pattern [org.apache.catalina.tribes.group.interceptors.Test**]
> to exclude the last 3 for example, but that doesn't happen.
>
> What am I doing wrong?
>

Looking at
https://github.com/apache/tomcat/blob/9747a3a6334369deb9b5bef1b17b1fe0ce774cdf/build.xml#L2024-L2039
I think you should use '/' instead of '.',
i.e.
test.exclude=org/apache/catalina/tribes/group/Test*,org/apache/catalina/tribes/group/interceptors/Test*


>
> Thanks,
>
> Igal
>

Re: JDK 17 Early Access build 21 is available

[Martin Grigorov]

Hi Rory,

Apache Tomcat's build and test pass successfully with JDK 17-ea+21-1866 on
Linux x86_64 and aarch64!

Regards,
Martin

On Mon, May 10, 2021 at 12:04 PM Rory O'Donnell 
wrote:

>
> Hi Mark, **
>
> *OpenJDK 17 Early Access build 21 is now available at
> **https://jdk.java.net/17* 
>
>   * These early-access , open-source builds are provided under the
>   o GNU General Public License, version 2, with the Classpath
> Exception 
>
>   * Schedule
>   o 2021/06/10 Rampdown Phase One
>   o 2021/07/15 Rampdown Phase Two
>   o 2021/08/05 Initial Release Candidate
>   o 2021/08/19 Final Release Candidate
>   o 2021/09/14 General Availability
>
>   * JEPs targeted to JDK 17, so far:
>   o JEP 356: Enhanced Pseudo-Random Number Generators
> 
>   o JEP 382: New macOS Rendering Pipeline
> 
>   o JEP 391: macOS/AArch64 Port 
>   o JEP 398: Deprecate the Applet API for Removal
> 
>   o JEP 410: Remove the Experimental AOT and JIT Compiler
> 
>
>   * Release Notes are available at https://jdk.java.net/17/release-notes
> 
>
>   * Changes in recent builds that maybe of interest:
>   o Build 21:
>   + JDK-8196415: JARs signed with SHA-1 algorithms are
> restricted by default.
>   + JDK-8265989: System property for the native character
> encoding name.
>   + JDK-8265137: java.util.Random suddenly has new public
> methods nowhere documented.
>   # [*Reported by Apache Lucene]*
>   o Build 20
>   + JDK-8037397: RegEx pattern matching loses character class
> after intersection (&&) operator.
>   + JDK-8264208: A new public method that returns the `Charset`
> used in the `Console.
>   o Build 19
>   + JDK-8228988: AnnotationParser throws NullPointerException on
> incompatible member type.
>   # *[Reported by ByteBuddy]*
>   + JDK-8258794: Support for CLDR version 39.
>   + JDK-8262108: SimpleDateFormat formatting broken for sq_MK
> Locale.
>   # *[**Reported by ApacheCommons]*
>   o Build 18
>   + JDK-8260693: Provide the support for specifying a signer in
> keytool -genkeypair.
>   + JDK-8263763: Synthetic constructor parameters of enum are
> not considered for annotation indices.
>   # *[Reported by ByteBuddy]*
>
> *Topics of interest from 'Insider Java':*
>
>   * Security and Sandboxing Post SecurityManager : Link
> <
> https://inside.java/2021/04/23/security-and-sandboxing-post-securitymanager/
> >
>   * Foreign Memory Access and NIO channels - Going Further : Link
> 
>
> *Project Loom Early-Access Build: **Build 17-loom+6-225*
> *(2021/4/1)*
>
>   * These early-access builds are provided under the GNU General Public
> License, version 2, with the Classpath Exception
> .
>   * These builds are produced for the purpose of gathering feedback. Use
> for any other purpose is at your own risk.
>   * Please send feedback via e-mail to loom-...@openjdk.java.net
> . To send e-mail to this address
> you must first subscribe to the mailing list
> .**
>
> *April 2021 Critical Patch Update Released:*
>
>   * As part of the April 2021 CPU we released JDK 16.0.1, JDK 11.0.11
> LTS, JDK 8u291 and JDK 7u301 as well as OpenJDK 16.0.1 (publicly
> available).
>
> Rgds,Rory
>
> --
> Rgds, Rory O'Donnell
> Quality Engineering Manager
> Oracle EMEA, Dublin, Ireland
>
>