[Bug 66076] Final block of encrypted response payload not being sent occasionally over TLS

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=66076

--- Comment #6 from Phil Clay  ---
Perfect.

Also note, my project uses embedded tomcat.  Specifically these three
artifacts:

org.apache.tomcat.embed:tomcat-embed-core
org.apache.tomcat.embed:tomcat-embed-el
org.apache.tomcat.embed:tomcat-embed-websocket

I assume the build will produce everything, but just wanted to be clear what
I'm using.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 66076] Final block of encrypted response payload not being sent occasionally over TLS

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=66076

--- Comment #5 from Mark Thomas  ---
Great. I'll do a dev build for you. It isn't that tricky but I am all set up
for it.

I think I know what the problem is. I should have something for you to test on
Monday.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 66076] Final block of encrypted response payload not being sent occasionally over TLS

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=66076

--- Comment #4 from Phil Clay  ---
> Once we have a potential fix, are you in a position to either builds Tomcat 
> 9.0.x yourself from source and/or test a 9.0.x dev build I provide for you?

Yes, Definitely!  I'd prefer a dev build to be provided if possible, but I'm
sure I could spend some time to build it myself if needed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[GitHub] [tomcat] zisding commented on pull request #514: Registry gives inaccurate log message saying "Creating MBeanServer ... " after already created the MBeanServer

[GitBox]

zisding commented on PR #514:
URL: https://github.com/apache/tomcat/pull/514#issuecomment-1133097834

   Hi Mark, @markt-asf 
   
   Thanks for merging the PR. Really hope my contribution can make Tomcat more 
perfect, even if it is incremental. 
   
   Based on the feedback, I further reviewed some source code and logging 
messages and found the following  inaccurate expression of the relation between 
the logging statement and its corresponding action in the source code. 
Meanwhile, I also proposed some suggestions. Could you please help me figure 
out whether they are appropriate or not? I can make a PR later.
   
   1.  Logging statement: 
https://github.com/apache/tomcat/blob/b78d415754b8d9c3160f84c111a993533568e8df/java/org/apache/catalina/session/DataSourceStore.java#L537
 
   Suggestion: Change `Removing` to `Removed` in the localstrings,  
`dataSourceStore.removing=Removing Session [{0}] at database [{1}]`
   Reason: as the logging statement is placed at the end of the function 
`remove()` indicting the function has been successfully executed.
   2. Logging statement: 
https://github.com/apache/tomcat/blob/b78d415754b8d9c3160f84c111a993533568e8df/java/org/apache/catalina/valves/RequestFilterValve.java/#L383
 
   Suggestion: Change `Denied` to `Denying` in the localstrings, 
`requestFilterValve.deny=Denied request for [{0}] based on property [{1}]`
   Reason:  the logging statement is placed before the target function 
`denyRequest()` indicting the function will be executed.
   3. Logging statement: 
https://github.com/apache/tomcat/blob/b78d415754b8d9c3160f84c111a993533568e8df/java/org/apache/catalina/realm/JAASRealm.java/#L569
 
   Suggestion: Change `Adding` to `Added` in the localstrings, 
`jaasRealm.rolePrincipalAdd=Adding role Principal [{0}] to this user 
Principal''s roles`,
   Reason:  the logging statement is placed after the target function `add()` 
indicting the status of `add` is completed.
   4. Logging statement: 
https://github.com/apache/tomcat/blob/b78d415754b8d9c3160f84c111a993533568e8df/java/org/apache/catalina/ha/session/DeltaManager.java/#L1385
   Suggestion: Change `Sent` to `Sending` in the localstrings, 
`deltaManager.createMessage.allSessionData=Manager [{0}] sent all session 
data.`,  
   Reason:  the logging statement is placed before the target function `send()` 
indicting the status of `send` will be executed or in progress.
   5. Logging statement: 
https://github.com/apache/tomcat/blob/0f2e084d1583cfa4c00cec1958ec30113fb4f41e/java/org/apache/coyote/AbstractProtocol.java#L392
   Suggestion: Change `Removed` to `Removing` in the localstrings, 
`abstractProtocol.waitingProcessor.remove=Removed processor [{0}] from waiting 
processors`,  
   Reason:  the logging statement is placed before the target function 
`remove()` indicting the status of `remove` will be executed.
   6. Logging statement: 
https://github.com/apache/tomcat/blob/0f2e084d1583cfa4c00cec1958ec30113fb4f41e/java/org/apache/coyote/http2/Stream.java#L655
   Suggestion: Change `sent ` to `sending` in the localstrings, 
`stream.reset.send=Connection [{0}], Stream [{1}], Reset sent due to [{2}]`,  
   Reason:  the logging statement is placed before the target function 
`sendReset()` indicting the status of `sendReset ` will be executed.
   7. Logging statement: 
https://github.com/apache/tomcat/blob/0f2e084d1583cfa4c00cec1958ec30113fb4f41e/java/org/apache/coyote/http2/Stream.java/#L686
   Suggestion: Change `has been recycled ` to `will be recycled ` in the 
localstrings, `stream.recycle=Connection [{0}], Stream [{1}] has been 
recycled`,  
   Reason:  the logging statement is placed before the target source code 
indicting the status of `recycle ` will be executed or in progress.
   
   Thanks for reviewing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Tomcat embed packaging clarification

[Romain Manni-Bucau]

Le ven. 20 mai 2022 à 12:10, Mark Thomas  a écrit :

> On 20/05/2022 10:36, Romain Manni-Bucau wrote:
> > Hi all,
> >
> > Checking a project with multiple tomcat integrators (spring boot, uship,
> > meecrowave, tomee, ...) I realised Tomcat ecosystem is quite exploded
> with
> > tomcat-embed packaging but I kind of fail to see the benefit from there
> > since using plain tomcat artifacts works well
>
> Not sure I understand your concern. There are a handful of extra JARs in
> the embedded namespace that provide an alternative packaging.
>
> There was a specific user request for the embedded packaging. They
> wanted fewer, larger JARs.
>
> It costs us very little to maintain those JARs.
>

Where I can envision to make it easy to use as a fatjar or something like
that, here embed packaging is kind of duplicating tomcat packaging and I
fail to see any benefit.


>
> > plus embed is still marked as
> > experimental in the build descriptors.
>
> That is an easy fix.
>

not yet, see next ;)


>
> >  From my window it would be great to deprecate embed jar usage,
> potentially
> > make some gap converging with default packaging, and focus on the main
> > packaging only and maybe drop embed one for the final 10.1 but not sure I
> > missed something critical.
>
> Why? What is the benefit of removing that packaging?
>

What does happen when you have tomcat + tomcat-embed in your classpath
because your libraries decided embed was better than default or the
opposite? Luckily it can work but it can also just fail and identifying it
is not always trivial for everyone.

Guess if default distro not full fatjar don't work well enough it can be a
need to integrate in main distribution, this is why I think it should
converge at some point.
That said, relocating embedded artifacts using org.apache.tomcat.embed
would mitigate the issue too and be okish for me too.


>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

[tomcat-native] branch main updated: Update version info

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat-native.git


The following commit(s) were added to refs/heads/main by this push:
 new c283658d9 Update version info
c283658d9 is described below

commit c283658d9782e480606494cc95e313544f04bb6e
Author: Mark Thomas 
AuthorDate: Fri May 20 13:04:58 2022 +0100

Update version info
---
 native/srclib/VERSIONS | 16 +---
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/native/srclib/VERSIONS b/native/srclib/VERSIONS
index 75594db48..32686396b 100644
--- a/native/srclib/VERSIONS
+++ b/native/srclib/VERSIONS
@@ -20,14 +20,15 @@ The minimum version of OpenSSL is driven by the version of 
OpenSSL used by
 downstream distributions.
 
 The current state of OpenSSL in Debian is:
-- OpenSSL 1.1.0l in Debian 9 (EOL in June 2022)
-- OpenSSL 1.1.1d in Debian 10
+- OpenSSL 1.1.0l in Debian 9  (EOL end June 2022)
+- OpenSSL 1.1.1n in Debian 10 (EOL end June 2024)
+- OpenSSL 1.1.1n in Debian 11 (EOL end June 2026)
 
 And in Ubuntu:
 - OpenSSL 1.0.2g in Ubuntu 16.04 LTS (EOL in April 2021)
-- OpenSSL 1.1.1  in Ubuntu 18.04 LTS
-- OpenSSL 1.1.1f in Ubuntu 20.04 LTS
-
+- OpenSSL 1.1.1  in Ubuntu 18.04 LTS (EOL in April 2028)
+- OpenSSL 1.1.1f in Ubuntu 20.04 LTS (EOL in April 2030)
+- OpenSSL 3.0.2  in Ubuntu 22.04 LTS (EOL in April 2032)
 
 The minimum version of APR is driven by the version of APR used by
 downstream distributions.
@@ -38,5 +39,6 @@ The current state of APR in Debian is:
 
 And in Ubuntu:
 - APR 1.5.2 in Ubuntu 16.04 LTS (EOL in April 2021)
-- APR 1.6.3 in Ubuntu 18.04 LTS
-- APR 1.6.5 in Ubuntu 20.04 LTS
+- APR 1.6.3 in Ubuntu 18.04 LTS (EOL in April 2028)
+- APR 1.6.5 in Ubuntu 20.04 LTS (EOL in April 2030)
+- APR 1.7.0 in Ubuntu 22.04 LTS (EOL in April 2032)


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch 8.5.x updated: Increase default buffer size for cluster replication messages

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/8.5.x by this push:
 new e154f15799 Increase default buffer size for cluster replication 
messages
e154f15799 is described below

commit e154f157996aa3e3e63091a13c1d528833119ce8
Author: Mark Thomas 
AuthorDate: Fri May 20 12:05:05 2022 +0100

Increase default buffer size for cluster replication messages
---
 java/org/apache/catalina/tribes/transport/Constants.java | 2 +-
 webapps/docs/changelog.xml   | 9 +
 webapps/docs/config/cluster-receiver.xml | 4 ++--
 webapps/docs/config/cluster-sender.xml   | 4 ++--
 4 files changed, 14 insertions(+), 5 deletions(-)

diff --git a/java/org/apache/catalina/tribes/transport/Constants.java 
b/java/org/apache/catalina/tribes/transport/Constants.java
index fe0515409f..07946d826e 100644
--- a/java/org/apache/catalina/tribes/transport/Constants.java
+++ b/java/org/apache/catalina/tribes/transport/Constants.java
@@ -27,7 +27,7 @@ public class Constants {
 
 public static final String Package = 
"org.apache.catalina.tribes.transport";
 
-public static final int DEFAULT_CLUSTER_MSG_BUFFER_SIZE = 43800;
+public static final int DEFAULT_CLUSTER_MSG_BUFFER_SIZE = 65536;
 public static final int DEFAULT_CLUSTER_ACK_BUFFER_SIZE = 25188;
 
 /*
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 2878a25eea..54a9825630 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -139,6 +139,15 @@
   
 
   
+  
+
+  
+Increase the default buffer size for replication messages from 43800 to
+65536 bytes. This is expected to improve performance for large messages
+when running on Linux based systems. (markt)
+  
+
+  
 
 
   
diff --git a/webapps/docs/config/cluster-receiver.xml 
b/webapps/docs/config/cluster-receiver.xml
index 9bc1b5350d..1533aac59e 100644
--- a/webapps/docs/config/cluster-receiver.xml
+++ b/webapps/docs/config/cluster-receiver.xml
@@ -118,7 +118,7 @@
   Boolean value for the socket OOBINLINE option. Possible values are 
true or false.
 
 
-  The receiver buffer size on the receiving sockets. Value is in bytes, 
the default value is 43800 bytes.
+  The receiver buffer size on the receiving sockets. Value is in bytes, 
the default value is 65536 bytes.
 
 
   The sending buffer size on the receiving sockets. Value is in bytes, the 
default value is 25188 bytes.
@@ -129,7 +129,7 @@
 
 
The send buffer size on the datagram socket.
-   Default value is 43800 bytes.
+   Default value is 65536 bytes.
 
 
   Boolean value for the socket SO_KEEPALIVE option. Possible values are 
true or false.
diff --git a/webapps/docs/config/cluster-sender.xml 
b/webapps/docs/config/cluster-sender.xml
index 66f9707eb0..516a79210b 100644
--- a/webapps/docs/config/cluster-sender.xml
+++ b/webapps/docs/config/cluster-sender.xml
@@ -91,7 +91,7 @@
   
   
The send buffer size on the socket.
-   Default value is 43800 bytes.
+   Default value is 65536 bytes.
   
   
 The receive buffer size on the datagram socket.
@@ -99,7 +99,7 @@
   
   
The send buffer size on the datagram socket.
-   Default value is 43800 bytes.
+   Default value is 65536 bytes.
   
   
Possible values are true or false.


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch 9.0.x updated: Increase default buffer size for cluster replication messages

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/9.0.x by this push:
 new 5e2204c239 Increase default buffer size for cluster replication 
messages
5e2204c239 is described below

commit 5e2204c23999ea6ba0904ec0a10e046aa4d65a34
Author: Mark Thomas 
AuthorDate: Fri May 20 12:05:05 2022 +0100

Increase default buffer size for cluster replication messages
---
 java/org/apache/catalina/tribes/transport/Constants.java | 2 +-
 webapps/docs/changelog.xml   | 9 +
 webapps/docs/config/cluster-receiver.xml | 4 ++--
 webapps/docs/config/cluster-sender.xml   | 4 ++--
 4 files changed, 14 insertions(+), 5 deletions(-)

diff --git a/java/org/apache/catalina/tribes/transport/Constants.java 
b/java/org/apache/catalina/tribes/transport/Constants.java
index fe0515409f..07946d826e 100644
--- a/java/org/apache/catalina/tribes/transport/Constants.java
+++ b/java/org/apache/catalina/tribes/transport/Constants.java
@@ -27,7 +27,7 @@ public class Constants {
 
 public static final String Package = 
"org.apache.catalina.tribes.transport";
 
-public static final int DEFAULT_CLUSTER_MSG_BUFFER_SIZE = 43800;
+public static final int DEFAULT_CLUSTER_MSG_BUFFER_SIZE = 65536;
 public static final int DEFAULT_CLUSTER_ACK_BUFFER_SIZE = 25188;
 
 /*
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index bdc0977b5f..5e6fa49603 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -143,6 +143,15 @@
   
 
   
+  
+
+  
+Increase the default buffer size for replication messages from 43800 to
+65536 bytes. This is expected to improve performance for large messages
+when running on Linux based systems. (markt)
+  
+
+  
 
 
   
diff --git a/webapps/docs/config/cluster-receiver.xml 
b/webapps/docs/config/cluster-receiver.xml
index 9bc1b5350d..1533aac59e 100644
--- a/webapps/docs/config/cluster-receiver.xml
+++ b/webapps/docs/config/cluster-receiver.xml
@@ -118,7 +118,7 @@
   Boolean value for the socket OOBINLINE option. Possible values are 
true or false.
 
 
-  The receiver buffer size on the receiving sockets. Value is in bytes, 
the default value is 43800 bytes.
+  The receiver buffer size on the receiving sockets. Value is in bytes, 
the default value is 65536 bytes.
 
 
   The sending buffer size on the receiving sockets. Value is in bytes, the 
default value is 25188 bytes.
@@ -129,7 +129,7 @@
 
 
The send buffer size on the datagram socket.
-   Default value is 43800 bytes.
+   Default value is 65536 bytes.
 
 
   Boolean value for the socket SO_KEEPALIVE option. Possible values are 
true or false.
diff --git a/webapps/docs/config/cluster-sender.xml 
b/webapps/docs/config/cluster-sender.xml
index 66f9707eb0..516a79210b 100644
--- a/webapps/docs/config/cluster-sender.xml
+++ b/webapps/docs/config/cluster-sender.xml
@@ -91,7 +91,7 @@
   
   
The send buffer size on the socket.
-   Default value is 43800 bytes.
+   Default value is 65536 bytes.
   
   
 The receive buffer size on the datagram socket.
@@ -99,7 +99,7 @@
   
   
The send buffer size on the datagram socket.
-   Default value is 43800 bytes.
+   Default value is 65536 bytes.
   
   
Possible values are true or false.


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch 10.0.x updated: Increase default buffer size for cluster replication messages

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 10.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/10.0.x by this push:
 new 5163b434f2 Increase default buffer size for cluster replication 
messages
5163b434f2 is described below

commit 5163b434f297b50d8753265276330ce6ec1cc997
Author: Mark Thomas 
AuthorDate: Fri May 20 12:05:05 2022 +0100

Increase default buffer size for cluster replication messages
---
 java/org/apache/catalina/tribes/transport/Constants.java | 2 +-
 webapps/docs/changelog.xml   | 9 +
 webapps/docs/config/cluster-receiver.xml | 4 ++--
 webapps/docs/config/cluster-sender.xml   | 4 ++--
 4 files changed, 14 insertions(+), 5 deletions(-)

diff --git a/java/org/apache/catalina/tribes/transport/Constants.java 
b/java/org/apache/catalina/tribes/transport/Constants.java
index fe0515409f..07946d826e 100644
--- a/java/org/apache/catalina/tribes/transport/Constants.java
+++ b/java/org/apache/catalina/tribes/transport/Constants.java
@@ -27,7 +27,7 @@ public class Constants {
 
 public static final String Package = 
"org.apache.catalina.tribes.transport";
 
-public static final int DEFAULT_CLUSTER_MSG_BUFFER_SIZE = 43800;
+public static final int DEFAULT_CLUSTER_MSG_BUFFER_SIZE = 65536;
 public static final int DEFAULT_CLUSTER_ACK_BUFFER_SIZE = 25188;
 
 /*
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 89df868106..e19eb5a48e 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -143,6 +143,15 @@
   
 
   
+  
+
+  
+Increase the default buffer size for replication messages from 43800 to
+65536 bytes. This is expected to improve performance for large messages
+when running on Linux based systems. (markt)
+  
+
+  
 
 
   
diff --git a/webapps/docs/config/cluster-receiver.xml 
b/webapps/docs/config/cluster-receiver.xml
index 3911b69221..461dd6c136 100644
--- a/webapps/docs/config/cluster-receiver.xml
+++ b/webapps/docs/config/cluster-receiver.xml
@@ -114,7 +114,7 @@
   Boolean value for the socket OOBINLINE option. Possible values are 
true or false.
 
 
-  The receiver buffer size on the receiving sockets. Value is in bytes, 
the default value is 43800 bytes.
+  The receiver buffer size on the receiving sockets. Value is in bytes, 
the default value is 65536 bytes.
 
 
   The sending buffer size on the receiving sockets. Value is in bytes, the 
default value is 25188 bytes.
@@ -125,7 +125,7 @@
 
 
The send buffer size on the datagram socket.
-   Default value is 43800 bytes.
+   Default value is 65536 bytes.
 
 
   Boolean value for the socket SO_KEEPALIVE option. Possible values are 
true or false.
diff --git a/webapps/docs/config/cluster-sender.xml 
b/webapps/docs/config/cluster-sender.xml
index a539647071..9411ec7fcb 100644
--- a/webapps/docs/config/cluster-sender.xml
+++ b/webapps/docs/config/cluster-sender.xml
@@ -86,7 +86,7 @@
   
   
The send buffer size on the socket.
-   Default value is 43800 bytes.
+   Default value is 65536 bytes.
   
   
 The receive buffer size on the datagram socket.
@@ -94,7 +94,7 @@
   
   
The send buffer size on the datagram socket.
-   Default value is 43800 bytes.
+   Default value is 65536 bytes.
   
   
Possible values are true or false.


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch main updated: Increase default buffer size for cluster replication messages

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/main by this push:
 new b78d415754 Increase default buffer size for cluster replication 
messages
b78d415754 is described below

commit b78d415754b8d9c3160f84c111a993533568e8df
Author: Mark Thomas 
AuthorDate: Fri May 20 12:05:05 2022 +0100

Increase default buffer size for cluster replication messages
---
 java/org/apache/catalina/tribes/transport/Constants.java | 2 +-
 webapps/docs/changelog.xml   | 9 +
 webapps/docs/config/cluster-receiver.xml | 4 ++--
 webapps/docs/config/cluster-sender.xml   | 4 ++--
 4 files changed, 14 insertions(+), 5 deletions(-)

diff --git a/java/org/apache/catalina/tribes/transport/Constants.java 
b/java/org/apache/catalina/tribes/transport/Constants.java
index fe0515409f..07946d826e 100644
--- a/java/org/apache/catalina/tribes/transport/Constants.java
+++ b/java/org/apache/catalina/tribes/transport/Constants.java
@@ -27,7 +27,7 @@ public class Constants {
 
 public static final String Package = 
"org.apache.catalina.tribes.transport";
 
-public static final int DEFAULT_CLUSTER_MSG_BUFFER_SIZE = 43800;
+public static final int DEFAULT_CLUSTER_MSG_BUFFER_SIZE = 65536;
 public static final int DEFAULT_CLUSTER_ACK_BUFFER_SIZE = 25188;
 
 /*
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 283029c1b5..747b252b3c 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -159,6 +159,15 @@
   
 
   
+  
+
+  
+Increase the default buffer size for replication messages from 43800 to
+65536 bytes. This is expected to improve performance for large messages
+when running on Linux based systems. (markt)
+  
+
+  
 
 
   
diff --git a/webapps/docs/config/cluster-receiver.xml 
b/webapps/docs/config/cluster-receiver.xml
index 3911b69221..461dd6c136 100644
--- a/webapps/docs/config/cluster-receiver.xml
+++ b/webapps/docs/config/cluster-receiver.xml
@@ -114,7 +114,7 @@
   Boolean value for the socket OOBINLINE option. Possible values are 
true or false.
 
 
-  The receiver buffer size on the receiving sockets. Value is in bytes, 
the default value is 43800 bytes.
+  The receiver buffer size on the receiving sockets. Value is in bytes, 
the default value is 65536 bytes.
 
 
   The sending buffer size on the receiving sockets. Value is in bytes, the 
default value is 25188 bytes.
@@ -125,7 +125,7 @@
 
 
The send buffer size on the datagram socket.
-   Default value is 43800 bytes.
+   Default value is 65536 bytes.
 
 
   Boolean value for the socket SO_KEEPALIVE option. Possible values are 
true or false.
diff --git a/webapps/docs/config/cluster-sender.xml 
b/webapps/docs/config/cluster-sender.xml
index a539647071..9411ec7fcb 100644
--- a/webapps/docs/config/cluster-sender.xml
+++ b/webapps/docs/config/cluster-sender.xml
@@ -86,7 +86,7 @@
   
   
The send buffer size on the socket.
-   Default value is 43800 bytes.
+   Default value is 65536 bytes.
   
   
 The receive buffer size on the datagram socket.
@@ -94,7 +94,7 @@
   
   
The send buffer size on the datagram socket.
-   Default value is 43800 bytes.
+   Default value is 65536 bytes.
   
   
Possible values are true or false.


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch 8.5.x updated: Refactor default cluster buffer sizes to use constants

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/8.5.x by this push:
 new e82c6c9309 Refactor default cluster buffer sizes to use constants
e82c6c9309 is described below

commit e82c6c9309199d056f7b2012d80a4b523e0ad250
Author: Mark Thomas 
AuthorDate: Fri May 20 11:58:41 2022 +0100

Refactor default cluster buffer sizes to use constants

Makes it simpler to change the default buffer size
---
 java/org/apache/catalina/tribes/io/LocalStrings.properties   | 2 +-
 java/org/apache/catalina/tribes/io/LocalStrings_de.properties| 2 +-
 java/org/apache/catalina/tribes/io/LocalStrings_es.properties| 2 +-
 java/org/apache/catalina/tribes/io/LocalStrings_fr.properties| 2 +-
 java/org/apache/catalina/tribes/io/LocalStrings_ja.properties| 2 +-
 java/org/apache/catalina/tribes/io/LocalStrings_ko.properties| 2 +-
 java/org/apache/catalina/tribes/io/LocalStrings_zh_CN.properties | 2 +-
 java/org/apache/catalina/tribes/io/ObjectReader.java | 6 --
 java/org/apache/catalina/tribes/transport/AbstractSender.java| 8 
 java/org/apache/catalina/tribes/transport/Constants.java | 3 +++
 java/org/apache/catalina/tribes/transport/ReceiverBase.java  | 8 
 test/org/apache/catalina/tribes/demos/ChannelCreator.java| 9 +
 .../org/apache/catalina/tribes/test/transport/SocketReceive.java | 4 +++-
 .../catalina/tribes/test/transport/SocketTribesReceive.java  | 5 +++--
 .../catalina/tribes/test/transport/SocketValidateReceive.java| 4 +++-
 15 files changed, 36 insertions(+), 25 deletions(-)

diff --git a/java/org/apache/catalina/tribes/io/LocalStrings.properties 
b/java/org/apache/catalina/tribes/io/LocalStrings.properties
index f7ef725719..534d0e4e54 100644
--- a/java/org/apache/catalina/tribes/io/LocalStrings.properties
+++ b/java/org/apache/catalina/tribes/io/LocalStrings.properties
@@ -15,7 +15,7 @@
 
 bufferPool.created=Created a buffer pool with max size:[{0}] bytes of type: 
[{1}]
 
-objectReader.retrieveFailed.socketReceiverBufferSize=Unable to retrieve the 
socket receiver buffer size, setting to default 43800 bytes.
+objectReader.retrieveFailed.socketReceiverBufferSize=Unable to retrieve the 
socket receiver buffer size, setting to default [{0}] bytes.
 
 replicationStream.conflict=conflicting non-public interface class loaders
 
diff --git a/java/org/apache/catalina/tribes/io/LocalStrings_de.properties 
b/java/org/apache/catalina/tribes/io/LocalStrings_de.properties
index ba50760f31..7967e8f934 100644
--- a/java/org/apache/catalina/tribes/io/LocalStrings_de.properties
+++ b/java/org/apache/catalina/tribes/io/LocalStrings_de.properties
@@ -13,7 +13,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-objectReader.retrieveFailed.socketReceiverBufferSize=Kann die Größe der Socket 
Puffer nicht auslesen. Setze sie auf den Standardwert von 43800 Bytes.
+objectReader.retrieveFailed.socketReceiverBufferSize=Kann die Größe der Socket 
Puffer nicht auslesen. Setze sie auf den Standardwert von [{0}] Bytes.
 
 xByteBuffer.no.package=In XByteBuffer existiert kein Paket
 xByteBuffer.size.larger.buffer=Größe liegt über dem bestehenden Buffer.
diff --git a/java/org/apache/catalina/tribes/io/LocalStrings_es.properties 
b/java/org/apache/catalina/tribes/io/LocalStrings_es.properties
index 583149fdfe..332cd0895c 100644
--- a/java/org/apache/catalina/tribes/io/LocalStrings_es.properties
+++ b/java/org/apache/catalina/tribes/io/LocalStrings_es.properties
@@ -13,7 +13,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-objectReader.retrieveFailed.socketReceiverBufferSize=Incapáz de recuperar el 
tamaño del buffer receptor, fijando el valor por defecto a 43800 bytes.\n
+objectReader.retrieveFailed.socketReceiverBufferSize=Incapáz de recuperar el 
tamaño del buffer receptor, fijando el valor por defecto a [{0}] bytes.\n
 
 replicationStream.conflict=hay conflicto en la clase de los cargadores de la 
interfaz no pública
 
diff --git a/java/org/apache/catalina/tribes/io/LocalStrings_fr.properties 
b/java/org/apache/catalina/tribes/io/LocalStrings_fr.properties
index 12437458c4..2450c0ca3d 100644
--- a/java/org/apache/catalina/tribes/io/LocalStrings_fr.properties
+++ b/java/org/apache/catalina/tribes/io/LocalStrings_fr.properties
@@ -15,7 +15,7 @@
 
 bufferPool.created=Création d''un pool de tampons de taille maximale : [{0}] 
octets de type : [{1}]
 
-objectReader.retrieveFailed.socketReceiverBufferSize=Incapacité de récupérer 
la taille du tampon du socket de réception, forcé à 43800 octets
+objectReader.retrieveFailed.socketReceiverBufferSize=Incapacité de récupérer 
la taille du tampon du socket de réception, forcé à [{0}] octets
 
 replicationStream.conflict

[tomcat] branch 10.0.x updated: Refactor default cluster buffer sizes to use constants

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 10.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/10.0.x by this push:
 new 5f0db8bd21 Refactor default cluster buffer sizes to use constants
5f0db8bd21 is described below

commit 5f0db8bd21481a5b3a34027b44f5999eedb22587
Author: Mark Thomas 
AuthorDate: Fri May 20 11:58:41 2022 +0100

Refactor default cluster buffer sizes to use constants

Makes it simpler to change the default buffer size
---
 java/org/apache/catalina/tribes/io/LocalStrings.properties   | 2 +-
 java/org/apache/catalina/tribes/io/LocalStrings_cs.properties| 2 +-
 java/org/apache/catalina/tribes/io/LocalStrings_de.properties| 2 +-
 java/org/apache/catalina/tribes/io/LocalStrings_es.properties| 2 +-
 java/org/apache/catalina/tribes/io/LocalStrings_fr.properties| 2 +-
 java/org/apache/catalina/tribes/io/LocalStrings_ja.properties| 2 +-
 java/org/apache/catalina/tribes/io/LocalStrings_ko.properties| 2 +-
 java/org/apache/catalina/tribes/io/LocalStrings_zh_CN.properties | 2 +-
 java/org/apache/catalina/tribes/io/ObjectReader.java | 6 --
 java/org/apache/catalina/tribes/transport/AbstractSender.java| 8 
 java/org/apache/catalina/tribes/transport/Constants.java | 3 +++
 java/org/apache/catalina/tribes/transport/ReceiverBase.java  | 8 
 test/org/apache/catalina/tribes/demos/ChannelCreator.java| 9 +
 .../org/apache/catalina/tribes/test/transport/SocketReceive.java | 4 +++-
 .../catalina/tribes/test/transport/SocketTribesReceive.java  | 5 +++--
 .../catalina/tribes/test/transport/SocketValidateReceive.java| 4 +++-
 16 files changed, 37 insertions(+), 26 deletions(-)

diff --git a/java/org/apache/catalina/tribes/io/LocalStrings.properties 
b/java/org/apache/catalina/tribes/io/LocalStrings.properties
index f7ef725719..534d0e4e54 100644
--- a/java/org/apache/catalina/tribes/io/LocalStrings.properties
+++ b/java/org/apache/catalina/tribes/io/LocalStrings.properties
@@ -15,7 +15,7 @@
 
 bufferPool.created=Created a buffer pool with max size:[{0}] bytes of type: 
[{1}]
 
-objectReader.retrieveFailed.socketReceiverBufferSize=Unable to retrieve the 
socket receiver buffer size, setting to default 43800 bytes.
+objectReader.retrieveFailed.socketReceiverBufferSize=Unable to retrieve the 
socket receiver buffer size, setting to default [{0}] bytes.
 
 replicationStream.conflict=conflicting non-public interface class loaders
 
diff --git a/java/org/apache/catalina/tribes/io/LocalStrings_cs.properties 
b/java/org/apache/catalina/tribes/io/LocalStrings_cs.properties
index c7e4de57d7..5891ce80a5 100644
--- a/java/org/apache/catalina/tribes/io/LocalStrings_cs.properties
+++ b/java/org/apache/catalina/tribes/io/LocalStrings_cs.properties
@@ -13,7 +13,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-objectReader.retrieveFailed.socketReceiverBufferSize=Nelze získat velikost 
bufferu pro socket receiver, nastaveno na výchozí hodnotu 43800 bytes.
+objectReader.retrieveFailed.socketReceiverBufferSize=Nelze získat velikost 
bufferu pro socket receiver, nastaveno na výchozí hodnotu [{0}] bytes.
 
 replicationStream.conflict=konflikt class loaderů neveřejného rozhraní
 
diff --git a/java/org/apache/catalina/tribes/io/LocalStrings_de.properties 
b/java/org/apache/catalina/tribes/io/LocalStrings_de.properties
index ba50760f31..7967e8f934 100644
--- a/java/org/apache/catalina/tribes/io/LocalStrings_de.properties
+++ b/java/org/apache/catalina/tribes/io/LocalStrings_de.properties
@@ -13,7 +13,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-objectReader.retrieveFailed.socketReceiverBufferSize=Kann die Größe der Socket 
Puffer nicht auslesen. Setze sie auf den Standardwert von 43800 Bytes.
+objectReader.retrieveFailed.socketReceiverBufferSize=Kann die Größe der Socket 
Puffer nicht auslesen. Setze sie auf den Standardwert von [{0}] Bytes.
 
 xByteBuffer.no.package=In XByteBuffer existiert kein Paket
 xByteBuffer.size.larger.buffer=Größe liegt über dem bestehenden Buffer.
diff --git a/java/org/apache/catalina/tribes/io/LocalStrings_es.properties 
b/java/org/apache/catalina/tribes/io/LocalStrings_es.properties
index 583149fdfe..332cd0895c 100644
--- a/java/org/apache/catalina/tribes/io/LocalStrings_es.properties
+++ b/java/org/apache/catalina/tribes/io/LocalStrings_es.properties
@@ -13,7 +13,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-objectReader.retrieveFailed.socketReceiverBufferSize=Incapáz de recuperar el 
tamaño del buffer receptor, fijando el valor por defecto a 43800 bytes.\n
+objectReader.retrieveFailed.socketReceiverBufferSize=Incapáz de recuperar el 
tamaño del buffer receptor, fijando el valor p

[tomcat] branch 9.0.x updated: Refactor default cluster buffer sizes to use constants

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/9.0.x by this push:
 new acba284026 Refactor default cluster buffer sizes to use constants
acba284026 is described below

commit acba284026fe4789464dda95613b8b93223dfe71
Author: Mark Thomas 
AuthorDate: Fri May 20 11:58:41 2022 +0100

Refactor default cluster buffer sizes to use constants

Makes it simpler to change the default buffer size
---
 java/org/apache/catalina/tribes/io/LocalStrings.properties   | 2 +-
 java/org/apache/catalina/tribes/io/LocalStrings_cs.properties| 2 +-
 java/org/apache/catalina/tribes/io/LocalStrings_de.properties| 2 +-
 java/org/apache/catalina/tribes/io/LocalStrings_es.properties| 2 +-
 java/org/apache/catalina/tribes/io/LocalStrings_fr.properties| 2 +-
 java/org/apache/catalina/tribes/io/LocalStrings_ja.properties| 2 +-
 java/org/apache/catalina/tribes/io/LocalStrings_ko.properties| 2 +-
 java/org/apache/catalina/tribes/io/LocalStrings_zh_CN.properties | 2 +-
 java/org/apache/catalina/tribes/io/ObjectReader.java | 6 --
 java/org/apache/catalina/tribes/transport/AbstractSender.java| 8 
 java/org/apache/catalina/tribes/transport/Constants.java | 3 +++
 java/org/apache/catalina/tribes/transport/ReceiverBase.java  | 8 
 test/org/apache/catalina/tribes/demos/ChannelCreator.java| 9 +
 .../org/apache/catalina/tribes/test/transport/SocketReceive.java | 4 +++-
 .../catalina/tribes/test/transport/SocketTribesReceive.java  | 5 +++--
 .../catalina/tribes/test/transport/SocketValidateReceive.java| 4 +++-
 16 files changed, 37 insertions(+), 26 deletions(-)

diff --git a/java/org/apache/catalina/tribes/io/LocalStrings.properties 
b/java/org/apache/catalina/tribes/io/LocalStrings.properties
index f7ef725719..534d0e4e54 100644
--- a/java/org/apache/catalina/tribes/io/LocalStrings.properties
+++ b/java/org/apache/catalina/tribes/io/LocalStrings.properties
@@ -15,7 +15,7 @@
 
 bufferPool.created=Created a buffer pool with max size:[{0}] bytes of type: 
[{1}]
 
-objectReader.retrieveFailed.socketReceiverBufferSize=Unable to retrieve the 
socket receiver buffer size, setting to default 43800 bytes.
+objectReader.retrieveFailed.socketReceiverBufferSize=Unable to retrieve the 
socket receiver buffer size, setting to default [{0}] bytes.
 
 replicationStream.conflict=conflicting non-public interface class loaders
 
diff --git a/java/org/apache/catalina/tribes/io/LocalStrings_cs.properties 
b/java/org/apache/catalina/tribes/io/LocalStrings_cs.properties
index c7e4de57d7..5891ce80a5 100644
--- a/java/org/apache/catalina/tribes/io/LocalStrings_cs.properties
+++ b/java/org/apache/catalina/tribes/io/LocalStrings_cs.properties
@@ -13,7 +13,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-objectReader.retrieveFailed.socketReceiverBufferSize=Nelze získat velikost 
bufferu pro socket receiver, nastaveno na výchozí hodnotu 43800 bytes.
+objectReader.retrieveFailed.socketReceiverBufferSize=Nelze získat velikost 
bufferu pro socket receiver, nastaveno na výchozí hodnotu [{0}] bytes.
 
 replicationStream.conflict=konflikt class loaderů neveřejného rozhraní
 
diff --git a/java/org/apache/catalina/tribes/io/LocalStrings_de.properties 
b/java/org/apache/catalina/tribes/io/LocalStrings_de.properties
index ba50760f31..7967e8f934 100644
--- a/java/org/apache/catalina/tribes/io/LocalStrings_de.properties
+++ b/java/org/apache/catalina/tribes/io/LocalStrings_de.properties
@@ -13,7 +13,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-objectReader.retrieveFailed.socketReceiverBufferSize=Kann die Größe der Socket 
Puffer nicht auslesen. Setze sie auf den Standardwert von 43800 Bytes.
+objectReader.retrieveFailed.socketReceiverBufferSize=Kann die Größe der Socket 
Puffer nicht auslesen. Setze sie auf den Standardwert von [{0}] Bytes.
 
 xByteBuffer.no.package=In XByteBuffer existiert kein Paket
 xByteBuffer.size.larger.buffer=Größe liegt über dem bestehenden Buffer.
diff --git a/java/org/apache/catalina/tribes/io/LocalStrings_es.properties 
b/java/org/apache/catalina/tribes/io/LocalStrings_es.properties
index 583149fdfe..332cd0895c 100644
--- a/java/org/apache/catalina/tribes/io/LocalStrings_es.properties
+++ b/java/org/apache/catalina/tribes/io/LocalStrings_es.properties
@@ -13,7 +13,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-objectReader.retrieveFailed.socketReceiverBufferSize=Incapáz de recuperar el 
tamaño del buffer receptor, fijando el valor por defecto a 43800 bytes.\n
+objectReader.retrieveFailed.socketReceiverBufferSize=Incapáz de recuperar el 
tamaño del buffer receptor, fijando el valor por

[tomcat] branch main updated: Refactor default cluster buffer sizes to use constants

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/main by this push:
 new 012d44466e Refactor default cluster buffer sizes to use constants
012d44466e is described below

commit 012d44466e67e26ddf76bc07f0efb6e2a6b1c0a0
Author: Mark Thomas 
AuthorDate: Fri May 20 11:58:41 2022 +0100

Refactor default cluster buffer sizes to use constants

Makes it simpler to change the default buffer size
---
 java/org/apache/catalina/tribes/io/LocalStrings.properties   | 2 +-
 java/org/apache/catalina/tribes/io/LocalStrings_cs.properties| 2 +-
 java/org/apache/catalina/tribes/io/LocalStrings_de.properties| 2 +-
 java/org/apache/catalina/tribes/io/LocalStrings_es.properties| 2 +-
 java/org/apache/catalina/tribes/io/LocalStrings_fr.properties| 2 +-
 java/org/apache/catalina/tribes/io/LocalStrings_ja.properties| 2 +-
 java/org/apache/catalina/tribes/io/LocalStrings_ko.properties| 2 +-
 java/org/apache/catalina/tribes/io/LocalStrings_zh_CN.properties | 2 +-
 java/org/apache/catalina/tribes/io/ObjectReader.java | 6 --
 java/org/apache/catalina/tribes/transport/AbstractSender.java| 8 
 java/org/apache/catalina/tribes/transport/Constants.java | 3 +++
 java/org/apache/catalina/tribes/transport/ReceiverBase.java  | 8 
 test/org/apache/catalina/tribes/demos/ChannelCreator.java| 9 +
 .../org/apache/catalina/tribes/test/transport/SocketReceive.java | 4 +++-
 .../catalina/tribes/test/transport/SocketTribesReceive.java  | 5 +++--
 .../catalina/tribes/test/transport/SocketValidateReceive.java| 4 +++-
 16 files changed, 37 insertions(+), 26 deletions(-)

diff --git a/java/org/apache/catalina/tribes/io/LocalStrings.properties 
b/java/org/apache/catalina/tribes/io/LocalStrings.properties
index f7ef725719..534d0e4e54 100644
--- a/java/org/apache/catalina/tribes/io/LocalStrings.properties
+++ b/java/org/apache/catalina/tribes/io/LocalStrings.properties
@@ -15,7 +15,7 @@
 
 bufferPool.created=Created a buffer pool with max size:[{0}] bytes of type: 
[{1}]
 
-objectReader.retrieveFailed.socketReceiverBufferSize=Unable to retrieve the 
socket receiver buffer size, setting to default 43800 bytes.
+objectReader.retrieveFailed.socketReceiverBufferSize=Unable to retrieve the 
socket receiver buffer size, setting to default [{0}] bytes.
 
 replicationStream.conflict=conflicting non-public interface class loaders
 
diff --git a/java/org/apache/catalina/tribes/io/LocalStrings_cs.properties 
b/java/org/apache/catalina/tribes/io/LocalStrings_cs.properties
index c7e4de57d7..5891ce80a5 100644
--- a/java/org/apache/catalina/tribes/io/LocalStrings_cs.properties
+++ b/java/org/apache/catalina/tribes/io/LocalStrings_cs.properties
@@ -13,7 +13,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-objectReader.retrieveFailed.socketReceiverBufferSize=Nelze získat velikost 
bufferu pro socket receiver, nastaveno na výchozí hodnotu 43800 bytes.
+objectReader.retrieveFailed.socketReceiverBufferSize=Nelze získat velikost 
bufferu pro socket receiver, nastaveno na výchozí hodnotu [{0}] bytes.
 
 replicationStream.conflict=konflikt class loaderů neveřejného rozhraní
 
diff --git a/java/org/apache/catalina/tribes/io/LocalStrings_de.properties 
b/java/org/apache/catalina/tribes/io/LocalStrings_de.properties
index ba50760f31..7967e8f934 100644
--- a/java/org/apache/catalina/tribes/io/LocalStrings_de.properties
+++ b/java/org/apache/catalina/tribes/io/LocalStrings_de.properties
@@ -13,7 +13,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-objectReader.retrieveFailed.socketReceiverBufferSize=Kann die Größe der Socket 
Puffer nicht auslesen. Setze sie auf den Standardwert von 43800 Bytes.
+objectReader.retrieveFailed.socketReceiverBufferSize=Kann die Größe der Socket 
Puffer nicht auslesen. Setze sie auf den Standardwert von [{0}] Bytes.
 
 xByteBuffer.no.package=In XByteBuffer existiert kein Paket
 xByteBuffer.size.larger.buffer=Größe liegt über dem bestehenden Buffer.
diff --git a/java/org/apache/catalina/tribes/io/LocalStrings_es.properties 
b/java/org/apache/catalina/tribes/io/LocalStrings_es.properties
index 583149fdfe..332cd0895c 100644
--- a/java/org/apache/catalina/tribes/io/LocalStrings_es.properties
+++ b/java/org/apache/catalina/tribes/io/LocalStrings_es.properties
@@ -13,7 +13,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-objectReader.retrieveFailed.socketReceiverBufferSize=Incapáz de recuperar el 
tamaño del buffer receptor, fijando el valor por defecto a 43800 bytes.\n
+objectReader.retrieveFailed.socketReceiverBufferSize=Incapáz de recuperar el 
tamaño del buffer receptor, fijando el valor por d

problem with juli logging and levels.

[jacques klein]

Hello all,

I guess my problem is tricky enough to require help from developpers...

Logging works fine at the start of my App (.war), the .level 
declarations in logging.properties apply.


However, during initialisation, the App sets a .level with by 
calling Logger.getLogger("").setLevel(),


the logging than gets inconsistent (not immediately) , for example  
logger.info("") generates a log even if a parent logger has been set 
to WARNING (level of logger not set).


I looked at the code of ClassLoaderLogManager and found two things that 
could explain, although I don't say I understand the problem.


 * private final Map<*ClassLoader*, ClassLoaderLogInfo>
   classLoaderLoggers = new *WeakHashMap*<>(); // Guarded by this

 * static ClassLoader getClassLoader() {
    ClassLoader result =
   *Thread.currentThread().getContextClassLoader()*;

What I noticed, is that following code

    java.util.logging.LogManager logM 
=java.util.logging.LogManager.getLogManager();  // it's a Tomcat 
ClassLoaderLogManager

    java.util.Enumeration all = logM.getLoggerNames();

gives me changing results (and ClassLoaderLogInfo objects get garbage 
collected); previously done loglevel settings get lost.


Of course, this happens without "redeploying the .war".

To mention, the App implements it's own plugin management, setting a 
specific classloader for each plugin.


Any help is welcome,

Jacques

[tomcat] branch 8.5.x updated: Remove the experimental label from the embedded packaging

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/8.5.x by this push:
 new faa4bb2659 Remove the experimental label from the embedded packaging
faa4bb2659 is described below

commit faa4bb265978a52b2a454e48a3bbcccd8424105d
Author: Mark Thomas 
AuthorDate: Fri May 20 11:12:04 2022 +0100

Remove the experimental label from the embedded packaging

The programmatic JAR is still labelled as experimental
---
 build.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/build.xml b/build.xml
index 60d419c606..800652df99 100644
--- a/build.xml
+++ b/build.xml
@@ -1295,7 +1295,7 @@
   
 
   
-  
 
 
@@ -1357,7 +1357,7 @@
   
 
   
 
 

[tomcat] branch 9.0.x updated: Remove the experimental label from the embedded packaging

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/9.0.x by this push:
 new e8f87a5bde Remove the experimental label from the embedded packaging
e8f87a5bde is described below

commit e8f87a5bde274b0f0a03885ab71b6f37d443a21f
Author: Mark Thomas 
AuthorDate: Fri May 20 11:12:04 2022 +0100

Remove the experimental label from the embedded packaging

The programmatic JAR is still labelled as experimental
---
 build.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/build.xml b/build.xml
index d34f56bc74..e5147c3565 100644
--- a/build.xml
+++ b/build.xml
@@ -1600,7 +1600,7 @@
   
 
   
-  
 
 
@@ -1742,7 +1742,7 @@
   
 
   
 
 

[tomcat] branch 10.0.x updated: Remove the experimental label from the embedded packaging

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 10.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/10.0.x by this push:
 new f3860de018 Remove the experimental label from the embedded packaging
f3860de018 is described below

commit f3860de0186c0855bc1ff85c1bf92a6260af1607
Author: Mark Thomas 
AuthorDate: Fri May 20 11:12:04 2022 +0100

Remove the experimental label from the embedded packaging

The programmatic JAR is still labelled as experimental
---
 build.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/build.xml b/build.xml
index b638704cc8..5a017d711d 100644
--- a/build.xml
+++ b/build.xml
@@ -1618,7 +1618,7 @@
   
 
   
-  
 
 
@@ -1760,7 +1760,7 @@
   
 
   
 
 

[tomcat] branch main updated: Remove the experimental label from the embedded packaging

[markt]

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/main by this push:
 new d536574c9d Remove the experimental label from the embedded packaging
d536574c9d is described below

commit d536574c9de54c58d9b20c8b4dd3a31b30aaf98e
Author: Mark Thomas 
AuthorDate: Fri May 20 11:12:04 2022 +0100

Remove the experimental label from the embedded packaging

The programmatic JAR is still labelled as experimental
---
 build.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/build.xml b/build.xml
index c2243a518c..2a67d5346f 100644
--- a/build.xml
+++ b/build.xml
@@ -1643,7 +1643,7 @@
   
 
   
-  
 
 
@@ -1785,7 +1785,7 @@
   
 
   
 
 

Re: Tomcat embed packaging clarification

[Mark Thomas]

On 20/05/2022 10:36, Romain Manni-Bucau wrote:

Hi all,

Checking a project with multiple tomcat integrators (spring boot, uship,
meecrowave, tomee, ...) I realised Tomcat ecosystem is quite exploded with
tomcat-embed packaging but I kind of fail to see the benefit from there
since using plain tomcat artifacts works well


Not sure I understand your concern. There are a handful of extra JARs in 
the embedded namespace that provide an alternative packaging.


There was a specific user request for the embedded packaging. They 
wanted fewer, larger JARs.


It costs us very little to maintain those JARs.


plus embed is still marked as
experimental in the build descriptors.


That is an easy fix.


 From my window it would be great to deprecate embed jar usage, potentially
make some gap converging with default packaging, and focus on the main
packaging only and maybe drop embed one for the final 10.1 but not sure I
missed something critical.


Why? What is the benefit of removing that packaging?

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 66077] Deadlock when concurrent processing of incoming HTTP/2 frames

[bugzilla]

https://bz.apache.org/bugzilla/show_bug.cgi?id=66077

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #1 from Mark Thomas  ---
The line numbers in the stack trace provided are consistent with Apache Tomcat
10.0.14 rather than 10.0.16.

As per the 10.0.x changelog, this deadlock is fixed in 10.0.15 onwards.
https://tomcat.apache.org/tomcat-10.0-doc/changelog.html

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Tomcat embed packaging clarification

[Romain Manni-Bucau]

Hi all,

Checking a project with multiple tomcat integrators (spring boot, uship,
meecrowave, tomee, ...) I realised Tomcat ecosystem is quite exploded with
tomcat-embed packaging but I kind of fail to see the benefit from there
since using plain tomcat artifacts works well plus embed is still marked as
experimental in the build descriptors.

>From my window it would be great to deprecate embed jar usage, potentially
make some gap converging with default packaging, and focus on the main
packaging only and maybe drop embed one for the final 10.1 but not sure I
missed something critical.

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book

Re: JDK 19 - Virtual Threads Testing!

[Rémy Maucherat]

On Fri, May 20, 2022 at 9:35 AM Martin Grigorov  wrote:
>
> On Tue, May 17, 2022 at 4:23 PM Rémy Maucherat  wrote:
>
> > On Tue, May 17, 2022 at 12:27 PM Mark Thomas  wrote:
> > >
> > > On 16/05/2022 14:14, Martin Grigorov wrote:
> > > > Hello Tomcat devs,
> > > >
> > > > Some tests fail with JDK 19-ea+22-1598:
> > >
> > > 
> > >
> > > >[concat] Testsuites with failed tests:
> > > > [concat] TEST-jakarta.el.TestImportHandlerStandardPackages.NIO.txt
> > > > [concat] TEST-jakarta.el.TestImportHandlerStandardPackages.NIO2.txt
> > >
> > > 
> > >
> > > > Here are the error types:
> > > >
> > > >
> > > > 1. Testsuite: jakarta.el.TestImportHandlerStandardPackages
> > > > Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.463
> > sec
> > > >
> > > > Testcase: testClassListsAreComplete took 0.444 sec
> > > >  FAILED
> > > > java.lang.Thread.Builder.OfPlatform
> > > > junit.framework.AssertionFailedError:
> > java.lang.Thread.Builder.OfPlatform
> > > >  at
> > > >
> > jakarta.el.TestImportHandlerStandardPackages.lambda$checkPackageClassList$12(TestImportHandlerStandardPackages.java:77)
> > > >  at
> > > >
> > java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
> > > >  at
> > > >
> > java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:179)
> > > >  at
> > > >
> > java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:179)
> > >
> > > I've fixed this one. Looking at the others.
> >
> > Ok, so since we're now adding support for Java 19 and the current
> > trunk has the Panama preview API, I'll add a new "openssl-foreign"
> > module that targets it.
> >
>
> According to
> https://github.com/openjdk/jdk/commit/2c5d136260fa717afa374db8b923b7c886d069b7
> the FF & Memory API is added in b23.
> Above we were using b22.
>
> https://jdk.java.net/19/ has been just updated to b23.
>
> Do you want me to update JDK 19 at Buildbot (& Jenkins) to b23 ?

That's good news if you want to test the OpenSSL support with a more
final version. I don't really know what kind of API changes can be
expected following the preview, so we'll see how that goes. The API
itself is a lot cleaner than the one from Java 17.

One feature remaining that could be interesting depending on how it's
done is: https://bugs.openjdk.java.net/browse/JDK-8254693
Allowing to pass heap byte buffers (as long as this capability remains
flexible enough, if there's a surprise like "you can never deallocate
it" then it's not going to be useful ...) would be very significant
for Tomcat allowing to get rid of ugly memory copies and direct BB
allocations.

The full foreign task list is:
https://bugs.openjdk.java.net/Dashboard.jspa?selectPageId=18412

Rémy

>
>
> >
> > Rémy
> >
> > > Mark
> > >
> > > -
> > > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> > > For additional commands, e-mail: dev-h...@tomcat.apache.org
> > >
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> > For additional commands, e-mail: dev-h...@tomcat.apache.org
> >
> >

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: JDK 19 - Virtual Threads Testing!

[Martin Grigorov]

On Tue, May 17, 2022 at 4:23 PM Rémy Maucherat  wrote:

> On Tue, May 17, 2022 at 12:27 PM Mark Thomas  wrote:
> >
> > On 16/05/2022 14:14, Martin Grigorov wrote:
> > > Hello Tomcat devs,
> > >
> > > Some tests fail with JDK 19-ea+22-1598:
> >
> > 
> >
> > >[concat] Testsuites with failed tests:
> > > [concat] TEST-jakarta.el.TestImportHandlerStandardPackages.NIO.txt
> > > [concat] TEST-jakarta.el.TestImportHandlerStandardPackages.NIO2.txt
> >
> > 
> >
> > > Here are the error types:
> > >
> > >
> > > 1. Testsuite: jakarta.el.TestImportHandlerStandardPackages
> > > Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.463
> sec
> > >
> > > Testcase: testClassListsAreComplete took 0.444 sec
> > >  FAILED
> > > java.lang.Thread.Builder.OfPlatform
> > > junit.framework.AssertionFailedError:
> java.lang.Thread.Builder.OfPlatform
> > >  at
> > >
> jakarta.el.TestImportHandlerStandardPackages.lambda$checkPackageClassList$12(TestImportHandlerStandardPackages.java:77)
> > >  at
> > >
> java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
> > >  at
> > >
> java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:179)
> > >  at
> > >
> java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:179)
> >
> > I've fixed this one. Looking at the others.
>
> Ok, so since we're now adding support for Java 19 and the current
> trunk has the Panama preview API, I'll add a new "openssl-foreign"
> module that targets it.
>

According to
https://github.com/openjdk/jdk/commit/2c5d136260fa717afa374db8b923b7c886d069b7
the FF & Memory API is added in b23.
Above we were using b22.

https://jdk.java.net/19/ has been just updated to b23.

Do you want me to update JDK 19 at Buildbot (& Jenkins) to b23 ?



>
> Rémy
>
> > Mark
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> > For additional commands, e-mail: dev-h...@tomcat.apache.org
> >
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>