Re: Regarding IDE configuration files
On 2/6/23 2:28 PM, Coty Sutherland wrote: On Sat, Feb 4, 2023 at 5:21 AM Mark Thomas wrote: 4 Feb 2023 04:17:29 Bailey Brownie : Hi all, Recently, when setting up Tomcat for development with the Eclipse IDE, I noticed that the configuration files that come with Tomcat had multiple hard-coded (and outdated) references to some dependencies. Sorry. That is probably me forgetting to update those files. Is it a good idea to handle class path configuration for IDEs by using a filterset when copying the config files in the IDE build targets? Are there any potential downsides to this approach? Excellent idea. No downside I can think of. +1 Thank you both for the feedback. I have opened a pull request with my changes, please review them and let me know if any modifications are required. With these changes, it should not be necessary to add classpath variables for ANT_HOME and TOMCAT_LIBS_BASE in Eclipse anymore. I have also used the existing "version.filters" filterset to get the required Java version for building Tomcat. I am not sure that is backwards-compatible with Tomcat versions that require a Java version below 9.. perhaps there is a better way of setting the Java version for the IDE config files? Thanks, Bailey - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] tbw777 opened a new pull request, #583: Replaced old time API
tbw777 opened a new pull request, #583: URL: https://github.com/apache/tomcat/pull/583 SimpleDateFormatter isnt thread safe and deprecated with new jvm8 time API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Regarding IDE configuration files
On Sat, Feb 4, 2023 at 5:21 AM Mark Thomas wrote: > > 4 Feb 2023 04:17:29 Bailey Brownie : > > > Hi all, > > > > Recently, when setting up Tomcat for development with the Eclipse IDE, > > I noticed that the configuration files that come with Tomcat had > > multiple hard-coded (and outdated) references to some dependencies. > > Sorry. That is probably me forgetting to update those files. > > > Is it a good idea to handle class path configuration for IDEs by using > > a filterset when copying the config files in the IDE build targets? Are > > there any potential downsides to this approach? > > Excellent idea. No downside I can think of. > +1
