[GitHub] tomcat-maven-plugin pull request #26: Allow easy myEclipse development
GitHub user hazendaz opened a pull request: https://github.com/apache/tomcat-maven-plugin/pull/26 Allow easy myEclipse development MyEclipse uses tag when importing projects to workspace by default. In order to allow development easily for users of myEclipse, colons are not allowed in the tag. This change replaced :: with -. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hazendaz/tomcat-maven-plugin trunk Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tomcat-maven-plugin/pull/26.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #26 commit 0f9edec10dbc4f35ef67027afcac6c65d60137a0 Author: Jeremy Landis Date: 2014-11-15T22:30:28Z Allow easy myEclipse development MyEclipse uses tag when importing projects to workspace by default. In order to allow development easily for users of myEclipse, colons are not allowed in the tag. This change replaced :: with -. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat-maven-plugin pull request: Allow easy myEclipse development
Github user hazendaz closed the pull request at: https://github.com/apache/tomcat-maven-plugin/pull/13 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat pull request: now json is fashion
Github user hazendaz commented on the pull request: https://github.com/apache/tomcat/pull/15#issuecomment-69744890 Sure...what I meant here is that this patch does nothing from tomcat perspective. It's just an empty if statement. It does nothing at all. --- Original Message --- From: "Martin Grigorov" Sent: January 13, 2015 8:18 AM To: "apache/tomcat" Cc: "Jeremy Landis" Subject: Re: [tomcat] now json is fashion (#15) I'm pretty sure Jersey does something. --- Reply to this email directly or view it on GitHub: https://github.com/apache/tomcat/pull/15#issuecomment-69742518 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat pull request: now json is fashion
Github user hazendaz commented on the pull request:
https://github.com/apache/tomcat/pull/15#issuecomment-69741658
We run json using Jackson with jersey in tomcat. No issues. This code
doesn't do anything. So unclear how it solves anything. All you did was add
an empty if statement.
--- Original Message ---
From: "ahu0605"
Sent: January 12, 2015 10:09 PM
To: "apache/tomcat"
Subject: Re: [tomcat] now json is fashion (#15)
but when i push content type - jsonï¼there is some bug , 4 ex :data is
json "{\"id\":\"asd\"}",the value will be a Map key, request.getPamaterMap ()
the key is {"id":"asd"}, value is null ,is not logic
---
Reply to this email directly or view it on GitHub:
https://github.com/apache/tomcat/pull/15#issuecomment-69689061
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat-maven-plugin pull request: Allow easy myEclipse development
GitHub user hazendaz opened a pull request: https://github.com/apache/tomcat-maven-plugin/pull/13 Allow easy myEclipse development MyEclipse uses tag when importing projects to workspace by default. In order to allow development easily for users of myEclipse, colons are not allowed in the tag. This change replaced :: with -. You can merge this pull request into a Git repository by running: $ git pull https://github.com/hazendaz/tomcat-maven-plugin trunk Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tomcat-maven-plugin/pull/13.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #13 commit f742db8b13b5380b9da64dd2b4a7acaa0143cf35 Author: Jeremy Landis Date: 2014-11-15T22:30:28Z Allow easy myEclipse development MyEclipse uses tag when importing projects to workspace by default. In order to allow development easily for users of myEclipse, colons are not allowed in the tag. This change replaced :: with -. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat pull request: Document the use of "shutdown" and "port" att...
Github user hazendaz commented on the pull request: https://github.com/apache/tomcat/pull/6#issuecomment-4225 Another -1 on this change. I'm not sure how this would solve any perceived security issue. The shutdown port is only accessible as local host so it requires you are on the actual machine to even issue anything against it. On top of that, permissions on the process itself should be set such that not just any user on the machine can start/stop the process. Then if someone somehow got passed this security the box, I would think there would be larger security concerns than tomcat. Am I missing something here? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
