[GitHub] tomcat issue #134: Display generate date when showing every message in Html ...
Github user michael-o commented on the issue: https://github.com/apache/tomcat/pull/134 @ljader, why? This is a static change, not a dynamic one. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat issue #134: Display generate date when showing every message in Html ...
Github user michael-o commented on the issue: https://github.com/apache/tomcat/pull/134 > How I can get the "Date" header without reloading the page when the DevTools are closed (by default)? As far as I can see, you can't > Doesn't the "Modified" section in "Right-click + Pageinfo" in Firefox shows every time a different date ? If yes, then I can's see how it's helpfull. Correct, that information is quite pointless. > I think I don't get why someone would like to checksum the response of Html Manager - can you give some examples? While this is correct, we don't know what people are doing with the manager. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat issue #134: Display generate date when showing every message in Html ...
Github user michael-o commented on the issue:
https://github.com/apache/tomcat/pull/134
I agree with @rmaucher, I see little benefit here. This not static content,
but dynamic. We have browser info and the {{Date}} header. For those who want
to checksum the response, this change will break it.
---
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat issue #119: API change for Realm and AuthenticatorBase to make remote...
Github user michael-o commented on the issue: https://github.com/apache/tomcat/pull/119 Please have a look what @ChristopherSchultz has proposed on the ticket. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat issue #119: API change for Realm and AuthenticatorBase to make remote...
Github user michael-o commented on the issue: https://github.com/apache/tomcat/pull/119 I'd really like to go with listeners as proposed just like the Spring Secutiry framework does. You will be able to do whatever your want with that information. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat issue #119: API change for Realm and AuthenticatorBase to make remote...
Github user michael-o commented on the issue: https://github.com/apache/tomcat/pull/119 Oh hell, this will break the public API in a patch release. Especially for custom components. They won't retrain backward compat. Isn't there a better way for this? --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat pull request #:
Github user michael-o commented on the pull request: https://github.com/apache/tomcat/commit/eb195bebac8239b994fa921aeedb136a93e4ccaf#commitcomment-29778594 In java/org/apache/catalina/core/ApplicationContext.java: In java/org/apache/catalina/core/ApplicationContext.java on line 419: @markt-asf Just stumbled upon this in our code with the target path for `forward`: `/WEB-INF/fo00_1385+0.jsp`. `URLDecoder` is the wrong class to use in several spots if your grep for. Javadoc says: bq. Utility class for HTML form decoding. This class contains static methods for decoding a String from the `application/x-www-form-urlencoded` MIME format. This is *not* URI encoding. What happens in my case is that from `/WEB-INF/fo00_1385+0.jsp` `/WEB-INF/fo00_1385 0.jsp` arrives at the end. This looks plain wrong to me. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat issue #115: Setting Timezone to GMT for Expires Header as per RFC1123
Github user michael-o commented on the issue: https://github.com/apache/tomcat/pull/115 @rainerjung My question simply was that if `Expires: 0` denotes a value in the past (expired already), why should I explicitly use a valid header in the past which requires more code to create as well as the bytes transported? --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat issue #115: Setting Timezone to GMT for Expires Header as per RFC1123
Github user michael-o commented on the issue: https://github.com/apache/tomcat/pull/115 Here is the reference commit: https://github.com/apache/httpd/commit/60087a708b051c3c987b80abdfdc3f2e046ebc4d @rainerjung How is `APR_DATE_BAD` defined? Unparsable? Or before Unix epoch? I still don't see how `Expires: 1970...` is better than `Expires: 0` when both are perfectly valid. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat issue #115: Setting Timezone to GMT for Expires Header as per RFC1123
Github user michael-o commented on the issue: https://github.com/apache/tomcat/pull/115 Thanks for the explanation. I hardly believe that Chrome does not implement `Expires: 0`. At best, we inquire with the Chromium project. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat issue #115: Setting Timezone to GMT for Expires Header as per RFC1123
Github user michael-o commented on the issue: https://github.com/apache/tomcat/pull/115 @pandareen, how do you know that Chrome does not understand it? --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat issue #115: Setting Timezone to GMT for Expires Header as per RFC1123
Github user michael-o commented on the issue: https://github.com/apache/tomcat/pull/115 I'd rather use `0` according to the spec. Moreover, it has less bytes to transfer. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat pull request #98: Fix for BZ62048
Github user michael-o commented on a diff in the pull request:
https://github.com/apache/tomcat/pull/98#discussion_r195838254
--- Diff: java/org/apache/catalina/manager/host/HTMLHostManagerServlet.java
---
@@ -173,6 +177,36 @@ protected String add(HttpServletRequest request,String
name,
return stringWriter.toString();
}
+/**
+ * Log out by invalidating the current session and sending 401
+ * in order to prompt user for new login upon next access.
+ *
+ * @param request The Servlet request
+ * @param response The Servlet response
+ */
+protected void logout(HttpServletRequest request, HttpServletResponse
response) throws IOException {
+response.setHeader("WWW-Authenticate","Basic realm=\"Login
required\"");
--- End diff --
I don't like this because you assume from within the code that the auth
mech is basic which is not always true.
---
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat issue #115: Setting Timezone to GMT for Expires Header as per RFC1123
Github user michael-o commented on the issue: https://github.com/apache/tomcat/pull/115 The format is described here: https://tools.ietf.org/html/rfc7231#section-7.1.1.1 Why not the stuff altogether and store the preformatted string in a static final? We can also use the value of `0` for expired stuff according to the RFC. @markt-asf --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat issue #96: Remove PUT and DELETE methods from an OPTIONS request if r...
Github user michael-o commented on the issue: https://github.com/apache/tomcat/pull/96 Alright, did not notice that. Mark has to tell wether he is willing to change this in 9.0. The other version likely won't change. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat issue #96: Remove PUT and DELETE methods from an OPTIONS request if r...
Github user michael-o commented on the issue: https://github.com/apache/tomcat/pull/96 @kdombeck Correct. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat issue #96: Remove PUT and DELETE methods from an OPTIONS request if r...
Github user michael-o commented on the issue: https://github.com/apache/tomcat/pull/96 Why is `POST` not part of the writable commands? --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat issue #96: Remove PUT and DELETE methods from an OPTIONS request if r...
Github user michael-o commented on the issue: https://github.com/apache/tomcat/pull/96 @markt-asf I'd second the 405 instead of 403. --- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] tomcat pull request #:
Github user michael-o commented on the pull request:
https://github.com/apache/tomcat/commit/d46012cb159c3384303eeceffc54eb78e6a62671#commitcomment-21548024
In java/org/apache/el/Messages.properties:
In java/org/apache/el/Messages.properties on line 32:
Shall it really output `'#{..}'` or rather `#{..}`? I wasn't certain about
the intention here during fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [Bug 54559] [PATCH] 1.1.27 needs APR = 1.3.0
Am 2013-02-14 00:43, schrieb bugzi...@apache.org: https://issues.apache.org/bugzilla/show_bug.cgi?id=54559 Rainer Jung rainer.j...@kippdata.de changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Rainer Jung rainer.j...@kippdata.de --- Thanks for the patch. Applied to 1.1.x in r1445989. Will be part of version 1.1.28. Why did you guys introduce a minor version bump of an important dependency in a patch version? I would have expected this for tcnative 1.2. This does not adhere to the Apache versioning scheme. Michael - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: RTC: Synchronize Tomcat 6 conf/web.xml mime mapping with Tomcat 7 [bug 54527]
Am 2013-02-12 20:32, schrieb Mark Thomas: On 12/02/2013 19:27, Michael-O wrote: Hi dev, by Konstantin's request I am asking the devs to consider synchronizing Tomcat 6 conf/web.xml mime mappings with Tomcat 7. In my opinion it would be very benificial for the entire user base when both mime mappings sections would be in sync inspite the growth in size. I recently had the chore to add several mappings manually although Tomcat 7 has them already. I am willing to provide an initial patch. Great. Attach the patch to the BZ issue. Patch attached: https://issues.apache.org/bugzilla/attachment.cgi?id=29952action=edit Mike - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
RTC: Synchronize Tomcat 6 conf/web.xml mime mapping with Tomcat 7 [bug 54527]
Hi dev, by Konstantin's request I am asking the devs to consider synchronizing Tomcat 6 conf/web.xml mime mappings with Tomcat 7. In my opinion it would be very benificial for the entire user base when both mime mappings sections would be in sync inspite the growth in size. I recently had the chore to add several mappings manually although Tomcat 7 has them already. I am willing to provide an initial patch. Thanks, Michael - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
