(tomcat) 04/08: Add additional comment to this relative performance test
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 4332382bb11d86197bfce2e9ca14c75a3c433225
Author: Mark Thomas
AuthorDate: Mon Jan 8 12:08:41 2024 +
Add additional comment to this relative performance test
---
test/org/apache/catalina/connector/TestResponsePerformance.java | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/test/org/apache/catalina/connector/TestResponsePerformance.java
b/test/org/apache/catalina/connector/TestResponsePerformance.java
index eb1236e80b..e88164c59a 100644
--- a/test/org/apache/catalina/connector/TestResponsePerformance.java
+++ b/test/org/apache/catalina/connector/TestResponsePerformance.java
@@ -24,6 +24,10 @@ import org.junit.Test;
import org.apache.catalina.startup.LoggingBaseTest;
import org.apache.tomcat.unittest.TesterRequest;
+/*
+ * This is a relative performance test so it remains part of the standard test
run. If the test fails then we need to
+ * looking at why and possibly disable/remove the homebrew approach for some
OS/Java combinations.
+ */
public class TestResponsePerformance extends LoggingBaseTest {
private static final int ITERATIONS = 10;
@@ -38,9 +42,8 @@ public class TestResponsePerformance extends LoggingBaseTest {
doHomebrew(resp);
doUri();
-// Note: Java 9 on my OSX laptop consistently shows doUri() is faster
-// than doHomebrew(). Worth a closer look for Tomcat 10 on the
-// assumption it will require java 9
+// Note: With Java 11 the 'homebrew' approach is consistently 3-4
times faster on both MacOS (Intel) and Linux
+// With Java 22 EA the 'homebrew' approach is consistently a
little over 2x faster on MacOS (M1)
// To allow for timing differences between runs, a "best of n" approach
// is taken for this test
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
(tomcat) 04/08: Add additional comment to this relative performance test
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit b655e6e4e62714404329f8cefc86144b4c394654
Author: Mark Thomas
AuthorDate: Mon Jan 8 12:08:41 2024 +
Add additional comment to this relative performance test
---
test/org/apache/catalina/connector/TestResponsePerformance.java | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/test/org/apache/catalina/connector/TestResponsePerformance.java
b/test/org/apache/catalina/connector/TestResponsePerformance.java
index 044fcfd3da..364829653f 100644
--- a/test/org/apache/catalina/connector/TestResponsePerformance.java
+++ b/test/org/apache/catalina/connector/TestResponsePerformance.java
@@ -24,6 +24,10 @@ import org.junit.Test;
import org.apache.catalina.startup.LoggingBaseTest;
import org.apache.tomcat.unittest.TesterRequest;
+/*
+ * This is a relative performance test so it remains part of the standard test
run. If the test fails then we need to
+ * looking at why and possibly disable/remove the homebrew approach for some
OS/Java combinations.
+ */
public class TestResponsePerformance extends LoggingBaseTest {
private static final int ITERATIONS = 100;
@@ -38,8 +42,8 @@ public class TestResponsePerformance extends LoggingBaseTest {
doHomebrew(resp);
doUri();
-// Note: With Java 11 the 'homebrew' approach is consistently 3 to 4
-// times faster on both MacOS and Linux
+// Note: With Java 11 the 'homebrew' approach is consistently 3-4
times faster on both MacOS (Intel) and Linux
+// With Java 22 EA the 'homebrew' approach is consistently a
little over 2x faster on MacOS (M1)
// To allow for timing differences between runs, a "best of n" approach
// is taken for this test
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
(tomcat) 04/08: Add additional comment to this relative performance test
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit a574b5af78fb54ab934bca32bac7757be230c0a4
Author: Mark Thomas
AuthorDate: Mon Jan 8 12:08:41 2024 +
Add additional comment to this relative performance test
---
test/org/apache/catalina/connector/TestResponsePerformance.java | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/test/org/apache/catalina/connector/TestResponsePerformance.java
b/test/org/apache/catalina/connector/TestResponsePerformance.java
index 100a20b38f..62c2e1db92 100644
--- a/test/org/apache/catalina/connector/TestResponsePerformance.java
+++ b/test/org/apache/catalina/connector/TestResponsePerformance.java
@@ -24,6 +24,10 @@ import org.junit.Test;
import org.apache.catalina.startup.LoggingBaseTest;
import org.apache.tomcat.unittest.TesterRequest;
+/*
+ * This is a relative performance test so it remains part of the standard test
run. If the test fails then we need to
+ * looking at why and possibly disable/remove the homebrew approach for some
OS/Java combinations.
+ */
public class TestResponsePerformance extends LoggingBaseTest {
private static final int ITERATIONS = 100;
@@ -38,8 +42,8 @@ public class TestResponsePerformance extends LoggingBaseTest {
doHomebrew(resp);
doUri();
-// Note: With Java 11 the 'homebrew' approach is consistently 3 to 4
-// times faster on both MacOS and Linux
+// Note: With Java 11 the 'homebrew' approach is consistently 3-4
times faster on both MacOS (Intel) and Linux
+// With Java 22 EA the 'homebrew' approach is consistently a
little over 2x faster on MacOS (M1)
// To allow for timing differences between runs, a "best of n" approach
// is taken for this test
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
