Re: (tomcat) branch 10.1.x updated: Add native access to the scripts
Thanks Rémy. Things happen, at least we found it before it hit the street. Am 11.04.24 um 20:52 schrieb Rémy Maucherat: On Thu, Apr 11, 2024 at 7:21 PM Rainer Jung wrote: Hi Rémy, I think this breaks 10.1 on Java 11, since --enable-native-access was introduced later. I was certain I tested it properly with 11, it worked and I thought it was added as a noop to a later build. Actually, it seems I made a dumb mistake somewhere while testing, so I will simply remove the patch. Rémy Best regards, Rainer Am 22.03.24 um 14:13 schrieb r...@apache.org: This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 6550e203a8 Add native access to the scripts 6550e203a8 is described below commit 6550e203a8119683f38c182cbfbb9b56587c54a0 Author: remm AuthorDate: Fri Mar 22 13:33:27 2024 +0100 Add native access to the scripts --- bin/catalina.bat | 1 + bin/catalina.sh | 1 + 2 files changed, 2 insertions(+) diff --git a/bin/catalina.bat b/bin/catalina.bat index 9c55ae940e..9a30371013 100755 --- a/bin/catalina.bat +++ b/bin/catalina.bat @@ -223,6 +223,7 @@ set "JAVA_OPTS=%JAVA_OPTS% --add-opens=java.base/java.io=ALL-UNNAMED" set "JAVA_OPTS=%JAVA_OPTS% --add-opens=java.base/java.util=ALL-UNNAMED" set "JAVA_OPTS=%JAVA_OPTS% --add-opens=java.base/java.util.concurrent=ALL-UNNAMED" set "JAVA_OPTS=%JAVA_OPTS% --add-opens=java.rmi/sun.rmi.transport=ALL-UNNAMED" +set "JAVA_OPTS=%JAVA_OPTS% --enable-native-access=ALL-UNNAMED" rem - Execute The Requested Command --- diff --git a/bin/catalina.sh b/bin/catalina.sh index 32f87ffb6f..ed647a2dea 100755 --- a/bin/catalina.sh +++ b/bin/catalina.sh @@ -296,6 +296,7 @@ JAVA_OPTS="$JAVA_OPTS --add-opens=java.base/java.io=ALL-UNNAMED" JAVA_OPTS="$JAVA_OPTS --add-opens=java.base/java.util=ALL-UNNAMED" JAVA_OPTS="$JAVA_OPTS --add-opens=java.base/java.util.concurrent=ALL-UNNAMED" JAVA_OPTS="$JAVA_OPTS --add-opens=java.rmi/sun.rmi.transport=ALL-UNNAMED" +JAVA_OPTS="$JAVA_OPTS --enable-native-access=ALL-UNNAMED" # - Execute The Requested Command - - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: (tomcat) branch 10.1.x updated: Add native access to the scripts
On Thu, Apr 11, 2024 at 7:21 PM Rainer Jung wrote: > > Hi Rémy, > > I think this breaks 10.1 on Java 11, since --enable-native-access was > introduced later. I was certain I tested it properly with 11, it worked and I thought it was added as a noop to a later build. Actually, it seems I made a dumb mistake somewhere while testing, so I will simply remove the patch. Rémy > Best regards, > > Rainer > > Am 22.03.24 um 14:13 schrieb r...@apache.org: > > This is an automated email from the ASF dual-hosted git repository. > > > > remm pushed a commit to branch 10.1.x > > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > > > > The following commit(s) were added to refs/heads/10.1.x by this push: > > new 6550e203a8 Add native access to the scripts > > 6550e203a8 is described below > > > > commit 6550e203a8119683f38c182cbfbb9b56587c54a0 > > Author: remm > > AuthorDate: Fri Mar 22 13:33:27 2024 +0100 > > > > Add native access to the scripts > > --- > > bin/catalina.bat | 1 + > > bin/catalina.sh | 1 + > > 2 files changed, 2 insertions(+) > > > > diff --git a/bin/catalina.bat b/bin/catalina.bat > > index 9c55ae940e..9a30371013 100755 > > --- a/bin/catalina.bat > > +++ b/bin/catalina.bat > > @@ -223,6 +223,7 @@ set "JAVA_OPTS=%JAVA_OPTS% > > --add-opens=java.base/java.io=ALL-UNNAMED" > > set "JAVA_OPTS=%JAVA_OPTS% --add-opens=java.base/java.util=ALL-UNNAMED" > > set "JAVA_OPTS=%JAVA_OPTS% > > --add-opens=java.base/java.util.concurrent=ALL-UNNAMED" > > set "JAVA_OPTS=%JAVA_OPTS% > > --add-opens=java.rmi/sun.rmi.transport=ALL-UNNAMED" > > +set "JAVA_OPTS=%JAVA_OPTS% --enable-native-access=ALL-UNNAMED" > > > > rem - Execute The Requested Command > > --- > > > > diff --git a/bin/catalina.sh b/bin/catalina.sh > > index 32f87ffb6f..ed647a2dea 100755 > > --- a/bin/catalina.sh > > +++ b/bin/catalina.sh > > @@ -296,6 +296,7 @@ JAVA_OPTS="$JAVA_OPTS > > --add-opens=java.base/java.io=ALL-UNNAMED" > > JAVA_OPTS="$JAVA_OPTS --add-opens=java.base/java.util=ALL-UNNAMED" > > JAVA_OPTS="$JAVA_OPTS > > --add-opens=java.base/java.util.concurrent=ALL-UNNAMED" > > JAVA_OPTS="$JAVA_OPTS --add-opens=java.rmi/sun.rmi.transport=ALL-UNNAMED" > > +JAVA_OPTS="$JAVA_OPTS --enable-native-access=ALL-UNNAMED" > > > > # - Execute The Requested Command > > - > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: (tomcat) branch 10.1.x updated: Add native access to the scripts
Hi Rémy, I think this breaks 10.1 on Java 11, since --enable-native-access was introduced later. Best regards, Rainer Am 22.03.24 um 14:13 schrieb r...@apache.org: This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 6550e203a8 Add native access to the scripts 6550e203a8 is described below commit 6550e203a8119683f38c182cbfbb9b56587c54a0 Author: remm AuthorDate: Fri Mar 22 13:33:27 2024 +0100 Add native access to the scripts --- bin/catalina.bat | 1 + bin/catalina.sh | 1 + 2 files changed, 2 insertions(+) diff --git a/bin/catalina.bat b/bin/catalina.bat index 9c55ae940e..9a30371013 100755 --- a/bin/catalina.bat +++ b/bin/catalina.bat @@ -223,6 +223,7 @@ set "JAVA_OPTS=%JAVA_OPTS% --add-opens=java.base/java.io=ALL-UNNAMED" set "JAVA_OPTS=%JAVA_OPTS% --add-opens=java.base/java.util=ALL-UNNAMED" set "JAVA_OPTS=%JAVA_OPTS% --add-opens=java.base/java.util.concurrent=ALL-UNNAMED" set "JAVA_OPTS=%JAVA_OPTS% --add-opens=java.rmi/sun.rmi.transport=ALL-UNNAMED" +set "JAVA_OPTS=%JAVA_OPTS% --enable-native-access=ALL-UNNAMED" rem - Execute The Requested Command --- diff --git a/bin/catalina.sh b/bin/catalina.sh index 32f87ffb6f..ed647a2dea 100755 --- a/bin/catalina.sh +++ b/bin/catalina.sh @@ -296,6 +296,7 @@ JAVA_OPTS="$JAVA_OPTS --add-opens=java.base/java.io=ALL-UNNAMED" JAVA_OPTS="$JAVA_OPTS --add-opens=java.base/java.util=ALL-UNNAMED" JAVA_OPTS="$JAVA_OPTS --add-opens=java.base/java.util.concurrent=ALL-UNNAMED" JAVA_OPTS="$JAVA_OPTS --add-opens=java.rmi/sun.rmi.transport=ALL-UNNAMED" +JAVA_OPTS="$JAVA_OPTS --enable-native-access=ALL-UNNAMED" # - Execute The Requested Command - - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
(tomcat) branch 10.1.x updated: Add native access to the scripts
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 6550e203a8 Add native access to the scripts 6550e203a8 is described below commit 6550e203a8119683f38c182cbfbb9b56587c54a0 Author: remm AuthorDate: Fri Mar 22 13:33:27 2024 +0100 Add native access to the scripts --- bin/catalina.bat | 1 + bin/catalina.sh | 1 + 2 files changed, 2 insertions(+) diff --git a/bin/catalina.bat b/bin/catalina.bat index 9c55ae940e..9a30371013 100755 --- a/bin/catalina.bat +++ b/bin/catalina.bat @@ -223,6 +223,7 @@ set "JAVA_OPTS=%JAVA_OPTS% --add-opens=java.base/java.io=ALL-UNNAMED" set "JAVA_OPTS=%JAVA_OPTS% --add-opens=java.base/java.util=ALL-UNNAMED" set "JAVA_OPTS=%JAVA_OPTS% --add-opens=java.base/java.util.concurrent=ALL-UNNAMED" set "JAVA_OPTS=%JAVA_OPTS% --add-opens=java.rmi/sun.rmi.transport=ALL-UNNAMED" +set "JAVA_OPTS=%JAVA_OPTS% --enable-native-access=ALL-UNNAMED" rem - Execute The Requested Command --- diff --git a/bin/catalina.sh b/bin/catalina.sh index 32f87ffb6f..ed647a2dea 100755 --- a/bin/catalina.sh +++ b/bin/catalina.sh @@ -296,6 +296,7 @@ JAVA_OPTS="$JAVA_OPTS --add-opens=java.base/java.io=ALL-UNNAMED" JAVA_OPTS="$JAVA_OPTS --add-opens=java.base/java.util=ALL-UNNAMED" JAVA_OPTS="$JAVA_OPTS --add-opens=java.base/java.util.concurrent=ALL-UNNAMED" JAVA_OPTS="$JAVA_OPTS --add-opens=java.rmi/sun.rmi.transport=ALL-UNNAMED" +JAVA_OPTS="$JAVA_OPTS --enable-native-access=ALL-UNNAMED" # - Execute The Requested Command - - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
