[Bug 52751] Optimized configuration of the system info displayed in the default error page

2014-05-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52751

--- Comment #10 from polina.gen...@gmail.com ---
Hi Violeta, 

Yes, the given solution perfectly solves my use case.

Thanks and regards,
Polina

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 52751] Optimized configuration of the system info displayed in the default error page

2014-05-14 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52751

Violeta Georgieva violet...@apache.org changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #11 from Violeta Georgieva violet...@apache.org ---
Ok 
Thanks

Violeta

*** This bug has been marked as a duplicate of bug 56383 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 52751] Optimized configuration of the system info displayed in the default error page

2014-04-25 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52751

--- Comment #9 from Violeta Georgieva violet...@apache.org ---
Hi Polina,

Check Bug 56383.
Do you think that the enhancement solves your use case?

Regards
Violeta

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 52751] Optimized configuration of the system info displayed in the default error page

2012-05-03 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52751

--- Comment #8 from polina.gen...@gmail.com ---
Hi,

What do you think of my previous comment – in this case should I provide server
attribute handling for the AJP connector in addition to the given patch?

I’m looking forward hearing from you, whatever the outcome is. 

Thanks in advance,
Polina

-- 
You are receiving this mail because:
You are the assignee for the bug.


DO NOT REPLY [Bug 52751] Optimized configuration of the system info displayed in the default error page

2012-04-11 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52751

--- Comment #7 from polina.gen...@gmail.com 2012-04-11 14:41:25 UTC ---
(In reply to comment #6)
 (In reply to comment #5)
  Maybe the server attribute should be exposed through AbstractProtocol or
  Endpoint or elsewhere.
 I'll check that.

Thanks for the hint!

Indeed using
server = ((AbstractAjpProtocol)
response.getConnector().getProtocolHandler()).getProperty(server) 
will right away do the job in the case of AJP connector (if there is server
attribute configured for it).

The problem is that the server attribute is currently not explicitly handled
for the AJP connector (unlike the HttpConnecor), meaning this attribute is not
documented and its value is not read or used anywhere in the AJP connector
implementation. 
Do you think we should revise this behavior and add server attribute handling
for the AJP connector?

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 52751] Optimized configuration of the system info displayed in the default error page

2012-03-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52751

violet...@apache.org changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WONTFIX |

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 52751] Optimized configuration of the system info displayed in the default error page

2012-03-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52751

--- Comment #5 from Konstantin Kolinko knst.koli...@gmail.com 2012-03-22 
13:22:16 UTC ---
I am OK with the patch, but there is a problem: it would not work if Tomcat is
accessed through AJP protocol.  The patch relies on the use of
AbstractHttp11Protocol to get the server setting.

Maybe the server attribute should be exposed through AbstractProtocol or
Endpoint or elsewhere.

I had a fear that the default value of server attribute which is documented
to be Apache-Coyote/1.1 will be visible here. Actually it should not be the
case here. The Apache-Coyote/1.1 string (aka Constants.SERVER_BYTES) is used
by AbstractHttp11Processor only if the server attribute is null.


 I would prefer to see the exact Tomcat version in the server header

+1.

I wonder though how coyote can get Tomcat version. Wouldn't that add an
unwanted dependency between components.


 particularly the line numbers in any stack trace.

The stack traces can be hidden. Most error pages do not display them. One can
configure a custom error page for error 500.

 manipulating directly the jar file.

Note, that there is no need to manipulate the jar file! One can create the
following file:
CATALINA_BASE/lib/org/apache/catalina/util/ServerInfo.properties

(I thought it is mentioned in the FAQ, but cannot find it at this moment). It
is written here:
http://tomcat.apache.org/tomcat-7.0-doc/security-howto.html#Valves

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 52751] Optimized configuration of the system info displayed in the default error page

2012-03-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52751

--- Comment #6 from violet...@apache.org 2012-03-22 13:37:42 UTC ---
(In reply to comment #5)
 Maybe the server attribute should be exposed through AbstractProtocol or
 Endpoint or elsewhere.

I'll check that.

 Note, that there is no need to manipulate the jar file! One can create the
 following file:
 CATALINA_BASE/lib/org/apache/catalina/util/ServerInfo.properties

Unforutnately it is not so easy for us. We (Eclipse Virgo) are embeding Tomcat.
Classloaders are a bit different in OSGi environment.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 52751] Optimized configuration of the system info displayed in the default error page

2012-03-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52751

--- Comment #3 from violet...@apache.org 2012-03-21 20:23:15 UTC ---
Hi,

I agreed with your points.

Unfortunately in some installation scenarios we do not have either access to
the jar files or permissions to restart the system in order to configure the
default error page footer, manipulating directly the jar file. 

With this small improvement Tomcat will provide convenient way for configuring
default error page footer not only through the server.xml but also during
runtime using provided Connectors MBeans.

What do you think?

Regards
Violeta Georgieva

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 52751] Optimized configuration of the system info displayed in the default error page

2012-03-21 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52751

violet...@apache.org changed:

   What|Removed |Added

  Attachment #28372|application/octet-stream|application/x-zip-compresse
  mime type||d

--- Comment #4 from violet...@apache.org 2012-03-21 20:25:11 UTC ---
Comment on attachment 28372
  -- https://issues.apache.org/bugzilla/attachment.cgi?id=28372
Patch in ErrorReportValve.java and docu page + 2 screenshots

Corrected patch MIME type

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 52751] Optimized configuration of the system info displayed in the default error page

2012-03-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52751

Mark Thomas ma...@apache.org changed:

   What|Removed |Added

  Attachment #28372|1   |0
   is patch||
  Attachment #28372|text/plain  |application/octet-stream
  mime type||

--- Comment #1 from Mark Thomas ma...@apache.org 2012-03-20 21:54:42 UTC ---
Comment on attachment 28372
  -- https://issues.apache.org/bugzilla/attachment.cgi?id=28372
Patch in ErrorReportValve.java and docu page + 2 screenshots

Correct patch MIME type so BZ doesn't try to display it.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 52751] Optimized configuration of the system info displayed in the default error page

2012-03-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52751

Mark Thomas ma...@apache.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX

--- Comment #2 from Mark Thomas ma...@apache.org 2012-03-20 22:11:07 UTC ---
It is very rare for an attacker to identify the specific Tomcat version and
then target a known vulnerability. It is much more common to see every known
vulnerability probed (for a range of servers) rather than the more targeted
attack described in the patch. I therefore see little point in hiding the
version number. I'd go further than that and say I would prefer to see the
exact Tomcat version in the server header since it provides more assistance to
debugging/monitoring efforts than it does harm.

Even if the version number is hidden there are plenty of other clues to the
exact version number, particularly the line numbers in any stack trace.

Rather than address this specific issue, I'd prefer to see a general solution
to bug 41007 that allowed custom error pages to be specified without having to
write a custom valve.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



DO NOT REPLY [Bug 52751] Optimized configuration of the system info displayed in the default error page

2012-02-24 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52751

violet...@apache.org changed:

   What|Removed |Added

 CC||violet...@apache.org
 OS/Version||All

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org