[Bug 56248] Automatic deployment with TCD deletes customized context.xml file

2014-03-17 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56248

Mark Thomas ma...@apache.org changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |FIXED

--- Comment #4 from Mark Thomas ma...@apache.org ---
I've fixed all of these issues for 8.0.x (8.0.4 onwards) and 7.0.x (7.0.53
onwards)

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 56248] Automatic deployment with TCD deletes customized context.xml file

2014-03-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56248

Konstantin Kolinko knst.koli...@gmail.com changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |---

--- Comment #3 from Konstantin Kolinko knst.koli...@gmail.com ---
Reviewing r1577199

Besides two small issues that I mentioned in Re: r1577199 thread on dev@, and
bug 56273, one more high-level one:

The logic in update=true case in
protected synchronized void deploy
(PrintWriter writer, ContextName cn,
 String tag, boolean update, HttpServletRequest request,
 StringManager smClient) {

is as follows:
1. mark webapp as serviced
2. delete old war
3. upload new war,
 that means to read the body of a PUT request and save it as file
4. trigger deployment, remove serviced mark

If step 3. fails due to aborted I/O, the old application will become
undeployed, deleting its custom configuration if there is any.

It would be better to upload it to a temporary name and rename the file.
A temporary name can be created with java.io.File.createTempFile(,,dir).

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 56248] Automatic deployment with TCD deletes customized context.xml file

2014-03-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56248

Mark Thomas ma...@apache.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

--- Comment #1 from Mark Thomas ma...@apache.org ---
This has been fixed in 8.0.x for 8.0.4 onwards and in 7.0.x for 5.0.53 onwards.

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [Bug 56248] Automatic deployment with TCD deletes customized context.xml file

2014-03-13 Thread sebb
On 13 March 2014 15:30,  bugzi...@apache.org wrote:
 https://issues.apache.org/bugzilla/show_bug.cgi?id=56248

 Mark Thomas ma...@apache.org changed:

What|Removed |Added
 
  Status|NEW |RESOLVED
  Resolution|--- |FIXED

 --- Comment #1 from Mark Thomas ma...@apache.org ---
 This has been fixed in 8.0.x for 8.0.4 onwards and in 7.0.x for 5.0.53 
 onwards.

5.0.53 ??

 --
 You are receiving this mail because:
 You are the assignee for the bug.

 -
 To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
 For additional commands, e-mail: dev-h...@tomcat.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 56248] Automatic deployment with TCD deletes customized context.xml file

2014-03-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56248

--- Comment #2 from Jesse Barnum jsb_apa...@360works.com ---
Wow, thank you!!!

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 56248] Automatic deployment with TCD deletes customized context.xml file

2014-03-12 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56248

Jesse Barnum jsb_apa...@360works.com changed:

   What|Removed |Added

 CC||jsb_apa...@360works.com

-- 
You are receiving this mail because:
You are the assignee for the bug.

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org