[Bug 57455] Bootstrap doesn't handle paths with one quote
https://issues.apache.org/bugzilla/show_bug.cgi?id=57455 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #4 from Mark Thomas --- Fixed in trunk and 8.0.x and will be included in 8.0.18 onwards. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 57455] Bootstrap doesn't handle paths with one quote
https://issues.apache.org/bugzilla/show_bug.cgi?id=57455 --- Comment #3 from Christopher Schultz --- (In reply to Mark Thomas from comment #1) > I'm leaning towards 'fixing' this by adding a comment that paths with '"' > are not permitted to catalina.propeties. +1 with an actual check for the condition and an error message, rather than odd-looking behavior, and another bug being filed down the road. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 57455] Bootstrap doesn't handle paths with one quote
https://issues.apache.org/bugzilla/show_bug.cgi?id=57455 --- Comment #2 from Tobias Stoeckmann --- Totally fine with that approach! -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 57455] Bootstrap doesn't handle paths with one quote
https://issues.apache.org/bugzilla/show_bug.cgi?id=57455 --- Comment #1 from Mark Thomas --- Thanks for the patch. I can confirm that it fixes the issues described. But... This has the potential to get messy. Neither " nor , is permitted in a file name in Windows but both are acceptable in unix and friends. We started off simply using ',' (comma) as a delimiter. This assumed ',' never appeared in the value. Then we had a bug report that paths containing ',' broke things. To fix this we added optional quoting using '"'. This allowed ',' to appear in the value if the value was quoted. This assumed '"' never appeared in a value. Now we have this bug. I am concerned that the proposed solution is a sticking plaster rather than a complete fix and that in a few months time we'll have someone raising a bug about a different edge case (I can already see several valid file names that will break this). Unless we switch to using an escape character of some form, we are always going to have these issues. And I'm not at all sure that escaping will be possible since the values being parsed are obtained - in the default case - via unescaped environment variables. I'm leaning towards 'fixing' this by adding a comment that paths with '"' are not permitted to catalina.propeties. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 57455] Bootstrap doesn't handle paths with one quote
https://issues.apache.org/bugzilla/show_bug.cgi?id=57455 Tobias Stoeckmann changed: What|Removed |Added Component|Catalina|Catalina Version|unspecified |trunk Product|Tomcat 9|Tomcat 8 Target Milestone|- | -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
