https://bz.apache.org/bugzilla/show_bug.cgi?id=61316
Bug ID: 61316
Summary: Test files used by TestEncodingDetector test are
broken in src.zip, src.tar.gz [8.5.18]
Product: Tomcat 8
Version: 8.5.x-trunk
Hardware: PC
Status: NEW
Severity: normal
Priority: P2
Component: Packaging
Assignee: dev@tomcat.apache.org
Reporter: knst.koli...@gmail.com
Target Milestone: ----
Testing 8.5.18 (Release candidate) from apache-tomcat-8.5.18-src.zip
the following test is consistently failing:
org.apache.jasper.compiler.TestEncodingDetector
Testing on Windows 10, Java 8/Java 7 x all connectors - all are failing.
Comparing unpacked -src.zip with fresh checkout of the tag,
the files used by this test differ.
>svn st
M test\webapp\jsp\encoding\bom-none-prolog-utf16be.jspx
M test\webapp\jsp\encoding\bom-none-prolog-utf16le.jspx
M test\webapp\jsp\encoding\bom-utf16be-prolog-none.jsp
M test\webapp\jsp\encoding\bom-utf16be-prolog-none.jspx
M test\webapp\jsp\encoding\bom-utf16be-prolog-utf16be.jspx
M test\webapp\jsp\encoding\bom-utf16be-prolog-utf16le.jspx
M test\webapp\jsp\encoding\bom-utf16be-prolog-utf8.jspx
M test\webapp\jsp\encoding\bom-utf16le-prolog-none.jsp
M test\webapp\jsp\encoding\bom-utf16le-prolog-none.jspx
M test\webapp\jsp\encoding\bom-utf16le-prolog-utf16be.jspx
M test\webapp\jsp\encoding\bom-utf16le-prolog-utf16le.jspx
M test\webapp\jsp\encoding\bom-utf16le-prolog-utf8.jspx
The list of diffing files is the same for -src.zip and -src.tar.gz.
Looking into the files from src.zip with a hex editor
(e.g. bom-none-prolog-utf16be.jspx), I see sequences like
000D 0A00 0D0A
These '0D0A' sequences apparently originate from LF -> CRLF conversion that
treated these 16-bit files as 8-bit ones.
Looking into the files from src.tar.gz, I see
000A 000A
All line wraps are doubled - there are additional empty lines everywhere.
The correct file in svn repository has
000D 000A
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
