[Bug 62539] WsSession cannot be GC while send close message timeout

2018-08-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62539

saiya <1005136...@qq.com> changed:

   What|Removed |Added

 Resolution|INVALID |---
 Status|RESOLVED|REOPENED

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62539] WsSession cannot be GC while send close message timeout

2018-08-08 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62539

--- Comment #5 from saiya <1005136...@qq.com> ---
Created attachment 36077
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=36077=edit
analysis

Thank you very much. What you said is right.
I think it has something to do with the network.

java.net.SocketTimeoutException: The current message was not fully sent within
the specified timeout
at
org.apache.tomcat.websocket.WsRemoteEndpointImplBase.sendMessageBlock(WsRemoteEndpointImplBase.java:299)
~[tomcat-embed-websocket-8.5.29.jar:8.5.29]
at
org.apache.tomcat.websocket.WsRemoteEndpointImplBase.sendMessageBlock(WsRemoteEndpointImplBase.java:258)
~[tomcat-embed-websocket-8.5.29.jar:8.5.29]
at
org.apache.tomcat.websocket.WsSession.sendCloseMessage(WsSession.java:592)
~[tomcat-embed-websocket-8.5.29.jar:8.5.29]
at org.apache.tomcat.websocket.WsSession.doClose(WsSession.java:480)
~[tomcat-embed-websocket-8.5.29.jar:8.5.29]
at org.apache.tomcat.websocket.WsSession.close(WsSession.java:445)
~[tomcat-embed-websocket-8.5.29.jar:8.5.29]
at org.apache.tomcat.websocket.WsSession.close(WsSession.java:439)
~[tomcat-embed-websocket-8.5.29.jar:8.5.29]

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62539] WsSession cannot be GC while send close message timeout

2018-08-07 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62539

Mark Thomas  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEW |RESOLVED

--- Comment #4 from Mark Thomas  ---
I can't reproduced the issue with a Tomcat unit test and inspection of the
provided test case indicates that there is a memory leak in the provided test
case.

WebSocketServer.onMessage(String message, Session session) never exits. Hence
the WebSocket session will be pinned in memory even after the session has been
closed. The while loop should be constructed in such a way that the loop exists
once the session is closed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62539] WsSession cannot be GC while send close message timeout

2018-08-07 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62539

--- Comment #3 from Mark Thomas  ---
The test applications provided are far from the simplest possible - both being
full Spring Boot applications. Further, the server application fails to build.

I've looked at the source and the test case is very similar to some existing
Tomcat test cases. I've tried to recreate the reported issue with the existing
test cases without any success.

The next step is to try and create a Tomcat 'unit' test that mirrors the
provided test applications.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62539] WsSession cannot be GC while send close message timeout

2018-08-06 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62539

saiya <1005136...@qq.com> changed:

   What|Removed |Added

 Status|NEEDINFO|NEW

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62539] WsSession cannot be GC while send close message timeout

2018-08-06 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62539

--- Comment #2 from saiya <1005136...@qq.com> ---
Created attachment 36074
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=36074=edit
code

1.start web socket server and  web socket client
2.debug break point on line 18
com.hx.ws.client.endpoint.WebSocketMessageHandler
3.web socket server will throw exception and close
4.web socket server WsSession more and more

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 62539] WsSession cannot be GC while send close message timeout

2018-08-06 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=62539

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |NEEDINFO

--- Comment #1 from Mark Thomas  ---
There is insufficient information in this bug report to investigate.

The description does not make clear if the Tomcat WebSocket implementation is
being used as the client, the server or both.

The description does not identify which side of the connection fails to send
the close message.

The description does not describe which side of the connection experiences the
memory leak.

The description does not include the GC root information for the held objects.

This additional information needs to be provided before the bug report can be
investigated.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org