[Bug 64710] NullPointerException in Http2UpgradeHandler.endRequestBodyFrame and BufferOverflowException in SocketBufferHandler
https://bz.apache.org/bugzilla/show_bug.cgi?id=64710 --- Comment #21 from Doug Whitfield --- Arshiya, I am trying to reproduce this issue using the provided application, but changing the pom file to be Tomcat 9.0.17. The goal is to determine if we can roll back to 9.0.17. The test application does not appear to have any logs printed. There is no exception printed on the command line. I would anticipate this means that 9.0.17 does not contain this issue. Can you provide clarity on where in the test application these exceptions should show up? Thanks! -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 64710] NullPointerException in Http2UpgradeHandler.endRequestBodyFrame and BufferOverflowException in SocketBufferHandler
https://bz.apache.org/bugzilla/show_bug.cgi?id=64710 --- Comment #20 from Doug Whitfield --- The earliest reference here is 9.0.36. Is there any reason to believe this exists in any version before that? Thanks! -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 64710] NullPointerException in Http2UpgradeHandler.endRequestBodyFrame and BufferOverflowException in SocketBufferHandler
https://bz.apache.org/bugzilla/show_bug.cgi?id=64710 Mark Thomas changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |FIXED --- Comment #19 from Mark Thomas --- BufferOverflowException fixed in: Fixed in: - master for 10.0.0-M9 onwards - 9.0.x for 9.0.39 onwards 8.5.x is not affected. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 64710] NullPointerException in Http2UpgradeHandler.endRequestBodyFrame and BufferOverflowException in SocketBufferHandler
https://bz.apache.org/bugzilla/show_bug.cgi?id=64710 Mark Thomas changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #18 from Mark Thomas --- None. We need a test case that reliably reproduces the issue. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 64710] NullPointerException in Http2UpgradeHandler.endRequestBodyFrame and BufferOverflowException in SocketBufferHandler
https://bz.apache.org/bugzilla/show_bug.cgi?id=64710 --- Comment #17 from Arshiya --- Any update on this please ? Thanks ! -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 64710] NullPointerException in Http2UpgradeHandler.endRequestBodyFrame and BufferOverflowException in SocketBufferHandler
https://bz.apache.org/bugzilla/show_bug.cgi?id=64710 Arshiya changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #16 from Arshiya --- Hi Mark , It is only the BufferOverFlow stack trace that we get in our application. Also ,we have configured the maxThreads as 40 (in our application and the test source code that I had attached earlier) . Is maxThreads applicable for http2 as well ? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 64710] NullPointerException in Http2UpgradeHandler.endRequestBodyFrame and BufferOverflowException in SocketBufferHandler
https://bz.apache.org/bugzilla/show_bug.cgi?id=64710 Mark Thomas changed: What|Removed |Added Status|REOPENED|NEEDINFO --- Comment #15 from Mark Thomas --- I am unable to reproduce this with 9.0.x or 10.0.x. Ideally, we need a more reliable test case. Is it just the one stack trace you see with the BufferOverflowException? If there is more than one stack trace - or if other exceptions are present in the logs - it might be helpful to see each of them. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 64710] NullPointerException in Http2UpgradeHandler.endRequestBodyFrame and BufferOverflowException in SocketBufferHandler
https://bz.apache.org/bugzilla/show_bug.cgi?id=64710 Arshiya changed: What|Removed |Added Resolution|FIXED |--- Status|RESOLVED|REOPENED --- Comment #14 from Arshiya --- Mark , Thank you for the response. Sorry to have missed out on a few points. I tried testing the same , post the fix with the hash https://github.com/apache/tomcat/commit/ea0a200fe29829bd88fb6fecb5549158896b68ea I can still see the BufferOverflow Exception.Please help us with this. JMeter Version: apache-jmeter-4.0 (with additional plugin for HTTP2) I have attached the source code and jmx file to reproduce the issue . To build the source code I have pointed to 9.0.36 in the pom.xml, but while executing the application , the classpath where the the tomcat jars built from the given hash is referred. java -cp -jar tomcat-9-embedded-1.0.4.jar -Xmx1g - where the latest tomcat (9.0.38) jars are placed. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 64710] NullPointerException in Http2UpgradeHandler.endRequestBodyFrame and BufferOverflowException in SocketBufferHandler
https://bz.apache.org/bugzilla/show_bug.cgi?id=64710 --- Comment #13 from Arshiya --- Created attachment 37444 --> https://bz.apache.org/bugzilla/attachment.cgi?id=37444=edit JMX file and Source Code -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 64710] NullPointerException in Http2UpgradeHandler.endRequestBodyFrame and BufferOverflowException in SocketBufferHandler
https://bz.apache.org/bugzilla/show_bug.cgi?id=64710 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|--- |FIXED --- Comment #12 from Mark Thomas --- Fixed in: - master for 10.0.0-M8 onwards - 9.0.x for 9.0.38 onwards - 8.5.x for 8.5.58 onwards -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 64710] NullPointerException in Http2UpgradeHandler.endRequestBodyFrame and BufferOverflowException in SocketBufferHandler
https://bz.apache.org/bugzilla/show_bug.cgi?id=64710 --- Comment #11 from Mark Thomas --- No JMeter version specified. No mention that an additional plugin is required. No source provided for JAR file - it is very unlikely a Tomcat developer is going to download a random JAR from a bug report and run it. Despite the above, I have been able to reproduce this with some changes to the JMeter configuration to make requests against the examples web application that ships with Tomcat. I'm currently considering alternative ways to fix reduce the memory footprint of closed streams that doesn't involve nulling out references. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 64710] NullPointerException in Http2UpgradeHandler.endRequestBodyFrame and BufferOverflowException in SocketBufferHandler
https://bz.apache.org/bugzilla/show_bug.cgi?id=64710 --- Comment #10 from Mark Thomas --- "latest source code" is not specific. If you are going to build from source and then report a bug you need to provide the hash you build from. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 64710] NullPointerException in Http2UpgradeHandler.endRequestBodyFrame and BufferOverflowException in SocketBufferHandler
https://bz.apache.org/bugzilla/show_bug.cgi?id=64710 --- Comment #9 from Arshiya --- If there is any update Please let us know . -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 64710] NullPointerException in Http2UpgradeHandler.endRequestBodyFrame and BufferOverflowException in SocketBufferHandler
https://bz.apache.org/bugzilla/show_bug.cgi?id=64710 --- Comment #8 from Arshiya --- Correcting the servlet port number: http://localhost:1080/hello -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 64710] NullPointerException in Http2UpgradeHandler.endRequestBodyFrame and BufferOverflowException in SocketBufferHandler
https://bz.apache.org/bugzilla/show_bug.cgi?id=64710
Arshiya changed:
What|Removed |Added
Resolution|DUPLICATE |---
Status|RESOLVED|REOPENED
--- Comment #7 from Arshiya ---
Hi Mark ,
The Null Pointer Exception and BufferOverflowException is from the jars built
from the latest tomcat source code (9.0.x branch). It is not a duplicate of bug
64671.
1)I have attached the jmx file and jar to reproduce the
BufferOverflowException.
Steps to reproduce:
*Client side : JMeter (attached Reproduction.jmx file)
No of threads:200
Loop Count:10 (can be increased)
Port:1080
*Server side (Embedded tomcat application : attached
tomcat-9-embedded-1.0.4.jar)
This is based of the example project
https://github.com/jyeary/tomcat-9-embedded/ and modified to add HTTP2Upgrade
protocol.Servlet can be found at http://localhost:1090/hello.
java -cp -jar tomcat-9-embedded-1.0.4.jar -Xmx1g
- where the latest tomcat jars are placed.
2)The Null pointer Exception is due to Null check not being added in the
endRequestBodyFrame in Http2UpgradeHandler :
public void endRequestBodyFrame(int streamId)
throws Http2Exception
{
Stream stream = getStream(streamId, true);
stream.getInputBuffer().onDataAvailable();
}
Can you please check and help us with the fix.
Thank you !
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 64710] NullPointerException in Http2UpgradeHandler.endRequestBodyFrame and BufferOverflowException in SocketBufferHandler
https://bz.apache.org/bugzilla/show_bug.cgi?id=64710 --- Comment #6 from Arshiya --- Created attachment 37424 --> https://bz.apache.org/bugzilla/attachment.cgi?id=37424=edit Jar file This is based of the example project https://github.com/jyeary/tomcat-9-embedded/ and modified to add HTTP2Upgrade protocol.Servlet can be found at http://localhost:1090/hello. java -cp -jar tomcat-9-embedded-1.0.4.jar -Xmx1g - where the latest tomcat jars are placed. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 64710] NullPointerException in Http2UpgradeHandler.endRequestBodyFrame and BufferOverflowException in SocketBufferHandler
https://bz.apache.org/bugzilla/show_bug.cgi?id=64710 --- Comment #5 from Arshiya --- Created attachment 37423 --> https://bz.apache.org/bugzilla/attachment.cgi?id=37423=edit JMX file -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 64710] NullPointerException in Http2UpgradeHandler.endRequestBodyFrame and BufferOverflowException in SocketBufferHandler
https://bz.apache.org/bugzilla/show_bug.cgi?id=64710 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Mark Thomas --- *** This bug has been marked as a duplicate of bug 64671 *** -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 64710] NullPointerException in Http2UpgradeHandler.endRequestBodyFrame and BufferOverflowException in SocketBufferHandler
https://bz.apache.org/bugzilla/show_bug.cgi?id=64710 --- Comment #3 from Christopher Schultz --- ... and the application is, what, exactly? Can you get the Tomcat examples application to fail in this way with JMeter? -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 64710] NullPointerException in Http2UpgradeHandler.endRequestBodyFrame and BufferOverflowException in SocketBufferHandler
https://bz.apache.org/bugzilla/show_bug.cgi?id=64710 Arshiya changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #2 from Arshiya --- We got the exception while running the below case with message payload size 2kb Client - JMeter Memory : 1GB at jmeter side No of threads (users) : 200 Ram-Up period : 1 Loop count: 60 (or) can also be tried by stopping the client before receiving response -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 64710] NullPointerException in Http2UpgradeHandler.endRequestBodyFrame and BufferOverflowException in SocketBufferHandler
https://bz.apache.org/bugzilla/show_bug.cgi?id=64710 Remy Maucherat changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #1 from Remy Maucherat --- Please provide a test case. "Can you please explain the root cause for this exception and fix the issue . " This means you should investigate this in the user list first. You could have some concurrent operation recycling the request or something like that. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
