[GitHub] [tomcat] aooohan commented on pull request #402: Add support for Unix Domain Sockets (APR Protocol)

2022-07-17 Thread GitBox


aooohan commented on PR #402:
URL: https://github.com/apache/tomcat/pull/402#issuecomment-1186760769

   > What happens is the second request to the server causes the server to hang 
on the socket.
   
   I've found this bug for a long time, and not putting the wrapper in 
connections before throwing an exception to prevent a known OS bug has led to 
it not being closed in time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] aooohan commented on pull request #402: Add support for Unix Domain Sockets (APR Protocol)

2022-07-17 Thread GitBox


aooohan commented on PR #402:
URL: https://github.com/apache/tomcat/pull/402#issuecomment-1186760554

   > What happens is the second request to the server causes the server to hang 
on the socket.
   Inaddtion, this is a second bug. It is purely by chance that you encountered 
this bug. I've found that this bug exists for a long time, and not putting the 
wrapper in connections before throwing an exception to prevent a known OS bug 
has led to it not being closed in time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] aooohan commented on pull request #402: Add support for Unix Domain Sockets (APR Protocol)

2022-07-17 Thread GitBox


aooohan commented on PR #402:
URL: https://github.com/apache/tomcat/pull/402#issuecomment-1186747561

   > Thank you for the reply. So it looks like if you are below Java 16, it 
uses APR, and if above Java16, it uses the Java APIs. I think there is a bug in 
APREndpoint, as my example is using Java11 + APR. 
   
   Indeed, i have reproduced this bug.  You can report this bug again on BZ.
   
   > When I commented out the "duplicate accept check" code in 
APREndpoint.java, Java11 + APR = Unix Sockets working.
   
   This is use for protecting  against a known OS bug.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[GitHub] [tomcat] aooohan commented on pull request #402: Add support for Unix Domain Sockets (APR Protocol)

2022-07-15 Thread GitBox


aooohan commented on PR #402:
URL: https://github.com/apache/tomcat/pull/402#issuecomment-1185322091

   > Hey guys, My apologies to comment on a year-old PR, but I cannot get 
`unixDomainSocketPath` to work on Tomcat9 with the latest APR, Java11, Ubuntu 
18.04. What happens is the second request to the server causes the server to 
hang on the socket. I was trying to find _any_ example of a working server.xml, 
but it's not part of the PR. Any chance you guys could post your working 
server.xml? Otherwise I may have spotted a bug and can start a new discussion 
with a test case. Thank you!
   > 
   > prob: 
[http://stackoverflow.com/questions/72975059/tomcat-crashe…](http://stackoverflow.com/questions/72975059/tomcat-crashe%E2%80%A6)
   
   I think the reason for your problem is that your JDK version is too low, you 
should use version 16+.
   You can take a look at  the 
[commit](https://github.com/apache/tomcat/commit/a616bf385a350175a33a0ebf09d8b6688344e9e3)
 ,hopes for helping you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org