[GitHub] [tomcat] markt-asf commented on issue #175: Apply the suggestion in rfc7233
markt-asf commented on issue #175: Apply the suggestion in rfc7233 URL: https://github.com/apache/tomcat/pull/175#issuecomment-507409540 I think everything is complete now. Feel free to re-open if you spot something I missed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on issue #175: Apply the suggestion in rfc7233
markt-asf commented on issue #175: Apply the suggestion in rfc7233 URL: https://github.com/apache/tomcat/pull/175#issuecomment-507304794 Thanks for the the review. I had mis-remembered how partial PUTs were implemented. I'll take another pass at the patch. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on issue #175: Apply the suggestion in rfc7233
markt-asf commented on issue #175: Apply the suggestion in rfc7233 URL: https://github.com/apache/tomcat/pull/175#issuecomment-507209534 Thanks. I have applied 2 of the 3 changes to 9.0.x (range units and etag) with some additional refactoring / clean-up as well as additional comments. I thin the remaining change needs to be made optional as many clients have implemented partial PUT even if the intention of the RFC 2616 authors was not to allow it. This is next on my TODO list followed by back-porting all the Rnage improvements inspired by your PRs. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
