[GitHub] [tomcat] markt-asf commented on pull request #362: Fix spelling
markt-asf commented on pull request #362: URL: https://github.com/apache/tomcat/pull/362#issuecomment-696726509 Great. Thanks for the confirmation. On that basis, I am going to close the PR. Thanks for all the fixes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on pull request #362: Fix spelling
markt-asf commented on pull request #362: URL: https://github.com/apache/tomcat/pull/362#issuecomment-696726509 Great. Thanks for the confirmation. On that basis, I am going to close the PR. Thanks for all the fixes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on pull request #362: Fix spelling
markt-asf commented on pull request #362: URL: https://github.com/apache/tomcat/pull/362#issuecomment-693582639 There were fewer API changes than expected the changes in the PR have been applied excluding the DTD/schema files identified above. If you could rebase the PR and confirm nothing has been missed that would be great. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on pull request #362: Fix spelling
markt-asf commented on pull request #362: URL: https://github.com/apache/tomcat/pull/362#issuecomment-693525406 DBCP and pool need to be fixed in the respective Commons projects. I have commit access there so I've done that and those changes can be removed from this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on pull request #362: Fix spelling
markt-asf commented on pull request #362: URL: https://github.com/apache/tomcat/pull/362#issuecomment-693501444 You can ignore all of those. I managed to flip the old and new so I was looking at them the wrong way round. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on pull request #362: Fix spelling
markt-asf commented on pull request #362: URL: https://github.com/apache/tomcat/pull/362#issuecomment-693490023 The following changes are not correct and need to be reverted: - org.apache.catalina.manager - "received" is correct - org.apache.servlets "external" is correct spelling - org.apache.catalina.tribes.group.interceptors "weren't" is correct - package org.apache.catalina.valves "triple" is correct This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on pull request #362: Fix spelling
markt-asf commented on pull request #362: URL: https://github.com/apache/tomcat/pull/362#issuecomment-693474068 Thanks for being so understanding. I'm starting to commit changes as I review them. Here is the frist batch of files we won;t be able to change. This should be the majority of them. Changes in the following files need to be submitted as PRs against https://github.com/eclipse-ee4j/jakartaee-schemas - jakartaee_9.xsd - jakartaee_web_services_2_0.xsd - jakartaee_web_services_client_2_0.xsd - jsp_3_0.xsd - web-app_5_0.xsd - web-fragment_5_0.xsd - web-jsptaglibrary_3_0.xsd Changes in the following files need to be removed from this PR (and I am not sure if there is an upstream project for them) - javaee_8.xsd - javaee_web_services_1_2.xsd - javaee_web_services_1_3.xsd - javaee_web_services_1_4.xsd - javaee_web_services_client_1_2.xsd - javaee_web_services_client_1_3.xsd - javaee_web_services_client_1_4.xsd - web-app_3_0.xsd - web-app_3_1.xsd - web-app_4_0.xsd - web-fragment_3_0.xsd - web-fragment_3_1.xsd - web-fragment_4_0.xsd The remaining schemas and DTDs are old enough that they originated at the ASF so we can fix them. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on pull request #362: Fix spelling
markt-asf commented on pull request #362: URL: https://github.com/apache/tomcat/pull/362#issuecomment-693401407 OK. I have a plan. I have checked out the source branch for the PR locally and am using a visual diff tool to compare this PR with Tomcat. The tool provides tools to easily review the changes in the PR and apply them selectively to Tomcat. I'll apply changes manually. If you can rebase this PR periodically, that will enable this PR to reflect the current TODO list in terms of what needs to be reviewed (and potentially merged). There will be some changes that can't be made in Tomcat. I can direct you to the correct upstream project for those. If you can remove those changes from this PR and submit PRs for the appropriate project(s) that would be very helpful. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on pull request #362: Fix spelling
markt-asf commented on pull request #362: URL: https://github.com/apache/tomcat/pull/362#issuecomment-693395720 There is lots of good stuff here but also changes to some files that we can't (due to ASF policy w.r.t. 3rd party licenses) change. And as Martin pointed out changing anything that might be considered part of the public API needs careful consideration. I'm currently trying to figure out the best way to handle this This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
