[GitHub] [tomcat] michael-o commented on pull request #401: Add support for unix domain sockets (APR Protocol)
michael-o commented on pull request #401: URL: https://github.com/apache/tomcat/pull/401#issuecomment-771777818 Yes, let's do 9.0.x first. @rmaucher has added an acceptable solution for Windows. This should be ported to the `AprEndpoint` too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] michael-o commented on pull request #401: Add support for unix domain sockets (APR Protocol)
michael-o commented on pull request #401: URL: https://github.com/apache/tomcat/pull/401#issuecomment-771777818 Yes, let's do 9.0.x first. @rmaucher has added an acceptable solution for Windows. This should be ported to the `AprEndpoint` too. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] michael-o commented on pull request #401: Add support for unix domain sockets (APR Protocol)
michael-o commented on pull request #401: URL: https://github.com/apache/tomcat/pull/401#issuecomment-770799039 > > > @michael-o You just pushed two commits to master: https://github.com/apache/tomcat/commits/master: > > * [a616bf3](https://github.com/apache/tomcat/commit/a616bf385a350175a33a0ebf09d8b6688344e9e3) (I guess this is a squashed one) > > * [c4f5e2c](https://github.com/apache/tomcat/commit/c4f5e2c9ccd7d65953e3c685d25e436e8330e142) > > > I'd expect only those two to be backported. A few fixups will follow, so they need to soak in then someone can cherry pick them to a branch and the squash. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] michael-o commented on pull request #401: Add support for unix domain sockets (APR Protocol)
michael-o commented on pull request #401: URL: https://github.com/apache/tomcat/pull/401#issuecomment-770748775 > > > @michael-o You just pushed two commits to master: https://github.com/apache/tomcat/commits/master: > > * [a616bf3](https://github.com/apache/tomcat/commit/a616bf385a350175a33a0ebf09d8b6688344e9e3) (I guess this is a squashed one) > > * [c4f5e2c](https://github.com/apache/tomcat/commit/c4f5e2c9ccd7d65953e3c685d25e436e8330e142) > > > I'd expect only those two to be backported. I tried with 9.0.x and compilation fails, precending commits are missing. That is why I requested a backport from @minfrin. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] michael-o commented on pull request #401: Add support for unix domain sockets (APR Protocol)
michael-o commented on pull request #401: URL: https://github.com/apache/tomcat/pull/401#issuecomment-770733763 @martin-g Not really, but I do not fully know which are revelant. I'd rathe merge a complete, blessed set rather then some halfbreed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] michael-o commented on pull request #401: Add support for unix domain sockets (APR Protocol)
michael-o commented on pull request #401: URL: https://github.com/apache/tomcat/pull/401#issuecomment-770716609 @minfrin I have now pushed this to master. Can you please backport to 9.0.x and 8.5.x and then I will merge them too? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] michael-o commented on pull request #401: Add support for unix domain sockets (APR Protocol)
michael-o commented on pull request #401: URL: https://github.com/apache/tomcat/pull/401#issuecomment-767869298 Alright, I will merge this this week. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] michael-o commented on pull request #401: Add support for unix domain sockets (APR Protocol)
michael-o commented on pull request #401: URL: https://github.com/apache/tomcat/pull/401#issuecomment-767651363 For me yes, but I want Rémy give a chance to do his improvements on top. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] michael-o commented on pull request #401: Add support for unix domain sockets (APR Protocol)
michael-o commented on pull request #401: URL: https://github.com/apache/tomcat/pull/401#issuecomment-761074064 Give me a couple of days and I will run this on FreeBSD and HP-UX. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
