[GitHub] [tomcat] zhanhb commented on issue #174: Clean method parseRange
zhanhb commented on issue #174: Clean method parseRange URL: https://github.com/apache/tomcat/pull/174#issuecomment-505359318 My suggestion for multiple range support: support is enough, don't let it be an entrance for DDOS attack. For this feature is specified in rfc document, many http server will supported this. But on the client side, a user agent who has a good ability to parse multi-range response usually doesn't need this feature. Single range is enough for them or capability reason. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] zhanhb commented on issue #174: Clean method parseRange
zhanhb commented on issue #174: Clean method parseRange URL: https://github.com/apache/tomcat/pull/174#issuecomment-505352885 Here's how I parse request `Range` now, glad if this can help you. https://github.com/zhanhb/ckfinder-spring-boot/blob/f9bccecbb1d534c804b62d9a33604388e1e91e48/ckfinder-connector/src/main/java/com/github/zhanhb/ckfinder/download/PathPartial.java#L300-L408 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] zhanhb commented on issue #174: Clean method parseRange
zhanhb commented on issue #174: Clean method parseRange URL: https://github.com/apache/tomcat/pull/174#issuecomment-505350158 If strong weak tag is implemented, maybe strong etag validator can be applied on header `If-Range`. Just maybe, we can see on the client side, chrome doesn't do strict as specified in [rfc 7233](https://tools.ietf.org/html/rfc7233#section-3.2)(will send weak etag in header `If-Range`). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] zhanhb commented on issue #174: Clean method parseRange
zhanhb commented on issue #174: Clean method parseRange URL: https://github.com/apache/tomcat/pull/174#issuecomment-505345715 Here's a test case for PUT, no other cases yet now. ```sh curl -i -X PUT --header 'Content-Range: bytes=1-5/4' --data 'abcdef' 'http://some-url-served-by-tomcat-default-servlet-and-not-readonly' ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] zhanhb commented on issue #174: Clean method parseRange
zhanhb commented on issue #174: Clean method parseRange
URL: https://github.com/apache/tomcat/pull/174#issuecomment-505224327
https://github.com/apache/tomcat/blob/54ea770e6213a7bed64ac9d90d7cfcf2dffc6a61/java/org/apache/catalina/servlets/DefaultServlet.java#L1391
How abouting chaning this line to
```java
if (!rangeHeader.startsWith("bytes=")) {
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[GitHub] [tomcat] zhanhb commented on issue #174: Clean method parseRange
zhanhb commented on issue #174: Clean method parseRange URL: https://github.com/apache/tomcat/pull/174#issuecomment-505220224 It's not easy for me to run a single test case now. I execute curl instead. I'll try to run single test case instead of execute command curl. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
