Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.1
Thanks for the review. Fixes made for next release. Mark On 07/07/2022 14:03, Konstantin Kolinko wrote: вт, 5 июл. 2022 г. в 22:49, Mark Thomas : The proposed Apache Tomcat migration tool for Jakarta EE 1.0.1 is now available for voting. The significant changes since 1.0.0 are: - Add support for .groovy files - Better support for non-standard archives - Numerous library updates It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.1/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1381/ The tag is: https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.1 acf10c08b41c6ce8fa4965fd975420b6e9e2b038 The proposed 1.0.1 release is: Not tested, but reviewed the distributables. Minor issues. 1. The NOTICE.txt file has not been updated for the year 2022. It says: Apache Tomcat migration tool for Jakarta EE Copyright 2021 The Apache Software Foundation instead of 2021-2022 as usual. I think it is not a stopper. I think that it is still valid from the legal point of view. 2. jakartaee-migration-1.0.1-src.zip and jakartaee-migration-1.0.1-src.tar.gz miss some files: .gitignore .travis.yml CHANGES.md .mvn/wrapper/maven-wrapper.jar Looking into mvnw.cmd and mvnw scripts, I see that they can deal with missing maven-wrapper.jar file: They will download version 0.5.6 of maven-wrapper from Maven Central, if one is missing locally. So I think it is not a stopper. 3. Version numbering, "1.0.1" vs "1.1.0" and Semantic Versioning. For reference: https://semver.org/ According to CHANGES.md, https://github.com/apache/tomcat-jakartaee-migration/blob/main/CHANGES.md I see two functionality changes that are not bug fixes: (1) "Fix #19. Add support for converting .groovy files." - From the description it sounds as an "added feature" and thus I was thinking whether it needs bumping the version number to 1.1.0, but actually it is an internal, one-liner change https://github.com/apache/tomcat-jakartaee-migration/commit/6465822873b3215cabc4a922e8444c4a960d7761 There are no new configuration options or anything like that. So I think it does not count as an "added feature". (2) "Remove deprecated -verbose command line option (remm)" https://github.com/apache/tomcat-jakartaee-migration/commit/528f05e09ba5745c56bcd66e02d88ce7ad8bb596 Removing an undocumented option that is commented as deprecated in the code is OK. I think it does not count as an "added feature". If it is breaking something, it is covered by 0.2.0 -> 1.0.0 version number change. Thus I am OK with the version number of 1.0.1. [ ] -1: Broken. Do not release because... [x] +1: Acceptable. Go ahead and release. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.1
вт, 5 июл. 2022 г. в 22:49, Mark Thomas : > > The proposed Apache Tomcat migration tool for Jakarta EE 1.0.1 is now > available for voting. > > The significant changes since 1.0.0 are: > > - Add support for .groovy files > > - Better support for non-standard archives > > - Numerous library updates > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.1/ > > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1381/ > > The tag is: > https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.1 > acf10c08b41c6ce8fa4965fd975420b6e9e2b038 > > The proposed 1.0.1 release is: > Not tested, but reviewed the distributables. Minor issues. 1. The NOTICE.txt file has not been updated for the year 2022. It says: Apache Tomcat migration tool for Jakarta EE Copyright 2021 The Apache Software Foundation instead of 2021-2022 as usual. I think it is not a stopper. I think that it is still valid from the legal point of view. 2. jakartaee-migration-1.0.1-src.zip and jakartaee-migration-1.0.1-src.tar.gz miss some files: .gitignore .travis.yml CHANGES.md .mvn/wrapper/maven-wrapper.jar Looking into mvnw.cmd and mvnw scripts, I see that they can deal with missing maven-wrapper.jar file: They will download version 0.5.6 of maven-wrapper from Maven Central, if one is missing locally. So I think it is not a stopper. 3. Version numbering, "1.0.1" vs "1.1.0" and Semantic Versioning. For reference: https://semver.org/ According to CHANGES.md, https://github.com/apache/tomcat-jakartaee-migration/blob/main/CHANGES.md I see two functionality changes that are not bug fixes: (1) "Fix #19. Add support for converting .groovy files." - From the description it sounds as an "added feature" and thus I was thinking whether it needs bumping the version number to 1.1.0, but actually it is an internal, one-liner change https://github.com/apache/tomcat-jakartaee-migration/commit/6465822873b3215cabc4a922e8444c4a960d7761 There are no new configuration options or anything like that. So I think it does not count as an "added feature". (2) "Remove deprecated -verbose command line option (remm)" https://github.com/apache/tomcat-jakartaee-migration/commit/528f05e09ba5745c56bcd66e02d88ce7ad8bb596 Removing an undocumented option that is commented as deprecated in the code is OK. I think it does not count as an "added feature". If it is breaking something, it is covered by 0.2.0 -> 1.0.0 version number change. Thus I am OK with the version number of 1.0.1. > [ ] -1: Broken. Do not release because... > [x] +1: Acceptable. Go ahead and release. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.1
On 05/07/2022 20:48, Mark Thomas wrote: The proposed Apache Tomcat migration tool for Jakarta EE 1.0.1 is now available for voting. The significant changes since 1.0.0 are: - Add support for .groovy files - Better support for non-standard archives - Numerous library updates It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.1/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1381/ The tag is: https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.1 acf10c08b41c6ce8fa4965fd975420b6e9e2b038 The proposed 1.0.1 release is: [ ] -1: Broken. Do not release because... [X] +1: Acceptable. Go ahead and release. Built the Tomcat 9.0.x webapps, deployed them on Tomcat 10.1.x modified to use this library and performed some basic testing. All looks good. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.1
On Tue, Jul 5, 2022 at 9:49 PM Mark Thomas wrote: > > The proposed Apache Tomcat migration tool for Jakarta EE 1.0.1 is now > available for voting. > > The significant changes since 1.0.0 are: > > - Add support for .groovy files > > - Better support for non-standard archives > > - Numerous library updates > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.1/ > > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1381/ > > The tag is: > https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.1 > acf10c08b41c6ce8fa4965fd975420b6e9e2b038 > > The proposed 1.0.1 release is: > > [ ] -1: Broken. Do not release because... > [X] +1: Acceptable. Go ahead and release. Remy > Thanks, > > Mark > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.1
> 2022年7月6日 03:48，Mark Thomas 写道： > > The proposed Apache Tomcat migration tool for Jakarta EE 1.0.1 is now > available for voting. > > The significant changes since 1.0.0 are: > > - Add support for .groovy files > > - Better support for non-standard archives > > - Numerous library updates > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.1/ > > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1381/ > > The tag is: > https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.1 > acf10c08b41c6ce8fa4965fd975420b6e9e2b038 > > The proposed 1.0.1 release is: > > [ ] -1: Broken. Do not release because… > [X] +1: Acceptable. Go ahead and release. > > Thanks, > > Mark > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > All unit test passed. Sorry, the previous reply is invalid.;) Han - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.1
> 2022年7月6日 03:48，Mark Thomas 写道： > > The proposed Apache Tomcat migration tool for Jakarta EE 1.0.1 is now > available for voting. > > The significant changes since 1.0.0 are: > > - Add support for .groovy files > > - Better support for non-standard archives > > - Numerous library updates > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.1/ > > The Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-1381/ > > The tag is: > https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.1 > acf10c08b41c6ce8fa4965fd975420b6e9e2b038 > > The proposed 1.0.1 release is: > > [ ] -1: Broken. Do not release because... > [ ] +1: Acceptable. Go ahead and release. > > Thanks, > > Mark > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > Mark, The Migration unit test failed because some jar packages were missing. Is this normal? Han - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[VOTE] Apache Tomcat migration tool for Jakarta EE 1.0.1
The proposed Apache Tomcat migration tool for Jakarta EE 1.0.1 is now available for voting. The significant changes since 1.0.0 are: - Add support for .groovy files - Better support for non-standard archives - Numerous library updates It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/jakartaee-migration/v1.0.1/ The Maven staging repo is: https://repository.apache.org/content/repositories/orgapachetomcat-1381/ The tag is: https://github.com/apache/tomcat-jakartaee-migration/tree/1.0.1 acf10c08b41c6ce8fa4965fd975420b6e9e2b038 The proposed 1.0.1 release is: [ ] -1: Broken. Do not release because... [ ] +1: Acceptable. Go ahead and release. Thanks, Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
