Re: [VOTE] Release Apache Tomcat 10.1.20

2024-03-20 Thread Christopher Schultz 

Dimitris,

On 3/20/24 09:09, Dimitris Soumis wrote:

+1 All tests pass on Fedora 38 with Java 21, tcnative-2.0.7, openssl-3.0.13.

(Just to mention that testing failed when running for the first time.
Crashed when running org.apache.tomcat.util.net.TestSSLHostConfigCompat.
Running again had no issues.)


If you can get it to fail again, please post the failure here so we can 
look.


We have found and fixed some timing issues when this exact thing happens 
to a tester.


Thanks,
-chris


On Tue, Mar 19, 2024 at 4:04 PM Christopher Schultz <
ch...@christopherschultz.net> wrote:


The proposed Apache Tomcat 10.1.20 release is now available for
voting.

The notable changes compared to 10.1.19 are:

- Fix regression when reloading TLS configuration and files.

- When restoring a saved POST request after a successful FORM
authentication, ensure that neither the URI, the query string no
the protocol are corrupted when restoring the request body.

- Align error handling for Writer and OutputStream. Ensure use of either
once the response has been recycled triggers a NullPointerException
provided that discardFacades is configured with the default value of
true.

For full details, see the change log:
https://nightlies.apache.org/tomcat/tomcat-10.1.x/docs/changelog.html

Applications that run on Tomcat 9 and earlier will not run on Tomcat 10
without changes. Java EE applications designed for Tomcat 9 and earlier
may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat
will automatically convert them to Jakarta EE and copy them to the
webapps directory.

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.20/

The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1486

The tag is:
https://github.com/apache/tomcat/tree/10.1.20
ab4d890c6fa7be3f910370f00fb5c7f10152e21c

The proposed 10.1.20 release is:
[ ] Broken - do not release
[X ] Stable - go ahead and release as 10.1.20

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org






-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 10.1.20

2024-03-20 Thread Dimitris Soumis 
+1 All tests pass on Fedora 38 with Java 21, tcnative-2.0.7, openssl-3.0.13.

(Just to mention that testing failed when running for the first time.
Crashed when running org.apache.tomcat.util.net.TestSSLHostConfigCompat.
Running again had no issues.)

On Tue, Mar 19, 2024 at 4:04 PM Christopher Schultz <
ch...@christopherschultz.net> wrote:

> The proposed Apache Tomcat 10.1.20 release is now available for
> voting.
>
> The notable changes compared to 10.1.19 are:
>
> - Fix regression when reloading TLS configuration and files.
>
> - When restoring a saved POST request after a successful FORM
>authentication, ensure that neither the URI, the query string no
>the protocol are corrupted when restoring the request body.
>
> - Align error handling for Writer and OutputStream. Ensure use of either
>once the response has been recycled triggers a NullPointerException
>provided that discardFacades is configured with the default value of
>true.
>
> For full details, see the change log:
> https://nightlies.apache.org/tomcat/tomcat-10.1.x/docs/changelog.html
>
> Applications that run on Tomcat 9 and earlier will not run on Tomcat 10
> without changes. Java EE applications designed for Tomcat 9 and earlier
> may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat
> will automatically convert them to Jakarta EE and copy them to the
> webapps directory.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.20/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1486
>
> The tag is:
> https://github.com/apache/tomcat/tree/10.1.20
> ab4d890c6fa7be3f910370f00fb5c7f10152e21c
>
> The proposed 10.1.20 release is:
> [ ] Broken - do not release
> [X ] Stable - go ahead and release as 10.1.20
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: [VOTE] Release Apache Tomcat 10.1.20

2024-03-20 Thread Mark Thomas 

On 19/03/2024 13:52, Christopher Schultz wrote:


The proposed 10.1.20 release is:
[ ] Broken - do not release
[X] Stable - go ahead and release as 10.1.20


Tests pass on Linux, Windows and MacOS (M1).

The build is reproducible.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 10.1.20

2024-03-19 Thread Igal Sapir 
On Tue, Mar 19, 2024 at 6:58 AM Christopher Schultz <
ch...@christopherschultz.net> wrote:

> The proposed Apache Tomcat 10.1.20 release is now available for
> voting.
>
> The notable changes compared to 10.1.19 are:
>
> - Fix regression when reloading TLS configuration and files.
>
> - When restoring a saved POST request after a successful FORM
>authentication, ensure that neither the URI, the query string no
>the protocol are corrupted when restoring the request body.
>
> - Align error handling for Writer and OutputStream. Ensure use of either
>once the response has been recycled triggers a NullPointerException
>provided that discardFacades is configured with the default value of
>true.
>
> For full details, see the change log:
> https://nightlies.apache.org/tomcat/tomcat-10.1.x/docs/changelog.html
>
> Applications that run on Tomcat 9 and earlier will not run on Tomcat 10
> without changes. Java EE applications designed for Tomcat 9 and earlier
> may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat
> will automatically convert them to Jakarta EE and copy them to the
> webapps directory.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.20/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1486
>
> The tag is:
> https://github.com/apache/tomcat/tree/10.1.20
> ab4d890c6fa7be3f910370f00fb5c7f10152e21c
>
> The proposed 10.1.20 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 10.1.20
>

+1

Igal



>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: [VOTE] Release Apache Tomcat 10.1.20

2024-03-19 Thread Romain Manni-Bucau 
+1 (non-binding), tested on several apps with "AsfEE" stack and Yupiik
Fusion, no issue so far.

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book



Le mar. 19 mars 2024 à 16:55, Rémy Maucherat  a écrit :

> On Tue, Mar 19, 2024 at 2:56 PM Christopher Schultz
>  wrote:
> >
> > The proposed Apache Tomcat 10.1.20 release is now available for
> > voting.
> >
> > The notable changes compared to 10.1.19 are:
> >
> > - Fix regression when reloading TLS configuration and files.
> >
> > - When restoring a saved POST request after a successful FORM
> >authentication, ensure that neither the URI, the query string no
> >the protocol are corrupted when restoring the request body.
> >
> > - Align error handling for Writer and OutputStream. Ensure use of either
> >once the response has been recycled triggers a NullPointerException
> >provided that discardFacades is configured with the default value of
> >true.
> >
> > For full details, see the change log:
> > https://nightlies.apache.org/tomcat/tomcat-10.1.x/docs/changelog.html
> >
> > Applications that run on Tomcat 9 and earlier will not run on Tomcat 10
> > without changes. Java EE applications designed for Tomcat 9 and earlier
> > may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat
> > will automatically convert them to Jakarta EE and copy them to the
> > webapps directory.
> >
> > It can be obtained from:
> > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.20/
> >
> > The Maven staging repo is:
> > https://repository.apache.org/content/repositories/orgapachetomcat-1486
> >
> > The tag is:
> > https://github.com/apache/tomcat/tree/10.1.20
> > ab4d890c6fa7be3f910370f00fb5c7f10152e21c
> >
> > The proposed 10.1.20 release is:
> > [ ] Broken - do not release
> > [X] Stable - go ahead and release as 10.1.20
>
> Rémy
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: [VOTE] Release Apache Tomcat 10.1.20

2024-03-19 Thread Rémy Maucherat 
On Tue, Mar 19, 2024 at 2:56 PM Christopher Schultz
 wrote:
>
> The proposed Apache Tomcat 10.1.20 release is now available for
> voting.
>
> The notable changes compared to 10.1.19 are:
>
> - Fix regression when reloading TLS configuration and files.
>
> - When restoring a saved POST request after a successful FORM
>authentication, ensure that neither the URI, the query string no
>the protocol are corrupted when restoring the request body.
>
> - Align error handling for Writer and OutputStream. Ensure use of either
>once the response has been recycled triggers a NullPointerException
>provided that discardFacades is configured with the default value of
>true.
>
> For full details, see the change log:
> https://nightlies.apache.org/tomcat/tomcat-10.1.x/docs/changelog.html
>
> Applications that run on Tomcat 9 and earlier will not run on Tomcat 10
> without changes. Java EE applications designed for Tomcat 9 and earlier
> may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat
> will automatically convert them to Jakarta EE and copy them to the
> webapps directory.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.20/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1486
>
> The tag is:
> https://github.com/apache/tomcat/tree/10.1.20
> ab4d890c6fa7be3f910370f00fb5c7f10152e21c
>
> The proposed 10.1.20 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 10.1.20

Rémy

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 10.1.20

2024-03-19 Thread Christopher Schultz 

All,

On 3/19/24 09:52, Christopher Schultz wrote:

The proposed Apache Tomcat 10.1.20 release is now available for
voting.

The notable changes compared to 10.1.19 are:

- Fix regression when reloading TLS configuration and files.

- When restoring a saved POST request after a successful FORM
   authentication, ensure that neither the URI, the query string no
   the protocol are corrupted when restoring the request body.

- Align error handling for Writer and OutputStream. Ensure use of either
   once the response has been recycled triggers a NullPointerException
   provided that discardFacades is configured with the default value of
   true.

For full details, see the change log:
https://nightlies.apache.org/tomcat/tomcat-10.1.x/docs/changelog.html

Applications that run on Tomcat 9 and earlier will not run on Tomcat 10 
without changes. Java EE applications designed for Tomcat 9 and earlier 
may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat 
will automatically convert them to Jakarta EE and copy them to the 
webapps directory.


It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.20/

The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1486

The tag is:
https://github.com/apache/tomcat/tree/10.1.20
ab4d890c6fa7be3f910370f00fb5c7f10152e21c

The proposed 10.1.20 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 10.1.20


+1 for stable release

The build is 100% reproducible and the unit tests pass on MacOS x86-64.

Details:
* Environment
*  Java (build):openjdk version "17.0.10" 2024-01-16 OpenJDK Runtime 
Environment Temurin-17.0.10+7 (build 17.0.10+7) OpenJDK 64-Bit Server VM 
Temurin-17.0.10+7 (build 17.0.10+7, mixed mode)
*  Java (test): openjdk version "17.0.10" 2024-01-16 OpenJDK Runtime 
Environment Temurin-17.0.10+7 (build 17.0.10+7) OpenJDK 64-Bit Server VM 
Temurin-17.0.10+7 (build 17.0.10+7, mixed mode)

*  OS:  Darwin 21.6.0 x86_64
*  cc:  Apple clang version 12.0.0 (clang-1200.0.31.1)
*  make:GNU Make 3.81
*  OpenSSL:   OpenSSL 3.2.0 23 Nov 2023 (Library: OpenSSL 3.2.0 23 
Nov 2023)

*  APR: 1.7.4
*
* Valid SHA-512 signature for apache-tomcat-10.1.20.zip
* Valid GPG signature for apache-tomcat-10.1.20.zip
* Valid SHA-512 signature for apache-tomcat-10.1.20.tar.gz
* Valid GPG signature for apache-tomcat-10.1.20.tar.gz
* Valid SHA-512 signature for apache-tomcat-10.1.20.exe
* Valid GPG signature for apache-tomcat-10.1.20.exe
* Valid SHA512 signature for apache-tomcat-10.1.20-src.zip
* Valid GPG signature for apache-tomcat-10.1.20-src.zip
* Valid SHA512 signature for apache-tomcat-10.1.20-src.tar.gz
* Valid GPG signature for apache-tomcat-10.1.20-src.tar.gz
*
* Binary Zip and tarball: Same
* Source Zip and tarball: Same
*
* Building dependencies returned: 0
* tcnative builds cleanly
* Tomcat builds cleanly
* Junit Tests: PASSED

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[VOTE] Release Apache Tomcat 10.1.20

2024-03-19 Thread Christopher Schultz 

The proposed Apache Tomcat 10.1.20 release is now available for
voting.

The notable changes compared to 10.1.19 are:

- Fix regression when reloading TLS configuration and files.

- When restoring a saved POST request after a successful FORM
  authentication, ensure that neither the URI, the query string no
  the protocol are corrupted when restoring the request body.

- Align error handling for Writer and OutputStream. Ensure use of either
  once the response has been recycled triggers a NullPointerException
  provided that discardFacades is configured with the default value of
  true.

For full details, see the change log:
https://nightlies.apache.org/tomcat/tomcat-10.1.x/docs/changelog.html

Applications that run on Tomcat 9 and earlier will not run on Tomcat 10 
without changes. Java EE applications designed for Tomcat 9 and earlier 
may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat 
will automatically convert them to Jakarta EE and copy them to the 
webapps directory.


It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-10/v10.1.20/

The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1486

The tag is:
https://github.com/apache/tomcat/tree/10.1.20
ab4d890c6fa7be3f910370f00fb5c7f10152e21c

The proposed 10.1.20 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 10.1.20

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org