Re: [VOTE] Release Apache Tomcat 9.0.0.M4

2016-03-19 Thread Violeta Georgieva 
2016-03-16 11:59 GMT+02:00 Mark Thomas :
>
> On 16/03/2016 09:34, Violeta Georgieva wrote:
> > Hi Mark,
> >
> > 2016-03-12 15:58 GMT+02:00 Mark Thomas :
> >>
> >> The proposed Apache Tomcat 9.0.0.M4 release is now available for
voting.
> >>
> >> This is a milestone release for the 9.0.x branch. It should be
> >> noted that, as a milestone release:
> >> - Servlet 4.0 is not finalised
> >> - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0
> >>
> >> The major changes compared to the 9.0.0.M3 branch are:
> >> - Added JASPIC support
> >> - Switch to the ParallelWebappClassLoader by default
> >> - Reduce runtime memory footprint
> >> - Lots of bug fixes
> >>
> >> For full details, see the changelog:
> >>
http://svn.us.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
> >>
> >> It can be obtained from:
> >> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M4/
> >> The Maven staging repo is:
> >>
https://repository.apache.org/content/repositories/orgapachetomcat-1065/
> >> The svn tag is:
> >> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M4/
> >>
> >> The proposed 9.0.0.M4 release is:
> >> [ ] Broken - do not release
> >> [ ] Alpha - go ahead and release as 9.0.0.M4
> >>
> >
> > I have issues with javax.websocket.Session.setMaxIdleTimeout(long)
> >
> > I can send messages after the max idle timeout.
> >
> > I have a test. I can send it here as a patch, or I can commit it to the
> > repo and mark it as non-executable.
>
> Commit it and mark it as ignored
>

I committed it. My expectation is that "After sleep..." message will not be
received. Is that correct?

> Mark
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Re: [VOTE] Release Apache Tomcat 9.0.0.M4

2016-03-19 Thread Mark Thomas 
On 16/03/2016 12:04, Violeta Georgieva wrote:
> 2016-03-16 11:59 GMT+02:00 Mark Thomas :
>>
>> On 16/03/2016 09:34, Violeta Georgieva wrote:
>>> Hi Mark,
>>>
>>> 2016-03-12 15:58 GMT+02:00 Mark Thomas :

 The proposed Apache Tomcat 9.0.0.M4 release is now available for
> voting.

 This is a milestone release for the 9.0.x branch. It should be
 noted that, as a milestone release:
 - Servlet 4.0 is not finalised
 - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0

 The major changes compared to the 9.0.0.M3 branch are:
 - Added JASPIC support
 - Switch to the ParallelWebappClassLoader by default
 - Reduce runtime memory footprint
 - Lots of bug fixes

 For full details, see the changelog:

> http://svn.us.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml

 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M4/
 The Maven staging repo is:

> https://repository.apache.org/content/repositories/orgapachetomcat-1065/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M4/

 The proposed 9.0.0.M4 release is:
 [ ] Broken - do not release
 [ ] Alpha - go ahead and release as 9.0.0.M4

>>>
>>> I have issues with javax.websocket.Session.setMaxIdleTimeout(long)
>>>
>>> I can send messages after the max idle timeout.
>>>
>>> I have a test. I can send it here as a patch, or I can commit it to the
>>> repo and mark it as non-executable.
>>
>> Commit it and mark it as ignored
>>
> 
> I committed it. My expectation is that "After sleep..." message will not be
> received. Is that correct?

The test has a bug.

The key points are:
- messages are processed serially on the server side
- the client session isn't closed until the server sends the response
  to the close message from the client

The sequence of events is

Seq Client  Server
1   Send msgSend timeout msg
2   Sleep()
3   Send close  (still sleeping)
4   Send after sleep msg
5   Rx after sleep
6   Rx close msg
7   Send close msg
8   Rx close msg
9   Close session

The server needs to send the 'After sleep' msg on on a different thread
and then it should fail server side.

Mark


> 
>> Mark
>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 9.0.0.M4

2016-03-18 Thread Violeta Georgieva 
Hi,

2016-03-17 21:34 GMT+02:00 Mark Thomas :
>
> On 16/03/2016 12:04, Violeta Georgieva wrote:
> > 2016-03-16 11:59 GMT+02:00 Mark Thomas :
> >>
> >> On 16/03/2016 09:34, Violeta Georgieva wrote:
> >>> Hi Mark,
> >>>
> >>> 2016-03-12 15:58 GMT+02:00 Mark Thomas :
> 
>  The proposed Apache Tomcat 9.0.0.M4 release is now available for
> > voting.
> 
>  This is a milestone release for the 9.0.x branch. It should be
>  noted that, as a milestone release:
>  - Servlet 4.0 is not finalised
>  - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket
1.2/2.0
> 
>  The major changes compared to the 9.0.0.M3 branch are:
>  - Added JASPIC support
>  - Switch to the ParallelWebappClassLoader by default
>  - Reduce runtime memory footprint
>  - Lots of bug fixes
> 
>  For full details, see the changelog:
> 
> >
http://svn.us.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
> 
>  It can be obtained from:
>  https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M4/
>  The Maven staging repo is:
> 
> > https://repository.apache.org/content/repositories/orgapachetomcat-1065/
>  The svn tag is:
>  http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M4/
> 
>  The proposed 9.0.0.M4 release is:
>  [ ] Broken - do not release
>  [ ] Alpha - go ahead and release as 9.0.0.M4
> 
> >>>
> >>> I have issues with javax.websocket.Session.setMaxIdleTimeout(long)
> >>>
> >>> I can send messages after the max idle timeout.
> >>>
> >>> I have a test. I can send it here as a patch, or I can commit it to
the
> >>> repo and mark it as non-executable.
> >>
> >> Commit it and mark it as ignored
> >>
> >
> > I committed it. My expectation is that "After sleep..." message will
not be
> > received. Is that correct?
>
> The test has a bug.
>
> The key points are:
> - messages are processed serially on the server side
> - the client session isn't closed until the server sends the response
>   to the close message from the client
>
> The sequence of events is
>
> Seq Client  Server
> 1   Send msgSend timeout msg
> 2   Sleep()
> 3   Send close  (still sleeping)
> 4   Send after sleep msg
> 5   Rx after sleep
> 6   Rx close msg
> 7   Send close msg
> 8   Rx close msg
> 9   Close session
>
> The server needs to send the 'After sleep' msg on on a different thread
> and then it should fail server side.
>

Ok
I was reading the javadoc and had a wrong expectation
"Set the non-zero number of milliseconds before this session will be closed
by the container if it is inactive, ie no messages are *either sent or
received*..."

I'll remove the wrong test.

Thanks,
Violeta

> Mark
>
>
> >
> >> Mark
> >>
> >>
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> >> For additional commands, e-mail: dev-h...@tomcat.apache.org
> >>
> >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Re: [VOTE] Release Apache Tomcat 9.0.0.M4

2016-03-16 Thread Mark Thomas 
On 16/03/2016 09:34, Violeta Georgieva wrote:
> Hi Mark,
> 
> 2016-03-12 15:58 GMT+02:00 Mark Thomas :
>>
>> The proposed Apache Tomcat 9.0.0.M4 release is now available for voting.
>>
>> This is a milestone release for the 9.0.x branch. It should be
>> noted that, as a milestone release:
>> - Servlet 4.0 is not finalised
>> - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0
>>
>> The major changes compared to the 9.0.0.M3 branch are:
>> - Added JASPIC support
>> - Switch to the ParallelWebappClassLoader by default
>> - Reduce runtime memory footprint
>> - Lots of bug fixes
>>
>> For full details, see the changelog:
>> http://svn.us.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
>>
>> It can be obtained from:
>> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M4/
>> The Maven staging repo is:
>> https://repository.apache.org/content/repositories/orgapachetomcat-1065/
>> The svn tag is:
>> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M4/
>>
>> The proposed 9.0.0.M4 release is:
>> [ ] Broken - do not release
>> [ ] Alpha - go ahead and release as 9.0.0.M4
>>
> 
> I have issues with javax.websocket.Session.setMaxIdleTimeout(long)
> 
> I can send messages after the max idle timeout.
> 
> I have a test. I can send it here as a patch, or I can commit it to the
> repo and mark it as non-executable.

Commit it and mark it as ignored

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 9.0.0.M4

2016-03-16 Thread Violeta Georgieva 
Hi Mark,

2016-03-12 15:58 GMT+02:00 Mark Thomas :
>
> The proposed Apache Tomcat 9.0.0.M4 release is now available for voting.
>
> This is a milestone release for the 9.0.x branch. It should be
> noted that, as a milestone release:
> - Servlet 4.0 is not finalised
> - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0
>
> The major changes compared to the 9.0.0.M3 branch are:
> - Added JASPIC support
> - Switch to the ParallelWebappClassLoader by default
> - Reduce runtime memory footprint
> - Lots of bug fixes
>
> For full details, see the changelog:
> http://svn.us.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M4/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1065/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M4/
>
> The proposed 9.0.0.M4 release is:
> [ ] Broken - do not release
> [ ] Alpha - go ahead and release as 9.0.0.M4
>

I have issues with javax.websocket.Session.setMaxIdleTimeout(long)

I can send messages after the max idle timeout.

I have a test. I can send it here as a patch, or I can commit it to the
repo and mark it as non-executable.

Regards,
Violeta

>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Re: [VOTE] Release Apache Tomcat 9.0.0.M4

2016-03-15 Thread Keiichi Fujino 
2016-03-12 22:58 GMT+09:00 Mark Thomas :

> The proposed Apache Tomcat 9.0.0.M4 release is now available for voting.
>
> This is a milestone release for the 9.0.x branch. It should be
> noted that, as a milestone release:
> - Servlet 4.0 is not finalised
> - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0
>
> The major changes compared to the 9.0.0.M3 branch are:
> - Added JASPIC support
> - Switch to the ParallelWebappClassLoader by default
> - Reduce runtime memory footprint
> - Lots of bug fixes
>
> For full details, see the changelog:
> http://svn.us.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M4/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1065/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M4/
>
> The proposed 9.0.0.M4 release is:
> [ ] Broken - do not release
> [X] Alpha - go ahead and release as 9.0.0.M4
>
>
+1
Tested on sample apps (enable DeltaManager ).


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
> --
> Keiichi.Fujino
>

Re: [VOTE] Release Apache Tomcat 9.0.0.M4

2016-03-14 Thread Felix Schumacher 

Am 12.03.2016 um 14:58 schrieb Mark Thomas:

The proposed Apache Tomcat 9.0.0.M4 release is now available for voting.

This is a milestone release for the 9.0.x branch. It should be
noted that, as a milestone release:
- Servlet 4.0 is not finalised
- The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0

The major changes compared to the 9.0.0.M3 branch are:
- Added JASPIC support
- Switch to the ParallelWebappClassLoader by default
- Reduce runtime memory footprint
- Lots of bug fixes

For full details, see the changelog:
http://svn.us.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M4/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1065/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M4/

The proposed 9.0.0.M4 release is:
[ ] Broken - do not release
[x] Alpha - go ahead and release as 9.0.0.M4


Felix



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 9.0.0.M4

2016-03-14 Thread Rémy Maucherat 
2016-03-12 14:58 GMT+01:00 Mark Thomas :

> The proposed Apache Tomcat 9.0.0.M4 release is now available for voting.
>
> This is a milestone release for the 9.0.x branch. It should be
> noted that, as a milestone release:
> - Servlet 4.0 is not finalised
> - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0
>
> The major changes compared to the 9.0.0.M3 branch are:
> - Added JASPIC support
> - Switch to the ParallelWebappClassLoader by default
> - Reduce runtime memory footprint
> - Lots of bug fixes
>
> For full details, see the changelog:
> http://svn.us.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M4/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1065/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M4/
>
> The proposed 9.0.0.M4 release is:
> [ ] Broken - do not release
> [X] Alpha - go ahead and release as 9.0.0.M4
>
> Still looking good.

Rémy

Re: [VOTE] Release Apache Tomcat 9.0.0.M4

2016-03-13 Thread Mark Thomas 
On 12/03/2016 13:58, Mark Thomas wrote:
> The proposed 9.0.0.M4 release is:
> [ ] Broken - do not release
> [X] Alpha - go ahead and release as 9.0.0.M4

Unit tests pass on Linux, Windows and OSX with NIO, NIO2 and APR/native
1.2.5

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[VOTE] Release Apache Tomcat 9.0.0.M4

2016-03-12 Thread Mark Thomas 
The proposed Apache Tomcat 9.0.0.M4 release is now available for voting.

This is a milestone release for the 9.0.x branch. It should be
noted that, as a milestone release:
- Servlet 4.0 is not finalised
- The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0

The major changes compared to the 9.0.0.M3 branch are:
- Added JASPIC support
- Switch to the ParallelWebappClassLoader by default
- Reduce runtime memory footprint
- Lots of bug fixes

For full details, see the changelog:
http://svn.us.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M4/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1065/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M4/

The proposed 9.0.0.M4 release is:
[ ] Broken - do not release
[ ] Alpha - go ahead and release as 9.0.0.M4


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org