[RESULTS] Re: [VOTE] Release Tomcat 5.5.32 Build

2011-02-01 Thread Jim Jagielski
I see more than enough +1-Stable votes to call this
vote closed and the release to proceed!

I will announce and release today...

Thanks to all testers, voters, etc...

On Jan 22, 2011, at 1:01 PM, Jim Jagielski wrote:

 The builds for Tomcat 5.5.32 are ready for testing and approval.
 The candidates binaries are available here:
 
 http://people.apache.org/~jim/tomcat-5.5/
 
 According to the release process, the 5.5.32 build corresponding to the
 tag TOMCAT_5_5_32 [1] is:
 
 [ ] Broken
 [ ] Alpha
 [ ] Beta
 [ ] Stable
 +++
 
 1. http://svn.apache.org/viewvc/tomcat/tc5.5.x/tags/TOMCAT_5_5_32/
 
 
 -
 To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
 For additional commands, e-mail: dev-h...@tomcat.apache.org
 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Tomcat 5.5.32 Build

2011-01-31 Thread Mladen Turk

I see you collected more then enough votes.
When do you plan to ANN that?

On 01/22/2011 07:01 PM, Jim Jagielski wrote:

The builds for Tomcat 5.5.32 are ready for testing and approval.
The candidates binaries are available here:

  http://people.apache.org/~jim/tomcat-5.5/

According to the release process, the 5.5.32 build corresponding to the
tag TOMCAT_5_5_32 [1] is:

[ ] Broken
[ ] Alpha
[ ] Beta
[ ] Stable
+++

1. http://svn.apache.org/viewvc/tomcat/tc5.5.x/tags/TOMCAT_5_5_32/


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org






--
^TM

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Tomcat 5.5.32 Build

2011-01-28 Thread Rainer Jung

On 22.01.2011 19:01, Jim Jagielski wrote:

The builds for Tomcat 5.5.32 are ready for testing and approval.
The candidates binaries are available here:

  http://people.apache.org/~jim/tomcat-5.5/

According to the release process, the 5.5.32 build corresponding to the
tag TOMCAT_5_5_32 [1] is:

[ ] Broken
[ ] Alpha
[ ] Beta
[X] Stable


- MD5 OK
- signatures OK
- key in KEYS file
- gz and zip for src and bin consistent
- src consistent with svn tag
- builds fine
- build result looks consistent with binaries

- Minor things:

  - bin/version.sh doesn_t have execute permissions in bin tarball

  - additional build.xml included in top-level src tar and zip
which is a duplicate of the one in the build directory.

  - STATUS.txt in svn, but not in src tar and zip
(I guess that's expected)

  - 4 errors in run-tester, but I vaguely remember those are
not regressions (details see below)

  - Some javadoc warnings but AFAIK TC 5.5 was never 100% clean
w.r.t. javadoc.


Details for run-tester:

   [tester] FAIL [GET /tester/ErrorPage08?type=Arithmetic HTTP/1.0] 
Expected data 'ErrorPage06 PASSED - SERVLET', got data 'ErrorPage06 
FAILED - message is not correct'
   [tester] FAIL [GET /tester/WrappedErrorPage08?type=Arithmetic 
HTTP/1.0] Expected data 'ErrorPage06 PASSED - SERVLET', got data 
'ErrorPage06 FAILED - message is not correct'
   [tester] FAIL [GET /tester/ErrorPage08?type=Array HTTP/1.0] Expected 
data 'ErrorPage06 PASSED - JSP', got data 'ErrorPage06 FAILED - message 
is not correct'
   [tester] FAIL [GET /tester/WrappedErrorPage08?type=Array HTTP/1.0] 
Expected data 'ErrorPage06 PASSED - JSP', got data 'ErrorPage06 FAILED - 
message is not correct'


Excerpt from catalina.out just in case it helps:

Jan 27, 2011 12:00:43 PM org.apache.catalina.core.ApplicationContext log
INFO: RequestListener01: requestInitialized()
Jan 27, 2011 12:00:43 PM org.apache.catalina.core.ApplicationContext log
INFO: RequestListener01: 
attributeAdded(org.apache.catalina.jsp_file,/ErrorPage08.jsp)

Jan 27, 2011 12:00:43 PM org.apache.catalina.core.ApplicationContext log
INFO: SessionListener01: sessionCreated(F404B825FBC270339EBB36A0E2303A50)
Jan 27, 2011 12:00:43 PM org.apache.catalina.core.ApplicationContext log
INFO: RequestListener01: 
attributeRemoved(org.apache.catalina.jsp_file,/ErrorPage08.jsp)
Jan 27, 2011 12:00:43 PM org.apache.catalina.core.StandardWrapperValve 
invoke

SEVERE: Servlet.service() for servlet ErrorPage08 threw exception
java.lang.ArithmeticException: ErrorPage08 Threw ArithmeticException
»···at 
org.apache.jsp.ErrorPage08_jsp._jspService(ErrorPage08_jsp.java:50)
»···at 
org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:98)

»···at javax.servlet.http.HttpServlet.service(HttpServlet.java:729)
»···at 
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:369)
»···at 
org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:308)

»···at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:259)
»···at javax.servlet.http.HttpServlet.service(HttpServlet.java:729)
»···at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:269)
»···at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188)

»···at org.apache.tester.StaticFilter.doFilter(StaticFilter.java:72)
»···at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:215)
»···at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188)
»···at 
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:213)
»···at 
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:172)
»···at 
org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:470)
»···at 
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
»···at 
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:117)
»···at 
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:108)
»···at 
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:174)
»···at 
org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:879)
»···at 
org.apache.coyote.http11.Http11BaseProtocol$Http11ConnectionHandler.processConnection(Http11BaseProtocol.java:665)
»···at 
org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket(PoolTcpEndpoint.java:528)
»···at 
org.apache.tomcat.util.net.LeaderFollowerWorkerThread.runIt(LeaderFollowerWorkerThread.java:81)
»···at 
org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:689)

»···at java.lang.Thread.run(Thread.java:534)
Jan 27, 2011 12:00:43 PM org.apache.catalina.core.ApplicationContext log
INFO: RequestListener01: 

Re: [VOTE] Release Tomcat 5.5.32 Build

2011-01-28 Thread Jim Jagielski

On Jan 28, 2011, at 5:56 AM, Rainer Jung wrote:
 
  - 4 errors in run-tester, but I vaguely remember those are
not regressions (details see below)
 

+1... non regressions (I should have noted them when
I called for the vote).


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Tomcat 5.5.32 Build

2011-01-27 Thread Filip Hanik - Dev Lists

On 01/22/2011 11:01 AM, Jim Jagielski wrote:

[X] Stable
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Tomcat 5.5.32 Build

2011-01-27 Thread Konstantin Kolinko
2011/1/22 Jim Jagielski j...@jagunet.com:
 [x] Stable

Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Tomcat 5.5.32 Build

2011-01-26 Thread Jim Jagielski

On Jan 22, 2011, at 1:01 PM, Jim Jagielski wrote:

 The builds for Tomcat 5.5.32 are ready for testing and approval.
 The candidates binaries are available here:
 
 http://people.apache.org/~jim/tomcat-5.5/
 
 According to the release process, the 5.5.32 build corresponding to the
 tag TOMCAT_5_5_32 [1] is:
 
 [ ] Broken
 [ ] Alpha
 [ ] Beta
 [ ] Stable
 +++
 
 1. http://svn.apache.org/viewvc/tomcat/tc5.5.x/tags/TOMCAT_5_5_32/
 


+1: STABLE

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Tomcat 5.5.32 Build

2011-01-26 Thread Mladen Turk

On 01/22/2011 07:01 PM, Jim Jagielski wrote:


According to the release process, the 5.5.32 build corresponding to the
tag TOMCAT_5_5_32 [1] is:

[ ] Broken
[ ] Alpha
[ ] Beta
[X] Stable



Regards
--
^TM

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Tomcat 5.5.32 Build

2011-01-23 Thread Jim Jagielski

On Jan 22, 2011, at 1:30 PM, Konstantin Kolinko wrote:

 2011/1/22 Jim Jagielski j...@jagunet.com:
 The builds for Tomcat 5.5.32 are ready for testing and approval.
 The candidates binaries are available here:
 
  http://people.apache.org/~jim/tomcat-5.5/
 
 According to the release process, the 5.5.32 build corresponding to the
 tag TOMCAT_5_5_32 [1] is:
 
 [ ] Broken
 [ ] Alpha
 [ ] Beta
 [ ] Stable
 +++
 
 1. http://svn.apache.org/viewvc/tomcat/tc5.5.x/tags/TOMCAT_5_5_32/
 
 
 1) I see the files, but cannot download them. The following URL
 responds with 403 forbidden
 http://people.apache.org/~jim/tomcat-5.5/v5.5.32/bin/apache-tomcat-5.5.32.zip
 
 Current permission of those files are:
 -rwx--  1 jim  jim  9080616 Jan 22 17:56 apache-tomcat-5.5.32.zip
 -rw-r--r--  1 jim  jim  187 Jan 22 17:56 apache-tomcat-5.5.32.zip.asc
 -rwx--  1 jim  jim   58 Jan 22 17:56 apache-tomcat-5.5.32.zip.md5
 

Fixed.

 2) Regarding version number bump
 http://svn.apache.org/viewvc?rev=1062211view=rev
 
 s/version.build=31/version.build=32/ is needed.
 
 IIRC version.bat/version.sh will display the wrong number.
 

Hrm... let me check. May require a re-TR
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[VOTE] Release Tomcat 5.5.32 Build

2011-01-22 Thread Jim Jagielski
The builds for Tomcat 5.5.32 are ready for testing and approval.
The candidates binaries are available here:

 http://people.apache.org/~jim/tomcat-5.5/

According to the release process, the 5.5.32 build corresponding to the
tag TOMCAT_5_5_32 [1] is:

[ ] Broken
[ ] Alpha
[ ] Beta
[ ] Stable
+++

1. http://svn.apache.org/viewvc/tomcat/tc5.5.x/tags/TOMCAT_5_5_32/


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Tomcat 5.5.32 Build

2011-01-22 Thread Konstantin Kolinko
2011/1/22 Jim Jagielski j...@jagunet.com:
 The builds for Tomcat 5.5.32 are ready for testing and approval.
 The candidates binaries are available here:

  http://people.apache.org/~jim/tomcat-5.5/

 According to the release process, the 5.5.32 build corresponding to the
 tag TOMCAT_5_5_32 [1] is:

 [ ] Broken
 [ ] Alpha
 [ ] Beta
 [ ] Stable
 +++

 1. http://svn.apache.org/viewvc/tomcat/tc5.5.x/tags/TOMCAT_5_5_32/


1) I see the files, but cannot download them. The following URL
responds with 403 forbidden
http://people.apache.org/~jim/tomcat-5.5/v5.5.32/bin/apache-tomcat-5.5.32.zip

Current permission of those files are:
-rwx--  1 jim  jim  9080616 Jan 22 17:56 apache-tomcat-5.5.32.zip
-rw-r--r--  1 jim  jim  187 Jan 22 17:56 apache-tomcat-5.5.32.zip.asc
-rwx--  1 jim  jim   58 Jan 22 17:56 apache-tomcat-5.5.32.zip.md5

2) Regarding version number bump
http://svn.apache.org/viewvc?rev=1062211view=rev

s/version.build=31/version.build=32/ is needed.

IIRC version.bat/version.sh will display the wrong number.


Best regards,
Konstantin Kolinko

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org