[jira] [Commented] (MTOMCAT-173) Direct dependencies are not added to classpath

2012-11-14 Thread Arne Franken (JIRA)

[ 
https://issues.apache.org/jira/browse/MTOMCAT-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13497175#comment-13497175
 ] 

Arne Franken commented on MTOMCAT-173:
--

I just built 2.1-SNAPSHOT locally and can confirm that the issue is fixed. 
Thanks!

 Direct dependencies are not added to classpath
 --

 Key: MTOMCAT-173
 URL: https://issues.apache.org/jira/browse/MTOMCAT-173
 Project: Apache Tomcat Maven Plugin
  Issue Type: Bug
  Components: tomcat6, tomcat7
Affects Versions: 2.0
Reporter: Arne Franken
Assignee: Olivier Lamy (*$^¨%`£)
 Fix For: 2.1


 in DefaultClassLoaderEntriesCalculator#calculateClassPathEntries, direct 
 dependencies are not added, the log message says skip adding artifact  + 
 artifact.getArtifactId() +  as it's in reactors. 
 In my case, it's a jar that is configured as a direct dependency. When the 
 Webapp starts, the Jar is missing from the Classpath and the startup fails.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[jira] [Commented] (MTOMCAT-173) Direct dependencies are not added to classpath

2012-11-13 Thread *$^¨%`£

[ 
https://issues.apache.org/jira/browse/MTOMCAT-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13496312#comment-13496312
 ] 

Olivier Lamy (*$^¨%`£) commented on MTOMCAT-173:


fixed http://svn.apache.org/r1408507

 Direct dependencies are not added to classpath
 --

 Key: MTOMCAT-173
 URL: https://issues.apache.org/jira/browse/MTOMCAT-173
 Project: Apache Tomcat Maven Plugin
  Issue Type: Bug
  Components: tomcat6, tomcat7
Affects Versions: 2.0
Reporter: Arne Franken
Assignee: Olivier Lamy (*$^¨%`£)
 Fix For: 2.1


 in DefaultClassLoaderEntriesCalculator#calculateClassPathEntries, direct 
 dependencies are not added, the log message says skip adding artifact  + 
 artifact.getArtifactId() +  as it's in reactors. 
 In my case, it's a jar that is configured as a direct dependency. When the 
 Webapp starts, the Jar is missing from the Classpath and the startup fails.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[jira] [Commented] (MTOMCAT-173) Direct dependencies are not added to classpath

2012-10-22 Thread JIRA

[ 
https://issues.apache.org/jira/browse/MTOMCAT-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13481281#comment-13481281
 ] 

Loïc Guerrin commented on MTOMCAT-173:
--

Hello,

I have the same issue with tomcat7-maven-plugin:2.0. But it's during an 
integration test with junit. I have the structure below:

/
-- project-domain
-- project-webapp

The module project-domain isn't added to the classpath and the startup of the 
tomcat fails.
In the maven debug log I see too 'skip adding artifact project-domain as it's 
in reactors'.

In DefaultClassLoaderEntriesCalculator#calculateClassPathEntries at line 116, 
the method isInProjectReferences rejects the project-domain as it's in 
projectReferences of project-webapp.

So is it possible to add a cheap workaround like a configuration parameter 
'forceIncludeProjectReferences' in order to add those project references to 
module classpath?

Thanks.


 Direct dependencies are not added to classpath
 --

 Key: MTOMCAT-173
 URL: https://issues.apache.org/jira/browse/MTOMCAT-173
 Project: Apache Tomcat Maven Plugin
  Issue Type: Bug
  Components: tomcat6, tomcat7
Affects Versions: 2.0
Reporter: Arne Franken
Assignee: Olivier Lamy (*$^¨%`£)

 in DefaultClassLoaderEntriesCalculator#calculateClassPathEntries, direct 
 dependencies are not added, the log message says skip adding artifact  + 
 artifact.getArtifactId() +  as it's in reactors. 
 In my case, it's a jar that is configured as a direct dependency. When the 
 Webapp starts, the Jar is missing from the Classpath and the startup fails.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[jira] [Commented] (MTOMCAT-173) Direct dependencies are not added to classpath

2012-08-20 Thread Arne Franken (JIRA)

[ 
https://issues.apache.org/jira/browse/MTOMCAT-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13437792#comment-13437792
 ] 

Arne Franken commented on MTOMCAT-173:
--

mvn -pl :dep-issue-webapp -am tomcat7:run
that actually works, but it means that I would ALWAYS have to build the webapp 
and ALL dependencies before I can start it.

That may not be a problem in a small test project like the one the archetype 
creates, but this is a big problem in a project where I have lot of 
dependencies with (tens of) thousands of lines of code that have to be compiled 
over and over again if I just want to restart my webapp.

 Direct dependencies are not added to classpath
 --

 Key: MTOMCAT-173
 URL: https://issues.apache.org/jira/browse/MTOMCAT-173
 Project: Apache Tomcat Maven Plugin
  Issue Type: Bug
  Components: tomcat6, tomcat7
Affects Versions: 2.0
Reporter: Arne Franken
Assignee: Olivier Lamy (*$^¨%`£)

 in DefaultClassLoaderEntriesCalculator#calculateClassPathEntries, direct 
 dependencies are not added, the log message says skip adding artifact  + 
 artifact.getArtifactId() +  as it's in reactors. 
 In my case, it's a jar that is configured as a direct dependency. When the 
 Webapp starts, the Jar is missing from the Classpath and the startup fails.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[jira] [Commented] (MTOMCAT-173) Direct dependencies are not added to classpath

2012-08-20 Thread *$^¨%`£

[ 
https://issues.apache.org/jira/browse/MTOMCAT-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13437813#comment-13437813
 ] 

Olivier Lamy (*$^¨%`£) commented on MTOMCAT-173:


I miss you here ! 
Don't clean your projects and you won't rebuild/recompile everything.
use only mvn -pl :dep-issue-webapp tomcat7:run (without -am) if you don't want 
to rebuild/recompile everything.

 Direct dependencies are not added to classpath
 --

 Key: MTOMCAT-173
 URL: https://issues.apache.org/jira/browse/MTOMCAT-173
 Project: Apache Tomcat Maven Plugin
  Issue Type: Bug
  Components: tomcat6, tomcat7
Affects Versions: 2.0
Reporter: Arne Franken
Assignee: Olivier Lamy (*$^¨%`£)

 in DefaultClassLoaderEntriesCalculator#calculateClassPathEntries, direct 
 dependencies are not added, the log message says skip adding artifact  + 
 artifact.getArtifactId() +  as it's in reactors. 
 In my case, it's a jar that is configured as a direct dependency. When the 
 Webapp starts, the Jar is missing from the Classpath and the startup fails.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[jira] [Commented] (MTOMCAT-173) Direct dependencies are not added to classpath

2012-08-20 Thread Arne Franken (JIRA)

[ 
https://issues.apache.org/jira/browse/MTOMCAT-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13437956#comment-13437956
 ] 

Arne Franken commented on MTOMCAT-173:
--

 Don't clean your projects
oops, of course you're right about that.

 use only mvn -pl :dep-issue-webapp tomcat7:run (without -am) if you don't 
 want to rebuild/recompile everything.
if I don't use -am, Tomcat will not have all necessary libraries in the 
classpath

if I use -am , Tomcat will have all necessary libraries in the classpath, but 
this won't work if any of my dependencies are also WAR artefacts which also 
have a Tomcat configuration since Maven will run the Tomcat plugin for the 
first module with plugin configuration in the dependency chain.
Also, dependencies will only be added to the classpath if they are compile time 
dependencies, whereas a WAR artefact only needs runtime dependencies if it 
doesn't contain code that needs compiling.

For me the only working workaround at the moment is to run mvn tomcat7:run 
directly in the directory of the webapp module.

 Direct dependencies are not added to classpath
 --

 Key: MTOMCAT-173
 URL: https://issues.apache.org/jira/browse/MTOMCAT-173
 Project: Apache Tomcat Maven Plugin
  Issue Type: Bug
  Components: tomcat6, tomcat7
Affects Versions: 2.0
Reporter: Arne Franken
Assignee: Olivier Lamy (*$^¨%`£)

 in DefaultClassLoaderEntriesCalculator#calculateClassPathEntries, direct 
 dependencies are not added, the log message says skip adding artifact  + 
 artifact.getArtifactId() +  as it's in reactors. 
 In my case, it's a jar that is configured as a direct dependency. When the 
 Webapp starts, the Jar is missing from the Classpath and the startup fails.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[jira] [Commented] (MTOMCAT-173) Direct dependencies are not added to classpath

2012-08-18 Thread *$^¨%`£

[ 
https://issues.apache.org/jira/browse/MTOMCAT-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13437416#comment-13437416
 ] 

Olivier Lamy (*$^¨%`£) commented on MTOMCAT-173:


use:
mvn -pl :dep-issue-webapp -am tomcat7:run 


 Direct dependencies are not added to classpath
 --

 Key: MTOMCAT-173
 URL: https://issues.apache.org/jira/browse/MTOMCAT-173
 Project: Apache Tomcat Maven Plugin
  Issue Type: Bug
  Components: tomcat6, tomcat7
Affects Versions: 2.0
Reporter: Arne Franken
Assignee: Olivier Lamy (*$^¨%`£)

 in DefaultClassLoaderEntriesCalculator#calculateClassPathEntries, direct 
 dependencies are not added, the log message says skip adding artifact  + 
 artifact.getArtifactId() +  as it's in reactors. 
 In my case, it's a jar that is configured as a direct dependency. When the 
 Webapp starts, the Jar is missing from the Classpath and the startup fails.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[jira] [Commented] (MTOMCAT-173) Direct dependencies are not added to classpath

2012-08-17 Thread Arne Franken (JIRA)

[ 
https://issues.apache.org/jira/browse/MTOMCAT-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13436637#comment-13436637
 ] 

Arne Franken commented on MTOMCAT-173:
--

I just found what the problem is:

I created a new project using your archetype. Example directory structure:
dep-issue-api/
dep-issue-api-impl/
dep-issue-webapp/
dep-issue-webapp-exec/
dep-issue-webapp-it/

I usually build and start all modules from the projects root directory, in this 
case:
mvn -am -pl dep-issue-webapp clean install  mvn -pl dep-issue-webapp 
tomcat7:run

if I start the tomcat plugin this way, all direct dependencies of the 
dep-issue-webapp module will not be added to the classpath by Maven, the 
startup of the webapp will fail.

-

If I instead do this:
mvn -am -pl dep-issue-webapp clean install
cd dep-issue-webapp
mvn tomcat7:run

Maven will add all direct dependencies to the classpath and the webapp will 
start correctly.

 Direct dependencies are not added to classpath
 --

 Key: MTOMCAT-173
 URL: https://issues.apache.org/jira/browse/MTOMCAT-173
 Project: Apache Tomcat Maven Plugin
  Issue Type: Bug
  Components: tomcat6, tomcat7
Affects Versions: 2.0
Reporter: Arne Franken
Assignee: Olivier Lamy (*$^¨%`£)

 in DefaultClassLoaderEntriesCalculator#calculateClassPathEntries, direct 
 dependencies are not added, the log message says skip adding artifact  + 
 artifact.getArtifactId() +  as it's in reactors. 
 In my case, it's a jar that is configured as a direct dependency. When the 
 Webapp starts, the Jar is missing from the Classpath and the startup fails.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[jira] [Commented] (MTOMCAT-173) Direct dependencies are not added to classpath

2012-08-16 Thread Arne Franken (JIRA)

[ 
https://issues.apache.org/jira/browse/MTOMCAT-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13435809#comment-13435809
 ] 

Arne Franken commented on MTOMCAT-173:
--

I'm using {{Apache Maven 3.0.4 (r1232337; 2012-01-17 09:44:56+0100)}}

 Direct dependencies are not added to classpath
 --

 Key: MTOMCAT-173
 URL: https://issues.apache.org/jira/browse/MTOMCAT-173
 Project: Apache Tomcat Maven Plugin
  Issue Type: Bug
  Components: tomcat6, tomcat7
Affects Versions: 2.0
Reporter: Arne Franken
Assignee: Olivier Lamy (*$^¨%`£)

 in DefaultClassLoaderEntriesCalculator#calculateClassPathEntries, direct 
 dependencies are not added, the log message says skip adding artifact  + 
 artifact.getArtifactId() +  as it's in reactors. 
 In my case, it's a jar that is configured as a direct dependency. When the 
 Webapp starts, the Jar is missing from the Classpath and the startup fails.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[jira] [Commented] (MTOMCAT-173) Direct dependencies are not added to classpath

2012-08-16 Thread *$^¨%`£

[ 
https://issues.apache.org/jira/browse/MTOMCAT-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13436348#comment-13436348
 ] 

Olivier Lamy (*$^¨%`£) commented on MTOMCAT-173:


So should work fine.
Do you have any sample project to reproduce your isssue ?

 Direct dependencies are not added to classpath
 --

 Key: MTOMCAT-173
 URL: https://issues.apache.org/jira/browse/MTOMCAT-173
 Project: Apache Tomcat Maven Plugin
  Issue Type: Bug
  Components: tomcat6, tomcat7
Affects Versions: 2.0
Reporter: Arne Franken
Assignee: Olivier Lamy (*$^¨%`£)

 in DefaultClassLoaderEntriesCalculator#calculateClassPathEntries, direct 
 dependencies are not added, the log message says skip adding artifact  + 
 artifact.getArtifactId() +  as it's in reactors. 
 In my case, it's a jar that is configured as a direct dependency. When the 
 Webapp starts, the Jar is missing from the Classpath and the startup fails.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[jira] [Commented] (MTOMCAT-173) Direct dependencies are not added to classpath

2012-08-15 Thread *$^¨%`£

[ 
https://issues.apache.org/jira/browse/MTOMCAT-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13435556#comment-13435556
 ] 

Olivier Lamy (*$^¨%`£) commented on MTOMCAT-173:


That's not a problem as classpath elements (the output directory of your 
dependency from reactors is added to the class path).
Which maven version are you using ? (I have to say that work only with maven 3).

 Direct dependencies are not added to classpath
 --

 Key: MTOMCAT-173
 URL: https://issues.apache.org/jira/browse/MTOMCAT-173
 Project: Apache Tomcat Maven Plugin
  Issue Type: Bug
  Components: tomcat6, tomcat7
Affects Versions: 2.0
Reporter: Arne Franken
Assignee: Olivier Lamy (*$^¨%`£)

 in DefaultClassLoaderEntriesCalculator#calculateClassPathEntries, direct 
 dependencies are not added, the log message says skip adding artifact  + 
 artifact.getArtifactId() +  as it's in reactors. 
 In my case, it's a jar that is configured as a direct dependency. When the 
 Webapp starts, the Jar is missing from the Classpath and the startup fails.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org