[Bug 64309] Improve repository regular expression performance used for bootstrapping Catalina
https://bz.apache.org/bugzilla/show_bug.cgi?id=64309 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Mark Thomas --- Fixed in: - master for 10.0.0-M5 onwards - 9.0.x for 9.0.35 onwards - 8.5.x for 8.5.55 onwards -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [Bug 64309] Improve repository regular expression performance used for bootstrapping Catalina
Yes, I also think the same. I will push the pull request for the enhancement. Paul > On Apr 7, 2020, at 8:48 AM, Mark Thomas wrote: > > On 07/04/2020 13:39, Paul Muriel Biya-Bi wrote: >> Hi Mark, >> >> In our case, the performance difference is indeed very small. On my Ubuntu >> system, I did a basic performance measurement (using >> System.currentTimeMillis()) on my common.loader path. With the >> Bootstrap.getPaths() method, I gained only 2 illiseconds on a repository >> path of 340 characters. The performance difference would have been more >> important if the repository path was a longer. >> >> So should we forget about this enhancement? > > Up to you. I've no objection to it. A couple of milliseconds might > matter to some users. > > Mark > > >> >> Thanks, >> Paul >> On Apr 6, 2020, at 10:46 AM, bugzi...@apache.org wrote: >>> >>> https://bz.apache.org/bugzilla/show_bug.cgi?id=64309 >>> >>> --- Comment #1 from Mark Thomas --- >>> No objections but I do wonder if the performance difference is noticeable or >>> even measurable given that this happens once on start-up. >>> >>> -- >>> You are receiving this mail because: >>> You are the assignee for the bug. >>> - >>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >>> For additional commands, e-mail: dev-h...@tomcat.apache.org >> >> - >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >> For additional commands, e-mail: dev-h...@tomcat.apache.org >> > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [Bug 64309] Improve repository regular expression performance used for bootstrapping Catalina
On 07/04/2020 13:39, Paul Muriel Biya-Bi wrote: > Hi Mark, > > In our case, the performance difference is indeed very small. On my Ubuntu > system, I did a basic performance measurement (using > System.currentTimeMillis()) on my common.loader path. With the > Bootstrap.getPaths() method, I gained only 2 illiseconds on a repository path > of 340 characters. The performance difference would have been more important > if the repository path was a longer. > > So should we forget about this enhancement? Up to you. I've no objection to it. A couple of milliseconds might matter to some users. Mark > > Thanks, > Paul > >> On Apr 6, 2020, at 10:46 AM, bugzi...@apache.org wrote: >> >> https://bz.apache.org/bugzilla/show_bug.cgi?id=64309 >> >> --- Comment #1 from Mark Thomas --- >> No objections but I do wonder if the performance difference is noticeable or >> even measurable given that this happens once on start-up. >> >> -- >> You are receiving this mail because: >> You are the assignee for the bug. >> - >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >> For additional commands, e-mail: dev-h...@tomcat.apache.org > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [Bug 64309] Improve repository regular expression performance used for bootstrapping Catalina
Hi Mark, In our case, the performance difference is indeed very small. On my Ubuntu system, I did a basic performance measurement (using System.currentTimeMillis()) on my common.loader path. With the Bootstrap.getPaths() method, I gained only 2 illiseconds on a repository path of 340 characters. The performance difference would have been more important if the repository path was a longer. So should we forget about this enhancement? Thanks, Paul > On Apr 6, 2020, at 10:46 AM, bugzi...@apache.org wrote: > > https://bz.apache.org/bugzilla/show_bug.cgi?id=64309 > > --- Comment #1 from Mark Thomas --- > No objections but I do wonder if the performance difference is noticeable or > even measurable given that this happens once on start-up. > > -- > You are receiving this mail because: > You are the assignee for the bug. > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 64309] Improve repository regular expression performance used for bootstrapping Catalina
https://bz.apache.org/bugzilla/show_bug.cgi?id=64309 --- Comment #1 from Mark Thomas --- No objections but I do wonder if the performance difference is noticeable or even measurable given that this happens once on start-up. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
