DO NOT REPLY [Bug 38216] Extend Jmxproxy to allow call of MBean Operations
https://issues.apache.org/bugzilla/show_bug.cgi?id=38216 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||FIXED --- Comment #8 from Mark Thomas ma...@apache.org 2012-01-22 18:34:10 UTC --- Patch looks good to me. Applied to trunk and 7.0.x and will be included in 7.0.26 onwards. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 38216] Extend Jmxproxy to allow call of MBean Operations
https://issues.apache.org/bugzilla/show_bug.cgi?id=38216 --- Comment #7 from Konstantin Kolinko knst.koli...@gmail.com 2012-01-19 07:19:33 UTC --- Created attachment 28173 -- https://issues.apache.org/bugzilla/attachment.cgi?id=28173 2012-01-19_tc8_JMXProxyServlet.patch Yours covers most common use case of method returning void/null. I think null values inside arrays should be handled as well. I am attaching patch that I am thinking about that covers null values in getAttribute() operation as well. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 38216] Extend Jmxproxy to allow call of MBean Operations
https://issues.apache.org/bugzilla/show_bug.cgi?id=38216
Chris O'Connor tom...@croconnor.co.uk changed:
What|Removed |Added
Status|RESOLVED|REOPENED
Resolution|FIXED |
--- Comment #6 from Chris O'Connor tom...@croconnor.co.uk 2012-01-17 14:49:57
UTC ---
Very useful feature and i'm just putting it onto our tomcat 6 boxes. However it
doesn't account for the invocation of the mbean returning null when outputting
the result. I propose that the invokeOperation becomes
public void invokeOperation(PrintWriter writer, String onameStr, String op,
String[] valuesStr){
try {
ObjectName oname=new ObjectName( onameStr );
MBeanOperationInfo methodInfo = registry.getMethodInfo(oname,op);
MBeanParameterInfo[] signature = methodInfo.getSignature();
String[] signatureTypes = new String[signature.length];
Object[] values = new Object[signature.length];
for (int i = 0; i signature.length; i++) {
MBeanParameterInfo pi = signature[i];
signatureTypes[i] = pi.getType();
values[i] = registry.convertValue(pi.getType(), valuesStr[i] );
}
Object retVal = mBeanServer.invoke(oname,op,values,signatureTypes);
if(retVal != null){
writer.println(OK - Operation + op + returned:);
output(, writer, retVal);
}else{
writer.println(OK - Operation + op + without return
value);
}
} catch( Exception ex ) {
writer.println(Error - + ex.toString());
ex.printStackTrace(writer);
}
}
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 38216] Extend Jmxproxy to allow call of MBean Operations
https://issues.apache.org/bugzilla/show_bug.cgi?id=38216 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #5 from Mark Thomas ma...@apache.org 2012-01-15 21:42:53 UTC --- After rather too long a variation of this patch has been applied to trunk and 7.0.x and will be included in 7.0.24 onwards. The main changes I made to the proposed patch were: - fixing a potential NPE when a method required zero parameters - improving the output when an array was returned (as is often the case with Tomcat MBeans) -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 38216] Extend Jmxproxy to allow call of MBean Operations
https://issues.apache.org/bugzilla/show_bug.cgi?id=38216 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEEDINFO|NEW Component|Webapps:Manager |Manager Version|Unknown |unspecified Product|Tomcat 5|Tomcat 7 --- Comment #4 from Mark Thomas ma...@apache.org 2011-12-20 20:32:18 UTC --- This Tomcat 5 enhancement request has been moved to Tomcat 7 (the latest version) since Tomcat 5 development is limited and focussed on bugs and security issues whereas Tomcat 7 is still seeing new feature development. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 38216] - Extend Jmxproxy to allow call of MBean Operations
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=38216. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=38216 --- Additional Comments From [EMAIL PROTECTED] 2007-01-02 04:25 --- It was definitely more than a feeling :) I'll attach a patch showing my modifications. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 38216] - Extend Jmxproxy to allow call of MBean Operations
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=38216. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=38216 --- Additional Comments From [EMAIL PROTECTED] 2007-01-02 06:59 --- Created an attachment (id=19340) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=19340action=view) The patch introduces an invoke operation to the proxy The operation is specified by the op parameter and the parameters of the JMX operation are specified (as a comma seperated list) by the ps parameter. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 38216] - Extend Jmxproxy to allow call of MBean Operations
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=38216. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=38216 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |NEEDINFO --- Additional Comments From [EMAIL PROTECTED] 2006-12-24 17:52 --- Got a specific patch in mind, or just a general this would be good feeling? ;) -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
