Hi
Subscribe Sent from my iPad - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Hi
Hi Mark Chris, I implemented the suggestions and uploaded the patch with changes. can you verify it? https://issues.apache.org/bugzilla/show_bug.cgi?id=57021 Thanks, VIN On Wed, Feb 11, 2015 at 6:12 PM, Pravallika Peddi reachme.va...@gmail.com wrote: Thanks for your guidance in this Mark and Chris. Hope my first fix will be accepted. On Wed, Feb 11, 2015 at 5:16 PM, Mark Thomas ma...@apache.org wrote: On 11/02/2015 11:32, Pravallika Peddi wrote: Hi Mark, I have created the patch file as you mentioned and attached it to the bug report, i would like to confirm on one thing: I have added two new strings to the LocalStrings.properties file which has Locale specific strings. Some one has to help to add the new strings to the other Locale files like Japaneese, france, etc... Don't worry about those. They can be completed later. Another query is: When can i mark the issue as RESOLVED? You don't. A committer will mark this issue as fixed once they have review and applied your patch. and who will verify my patch to make sure it is working? This is the responsibility of the committer who commits the patch. From my side i verified the fix. Great. One of the committers will look at this shortly. Mark On Wed, Feb 11, 2015 at 2:43 PM, Mark Thomas ma...@apache.org wrote: On 11/02/2015 06:25, Pravallika Peddi wrote: Hi Mark, Attached the fix details. Patches should be in diff -u format and attached to the bug report to which they relate. Mark I have modified AprLifecycleListener.java and Library.java to fix the issue. Added a new file LibraryNotFoundError.java in org.apache.tomcat.jni package. Added two new strings in LocalStrings.properties file located in org.apache.catalina.core package. I do not know the other languages so did not add the new strings in other property files. I tested the fix and attached the log files as well. I provided the fix based on the comments provided in the issue. I did not implement the 3rd point(C) yet as i did not feel it so important. Let me know if it is required so that i can fix the third point too. Please validate the fix so that i can commit to svn. Thanks, VIN On Tue, Feb 10, 2015 at 5:15 PM, Pravallika Peddi reachme.va...@gmail.com mailto:reachme.va...@gmail.com wrote: Got you Mark. Now i am able to reproduce the problem by keeping I64 bit dll in x64 bit windows platform. I will fix it and let you know. Thanks, VIN On Tue, Feb 10, 2015 at 2:19 PM, Mark Thomas ma...@apache.org mailto:ma...@apache.org wrote: On 10/02/2015 06:28, Pravallika Peddi wrote: Thanks Chris for the information. Mark Chris: I have gone through one of the issues given by Mark: https://issues.apache.org/bugzilla/show_bug.cgi?id=57021 and found that this issue is fixed already. Steps i performed: 1) Download Tomcat 6.0 - 32 bit version and run it on 32-bit Windows platform. Tomcat Server started successfully using commands mentioned in issue. Stop the tomcat. Check the catalina.out folder and it has no error messages. Rename catalina.out file. 2) Download Tomcat 6.0-64 bit version and extract tcnative-dll and copy it on to 32-bit Tomcat folder. Start the Tomcat Server and check the catalina.out file. It has proper error message Feb 10, 2015 11:42:54 AM org.apache.catalina.core.AprLifecycleListener init INFO: The APR based Apache Tomcat Native library which allows optimal performance in production environments was not found on the java.library.path: and i did not observe any error in command line as mentioned in the issue. I attached both the catalina.out files for your reference. Even i checked the recent Trunk AppLifecycleListener.init() java method and did not find the source code that was mentioned in the issue. Hence i feel the issue is fixed. Please confirm so that i will close the issue. The issue is not fixed. Tomcat isn't finding the tc-native library so the error isn't triggering. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org mailto:dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org mailto:dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Hi
On 11/02/2015 06:25, Pravallika Peddi wrote: Hi Mark, Attached the fix details. Patches should be in diff -u format and attached to the bug report to which they relate. Mark I have modified AprLifecycleListener.java and Library.java to fix the issue. Added a new file LibraryNotFoundError.java in org.apache.tomcat.jni package. Added two new strings in LocalStrings.properties file located in org.apache.catalina.core package. I do not know the other languages so did not add the new strings in other property files. I tested the fix and attached the log files as well. I provided the fix based on the comments provided in the issue. I did not implement the 3rd point(C) yet as i did not feel it so important. Let me know if it is required so that i can fix the third point too. Please validate the fix so that i can commit to svn. Thanks, VIN On Tue, Feb 10, 2015 at 5:15 PM, Pravallika Peddi reachme.va...@gmail.com mailto:reachme.va...@gmail.com wrote: Got you Mark. Now i am able to reproduce the problem by keeping I64 bit dll in x64 bit windows platform. I will fix it and let you know. Thanks, VIN On Tue, Feb 10, 2015 at 2:19 PM, Mark Thomas ma...@apache.org mailto:ma...@apache.org wrote: On 10/02/2015 06:28, Pravallika Peddi wrote: Thanks Chris for the information. Mark Chris: I have gone through one of the issues given by Mark: https://issues.apache.org/bugzilla/show_bug.cgi?id=57021 and found that this issue is fixed already. Steps i performed: 1) Download Tomcat 6.0 - 32 bit version and run it on 32-bit Windows platform. Tomcat Server started successfully using commands mentioned in issue. Stop the tomcat. Check the catalina.out folder and it has no error messages. Rename catalina.out file. 2) Download Tomcat 6.0-64 bit version and extract tcnative-dll and copy it on to 32-bit Tomcat folder. Start the Tomcat Server and check the catalina.out file. It has proper error message Feb 10, 2015 11:42:54 AM org.apache.catalina.core.AprLifecycleListener init INFO: The APR based Apache Tomcat Native library which allows optimal performance in production environments was not found on the java.library.path: and i did not observe any error in command line as mentioned in the issue. I attached both the catalina.out files for your reference. Even i checked the recent Trunk AppLifecycleListener.init() java method and did not find the source code that was mentioned in the issue. Hence i feel the issue is fixed. Please confirm so that i will close the issue. The issue is not fixed. Tomcat isn't finding the tc-native library so the error isn't triggering. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org mailto:dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org mailto:dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Hi
Hi Mark, I have created the patch file as you mentioned and attached it to the bug report, i would like to confirm on one thing: I have added two new strings to the LocalStrings.properties file which has Locale specific strings. Some one has to help to add the new strings to the other Locale files like Japaneese, france, etc... Another query is: When can i mark the issue as RESOLVED? and who will verify my patch to make sure it is working? From my side i verified the fix. On Wed, Feb 11, 2015 at 2:43 PM, Mark Thomas ma...@apache.org wrote: On 11/02/2015 06:25, Pravallika Peddi wrote: Hi Mark, Attached the fix details. Patches should be in diff -u format and attached to the bug report to which they relate. Mark I have modified AprLifecycleListener.java and Library.java to fix the issue. Added a new file LibraryNotFoundError.java in org.apache.tomcat.jni package. Added two new strings in LocalStrings.properties file located in org.apache.catalina.core package. I do not know the other languages so did not add the new strings in other property files. I tested the fix and attached the log files as well. I provided the fix based on the comments provided in the issue. I did not implement the 3rd point(C) yet as i did not feel it so important. Let me know if it is required so that i can fix the third point too. Please validate the fix so that i can commit to svn. Thanks, VIN On Tue, Feb 10, 2015 at 5:15 PM, Pravallika Peddi reachme.va...@gmail.com mailto:reachme.va...@gmail.com wrote: Got you Mark. Now i am able to reproduce the problem by keeping I64 bit dll in x64 bit windows platform. I will fix it and let you know. Thanks, VIN On Tue, Feb 10, 2015 at 2:19 PM, Mark Thomas ma...@apache.org mailto:ma...@apache.org wrote: On 10/02/2015 06:28, Pravallika Peddi wrote: Thanks Chris for the information. Mark Chris: I have gone through one of the issues given by Mark: https://issues.apache.org/bugzilla/show_bug.cgi?id=57021 and found that this issue is fixed already. Steps i performed: 1) Download Tomcat 6.0 - 32 bit version and run it on 32-bit Windows platform. Tomcat Server started successfully using commands mentioned in issue. Stop the tomcat. Check the catalina.out folder and it has no error messages. Rename catalina.out file. 2) Download Tomcat 6.0-64 bit version and extract tcnative-dll and copy it on to 32-bit Tomcat folder. Start the Tomcat Server and check the catalina.out file. It has proper error message Feb 10, 2015 11:42:54 AM org.apache.catalina.core.AprLifecycleListener init INFO: The APR based Apache Tomcat Native library which allows optimal performance in production environments was not found on the java.library.path: and i did not observe any error in command line as mentioned in the issue. I attached both the catalina.out files for your reference. Even i checked the recent Trunk AppLifecycleListener.init() java method and did not find the source code that was mentioned in the issue. Hence i feel the issue is fixed. Please confirm so that i will close the issue. The issue is not fixed. Tomcat isn't finding the tc-native library so the error isn't triggering. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org mailto:dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org mailto:dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Hi
On 11/02/2015 11:32, Pravallika Peddi wrote: Hi Mark, I have created the patch file as you mentioned and attached it to the bug report, i would like to confirm on one thing: I have added two new strings to the LocalStrings.properties file which has Locale specific strings. Some one has to help to add the new strings to the other Locale files like Japaneese, france, etc... Don't worry about those. They can be completed later. Another query is: When can i mark the issue as RESOLVED? You don't. A committer will mark this issue as fixed once they have review and applied your patch. and who will verify my patch to make sure it is working? This is the responsibility of the committer who commits the patch. From my side i verified the fix. Great. One of the committers will look at this shortly. Mark On Wed, Feb 11, 2015 at 2:43 PM, Mark Thomas ma...@apache.org wrote: On 11/02/2015 06:25, Pravallika Peddi wrote: Hi Mark, Attached the fix details. Patches should be in diff -u format and attached to the bug report to which they relate. Mark I have modified AprLifecycleListener.java and Library.java to fix the issue. Added a new file LibraryNotFoundError.java in org.apache.tomcat.jni package. Added two new strings in LocalStrings.properties file located in org.apache.catalina.core package. I do not know the other languages so did not add the new strings in other property files. I tested the fix and attached the log files as well. I provided the fix based on the comments provided in the issue. I did not implement the 3rd point(C) yet as i did not feel it so important. Let me know if it is required so that i can fix the third point too. Please validate the fix so that i can commit to svn. Thanks, VIN On Tue, Feb 10, 2015 at 5:15 PM, Pravallika Peddi reachme.va...@gmail.com mailto:reachme.va...@gmail.com wrote: Got you Mark. Now i am able to reproduce the problem by keeping I64 bit dll in x64 bit windows platform. I will fix it and let you know. Thanks, VIN On Tue, Feb 10, 2015 at 2:19 PM, Mark Thomas ma...@apache.org mailto:ma...@apache.org wrote: On 10/02/2015 06:28, Pravallika Peddi wrote: Thanks Chris for the information. Mark Chris: I have gone through one of the issues given by Mark: https://issues.apache.org/bugzilla/show_bug.cgi?id=57021 and found that this issue is fixed already. Steps i performed: 1) Download Tomcat 6.0 - 32 bit version and run it on 32-bit Windows platform. Tomcat Server started successfully using commands mentioned in issue. Stop the tomcat. Check the catalina.out folder and it has no error messages. Rename catalina.out file. 2) Download Tomcat 6.0-64 bit version and extract tcnative-dll and copy it on to 32-bit Tomcat folder. Start the Tomcat Server and check the catalina.out file. It has proper error message Feb 10, 2015 11:42:54 AM org.apache.catalina.core.AprLifecycleListener init INFO: The APR based Apache Tomcat Native library which allows optimal performance in production environments was not found on the java.library.path: and i did not observe any error in command line as mentioned in the issue. I attached both the catalina.out files for your reference. Even i checked the recent Trunk AppLifecycleListener.init() java method and did not find the source code that was mentioned in the issue. Hence i feel the issue is fixed. Please confirm so that i will close the issue. The issue is not fixed. Tomcat isn't finding the tc-native library so the error isn't triggering. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org mailto:dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org mailto:dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Hi
Thanks for your guidance in this Mark and Chris. Hope my first fix will be accepted. On Wed, Feb 11, 2015 at 5:16 PM, Mark Thomas ma...@apache.org wrote: On 11/02/2015 11:32, Pravallika Peddi wrote: Hi Mark, I have created the patch file as you mentioned and attached it to the bug report, i would like to confirm on one thing: I have added two new strings to the LocalStrings.properties file which has Locale specific strings. Some one has to help to add the new strings to the other Locale files like Japaneese, france, etc... Don't worry about those. They can be completed later. Another query is: When can i mark the issue as RESOLVED? You don't. A committer will mark this issue as fixed once they have review and applied your patch. and who will verify my patch to make sure it is working? This is the responsibility of the committer who commits the patch. From my side i verified the fix. Great. One of the committers will look at this shortly. Mark On Wed, Feb 11, 2015 at 2:43 PM, Mark Thomas ma...@apache.org wrote: On 11/02/2015 06:25, Pravallika Peddi wrote: Hi Mark, Attached the fix details. Patches should be in diff -u format and attached to the bug report to which they relate. Mark I have modified AprLifecycleListener.java and Library.java to fix the issue. Added a new file LibraryNotFoundError.java in org.apache.tomcat.jni package. Added two new strings in LocalStrings.properties file located in org.apache.catalina.core package. I do not know the other languages so did not add the new strings in other property files. I tested the fix and attached the log files as well. I provided the fix based on the comments provided in the issue. I did not implement the 3rd point(C) yet as i did not feel it so important. Let me know if it is required so that i can fix the third point too. Please validate the fix so that i can commit to svn. Thanks, VIN On Tue, Feb 10, 2015 at 5:15 PM, Pravallika Peddi reachme.va...@gmail.com mailto:reachme.va...@gmail.com wrote: Got you Mark. Now i am able to reproduce the problem by keeping I64 bit dll in x64 bit windows platform. I will fix it and let you know. Thanks, VIN On Tue, Feb 10, 2015 at 2:19 PM, Mark Thomas ma...@apache.org mailto:ma...@apache.org wrote: On 10/02/2015 06:28, Pravallika Peddi wrote: Thanks Chris for the information. Mark Chris: I have gone through one of the issues given by Mark: https://issues.apache.org/bugzilla/show_bug.cgi?id=57021 and found that this issue is fixed already. Steps i performed: 1) Download Tomcat 6.0 - 32 bit version and run it on 32-bit Windows platform. Tomcat Server started successfully using commands mentioned in issue. Stop the tomcat. Check the catalina.out folder and it has no error messages. Rename catalina.out file. 2) Download Tomcat 6.0-64 bit version and extract tcnative-dll and copy it on to 32-bit Tomcat folder. Start the Tomcat Server and check the catalina.out file. It has proper error message Feb 10, 2015 11:42:54 AM org.apache.catalina.core.AprLifecycleListener init INFO: The APR based Apache Tomcat Native library which allows optimal performance in production environments was not found on the java.library.path: and i did not observe any error in command line as mentioned in the issue. I attached both the catalina.out files for your reference. Even i checked the recent Trunk AppLifecycleListener.init() java method and did not find the source code that was mentioned in the issue. Hence i feel the issue is fixed. Please confirm so that i will close the issue. The issue is not fixed. Tomcat isn't finding the tc-native library so the error isn't triggering. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org mailto:dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org mailto:dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Hi
On 10/02/2015 06:28, Pravallika Peddi wrote: Thanks Chris for the information. Mark Chris: I have gone through one of the issues given by Mark: https://issues.apache.org/bugzilla/show_bug.cgi?id=57021 and found that this issue is fixed already. Steps i performed: 1) Download Tomcat 6.0 - 32 bit version and run it on 32-bit Windows platform. Tomcat Server started successfully using commands mentioned in issue. Stop the tomcat. Check the catalina.out folder and it has no error messages. Rename catalina.out file. 2) Download Tomcat 6.0-64 bit version and extract tcnative-dll and copy it on to 32-bit Tomcat folder. Start the Tomcat Server and check the catalina.out file. It has proper error message Feb 10, 2015 11:42:54 AM org.apache.catalina.core.AprLifecycleListener init INFO: The APR based Apache Tomcat Native library which allows optimal performance in production environments was not found on the java.library.path: and i did not observe any error in command line as mentioned in the issue. I attached both the catalina.out files for your reference. Even i checked the recent Trunk AppLifecycleListener.init() java method and did not find the source code that was mentioned in the issue. Hence i feel the issue is fixed. Please confirm so that i will close the issue. The issue is not fixed. Tomcat isn't finding the tc-native library so the error isn't triggering. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Hi
Got you Mark. Now i am able to reproduce the problem by keeping I64 bit dll in x64 bit windows platform. I will fix it and let you know. Thanks, VIN On Tue, Feb 10, 2015 at 2:19 PM, Mark Thomas ma...@apache.org wrote: On 10/02/2015 06:28, Pravallika Peddi wrote: Thanks Chris for the information. Mark Chris: I have gone through one of the issues given by Mark: https://issues.apache.org/bugzilla/show_bug.cgi?id=57021 and found that this issue is fixed already. Steps i performed: 1) Download Tomcat 6.0 - 32 bit version and run it on 32-bit Windows platform. Tomcat Server started successfully using commands mentioned in issue. Stop the tomcat. Check the catalina.out folder and it has no error messages. Rename catalina.out file. 2) Download Tomcat 6.0-64 bit version and extract tcnative-dll and copy it on to 32-bit Tomcat folder. Start the Tomcat Server and check the catalina.out file. It has proper error message Feb 10, 2015 11:42:54 AM org.apache.catalina.core.AprLifecycleListener init INFO: The APR based Apache Tomcat Native library which allows optimal performance in production environments was not found on the java.library.path: and i did not observe any error in command line as mentioned in the issue. I attached both the catalina.out files for your reference. Even i checked the recent Trunk AppLifecycleListener.init() java method and did not find the source code that was mentioned in the issue. Hence i feel the issue is fixed. Please confirm so that i will close the issue. The issue is not fixed. Tomcat isn't finding the tc-native library so the error isn't triggering. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Hi
Thanks for the reply Mark. What is the editor that is generally used to change the code? I installed add-on to eclipse to connect to SVN. After installing, when tried to connect to below link from Import -- Other -- Check out project from SVN, eclipse is crashing. Below link i used to connect to SVN: http://svn.apache.org/repos/asf/tomcat/trunk/ Can you help on this? regards, VIN On Fri, Feb 6, 2015 at 3:01 PM, Mark Thomas ma...@apache.org wrote: On 06/02/2015 07:46, Pravallika Peddi wrote: Thanks Mark. I downloaded the source code from trunk using svn. checked out version is: 1657747 I am able to build it and Tomcat is running successfully in my environment. Great. Can you help assign a bug or some assignment considering my skills so that i can start working? I can certainly provide you with some pointers for bugs you might want to get started on but ultimately what you work on - or if you work on anything at all - is up to you. If you haven't already you should read this: http://tomcat.apache.org/getinvolved.html My suggestions for places where you could get started are: https://issues.apache.org/bugzilla/show_bug.cgi?id=57021 https://issues.apache.org/bugzilla/show_bug.cgi?id=56438 Alternatively, take a look through the open bugs and pick one that looks interesting. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Hi
Thanks Chris for the information. Mark Chris: I have gone through one of the issues given by Mark: https://issues.apache.org/bugzilla/show_bug.cgi?id=57021 and found that this issue is fixed already. Steps i performed: 1) Download Tomcat 6.0 - 32 bit version and run it on 32-bit Windows platform. Tomcat Server started successfully using commands mentioned in issue. Stop the tomcat. Check the catalina.out folder and it has no error messages. Rename catalina.out file. 2) Download Tomcat 6.0-64 bit version and extract tcnative-dll and copy it on to 32-bit Tomcat folder. Start the Tomcat Server and check the catalina.out file. It has proper error message Feb 10, 2015 11:42:54 AM org.apache.catalina.core.AprLifecycleListener init INFO: The APR based Apache Tomcat Native library which allows optimal performance in production environments was not found on the java.library.path: and i did not observe any error in command line as mentioned in the issue. I attached both the catalina.out files for your reference. Even i checked the recent Trunk AppLifecycleListener.init() java method and did not find the source code that was mentioned in the issue. Hence i feel the issue is fixed. Please confirm so that i will close the issue. Regards, VIN On Mon, Feb 9, 2015 at 10:59 PM, Christopher Schultz ch...@christopherschultz.net wrote: Pravallika, On 2/9/15 7:01 AM, Pravallika Peddi wrote: Hi Mark, Finally, I am able to Import the Tomcat source project to Eclipse with minor compile errors.. I will work on one of the issues and let you know. If you use Eclipse, after you check-out from Subversion, do this: 1. Close the project from within Eclipse 2. Go to the command-line 3. Run the ant target ide-eclipse 4. Re-open the project in Eclipse This should configure everything for you -- especially the build path so that you don't have to go looking-around for everything. Welcome to the community. Hope that helps, -chris On Mon, Feb 9, 2015 at 3:04 PM, Pravallika Peddi reachme.va...@gmail.com wrote: Thanks for the reply Mark. What is the editor that is generally used to change the code? I installed add-on to eclipse to connect to SVN. After installing, when tried to connect to below link from Import -- Other -- Check out project from SVN, eclipse is crashing. Below link i used to connect to SVN: http://svn.apache.org/repos/asf/tomcat/trunk/ Can you help on this? regards, VIN On Fri, Feb 6, 2015 at 3:01 PM, Mark Thomas ma...@apache.org wrote: On 06/02/2015 07:46, Pravallika Peddi wrote: Thanks Mark. I downloaded the source code from trunk using svn. checked out version is: 1657747 I am able to build it and Tomcat is running successfully in my environment. Great. Can you help assign a bug or some assignment considering my skills so that i can start working? I can certainly provide you with some pointers for bugs you might want to get started on but ultimately what you work on - or if you work on anything at all - is up to you. If you haven't already you should read this: http://tomcat.apache.org/getinvolved.html My suggestions for places where you could get started are: https://issues.apache.org/bugzilla/show_bug.cgi?id=57021 https://issues.apache.org/bugzilla/show_bug.cgi?id=56438 Alternatively, take a look through the open bugs and pick one that looks interesting. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Hi
Pravallika, On 2/9/15 7:01 AM, Pravallika Peddi wrote: Hi Mark, Finally, I am able to Import the Tomcat source project to Eclipse with minor compile errors.. I will work on one of the issues and let you know. If you use Eclipse, after you check-out from Subversion, do this: 1. Close the project from within Eclipse 2. Go to the command-line 3. Run the ant target ide-eclipse 4. Re-open the project in Eclipse This should configure everything for you -- especially the build path so that you don't have to go looking-around for everything. Welcome to the community. Hope that helps, -chris On Mon, Feb 9, 2015 at 3:04 PM, Pravallika Peddi reachme.va...@gmail.com wrote: Thanks for the reply Mark. What is the editor that is generally used to change the code? I installed add-on to eclipse to connect to SVN. After installing, when tried to connect to below link from Import -- Other -- Check out project from SVN, eclipse is crashing. Below link i used to connect to SVN: http://svn.apache.org/repos/asf/tomcat/trunk/ Can you help on this? regards, VIN On Fri, Feb 6, 2015 at 3:01 PM, Mark Thomas ma...@apache.org wrote: On 06/02/2015 07:46, Pravallika Peddi wrote: Thanks Mark. I downloaded the source code from trunk using svn. checked out version is: 1657747 I am able to build it and Tomcat is running successfully in my environment. Great. Can you help assign a bug or some assignment considering my skills so that i can start working? I can certainly provide you with some pointers for bugs you might want to get started on but ultimately what you work on - or if you work on anything at all - is up to you. If you haven't already you should read this: http://tomcat.apache.org/getinvolved.html My suggestions for places where you could get started are: https://issues.apache.org/bugzilla/show_bug.cgi?id=57021 https://issues.apache.org/bugzilla/show_bug.cgi?id=56438 Alternatively, take a look through the open bugs and pick one that looks interesting. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org signature.asc Description: OpenPGP digital signature
Re: Hi
Hi Mark, Finally, I am able to Import the Tomcat source project to Eclipse with minor compile errors.. I will work on one of the issues and let you know. Regards, VIN On Mon, Feb 9, 2015 at 3:04 PM, Pravallika Peddi reachme.va...@gmail.com wrote: Thanks for the reply Mark. What is the editor that is generally used to change the code? I installed add-on to eclipse to connect to SVN. After installing, when tried to connect to below link from Import -- Other -- Check out project from SVN, eclipse is crashing. Below link i used to connect to SVN: http://svn.apache.org/repos/asf/tomcat/trunk/ Can you help on this? regards, VIN On Fri, Feb 6, 2015 at 3:01 PM, Mark Thomas ma...@apache.org wrote: On 06/02/2015 07:46, Pravallika Peddi wrote: Thanks Mark. I downloaded the source code from trunk using svn. checked out version is: 1657747 I am able to build it and Tomcat is running successfully in my environment. Great. Can you help assign a bug or some assignment considering my skills so that i can start working? I can certainly provide you with some pointers for bugs you might want to get started on but ultimately what you work on - or if you work on anything at all - is up to you. If you haven't already you should read this: http://tomcat.apache.org/getinvolved.html My suggestions for places where you could get started are: https://issues.apache.org/bugzilla/show_bug.cgi?id=57021 https://issues.apache.org/bugzilla/show_bug.cgi?id=56438 Alternatively, take a look through the open bugs and pick one that looks interesting. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Hi
Hello mark, Along what lines of development is tomcat looking for now? Thanking. You On 6 Feb 2015 15:01, Mark Thomas ma...@apache.org wrote: On 06/02/2015 07:46, Pravallika Peddi wrote: Thanks Mark. I downloaded the source code from trunk using svn. checked out version is: 1657747 I am able to build it and Tomcat is running successfully in my environment. Great. Can you help assign a bug or some assignment considering my skills so that i can start working? I can certainly provide you with some pointers for bugs you might want to get started on but ultimately what you work on - or if you work on anything at all - is up to you. If you haven't already you should read this: http://tomcat.apache.org/getinvolved.html My suggestions for places where you could get started are: https://issues.apache.org/bugzilla/show_bug.cgi?id=57021 https://issues.apache.org/bugzilla/show_bug.cgi?id=56438 Alternatively, take a look through the open bugs and pick one that looks interesting. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Hi
On 06/02/2015 07:46, Pravallika Peddi wrote: Thanks Mark. I downloaded the source code from trunk using svn. checked out version is: 1657747 I am able to build it and Tomcat is running successfully in my environment. Great. Can you help assign a bug or some assignment considering my skills so that i can start working? I can certainly provide you with some pointers for bugs you might want to get started on but ultimately what you work on - or if you work on anything at all - is up to you. If you haven't already you should read this: http://tomcat.apache.org/getinvolved.html My suggestions for places where you could get started are: https://issues.apache.org/bugzilla/show_bug.cgi?id=57021 https://issues.apache.org/bugzilla/show_bug.cgi?id=56438 Alternatively, take a look through the open bugs and pick one that looks interesting. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Hi
Thanks Mark. I downloaded the source code from trunk using svn. checked out version is: 1657747 I am able to build it and Tomcat is running successfully in my environment. Can you help assign a bug or some assignment considering my skills so that i can start working? Thanks, VIN On Thu, Feb 5, 2015 at 6:16 PM, Mark Thomas ma...@apache.org wrote: On 05/02/2015 09:57, Pravallika Peddi wrote: Hi Mark, Thanks for your reply. I downloaded the tomcat source code of apache-tomcat-8.0.18-src but not from the Trunk. I am able to build it and Tomcat is running successfully in my environment. OK. If you can build 8.0.x form source then building trunk from an svn checkout isn't that different. I do not know how to download the Trunk from SVN. Details are in reference [1] in my previous e-mail. You can either checkout from the ASF's svn server or clone the github mirror. Mark Thanks, VIN. On Thu, Feb 5, 2015 at 2:31 PM, Mark Thomas ma...@apache.org wrote: On 05/02/2015 08:56, Pravallika Peddi wrote: Hi, I am VIN and newly joined to the apache DEV community. I would like to contribute in development and bug fixing and chose Tomcat as my first project. I am good at core java technologies/Servlets. Can some one help me to guide? Welcome. The first task is to make sure you can build Tomcat. Have you checked out trunk (9.0.x). See [1]. Can you build a working Tomcat instance? Mark [1] http://tomcat.apache.org/svn.html - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Hi
On 05/02/2015 09:57, Pravallika Peddi wrote: Hi Mark, Thanks for your reply. I downloaded the tomcat source code of apache-tomcat-8.0.18-src but not from the Trunk. I am able to build it and Tomcat is running successfully in my environment. OK. If you can build 8.0.x form source then building trunk from an svn checkout isn't that different. I do not know how to download the Trunk from SVN. Details are in reference [1] in my previous e-mail. You can either checkout from the ASF's svn server or clone the github mirror. Mark Thanks, VIN. On Thu, Feb 5, 2015 at 2:31 PM, Mark Thomas ma...@apache.org wrote: On 05/02/2015 08:56, Pravallika Peddi wrote: Hi, I am VIN and newly joined to the apache DEV community. I would like to contribute in development and bug fixing and chose Tomcat as my first project. I am good at core java technologies/Servlets. Can some one help me to guide? Welcome. The first task is to make sure you can build Tomcat. Have you checked out trunk (9.0.x). See [1]. Can you build a working Tomcat instance? Mark [1] http://tomcat.apache.org/svn.html - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Hi
Hi, I am VIN and newly joined to the apache DEV community. I would like to contribute in development and bug fixing and chose Tomcat as my first project. I am good at core java technologies/Servlets. Can some one help me to guide? Thanks, Vin.
Re: Hi
On 05/02/2015 08:56, Pravallika Peddi wrote: Hi, I am VIN and newly joined to the apache DEV community. I would like to contribute in development and bug fixing and chose Tomcat as my first project. I am good at core java technologies/Servlets. Can some one help me to guide? Welcome. The first task is to make sure you can build Tomcat. Have you checked out trunk (9.0.x). See [1]. Can you build a working Tomcat instance? Mark [1] http://tomcat.apache.org/svn.html - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Hi
Hi Mark, Thanks for your reply. I downloaded the tomcat source code of apache-tomcat-8.0.18-src but not from the Trunk. I am able to build it and Tomcat is running successfully in my environment. I do not know how to download the Trunk from SVN. Thanks, VIN. On Thu, Feb 5, 2015 at 2:31 PM, Mark Thomas ma...@apache.org wrote: On 05/02/2015 08:56, Pravallika Peddi wrote: Hi, I am VIN and newly joined to the apache DEV community. I would like to contribute in development and bug fixing and chose Tomcat as my first project. I am good at core java technologies/Servlets. Can some one help me to guide? Welcome. The first task is to make sure you can build Tomcat. Have you checked out trunk (9.0.x). See [1]. Can you build a working Tomcat instance? Mark [1] http://tomcat.apache.org/svn.html - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53900] New: hi
https://issues.apache.org/bugzilla/show_bug.cgi?id=53900 Priority: P2 Bug ID: 53900 Assignee: dev@tomcat.apache.org Summary: hi Severity: normal Classification: Unclassified OS: Windows XP Reporter: ily.sncs...@gmail.com Hardware: PC Status: NEW Version: nightly Component: Application Taglib Product: Taglibs -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Bug 53900] hi
https://issues.apache.org/bugzilla/show_bug.cgi?id=53900 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Mark Thomas ma...@apache.org --- SPAM - user disabled. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Hi, a question about JspCompilationContext.isRemoved().
Dear developers of jasper,
I have a question about JspCompilationContext.isRemoved(). I think we should
check the file in file system instead of checking a counter.
In this method, we use a counter named ¡°removed¡± to determine if the JSP
file is in the file system.
public boolean isRemoved() {
if (removed 1 ) {
return true;
}
return false;
}
But I think there are two problems in above code.
1. We will always get a 404 page when we recover a JSP file after we delete
it and access it with browser. What cause it is because the counter is
increased in Compiler.isOutDated() when we try to access a deleted JSP file.
But the counter is only reset to 0 in JspCompilationContext.load(), which is
executed after the method isOutDated(). In another word, the method load()
is never reset to 0 once counter is set to 2.
2. We can access the page through browser successfully for two times after
we have deleted the relative JSP file in file system. Because condition is
¡°removed¡± is equal or larger than 2.
I think it may be better if we change the method in this way.
public boolean isRemoved() {
String jsp = getJspFile();
try {
URL jspUrl = getResource(jsp);
if (jspUrl == null) {
return true;
}
return false;
} catch (Exception e) {
e.printStackTrace();
return true;
}
}
Do you think it is a sound idea? Does it cause impact against other code?
Any help is appreciated.
Sean
_
Don't just search. Find. Check out the new MSN Search!
http://search.msn.click-url.com/go/onm00200636ave/direct/01/
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
