Re: Manager look and feel
On 26/08/2013 23:00, Caldarale, Charles R wrote: From: Larry Shatzer, Jr. [mailto:lar...@gmail.com] Subject: Re: Manager look and feel Maybe switching the manager application to use JSP for all presentation I don't think that should be done. Some sites may disable JSP capability, but still want to use the manager webapp. My instant reaction was +1. On reflection, the Manager does use JSP already for some aspects and no-one has complained to date. On that basis I have no objections to making greater use of JSPs. The current approach does support i18n and any switch to JSP would need to continue to do so to at least the same degree. The fall-back for sites that didn't want JSPs but wanted to use the manager would be to use the text based interface. I suppose one could pre-compile the JSP code, but that makes it harder for a site to customize the manager. - Chuck There is also work in progress to improve the docs and the Tomcat website. It would be preferable if there was a consistent look and feel between those and the manager app. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Manager look and feel
Hi i wonder for some times if tomcat GUI couldn't be externalized in another project. To be concrete i'm thinking to commons-monitoring (or the project which will replace it in incubator if we move it over incubator) Here is the current doc: http://commons.apache.org/sandbox/commons-monitoring/ Some screenshots are on this page: http://commons.apache.org/sandbox/commons-monitoring/reporting.html The gui is designed to be pluggable and i think tomcat could just be a plugin. It is still a young project (in sandbox) but all tomcat webapps features can go easily inside and all Apache projects could extend it to get something finally more consistent. wdyt? *Romain Manni-Bucau* *Twitter: @rmannibucau https://twitter.com/rmannibucau* *Blog: **http://rmannibucau.wordpress.com/*http://rmannibucau.wordpress.com/ *LinkedIn: **http://fr.linkedin.com/in/rmannibucau* *Github: https://github.com/rmannibucau* 2013/8/26 Larry Shatzer, Jr. lar...@gmail.com I was playing around with making the manager page look a bit more modern. (I see bug 55383, which is kinda related)... I whipped up a proof of concept with a static HTML page, using Bootstrap. I put it up on github, if anyone wanted to take a look: https://github.com/larrys/tomcat-manager-bootstrap I'm not a bootstrap/css guy, and just copied an example bootstrap template, and some of the areas on the page need a bit of work. I just wanted to get a quick proof of concept, and solicet feedback before I spent a lot of time on it. I was also wondering if there was a reason why the manager servlet has the HTML inlined in the Java code, instead of using JSPs? -- Larry
Re: Manager look and feel
gui is looking good. If you need help on the commons monitoring project let me know, I have some spare time. On Mon, Aug 26, 2013 at 4:16 PM, Romain Manni-Bucau rmannibu...@gmail.comwrote: Hi i wonder for some times if tomcat GUI couldn't be externalized in another project. To be concrete i'm thinking to commons-monitoring (or the project which will replace it in incubator if we move it over incubator) Here is the current doc: http://commons.apache.org/sandbox/commons-monitoring/ Some screenshots are on this page: http://commons.apache.org/sandbox/commons-monitoring/reporting.html The gui is designed to be pluggable and i think tomcat could just be a plugin. It is still a young project (in sandbox) but all tomcat webapps features can go easily inside and all Apache projects could extend it to get something finally more consistent. wdyt? *Romain Manni-Bucau* *Twitter: @rmannibucau https://twitter.com/rmannibucau* *Blog: **http://rmannibucau.wordpress.com/* http://rmannibucau.wordpress.com/ *LinkedIn: **http://fr.linkedin.com/in/rmannibucau* *Github: https://github.com/rmannibucau* 2013/8/26 Larry Shatzer, Jr. lar...@gmail.com I was playing around with making the manager page look a bit more modern. (I see bug 55383, which is kinda related)... I whipped up a proof of concept with a static HTML page, using Bootstrap. I put it up on github, if anyone wanted to take a look: https://github.com/larrys/tomcat-manager-bootstrap I'm not a bootstrap/css guy, and just copied an example bootstrap template, and some of the areas on the page need a bit of work. I just wanted to get a quick proof of concept, and solicet feedback before I spent a lot of time on it. I was also wondering if there was a reason why the manager servlet has the HTML inlined in the Java code, instead of using JSPs? -- Larry -- With Regards, Andrew Carr e. andrewlanec...@gmail.com w. andrew.c...@openlogic.com h. 4235255668 c. 4234708192 a. 101 Francis Drive, Greeneville, TN, 37743
Re: Manager look and feel
It would need to be updated to bootstrap 3 (but using a custom bootstrap 2 theme it is not as easy as replacing files) and maybe some basic components (graphs etc, atm there is no component libs) Le 26 août 2013 22:44, Andrew Carr andrewlanec...@gmail.com a écrit : gui is looking good. If you need help on the commons monitoring project let me know, I have some spare time. On Mon, Aug 26, 2013 at 4:16 PM, Romain Manni-Bucau rmannibu...@gmail.comwrote: Hi i wonder for some times if tomcat GUI couldn't be externalized in another project. To be concrete i'm thinking to commons-monitoring (or the project which will replace it in incubator if we move it over incubator) Here is the current doc: http://commons.apache.org/sandbox/commons-monitoring/ Some screenshots are on this page: http://commons.apache.org/sandbox/commons-monitoring/reporting.html The gui is designed to be pluggable and i think tomcat could just be a plugin. It is still a young project (in sandbox) but all tomcat webapps features can go easily inside and all Apache projects could extend it to get something finally more consistent. wdyt? *Romain Manni-Bucau* *Twitter: @rmannibucau https://twitter.com/rmannibucau* *Blog: **http://rmannibucau.wordpress.com/* http://rmannibucau.wordpress.com/ *LinkedIn: **http://fr.linkedin.com/in/rmannibucau* *Github: https://github.com/rmannibucau* 2013/8/26 Larry Shatzer, Jr. lar...@gmail.com I was playing around with making the manager page look a bit more modern. (I see bug 55383, which is kinda related)... I whipped up a proof of concept with a static HTML page, using Bootstrap. I put it up on github, if anyone wanted to take a look: https://github.com/larrys/tomcat-manager-bootstrap I'm not a bootstrap/css guy, and just copied an example bootstrap template, and some of the areas on the page need a bit of work. I just wanted to get a quick proof of concept, and solicet feedback before I spent a lot of time on it. I was also wondering if there was a reason why the manager servlet has the HTML inlined in the Java code, instead of using JSPs? -- Larry -- With Regards, Andrew Carr e. andrewlanec...@gmail.com w. andrew.c...@openlogic.com h. 4235255668 c. 4234708192 a. 101 Francis Drive, Greeneville, TN, 37743
Re: Manager look and feel
I like that Tomcat ships with a manager application bundled with it. If you need more functionality, you can look at psi probe https://code.google.com/p/psi-probe/, or write your own application that wraps the RESTish interface that the manager application provides. I just wish the default manager application was easier to theme, or tweak a few things. I resorted to a servlet filter at my $JOB to color a few things depending on the environment you are on (test vs prod, etc), along with a few other things. Commons Monitoring looks similar to https://code.google.com/p/javamelody/. -- Larry On Mon, Aug 26, 2013 at 2:16 PM, Romain Manni-Bucau rmannibu...@gmail.comwrote: Hi i wonder for some times if tomcat GUI couldn't be externalized in another project. To be concrete i'm thinking to commons-monitoring (or the project which will replace it in incubator if we move it over incubator) Here is the current doc: http://commons.apache.org/sandbox/commons-monitoring/ Some screenshots are on this page: http://commons.apache.org/sandbox/commons-monitoring/reporting.html The gui is designed to be pluggable and i think tomcat could just be a plugin. It is still a young project (in sandbox) but all tomcat webapps features can go easily inside and all Apache projects could extend it to get something finally more consistent. wdyt? *Romain Manni-Bucau* *Twitter: @rmannibucau https://twitter.com/rmannibucau* *Blog: **http://rmannibucau.wordpress.com/* http://rmannibucau.wordpress.com/ *LinkedIn: **http://fr.linkedin.com/in/rmannibucau* *Github: https://github.com/rmannibucau* 2013/8/26 Larry Shatzer, Jr. lar...@gmail.com I was playing around with making the manager page look a bit more modern. (I see bug 55383, which is kinda related)... I whipped up a proof of concept with a static HTML page, using Bootstrap. I put it up on github, if anyone wanted to take a look: https://github.com/larrys/tomcat-manager-bootstrap I'm not a bootstrap/css guy, and just copied an example bootstrap template, and some of the areas on the page need a bit of work. I just wanted to get a quick proof of concept, and solicet feedback before I spent a lot of time on it. I was also wondering if there was a reason why the manager servlet has the HTML inlined in the Java code, instead of using JSPs? -- Larry
Re: Manager look and feel
We talked about javamelody before hacking on it but it is different cause storage is pluggable (memory is implemented) and gui is designed as extensible (not really in jm). It integrates with cdi too (not jm.AFAIK). The main points are IMO easyness of extensibility (hawtio failed about it IMHO), default features and integration with Apache products (I hope TomEE will rely on it very soon) Le 26 août 2013 22:59, Larry Shatzer, Jr. lar...@gmail.com a écrit : I like that Tomcat ships with a manager application bundled with it. If you need more functionality, you can look at psi probe https://code.google.com/p/psi-probe/, or write your own application that wraps the RESTish interface that the manager application provides. I just wish the default manager application was easier to theme, or tweak a few things. I resorted to a servlet filter at my $JOB to color a few things depending on the environment you are on (test vs prod, etc), along with a few other things. Commons Monitoring looks similar to https://code.google.com/p/javamelody/. -- Larry On Mon, Aug 26, 2013 at 2:16 PM, Romain Manni-Bucau rmannibu...@gmail.comwrote: Hi i wonder for some times if tomcat GUI couldn't be externalized in another project. To be concrete i'm thinking to commons-monitoring (or the project which will replace it in incubator if we move it over incubator) Here is the current doc: http://commons.apache.org/sandbox/commons-monitoring/ Some screenshots are on this page: http://commons.apache.org/sandbox/commons-monitoring/reporting.html The gui is designed to be pluggable and i think tomcat could just be a plugin. It is still a young project (in sandbox) but all tomcat webapps features can go easily inside and all Apache projects could extend it to get something finally more consistent. wdyt? *Romain Manni-Bucau* *Twitter: @rmannibucau https://twitter.com/rmannibucau* *Blog: **http://rmannibucau.wordpress.com/* http://rmannibucau.wordpress.com/ *LinkedIn: **http://fr.linkedin.com/in/rmannibucau* *Github: https://github.com/rmannibucau* 2013/8/26 Larry Shatzer, Jr. lar...@gmail.com I was playing around with making the manager page look a bit more modern. (I see bug 55383, which is kinda related)... I whipped up a proof of concept with a static HTML page, using Bootstrap. I put it up on github, if anyone wanted to take a look: https://github.com/larrys/tomcat-manager-bootstrap I'm not a bootstrap/css guy, and just copied an example bootstrap template, and some of the areas on the page need a bit of work. I just wanted to get a quick proof of concept, and solicet feedback before I spent a lot of time on it. I was also wondering if there was a reason why the manager servlet has the HTML inlined in the Java code, instead of using JSPs? -- Larry
Re: Manager look and feel
Commons Monitoring is more comparable to Yammer Metrics than Java Melody. psi-probe/lambda-probe due to GPL nature can't be bundled with Tomcat, Commons Monitoring could. 2013/8/26 Larry Shatzer, Jr. lar...@gmail.com I like that Tomcat ships with a manager application bundled with it. If you need more functionality, you can look at psi probe https://code.google.com/p/psi-probe/, or write your own application that wraps the RESTish interface that the manager application provides. I just wish the default manager application was easier to theme, or tweak a few things. I resorted to a servlet filter at my $JOB to color a few things depending on the environment you are on (test vs prod, etc), along with a few other things. Commons Monitoring looks similar to https://code.google.com/p/javamelody/. -- Larry On Mon, Aug 26, 2013 at 2:16 PM, Romain Manni-Bucau rmannibu...@gmail.comwrote: Hi i wonder for some times if tomcat GUI couldn't be externalized in another project. To be concrete i'm thinking to commons-monitoring (or the project which will replace it in incubator if we move it over incubator) Here is the current doc: http://commons.apache.org/sandbox/commons-monitoring/ Some screenshots are on this page: http://commons.apache.org/sandbox/commons-monitoring/reporting.html The gui is designed to be pluggable and i think tomcat could just be a plugin. It is still a young project (in sandbox) but all tomcat webapps features can go easily inside and all Apache projects could extend it to get something finally more consistent. wdyt? *Romain Manni-Bucau* *Twitter: @rmannibucau https://twitter.com/rmannibucau* *Blog: **http://rmannibucau.wordpress.com/* http://rmannibucau.wordpress.com/ *LinkedIn: **http://fr.linkedin.com/in/rmannibucau* *Github: https://github.com/rmannibucau* 2013/8/26 Larry Shatzer, Jr. lar...@gmail.com I was playing around with making the manager page look a bit more modern. (I see bug 55383, which is kinda related)... I whipped up a proof of concept with a static HTML page, using Bootstrap. I put it up on github, if anyone wanted to take a look: https://github.com/larrys/tomcat-manager-bootstrap I'm not a bootstrap/css guy, and just copied an example bootstrap template, and some of the areas on the page need a bit of work. I just wanted to get a quick proof of concept, and solicet feedback before I spent a lot of time on it. I was also wondering if there was a reason why the manager servlet has the HTML inlined in the Java code, instead of using JSPs? -- Larry
Re: Manager look and feel
Larry, On 8/26/13 4:10 PM, Larry Shatzer, Jr. wrote: I was playing around with making the manager page look a bit more modern. (I see bug 55383, which is kinda related)... I whipped up a proof of concept with a static HTML page, using Bootstrap. I put it up on github, if anyone wanted to take a look: https://github.com/larrys/tomcat-manager-bootstrap I'm not a bootstrap/css guy, and just copied an example bootstrap template, and some of the areas on the page need a bit of work. I just wanted to get a quick proof of concept, and solicet feedback before I spent a lot of time on it. Would you be willing to produce some patches for Tomcat? (Either that or teach me how to take stuff from github and apply it to Tomcat sources). Note that the manager application really should not have any external dependencies (e.g. Bootstrap source files loaded remotely) so we may need to include some of their sources (yay! AL2.0!), or structure things so that they look okay out of the box, but great if you install the Bootstrap stuff yourself. The reason we can't just refer to twitter.com/bootstrap/main.js (or whatever) is because not everyone exposes their Tomcat installation to the Internet. I was also wondering if there was a reason why the manager servlet has the HTML inlined in the Java code, instead of using JSPs? As dumb as it sounds this was probably done to limit the number of moving parts in the manager application. IMHO, the manager application (nay, all Tomcat-bundled applications) should be an example of clean design and implementation using the appropriate technologies at hand. -chris signature.asc Description: OpenPGP digital signature
Re: Manager look and feel
Christopher, On Mon, Aug 26, 2013 at 3:32 PM, Christopher Schultz ch...@christopherschultz.net wrote: Larry, On 8/26/13 4:10 PM, Larry Shatzer, Jr. wrote: I was playing around with making the manager page look a bit more modern. (I see bug 55383, which is kinda related)... I whipped up a proof of concept with a static HTML page, using Bootstrap. I put it up on github, if anyone wanted to take a look: https://github.com/larrys/tomcat-manager-bootstrap I'm not a bootstrap/css guy, and just copied an example bootstrap template, and some of the areas on the page need a bit of work. I just wanted to get a quick proof of concept, and solicet feedback before I spent a lot of time on it. Would you be willing to produce some patches for Tomcat? (Either that or teach me how to take stuff from github and apply it to Tomcat sources). Note that the manager application really should not have any external dependencies (e.g. Bootstrap source files loaded remotely) so we may need to include some of their sources (yay! AL2.0!), or structure things so that they look okay out of the box, but great if you install the Bootstrap stuff yourself. The reason we can't just refer to twitter.com/bootstrap/main.js (or whatever) is because not everyone exposes their Tomcat installation to the Internet. I'm not opposed to distilling the sample HTML code I provided into the HTMLManager servlet, if that is a direction that is desirable. If you just wanted to look at the proof of concept, you can download a zip of it, and just load the index.html in a browser. ( https://github.com/larrys/tomcat-manager-bootstrap/archive/master.zip) It is just a standalone HTML page that represents what I think one possible update to the manager GUI could be, using bootstrap. I wanted to avoid changing code, and have a quicker feedback cycle on the look and feel in just static HTML. I also never intended to have it load an external resource for Bootstrap stuff. I was also wondering if there was a reason why the manager servlet has the HTML inlined in the Java code, instead of using JSPs? As dumb as it sounds this was probably done to limit the number of moving parts in the manager application. IMHO, the manager application (nay, all Tomcat-bundled applications) should be an example of clean design and implementation using the appropriate technologies at hand. I think updating the look and feel should be done outside of any switch to use JSP, to keep the two changes somewhat independent. Maybe switching the manager application to use JSP for all presentation, while still using the servlets below for the heavy lifting of deploying, should be done first. Then updating the look and feel should be easier. -- Larry
RE: Manager look and feel
From: Larry Shatzer, Jr. [mailto:lar...@gmail.com] Subject: Re: Manager look and feel Maybe switching the manager application to use JSP for all presentation I don't think that should be done. Some sites may disable JSP capability, but still want to use the manager webapp. I suppose one could pre-compile the JSP code, but that makes it harder for a site to customize the manager. - Chuck THIS COMMUNICATION MAY CONTAIN CONFIDENTIAL AND/OR OTHERWISE PROPRIETARY MATERIAL and is thus for use only by the intended recipient. If you received this in error, please contact the sender and delete the e-mail and its attachments from all computers. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: Manager look and feel
On Mon, Aug 26, 2013 at 4:00 PM, Caldarale, Charles R chuck.caldar...@unisys.com wrote: From: Larry Shatzer, Jr. [mailto:lar...@gmail.com] Subject: Re: Manager look and feel Maybe switching the manager application to use JSP for all presentation I don't think that should be done. Some sites may disable JSP capability, but still want to use the manager webapp. I suppose one could pre-compile the JSP code, but that makes it harder for a site to customize the manager. Right now it is hard to customize the manager at all. All the presentation logic is inside the servlet. I had to do a round about hack to modify the HTML through a servlet filter, which is pretty brittle. It wouldn't be too hard to provide an ant script or something that allowed you to take the manager webapp, compile it, and use the precompiled JSP version, for those specific scenarios where you want to totally disable JSP. -- Larry
