Re: pooledconnection & tccl?

2012-08-27 Thread Christopher Schultz
Filip,

On 8/22/12 9:12 AM, Filip Hanik (mailing lists) wrote:
> I've thought about this, you see if it is using TCCL it will cause a memory
> leak on app reload as the app wont be unloaded due to the pool holding it.
> But I think we should make it an option

It's always been my position that DataSources created due to webapp
configuration (e.g. /) ought to be cleaned-up on
webapp undeploy, but there hasn't seemed to be much interest in that.

-chris



signature.asc
Description: OpenPGP digital signature


RE: pooledconnection & tccl?

2012-08-22 Thread Filip Hanik (mailing lists)
I've thought about this, you see if it is using TCCL it will cause a memory
leak on app reload as the app wont be unloaded due to the pool holding it.
But I think we should make it an option

Best
Filip

> -Original Message-
> From: Romain Manni-Bucau [mailto:rmannibu...@gmail.com]
> Sent: Wednesday, August 22, 2012 3:14 AM
> To: Tomcat Developers List
> Subject: Re: pooledconnection & tccl?
> 
> if the resource is an app resource it should be closed with the stop()
> and
> recreated with the start
> 
> *Romain Manni-Bucau*
> *Twitter: @rmannibucau*
> *Blog: http://rmannibucau.wordpress.com*
> 
> 
> 
> 
> 2012/8/22 Pid * 
> 
> > On 19 Aug 2012, at 19:11, Romain Manni-Bucau 
> > wrote:
> >
> > > Hi,
> > >
> > > org.apache.tomcat.jdbc.pool.PooledConnection#connectUsingDriver uses
> > tomcat
> > > classloader to create the driver, couldn't it be the TCCL?
> > >
> > > this way it could allow to provide the driver in the webapp.
> >
> > What would happen if the app is reloaded?
> >
> >
> > p
> >
> >
> >
> >
> > >
> > > *Romain Manni-Bucau*
> > > *Twitter: @rmannibucau*
> > > *Blog: http://rmannibucau.wordpress.com*
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> > For additional commands, e-mail: dev-h...@tomcat.apache.org
> >
> >


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: pooledconnection & tccl?

2012-08-22 Thread Romain Manni-Bucau
if the resource is an app resource it should be closed with the stop() and
recreated with the start

*Romain Manni-Bucau*
*Twitter: @rmannibucau*
*Blog: http://rmannibucau.wordpress.com*




2012/8/22 Pid * 

> On 19 Aug 2012, at 19:11, Romain Manni-Bucau 
> wrote:
>
> > Hi,
> >
> > org.apache.tomcat.jdbc.pool.PooledConnection#connectUsingDriver uses
> tomcat
> > classloader to create the driver, couldn't it be the TCCL?
> >
> > this way it could allow to provide the driver in the webapp.
>
> What would happen if the app is reloaded?
>
>
> p
>
>
>
>
> >
> > *Romain Manni-Bucau*
> > *Twitter: @rmannibucau*
> > *Blog: http://rmannibucau.wordpress.com*
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>


Re: pooledconnection & tccl?

2012-08-22 Thread Pid *
On 19 Aug 2012, at 19:11, Romain Manni-Bucau  wrote:

> Hi,
>
> org.apache.tomcat.jdbc.pool.PooledConnection#connectUsingDriver uses tomcat
> classloader to create the driver, couldn't it be the TCCL?
>
> this way it could allow to provide the driver in the webapp.

What would happen if the app is reloaded?


p




>
> *Romain Manni-Bucau*
> *Twitter: @rmannibucau*
> *Blog: http://rmannibucau.wordpress.com*

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org