Re: [VOTE] Release Apache Tomcat 9.0.0.M19

[Rainer Jung]

Am 11.04.2017 um 13:47 schrieb Mark Thomas:

On 30/03/17 20:35, Rainer Jung wrote:




  - Exceptions: the biggest difference is more NullPointerException
(about 32 new ones). They seem to happen after the stop was issued and
only for apr and nio, not for nio2. Two cases:
- org.apache.coyote.http11.Http11Processor.endRequest Error
finishing response (20 times)




I've got to the bottom of what is causing this. I'm still investigating
potential solutions.

What happens is:
- request processing thread writes the response
- main thread reads response and ends the test
- ending the test stops the Tomcat instance
- that eventually calls stop on the endpoint
- the endpoint stops the poller
- the poller times out any open connections
- timing out the connection recycles the MappingData
- all of this happens before the request processing thread gets as far
  as line 393 in the CoyoteAdapter

and that triggers the NPE.


Thanks for investigating and letting us know! I saw your new Null checks 
in CoyoteAdapter.


Regards,

Rainer


at
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:393)
at
org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:498)
at
org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66)

at
org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:796)


Line 393 is:

request.getMappingData().context.logAccess(request, response,
System.currentTimeMillis() - req.getStartTime(), false);




Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 9.0.0.M19

[Mark Thomas]

On 30/03/17 20:35, Rainer Jung wrote:



>   - Exceptions: the biggest difference is more NullPointerException
> (about 32 new ones). They seem to happen after the stop was issued and
> only for apr and nio, not for nio2. Two cases:
> - org.apache.coyote.http11.Http11Processor.endRequest Error
> finishing response (20 times)



I've got to the bottom of what is causing this. I'm still investigating
potential solutions.

What happens is:
- request processing thread writes the response
- main thread reads response and ends the test
- ending the test stops the Tomcat instance
- that eventually calls stop on the endpoint
- the endpoint stops the poller
- the poller times out any open connections
- timing out the connection recycles the MappingData
- all of this happens before the request processing thread gets as far
  as line 393 in the CoyoteAdapter

and that triggers the NPE.

> at
> org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:393)
> at
> org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:498)
> at
> org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66)
> 
> at
> org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:796)
> 
> 
> Line 393 is:
> 
> request.getMappingData().context.logAccess(request, response,
> System.currentTimeMillis() - req.getStartTime(), false);



Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 9.0.0.M19

[Rainer Jung]

Am 27.03.2017 um 14:56 schrieb Mark Thomas:

The proposed Apache Tomcat 9.0.0.M19 release is now available for voting.

This is a milestone release for the 9.0.x branch. It should be
noted that, as a milestone release:
- Servlet 4.0 is not finalised
- The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0

The major changes compared to the 9.0.0.M18 release are:

- Various HTTP/2 improvements

- Fixes for sendfile related issues that could cause subsequent requests
  to experience IllegalStateExceptions

- Servlet 4.0 updates


Along with lots of other bug fixes and improvements

For full details, see the changelog:
http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M19/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1125/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M19/

The proposed 9.0.0.M19 release is:
[ ] Broken - do not release
[X] Alpha - go ahead and release as 9.0.0.M19


I know the vote is over but for the sake of completeness:

+1 to release as alpha.

Please see below for some details on increased number of NPE during 
shutdown.


Details
===

- SHA1 and MD5 OK
- signatures OK
- key in KEYS file
- gz and zip for src and bin consistent
- src consistent with svn tag
  - except bin shell scripts are not executable in src tarball
(not critical)
- builds fine
- build result looks consistent with binaries
- no checkstyle complaints
- no Javadoc warnings
- Unit tests: No failures

  - WARN messages:
- some message that were logged in M17 by localhost-startStop-1
  are now logged by main
- the message "[main] 
org.apache.tomcat.util.net.Nio2Endpoint.shutdownExecutor The executor 
associated with thread pool [http-nio2-127.0.0.1-auto-I] has not fully 
shutdown. Some application threads may still be running." (6 times) is 
now gone
- the message 
"org.apache.catalina.loader.WebappClassLoaderBase.clearReferencesThreads 
The web application [ROOT] is still processing a request that has yet to 
finish. This is very likely to create a memory leak. You can control the 
time allowed for requests to finish by using the unloadDelay attribute 
of the standard Context implementation. Stack trace of request 
processing thread:" reduced from 18 times to 3 times

- more Tribes warnings (46 versus 72)
- more Tribes errors (7 versus 12)

  - SEVERE message
- more "org.apache.coyote.http11.Http11Processor.service Error 
processing request" (apr 3 versus 6, nio 3 versus 10)
- more "org.apache.coyote.http11.Http11Processor.endRequest Error 
finishing response" (apr 1 versus 7, nio 1 versus 13)
- more 
"org.apache.coyote.AbstractProtocol$ConnectionHandler.process Error 
reading request, ignored" (apr 4 versus 6)
- new message "org.apache.catalina.core.StandardWrapperValve.invoke 
Servlet.service() for servlet [jsp] in context with path [/test] threw 
exception [Page-encoding specified in XML prolog (ISO-8859-1) is 
different from that specified in jsp-property-group (UTF-8)] with root 
cause" (one for apr, nio and nio2)
- less "org.apache.catalina.connector.CoyoteAdapter.asyncDispatch 
Exception while processing an asynchronous request" (nio2 1 versus 0)
- no more "org.apache.catalina.core.StandardWrapperValve.invoke 
Servlet.service() for servlet [simple] in context with path [] threw 
exception"
- much less "org.apache.catalina.core.StandardHostValve.invoke 
Exception Processing /simple" (apr, nio and nio2 5 each versus now only 
one for nio)


  - Exceptions: the biggest difference is more NullPointerException 
(about 32 new ones). They seem to happen after the stop was issued and 
only for apr and nio, not for nio2. Two cases:
- org.apache.coyote.http11.Http11Processor.endRequest Error 
finishing response (20 times)


Stack

at 
org.apache.coyote.http11.Http11OutputBuffer.commit(Http11OutputBuffer.java:329) 

at 
org.apache.coyote.http11.Http11Processor.prepareResponse(Http11Processor.java:1000) 


at org.apache.coyote.AbstractProcessor.action(AbstractProcessor.java:258)
at 
org.apache.coyote.http11.Http11Processor.endRequest(Http11Processor.java:1169)


Line 329 is:

socketWrapper.write(isBlocking(), headerBuffer);

Tests with this NPE (maybe it varies):

nio org.apache.catalina.connector.TestRequest [testBug57215f]
nio org.apache.catalina.core.TestApplicationContext [testBug53467]
nio org.apache.catalina.core.TestStandardContextResources 
[testResourcesWebInfClasses]

nio org.apache.catalina.mbeans.TestRegistration [testMBeanDeregistration]
nio org.apache.catalina.startup.TestTomcat [testJsps]
nio org.apache.catalina.startup.TestTomcatClassLoader 
[testDefaultClassLoader]

nio org.apache.el.TestELInJsp [testBug46596]
nio org.apache.jasper.compiler.TestEncodingDetector [testEncodedJsp[1]]
nio org.apache.jasper.compiler.TestEncodingDetector 

Re: [VOTE] Release Apache Tomcat 9.0.0.M19

[Mark Thomas]

On 27/03/17 13:56, Mark Thomas wrote:
> The proposed 9.0.0.M19 release is:
> [ ] Broken - do not release
> [X] Alpha - go ahead and release as 9.0.0.M19

Unit tests pass for NIO, NIo2 and APR/native (1.2.12) on Windows, Linux
and OSX.

Mark


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 9.0.0.M19

[Keiichi Fujino]

2017-03-27 21:56 GMT+09:00 Mark Thomas :

> The proposed Apache Tomcat 9.0.0.M19 release is now available for voting.
>
> This is a milestone release for the 9.0.x branch. It should be
> noted that, as a milestone release:
> - Servlet 4.0 is not finalised
> - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0
>
> The major changes compared to the 9.0.0.M18 release are:
>
> - Various HTTP/2 improvements
>
> - Fixes for sendfile related issues that could cause subsequent requests
>   to experience IllegalStateExceptions
>
> - Servlet 4.0 updates
>
>
> Along with lots of other bug fixes and improvements
>
> For full details, see the changelog:
> http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M19/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1125/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M19/
>
> The proposed 9.0.0.M19 release is:
> [ ] Broken - do not release
> [X] Alpha - go ahead and release as 9.0.0.M19
>
>
+1
Tested on some test applications (use jdbc-pool).



> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
> --
> Keiichi.Fujino
> 

Re: [VOTE] Release Apache Tomcat 9.0.0.M19

[Felix Schumacher]

Am 27. März 2017 14:56:41 MESZ schrieb Mark Thomas :
>The proposed Apache Tomcat 9.0.0.M19 release is now available for
>voting.
>
>This is a milestone release for the 9.0.x branch. It should be
>noted that, as a milestone release:
>- Servlet 4.0 is not finalised
>- The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0
>
>The major changes compared to the 9.0.0.M18 release are:
>
>- Various HTTP/2 improvements
>
>- Fixes for sendfile related issues that could cause subsequent
>requests
>  to experience IllegalStateExceptions
>
>- Servlet 4.0 updates
>
>
>Along with lots of other bug fixes and improvements
>
>For full details, see the changelog:
>http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
>
>It can be obtained from:
>https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M19/
>The Maven staging repo is:
>https://repository.apache.org/content/repositories/orgapachetomcat-1125/
>The svn tag is:
>http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M19/
>
>The proposed 9.0.0.M19 release is:
>[ ] Broken - do not release
>[x] Alpha - go ahead and release as 9.0.0.M19

Felix

>
>-
>To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>For additional commands, e-mail: dev-h...@tomcat.apache.org

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 9.0.0.M19

[Martin Grigorov]

On Mon, Mar 27, 2017 at 2:56 PM, Mark Thomas  wrote:

> The proposed Apache Tomcat 9.0.0.M19 release is now available for voting.
>
> This is a milestone release for the 9.0.x branch. It should be
> noted that, as a milestone release:
> - Servlet 4.0 is not finalised
> - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0
>
> The major changes compared to the 9.0.0.M18 release are:
>
> - Various HTTP/2 improvements
>
> - Fixes for sendfile related issues that could cause subsequent requests
>   to experience IllegalStateExceptions
>
> - Servlet 4.0 updates
>
>
> Along with lots of other bug fixes and improvements
>
> For full details, see the changelog:
> http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M19/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1125/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M19/
>
> The proposed 9.0.0.M19 release is:
> [ ] Broken - do not release
> [ X ] Alpha - go ahead and release as 9.0.0.M19
>

Regards,
Martin


>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: [VOTE] Release Apache Tomcat 9.0.0.M19

[Rémy Maucherat]

2017-03-27 14:56 GMT+02:00 Mark Thomas :

> The proposed Apache Tomcat 9.0.0.M19 release is now available for voting.
>
> This is a milestone release for the 9.0.x branch. It should be
> noted that, as a milestone release:
> - Servlet 4.0 is not finalised
> - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0
>
> The major changes compared to the 9.0.0.M18 release are:
>
> - Various HTTP/2 improvements
>
> - Fixes for sendfile related issues that could cause subsequent requests
>   to experience IllegalStateExceptions
>
> - Servlet 4.0 updates
>
>
> Along with lots of other bug fixes and improvements
>
> For full details, see the changelog:
> http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M19/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1125/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M19/
>
> The proposed 9.0.0.M19 release is:
> [ ] Broken - do not release
> [X] Alpha - go ahead and release as 9.0.0.M19
>
> Rémy

Re: [VOTE] Release Apache Tomcat 9.0.0.M19

[Violeta Georgieva]

Hi,

2017-03-27 15:56 GMT+03:00 Mark Thomas :
>
> The proposed Apache Tomcat 9.0.0.M19 release is now available for voting.
>
> This is a milestone release for the 9.0.x branch. It should be
> noted that, as a milestone release:
> - Servlet 4.0 is not finalised
> - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0
>
> The major changes compared to the 9.0.0.M18 release are:
>
> - Various HTTP/2 improvements
>
> - Fixes for sendfile related issues that could cause subsequent requests
>   to experience IllegalStateExceptions
>
> - Servlet 4.0 updates
>
>
> Along with lots of other bug fixes and improvements
>
> For full details, see the changelog:
> http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M19/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1125/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M19/
>
> The proposed 9.0.0.M19 release is:
> [ ] Broken - do not release
[X] Alpha - go ahead and release as 9.0.0.M19

Regards,
Violeta

>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>